bmad-plus 0.16.0 → 0.17.1

package/tools/build/generate-adapters.js

@@ -43,7 +43,12 @@
 const fs = require('node:fs');
 const path = require('node:path');
 const { loadRegistry, buildDerived, DEFAULT_REGISTRY_PATH } = require('./generate');
-const { PROJECT_INSTRUCTIONS, MEMORY_INSTRUCTIONS, UPDATE_INSTRUCTIONS, TOOL_METADATA } = require('./adapters.config');
+const {
+  PROJECT_INSTRUCTIONS,
+  MEMORY_INSTRUCTIONS,
+  UPDATE_INSTRUCTIONS,
+  TOOL_METADATA,
+} = require('./adapters.config');
 
 const DEFAULT_OUT_DIR = path.join(__dirname, 'generated-adapters');
 const REPO_ROOT = path.join(__dirname, '..', '..');
@@ -108,7 +113,13 @@ function validateTargets(registry) {
     throw new Error('registry.yaml: targets.adapters must be a non-empty list');
   }
   t.adapters.forEach((a, i) => {
-    if (!a || typeof a.tool !== 'string' || a.tool === '' || typeof a.file !== 'string' || a.file === '') {
+    if (
+      !a ||
+      typeof a.tool !== 'string' ||
+      a.tool === '' ||
+      typeof a.file !== 'string' ||
+      a.file === ''
+    ) {
       throw new Error(`registry.yaml: targets.adapters[${i}] must have string "tool" and "file"`);
     }
     validateRelativeFile(a.file);
@@ -118,13 +129,19 @@ function validateTargets(registry) {
 
 /** Convert the canonical derivation into the adapter presentation shape. */
 function factsFromDerived(derived, packs = derived.packOrder) {
-  const selected = packs.map(id => {
+  const selected = packs.map((id) => {
     const pack = derived.packs[id];
     return {
-      id, name: pack.name, displayName: pack.displayName, desc: pack.desc,
-      required: pack.required, agentCount: pack.installerAgentCount,
-      categoryAgentCount: pack.categoryAgentCount, subAgentCount: pack.subAgentCount,
-      workflowCount: pack.workflowCount, frameworkCount: pack.frameworkCount,
+      id,
+      name: pack.name,
+      displayName: pack.displayName,
+      desc: pack.desc,
+      required: pack.required,
+      agentCount: pack.installerAgentCount,
+      categoryAgentCount: pack.categoryAgentCount,
+      subAgentCount: pack.subAgentCount,
+      workflowCount: pack.workflowCount,
+      frameworkCount: pack.frameworkCount,
       personas: pack.personas,
     };
   });
@@ -133,9 +150,10 @@ function factsFromDerived(derived, packs = derived.packOrder) {
     spine: derived.targets.spine,
     modelsSupported: derived.targets.models_supported,
     packCount: selected.length,
-    installerAgentCount: packs.length === derived.packOrder.length
-      ? derived.installerAgents
-      : selected.reduce((total, pack) => total + pack.agentCount, 0),
+    installerAgentCount:
+      packs.length === derived.packOrder.length
+        ? derived.installerAgents
+        : selected.reduce((total, pack) => total + pack.agentCount, 0),
     packs: selected,
   };
 }
@@ -153,8 +171,15 @@ function renderRoster(facts) {
       const identity = persona.alias
         ? '(' + persona.alias + ') — ' + persona.role
         : '(' + persona.role + ')';
-      lines.push('- **' + persona.name + '** ' + identity + ' — ' + persona.description +
-        (pack.required ? '' : ' (' + pack.name + ')'));
+      lines.push(
+        '- **' +
+          persona.name +
+          '** ' +
+          identity +
+          ' — ' +
+          persona.description +
+          (pack.required ? '' : ' (' + pack.name + ')')
+      );
     }
   }
   return lines;
@@ -346,40 +371,66 @@ function generateAllFiles(registry) {
 /** Installable tools and paths come from the registry; only detection is local. */
 function buildIDEConfigs(derived) {
   validateTargets({ targets: derived.targets });
-  return Object.fromEntries(derived.targets.adapters.map(({ tool, file }) => [
-    tool, { name: TOOL_METADATA[tool]?.name || tool, configFile: file,
-      detect: [...(TOOL_METADATA[tool]?.detect || [])] },
-  ]));
+  return Object.fromEntries(
+    derived.targets.adapters.map(({ tool, file }) => [
+      tool,
+      {
+        name: TOOL_METADATA[tool]?.name || tool,
+        configFile: file,
+        detect: [...(TOOL_METADATA[tool]?.detect || [])],
+      },
+    ])
+  );
 }
 
 function selectedPacks(derived, packs) {
-  if (packs !== undefined && !Array.isArray(packs)) throw new Error('packs must be an array of pack IDs');
+  if (packs !== undefined && !Array.isArray(packs))
+    throw new Error('packs must be an array of pack IDs');
   const selected = new Set(packs === undefined ? derived.packOrder : packs);
   for (const id of selected) {
     if (!Object.hasOwn(derived.packs, id)) throw new Error('Unknown pack: ' + id);
   }
   for (const id of derived.packOrder) if (derived.packs[id].required) selected.add(id);
-  return derived.packOrder.filter(id => selected.has(id));
+  return derived.packOrder.filter((id) => selected.has(id));
 }
 
 function renderUserSections(derived, { packs, userName = 'Developer', language = 'English' } = {}) {
   const ids = selectedPacks(derived, packs);
   const facts = factsFromDerived(derived, ids);
   const lines = [
-    '## Project Context', '',
-    'This project uses ' + facts.product.displayName + ', an augmented AI-driven development framework.',
-    'Based on ' + facts.product.derivedFrom + ' with multi-role agents, autopilot mode, and parallel execution.',
-    '', ...renderRoster(facts), '',
-    '## Skills', '',
+    '## Project Context',
+    '',
+    'This project uses ' +
+      facts.product.displayName +
+      ', an augmented AI-driven development framework.',
+    'Based on ' +
+      facts.product.derivedFrom +
+      ' with multi-role agents, autopilot mode, and parallel execution.',
+    '',
+    ...renderRoster(facts),
+    '',
+    '## Skills',
+    '',
     '- Load skills from `.agents/skills/`.',
     '- Each agent has a SKILL.md with capabilities, activation protocol, and role-switching rules.',
     '- Auto-activation triggers: `.agents/data/role-triggers.yaml`.',
-    '', '## Communication', '',
+    '',
+    '## Communication',
+    '',
     '- User name: ' + String(userName).replace(/[\r\n]/g, ' '),
-    '- Default language: ' + String(language).replace(/[\r\n]/g, ' ') + ' for user-facing content, English for code and technical docs.',
+    '- Default language: ' +
+      String(language).replace(/[\r\n]/g, ' ') +
+      ' for user-facing content, English for code and technical docs.',
   ];
   if (ids.includes('memory')) lines.push('', ...MEMORY_INSTRUCTIONS);
-  lines.push('', ...UPDATE_INSTRUCTIONS, '', ...renderFactsSection(facts), '', ...renderKeyCommands());
+  lines.push(
+    '',
+    ...UPDATE_INSTRUCTIONS,
+    '',
+    ...renderFactsSection(facts),
+    '',
+    ...renderKeyCommands()
+  );
   return lines;
 }
 
@@ -395,36 +446,61 @@ function userMarkerLines() {
 function renderUserConfig(derived, options = {}) {
   validateTargets({ targets: derived.targets });
   return [
-    ...userMarkerLines(), '',
-    '# ' + derived.product.displayName + ' — Agent Spine', '',
-    'This file is the common project instruction spine for the installed ' + derived.product.displayName + ' tools.', '',
-    ...renderUserSections(derived, options), '',
+    ...userMarkerLines(),
+    '',
+    '# ' + derived.product.displayName + ' — Agent Spine',
+    '',
+    'This file is the common project instruction spine for the installed ' +
+      derived.product.displayName +
+      ' tools.',
+    '',
+    ...renderUserSections(derived, options),
+    '',
   ].join('\n');
 }
 
 /** Pure render of the common spine and every selected registry adapter. */
 function generateUserFiles(derived, options = {}) {
   validateTargets({ targets: derived.targets });
-  const available = derived.targets.adapters.map(adapter => adapter.tool);
+  const available = derived.targets.adapters.map((adapter) => adapter.tool);
   const requested = options.tools === undefined ? available : options.tools;
   if (!Array.isArray(requested)) throw new Error('tools must be an array of tool IDs');
   for (const tool of requested) {
     if (!available.includes(tool)) throw new Error('Unknown tool: ' + tool);
   }
-  const targets = { ...derived.targets,
-    adapters: derived.targets.adapters.filter(adapter => requested.includes(adapter.tool)) };
-  const files = [{ file: targets.spine, tools: ['spine'], spine: true,
-    content: renderUserConfig(derived, options) }];
+  const targets = {
+    ...derived.targets,
+    adapters: derived.targets.adapters.filter((adapter) => requested.includes(adapter.tool)),
+  };
+  const files = [
+    {
+      file: targets.spine,
+      tools: ['spine'],
+      spine: true,
+      content: renderUserConfig(derived, options),
+    },
+  ];
   for (const { file, tools } of groupAdaptersByFile({ targets })) {
     if (file === targets.spine) continue;
     const reference = path.posix.relative(path.posix.dirname(file), targets.spine);
     const lines = [];
-    if (file.endsWith('.mdc')) lines.push('---',
-      'description: "' + derived.product.displayName + ' agents adapter"', 'alwaysApply: true', '---', '');
-    lines.push(...userMarkerLines(), '',
-      '# ' + derived.product.displayName + ' — Adapter for ' + tools.join(' + '), '',
+    if (file.endsWith('.mdc'))
+      lines.push(
+        '---',
+        'description: "' + derived.product.displayName + ' agents adapter"',
+        'alwaysApply: true',
+        '---',
+        ''
+      );
+    lines.push(
+      ...userMarkerLines(),
+      '',
+      '# ' + derived.product.displayName + ' — Adapter for ' + tools.join(' + '),
+      '',
       'Read the project spine first: [' + targets.spine + '](' + reference + ').',
-      'Paths in the shared project instructions below are relative to the project root.', '');
+      'Paths in the shared project instructions below are relative to the project root.',
+      ''
+    );
     for (const tool of tools) {
       lines.push('## Tool notes — ' + tool, '');
       for (const note of TOOL_NOTES[tool] || buildDefaultNotes(tool, file)) lines.push('- ' + note);
@@ -438,8 +514,14 @@ function generateUserFiles(derived, options = {}) {
 
 /** Refuse portable-path escapes even when generated input has been modified. */
 function validateRelativeFile(file) {
-  if (typeof file !== 'string' || !file || /[\\:]/.test(file) || file.includes('\0') ||
-      path.posix.isAbsolute(file) || file.split('/').some(part => !part || part === '.' || part === '..')) {
+  if (
+    typeof file !== 'string' ||
+    !file ||
+    /[\\:]/.test(file) ||
+    file.includes('\0') ||
+    path.posix.isAbsolute(file) ||
+    file.split('/').some((part) => !part || part === '.' || part === '..')
+  ) {
     throw new Error('Adapter file must be a relative project path: ' + file);
   }
 }
@@ -450,20 +532,30 @@ function safeTarget(outDir, file) {
   const root = path.resolve(outDir);
   const target = path.resolve(root, file);
   const relative = path.relative(root, target);
-  if (!relative || relative === '..' || relative.startsWith('..' + path.sep) || path.isAbsolute(relative)) {
+  if (
+    !relative ||
+    relative === '..' ||
+    relative.startsWith('..' + path.sep) ||
+    path.isAbsolute(relative)
+  ) {
     throw new Error('Adapter path escapes the target project: ' + file);
   }
   let current = path.parse(target).root;
   for (const part of target.slice(current.length).split(path.sep)) {
     current = path.join(current, part);
     let stat;
-    try { stat = fs.lstatSync(current); } catch (error) {
+    try {
+      stat = fs.lstatSync(current);
+    } catch (error) {
       if (error.code === 'ENOENT') break;
       throw error;
     }
-    if (stat.isSymbolicLink()) throw new Error('Adapter path contains a symlink or junction: ' + current);
-    if (current === target && !stat.isFile()) throw new Error('Adapter target is not a regular file: ' + current);
-    if (current !== target && !stat.isDirectory()) throw new Error('Adapter parent is not a directory: ' + current);
+    if (stat.isSymbolicLink())
+      throw new Error('Adapter path contains a symlink or junction: ' + current);
+    if (current === target && !stat.isFile())
+      throw new Error('Adapter target is not a regular file: ' + current);
+    if (current !== target && !stat.isDirectory())
+      throw new Error('Adapter parent is not a directory: ' + current);
   }
   return target;
 }
@@ -480,14 +572,24 @@ function writeFiles(outDir, files) {
   });
 }
 
-function writeUserAdapters({ outDir, derived = require('../cli/lib/packs').DERIVED,
-  packs, userName, language, tools, force = false } = {}) {
+function writeUserAdapters({
+  outDir,
+  derived = require('../cli/lib/packs').DERIVED,
+  packs,
+  userName,
+  language,
+  tools,
+  force = false,
+} = {}) {
   if (!outDir) throw new Error('A target project directory is required');
   const files = generateUserFiles(derived, { packs, userName, language, tools });
   const blockers = listAdoptionBlockers(outDir, files, USER_CONFIG_MARKER);
   if (blockers.length && !force) {
-    throw new Error('REFUSING to overwrite files not owned by this user configuration: ' +
-      blockers.join(', ') + '. Review them and use --force to replace them explicitly.');
+    throw new Error(
+      'REFUSING to overwrite files not owned by this user configuration: ' +
+        blockers.join(', ') +
+        '. Review them and use --force to replace them explicitly.'
+    );
   }
   return writeFiles(outDir, files);
 }
@@ -546,13 +648,17 @@ function parseOutDir(args) {
   const idx = args.indexOf('--out-dir');
   const targetIdx = args.indexOf('--target');
   if (targetIdx !== -1) {
-    if (args.includes('--adopt') || idx !== -1) throw new Error('--target, --adopt and --out-dir are mutually exclusive');
+    if (args.includes('--adopt') || idx !== -1)
+      throw new Error('--target, --adopt and --out-dir are mutually exclusive');
     const value = args[targetIdx + 1];
     if (!value || value.startsWith('--')) throw new Error('--target requires a directory path');
     return path.resolve(value);
   }
   if (args.includes('--adopt')) {
-    if (idx !== -1) throw new Error('--adopt and --out-dir are mutually exclusive (--adopt targets the repo root)');
+    if (idx !== -1)
+      throw new Error(
+        '--adopt and --out-dir are mutually exclusive (--adopt targets the repo root)'
+      );
     return REPO_ROOT;
   }
   if (idx === -1) return DEFAULT_OUT_DIR;
@@ -581,9 +687,18 @@ function main(argv) {
       };
       const packs = option('--packs');
       const tools = option('--tools');
-      const options = { packs: !packs || packs === 'all' ? undefined : packs.split(',').map(value => value.trim()),
-        tools: !tools || tools === 'all' ? undefined : tools === 'none' ? [] : tools.split(',').map(value => value.trim()),
-        userName: option('--user-name'), language: option('--language') };
+      const options = {
+        packs:
+          !packs || packs === 'all' ? undefined : packs.split(',').map((value) => value.trim()),
+        tools:
+          !tools || tools === 'all'
+            ? undefined
+            : tools === 'none'
+              ? []
+              : tools.split(',').map((value) => value.trim()),
+        userName: option('--user-name'),
+        language: option('--language'),
+      };
       const derived = require('../cli/lib/packs').DERIVED;
       const files = generateUserFiles(derived, options);
       if (args.includes('--print')) {
@@ -593,12 +708,21 @@ function main(argv) {
       if (args.includes('--check')) {
         const mismatches = files.filter(({ file, content }) => {
           const target = safeTarget(outDir, file);
-          return !fs.existsSync(target) || normalizeEol(fs.readFileSync(target, 'utf8')) !== normalizeEol(content);
+          return (
+            !fs.existsSync(target) ||
+            normalizeEol(fs.readFileSync(target, 'utf8')) !== normalizeEol(content)
+          );
         });
-        if (mismatches.length) console.error('User adapter drift: ' + mismatches.map(entry => entry.file).join(', '));
+        if (mismatches.length)
+          console.error('User adapter drift: ' + mismatches.map((entry) => entry.file).join(', '));
         return mismatches.length ? 1 : 0;
       }
-      const written = writeUserAdapters({ outDir, derived, ...options, force: args.includes('--force') });
+      const written = writeUserAdapters({
+        outDir,
+        derived,
+        ...options,
+        force: args.includes('--force'),
+      });
       for (const target of written) console.log('Generated ' + target);
       return 0;
     } catch (error) {
@@ -658,7 +782,9 @@ module.exports = {
   GENERATED_MARKER,
   USER_CONFIG_MARKER,
   buildIDEConfigs,
-  get IDE_CONFIGS() { return buildIDEConfigs(require('../cli/lib/packs').DERIVED); },
+  get IDE_CONFIGS() {
+    return buildIDEConfigs(require('../cli/lib/packs').DERIVED);
+  },
   renderUserConfig,
   generateUserFiles,
   writeUserAdapters,

package/tools/build/generate.js

@@ -58,8 +58,8 @@ function assertResourcePath(file, where) {
 }
 
 /** Installed entry points, derived from the same layout used by pack-copy.js. */
-function buildRequiredResources(pack) {
-  const where = `registry.yaml: pack "${pack.pack_dir}"`;
+function buildRequiredResources(pack, id = pack.pack_dir) {
+  const where = `registry.yaml: pack "${id}"`;
   for (const file of [
     ...pack.agents,
     ...(pack.skills || []),
@@ -135,12 +135,15 @@ function validateRegistry(registry) {
     if (pack.skills !== undefined && !Array.isArray(pack.skills)) {
       throw new Error(`${where}: "skills" must be a list`);
     }
-    if (typeof pack.pack_dir !== 'string' || pack.pack_dir === '') {
-      throw new Error(`${where}: missing "pack_dir"`);
-    }
     if (!INSTALL_LAYOUTS.includes(pack.install_layout)) {
       throw new Error(`${where}: "install_layout" must be one of ${INSTALL_LAYOUTS.join('|')}`);
     }
+    if (
+      (pack.install_layout === 'packaged' || pack.pack_dir !== undefined) &&
+      (typeof pack.pack_dir !== 'string' || pack.pack_dir === '')
+    ) {
+      throw new Error(`${where}: missing "pack_dir"`);
+    }
     if (pack.install_layout === 'packaged' && !Array.isArray((pack.doctor || {}).pack_agents)) {
       throw new Error(`${where}: packaged layout requires "doctor.pack_agents" list`);
     }
@@ -157,7 +160,7 @@ function validateRegistry(registry) {
     ) {
       throw new Error(`${where}: runtime must declare known runtimes`);
     }
-    buildRequiredResources(pack);
+    buildRequiredResources(pack, id);
     if (pack.personas !== undefined) {
       if (!Array.isArray(pack.personas)) throw new Error(`${where}: personas must be a list`);
       const roster = new Set([...pack.agents, ...(pack.sub_agents || [])]);
@@ -253,13 +256,16 @@ function buildPacks(registry) {
     const entry = {
       name: p.cli.name,
       icon: p.cli.icon,
-      agents: [...p.agents],
+      // Only loose packs install agent directories; packaged agents live in packDir.
+      agents: p.install_layout === 'loose' ? [...p.agents] : [],
       skills: [...(p.skills || [])],
     };
     if ('data' in p) entry.data = [...p.data];
     if (p.external_package) entry.externalPackage = p.external_package;
-    entry.packDir = p.pack_dir;
-    entry.packSrcDir = p.pack_src_dir || 'packs';
+    if (p.pack_dir) {
+      entry.packDir = p.pack_dir;
+      entry.packSrcDir = p.pack_src_dir || 'packs';
+    }
     if (p.required === true) entry.required = true;
     entry.desc = derived.packs[id].desc;
     packs[id] = entry;
@@ -313,6 +319,7 @@ function buildDerived(registry, { sourceRoot = path.join(REPO_ROOT, 'src', 'bmad
       order: pack.order,
       name: pack.cli.name,
       displayName: pack.display_name || pack.cli.name,
+      iconEmoji: pack.icon_emoji || '',
       required: pack.required === true,
       installerAgentCount,
       categoryAgentCount,
@@ -324,12 +331,14 @@ function buildDerived(registry, { sourceRoot = path.join(REPO_ROOT, 'src', 'bmad
       frameworkCount: (pack.compliance_tags || []).length,
       categoryCount: categories.length,
       skillCount: (pack.skills || []).length,
-      referenceFiles: countMarkdownFiles(
-        path.join(sourceRoot, pack.pack_src_dir || 'packs', pack.pack_dir, 'references')
-      ),
+      referenceFiles: pack.pack_dir
+        ? countMarkdownFiles(
+            path.join(sourceRoot, pack.pack_src_dir || 'packs', pack.pack_dir, 'references')
+          )
+        : 0,
       categoryAgentCounts,
       runtimes: [...pack.runtime],
-      requiredResources: buildRequiredResources(pack),
+      requiredResources: buildRequiredResources(pack, id),
       personas: (pack.personas || []).map(({ id, name, role, description, alias }) => ({
         id,
         name,
@@ -528,6 +537,31 @@ function describeDiff(label, generated, current, mismatches) {
   }
 }
 
+/**
+ * Every source path the installer copies from (see pack-copy.js listPackFiles)
+ * must exist; the copier tolerates a missing path, so the build must not.
+ */
+function checkSourcePaths(packs, packageRoot = REPO_ROOT) {
+  const sourceRoot = path.join(packageRoot, 'src', 'bmad-plus');
+  const missing = [];
+  for (const [id, pack] of Object.entries(packs)) {
+    const declared = [
+      ...pack.agents.map((name) => path.join(sourceRoot, 'agents', name)),
+      ...pack.skills.map((name) => path.join(sourceRoot, 'skills', name)),
+      ...(pack.data || []).map((name) => path.join(sourceRoot, 'data', name)),
+      ...(pack.externalPackage ? [path.join(packageRoot, pack.externalPackage, 'skills')] : []),
+      ...(pack.packDir ? [path.join(sourceRoot, pack.packSrcDir, pack.packDir)] : []),
+    ];
+    for (const source of declared) {
+      if (!fs.existsSync(source)) {
+        const relative = path.relative(packageRoot, source).split(path.sep).join('/');
+        missing.push(`PACKS.${id}: declared source path does not exist: ${relative}`);
+      }
+    }
+  }
+  return missing;
+}
+
 /**
  * `--check` mode: prove registry.yaml reproduces the live packs.js exactly,
  * and that product.version matches package.json.
@@ -546,6 +580,7 @@ function check({
   const mismatches = [];
 
   const pkg = JSON.parse(fs.readFileSync(packageJsonPath, 'utf8'));
+  mismatches.push(...checkSourcePaths(generated.PACKS));
   const { checkPythonDelivery } = require('./pack-delivery');
   mismatches.push(...checkPythonDelivery(registry, { packageRoot: REPO_ROOT, packageJson: pkg }));
   try {
@@ -642,6 +677,7 @@ module.exports = {
   generateModuleSource,
   generatePacksModuleSource,
   check,
+  checkSourcePaths,
   main,
 };
 

package/tools/cli/bmad-plus-cli.js

@@ -29,10 +29,11 @@ const doctor = require('./commands/doctor');
 const scan = require('./commands/scan');
 const memory = require('./commands/memory');
 
+// `--lang` is declared per command: a program-level copy would swallow it.
 program
+  .name('bmad-plus')
   .version(packageJson.version)
-  .description('BMAD+ — Augmented AI-Driven Development Framework')
-  .option('-l, --lang <code>', 'Language code: en, fr, es, de, pt-br, ru, zh, he, ja, it');
+  .description('BMAD+ — Augmented AI-Driven Development Framework');
 
 // Install command
 const installCmd = program
@@ -131,7 +132,3 @@ program.parseAsync(process.argv).catch((error) => {
   console.error(`BMAD+: ${error.message}`);
   process.exitCode = 1;
 });
-
-if (process.argv.slice(2).length === 0) {
-  program.outputHelp();
-}