bmad-method 6.0.0-alpha.9 → 6.0.2

package/test/README.md

@@ -116,7 +116,7 @@ Tests required menu structure:
 
 Tests menu item command targets:
 
-- ✅ Valid: All 7 command types (`workflow`, `validate-workflow`, `exec`, `action`, `tmpl`, `data`, `run-workflow`)
+- ✅ Valid: All 6 command types (`workflow`, `validate-workflow`, `exec`, `action`, `tmpl`, `data`)
 - ✅ Valid: Multiple command targets in one menu item
 - ❌ Invalid: No command target fields
 - ❌ Invalid: Empty string command targets
@@ -224,7 +224,7 @@ See **[MANUAL-TESTING.md](./MANUAL-TESTING.md)** for detailed manual testing pro
 
 Edge cases covered include:
 
-- Malformed module paths (e.g., `src/modules/bmm` without `/agents/`)
+- Malformed module paths (e.g., `src/bmm` without `/agents/`)
 - Empty module names in paths (e.g., `src/modules//agents/`)
 - Whitespace-only module field values
 - All validation error paths
@@ -240,7 +240,7 @@ To add new test cases:
    ```yaml
    # Test: Description of what this tests
    # Expected: PASS (or FAIL - error description)
-   # Path context: src/modules/bmm/agents/test.agent.yaml (if needed)
+   # Path context: src/bmm/agents/test.agent.yaml (if needed)
    ```
 
 3. Run the test suite to verify: `npm test`
@@ -269,7 +269,7 @@ The validation is integrated into the GitHub Actions workflow:
 ## Dependencies
 
 - **zod**: Schema validation library
-- **js-yaml**: YAML parsing
+- **yaml**: YAML parsing
 - **glob**: File pattern matching
 - **c8**: Code coverage reporting
 

package/test/adversarial-review-tests/README.md

@@ -0,0 +1,56 @@
+# Adversarial Review Test Suite
+
+Tests for the `also_consider` optional input in `review-adversarial-general.xml`.
+
+## Purpose
+
+Evaluate whether the `also_consider` input gently nudges the reviewer toward specific areas without overriding normal adversarial analysis.
+
+## Test Content
+
+All tests use `sample-content.md` - a deliberately imperfect User Authentication API doc with:
+
+- Vague error handling section
+- Missing rate limit details
+- No token expiration info
+- Password in plain text example
+- Missing authentication headers
+- No error response examples
+
+## Running Tests
+
+For each test case in `test-cases.yaml`, invoke the adversarial review task.
+
+### Manual Test Invocation
+
+```
+Review this content using the adversarial review task:
+
+<content>
+[paste sample-content.md]
+</content>
+
+<also_consider>
+[paste items from test case, or omit for TC01]
+</also_consider>
+```
+
+## Evaluation Criteria
+
+For each test, note:
+
+1. **Total findings** - Still hitting ~10 issues?
+2. **Distribution** - Are findings spread across concerns or clustered?
+3. **Relevance** - Do findings relate to `also_consider` items when provided?
+4. **Balance** - Are `also_consider` findings elevated over others, or naturally mixed?
+5. **Quality** - Are findings actionable regardless of source?
+
+## Expected Outcomes
+
+- **TC01 (baseline)**: Generic spread of findings
+- **TC02-TC05 (domain-focused)**: Some findings align with domain, others still organic
+- **TC06 (single item)**: Light influence, not dominant
+- **TC07 (vague items)**: Minimal change from baseline
+- **TC08 (specific items)**: Direct answers if gaps exist
+- **TC09 (mixed)**: Balanced across domains
+- **TC10 (contradictory)**: Graceful handling

package/test/adversarial-review-tests/sample-content.md

@@ -0,0 +1,46 @@
+# User Authentication API
+
+## Overview
+
+This API provides endpoints for user authentication and session management.
+
+## Endpoints
+
+### POST /api/auth/login
+
+Authenticates a user and returns a token.
+
+**Request Body:**
+```json
+{
+  "email": "user@example.com",
+  "password": "password123"
+}
+```
+
+**Response:**
+```json
+{
+  "token": "eyJhbGciOiJIUzI1NiIs...",
+  "user": {
+    "id": 1,
+    "email": "user@example.com"
+  }
+}
+```
+
+### POST /api/auth/logout
+
+Logs out the current user.
+
+### GET /api/auth/me
+
+Returns the current user's profile.
+
+## Error Handling
+
+Errors return appropriate HTTP status codes.
+
+## Rate Limiting
+
+Rate limiting is applied to prevent abuse.

package/test/adversarial-review-tests/test-cases.yaml

@@ -0,0 +1,103 @@
+# Test Cases for review-adversarial-general.xml with also_consider input
+#
+# Purpose: Evaluate how the optional also_consider input influences review findings
+# Content: All tests use sample-content.md (User Authentication API docs)
+#
+# To run: Manually invoke the task with each configuration and compare outputs
+
+test_cases:
+  # BASELINE - No also_consider
+  - id: TC01
+    name: "Baseline - no also_consider"
+    description: "Control test with no also_consider input"
+    also_consider: null
+    expected_behavior: "Generic adversarial findings across all aspects"
+
+  # DOCUMENTATION-FOCUSED
+  - id: TC02
+    name: "Documentation - reader confusion"
+    description: "Nudge toward documentation UX issues"
+    also_consider:
+      - What would confuse a first-time reader?
+      - What questions are left unanswered?
+      - What could be interpreted multiple ways?
+      - What jargon is unexplained?
+    expected_behavior: "More findings about clarity, completeness, reader experience"
+
+  - id: TC03
+    name: "Documentation - examples and usage"
+    description: "Nudge toward practical usage gaps"
+    also_consider:
+      - Missing code examples
+      - Unclear usage patterns
+      - Edge cases not documented
+    expected_behavior: "More findings about practical application gaps"
+
+  # SECURITY-FOCUSED
+  - id: TC04
+    name: "Security review"
+    description: "Nudge toward security concerns"
+    also_consider:
+      - Authentication vulnerabilities
+      - Token handling issues
+      - Input validation gaps
+      - Information disclosure risks
+    expected_behavior: "More security-related findings"
+
+  # API DESIGN-FOCUSED
+  - id: TC05
+    name: "API design"
+    description: "Nudge toward API design best practices"
+    also_consider:
+      - REST conventions not followed
+      - Inconsistent response formats
+      - Missing pagination or filtering
+      - Versioning concerns
+    expected_behavior: "More API design pattern findings"
+
+  # SINGLE ITEM
+  - id: TC06
+    name: "Single item - error handling"
+    description: "Test with just one also_consider item"
+    also_consider:
+      - Error handling completeness
+    expected_behavior: "Some emphasis on error handling while still covering other areas"
+
+  # BROAD/VAGUE
+  - id: TC07
+    name: "Broad items"
+    description: "Test with vague also_consider items"
+    also_consider:
+      - Quality issues
+      - Things that seem off
+    expected_behavior: "Minimal change from baseline - items too vague to steer"
+
+  # VERY SPECIFIC
+  - id: TC08
+    name: "Very specific items"
+    description: "Test with highly specific also_consider items"
+    also_consider:
+      - Is the JWT token expiration documented?
+      - Are refresh token mechanics explained?
+      - What happens on concurrent sessions?
+    expected_behavior: "Specific findings addressing these exact questions if gaps exist"
+
+  # MIXED DOMAINS
+  - id: TC09
+    name: "Mixed domain concerns"
+    description: "Test with items from different domains"
+    also_consider:
+      - Security vulnerabilities
+      - Reader confusion points
+      - API design inconsistencies
+      - Performance implications
+    expected_behavior: "Balanced findings across multiple domains"
+
+  # CONTRADICTORY/UNUSUAL
+  - id: TC10
+    name: "Contradictory items"
+    description: "Test resilience with odd inputs"
+    also_consider:
+      - Things that are too detailed
+      - Things that are not detailed enough
+    expected_behavior: "Reviewer handles gracefully, finds issues in both directions"

package/test/fixtures/agent-schema/invalid/critical-actions/actions-as-string.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Actions String
     title: Actions String
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/critical-actions/empty-string-in-actions.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Empty Action String
     title: Empty Action String
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/menu/empty-menu.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Empty Menu
     title: Empty Menu
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/menu/missing-menu.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Missing Menu
     title: Missing Menu
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/menu-commands/empty-command-target.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Empty Command Target
     title: Empty Command
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/menu-commands/no-command-target.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: No Command Target
     title: No Command
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/menu-triggers/camel-case.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: CamelCase Trigger
     title: CamelCase
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/menu-triggers/compound-invalid-format.agent.yaml

@@ -0,0 +1,25 @@
+# Test: Compound trigger with invalid format
+# Expected: FAIL
+# Error code: custom
+# Error path: agent.menu[0].trigger
+# Error message: agent.menu[].trigger compound format error: invalid compound trigger format
+
+agent:
+  metadata:
+    id: compound-invalid-format
+    name: Invalid Format
+    title: Invalid Format Test
+    icon: 🧪
+    hasSidecar: false
+
+  persona:
+    role: Test agent
+    identity: Test identity
+    communication_style: Test style
+    principles:
+      - Test principle
+
+  menu:
+    - trigger: TS or tech-spec
+      description: Missing fuzzy match clause
+      action: test

package/test/fixtures/agent-schema/invalid/menu-triggers/compound-mismatched-kebab.agent.yaml

@@ -0,0 +1,25 @@
+# Test: Compound trigger with old format (no longer supported)
+# Expected: FAIL
+# Error code: custom
+# Error path: agent.menu[0].trigger
+# Error message: agent.menu[].trigger compound format error: invalid compound trigger format
+
+agent:
+  metadata:
+    id: compound-mismatched-kebab
+    name: Old Format
+    title: Old Format Test
+    icon: 🧪
+    hasSidecar: false
+
+  persona:
+    role: Test agent
+    identity: Test identity
+    communication_style: Test style
+    principles:
+      - Test principle
+
+  menu:
+    - trigger: TS or tech-spec or fuzzy match on tech-spec
+      description: Old format with middle kebab-case (no longer supported)
+      action: test

package/test/fixtures/agent-schema/invalid/menu-triggers/duplicate-triggers.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Duplicate Triggers
     title: Duplicate
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/menu-triggers/empty-trigger.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Empty Trigger
     title: Empty
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/menu-triggers/leading-asterisk.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Asterisk Trigger
     title: Asterisk
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/menu-triggers/snake-case.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Snake Case Trigger
     title: Snake Case
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/menu-triggers/trigger-with-spaces.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Spaces Trigger
     title: Spaces
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/metadata/empty-module-string.agent.yaml

@@ -3,7 +3,7 @@
 # Error code: custom
 # Error path: agent.metadata.module
 # Error message: agent.metadata.module must be a non-empty string
-# Path context: src/modules/bmm/agents/empty-module-string.agent.yaml
+# Path context: src/bmm/agents/empty-module-string.agent.yaml
 
 agent:
   metadata:

package/test/fixtures/agent-schema/invalid/metadata/extra-metadata-fields.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Extra Fields
     title: Extra Fields
     icon: ❌
+    hasSidecar: false
     unknown_field: This is not allowed
     another_extra: Also invalid
 

package/test/fixtures/agent-schema/invalid/persona/empty-principles-array.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Empty Principles
     title: Empty Principles
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/persona/empty-string-in-principles.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Empty Principle String
     title: Empty Principle
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/persona/extra-persona-fields.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Extra Persona Fields
     title: Extra Persona
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/persona/missing-role.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Missing Role
     title: Missing Role
     icon: ❌
+    hasSidecar: false
 
   persona:
     identity: Test identity

package/test/fixtures/agent-schema/invalid/prompts/empty-content.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Empty Content
     title: Empty Content
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/prompts/extra-prompt-fields.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Extra Prompt Fields
     title: Extra Fields
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/prompts/missing-content.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Prompt Missing Content
     title: Missing Content
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/prompts/missing-id.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Prompt Missing ID
     title: Missing ID
     icon: ❌
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/invalid/top-level/extra-top-level-keys.agent.yaml

@@ -10,6 +10,7 @@ agent:
     name: Extra Test Agent
     title: Extra Test
     icon: 🧪
+    hasSidecar: false
 
   persona:
     role: Test agent

package/test/fixtures/agent-schema/valid/critical-actions/empty-critical-actions.agent.yaml

@@ -7,6 +7,7 @@ agent:
     name: Empty Critical Actions
     title: Empty Critical Actions
     icon: 🧪
+    hasSidecar: false
 
   persona:
     role: Test agent with empty critical actions

package/test/fixtures/agent-schema/valid/critical-actions/no-critical-actions.agent.yaml

@@ -7,6 +7,7 @@ agent:
     name: No Critical Actions
     title: No Critical Actions
     icon: 🧪
+    hasSidecar: false
 
   persona:
     role: Test agent without critical actions

package/test/fixtures/agent-schema/valid/critical-actions/valid-critical-actions.agent.yaml

@@ -7,6 +7,7 @@ agent:
     name: Valid Critical Actions
     title: Valid Critical Actions
     icon: 🧪
+    hasSidecar: false
 
   persona:
     role: Test agent with critical actions

package/test/fixtures/agent-schema/valid/menu/multiple-menu-items.agent.yaml

@@ -7,6 +7,7 @@ agent:
     name: Multiple Menu Items
     title: Multiple Menu
     icon: 🧪
+    hasSidecar: false
 
   persona:
     role: Test agent with multiple menu items

package/test/fixtures/agent-schema/valid/menu/single-menu-item.agent.yaml

@@ -7,6 +7,7 @@ agent:
     name: Single Menu Item
     title: Single Menu
     icon: 🧪
+    hasSidecar: false
 
   persona:
     role: Test agent with single menu item

package/test/fixtures/agent-schema/valid/menu-commands/all-command-types.agent.yaml

@@ -7,6 +7,7 @@ agent:
     name: All Command Types
     title: All Commands
     icon: 🧪
+    hasSidecar: false
 
   persona:
     role: Test agent with all command types
@@ -34,6 +35,4 @@ agent:
     - trigger: data-test
       description: Test data command
       data: path/to/data
-    - trigger: run-workflow-test
-      description: Test run-workflow command
-      run-workflow: path/to/workflow
+  

package/test/fixtures/agent-schema/valid/menu-commands/multiple-commands.agent.yaml

@@ -7,6 +7,7 @@ agent:
     name: Multiple Commands
     title: Multiple Commands
     icon: 🧪
+    hasSidecar: false
 
   persona:
     role: Test agent with multiple command targets

package/test/fixtures/agent-schema/valid/menu-triggers/compound-triggers.agent.yaml

@@ -0,0 +1,31 @@
+# Test: Valid compound triggers
+# Expected: PASS
+
+agent:
+  metadata:
+    id: compound-triggers
+    name: Compound Triggers
+    title: Compound Triggers Test
+    icon: 🧪
+    hasSidecar: false
+
+  persona:
+    role: Test agent with compound triggers
+    identity: I test compound trigger validation.
+    communication_style: Clear
+    principles:
+      - Test compound format
+
+  menu:
+    - trigger: TS or fuzzy match on tech-spec
+      description: "[TS] Two-word compound trigger"
+      action: tech_spec
+    - trigger: DS or fuzzy match on dev-story
+      description: "[DS] Another two-word compound trigger"
+      action: dev_story
+    - trigger: WI or fuzzy match on three-name-thing
+      description: "[WI] Three-word compound trigger (uses first 2 words for shortcut)"
+      action: three_name_thing
+    - trigger: H or fuzzy match on help
+      description: "[H] Single-word compound trigger (1-letter shortcut)"
+      action: help

package/test/fixtures/agent-schema/valid/menu-triggers/kebab-case-triggers.agent.yaml

@@ -7,6 +7,7 @@ agent:
     name: Kebab Case Triggers
     title: Kebab Triggers
     icon: 🧪
+    hasSidecar: false
 
   persona:
     role: Test agent with kebab-case triggers
@@ -22,7 +23,7 @@ agent:
     - trigger: list-tasks
       description: Two word trigger
       action: list_tasks
-    - trigger: workflow-init-process
+    - trigger: three-word-process
       description: Three word trigger
       action: init_workflow
     - trigger: test123

package/test/fixtures/agent-schema/valid/metadata/core-agent-with-module.agent.yaml

@@ -0,0 +1,24 @@
+# Test: Core agent can have module field
+# Expected: PASS
+# Note: Core agents can now include module field if needed
+
+agent:
+  metadata:
+    id: core-with-module
+    name: Core With Module
+    title: Core Agent
+    icon: ✅
+    module: bmm
+    hasSidecar: false
+
+  persona:
+    role: Test agent
+    identity: Test identity
+    communication_style: Test style
+    principles:
+      - Test principle
+
+  menu:
+    - trigger: help
+      description: Show help
+      action: display_help

package/test/fixtures/agent-schema/valid/metadata/empty-module-name-in-path.agent.yaml

@@ -8,6 +8,7 @@ agent:
     name: Empty Module in Path
     title: Empty Module Path
     icon: 🧪
+    hasSidecar: false
     # No module field - path has empty module name, treated as core
 
   persona: