aigroup-workflow 2.1.2 → 2.2.0

package/skills/infra/websocket-engineer/references/security.md

@@ -0,0 +1,474 @@
+# WebSocket Security Reference
+
+## Authentication
+
+### JWT Authentication
+
+```javascript
+const io = require('socket.io')(3000);
+const jwt = require('jsonwebtoken');
+
+// Middleware for authentication
+io.use((socket, next) => {
+  const token = socket.handshake.auth.token;
+
+  if (!token) {
+    return next(new Error('Authentication error: No token provided'));
+  }
+
+  try {
+    const decoded = jwt.verify(token, process.env.JWT_SECRET);
+    socket.userId = decoded.userId;
+    socket.username = decoded.username;
+    next();
+  } catch (err) {
+    next(new Error('Authentication error: Invalid token'));
+  }
+});
+
+io.on('connection', (socket) => {
+  console.log(`User ${socket.username} connected`);
+
+  socket.on('message', (data) => {
+    // socket.userId is already verified
+    saveMessage(socket.userId, data);
+  });
+});
+```
+
+### Query Parameter Authentication (Less Secure)
+
+```javascript
+// Use only for initial handshake, then upgrade to token
+io.use((socket, next) => {
+  const token = socket.handshake.query.token;
+
+  if (!token) {
+    return next(new Error('Authentication required'));
+  }
+
+  jwt.verify(token, process.env.JWT_SECRET, (err, decoded) => {
+    if (err) return next(new Error('Invalid token'));
+    socket.userId = decoded.userId;
+    next();
+  });
+});
+```
+
+### Cookie Authentication
+
+```javascript
+const cookieParser = require('cookie-parser');
+
+io.use((socket, next) => {
+  const cookies = socket.handshake.headers.cookie;
+
+  if (!cookies) {
+    return next(new Error('No cookies'));
+  }
+
+  // Parse cookies
+  cookieParser(process.env.COOKIE_SECRET)(
+    socket.request,
+    {},
+    () => {
+      const sessionId = socket.request.signedCookies.sessionId;
+
+      if (!sessionId) {
+        return next(new Error('No session'));
+      }
+
+      // Verify session in Redis/DB
+      verifySession(sessionId).then(user => {
+        socket.userId = user.id;
+        next();
+      }).catch(err => {
+        next(new Error('Invalid session'));
+      });
+    }
+  );
+});
+```
+
+## Authorization
+
+### Room-Based Authorization
+
+```javascript
+io.on('connection', (socket) => {
+  socket.on('join-room', async (roomId) => {
+    // Check if user has permission
+    const hasAccess = await checkRoomAccess(socket.userId, roomId);
+
+    if (!hasAccess) {
+      socket.emit('error', { message: 'Access denied to room' });
+      return;
+    }
+
+    socket.join(roomId);
+    socket.emit('joined', { room: roomId });
+  });
+
+  socket.on('send-message', async ({ roomId, text }) => {
+    // Verify user is in room
+    if (!socket.rooms.has(roomId)) {
+      socket.emit('error', { message: 'Not in room' });
+      return;
+    }
+
+    // Check write permissions
+    const canWrite = await checkWritePermission(socket.userId, roomId);
+
+    if (!canWrite) {
+      socket.emit('error', { message: 'No write permission' });
+      return;
+    }
+
+    io.to(roomId).emit('message', {
+      userId: socket.userId,
+      text,
+      timestamp: Date.now()
+    });
+  });
+});
+```
+
+### Admin-Only Events
+
+```javascript
+const ADMIN_EVENTS = ['kick-user', 'ban-user', 'delete-message'];
+
+io.use((socket, next) => {
+  // Attach role to socket after auth
+  getUserRole(socket.userId).then(role => {
+    socket.role = role;
+    next();
+  });
+});
+
+io.on('connection', (socket) => {
+  ADMIN_EVENTS.forEach(event => {
+    socket.on(event, async (data) => {
+      if (socket.role !== 'admin') {
+        socket.emit('error', { message: 'Admin access required' });
+        return;
+      }
+
+      // Execute admin action
+      await handleAdminAction(event, data);
+    });
+  });
+});
+```
+
+## Rate Limiting
+
+### Per-Socket Rate Limiting
+
+```javascript
+const rateLimit = require('express-rate-limit');
+
+class SocketRateLimiter {
+  constructor(maxRequests = 100, windowMs = 60000) {
+    this.maxRequests = maxRequests;
+    this.windowMs = windowMs;
+    this.requests = new Map();
+  }
+
+  check(socketId) {
+    const now = Date.now();
+    const userRequests = this.requests.get(socketId) || [];
+
+    // Remove expired requests
+    const validRequests = userRequests.filter(
+      time => now - time < this.windowMs
+    );
+
+    if (validRequests.length >= this.maxRequests) {
+      return false; // Rate limit exceeded
+    }
+
+    validRequests.push(now);
+    this.requests.set(socketId, validRequests);
+    return true;
+  }
+
+  reset(socketId) {
+    this.requests.delete(socketId);
+  }
+}
+
+const limiter = new SocketRateLimiter(100, 60000); // 100 req/min
+
+io.on('connection', (socket) => {
+  socket.on('message', (data) => {
+    if (!limiter.check(socket.id)) {
+      socket.emit('error', { message: 'Rate limit exceeded' });
+      return;
+    }
+
+    // Process message
+    io.to(data.roomId).emit('message', data);
+  });
+
+  socket.on('disconnect', () => {
+    limiter.reset(socket.id);
+  });
+});
+```
+
+### Redis-Based Distributed Rate Limiting
+
+```javascript
+const Redis = require('ioredis');
+const redis = new Redis();
+
+async function checkRateLimit(userId, maxRequests = 100, windowSec = 60) {
+  const key = `rate_limit:${userId}`;
+  const now = Date.now();
+  const windowStart = now - (windowSec * 1000);
+
+  const pipeline = redis.pipeline();
+
+  // Remove old entries
+  pipeline.zremrangebyscore(key, 0, windowStart);
+
+  // Count requests in window
+  pipeline.zcard(key);
+
+  // Add current request
+  pipeline.zadd(key, now, `${now}-${Math.random()}`);
+
+  // Set expiry
+  pipeline.expire(key, windowSec);
+
+  const results = await pipeline.exec();
+  const count = results[1][1];
+
+  return count < maxRequests;
+}
+
+io.on('connection', (socket) => {
+  socket.on('message', async (data) => {
+    const allowed = await checkRateLimit(socket.userId, 50, 60);
+
+    if (!allowed) {
+      socket.emit('error', { message: 'Too many requests' });
+      return;
+    }
+
+    io.to(data.roomId).emit('message', data);
+  });
+});
+```
+
+## CORS Configuration
+
+```javascript
+const io = require('socket.io')(3000, {
+  cors: {
+    origin: ['https://example.com', 'https://app.example.com'],
+    methods: ['GET', 'POST'],
+    credentials: true,
+    allowedHeaders: ['Authorization']
+  }
+});
+
+// Dynamic CORS
+io.engine.on('initial_headers', (headers, req) => {
+  headers['Access-Control-Allow-Origin'] = req.headers.origin;
+});
+```
+
+## Input Validation
+
+```javascript
+const Joi = require('joi');
+
+const messageSchema = Joi.object({
+  roomId: Joi.string().uuid().required(),
+  text: Joi.string().min(1).max(1000).required(),
+  attachments: Joi.array().items(Joi.string().uri()).max(5).optional()
+});
+
+io.on('connection', (socket) => {
+  socket.on('message', (data) => {
+    // Validate input
+    const { error, value } = messageSchema.validate(data);
+
+    if (error) {
+      socket.emit('error', {
+        message: 'Invalid message format',
+        details: error.details
+      });
+      return;
+    }
+
+    // Process validated data
+    io.to(value.roomId).emit('message', {
+      userId: socket.userId,
+      ...value,
+      timestamp: Date.now()
+    });
+  });
+});
+```
+
+## XSS Protection
+
+```javascript
+const sanitizeHtml = require('sanitize-html');
+
+function sanitizeMessage(text) {
+  return sanitizeHtml(text, {
+    allowedTags: [], // Strip all HTML
+    allowedAttributes: {},
+    disallowedTagsMode: 'escape'
+  });
+}
+
+io.on('connection', (socket) => {
+  socket.on('message', (data) => {
+    const sanitized = {
+      ...data,
+      text: sanitizeMessage(data.text)
+    };
+
+    io.to(data.roomId).emit('message', sanitized);
+  });
+});
+```
+
+## DDoS Protection
+
+### Connection Limiting
+
+```javascript
+const connectionLimits = new Map();
+const MAX_CONNECTIONS_PER_IP = 10;
+
+io.engine.on('connection', (rawSocket) => {
+  const ip = rawSocket.request.headers['x-forwarded-for'] ||
+              rawSocket.request.connection.remoteAddress;
+
+  const currentConnections = connectionLimits.get(ip) || 0;
+
+  if (currentConnections >= MAX_CONNECTIONS_PER_IP) {
+    rawSocket.close(1008, 'Too many connections from IP');
+    return;
+  }
+
+  connectionLimits.set(ip, currentConnections + 1);
+
+  rawSocket.on('close', () => {
+    const count = connectionLimits.get(ip) - 1;
+    if (count <= 0) {
+      connectionLimits.delete(ip);
+    } else {
+      connectionLimits.set(ip, count);
+    }
+  });
+});
+```
+
+### Message Size Limits
+
+```javascript
+const io = require('socket.io')(3000, {
+  maxHttpBufferSize: 1e6, // 1MB max message size
+  pingTimeout: 60000,
+  pingInterval: 25000
+});
+
+io.on('connection', (socket) => {
+  socket.on('message', (data) => {
+    if (JSON.stringify(data).length > 10000) {
+      socket.emit('error', { message: 'Message too large' });
+      return;
+    }
+
+    // Process message
+  });
+});
+```
+
+## Secure Session Management
+
+```javascript
+const sessions = new Map();
+
+io.on('connection', (socket) => {
+  const sessionId = generateSecureSessionId();
+
+  sessions.set(socket.id, {
+    sessionId,
+    userId: socket.userId,
+    createdAt: Date.now(),
+    lastActivity: Date.now()
+  });
+
+  // Timeout inactive sessions
+  const timeout = setTimeout(() => {
+    socket.disconnect(true);
+  }, 30 * 60 * 1000); // 30 minutes
+
+  socket.on('message', () => {
+    const session = sessions.get(socket.id);
+    if (session) {
+      session.lastActivity = Date.now();
+      clearTimeout(timeout);
+    }
+  });
+
+  socket.on('disconnect', () => {
+    sessions.delete(socket.id);
+    clearTimeout(timeout);
+  });
+});
+
+function generateSecureSessionId() {
+  return require('crypto').randomBytes(32).toString('hex');
+}
+```
+
+## Audit Logging
+
+```javascript
+const winston = require('winston');
+
+const logger = winston.createLogger({
+  level: 'info',
+  format: winston.format.json(),
+  transports: [
+    new winston.transports.File({ filename: 'websocket-audit.log' })
+  ]
+});
+
+io.on('connection', (socket) => {
+  logger.info('Connection', {
+    socketId: socket.id,
+    userId: socket.userId,
+    ip: socket.handshake.address,
+    timestamp: Date.now()
+  });
+
+  socket.on('message', (data) => {
+    logger.info('Message', {
+      socketId: socket.id,
+      userId: socket.userId,
+      roomId: data.roomId,
+      messageLength: data.text.length,
+      timestamp: Date.now()
+    });
+  });
+
+  socket.on('disconnect', (reason) => {
+    logger.info('Disconnect', {
+      socketId: socket.id,
+      userId: socket.userId,
+      reason,
+      timestamp: Date.now()
+    });
+  });
+});
+```

package/skills/java/java-architect/SKILL.md

@@ -0,0 +1,132 @@
+---
+name: java-architect
+description: Use when building, configuring, or debugging enterprise Java applications with Spring Boot 3.x, microservices, or reactive programming. Invoke to implement WebFlux endpoints, optimize JPA queries and database performance, configure Spring Security with OAuth2/JWT, or resolve authentication issues and async processing challenges in cloud-native Spring applications.
+license: MIT
+metadata:
+  author: https://github.com/Jeffallan
+  version: "1.1.0"
+  domain: language
+  triggers: Spring Boot, Java, microservices, Spring Cloud, JPA, Hibernate, WebFlux, reactive, Java Enterprise
+  role: architect
+  scope: implementation
+  output-format: code
+  related-skills: fullstack-guardian, api-designer, devops-engineer, database-optimizer
+---
+
+# Java Architect
+
+Enterprise Java specialist focused on Spring Boot 3.x, microservices architecture, and cloud-native development using Java 21 LTS.
+
+## Core Workflow
+
+1. **Architecture analysis** - Review project structure, dependencies, Spring config
+2. **Domain design** - Create models following DDD and Clean Architecture; verify domain boundaries before proceeding. If boundaries are unclear, resolve ambiguities before moving to implementation.
+3. **Implementation** - Build services with Spring Boot best practices
+4. **Data layer** - Optimize JPA queries, implement repositories; run `./mvnw verify -pl <module>` to confirm query correctness. If integration tests fail: review Hibernate SQL logs, fix queries or mappings, re-run before proceeding.
+5. **Security & config** - Apply Spring Security, externalize configuration, add observability; run `./mvnw verify` after security changes to confirm filter chain and JWT wiring. If tests fail: check `SecurityFilterChain` bean order and token validation config, then re-run.
+6. **Quality assurance** - Run `./mvnw verify` (Maven) or `./gradlew check` (Gradle) to confirm all tests pass and coverage reaches 85%+ before closing. If coverage is below threshold: identify untested branches via JaCoCo report (`target/site/jacoco/index.html`), add missing test cases, re-run.
+
+## Reference Guide
+
+Load detailed guidance based on context:
+
+| Topic | Reference | Load When |
+|-------|-----------|-----------|
+| Spring Boot | `references/spring-boot-setup.md` | Project setup, configuration, starters |
+| Reactive | `references/reactive-webflux.md` | WebFlux, Project Reactor, R2DBC |
+| Data Access | `references/jpa-optimization.md` | JPA, Hibernate, query tuning |
+| Security | `references/spring-security.md` | OAuth2, JWT, method security |
+| Testing | `references/testing-patterns.md` | JUnit 5, TestContainers, Mockito |
+
+## Constraints
+
+### MUST DO
+- Use Java 21 LTS features (records, sealed classes, pattern matching)
+- Apply database migrations (Flyway/Liquibase)
+- Document APIs with OpenAPI/Swagger
+- Use proper exception handling hierarchy
+- Externalize all configuration (never hardcode values)
+
+### MUST NOT DO
+- Use deprecated Spring APIs
+- Skip input validation
+- Store sensitive data unencrypted
+- Use blocking code in reactive applications
+- Ignore transaction boundaries
+
+## Output Templates
+
+When implementing Java features, provide:
+1. Domain models (entities, DTOs, records)
+2. Service layer (business logic, transactions)
+3. Repository interfaces (Spring Data)
+4. Controller/REST endpoints
+5. Test classes with comprehensive coverage
+6. Brief explanation of architectural decisions
+
+## Code Examples
+
+### Minimal WebFlux REST Endpoint
+
+```java
+@RestController
+@RequestMapping("/api/v1/orders")
+@RequiredArgsConstructor
+public class OrderController {
+
+    private final OrderService orderService;
+
+    @GetMapping("/{id}")
+    public Mono<ResponseEntity<OrderDto>> getOrder(@PathVariable UUID id) {
+        return orderService.findById(id)
+                .map(ResponseEntity::ok)
+                .defaultIfEmpty(ResponseEntity.notFound().build());
+    }
+
+    @PostMapping
+    @ResponseStatus(HttpStatus.CREATED)
+    public Mono<OrderDto> createOrder(@Valid @RequestBody CreateOrderRequest request) {
+        return orderService.create(request);
+    }
+}
+```
+
+### JPA Repository with Optimized Query
+
+```java
+public interface OrderRepository extends JpaRepository<Order, UUID> {
+
+    // Avoid N+1: fetch association in one query
+    @Query("SELECT o FROM Order o JOIN FETCH o.items WHERE o.customerId = :customerId")
+    List<Order> findByCustomerIdWithItems(@Param("customerId") UUID customerId);
+
+    // Projection to limit fetched columns
+    @Query("SELECT new com.example.dto.OrderSummary(o.id, o.status, o.total) FROM Order o WHERE o.status = :status")
+    Page<OrderSummary> findSummariesByStatus(@Param("status") OrderStatus status, Pageable pageable);
+}
+```
+
+### Spring Security OAuth2 JWT Configuration
+
+```java
+@Configuration
+@EnableMethodSecurity
+public class SecurityConfig {
+
+    @Bean
+    public SecurityFilterChain filterChain(HttpSecurity http) throws Exception {
+        return http
+                .csrf(AbstractHttpConfigurer::disable)
+                .sessionManagement(s -> s.sessionCreationPolicy(STATELESS))
+                .authorizeHttpRequests(auth -> auth
+                        .requestMatchers("/actuator/health").permitAll()
+                        .anyRequest().authenticated())
+                .oauth2ResourceServer(oauth2 -> oauth2.jwt(Customizer.withDefaults()))
+                .build();
+    }
+}
+```
+
+## Knowledge Reference
+
+Spring Boot 3.x, Java 21, Spring WebFlux, Project Reactor, Spring Data JPA, Spring Security, OAuth2/JWT, Hibernate, R2DBC, Spring Cloud, Resilience4j, Micrometer, JUnit 5, TestContainers, Mockito, Maven/Gradle