agileflow 3.4.3 → 4.0.0-alpha.2

package/scripts/validate-expertise.sh

@@ -1,263 +0,0 @@
-#!/bin/bash
-#
-# validate-expertise.sh - Validate Agent Expert expertise.yaml files
-#
-# Purpose: Ensure expertise files remain accurate and useful over time
-#
-# Checks performed:
-#   1. Schema validation (required fields: domain, last_updated, version)
-#   2. Staleness check (last_updated > 30 days old)
-#   3. File size check (warn if > 200 lines)
-#   4. Learnings check (warn if empty - never self-improved)
-#
-# Usage:
-#   ./scripts/validate-expertise.sh           # Validate all expertise files
-#   ./scripts/validate-expertise.sh database  # Validate specific domain
-#   ./scripts/validate-expertise.sh --help    # Show help
-#
-# Exit codes:
-#   0 - All checks passed
-#   1 - One or more checks failed (warnings don't cause failure)
-#
-
-set -e
-
-# Colors (using vibrant 256-color palette)
-NC='\033[0m'        # No Color / Reset
-RED='\033[0;31m'    # Standard red (fallback)
-GREEN='\033[0;32m'  # Standard green (fallback)
-
-# Vibrant 256-color palette
-MINT_GREEN='\033[38;5;158m'   # Healthy/success states
-PEACH='\033[38;5;215m'        # Warning states
-CORAL='\033[38;5;203m'        # Critical/error states
-SKY_BLUE='\033[38;5;117m'     # Headers/titles
-
-# Configuration
-EXPERTS_DIR="packages/cli/src/core/experts"
-STALE_THRESHOLD_DAYS=30
-MAX_LINES=200
-
-# Counters
-TOTAL=0
-PASSED=0
-WARNINGS=0
-FAILED=0
-
-# Help message
-show_help() {
-    echo "Usage: $0 [domain]"
-    echo ""
-    echo "Validate Agent Expert expertise.yaml files"
-    echo ""
-    echo "Options:"
-    echo "  domain    Validate only the specified domain (e.g., 'database', 'testing')"
-    echo "  --help    Show this help message"
-    echo ""
-    echo "Checks performed:"
-    echo "  - Schema validation (domain, last_updated, version fields)"
-    echo "  - Staleness check (last_updated > $STALE_THRESHOLD_DAYS days)"
-    echo "  - File size check (> $MAX_LINES lines)"
-    echo "  - Learnings check (empty learnings array)"
-    echo ""
-    echo "Examples:"
-    echo "  $0                 # Validate all expertise files"
-    echo "  $0 database        # Validate only database domain"
-    echo "  $0 --help          # Show this help"
-}
-
-# Check if yq is available (for better YAML parsing)
-has_yq() {
-    command -v yq &> /dev/null
-}
-
-# Extract YAML field using grep (fallback if yq not available)
-get_yaml_field() {
-    local file="$1"
-    local field="$2"
-    grep "^${field}:" "$file" 2>/dev/null | sed "s/^${field}:[[:space:]]*//" | tr -d '"' || echo ""
-}
-
-# Check if learnings is empty
-learnings_empty() {
-    local file="$1"
-    # Check for "learnings: []" or learnings with only comments
-    if grep -q "^learnings: \[\]" "$file" 2>/dev/null; then
-        return 0  # Empty
-    fi
-    # Check if there's actual content after learnings:
-    local after_learnings
-    after_learnings=$(sed -n '/^learnings:/,/^[a-z]/p' "$file" | grep -v "^#" | grep -v "^learnings:" | grep -v "^$" | head -1)
-    if [ -z "$after_learnings" ]; then
-        return 0  # Empty
-    fi
-    return 1  # Has content
-}
-
-# Get file line count
-get_line_count() {
-    wc -l < "$1" | tr -d ' '
-}
-
-# Calculate days since date
-days_since() {
-    local date_str="$1"
-    local date_epoch
-    local now_epoch
-
-    # Handle different date formats
-    if [[ "$date_str" =~ ^[0-9]{4}-[0-9]{2}-[0-9]{2}$ ]]; then
-        date_epoch=$(date -d "$date_str" +%s 2>/dev/null || date -j -f "%Y-%m-%d" "$date_str" +%s 2>/dev/null)
-    else
-        echo "999"  # Invalid date
-        return
-    fi
-
-    now_epoch=$(date +%s)
-    echo $(( (now_epoch - date_epoch) / 86400 ))
-}
-
-# Validate a single expertise file
-validate_expertise() {
-    local domain="$1"
-    local file="$EXPERTS_DIR/$domain/expertise.yaml"
-    local status="PASS"
-    local issues=()
-
-    TOTAL=$((TOTAL + 1))
-
-    # Check file exists
-    if [ ! -f "$file" ]; then
-        echo -e "${RED}FAIL${NC}  $domain - File not found: $file"
-        FAILED=$((FAILED + 1))
-        return 1
-    fi
-
-    # Schema validation
-    local domain_field version last_updated
-    domain_field=$(get_yaml_field "$file" "domain")
-    version=$(get_yaml_field "$file" "version")
-    last_updated=$(get_yaml_field "$file" "last_updated")
-
-    if [ -z "$domain_field" ]; then
-        issues+=("missing 'domain' field")
-        status="FAIL"
-    fi
-
-    if [ -z "$version" ]; then
-        issues+=("missing 'version' field")
-        status="FAIL"
-    fi
-
-    if [ -z "$last_updated" ]; then
-        issues+=("missing 'last_updated' field")
-        status="FAIL"
-    fi
-
-    # Staleness check
-    if [ -n "$last_updated" ]; then
-        local days_old
-        days_old=$(days_since "$last_updated")
-        if [ "$days_old" -gt "$STALE_THRESHOLD_DAYS" ]; then
-            issues+=("stale (${days_old} days since update)")
-            if [ "$status" = "PASS" ]; then
-                status="WARN"
-            fi
-        fi
-    fi
-
-    # File size check
-    local line_count
-    line_count=$(get_line_count "$file")
-    if [ "$line_count" -gt "$MAX_LINES" ]; then
-        issues+=("large file (${line_count} lines > ${MAX_LINES})")
-        if [ "$status" = "PASS" ]; then
-            status="WARN"
-        fi
-    fi
-
-    # Learnings check
-    if learnings_empty "$file"; then
-        issues+=("no learnings recorded (never self-improved)")
-        if [ "$status" = "PASS" ]; then
-            status="WARN"
-        fi
-    fi
-
-    # Output result (using vibrant 256-color palette)
-    case "$status" in
-        PASS)
-            echo -e "${MINT_GREEN}PASS${NC}  $domain"
-            PASSED=$((PASSED + 1))
-            ;;
-        WARN)
-            echo -e "${PEACH}WARN${NC}  $domain - ${issues[*]}"
-            WARNINGS=$((WARNINGS + 1))
-            ;;
-        FAIL)
-            echo -e "${CORAL}FAIL${NC}  $domain - ${issues[*]}"
-            FAILED=$((FAILED + 1))
-            ;;
-    esac
-}
-
-# Main
-main() {
-    # Handle help
-    if [ "$1" = "--help" ] || [ "$1" = "-h" ]; then
-        show_help
-        exit 0
-    fi
-
-    # Find script directory and change to repo root
-    local script_dir
-    script_dir="$(cd "$(dirname "${BASH_SOURCE[0]}")" && pwd)"
-    cd "$script_dir/.."
-
-    # Check experts directory exists
-    if [ ! -d "$EXPERTS_DIR" ]; then
-        echo -e "${CORAL}Error:${NC} Experts directory not found: $EXPERTS_DIR"
-        echo "Are you running this from the repository root?"
-        exit 1
-    fi
-
-    echo -e "${SKY_BLUE}Validating Agent Expert Files${NC}"
-    echo "================================"
-    echo ""
-
-    # Validate specific domain or all
-    if [ -n "$1" ]; then
-        # Single domain
-        if [ ! -d "$EXPERTS_DIR/$1" ]; then
-            echo -e "${CORAL}Error:${NC} Domain not found: $1"
-            echo "Available domains:"
-            ls -1 "$EXPERTS_DIR" | grep -v templates | grep -v README
-            exit 1
-        fi
-        validate_expertise "$1"
-    else
-        # All domains
-        for dir in "$EXPERTS_DIR"/*/; do
-            local domain
-            domain=$(basename "$dir")
-            # Skip templates directory
-            if [ "$domain" = "templates" ]; then
-                continue
-            fi
-            validate_expertise "$domain"
-        done
-    fi
-
-    # Summary (using vibrant 256-color palette)
-    echo ""
-    echo "================================"
-    echo -e "Total: $TOTAL | ${MINT_GREEN}Passed: $PASSED${NC} | ${PEACH}Warnings: $WARNINGS${NC} | ${CORAL}Failed: $FAILED${NC}"
-
-    # Exit code
-    if [ "$FAILED" -gt 0 ]; then
-        exit 1
-    fi
-    exit 0
-}
-
-main "$@"

package/scripts/validate-tokens.sh

@@ -1,73 +0,0 @@
-#!/bin/bash
-
-# AgileFlow Token Validation Script
-# Safely checks if required MCP tokens are present in .env WITHOUT exposing them
-# Security-first approach: shows token lengths, never displays actual values
-
-echo "🔐 Token Validation (Secure Check - No Tokens Exposed)"
-echo "========================================================="
-echo ""
-
-# Check if .env exists
-if [ ! -f .env ]; then
-  echo "❌ .env file NOT found"
-  echo ""
-  echo "To create .env, copy from template:"
-  echo "  cp .env.example .env"
-  echo "Then edit .env and add your real tokens (DO NOT COMMIT)"
-  exit 1
-fi
-
-echo "✅ .env file found"
-echo ""
-
-# Check GitHub token (secure - doesn't print value)
-if grep -q "^GITHUB_PERSONAL_ACCESS_TOKEN=" .env && ! grep -q "GITHUB_PERSONAL_ACCESS_TOKEN=$" .env; then
-  TOKEN_VALUE=$(grep "^GITHUB_PERSONAL_ACCESS_TOKEN=" .env | cut -d'=' -f2)
-  if [ -z "$TOKEN_VALUE" ] || [ "$TOKEN_VALUE" = "your_token_here" ] || [ "$TOKEN_VALUE" = "ghp_placeholder" ]; then
-    echo "⚠️  GITHUB_PERSONAL_ACCESS_TOKEN is set but appears to be placeholder"
-    echo "    → Replace with real token (starts with ghp_)"
-  else
-    echo "✅ GITHUB_PERSONAL_ACCESS_TOKEN is set (length: ${#TOKEN_VALUE})"
-  fi
-else
-  echo "⚠️  GITHUB_PERSONAL_ACCESS_TOKEN not found in .env"
-fi
-
-echo ""
-
-# Check Notion token (secure - doesn't print value)
-if grep -q "^NOTION_TOKEN=" .env && ! grep -q "NOTION_TOKEN=$" .env; then
-  TOKEN_VALUE=$(grep "^NOTION_TOKEN=" .env | cut -d'=' -f2)
-  if [ -z "$TOKEN_VALUE" ] || [ "$TOKEN_VALUE" = "your_token_here" ] || [[ "$TOKEN_VALUE" == *"placeholder"* ]]; then
-    echo "⚠️  NOTION_TOKEN is set but appears to be placeholder"
-    echo "    → Replace with real token (starts with ntn_ or secret_)"
-  else
-    echo "✅ NOTION_TOKEN is set (length: ${#TOKEN_VALUE})"
-  fi
-else
-  echo "ℹ️  NOTION_TOKEN not found in .env (optional if Notion not enabled)"
-fi
-
-echo ""
-echo "🔒 Security Check:"
-
-# Check .gitignore for .mcp.json
-if grep -q '^\\.mcp\\.json$' .gitignore 2>/dev/null; then
-  echo "✅ .mcp.json is in .gitignore"
-else
-  echo "❌ .mcp.json NOT in .gitignore (CRITICAL - must exclude!)"
-fi
-
-# Check .gitignore for .env
-if grep -q '^\\.env$' .gitignore 2>/dev/null; then
-  echo "✅ .env is in .gitignore"
-else
-  echo "❌ .env NOT in .gitignore (CRITICAL - must exclude!)"
-fi
-
-echo ""
-echo "If you added new tokens to .env, remember to:"
-echo "  1. Verify .mcp.json and .env are in .gitignore (NEVER commit them!)"
-echo "  2. 🔴 RESTART Claude Code for MCP servers to load new tokens"
-echo "  3. Test MCP commands after restart"

package/scripts/validators/README.md

@@ -1,143 +0,0 @@
-# Validators
-
-Specialized self-validation scripts for AgileFlow agents.
-
-## Overview
-
-Validators are Node.js scripts that run via hooks to verify agent output. They enable **closed-loop prompts** where validation is guaranteed, not optional.
-
-**Research**: See [ADR-0009](../../../docs/03-decisions/adr-0009-specialized-self-validating-agents.md)
-
----
-
-## Exit Codes
-
-| Code | Meaning | Behavior |
-|------|---------|----------|
-| `0` | Success | Proceed normally |
-| `2` | Error (blocking) | Stderr sent to Claude for self-correction |
-| Other | Warning | Log but continue |
-
-**Exit code 2 is special**: Claude receives stderr output and automatically attempts to fix the issue.
-
----
-
-## Input Format
-
-Validators receive JSON via stdin with tool context:
-
-```json
-{
-  "tool_name": "Write",
-  "tool_input": {
-    "file_path": "/path/to/file.json",
-    "content": "..."
-  },
-  "result": "File written successfully"
-}
-```
-
----
-
-## Validator Template
-
-```javascript
-#!/usr/bin/env node
-const fs = require('fs');
-
-let input = '';
-process.stdin.on('data', chunk => input += chunk);
-process.stdin.on('end', () => {
-  try {
-    const context = JSON.parse(input);
-    const filePath = context.tool_input?.file_path;
-
-    if (!filePath) {
-      console.log('No file path in context, skipping');
-      process.exit(0);
-    }
-
-    // Your validation logic here
-    const issues = validate(filePath);
-
-    if (issues.length > 0) {
-      // Exit 2 = Claude will try to fix these
-      console.error(`Resolve these issues in ${filePath}:`);
-      issues.forEach(i => console.error(`  - ${i}`));
-      process.exit(2);
-    }
-
-    console.log(`Validation passed: ${filePath}`);
-    process.exit(0);
-  } catch (e) {
-    // Exit 1 = warning, don't block
-    console.error(`Validator error: ${e.message}`);
-    process.exit(1);
-  }
-});
-
-function validate(filePath) {
-  const issues = [];
-  // Add your checks here
-  return issues;
-}
-```
-
----
-
-## Hook Configuration
-
-Add hooks to agent/command frontmatter:
-
-### PostToolUse (after each tool call)
-
-```yaml
-hooks:
-  PostToolUse:
-    - matcher: "Write"
-      hooks:
-        - type: command
-          command: "node .agileflow/hooks/validators/your-validator.js"
-```
-
-### Stop (when agent finishes)
-
-```yaml
-hooks:
-  Stop:
-    - hooks:
-        - type: command
-          command: "node .agileflow/hooks/validators/final-validator.js"
-```
-
----
-
-## Best Practices
-
-1. **Keep validators fast** (< 100ms) - they run on every matching tool call
-2. **Use specific matchers** - `"Write"` not `"Write|Edit|Read"`
-3. **Return helpful errors** - Claude uses stderr to fix issues
-4. **Test standalone first** - `echo '{"tool_input":{"file_path":"test.json"}}' | node validator.js`
-5. **Log success too** - helps debugging hook chains
-
----
-
-## Available Validators
-
-| Validator | Purpose | Matcher |
-|-----------|---------|---------|
-| `json-schema-validator.js` | Validate JSON structure | Write (*.json) |
-| `markdown-validator.js` | Validate markdown format | Write (*.md) |
-| `story-format-validator.js` | Validate story structure | Write (status.json) |
-
----
-
-## Testing Validators
-
-```bash
-# Test with sample input
-echo '{"tool_name":"Write","tool_input":{"file_path":"test.json","content":"{}"}}' | node json-schema-validator.js
-
-# Check exit code
-echo $?
-```