agentvibes 5.12.0-alpha.0 → 5.13.0

package/src/utils/preview-list-prompt.js

@@ -1,144 +1,144 @@
-/**
- * Custom Inquirer List Prompt with Spacebar Preview
- * Uses wrapper approach with readline keypress events
- */
-
-import readline from 'node:readline';
-import { execSync } from 'node:child_process';
-
-/**
- * Wrapper for inquirer list prompt that adds spacebar preview
- * @param {Object} inquirer - Inquirer instance
- * @param {Object} config - Prompt configuration
- * @param {Function} config.onPreview - Callback for preview (receives selected value)
- * @returns {Promise} Inquirer prompt promise
- */
-export async function createPreviewListPrompt(inquirer, config) {
-  const { onPreview, ...promptConfig } = config;
-
-  // Set up keypress listener
-  let keypressListener = null;
-
-  // Track playing state
-  let currentlyPlaying = null;
-  let audioProcess = null;
-
-  // Initialize currentSelection to match the default value
-  let currentSelection = 0;
-  if (promptConfig.default) {
-    const defaultIndex = promptConfig.choices.findIndex(c => c.value === promptConfig.default);
-    if (defaultIndex !== -1) {
-      currentSelection = defaultIndex;
-    }
-  }
-
-  // Function to stop currently playing audio
-  const stopAudio = () => {
-    // Kill the specific process if we have it
-    // SECURITY: Only kill our own process, never use pkill which affects all users
-    if (audioProcess) {
-      try {
-        audioProcess.kill('SIGKILL');
-        audioProcess = null;
-      } catch (e) {
-        // Process might have already finished or already killed
-      }
-    }
-
-    currentlyPlaying = null;
-  };
-
-  if (onPreview && process.stdin.isTTY) {
-    readline.emitKeypressEvents(process.stdin);
-    // SECURITY: Wrap in try-catch to prevent terminal corruption on error
-    try {
-      if (process.stdin.setRawMode) {
-        process.stdin.setRawMode(true);
-      }
-    } catch (e) {
-      // Failed to set raw mode, continue without it
-    }
-
-    keypressListener = async (str, key) => {
-      // Track current selection based on arrow keys
-      if (key && key.name === 'down') {
-        currentSelection = Math.min(currentSelection + 1, promptConfig.choices.length - 1);
-      } else if (key && key.name === 'up') {
-        currentSelection = Math.max(currentSelection - 1, 0);
-      }
-
-      if (key && key.name === 'space') {
-        // Get the current item (don't filter - use actual index)
-        const currentChoice = promptConfig.choices[currentSelection];
-
-        // Only preview if it's a valid choice (not separator, not special item)
-        if (currentChoice && currentChoice.value && !currentChoice.value.startsWith('__')) {
-
-          // Toggle: if same voice pressed twice, stop it
-          if (currentlyPlaying === currentChoice.value) {
-            stopAudio();
-            return;
-          }
-
-          // CRITICAL: Stop previous voice BEFORE starting new one
-          if (currentlyPlaying) {
-            stopAudio();
-            // Small delay to ensure kill takes effect
-            await new Promise(resolve => setTimeout(resolve, 100));
-          }
-
-          currentlyPlaying = currentChoice.value;
-
-          // Call onPreview and store process handle immediately
-          try {
-            const result = await onPreview(currentChoice.value);
-            // Store the process handle - onPreview should return the spawn() result
-            audioProcess = result;
-          } catch (err) {
-            console.error(`[Preview] Error playing sample:`, err.message);
-            currentlyPlaying = null;
-            audioProcess = null;
-          }
-        }
-      }
-    };
-
-    process.stdin.on('keypress', keypressListener);
-  }
-
-  try {
-    // Run the standard list prompt
-    const result = await inquirer.prompt([{
-      ...promptConfig,
-      type: 'list'
-    }]);
-
-    return result;
-  } finally {
-    // Stop any playing audio
-    stopAudio();
-
-    // Clean up keypress listener
-    if (keypressListener) {
-      process.stdin.removeListener('keypress', keypressListener);
-      // SECURITY: Wrap in try-catch to ensure cleanup always completes
-      try {
-        if (process.stdin.setRawMode) {
-          process.stdin.setRawMode(false);
-        }
-      } catch (e) {
-        // Failed to restore raw mode, but we're exiting anyway
-      }
-      // readline.emitKeypressEvents() put stdin into flowing mode; pause it so the
-      // open stdin handle no longer keeps the event loop alive after the prompt
-      // resolves (otherwise the process lingers until stdin is otherwise closed).
-      try {
-        process.stdin.pause();
-      } catch (e) {
-        // stdin may already be closed; nothing more to do
-      }
-    }
-  }
-}
-
-export default createPreviewListPrompt;
+/**
+ * Custom Inquirer List Prompt with Spacebar Preview
+ * Uses wrapper approach with readline keypress events
+ */
+
+import readline from 'node:readline';
+import { execSync } from 'node:child_process';
+
+/**
+ * Wrapper for inquirer list prompt that adds spacebar preview
+ * @param {Object} inquirer - Inquirer instance
+ * @param {Object} config - Prompt configuration
+ * @param {Function} config.onPreview - Callback for preview (receives selected value)
+ * @returns {Promise} Inquirer prompt promise
+ */
+export async function createPreviewListPrompt(inquirer, config) {
+  const { onPreview, ...promptConfig } = config;
+
+  // Set up keypress listener
+  let keypressListener = null;
+
+  // Track playing state
+  let currentlyPlaying = null;
+  let audioProcess = null;
+
+  // Initialize currentSelection to match the default value
+  let currentSelection = 0;
+  if (promptConfig.default) {
+    const defaultIndex = promptConfig.choices.findIndex(c => c.value === promptConfig.default);
+    if (defaultIndex !== -1) {
+      currentSelection = defaultIndex;
+    }
+  }
+
+  // Function to stop currently playing audio
+  const stopAudio = () => {
+    // Kill the specific process if we have it
+    // SECURITY: Only kill our own process, never use pkill which affects all users
+    if (audioProcess) {
+      try {
+        audioProcess.kill('SIGKILL');
+        audioProcess = null;
+      } catch (e) {
+        // Process might have already finished or already killed
+      }
+    }
+
+    currentlyPlaying = null;
+  };
+
+  if (onPreview && process.stdin.isTTY) {
+    readline.emitKeypressEvents(process.stdin);
+    // SECURITY: Wrap in try-catch to prevent terminal corruption on error
+    try {
+      if (process.stdin.setRawMode) {
+        process.stdin.setRawMode(true);
+      }
+    } catch (e) {
+      // Failed to set raw mode, continue without it
+    }
+
+    keypressListener = async (str, key) => {
+      // Track current selection based on arrow keys
+      if (key && key.name === 'down') {
+        currentSelection = Math.min(currentSelection + 1, promptConfig.choices.length - 1);
+      } else if (key && key.name === 'up') {
+        currentSelection = Math.max(currentSelection - 1, 0);
+      }
+
+      if (key && key.name === 'space') {
+        // Get the current item (don't filter - use actual index)
+        const currentChoice = promptConfig.choices[currentSelection];
+
+        // Only preview if it's a valid choice (not separator, not special item)
+        if (currentChoice && currentChoice.value && !currentChoice.value.startsWith('__')) {
+
+          // Toggle: if same voice pressed twice, stop it
+          if (currentlyPlaying === currentChoice.value) {
+            stopAudio();
+            return;
+          }
+
+          // CRITICAL: Stop previous voice BEFORE starting new one
+          if (currentlyPlaying) {
+            stopAudio();
+            // Small delay to ensure kill takes effect
+            await new Promise(resolve => setTimeout(resolve, 100));
+          }
+
+          currentlyPlaying = currentChoice.value;
+
+          // Call onPreview and store process handle immediately
+          try {
+            const result = await onPreview(currentChoice.value);
+            // Store the process handle - onPreview should return the spawn() result
+            audioProcess = result;
+          } catch (err) {
+            console.error(`[Preview] Error playing sample:`, err.message);
+            currentlyPlaying = null;
+            audioProcess = null;
+          }
+        }
+      }
+    };
+
+    process.stdin.on('keypress', keypressListener);
+  }
+
+  try {
+    // Run the standard list prompt
+    const result = await inquirer.prompt([{
+      ...promptConfig,
+      type: 'list'
+    }]);
+
+    return result;
+  } finally {
+    // Stop any playing audio
+    stopAudio();
+
+    // Clean up keypress listener
+    if (keypressListener) {
+      process.stdin.removeListener('keypress', keypressListener);
+      // SECURITY: Wrap in try-catch to ensure cleanup always completes
+      try {
+        if (process.stdin.setRawMode) {
+          process.stdin.setRawMode(false);
+        }
+      } catch (e) {
+        // Failed to restore raw mode, but we're exiting anyway
+      }
+      // readline.emitKeypressEvents() put stdin into flowing mode; pause it so the
+      // open stdin handle no longer keeps the event loop alive after the prompt
+      // resolves (otherwise the process lingers until stdin is otherwise closed).
+      try {
+        process.stdin.pause();
+      } catch (e) {
+        // stdin may already be closed; nothing more to do
+      }
+    }
+  }
+}
+
+export default createPreviewListPrompt;

package/src/utils/provider-validator.js

@@ -7,6 +7,64 @@ import { spawnSync } from 'node:child_process';
 import path from 'node:path'; // For safe path operations and traversal prevention
 import fs from 'node:fs'; // For checking file/directory existence
 import os from 'node:os'; // For os.homedir() to prevent HOME injection attacks
+import { listProviders, displayName as catalogDisplayName } from '../services/provider-catalog.js';
+
+/**
+ * Canonical set of TTS synthesis providers AgentVibes knows how to use.
+ * SINGLE SOURCE OF TRUTH: every user-facing dispatcher (MCP set_provider
+ * allowlist, voice switch, voice list, Windows provider manager) must recognise
+ * these providers — platform-scoped where noted below. A provider that lives
+ * here but is missing from a dispatcher is the "silent drop to Piper / Unknown
+ * provider" class of bug (see AVI-S8.1). The dispatcher-parity conformance test
+ * asserts this invariant.
+ *
+ * Platform notes: `macos` is Darwin-only; `windows-sapi`/`windows-piper` are
+ * Windows-only. `kokoro` ships a play-tts runtime on BOTH Unix
+ * (play-tts-kokoro.sh) and PowerShell (play-tts-kokoro.ps1). `elevenlabs` ships
+ * a Unix runtime only (play-tts-elevenlabs.sh) — there is NO
+ * play-tts-elevenlabs.ps1 yet — so it is recognised by the portable (bash/JS)
+ * dispatchers but intentionally excluded from the Windows provider manager
+ * until a PowerShell runtime lands (AVI-S8.2).
+ * @type {readonly string[]}
+ */
+export const SUPPORTED_PROVIDERS = Object.freeze(listProviders().map((p) => p.id));
+
+/**
+ * Providers that use the SAME id on every OS and have at least a Unix (bash)
+ * runtime. Every PORTABLE dispatcher — the MCP set_provider allowlist,
+ * voice-manager.sh, and list-voices.js — must recognise these regardless of
+ * platform. DERIVED VIEW over the catalog: the providers with a Unix runtime
+ * whose voices are enumerable without disk (static/name-to-id) — i.e. kokoro and
+ * elevenlabs.
+ * @type {readonly string[]}
+ */
+export const CROSS_PLATFORM_PROVIDERS = Object.freeze(
+  listProviders()
+    .filter((p) => p.runtime.unix !== null && (p.voiceModel === 'static' || p.voiceModel === 'name-to-id'))
+    .map((p) => p.id),
+);
+
+/**
+ * Subset of {@link CROSS_PLATFORM_PROVIDERS} that ALSO ships a PowerShell runtime
+ * (play-tts-*.ps1), so the Windows provider manager (provider-manager.ps1) must
+ * recognise them too. `elevenlabs` is excluded until play-tts-elevenlabs.ps1
+ * exists (AVI-S8.2). DERIVED VIEW over the catalog.
+ * @type {readonly string[]}
+ */
+export const WINDOWS_RUNTIME_PROVIDERS = Object.freeze(
+  listProviders()
+    .filter((p) => p.runtime.unix !== null && (p.voiceModel === 'static' || p.voiceModel === 'name-to-id') && p.runtime.windows !== null)
+    .map((p) => p.id),
+);
+
+/**
+ * Is `name` a provider AgentVibes canonically supports?
+ * @param {string} name
+ * @returns {boolean}
+ */
+export function isKnownProvider(name) {
+  return SUPPORTED_PROVIDERS.includes(String(name || '').toLowerCase());
+}
 
 /**
  * Helper: Check if command exists in PATH
@@ -603,16 +661,8 @@ function getPackageInfo(pkgName) {
  * @returns {string} Display name
  */
 export function getProviderDisplayName(providerName) {
-  const names = {
-    soprano: 'Soprano TTS',
-    piper: 'Piper TTS',
-    kokoro: 'Kokoro TTS',
-    elevenlabs: 'ElevenLabs',
-    macos: 'macOS Say',
-    sapi: 'Windows SAPI',
-    'windows-sapi': 'Windows SAPI',
-    'windows-piper': 'Piper TTS'
-  };
-
-  return names[providerName] || providerName;
+  // DERIVED VIEW: delegate to the Provider Catalog (single source of truth for
+  // display names). The catalog resolves aliases (e.g. 'sapi' → Windows SAPI) and
+  // passes unknown ids through unchanged, preserving this function's contract.
+  return catalogDisplayName(providerName);
 }