agentvibes 5.12.0-alpha.0 → 5.13.0

package/src/installer.js

@@ -141,6 +141,33 @@ async function saveManifest(manifestPath, files) {
 //   • dest hash == manifest hash       → copy  (action: 'updated')
 //   • dest hash != manifest hash       → skip  (action: 'skipped', .user.bak saved)
 //   • no manifest entry yet            → copy  (action: 'updated')
+// Preserve destPath's CURRENT content in a sidecar backup before anything
+// overwrites it. Never clobbers an existing .user.bak — that backup may hold the
+// only surviving copy of an earlier customization; a second backup gets a
+// content-stamped name instead. Returns true only when the current content is
+// safely stored somewhere, so callers can refuse to overwrite when it isn't.
+async function backupUserFile(destPath) {
+  const bak = `${destPath}.user.bak`;
+  try {
+    const currentHash = await computeFileHash(destPath);
+    if (!currentHash) return false;
+
+    const existingHash = await computeFileHash(bak);
+    if (existingHash === currentHash) return true; // already backed up
+
+    if (existingHash) {
+      // A different backup exists — keep it and stamp this one.
+      await fs.copyFile(destPath, `${destPath}.user.bak.${currentHash.slice(0, 8)}`);
+      return true;
+    }
+
+    await fs.copyFile(destPath, bak);
+    return true;
+  } catch {
+    return false;
+  }
+}
+
 async function manifestSafeCopy(srcPath, destPath, manifest) {
   const srcHash = await computeFileHash(srcPath);
   if (!srcHash) return { action: 'skipped', hash: null }; // src missing
@@ -157,15 +184,29 @@ async function manifestSafeCopy(srcPath, destPath, manifest) {
   }
 
   const manifestHash = manifest[destPath]?.hash;
-  if (manifestHash && destHash !== manifestHash) {
-    // User modified the file since we last installed it — preserve it
-    try { await fs.copyFile(destPath, destPath + '.user.bak'); } catch { /* best effort */ }
-    return { action: 'skipped', hash: destHash };
+
+  if (manifestHash) {
+    if (destHash !== manifestHash) {
+      // User modified the file since we last installed it — preserve it
+      await backupUserFile(destPath);
+      return { action: 'skipped', hash: destHash };
+    }
+    // Byte-identical to what we last installed — untouched, ours to update
+    await fs.copyFile(srcPath, destPath);
+    return { action: 'updated', hash: srcHash };
   }
 
-  // Stock file (or no manifest entry yet) — safe to overwrite
+  // No manifest entry, and dest differs from what we ship. This is either a
+  // user's customized file or an older stock copy predating the manifest — the
+  // two are indistinguishable, so we must assume it could be a customization.
+  // Back it up before overwriting, and if the backup can't be secured, refuse
+  // to overwrite at all rather than destroy the only copy.
+  // (CLAUDE.md: never overwrite existing user .claude/ config.)
+  if (!(await backupUserFile(destPath))) {
+    return { action: 'skipped', hash: destHash };
+  }
   await fs.copyFile(srcPath, destPath);
-  return { action: 'updated', hash: srcHash };
+  return { action: 'updated', hash: srcHash, backedUp: true };
 }
 
 // Delete only the files listed in manifest that reside under baseDir.
@@ -3593,14 +3634,17 @@ async function copyCommandFiles(targetDir, spinner) {
  */
 function shouldIncludeHookFile(file, stat) {
   if (isNativeWindows()) {
-    // Include .ps1 scripts, .py helpers, and hooks.json; exclude dotfiles and prepare-release
+    // Include .ps1 scripts, .py helpers, hooks.json, and the generated
+    // provider-catalog.json; exclude dotfiles and prepare-release
     return stat.isFile() &&
-           (file.endsWith('.ps1') || file.endsWith('.py') || file === 'hooks.json') &&
+           (file.endsWith('.ps1') || file.endsWith('.py') || file === 'hooks.json' ||
+            file === 'provider-catalog.json') &&
            !file.includes('prepare-release') &&
            !file.startsWith('.');
   }
   return stat.isFile() &&
-         (file.endsWith('.sh') || file.endsWith('.py') || file === 'hooks.json') &&
+         (file.endsWith('.sh') || file.endsWith('.py') || file === 'hooks.json' ||
+          file === 'provider-catalog.json') &&
          !file.includes('prepare-release') &&
          !file.startsWith('.');
 }
@@ -5668,6 +5712,16 @@ async function performUpdateOperations(targetDir, spinner) {
   spinner.text = 'Checking for old configuration...';
   await detectAndMigrateOldConfig(targetDir, spinner);
 
+  // Upgrade safety for the new opt-in injection gate (session-start-tts.sh):
+  // a project that was already installed and talking pre-gate has no marker, so
+  // the gate would newly silence it. Backfill the enable marker for a PROJECT
+  // update so existing users keep their audio. A GLOBAL (home-dir) update stays
+  // opt-in — and we say so, otherwise the user's voice just stops with no clue.
+  if ((await configureInjectionScope(targetDir)) === 'global') {
+    console.log('');
+    warnGlobalInjectionScope();
+  }
+
   return {
     commandCount,
     hookCount: hookResult.count,
@@ -5721,6 +5775,61 @@ async function updateAgentVibes(targetDir, options) {
   }
 }
 
+/**
+ * Configure the session-start injection opt-in marker for this install/update.
+ *
+ * - PROJECT install → drop `.claude/agentvibes-enabled` so session-start-tts.sh
+ *   injects the TTS protocol for THIS project (and only this one), preserving the
+ *   "install in a project and it just works" experience.
+ * - GLOBAL install (target === home dir) → write nothing; injecting into every
+ *   session is exactly the "cacophony of agents" we are preventing.
+ *
+ * Uses `agentvibes-enabled`, NOT `agentvibes-unmuted`, on purpose: the unmuted
+ * marker OVERRIDES a global mute in play-tts.sh, so writing it here would let an
+ * install/update silently defeat a user's `~/.agentvibes-muted` kill-switch.
+ * Non-destructive: never touches an existing mute/unmute/enabled choice.
+ *
+ * @param {string} targetDir - install target
+ * @returns {Promise<'global'|'enabled'|'kept'|'error'>} what happened (for messaging)
+ */
+async function configureInjectionScope(targetDir) {
+  try {
+    // path.relative is case-insensitive on win32 and normalizes separators, so a
+    // lowercase drive letter or trailing slash no longer misdetects a home
+    // install; realpath (best-effort) also collapses a symlinked $HOME.
+    let resolvedTarget = path.resolve(targetDir);
+    let resolvedHome = path.resolve(os.homedir());
+    try { resolvedTarget = fsSync.realpathSync.native(resolvedTarget); } catch { /* dir may not exist yet */ }
+    try { resolvedHome = fsSync.realpathSync.native(resolvedHome); } catch { /* ignore */ }
+    if (path.relative(resolvedHome, resolvedTarget) === '') return 'global';
+
+    const claudeDir = path.join(targetDir, '.claude');
+    // Respect any prior explicit choice — enabled OR either mute/unmute marker.
+    for (const m of ['agentvibes-enabled', 'agentvibes-unmuted', 'agentvibes-muted']) {
+      if (await fs.access(path.join(claudeDir, m)).then(() => true).catch(() => false)) {
+        return 'kept';
+      }
+    }
+    await fs.mkdir(claudeDir, { recursive: true });
+    await fs.writeFile(path.join(claudeDir, 'agentvibes-enabled'), '', 'utf8');
+    return 'enabled';
+  } catch (err) {
+    // Never fail install/update over the marker, but don't swallow silently —
+    // a read-only FS here would otherwise produce a mysterious "silent" project.
+    console.log(chalk.gray(`   (Could not set TTS injection marker: ${err.code || err.message}. Run /agent-vibes:unmute to enable.)`));
+    return 'error';
+  }
+}
+
+// Print the "global install stays silent" guidance (shared by install + update).
+function warnGlobalInjectionScope() {
+  console.log(chalk.yellow.bold('  ⚠  Global install detected (installed at your home directory)'));
+  console.log(chalk.gray('     TTS stays OFF by default so it will NOT talk in every session at once.'));
+  console.log(chalk.gray('     Enable it in a specific project with:  ') + chalk.cyan('/agent-vibes:unmute'));
+  console.log(chalk.gray('     (or re-run the installer inside a project folder, not your home dir).'));
+  console.log('');
+}
+
 // Installation function
 async function install(options = {}) {
   const currentDir = process.env.INIT_CWD || process.cwd();
@@ -6243,6 +6352,11 @@ def _strip_markdown(text: str) -> str:
     console.log(chalk.magenta('  \u2661  Sponsor this Developer  github.com/sponsors/paulpreibisch'));
     console.log('');
 
+    // Opt-in injection marker (prevents the global-install cacophony). See
+    // configureInjectionScope: project installs enable THIS project; a home-dir
+    // install stays silent. Uses agentvibes-enabled so it can't override a global mute.
+    if ((await configureInjectionScope(targetDir)) === 'global') warnGlobalInjectionScope();
+
     if (!(options.nonInteractive || process.env.AGENT_VIBES_NON_INTERACTIVE === '1')) {
       // Clean final summary
       console.log('');
@@ -6997,7 +7111,7 @@ export {
   CRITICAL_HOOKS, CRITICAL_HOOKS_WINDOWS,
   // Manifest utilities (used by tests and external tooling)
   getProjectManifestPath, getGlobalManifestPath,
-  loadManifest, saveManifest, computeFileHash, manifestSafeCopy, removeManifestFiles,
+  loadManifest, saveManifest, computeFileHash, manifestSafeCopy, backupUserFile, removeManifestFiles,
   // Pure helper functions exported for testing
   readJsonConfigSafe, backupConfigFile,
   isPiperProvider, supportsEmoji, getPersonalityIcon,

package/src/services/language-service.js

@@ -1,47 +1,47 @@
-/**
- * LanguageService — single source of truth for the selected UI language.
- *
- * Persists the selection to ~/.claude/config/language.txt so it survives
- * process restarts.  Notifies registered listeners on every change so the
- * TUI can re-render dynamic labels immediately.
- */
-
-import fs from 'node:fs';
-import path from 'node:path';
-import os from 'node:os';
-import { t, SUPPORTED_LANGUAGES } from '../i18n/strings.js';
-
-const LANG_FILE = path.join(os.homedir(), '.claude', 'config', 'language.txt');
-const VALID_LANGS = new Set(SUPPORTED_LANGUAGES.map(l => l.value));
-
-export class LanguageService {
-  constructor() {
-    this._lang = this._load();
-    this._listeners = [];
-  }
-
-  _load() {
-    try {
-      const val = fs.readFileSync(LANG_FILE, 'utf8').trim();
-      return VALID_LANGS.has(val) ? val : 'en';
-    } catch {
-      return 'en';
-    }
-  }
-
-  getLang() { return this._lang; }
-
-  setLang(lang) {
-    if (!VALID_LANGS.has(lang)) return;
-    this._lang = lang;
-    try {
-      fs.mkdirSync(path.dirname(LANG_FILE), { recursive: true });
-      fs.writeFileSync(LANG_FILE, lang, { mode: 0o600 });
-    } catch { /* non-fatal */ }
-    this._listeners.forEach(fn => fn(lang));
-  }
-
-  onChange(fn) { this._listeners.push(fn); }
-
-  t(key) { return t(this._lang, key); }
-}
+/**
+ * LanguageService — single source of truth for the selected UI language.
+ *
+ * Persists the selection to ~/.claude/config/language.txt so it survives
+ * process restarts.  Notifies registered listeners on every change so the
+ * TUI can re-render dynamic labels immediately.
+ */
+
+import fs from 'node:fs';
+import path from 'node:path';
+import os from 'node:os';
+import { t, SUPPORTED_LANGUAGES } from '../i18n/strings.js';
+
+const LANG_FILE = path.join(os.homedir(), '.claude', 'config', 'language.txt');
+const VALID_LANGS = new Set(SUPPORTED_LANGUAGES.map(l => l.value));
+
+export class LanguageService {
+  constructor() {
+    this._lang = this._load();
+    this._listeners = [];
+  }
+
+  _load() {
+    try {
+      const val = fs.readFileSync(LANG_FILE, 'utf8').trim();
+      return VALID_LANGS.has(val) ? val : 'en';
+    } catch {
+      return 'en';
+    }
+  }
+
+  getLang() { return this._lang; }
+
+  setLang(lang) {
+    if (!VALID_LANGS.has(lang)) return;
+    this._lang = lang;
+    try {
+      fs.mkdirSync(path.dirname(LANG_FILE), { recursive: true });
+      fs.writeFileSync(LANG_FILE, lang, { mode: 0o600 });
+    } catch { /* non-fatal */ }
+    this._listeners.forEach(fn => fn(lang));
+  }
+
+  onChange(fn) { this._listeners.push(fn); }
+
+  t(key) { return t(this._lang, key); }
+}

package/src/services/navigation-service.js

@@ -7,7 +7,7 @@
  */
 
 /** Ordered list of all tab IDs — used for cycling and validation */
-export const TAB_ORDER = ['setup', 'settings', 'voices', 'music', 'agents', 'receiver', 'readme', 'help'];
+export const TAB_ORDER = ['setup', 'settings', 'music', 'agents', 'receiver', 'readme', 'help'];
 
 export class NavigationService {
   /**