agentvibes 5.12.0-alpha.0 → 5.13.0

package/src/console/app.js

@@ -22,7 +22,6 @@ import { FOOTER_CONFIG, DEFAULT_FOOTER_COLOR } from './footer-config.js';
 import { createModalOverlay } from './modals/modal-overlay.js';
 import { BRAND_PINK } from './brand-colors.js';
 import { createSettingsTab } from './tabs/settings-tab.js';
-import { createVoicesTab } from './tabs/voices-tab.js';
 import { createMusicTab } from './tabs/music-tab.js';
 import { createSetupTab } from './tabs/setup-tab.js';
 import { createHelpTab } from './tabs/help-tab.js';
@@ -728,13 +727,6 @@ export class AgentVibesConsole {
     };
     this.tabs['settings'] = createSettingsTab(this.screen, services);
 
-    // Destroy voices placeholder and mount real voices tab
-    const voicesPlaceholder = this.tabs['voices'];
-    if (voicesPlaceholder && typeof voicesPlaceholder.destroy === 'function') {
-      voicesPlaceholder.destroy();
-    }
-    this.tabs['voices'] = createVoicesTab(this.screen, services);
-
     // Destroy music placeholder and mount real music tab
     const musicPlaceholder = this.tabs['music'];
     if (musicPlaceholder && typeof musicPlaceholder.destroy === 'function') {
@@ -923,7 +915,7 @@ export class AgentVibesConsole {
  *
  * @param {object} opts
  * @param {string} [opts.startTab='settings'] - Which tab to show on launch.
- *   Used by story 6.5 (command routing). Values: 'settings' | 'install' | 'voices' | 'music'
+ *   Used by story 6.5 (command routing). Values: 'settings' | 'setup' | 'music'
  * @param {boolean} [opts._testMode=false] - Internal: skip render in test environments.
  * @returns {Promise<AgentVibesConsole>}
  */

package/src/console/bling.js

@@ -0,0 +1,71 @@
+/**
+ * AgentVibes — Shared "bling" readiness cue.
+ *
+ * A short, fire-and-forget chime played the instant a preview is committed, so
+ * silence during synthesis / an SSH round-trip never reads as a hang. Used by
+ * BOTH the voice picker (setup-tab.js) and the music-preview surfaces
+ * (music-tab.js, track-picker.js) so they can't drift.
+ *
+ * `buildBlingCommand` was originally defined in setup-tab.js; it was moved here
+ * and is re-exported from setup-tab.js for backward compatibility (existing
+ * imports and tests keep working).
+ */
+
+import fs from 'node:fs';
+import path from 'node:path';
+import { spawn } from 'node:child_process';
+
+/**
+ * Build the fire-and-forget "preview ready" cue command for a platform. Pure
+ * (no spawning here, so it is unit-testable). Plays the bundled CC0 wav when
+ * present, else falls back to a system sound (Windows) / freedesktop cue or
+ * terminal bell (POSIX). stdio is ignored by the caller, so the POSIX bell is
+ * redirected to /dev/tty rather than the discarded stdout.
+ * @param {string} platform - process.platform value
+ * @param {string} wavPath - absolute path to the bling wav
+ * @param {boolean} haveWav - whether wavPath exists on disk
+ * @returns {{command: string, args: string[]}}
+ */
+export function buildBlingCommand(platform, wavPath, haveWav) {
+  if (platform === 'win32') {
+    const ps = haveWav
+      ? `Add-Type -AssemblyName System.Windows.Forms; (New-Object System.Media.SoundPlayer('${wavPath.replace(/'/g, "''")}')).PlaySync()`
+      : '[System.Media.SystemSounds]::Asterisk.Play(); Start-Sleep -Milliseconds 700';
+    return { command: 'powershell', args: ['-NoProfile', '-Command', ps] };
+  }
+  if (haveWav) {
+    // Pass wavPath as a positional arg ($1) so the path is never interpolated
+    // into the shell string (prevents injection / breakage on special chars).
+    const sh = 'paplay "$1" 2>/dev/null || aplay -q "$1" 2>/dev/null || printf "\\a" > /dev/tty 2>/dev/null';
+    return { command: 'bash', args: ['-c', sh, '--', wavPath] };
+  }
+  const sh = 'paplay /usr/share/sounds/freedesktop/stereo/message.oga 2>/dev/null || printf "\\a" > /dev/tty 2>/dev/null';
+  return { command: 'bash', args: ['-c', sh] };
+}
+
+/**
+ * Resolve the bundled CC0 bling wav for a package root.
+ * Sound: "Ui sounds - Shimmering success" by Philip_Berger, CC0 (freesound
+ * #648212). See .claude/audio/ui/CREDITS.txt.
+ * @param {string} packageRoot - AgentVibes package/repo root
+ * @returns {string}
+ */
+export function resolveBlingWav(packageRoot) {
+  return path.join(packageRoot, '.claude', 'audio', 'ui', 'bling-success.wav');
+}
+
+/**
+ * Play the readiness cue, fire-and-forget. Detached + unref'd + errors
+ * swallowed, so it never blocks the UI or fails a preview. A missing wav falls
+ * back to a platform system sound via buildBlingCommand.
+ * @param {string} packageRoot - AgentVibes package/repo root
+ */
+export function playBlingCue(packageRoot) {
+  try {
+    const wav = resolveBlingWav(packageRoot);
+    const { command, args } = buildBlingCommand(process.platform, wav, fs.existsSync(wav));
+    const cue = spawn(command, args, { stdio: 'ignore', detached: true }); // NOSONAR
+    cue.on('error', () => { /* best-effort cue; a spawn failure must not surface */ });
+    cue.unref();
+  } catch { /* the readiness cue is purely cosmetic — never break the preview */ }
+}

package/src/console/brand-colors.js

@@ -1,13 +1,13 @@
-/**
- * AgentVibes TUI — Brand Color Constants
- *
- * Single source of truth for the two primary brand colors.
- * Change BRAND_PINK or BRAND_BLUE here to update every modal title,
- * button, and the "Vibes" logotype across the entire TUI.
- */
-
-/** Magenta-pink used for modal titles and the "Vibes" logotype. */
-export const BRAND_PINK = '#f06292';  // Light magenta — Pink 300
-
-/** Indigo blue used for default button backgrounds and primary accents. */
-export const BRAND_BLUE = '#3949ab';
+/**
+ * AgentVibes TUI — Brand Color Constants
+ *
+ * Single source of truth for the two primary brand colors.
+ * Change BRAND_PINK or BRAND_BLUE here to update every modal title,
+ * button, and the "Vibes" logotype across the entire TUI.
+ */
+
+/** Magenta-pink used for modal titles and the "Vibes" logotype. */
+export const BRAND_PINK = '#f06292';  // Light magenta — Pink 300
+
+/** Indigo blue used for default button backgrounds and primary accents. */
+export const BRAND_BLUE = '#3949ab';

package/src/console/constants/personalities.js

@@ -1,44 +1,44 @@
-/**
- * AgentVibes — Canonical personality constants.
- *
- * Single source of truth for personality names and their associated emoji
- * glyphs.  All TUI modules (settings-tab, agents-tab, personality-picker …)
- * import from here; src/installer.js maintains its own copy because it
- * predates the TUI and uses a different module-load path.
- *
- * Exported:
- *   PERSONALITY_EMOJIS  — Map of personality name → emoji string
- *   PERSONALITIES       — Ordered array of personality names (canonical order
- *                         used for picker lists)
- */
-
-export const PERSONALITY_EMOJIS = Object.freeze({
-  angry:        '😠',
-  annoying:     '😤',
-  crass:        '🤬',
-  dramatic:     '🎭',
-  'dry-humor':  '😐',
-  flirty:       '😘',
-  funny:        '😂',
-  grandpa:      '👴',
-  millennial:   '🙄',
-  moody:        '😒',
-  none:         '😊',
-  normal:       '😊',
-  pirate:       '⚓',
-  poetic:       '📜',
-  professional: '👔',
-  rapper:       '🎤',
-  robot:        '🤖',
-  sarcastic:    '😏',
-  sassy:        '💁',
-  'surfer-dude':'🏄',
-  zen:          '🧘',
-});
-
-export const PERSONALITIES = Object.freeze([
-  'none', 'angry', 'annoying', 'crass', 'dramatic', 'dry-humor',
-  'flirty', 'funny', 'grandpa', 'millennial', 'moody', 'normal',
-  'pirate', 'poetic', 'professional', 'rapper', 'robot', 'sarcastic',
-  'sassy', 'surfer-dude', 'zen',
-]);
+/**
+ * AgentVibes — Canonical personality constants.
+ *
+ * Single source of truth for personality names and their associated emoji
+ * glyphs.  All TUI modules (settings-tab, agents-tab, personality-picker …)
+ * import from here; src/installer.js maintains its own copy because it
+ * predates the TUI and uses a different module-load path.
+ *
+ * Exported:
+ *   PERSONALITY_EMOJIS  — Map of personality name → emoji string
+ *   PERSONALITIES       — Ordered array of personality names (canonical order
+ *                         used for picker lists)
+ */
+
+export const PERSONALITY_EMOJIS = Object.freeze({
+  angry:        '😠',
+  annoying:     '😤',
+  crass:        '🤬',
+  dramatic:     '🎭',
+  'dry-humor':  '😐',
+  flirty:       '😘',
+  funny:        '😂',
+  grandpa:      '👴',
+  millennial:   '🙄',
+  moody:        '😒',
+  none:         '😊',
+  normal:       '😊',
+  pirate:       '⚓',
+  poetic:       '📜',
+  professional: '👔',
+  rapper:       '🎤',
+  robot:        '🤖',
+  sarcastic:    '😏',
+  sassy:        '💁',
+  'surfer-dude':'🏄',
+  zen:          '🧘',
+});
+
+export const PERSONALITIES = Object.freeze([
+  'none', 'angry', 'annoying', 'crass', 'dramatic', 'dry-humor',
+  'flirty', 'funny', 'grandpa', 'millennial', 'moody', 'normal',
+  'pirate', 'poetic', 'professional', 'rapper', 'robot', 'sarcastic',
+  'sassy', 'surfer-dude', 'zen',
+]);

package/src/console/footer-config.js

@@ -19,10 +19,6 @@ export const FOOTER_CONFIG = {
     color: '#2196f3',
     text: ` ${key('↑↓')} Navigate  ${key('←→')} Same Row  ${key('Enter')} Activate  ${key('Space')} Preview  ${key('Esc')} Cancel`,
   },
-  voices: {
-    color: '#00bcd4',
-    text: ` ${key('1-6')} Sort  ${key('/')} Search  ${key('P')} Provider  ${key('F')} Favorites  ${key('Space')} Preview  ${key('*')} Fav  ${key('I')} Install`,
-  },
   music: {
     color: '#ff9800',
     text: ` ${key('Space')} Preview  ${key('Enter')} Select  ${key('M')} Toggle  ${key('*')} Fav  ${key('F')} Filter  ${key('↑↓')} Navigate`,

package/src/console/music-preview.js

@@ -0,0 +1,79 @@
+/**
+ * AgentVibes — Shared music-preview transport helpers.
+ *
+ * Both music-preview surfaces (the Music tab and the track-picker widget) must
+ * make the same remote-vs-local decision: a transport provider routes audio to
+ * a remote receiver, so a local MP3 preview would be silent on a headless box
+ * and must be forwarded instead. This module holds the provider-resolve and the
+ * remote-forward spawn so the two surfaces can't drift.
+ *
+ * The caller owns UI feedback (status text, error messages) and attaches its own
+ * exit/error/stderr handlers to the returned child process.
+ */
+
+import fs from 'node:fs';
+import path from 'node:path';
+import os from 'node:os';
+import { spawn } from 'node:child_process';
+
+// Transport providers route audio to a remote receiver; local MP3 playback is
+// silent on a headless/remote box, so track previews must be forwarded instead.
+export const REMOTE_PROVIDERS = ['ssh-remote', 'agentvibes-receiver'];
+
+/**
+ * Resolve the active provider and the project dir it was read from, using the
+ * same search order as the voice pickers (CLAUDE_PROJECT_DIR → cwd → package →
+ * home). Returns { remote, projectDir } so a remote preview can forward the
+ * track to the receiver and tell the sender which .claude dir to resolve.
+ * @param {string} packageRoot - AgentVibes package/repo root (package fallback)
+ * @returns {{ remote: boolean, projectDir: string }}
+ */
+export function resolveMusicProvider(packageRoot) {
+  const dirs = [process.env.CLAUDE_PROJECT_DIR, process.cwd(), packageRoot, os.homedir()].filter(Boolean);
+  for (const d of dirs) {
+    const p = path.join(d, '.claude', 'tts-provider.txt');
+    try {
+      if (fs.existsSync(p)) {
+        const provider = fs.readFileSync(p, 'utf8').trim();
+        return { remote: REMOTE_PROVIDERS.includes(provider), projectDir: d };
+      }
+    } catch { /* next */ }
+  }
+  return { remote: false, projectDir: '' };
+}
+
+/**
+ * Resolve the SSH sender script path, preferring the package-bundled copy and
+ * falling back to the project's .claude/hooks copy.
+ * @param {string} packageRoot
+ * @param {string} projectDir
+ * @returns {string}
+ */
+export function resolveRemoteSender(packageRoot, projectDir) {
+  const pkgSender = path.resolve(packageRoot, '.claude', 'hooks', 'play-tts-ssh-remote.sh');
+  return fs.existsSync(pkgSender)
+    ? pkgSender
+    : path.join(projectDir, '.claude', 'hooks', 'play-tts-ssh-remote.sh');
+}
+
+/**
+ * Spawn the SSH sender to forward a music track to the receiver, or stop the
+ * current one. Fire-and-forget (the sender exits after handing the payload to
+ * SSH; the receiver plays/stops asynchronously). Returns the child process so
+ * the caller can wire its own exit/error/stderr handlers for UI feedback.
+ *
+ * @param {object} opts
+ * @param {string} opts.packageRoot
+ * @param {string} opts.projectDir
+ * @param {object} opts.env         - base spawn env (e.g. buildAudioEnv())
+ * @param {string} [opts.track]     - track filename to play (ignored when stop)
+ * @param {boolean} [opts.stop]     - send an explicit music-stop signal instead
+ * @returns {import('node:child_process').ChildProcess}
+ */
+export function spawnMusicRemote({ packageRoot, projectDir, env, track = null, stop = false }) {
+  const senderPath = resolveRemoteSender(packageRoot, projectDir);
+  const spawnEnv = { ...env, CLAUDE_PROJECT_DIR: projectDir };
+  if (stop) spawnEnv.AGENTVIBES_MUSIC_STOP = '1';
+  else spawnEnv.AGENTVIBES_MUSIC_ONLY = track;
+  return spawn('bash', [senderPath, '', ''], { stdio: ['ignore', 'ignore', 'pipe'], detached: true, env: spawnEnv }); // NOSONAR
+}

package/src/console/navigation.js

@@ -9,7 +9,6 @@
 /** Map of key → tab ID for global tab shortcut keys */
 const KEY_TO_TAB = {
   's': 'settings', 'S': 'settings',
-  'v': 'voices',   'V': 'voices',
   'm': 'music',    'M': 'music',
   'b': 'agents',   'B': 'agents',
   'x': 'receiver', 'X': 'receiver',

package/src/console/tabs/agents-tab.js

@@ -28,6 +28,7 @@ import crypto from 'node:crypto';
 import fs from 'node:fs';
 import os from 'node:os';
 import path from 'node:path';
+import { fileURLToPath } from 'node:url';
 import { spawn } from 'node:child_process';
 
 // Max pretext length to prevent excessively long TTS utterances
@@ -235,6 +236,17 @@ ${_tl('bmadDesc')}
   // Capture cwd once at construction (L1 fix)
   const _projectRoot = process.cwd();
 
+  // Preview hooks: prefer the CURRENT package copy over the project-local
+  // .claude/hooks, which a tarball reinstall does NOT refresh (npm updates
+  // node_modules only). A stale project hook routes previews through an outdated
+  // sender (e.g. the old agentvibes-receiver→legacy-sender path). CLAUDE_PROJECT_DIR
+  // still points at _projectRoot so the hook reads the project's config/provider.
+  const _pkgClaudeDir = path.resolve(path.dirname(fileURLToPath(import.meta.url)), '..', '..', '..', '.claude');
+  function _hookScript(subdir, name) {
+    const pkg = path.join(_pkgClaudeDir, subdir, name);
+    return fs.existsSync(pkg) ? pkg : path.join(_projectRoot, '.claude', subdir, name);
+  }
+
   // Story 8.3 fix: Windows agent-preview temp-patches config files (personality.txt,
   // reverb-level.txt) to apply per-agent settings during a preview. Track every
   // patched file + its pre-patch content here so ALL of them can be restored —
@@ -1116,7 +1128,7 @@ ${_tl('bmadDesc')}
 
       if (_isWin) {
         // Windows: route through play-tts.ps1 (same pattern as non-Windows bash route)
-        const playTtsScript = path.join(_projectRoot, '.claude', 'hooks-windows', 'play-tts.ps1');
+        const playTtsScript = _hookScript('hooks-windows', 'play-tts.ps1');
         if (!fs.existsSync(playTtsScript)) return;
         _previewVoiceId = voiceId;
         if (!_vpClosed) { vpPreviewLine.setContent(`{bright-cyan-fg}♪ Playing: ${voiceId}...{/bright-cyan-fg}`); _refreshVP(); }
@@ -1131,7 +1143,7 @@ ${_tl('bmadDesc')}
       }
 
       // Non-Windows: use bash play-tts.sh
-      const playTtsScript = path.join(_projectRoot, '.claude', 'hooks', 'play-tts.sh');
+      const playTtsScript = _hookScript('hooks', 'play-tts.sh');
       if (!fs.existsSync(playTtsScript)) return;
 
       const remoteLlm = detectRemoteLlm();