@xenon-device-management/xenon 2.13.2 → 2.15.0

package/lib/test/integration/team-visibility-grid.spec.js

@@ -15,7 +15,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const authMiddleware_1 = require("../../src/middleware/authMiddleware");
 const grid_1 = __importDefault(require("../../src/app/routers/grid"));
 const typedi_1 = require("typedi");
@@ -23,8 +23,11 @@ const TeamService_1 = require("../../src/services/TeamService");
 const prisma_1 = require("../../src/prisma");
 const seedUser_1 = require("../helpers/seedUser");
 const device_store_1 = require("../../src/data-service/device-store");
+const scratch_database_1 = require("../helpers/scratch-database");
+const prisma_store_1 = require("../../src/data-service/prisma-store");
 describe('team visibility on /grid/devices (integration)', function () {
     this.timeout(60000);
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
     let sa;
     let aliceMember;
     let bobUnaffiliated;
@@ -43,6 +46,9 @@ describe('team visibility on /grid/devices (integration)', function () {
         teamB = yield typedi_1.Container.get(TeamService_1.TeamService).create(`p4a-team-b-${stamp}`);
         // Alice on team A only.
         yield typedi_1.Container.get(TeamService_1.TeamService).addMember(teamA.id, aliceMember.user.id);
+        // /devices lists the store grid.ts took when it was imported: Prisma under
+        // `npx mocha <file>`, Loki under `test:all` (NODE_ENV=test). So each phone
+        // is a Device row and is added to that store.
         store = device_store_1.DeviceStoreFactory.getStore();
         // Three test devices. Use minimal field set; the schema may have
         // additional optional fields we don't need to populate for this test.
@@ -77,18 +83,13 @@ describe('team visibility on /grid/devices (integration)', function () {
         });
         yield store.addDevices([teamBDev]);
     }));
+    // Loki is one collection for the whole process: take the phones back out.
+    // A Prisma store's rows went with the scratch database.
     after(() => __awaiter(this, void 0, void 0, function* () {
-        yield prisma_1.prisma.device.deleteMany({
-            where: { udid: { in: [SHARED_UDID, TEAM_A_UDID, TEAM_B_UDID] } },
-        });
-        yield prisma_1.prisma.teamMember.deleteMany({
-            where: { teamId: { in: [teamA.id, teamB.id] } },
-        });
-        yield prisma_1.prisma.team.delete({ where: { id: teamA.id } }).catch(() => undefined);
-        yield prisma_1.prisma.team.delete({ where: { id: teamB.id } }).catch(() => undefined);
-        yield sa.cleanup();
-        yield aliceMember.cleanup();
-        yield bobUnaffiliated.cleanup();
+        if (store instanceof prisma_store_1.PrismaDeviceStore)
+            return;
+        for (const udid of [SHARED_UDID, TEAM_A_UDID, TEAM_B_UDID])
+            yield store.removeDevices({ udid });
     }));
     function buildApp() {
         const app = (0, express_1.default)();
@@ -101,7 +102,7 @@ describe('team visibility on /grid/devices (integration)', function () {
         return rows.map((r) => r.udid);
     }
     it('SUPER_ADMIN sees all three test devices', () => __awaiter(this, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(buildApp()).get('/devices').set('Cookie', sa.cookie);
+        const r = yield (0, loopbackRequest_1.default)(buildApp()).get('/devices').set('Cookie', sa.cookie);
         (0, chai_1.expect)(r.status).to.equal(200);
         const got = udids(r.body);
         (0, chai_1.expect)(got).to.include(SHARED_UDID);
@@ -109,7 +110,7 @@ describe('team visibility on /grid/devices (integration)', function () {
         (0, chai_1.expect)(got).to.include(TEAM_B_UDID);
     }));
     it('Alice (team A member) sees shared + team A; not team B', () => __awaiter(this, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(buildApp()).get('/devices').set('Cookie', aliceMember.cookie);
+        const r = yield (0, loopbackRequest_1.default)(buildApp()).get('/devices').set('Cookie', aliceMember.cookie);
         (0, chai_1.expect)(r.status).to.equal(200);
         const got = udids(r.body);
         (0, chai_1.expect)(got).to.include(SHARED_UDID);
@@ -117,7 +118,7 @@ describe('team visibility on /grid/devices (integration)', function () {
         (0, chai_1.expect)(got).to.not.include(TEAM_B_UDID);
     }));
     it('Bob (no team) sees only the shared device', () => __awaiter(this, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(buildApp()).get('/devices').set('Cookie', bobUnaffiliated.cookie);
+        const r = yield (0, loopbackRequest_1.default)(buildApp()).get('/devices').set('Cookie', bobUnaffiliated.cookie);
         (0, chai_1.expect)(r.status).to.equal(200);
         const got = udids(r.body);
         (0, chai_1.expect)(got).to.include(SHARED_UDID);

package/lib/test/integration/team-visibility-leases.spec.js

@@ -15,7 +15,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const typedi_1 = require("typedi");
 const authMiddleware_1 = require("../../src/middleware/authMiddleware");
 const sdk_leases_1 = require("../../src/app/routers/sdk-leases");
@@ -24,6 +24,8 @@ const TeamService_1 = require("../../src/services/TeamService");
 const device_store_1 = require("../../src/data-service/device-store");
 const prisma_1 = require("../../src/prisma");
 const seedUser_1 = require("../helpers/seedUser");
+const scratch_database_1 = require("../helpers/scratch-database");
+const loki_stores_1 = require("../helpers/loki-stores");
 /**
  * SDK leases against the production store: the real auth middleware computes
  * the member's teams, and the Prisma store's match (a SQL where clause, not
@@ -32,6 +34,10 @@ const seedUser_1 = require("../helpers/seedUser");
  */
 describe('team boundary on SDK leases (integration)', function () {
     this.timeout(60000);
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
+    // The Prisma store this suite is about, under `test:all` too, whose
+    // NODE_ENV would hand the factory a Loki one.
+    (0, loki_stores_1.usePrismaStores)();
     let sa;
     let alice;
     let teamA;
@@ -63,15 +69,6 @@ describe('team boundary on SDK leases (integration)', function () {
         yield prisma_1.prisma.lease.deleteMany({ where: { deviceUdid: { in: UDIDS } } });
         yield prisma_1.prisma.device.updateMany({ where: { udid: { in: UDIDS } }, data: { busy: false } });
     }));
-    after(() => __awaiter(this, void 0, void 0, function* () {
-        yield prisma_1.prisma.lease.deleteMany({ where: { deviceUdid: { in: UDIDS } } });
-        yield prisma_1.prisma.device.deleteMany({ where: { udid: { in: UDIDS } } });
-        yield prisma_1.prisma.teamMember.deleteMany({ where: { teamId: { in: [teamA.id, teamB.id] } } });
-        yield prisma_1.prisma.team.delete({ where: { id: teamA.id } }).catch(() => undefined);
-        yield prisma_1.prisma.team.delete({ where: { id: teamB.id } }).catch(() => undefined);
-        yield sa.cleanup();
-        yield alice.cleanup();
-    }));
     function lease(who, filters) {
         const svc = new LeaseService_1.LeaseService(prisma_1.prisma, device_store_1.DeviceStoreFactory.getStore(), {
             allocate: () => __awaiter(this, void 0, void 0, function* () { return ({ systemPort: 9001, chromedriverPort: 9002, mjpegServerPort: 9003 }); }),
@@ -80,7 +77,7 @@ describe('team boundary on SDK leases (integration)', function () {
         app.use(express_1.default.json());
         app.use(authMiddleware_1.authMiddleware);
         app.use('/sdk/leases', (0, sdk_leases_1.makeRouter)({ leaseService: svc }));
-        return (0, supertest_1.default)(app)
+        return (0, loopbackRequest_1.default)(app)
             .post('/sdk/leases')
             .set('Cookie', who.cookie)
             .send({ filters: Object.assign({ platform: 'android', filterByHost: HOST }, filters) });

package/lib/test/integration/team-visibility-recordings.spec.js

@@ -15,7 +15,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const authMiddleware_1 = require("../../src/middleware/authMiddleware");
 const recordings_1 = __importDefault(require("../../src/app/routers/recordings"));
 const typedi_1 = require("typedi");
@@ -23,8 +23,10 @@ const TeamService_1 = require("../../src/services/TeamService");
 const prisma_1 = require("../../src/prisma");
 const seedUser_1 = require("../helpers/seedUser");
 const artifact_store_1 = require("../helpers/artifact-store");
+const scratch_database_1 = require("../helpers/scratch-database");
 describe('team visibility on /recordings reads (integration)', function () {
     this.timeout(60000);
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
     // GET /recordings/:groupId resolves ARTIFACT_STORE from the container, which
     // ServerManager registers at boot. Without it every allowed read is a 500.
     (0, artifact_store_1.useArtifactStore)();
@@ -90,21 +92,6 @@ describe('team visibility on /recordings reads (integration)', function () {
             data: Object.assign({ id: `rec-b-${stamp}`, group_id: GROUP_TEAM_B, device_udid: TEAM_B_UDID }, baseRecording),
         });
     }));
-    after(() => __awaiter(this, void 0, void 0, function* () {
-        yield prisma_1.prisma.recording.deleteMany({
-            where: { group_id: { in: [GROUP_SHARED, GROUP_TEAM_A, GROUP_TEAM_B] } },
-        });
-        yield prisma_1.prisma.device.deleteMany({
-            where: { udid: { in: [SHARED_UDID, TEAM_A_UDID, TEAM_B_UDID] } },
-        });
-        yield prisma_1.prisma.teamMember.deleteMany({
-            where: { teamId: { in: [teamA.id, teamB.id] } },
-        });
-        yield prisma_1.prisma.team.delete({ where: { id: teamA.id } }).catch(() => undefined);
-        yield prisma_1.prisma.team.delete({ where: { id: teamB.id } }).catch(() => undefined);
-        yield sa.cleanup();
-        yield aliceMember.cleanup();
-    }));
     function buildApp() {
         const app = (0, express_1.default)();
         app.use(express_1.default.json());
@@ -113,19 +100,19 @@ describe('team visibility on /recordings reads (integration)', function () {
         return app;
     }
     it('Alice GET /recordings/:teamBGroup → 404', () => __awaiter(this, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(buildApp())
+        const r = yield (0, loopbackRequest_1.default)(buildApp())
             .get(`/recordings/${GROUP_TEAM_B}`)
             .set('Cookie', aliceMember.cookie);
         (0, chai_1.expect)(r.status).to.equal(404);
     }));
     it('SA GET /recordings/:teamBGroup → 200 (admin sees all)', () => __awaiter(this, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(buildApp())
+        const r = yield (0, loopbackRequest_1.default)(buildApp())
             .get(`/recordings/${GROUP_TEAM_B}`)
             .set('Cookie', sa.cookie);
         (0, chai_1.expect)(r.status).to.equal(200);
     }));
     it('Alice GET /recordings/:teamAGroup → 200 (member of team A)', () => __awaiter(this, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(buildApp())
+        const r = yield (0, loopbackRequest_1.default)(buildApp())
             .get(`/recordings/${GROUP_TEAM_A}`)
             .set('Cookie', aliceMember.cookie);
         (0, chai_1.expect)(r.status).to.equal(200);

package/lib/test/integration/team-visibility-sessions.spec.js

@@ -15,7 +15,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const typedi_1 = require("typedi");
 const authMiddleware_1 = require("../../src/middleware/authMiddleware");
 const dashboard_1 = __importDefault(require("../../src/app/routers/dashboard"));
@@ -23,6 +23,7 @@ const bug_report_1 = __importDefault(require("../../src/app/routers/bug-report")
 const TeamService_1 = require("../../src/services/TeamService");
 const prisma_1 = require("../../src/prisma");
 const seedUser_1 = require("../helpers/seedUser");
+const scratch_database_1 = require("../helpers/scratch-database");
 /**
  * A session's data follows its phone's team, run as real queries (the session
  * list, builds and healing reads build Prisma filters that a stub would only
@@ -32,6 +33,7 @@ const seedUser_1 = require("../helpers/seedUser");
  */
 describe('team visibility on session data (integration)', function () {
     this.timeout(60000);
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
     let sa;
     let alice;
     let teamA;
@@ -123,21 +125,6 @@ describe('team visibility on session data (integration)', function () {
             });
         }
     }));
-    after(() => __awaiter(this, void 0, void 0, function* () {
-        const ids = [...Object.values(S), `${S.b}-2`];
-        yield prisma_1.prisma.sessionLog.deleteMany({ where: { session_id: { in: ids } } });
-        yield prisma_1.prisma.selectorState.deleteMany({
-            where: { original_selector: { in: [MUTED, MUTED_B] } },
-        });
-        yield prisma_1.prisma.session.deleteMany({ where: { id: { in: ids } } });
-        yield prisma_1.prisma.build.deleteMany({ where: { id: { in: [mixedBuild.id, teamBBuild.id] } } });
-        yield prisma_1.prisma.device.deleteMany({ where: { udid: { in: Object.values(U) } } });
-        yield prisma_1.prisma.teamMember.deleteMany({ where: { teamId: { in: [teamA.id, teamB.id] } } });
-        yield prisma_1.prisma.team.delete({ where: { id: teamA.id } }).catch(() => undefined);
-        yield prisma_1.prisma.team.delete({ where: { id: teamB.id } }).catch(() => undefined);
-        yield sa.cleanup();
-        yield alice.cleanup();
-    }));
     function app() {
         const a = (0, express_1.default)();
         a.use(express_1.default.json());
@@ -146,8 +133,8 @@ describe('team visibility on session data (integration)', function () {
         bug_report_1.default.register(a);
         return a;
     }
-    const asAlice = (url) => (0, supertest_1.default)(app()).get(url).set('Cookie', alice.cookie);
-    const asSa = (url) => (0, supertest_1.default)(app()).get(url).set('Cookie', sa.cookie);
+    const asAlice = (url) => (0, loopbackRequest_1.default)(app()).get(url).set('Cookie', alice.cookie);
+    const asSa = (url) => (0, loopbackRequest_1.default)(app()).get(url).set('Cookie', sa.cookie);
     const unknownBody = (id) => ({ error: true, message: `Session with id ${id} not found` });
     it("lists a member's sessions: shared, their team's, and their own on a phone that is gone", () => __awaiter(this, void 0, void 0, function* () {
         const ids = (yield asAlice('/session')).body.map((s) => s.id);
@@ -265,7 +252,7 @@ describe('team visibility on session data (integration)', function () {
         }));
     });
     it("refuses a bug report for another team's session as for an unknown one", () => __awaiter(this, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(app())
+        const r = yield (0, loopbackRequest_1.default)(app())
             .post(`/sessions/${S.b}/bug-report?mode=full`)
             .set('Cookie', alice.cookie)
             .set('Origin', 'http://127.0.0.1');

package/lib/test/integration/users-flow.spec.js

@@ -15,25 +15,20 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const authMiddleware_1 = require("../../src/middleware/authMiddleware");
 const users_1 = require("../../src/app/routers/users");
-const prisma_1 = require("../../src/prisma");
+const scratch_database_1 = require("../helpers/scratch-database");
 const seedUser_1 = require("../helpers/seedUser");
 describe('users CRUD flow (integration)', function () {
     this.timeout(60000);
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
     let sa;
     let admin;
     before(() => __awaiter(this, void 0, void 0, function* () {
         sa = yield (0, seedUser_1.seedUser)('SUPER_ADMIN', { name: 'Flow SA' });
         admin = yield (0, seedUser_1.seedUser)('ADMIN', { name: 'Flow Admin' });
     }));
-    after(() => __awaiter(this, void 0, void 0, function* () {
-        yield sa.cleanup();
-        yield admin.cleanup();
-        // Anything created during the flow with the flow-bob email tag.
-        yield prisma_1.prisma.user.deleteMany({ where: { email: { contains: 'flow-bob' } } });
-    }));
     function buildApp() {
         const app = (0, express_1.default)();
         app.use(express_1.default.json());
@@ -44,27 +39,27 @@ describe('users CRUD flow (integration)', function () {
     it('SA creates an admin -> admin creates a member -> admin lists', () => __awaiter(this, void 0, void 0, function* () {
         const app = buildApp();
         // ADMIN role-create — should fail with 403 (admin can't create admins).
-        const denied = yield (0, supertest_1.default)(app)
+        const denied = yield (0, loopbackRequest_1.default)(app)
             .post('/users')
             .set('Cookie', admin.cookie)
             .send({ email: 'flow-admin2@xenon.local', name: 'Admin 2', role: 'ADMIN' });
         (0, chai_1.expect)(denied.status).to.equal(403);
         // SA creates a member.
         const memberEmail = `flow-bob-${Date.now()}@xenon.local`;
-        const created = yield (0, supertest_1.default)(app)
+        const created = yield (0, loopbackRequest_1.default)(app)
             .post('/users')
             .set('Cookie', sa.cookie)
             .send({ email: memberEmail, name: 'Bob', role: 'MEMBER' });
         (0, chai_1.expect)(created.status).to.equal(201);
         (0, chai_1.expect)(created.body.temporaryPassword).to.match(/^[A-Za-z0-9_-]{12,}$/);
         // Admin lists — sees the new member; does NOT see SA or other admins.
-        const listAdmin = yield (0, supertest_1.default)(app).get('/users').set('Cookie', admin.cookie);
+        const listAdmin = yield (0, loopbackRequest_1.default)(app).get('/users').set('Cookie', admin.cookie);
         (0, chai_1.expect)(listAdmin.status).to.equal(200);
         const emailsAdmin = listAdmin.body.map((u) => u.email);
         (0, chai_1.expect)(emailsAdmin).to.include(memberEmail);
         (0, chai_1.expect)(emailsAdmin).to.not.include(sa.user.email);
         // SA lists — sees everyone.
-        const listSA = yield (0, supertest_1.default)(app).get('/users').set('Cookie', sa.cookie);
+        const listSA = yield (0, loopbackRequest_1.default)(app).get('/users').set('Cookie', sa.cookie);
         const emailsSA = listSA.body.map((u) => u.email);
         (0, chai_1.expect)(emailsSA).to.include(sa.user.email);
         (0, chai_1.expect)(emailsSA).to.include(admin.user.email);

package/lib/test/integration/users-lockout.spec.js

@@ -15,13 +15,15 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const authMiddleware_1 = require("../../src/middleware/authMiddleware");
 const users_1 = require("../../src/app/routers/users");
 const prisma_1 = require("../../src/prisma");
 const seedUser_1 = require("../helpers/seedUser");
+const scratch_database_1 = require("../helpers/scratch-database");
 describe('users lockout protections (integration)', function () {
     this.timeout(60000);
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
     function buildApp() {
         const app = (0, express_1.default)();
         app.use(express_1.default.json());
@@ -32,7 +34,7 @@ describe('users lockout protections (integration)', function () {
     it('SA cannot delete themselves', () => __awaiter(this, void 0, void 0, function* () {
         const me = yield (0, seedUser_1.seedUser)('SUPER_ADMIN', { name: 'Lockout Self' });
         try {
-            const r = yield (0, supertest_1.default)(buildApp()).delete(`/users/${me.user.id}`).set('Cookie', me.cookie);
+            const r = yield (0, loopbackRequest_1.default)(buildApp()).delete(`/users/${me.user.id}`).set('Cookie', me.cookie);
             (0, chai_1.expect)(r.status).to.equal(400);
             (0, chai_1.expect)(r.body.error).to.match(/yourself/);
         }
@@ -43,7 +45,7 @@ describe('users lockout protections (integration)', function () {
     it('SA cannot demote themselves', () => __awaiter(this, void 0, void 0, function* () {
         const me = yield (0, seedUser_1.seedUser)('SUPER_ADMIN', { name: 'Lockout Demote-Self' });
         try {
-            const r = yield (0, supertest_1.default)(buildApp())
+            const r = yield (0, loopbackRequest_1.default)(buildApp())
                 .patch(`/users/${me.user.id}`)
                 .set('Cookie', me.cookie)
                 .send({ role: 'MEMBER' });

package/lib/test/unit/EmailService.test.js

@@ -121,4 +121,70 @@ describe('EmailService', () => {
             }
         });
     });
+    // A reset link Xenon sends points at XENON_PUBLIC_URL, never the request's
+    // Host, so with SMTP but no address set no link is emailed at all. Said once
+    // at startup, so an operator upgrading learns why self-service reset went.
+    describe('warnAboutPublicUrl', () => {
+        it('warns when Xenon could send links but has no XENON_PUBLIC_URL to point them at', () => {
+            const orig = {
+                url: config_1.config.smtpUrl,
+                fb: config_1.config.passwordResetLogFallback,
+                pub: config_1.config.publicUrl,
+            };
+            const svc = new EmailService_1.EmailService();
+            const warn = sinon_1.default.stub(svc, 'warnLog');
+            try {
+                config_1.config.smtpUrl = undefined;
+                config_1.config.passwordResetLogFallback = false;
+                config_1.config.publicUrl = undefined;
+                svc.warnAboutPublicUrl();
+                (0, chai_1.expect)(warn.called, 'nothing could be sent anyway').to.equal(false);
+                config_1.config.smtpUrl = 'smtp://mail.example.com:587';
+                config_1.config.publicUrl = 'https://xenon.example.com';
+                svc.warnAboutPublicUrl();
+                (0, chai_1.expect)(warn.called).to.equal(false);
+                config_1.config.publicUrl = 'not a url';
+                svc.warnAboutPublicUrl();
+                (0, chai_1.expect)(warn.calledOnce).to.equal(true);
+                (0, chai_1.expect)(warn.firstCall.args[0]).to.match(/XENON_PUBLIC_URL/);
+            }
+            finally {
+                config_1.config.smtpUrl = orig.url;
+                config_1.config.passwordResetLogFallback = orig.fb;
+                config_1.config.publicUrl = orig.pub;
+            }
+        });
+        // The variable also drives each device's dashboard_link, so a value
+        // Xenon refuses is said at startup whether or not mail is set up. It was
+        // silent without SMTP. The value itself is not logged: it may carry a
+        // user name and password, one of the reasons it is refused.
+        it('warns, once, when XENON_PUBLIC_URL is set but refused, mail or not', () => {
+            const orig = {
+                url: config_1.config.smtpUrl,
+                fb: config_1.config.passwordResetLogFallback,
+                pub: config_1.config.publicUrl,
+            };
+            const svc = new EmailService_1.EmailService();
+            const warn = sinon_1.default.stub(svc, 'warnLog');
+            try {
+                config_1.config.smtpUrl = undefined;
+                config_1.config.passwordResetLogFallback = false;
+                config_1.config.publicUrl = 'https://user:secret@lab.example.com/qa';
+                svc.warnAboutPublicUrl();
+                (0, chai_1.expect)(warn.calledOnce).to.equal(true);
+                (0, chai_1.expect)(warn.firstCall.args[0]).to.match(/XENON_PUBLIC_URL is set/);
+                (0, chai_1.expect)(warn.firstCall.args[0]).to.match(/dashboard/);
+                (0, chai_1.expect)(warn.firstCall.args[0]).to.not.include('secret');
+                warn.resetHistory();
+                config_1.config.smtpUrl = 'smtp://mail.example.com:587';
+                svc.warnAboutPublicUrl();
+                (0, chai_1.expect)(warn.calledOnce, 'one warning with SMTP too').to.equal(true);
+            }
+            finally {
+                config_1.config.smtpUrl = orig.url;
+                config_1.config.passwordResetLogFallback = orig.fb;
+                config_1.config.publicUrl = orig.pub;
+            }
+        });
+    });
 });

package/lib/test/unit/ResilioTreeHealingProvider.test.js

@@ -13,7 +13,8 @@ require("reflect-metadata");
 const chai_1 = require("chai");
 const types_1 = require("../../src/services/healing/types");
 const ResilioTreeHealingProvider_1 = require("../../src/services/healing/ResilioTreeHealingProvider");
-const { JSDOMParser, Path } = require('resiliotree');
+const xmldom_1 = require("@xmldom/xmldom");
+const resilioPath_1 = require("../../src/services/healing/resilioPath");
 describe('ResilioTreeHealingProvider', () => {
     let provider;
     let mockEtalonService;
@@ -43,32 +44,26 @@ describe('ResilioTreeHealingProvider', () => {
         };
         provider = new ResilioTreeHealingProvider_1.ResilioTreeHealingProvider(mockEtalonService);
     });
-    it('should heal an element when a ResilioTree path exists', () => __awaiter(void 0, void 0, void 0, function* () {
-        const parser = new JSDOMParser();
-        const root = parser.parse(sourceXml);
-        // Find the button in source
-        const bodyNode = root.children[0];
-        const hierarchyNode = bodyNode.children[0];
-        const frameLayout = hierarchyNode.children[0];
-        const linearLayout = frameLayout.children[0];
-        const buttonNode = linearLayout.children[0];
-        const path = new Path([root, bodyNode, hierarchyNode, frameLayout, linearLayout, buttonNode]);
+    // The button's id and text both changed, so it is another element as far as
+    // its path can tell: Resilio leaves it to Fuzzy XML rather than guess. (This
+    // test used to expect a heal, from a path made by an HTML parse and a driver
+    // stub that accepted any XPath, including the lowercase one Resilio wrote,
+    // which no real driver matches. See resilio-path-healing.spec.ts.)
+    it('leaves an element whose id and text changed to the next tier', () => __awaiter(void 0, void 0, void 0, function* () {
+        const doc = new xmldom_1.DOMParser().parseFromString(sourceXml, 'text/xml');
+        const button = doc.getElementsByTagName('android.widget.Button')[0];
         mockEtalonService.getSignature = () => __awaiter(void 0, void 0, void 0, function* () {
             return ({
                 selector: "//android.widget.Button[@text='Submit']",
                 strategy: 'xpath',
                 attributes: { text: 'Submit', 'resource-id': 'com.example:id/submit_btn' },
                 nodeName: 'android.widget.Button',
-                path: path.toJSON(),
+                path: (0, resilioPath_1.resilioPathOf)(button, sourceXml),
                 lastSeen: Date.now(),
             });
         });
         const mockDriver = {
-            findElement: (strategy, selector) => __awaiter(void 0, void 0, void 0, function* () {
-                (0, chai_1.expect)(strategy).to.equal('xpath');
-                (0, chai_1.expect)(selector.toLowerCase()).to.contain('android.widget.button');
-                return { ELEMENT: 'healed-element-123' };
-            }),
+            findElement: () => __awaiter(void 0, void 0, void 0, function* () { return ({ ELEMENT: 'any-element' }); }),
         };
         const context = {
             sessionId: 'test-session',
@@ -77,11 +72,43 @@ describe('ResilioTreeHealingProvider', () => {
             selector: "//android.widget.Button[@text='Submit']",
             pageSource: brokenXml,
         };
-        const result = yield provider.heal(context);
-        (0, chai_1.expect)(result).to.not.be.null;
+        (0, chai_1.expect)(yield provider.heal(context)).to.equal(null);
+    }));
+    it('heals the same element after the page changed around it', () => __awaiter(void 0, void 0, void 0, function* () {
+        const doc = new xmldom_1.DOMParser().parseFromString(sourceXml, 'text/xml');
+        const button = doc.getElementsByTagName('android.widget.Button')[0];
+        mockEtalonService.getSignature = () => __awaiter(void 0, void 0, void 0, function* () {
+            return ({
+                selector: "//android.widget.Button[@text='Submit']",
+                strategy: 'xpath',
+                attributes: {},
+                nodeName: 'android.widget.Button',
+                path: (0, resilioPath_1.resilioPathOf)(button, sourceXml),
+                lastSeen: Date.now(),
+            });
+        });
+        // The button moved into a new row; it is still "Submit".
+        const movedXml = sourceXml
+            .replace('<android.widget.Button index="0"', '<android.widget.LinearLayout index="0"><android.widget.Button index="0"')
+            .replace('resource-id="com.example:id/submit_btn" />', 'resource-id="com.example:id/submit_btn" /></android.widget.LinearLayout>');
+        const asked = [];
+        const result = yield provider.heal({
+            sessionId: 'test-session',
+            driver: {
+                findElement: (_using, selector) => __awaiter(void 0, void 0, void 0, function* () {
+                    asked.push(selector);
+                    return { ELEMENT: 'healed-element-123' };
+                }),
+            },
+            strategy: 'xpath',
+            selector: "//android.widget.Button[@text='Submit']",
+            pageSource: movedXml,
+        });
         (0, chai_1.expect)(result === null || result === void 0 ? void 0 : result.id).to.equal('healed-element-123');
         (0, chai_1.expect)(result === null || result === void 0 ? void 0 : result.tier).to.equal(types_1.HealingTier.TIER_1_RECOVERY);
         (0, chai_1.expect)(result === null || result === void 0 ? void 0 : result.message).to.contain('ResilioTree');
+        // The element's own id, which it kept.
+        (0, chai_1.expect)(asked[0]).to.equal("//*[@resource-id='com.example:id/submit_btn']");
     }));
     it('should return null if no signature/path is found', () => __awaiter(void 0, void 0, void 0, function* () {
         const context = {

package/lib/test/unit/TeamService.test.js

@@ -56,6 +56,7 @@ describe('TeamService (User-keyed)', () => {
     }));
     it('delete() blocks when team has devices OR active members', () => __awaiter(void 0, void 0, void 0, function* () {
         sinon_1.default.stub(prisma_1.prisma.device, 'count').resolves(1);
+        sinon_1.default.stub(prisma_1.prisma.deviceSetting, 'findMany').resolves([]);
         sinon_1.default.stub(prisma_1.prisma.teamMember, 'count').resolves(0);
         sinon_1.default.stub(prisma_1.prisma.app, 'count').resolves(0);
         let err;
@@ -72,6 +73,7 @@ describe('TeamService (User-keyed)', () => {
     // as for its phones: the admin moves them first.
     it('delete() blocks while the team still owns apps', () => __awaiter(void 0, void 0, void 0, function* () {
         sinon_1.default.stub(prisma_1.prisma.device, 'count').resolves(0);
+        sinon_1.default.stub(prisma_1.prisma.deviceSetting, 'findMany').resolves([]);
         sinon_1.default.stub(prisma_1.prisma.teamMember, 'count').resolves(0);
         const apps = sinon_1.default.stub(prisma_1.prisma.app, 'count').resolves(2);
         const teamDel = sinon_1.default.stub(prisma_1.prisma.team, 'delete').resolves({});
@@ -89,6 +91,7 @@ describe('TeamService (User-keyed)', () => {
     }));
     it('delete() drops FK on revoked apiKeys then deletes the team', () => __awaiter(void 0, void 0, void 0, function* () {
         sinon_1.default.stub(prisma_1.prisma.device, 'count').resolves(0);
+        sinon_1.default.stub(prisma_1.prisma.deviceSetting, 'findMany').resolves([]);
         sinon_1.default.stub(prisma_1.prisma.teamMember, 'count').resolves(0);
         sinon_1.default.stub(prisma_1.prisma.app, 'count').resolves(0);
         const apiKeyUpdate = sinon_1.default.stub(prisma_1.prisma.apiKey, 'updateMany').resolves({ count: 0 });

package/lib/test/unit/XenonCapabilityManager.spec.js

@@ -47,9 +47,11 @@ describe('XenonCapabilityManager.getXenonCapabilities — interceptor activation
         expect(out[XenonCapabilityManager_1.XENON_CAPABILITIES.SESSION_NAME]).to.equal('new-name');
         expect(out[XenonCapabilityManager_1.XENON_CAPABILITIES.BUILD_NAME]).to.equal('nightly');
     });
-    it('treats no interceptor cap as disabled', () => {
+    it("leaves no interceptor cap unset, for the server's `interceptor` option to decide", () => {
+        // Off unless the server's option turns it on: resolveInterceptorOptions,
+        // test/unit/phone-network/interceptor-options.spec.ts.
         const out = (0, XenonCapabilityManager_1.getXenonCapabilities)(caps({}));
-        expect(out[XenonCapabilityManager_1.XENON_CAPABILITIES.INTERCEPTOR_ENABLED]).to.equal(false);
+        expect(out[XenonCapabilityManager_1.XENON_CAPABILITIES.INTERCEPTOR_ENABLED]).to.equal(undefined);
     });
     it('does not throw when firstMatch is missing entirely', () => {
         const malformed = { alwaysMatch: { interceptor: { enabled: true } } };