@xenon-device-management/xenon 2.13.2 → 2.15.0

package/lib/test/helpers/loki-stores.js

@@ -1,7 +1,9 @@
 "use strict";
 Object.defineProperty(exports, "__esModule", { value: true });
 exports.useLokiStores = useLokiStores;
+exports.usePrismaStores = usePrismaStores;
 const device_store_1 = require("../../src/data-service/device-store");
+const prisma_store_1 = require("../../src/data-service/prisma-store");
 // DeviceStoreFactory's cached stores, one per kind.
 const CACHES = ['_deviceStore', '_pendingSessionStore', '_cliArgsStore', '_healEtalonStore'];
 /**
@@ -39,3 +41,34 @@ function useLokiStores() {
             process.env.NODE_ENV = previousEnv;
     });
 }
+/**
+ * The Prisma stores (what a server with SQLite runs) for the enclosing
+ * `describe`, however the file was started. Put the suite's database behind
+ * them first: `useScratchDatabase({ wholeSuite: true })`.
+ *
+ * `npm run test:all` sets NODE_ENV to 'test', so DeviceStoreFactory hands it
+ * Loki stores, while `npx mocha <file>` gets Prisma ones. A spec written
+ * against the Prisma store's queries then tested Loki in the full run, and its
+ * phones stayed in Loki's one collection for every later spec. This hands the
+ * factory new Prisma stores for the suite, then puts the old ones back. A
+ * module that took its store when it was imported (`grid.ts`) keeps that one.
+ *
+ * Call it inside a `describe`, before the hooks that use a store, never at the
+ * top of a file.
+ */
+function usePrismaStores() {
+    const factory = device_store_1.DeviceStoreFactory;
+    const saved = {};
+    before(() => {
+        for (const key of CACHES)
+            saved[key] = factory[key];
+        factory._deviceStore = new prisma_store_1.PrismaDeviceStore();
+        factory._pendingSessionStore = new prisma_store_1.PrismaPendingSessionStore();
+        factory._cliArgsStore = new prisma_store_1.PrismaCLIArgsStore();
+        factory._healEtalonStore = new prisma_store_1.PrismaHealEtalonStore();
+    });
+    after(() => {
+        for (const key of CACHES)
+            factory[key] = saved[key];
+    });
+}

package/lib/test/helpers/page-sources.js

@@ -0,0 +1,164 @@
+"use strict";
+var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, generator) {
+    function adopt(value) { return value instanceof P ? value : new P(function (resolve) { resolve(value); }); }
+    return new (P || (P = Promise))(function (resolve, reject) {
+        function fulfilled(value) { try { step(generator.next(value)); } catch (e) { reject(e); } }
+        function rejected(value) { try { step(generator["throw"](value)); } catch (e) { reject(e); } }
+        function step(result) { result.done ? resolve(result.value) : adopt(result.value).then(fulfilled, rejected); }
+        step((generator = generator.apply(thisArg, _arguments || [])).next());
+    });
+};
+Object.defineProperty(exports, "__esModule", { value: true });
+exports.ios = exports.android = void 0;
+exports.elementIdOf = elementIdOf;
+exports.pageDriver = pageDriver;
+const xmldom_1 = require("@xmldom/xmldom");
+const xpath_1 = require("xpath");
+/**
+ * Page sources shaped like the drivers' own (UiAutomator2's `hierarchy`,
+ * XCUITest's `AppiumAUT`), and a driver that answers finds by running the
+ * XPath on them, as the real drivers do, for specs that check which element a
+ * healed locator selects. No phone.
+ */
+const W3C_ELEMENT_KEY = 'element-6066-11e4-a52e-4f735466cecf';
+const attrs = (o) => Object.entries(o)
+    .map(([k, v]) => `${k}="${v}"`)
+    .join(' ');
+function androidNode(tag, index, bounds, extra = {}, children) {
+    const a = attrs(Object.assign({ index, package: 'com.example.shop', class: tag, text: '', 'resource-id': '', 'content-desc': '', checkable: 'false', checked: 'false', clickable: 'false', enabled: 'true', focusable: 'false', focused: 'false', 'long-clickable': 'false', password: 'false', scrollable: 'false', selected: 'false', bounds, displayed: 'true' }, extra));
+    return children === undefined ? `<${tag} ${a} />` : `<${tag} ${a}>${children}</${tag}>`;
+}
+exports.android = {
+    button: (index, id, text, bounds) => androidNode('android.widget.Button', index, bounds, {
+        'resource-id': `com.example.shop:id/${id}`,
+        text,
+        'content-desc': text,
+        clickable: 'true',
+        focusable: 'true',
+    }),
+    field: (index, id, text, bounds) => androidNode('android.widget.EditText', index, bounds, {
+        'resource-id': `com.example.shop:id/${id}`,
+        text,
+        clickable: 'true',
+        focusable: 'true',
+    }),
+    text: (index, id, text, bounds) => androidNode('android.widget.TextView', index, bounds, {
+        'resource-id': `com.example.shop:id/${id}`,
+        text,
+    }),
+    image: (index, id, description, bounds) => androidNode('android.widget.ImageView', index, bounds, {
+        'resource-id': `com.example.shop:id/${id}`,
+        'content-desc': description,
+    }),
+    /** A clickable row holding other elements, as list rows and compound buttons are. */
+    row: (index, id, bounds, children) => androidNode('android.widget.LinearLayout', index, bounds, { 'resource-id': `com.example.shop:id/${id}`, clickable: 'true', focusable: 'true' }, children),
+    layout: (index, id, bounds, children) => androidNode('android.widget.LinearLayout', index, bounds, { 'resource-id': id ? `com.example.shop:id/${id}` : '' }, children),
+    page: (children) => "<?xml version='1.0' encoding='UTF-8' standalone='yes' ?>" +
+        '<hierarchy index="0" class="hierarchy" rotation="0" width="1080" height="2220">' +
+        androidNode('android.widget.FrameLayout', 0, '[0,0][1080,2220]', {}, children) +
+        '</hierarchy>',
+};
+function iosNode(type, a, children = '') {
+    return `<${type} ${attrs(Object.assign({ type, enabled: 'true', visible: 'true', accessible: 'true' }, a))}>${children}</${type}>`;
+}
+exports.ios = {
+    button: (name, label, y) => iosNode('XCUIElementTypeButton', { name, label, x: 20, y, width: 350, height: 44 }),
+    field: (name, value, y) => iosNode('XCUIElementTypeTextField', { name, value, x: 20, y, width: 350, height: 44 }),
+    group: (children) => iosNode('XCUIElementTypeOther', { x: 0, y: 100, width: 390, height: 600 }, children),
+    page: (children) => '<?xml version="1.0" encoding="UTF-8"?><AppiumAUT>' +
+        iosNode('XCUIElementTypeApplication', { name: 'Shop', label: 'Shop', x: 0, y: 0, width: 390, height: 844 }, iosNode('XCUIElementTypeWindow', { x: 0, y: 0, width: 390, height: 844 }, children)) +
+        '</AppiumAUT>',
+};
+/** The element id the fake driver gives an element: its resource-id or name. */
+function elementIdOf(el) {
+    return `el:${el.getAttribute('resource-id') || el.getAttribute('name') || el.tagName}`;
+}
+/**
+ * A driver showing `pageSource`: finds run the XPath on it and answer the
+ * first match, attributes and rects are the element's own. `show` changes the
+ * screen.
+ */
+function pageDriver(pageSource) {
+    let doc = new xmldom_1.DOMParser().parseFromString(pageSource, 'text/xml');
+    let source = pageSource;
+    const known = new Map();
+    const select = (using, value) => {
+        if (using !== 'xpath')
+            throw new Error(`unsupported locator strategy ${using}`);
+        return (0, xpath_1.select)(value, doc).filter((n) => n.nodeType === 1);
+    };
+    const ref = (el) => {
+        const id = elementIdOf(el);
+        known.set(id, el);
+        return { ELEMENT: id, [W3C_ELEMENT_KEY]: id };
+    };
+    const element = (id) => {
+        const el = known.get(id);
+        if (!el)
+            throw new Error(`no element ${id}`);
+        return el;
+    };
+    return {
+        show(next) {
+            source = next;
+            doc = new xmldom_1.DOMParser().parseFromString(next, 'text/xml');
+        },
+        getPageSource() {
+            return __awaiter(this, void 0, void 0, function* () {
+                return source;
+            });
+        },
+        findElement(using, value) {
+            return __awaiter(this, void 0, void 0, function* () {
+                const [first] = select(using, value);
+                if (!first) {
+                    throw Object.assign(new Error('NoSuchElement: An element could not be located'), {
+                        name: 'NoSuchElementError',
+                    });
+                }
+                return ref(first);
+            });
+        },
+        findElements(using, value) {
+            return __awaiter(this, void 0, void 0, function* () {
+                return select(using, value).map(ref);
+            });
+        },
+        caps: { platformName: /<XCUIElementType/.test(pageSource) ? 'iOS' : 'Android' },
+        /**
+         * As the drivers answer: getAttribute(name, elementId). UiAutomator2
+         * answers String(value), so an attribute the element hasn't set is
+         * "null"; WebDriverAgent answers null.
+         */
+        getAttribute(name, id) {
+            return __awaiter(this, void 0, void 0, function* () {
+                const value = element(id).getAttribute(name);
+                if (value)
+                    return value;
+                return /<XCUIElementType/.test(source) ? null : 'null';
+            });
+        },
+        getName(id) {
+            return __awaiter(this, void 0, void 0, function* () {
+                return element(id).tagName;
+            });
+        },
+        getElementRect(id) {
+            return __awaiter(this, void 0, void 0, function* () {
+                var _a;
+                const el = element(id);
+                const bounds = el.getAttribute('bounds');
+                if (bounds) {
+                    const [x1, y1, x2, y2] = ((_a = bounds.match(/\d+/g)) !== null && _a !== void 0 ? _a : []).map(Number);
+                    return { x: x1, y: y1, width: x2 - x1, height: y2 - y1 };
+                }
+                return {
+                    x: Number(el.getAttribute('x')),
+                    y: Number(el.getAttribute('y')),
+                    width: Number(el.getAttribute('width')),
+                    height: Number(el.getAttribute('height')),
+                };
+            });
+        },
+    };
+}

package/lib/test/helpers/scratch-database.js

@@ -29,6 +29,7 @@ const MODELS = [
     'profiling',
     'app',
     'device',
+    'deviceSetting',
     'pendingSession',
     'cLIArgs',
     'webhookConfig',
@@ -51,16 +52,54 @@ const MODELS = [
     'sessionMetric',
     'selectorEvent',
 ];
+let scratchCount = 0;
+let template;
+/**
+ * A database migrated once for the whole process, which each suite copies.
+ * Removed when the process exits.
+ */
+function migratedTemplate() {
+    if (template)
+        return template;
+    const file = path_1.default.join(os_1.default.tmpdir(), `xenon-scratch-template-${process.pid}-${Date.now()}.db`);
+    (0, child_process_1.execSync)('npx prisma migrate deploy', {
+        cwd: path_1.default.resolve(__dirname, '../..'),
+        env: Object.assign(Object.assign({}, process.env), { DATABASE_URL: `file:${file}` }),
+        stdio: 'pipe',
+    });
+    process.once('exit', () => {
+        for (const f of [file, `${file}-journal`]) {
+            try {
+                fs_1.default.unlinkSync(f);
+            }
+            catch (_a) {
+                // already gone
+            }
+        }
+    });
+    template = file;
+    return file;
+}
 /**
  * Back the whole `prisma` wrapper with a scratch SQLite file for the enclosing
  * `describe`, so the real queries (the device store, the session lifecycle,
  * SessionOwnerResolver) run against a real database that is not the server's.
  * Like useScratchPortLeases, for every model.
  *
- * Call it inside a `describe`, never at the top of a file. The database is
- * migrated once per suite; the stubs are made before each test and removed
- * after it, so a spec's own `sinon.restore()` can't leave the next test on
- * the real database. Tests empty the tables they use.
+ * Call it inside a `describe`, never at the top of a file. Each suite gets a
+ * fresh database: a copy of one migrated once per process (migrating takes
+ * seconds). The stubs are made before each test and removed after it, so a
+ * spec's own `sinon.restore()` can't leave the next test on the real
+ * database. Tests empty the tables they use.
+ *
+ * With `wholeSuite`, the stubs are made once, before the suite's own `before`
+ * hooks (call it first in the describe), and removed after the suite. Making
+ * them takes tens of milliseconds, which a suite of hundreds of short tests
+ * otherwise pays per test. Its `before` hooks can then seed the rows every
+ * test reads, and nothing needs deleting: the file goes with the suite. Only
+ * for a suite that doesn't stub or restore `prisma` itself. Its own `after`
+ * hooks run once the stubs are gone, so they must not touch `prisma`: it is
+ * the real database again by then.
  *
  * With `captureQueries`, `queries` holds the SQL each test ran, so a spec can
  * ask SQLite how it reads a table (`EXPLAIN QUERY PLAN`).
@@ -71,13 +110,10 @@ function useScratchDatabase(options = {}) {
     let dbPath = '';
     before(function () {
         this.timeout(90000);
-        dbPath = path_1.default.join(os_1.default.tmpdir(), `xenon-scratch-${process.pid}-${Date.now()}.db`);
+        scratchCount += 1;
+        dbPath = path_1.default.join(os_1.default.tmpdir(), `xenon-scratch-${process.pid}-${Date.now()}-${scratchCount}.db`);
+        fs_1.default.copyFileSync(migratedTemplate(), dbPath);
         const url = `file:${dbPath}`;
-        (0, child_process_1.execSync)('npx prisma migrate deploy', {
-            cwd: path_1.default.resolve(__dirname, '../..'),
-            env: Object.assign(Object.assign({}, process.env), { DATABASE_URL: url }),
-            stdio: 'pipe',
-        });
         if (options.captureQueries) {
             const db = new client_1.PrismaClient({
                 datasources: { db: { url } },
@@ -89,9 +125,10 @@ function useScratchDatabase(options = {}) {
         else {
             ctx.db = new client_1.PrismaClient({ datasources: { db: { url } } });
         }
+        if (options.wholeSuite)
+            stubPrisma();
     });
-    beforeEach(() => {
-        ctx.queries.length = 0;
+    function stubPrisma() {
         for (const model of MODELS) {
             const wrapper = prisma_1.prisma[model];
             const delegate = ctx.db[model];
@@ -101,8 +138,16 @@ function useScratchDatabase(options = {}) {
                 sandbox.stub(wrapper, name).callsFake((...args) => delegate[name](...args));
             }
         }
+    }
+    beforeEach(() => {
+        ctx.queries.length = 0;
+        if (!options.wholeSuite)
+            stubPrisma();
+    });
+    afterEach(() => {
+        if (!options.wholeSuite)
+            sandbox.restore();
     });
-    afterEach(() => sandbox.restore());
     after(() => __awaiter(this, void 0, void 0, function* () {
         sandbox.restore();
         if (ctx.db)

package/lib/test/integration/audit-ingest.spec.js

@@ -15,7 +15,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const sinon_1 = __importDefault(require("sinon"));
 // Static import (matches the passing integration-spec idiom, e.g. selector-health-endpoint.spec):
 // a dynamic `await import('...routers/audit')` fails ESM resolution on the extensionless path
@@ -37,7 +37,7 @@ describe('POST /xenon/api/audit/events', () => {
         app.use('/xenon/api/audit', (0, audit_1.makeRouter)({ eventLogService: eventLogSvc }));
     });
     it('202s on a valid batch of 2 events and appends each via EventLogService.appendSafe with type mcp_audit', () => __awaiter(void 0, void 0, void 0, function* () {
-        const res = yield (0, supertest_1.default)(app)
+        const res = yield (0, loopbackRequest_1.default)(app)
             .post('/xenon/api/audit/events')
             .send({
             events: [
@@ -70,20 +70,20 @@ describe('POST /xenon/api/audit/events', () => {
         (0, chai_1.expect)(secondArg.payload).to.deep.include({ sessionId: 'sess-1' });
     }));
     it('400s when events is missing', () => __awaiter(void 0, void 0, void 0, function* () {
-        const res = yield (0, supertest_1.default)(app).post('/xenon/api/audit/events').send({});
+        const res = yield (0, loopbackRequest_1.default)(app).post('/xenon/api/audit/events').send({});
         (0, chai_1.expect)(res.status).to.equal(400);
         (0, chai_1.expect)(res.body.error).to.equal('bad_request');
         (0, chai_1.expect)(eventLogSvc.appendSafe.called).to.be.false;
     }));
     it('400s when events is not an array', () => __awaiter(void 0, void 0, void 0, function* () {
-        const res = yield (0, supertest_1.default)(app)
+        const res = yield (0, loopbackRequest_1.default)(app)
             .post('/xenon/api/audit/events')
             .send({ events: 'nope' });
         (0, chai_1.expect)(res.status).to.equal(400);
         (0, chai_1.expect)(res.body.error).to.equal('bad_request');
     }));
     it('400s when a batch event is malformed (missing tool)', () => __awaiter(void 0, void 0, void 0, function* () {
-        const res = yield (0, supertest_1.default)(app)
+        const res = yield (0, loopbackRequest_1.default)(app)
             .post('/xenon/api/audit/events')
             .send({
             events: [{ subject: 'agent-1', decision: 'allow', latencyMs: 10 }],
@@ -100,7 +100,7 @@ describe('POST /xenon/api/audit/events', () => {
             decision: 'allow',
             latencyMs: i,
         }));
-        const res = yield (0, supertest_1.default)(app).post('/xenon/api/audit/events').send({ events });
+        const res = yield (0, loopbackRequest_1.default)(app).post('/xenon/api/audit/events').send({ events });
         (0, chai_1.expect)(res.status).to.equal(400);
         (0, chai_1.expect)(res.body.error).to.equal('bad_request');
         (0, chai_1.expect)(eventLogSvc.appendSafe.called).to.be.false;
@@ -131,12 +131,12 @@ describe('POST /xenon/api/audit/events — guard (router-level roleGuard(MEMBER)
     });
     it('401s when unauthenticated', () => __awaiter(void 0, void 0, void 0, function* () {
         const app = yield makeApp(eventLogSvc)();
-        const res = yield (0, supertest_1.default)(app).post('/xenon/api/audit/events').send(validBody);
+        const res = yield (0, loopbackRequest_1.default)(app).post('/xenon/api/audit/events').send(validBody);
         (0, chai_1.expect)(res.status).to.equal(401);
     }));
     it('403s for a role below MEMBER', () => __awaiter(void 0, void 0, void 0, function* () {
         const app = yield makeApp(eventLogSvc)();
-        const res = yield (0, supertest_1.default)(app)
+        const res = yield (0, loopbackRequest_1.default)(app)
             .post('/xenon/api/audit/events')
             .set('x-test-role', 'BOGUS')
             .set('x-test-scopes', 'admin')
@@ -145,7 +145,7 @@ describe('POST /xenon/api/audit/events — guard (router-level roleGuard(MEMBER)
     }));
     it('403s for MEMBER role without the admin scope', () => __awaiter(void 0, void 0, void 0, function* () {
         const app = yield makeApp(eventLogSvc)();
-        const res = yield (0, supertest_1.default)(app)
+        const res = yield (0, loopbackRequest_1.default)(app)
             .post('/xenon/api/audit/events')
             .set('x-test-role', 'MEMBER')
             .set('x-test-scopes', 'devices')
@@ -155,7 +155,7 @@ describe('POST /xenon/api/audit/events — guard (router-level roleGuard(MEMBER)
     }));
     it('202s for MEMBER role with the admin scope', () => __awaiter(void 0, void 0, void 0, function* () {
         const app = yield makeApp(eventLogSvc)();
-        const res = yield (0, supertest_1.default)(app)
+        const res = yield (0, loopbackRequest_1.default)(app)
             .post('/xenon/api/audit/events')
             .set('x-test-role', 'MEMBER')
             .set('x-test-scopes', 'admin')

package/lib/test/integration/auth-flow.spec.js

@@ -14,13 +14,13 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const express_1 = __importDefault(require("express"));
 const auth_1 = require("../../src/app/routers/auth");
 const authMiddleware_1 = require("../../src/middleware/authMiddleware");
-const prisma_1 = require("../../src/prisma");
 const typedi_1 = require("typedi");
 const UserService_1 = require("../../src/services/UserService");
+const scratch_database_1 = require("../helpers/scratch-database");
 function buildApp() {
     const app = (0, express_1.default)();
     app.use(express_1.default.json());
@@ -32,10 +32,9 @@ function buildApp() {
 }
 describe('auth flow (integration)', function () {
     this.timeout(30000);
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
     let user;
     before(() => __awaiter(this, void 0, void 0, function* () {
-        yield prisma_1.prisma.userSession.deleteMany({ where: { user: { email: 'loginflow@xenon.local' } } });
-        yield prisma_1.prisma.user.deleteMany({ where: { email: 'loginflow@xenon.local' } });
         user = yield typedi_1.Container.get(UserService_1.UserService).createUser({
             email: 'loginflow@xenon.local',
             name: 'Login Flow',
@@ -43,31 +42,27 @@ describe('auth flow (integration)', function () {
             role: 'ADMIN',
         });
     }));
-    after(() => __awaiter(this, void 0, void 0, function* () {
-        yield prisma_1.prisma.userSession.deleteMany({ where: { userId: user.id } });
-        yield prisma_1.prisma.user.delete({ where: { id: user.id } });
-    }));
     it('login → cookie → /whoami → logout → 401', () => __awaiter(this, void 0, void 0, function* () {
         var _a;
         const app = buildApp();
-        const login = yield (0, supertest_1.default)(app)
+        const login = yield (0, loopbackRequest_1.default)(app)
             .post('/api/auth/login')
             .send({ email: 'loginflow@xenon.local', password: 'flow-test-12' });
         (0, chai_1.expect)(login.status).to.equal(204);
         const cookie = (_a = login.headers['set-cookie']) === null || _a === void 0 ? void 0 : _a[0];
         (0, chai_1.expect)(cookie).to.match(/^xenon_dashboard_session=/);
-        const me = yield (0, supertest_1.default)(app).get('/api/whoami').set('Cookie', cookie);
+        const me = yield (0, loopbackRequest_1.default)(app).get('/api/whoami').set('Cookie', cookie);
         (0, chai_1.expect)(me.status).to.equal(200);
         (0, chai_1.expect)(me.body.userId).to.equal(user.id);
         (0, chai_1.expect)(me.body.kind).to.equal('user-session');
-        const out = yield (0, supertest_1.default)(app).post('/api/auth/logout').set('Cookie', cookie);
+        const out = yield (0, loopbackRequest_1.default)(app).post('/api/auth/logout').set('Cookie', cookie);
         (0, chai_1.expect)(out.status).to.equal(204);
-        const me2 = yield (0, supertest_1.default)(app).get('/api/whoami').set('Cookie', cookie);
+        const me2 = yield (0, loopbackRequest_1.default)(app).get('/api/whoami').set('Cookie', cookie);
         (0, chai_1.expect)(me2.status).to.equal(401);
     }));
     it('login with wrong password returns generic 401 (no enumeration)', () => __awaiter(this, void 0, void 0, function* () {
         const app = buildApp();
-        const login = yield (0, supertest_1.default)(app)
+        const login = yield (0, loopbackRequest_1.default)(app)
             .post('/api/auth/login')
             .send({ email: 'loginflow@xenon.local', password: 'WRONG' });
         (0, chai_1.expect)(login.status).to.equal(401);
@@ -75,7 +70,7 @@ describe('auth flow (integration)', function () {
     }));
     it('login with unknown email returns the same generic 401', () => __awaiter(this, void 0, void 0, function* () {
         const app = buildApp();
-        const login = yield (0, supertest_1.default)(app)
+        const login = yield (0, loopbackRequest_1.default)(app)
             .post('/api/auth/login')
             .send({ email: 'no-such@xenon.local', password: 'whatever' });
         (0, chai_1.expect)(login.status).to.equal(401);

package/lib/test/integration/auth-rate-limit.spec.js

@@ -15,22 +15,25 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const auth_1 = require("../../src/app/routers/auth");
+const scratch_database_1 = require("../helpers/scratch-database");
 describe('login rate limit', function () {
     this.timeout(15000);
+    // Each attempt looks the email address up.
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
     it('5 bad logins from one IP → 6th returns 429 with Retry-After', () => __awaiter(this, void 0, void 0, function* () {
         const app = (0, express_1.default)();
         app.use(express_1.default.json());
         app.use('/auth', (0, auth_1.authPublicRouter)());
         for (let i = 0; i < 5; i++) {
-            const r = yield (0, supertest_1.default)(app)
+            const r = yield (0, loopbackRequest_1.default)(app)
                 .post('/auth/login')
                 .set('X-Forwarded-For', '9.9.9.9')
                 .send({ email: 'no@no.com', password: 'no' });
             (0, chai_1.expect)(r.status).to.equal(401);
         }
-        const blocked = yield (0, supertest_1.default)(app)
+        const blocked = yield (0, loopbackRequest_1.default)(app)
             .post('/auth/login')
             .set('X-Forwarded-For', '9.9.9.9')
             .send({ email: 'no@no.com', password: 'no' });

package/lib/test/integration/bug-report-route.spec.js

@@ -48,7 +48,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const sinon_1 = __importDefault(require("sinon"));
 const fs = __importStar(require("fs"));
 const path = __importStar(require("path"));
@@ -57,11 +57,14 @@ const unzipper = __importStar(require("unzipper"));
 const prisma_1 = require("../../src/prisma");
 const config_1 = require("../../src/config");
 const bug_report_1 = __importDefault(require("../../src/app/routers/bug-report"));
+const authMiddleware_1 = require("../../src/middleware/authMiddleware");
 describe('POST /sessions/:id/bug-report (integration)', () => {
     let tmpAssets;
+    let savedAssetsPath;
     const fixtureMp4 = path.join(__dirname, 'fixtures/bug-report/recording.mp4');
     beforeEach(() => {
         tmpAssets = fs.mkdtempSync(path.join(os.tmpdir(), 'xenon-it-'));
+        savedAssetsPath = config_1.config.sessionAssetsPath;
         config_1.config.sessionAssetsPath = tmpAssets;
         const sessionDir = path.join(tmpAssets, 'sess-it', 'video');
         fs.mkdirSync(sessionDir, { recursive: true });
@@ -69,10 +72,27 @@ describe('POST /sessions/:id/bug-report (integration)', () => {
     });
     afterEach(() => {
         sinon_1.default.restore();
+        config_1.config.sessionAssetsPath = savedAssetsPath;
         fs.rmSync(tmpAssets, { recursive: true, force: true });
     });
+    /**
+     * The router sits behind authMiddleware in the API, and its roleGuard
+     * answers 401 to a request with no `req.auth` (27fd825, three days after
+     * this spec). Stand in for the middleware with an admin, as it sets one:
+     * no `teamIds`, so the session needs no Device row to be visible.
+     */
     function makeApp() {
         const app = (0, express_1.default)();
+        app.use((req, _res, next) => {
+            req.auth = {
+                kind: 'user-session',
+                userId: 'usr_admin',
+                role: 'ADMIN',
+                scopes: (0, authMiddleware_1.scopesForRole)('ADMIN'),
+                rateLimit: 100,
+            };
+            next();
+        });
         bug_report_1.default.register(app);
         return app;
     }
@@ -94,7 +114,7 @@ describe('POST /sessions/:id/bug-report (integration)', () => {
         sinon_1.default.stub(prisma_1.prisma.sessionLog, 'findMany').resolves([
             { createdAt: new Date(), title: 'click', response: 'fail' },
         ]);
-        const res = yield (0, supertest_1.default)(makeApp())
+        const res = yield (0, loopbackRequest_1.default)(makeApp())
             .post('/sessions/sess-it/bug-report?mode=full')
             .buffer(true)
             .parse((r, cb) => {

package/lib/test/integration/forgot-password-rate-limit.spec.js

@@ -15,22 +15,25 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const auth_1 = require("../../src/app/routers/auth");
+const scratch_database_1 = require("../helpers/scratch-database");
 describe('forgot-password rate limit', function () {
     this.timeout(15000);
+    // Each attempt looks the email address up.
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
     it('3 attempts from one IP -> 4th returns 429 with Retry-After', () => __awaiter(this, void 0, void 0, function* () {
         const app = (0, express_1.default)();
         app.use(express_1.default.json());
         app.use('/auth', (0, auth_1.authPublicRouter)());
         for (let i = 0; i < 3; i++) {
-            const r = yield (0, supertest_1.default)(app)
+            const r = yield (0, loopbackRequest_1.default)(app)
                 .post('/auth/forgot-password')
                 .set('X-Forwarded-For', '7.7.7.7')
                 .send({ email: 'whatever@xenon.local' });
             (0, chai_1.expect)(r.status).to.equal(204);
         }
-        const blocked = yield (0, supertest_1.default)(app)
+        const blocked = yield (0, loopbackRequest_1.default)(app)
             .post('/auth/forgot-password')
             .set('X-Forwarded-For', '7.7.7.7')
             .send({ email: 'whatever@xenon.local' });