@xenon-device-management/xenon 2.13.2 → 2.15.0

package/lib/test/integration/sdk-version.spec.js

@@ -48,7 +48,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importStar(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 describe('GET /xenon/api/sdk/version', () => {
     it('returns pluginVersion + supports array', () => __awaiter(void 0, void 0, void 0, function* () {
         const register = (yield Promise.resolve().then(() => __importStar(require('../../src/app/routers/sdk-version')))).default;
@@ -61,7 +61,7 @@ describe('GET /xenon/api/sdk/version', () => {
         const apiRouter = (0, express_1.Router)();
         register(apiRouter);
         app.use('/xenon/api', apiRouter);
-        const res = yield (0, supertest_1.default)(app).get('/xenon/api/sdk/version');
+        const res = yield (0, loopbackRequest_1.default)(app).get('/xenon/api/sdk/version');
         (0, chai_1.expect)(res.status).to.equal(200);
         (0, chai_1.expect)(res.body.pluginVersion).to.be.a('string');
         (0, chai_1.expect)(res.body.supports).to.include.members(['leases', 'ports', 'heartbeat']);

package/lib/test/integration/selector-health-endpoint.spec.js

@@ -16,7 +16,7 @@ require("reflect-metadata");
 const chai_1 = require("chai");
 const sinon_1 = __importDefault(require("sinon"));
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const dashboard_1 = require("../../src/app/routers/dashboard");
 const roleGuard_1 = require("../../src/middleware/roleGuard");
 const prisma_1 = require("../../src/prisma");
@@ -209,23 +209,23 @@ describe('GET /healing/selector-health — MEMBER guard (router-level)', () => {
     });
     afterEach(() => sinon_1.default.restore());
     it('401s when unauthenticated', () => __awaiter(void 0, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(makeApp()).get('/xenon/api/healing/selector-health');
+        const r = yield (0, loopbackRequest_1.default)(makeApp()).get('/xenon/api/healing/selector-health');
         (0, chai_1.expect)(r.status).to.equal(401);
     }));
     it('403s for a role below MEMBER', () => __awaiter(void 0, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(makeApp())
+        const r = yield (0, loopbackRequest_1.default)(makeApp())
             .get('/xenon/api/healing/selector-health')
             .set('x-test-role', 'BOGUS');
         (0, chai_1.expect)(r.status).to.equal(403);
     }));
     it('200s for MEMBER', () => __awaiter(void 0, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(makeApp())
+        const r = yield (0, loopbackRequest_1.default)(makeApp())
             .get('/xenon/api/healing/selector-health')
             .set('x-test-role', 'MEMBER');
         (0, chai_1.expect)(r.status).to.equal(200);
     }));
     it('200s for ADMIN', () => __awaiter(void 0, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(makeApp())
+        const r = yield (0, loopbackRequest_1.default)(makeApp())
             .get('/xenon/api/healing/selector-health')
             .set('x-test-role', 'ADMIN');
         (0, chai_1.expect)(r.status).to.equal(200);

package/lib/test/integration/team-membership-migration.spec.js

@@ -8,28 +8,89 @@ var __awaiter = (this && this.__awaiter) || function (thisArg, _arguments, P, ge
         step((generator = generator.apply(thisArg, _arguments || [])).next());
     });
 };
+var __importDefault = (this && this.__importDefault) || function (mod) {
+    return (mod && mod.__esModule) ? mod : { "default": mod };
+};
 Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
+const child_process_1 = require("child_process");
+const fs_1 = __importDefault(require("fs"));
+const os_1 = __importDefault(require("os"));
+const path_1 = __importDefault(require("path"));
 const typedi_1 = require("typedi");
+const client_1 = require("../../src/generated/client");
 const UserService_1 = require("../../src/services/UserService");
 const TeamService_1 = require("../../src/services/TeamService");
 const prisma_1 = require("../../src/prisma");
+const scratch_database_1 = require("../helpers/scratch-database");
+const ROOT = path_1.default.resolve(__dirname, '../..');
+const MIGRATIONS = path_1.default.join(ROOT, 'prisma', 'migrations');
+/** The migration that backfills TeamMember from ApiKey.teamId. */
+const BACKFILL = '20260430001747_phase_3_team_members';
+/**
+ * `prisma migrate deploy` into `url` of the repository's migrations that
+ * `include` names, from a copy of the schema in `dir`. Run again with more
+ * of them, it applies only the ones not yet applied.
+ */
+function deploy(dir, url, include) {
+    const target = path_1.default.join(dir, 'migrations');
+    fs_1.default.mkdirSync(target, { recursive: true });
+    fs_1.default.copyFileSync(path_1.default.join(MIGRATIONS, 'migration_lock.toml'), path_1.default.join(target, 'migration_lock.toml'));
+    for (const name of fs_1.default.readdirSync(MIGRATIONS)) {
+        const sql = path_1.default.join(MIGRATIONS, name, 'migration.sql');
+        if (!include(name) || !fs_1.default.existsSync(sql))
+            continue;
+        fs_1.default.mkdirSync(path_1.default.join(target, name), { recursive: true });
+        fs_1.default.copyFileSync(sql, path_1.default.join(target, name, 'migration.sql'));
+    }
+    fs_1.default.copyFileSync(path_1.default.join(ROOT, 'prisma', 'schema.prisma'), path_1.default.join(dir, 'schema.prisma'));
+    (0, child_process_1.execSync)(`npx prisma migrate deploy --schema "${path_1.default.join(dir, 'schema.prisma')}"`, {
+        cwd: ROOT,
+        env: Object.assign(Object.assign({}, process.env), { DATABASE_URL: url }),
+        stdio: 'pipe',
+    });
+}
 describe('team-membership migration backfill (integration)', function () {
     this.timeout(60000);
-    it('no TeamMember row points at Legacy Admin', () => __awaiter(this, void 0, void 0, function* () {
-        const legacy = yield prisma_1.prisma.user.findFirst({
-            where: { email: 'legacy-admin@xenon.local' },
-        });
-        if (!legacy) {
-            // Legacy Admin only exists if Phase 1's adoption migration actually ran
-            // against a non-empty ApiKey table. Skip if absent.
-            // eslint-disable-next-line no-console
-            console.log('skipped: no Legacy Admin in this DB');
-            return;
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
+    // Through 2.14 this read the developer's own database, and returned early
+    // unless an old Legacy Admin happened to be in it. It runs the migration
+    // itself now, on a database migrated up to it and seeded as such a lab was.
+    it('backfills TeamMember from team keys, and gives Legacy Admin no membership', () => __awaiter(this, void 0, void 0, function* () {
+        const dir = fs_1.default.mkdtempSync(path_1.default.join(os_1.default.tmpdir(), 'xenon-team-backfill-'));
+        const url = `file:${path_1.default.join(dir, 'xenon.db')}`;
+        try {
+            deploy(dir, url, (name) => name < BACKFILL);
+            const before = new client_1.PrismaClient({ datasources: { db: { url } } });
+            try {
+                yield before.$executeRawUnsafe('INSERT INTO "Team" ("id", "name") VALUES (?, ?)', 'team-1', 'Team 1');
+                for (const [id, email] of [
+                    ['legacy', 'legacy-admin@xenon.local'],
+                    ['alice', 'alice@xenon.local'],
+                ]) {
+                    yield before.$executeRawUnsafe(`INSERT INTO "User" ("id", "email", "name", "passwordHash", "accessKey", "updatedAt")
+             VALUES (?, ?, ?, 'x', ?, CURRENT_TIMESTAMP)`, id, email, id, `ak-${id}`);
+                    yield before.$executeRawUnsafe(`INSERT INTO "ApiKey" ("id", "name", "keyHash", "scopes", "teamId", "userId")
+             VALUES (?, ?, ?, 'devices', 'team-1', ?)`, `key-${id}`, id, `hash-${id}`, id);
+                }
+            }
+            finally {
+                yield before.$disconnect();
+            }
+            deploy(dir, url, () => true);
+            const after = new client_1.PrismaClient({ datasources: { db: { url } } });
+            try {
+                const members = yield after.teamMember.findMany({ select: { teamId: true, userId: true } });
+                (0, chai_1.expect)(members).to.deep.equal([{ teamId: 'team-1', userId: 'alice' }]);
+            }
+            finally {
+                yield after.$disconnect();
+            }
+        }
+        finally {
+            fs_1.default.rmSync(dir, { recursive: true, force: true });
         }
-        const polluted = yield prisma_1.prisma.teamMember.count({ where: { userId: legacy.id } });
-        (0, chai_1.expect)(polluted).to.equal(0);
     }));
     it('addMember / removeMember round-trip an arbitrary user', () => __awaiter(this, void 0, void 0, function* () {
         const u = yield typedi_1.Container.get(UserService_1.UserService).createUser({

package/lib/test/integration/team-visibility-apps.spec.js

@@ -15,7 +15,7 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const fs_1 = __importDefault(require("fs"));
 const os_1 = __importDefault(require("os"));
 const path_1 = __importDefault(require("path"));
@@ -29,17 +29,17 @@ const app_service_1 = require("../../src/dashboard/services/app-service");
 const prisma_1 = require("../../src/prisma");
 const seedUser_1 = require("../helpers/seedUser");
 const container_registration_1 = require("../helpers/container-registration");
+const scratch_database_1 = require("../helpers/scratch-database");
 /**
  * Uploaded apps follow the device team rule, run as real queries: the list
  * builds a Prisma filter (`OR: [{ teamId: null }, { teamId: { in } }]`, with an
  * empty `in` for a member in no team) that a stub would only echo back.
  *
- * Run on a migrated database:
- *   DATABASE_URL=file:/tmp/x.db npx prisma migrate deploy
- *   DATABASE_URL=file:/tmp/x.db npx mocha test/integration/team-visibility-apps.spec.ts
+ * On a scratch database of its own, so `npx mocha <file>` is enough.
  */
 describe('team visibility on uploaded apps (integration)', function () {
     this.timeout(60000);
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
     let sa;
     let alice;
     let loner;
@@ -87,17 +87,10 @@ describe('team visibility on uploaded apps (integration)', function () {
             });
         }
     }));
-    after(() => __awaiter(this, void 0, void 0, function* () {
-        yield prisma_1.prisma.app.deleteMany({ where: { id: { in: Object.values(A) } } });
-        yield prisma_1.prisma.teamMember.deleteMany({ where: { teamId: { in: [teamA.id, teamB.id] } } });
-        yield prisma_1.prisma.team.delete({ where: { id: teamA.id } }).catch(() => undefined);
-        yield prisma_1.prisma.team.delete({ where: { id: teamB.id } }).catch(() => undefined);
-        yield sa.cleanup();
-        yield alice.cleanup();
-        yield loner.cleanup();
+    after(() => {
         restore();
         fs_1.default.rmSync(dir, { recursive: true, force: true });
-    }));
+    });
     function app() {
         const a = (0, express_1.default)();
         a.use(express_1.default.json());
@@ -106,13 +99,13 @@ describe('team visibility on uploaded apps (integration)', function () {
         return a;
     }
     const ids = (cookie) => __awaiter(this, void 0, void 0, function* () {
-        return (yield (0, supertest_1.default)(app()).get('/apps').set('Cookie', cookie)).body
+        return (yield (0, loopbackRequest_1.default)(app()).get('/apps').set('Cookie', cookie)).body
             .map((r) => r.id)
             .filter((id) => Object.values(A).includes(id));
     });
     const UNKNOWN = { error: 'App not found' };
     it("lists a member's shared and own-team apps, with the team's name", () => __awaiter(this, void 0, void 0, function* () {
-        const res = yield (0, supertest_1.default)(app()).get('/apps').set('Cookie', alice.cookie);
+        const res = yield (0, loopbackRequest_1.default)(app()).get('/apps').set('Cookie', alice.cookie);
         (0, chai_1.expect)(res.status).to.equal(200);
         const mine = res.body.filter((r) => Object.values(A).includes(r.id));
         (0, chai_1.expect)(mine.map((r) => r.id)).to.have.members([A.shared, A.a]);
@@ -127,20 +120,20 @@ describe('team visibility on uploaded apps (integration)', function () {
         (0, chai_1.expect)(yield ids(sa.cookie)).to.have.members(Object.values(A));
     }));
     it("answers another team's app exactly as an unknown id", () => __awaiter(this, void 0, void 0, function* () {
-        const hidden = yield (0, supertest_1.default)(app()).get(`/apps/${A.b}/download`).set('Cookie', alice.cookie);
-        const unknown = yield (0, supertest_1.default)(app())
+        const hidden = yield (0, loopbackRequest_1.default)(app()).get(`/apps/${A.b}/download`).set('Cookie', alice.cookie);
+        const unknown = yield (0, loopbackRequest_1.default)(app())
             .get(`/apps/nope-${stamp}/download`)
             .set('Cookie', alice.cookie);
         (0, chai_1.expect)(hidden.status).to.equal(404);
         (0, chai_1.expect)(hidden.body).to.deep.equal(UNKNOWN);
         (0, chai_1.expect)(unknown.status).to.equal(404);
         (0, chai_1.expect)(unknown.body).to.deep.equal(UNKNOWN);
-        const own = yield (0, supertest_1.default)(app()).get(`/apps/${A.a}/download`).set('Cookie', alice.cookie);
+        const own = yield (0, loopbackRequest_1.default)(app()).get(`/apps/${A.a}/download`).set('Cookie', alice.cookie);
         (0, chai_1.expect)(own.status).to.equal(200);
     }));
     it('a download ticket serves its app once, with no login', () => __awaiter(this, void 0, void 0, function* () {
         const t = yield typedi_1.Container.get(AppDownloadTicketService_1.AppDownloadTicketService).mint(A.b);
-        const first = yield (0, supertest_1.default)(app())
+        const first = yield (0, loopbackRequest_1.default)(app())
             .get(`/apps/${A.b}/download`)
             .query({ ticket: t })
             .buffer(true)
@@ -151,16 +144,16 @@ describe('team visibility on uploaded apps (integration)', function () {
         });
         (0, chai_1.expect)(first.status).to.equal(200);
         (0, chai_1.expect)(Buffer.compare(first.body, bytesOf(A.b))).to.equal(0);
-        const again = yield (0, supertest_1.default)(app()).get(`/apps/${A.b}/download`).query({ ticket: t });
+        const again = yield (0, loopbackRequest_1.default)(app()).get(`/apps/${A.b}/download`).query({ ticket: t });
         (0, chai_1.expect)(again.status).to.equal(401);
     }));
     it('moving an app to a team changes who sees it', () => __awaiter(this, void 0, void 0, function* () {
-        const put = (teamId) => (0, supertest_1.default)(app()).put(`/apps/${A.b}/team`).set('Cookie', sa.cookie).send({ teamId });
+        const put = (teamId) => (0, loopbackRequest_1.default)(app()).put(`/apps/${A.b}/team`).set('Cookie', sa.cookie).send({ teamId });
         (0, chai_1.expect)((yield put(teamA.id)).body).to.deep.equal({ ok: true, updated: 1 });
         (0, chai_1.expect)(yield ids(alice.cookie)).to.include(A.b);
         (0, chai_1.expect)((yield put(teamB.id)).status).to.equal(200);
         (0, chai_1.expect)(yield ids(alice.cookie)).to.not.include(A.b);
-        const member = yield (0, supertest_1.default)(app())
+        const member = yield (0, loopbackRequest_1.default)(app())
             .put(`/apps/${A.b}/team`)
             .set('Cookie', alice.cookie)
             .send({ teamId: teamA.id });

package/lib/test/integration/team-visibility-control.spec.js

@@ -16,7 +16,7 @@ require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
 const cors_1 = __importDefault(require("cors"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const fs_1 = __importDefault(require("fs"));
 const os_1 = __importDefault(require("os"));
 const path_1 = __importDefault(require("path"));
@@ -31,6 +31,10 @@ const prisma_1 = require("../../src/prisma");
 const seedUser_1 = require("../helpers/seedUser");
 const container_registration_1 = require("../helpers/container-registration");
 const device_store_1 = require("../../src/data-service/device-store");
+const db_1 = require("../../src/data-service/db");
+const scratch_database_1 = require("../helpers/scratch-database");
+const loki_stores_1 = require("../helpers/loki-stores");
+const own_node_id_1 = require("../helpers/own-node-id");
 /**
  * Teams are a device boundary on /control, end to end: the real auth
  * middleware computes req.auth.teamIds from TeamMember rows, and the real
@@ -88,23 +92,37 @@ const METHODS_BY_ACTION = CONTROL_ROUTES.reduce((acc, { method, action }) => {
 }, new Map());
 describe('team boundary on /control (integration)', function () {
     this.timeout(60000);
+    // Hermetic, so it runs in `npm run test:all` and on its own alike: users,
+    // teams and sessions go to a scratch database, never ~/.cache/xenon/xenon.db,
+    // and the phones to the in-memory device store. Nothing here stubs `prisma`
+    // itself, so the scratch database stands in for the whole suite.
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
+    (0, loki_stores_1.useLokiStores)();
+    // The fixture phones are this server's own; see DEVICE_HOST.
+    (0, own_node_id_1.useOwnNodeId)();
     let sa;
     let alice;
-    let teamA;
-    let teamB;
     let keyDir;
+    let deviceRows;
     const restores = [];
     const stamp = Date.now();
     const SHARED_UDID = `tb-shared-${stamp}`;
     const TEAM_A_UDID = `tb-team-a-${stamp}`;
     const TEAM_B_UDID = `tb-team-b-${stamp}`;
-    // The same length as TEAM_B_UDID, so an answer that echoes the path (Express's
-    // "Cannot GET …") has the same length for both.
+    // Team B's phone on a node. /control sends a node's phone's actions on to
+    // the node, or refuses them naming it (nodePhoneControl.ts), so the team
+    // guard has to have hidden it before that gate runs.
+    const TEAM_B_NODE_UDID = `tb-node-b-${stamp}`;
+    // The same length as the hidden udids, so an answer that echoes the path
+    // (Express's "Cannot GET …") has the same length for each.
     const UNKNOWN_UDID = `tb-nobody-${stamp}`;
-    // The tap handler proxies to the device's host unless it is this server, so
-    // every device lives "here" and each request says it is addressed here.
-    const DEVICE_HOST = 'http://127.0.0.1:4723';
-    const HOST_HEADER = '127.0.0.1:4723';
+    // Whose a phone is comes from its row: its nodeId, else its exact host
+    // (isOtherServersPhone). A row with neither of this server's is another
+    // server's phone, and /control sends its requests on to that host. So the
+    // fixtures carry this server's node id, and /control runs them here with
+    // the fake manager below. Port 1 has nothing listening, so a request sent
+    // on by mistake fails at once instead of reaching a real server here.
+    const DEVICE_HOST = 'http://127.0.0.1:1';
     before(() => __awaiter(this, void 0, void 0, function* () {
         keyDir = fs_1.default.mkdtempSync(path_1.default.join(os_1.default.tmpdir(), 'xenon-team-boundary-'));
         const keys = new JwtKeyService_1.JwtKeyService();
@@ -112,21 +130,28 @@ describe('team boundary on /control (integration)', function () {
         restores.push((0, container_registration_1.saveRegistrations)(JwtKeyService_1.JwtKeyService, device_managers_1.XenonManager));
         typedi_1.Container.set(JwtKeyService_1.JwtKeyService, keys);
         typedi_1.Container.set(device_managers_1.XenonManager, { deviceInstances: () => __awaiter(this, void 0, void 0, function* () { return [new IOSDeviceManager()]; }) });
+        // The scratch database goes with the suite, and every row seeded here
+        // with it.
         sa = yield (0, seedUser_1.seedUser)('SUPER_ADMIN', { name: 'TB SA' });
         alice = yield (0, seedUser_1.seedUser)('MEMBER', { name: 'Alice (team A)' });
-        teamA = yield typedi_1.Container.get(TeamService_1.TeamService).create(`tb-team-a-${stamp}`);
-        teamB = yield typedi_1.Container.get(TeamService_1.TeamService).create(`tb-team-b-${stamp}`);
+        const teamA = yield typedi_1.Container.get(TeamService_1.TeamService).create(`tb-team-a-${stamp}`);
+        const teamB = yield typedi_1.Container.get(TeamService_1.TeamService).create(`tb-team-b-${stamp}`);
         yield typedi_1.Container.get(TeamService_1.TeamService).addMember(teamA.id, alice.user.id);
+        // The in-memory store is one collection for the whole process. Held here,
+        // so `after` removes these rows whatever useLokiStores has put back by then.
+        deviceRows = yield db_1.XenonDatabase.DeviceModel;
         const store = device_store_1.DeviceStoreFactory.getStore();
-        for (const [udid, teamId] of [
-            [SHARED_UDID, null],
-            [TEAM_A_UDID, teamA.id],
-            [TEAM_B_UDID, teamB.id],
+        for (const [udid, teamId, nodeId] of [
+            [SHARED_UDID, null, own_node_id_1.OWN_NODE_ID],
+            [TEAM_A_UDID, teamA.id, own_node_id_1.OWN_NODE_ID],
+            [TEAM_B_UDID, teamB.id, own_node_id_1.OWN_NODE_ID],
+            [TEAM_B_NODE_UDID, teamB.id, 'tb-another-node'],
         ]) {
             const row = yield prisma_1.prisma.device.create({
                 data: {
                     udid,
                     host: DEVICE_HOST,
+                    nodeId,
                     name: udid,
                     platform: 'ios',
                     // Known screen size, so stream/ticket's after-response size fetch
@@ -139,19 +164,14 @@ describe('team boundary on /control (integration)', function () {
             yield store.addDevices([row]);
         }
     }));
-    after(() => __awaiter(this, void 0, void 0, function* () {
-        yield prisma_1.prisma.device.deleteMany({
-            where: { udid: { in: [SHARED_UDID, TEAM_A_UDID, TEAM_B_UDID] } },
+    after(() => {
+        deviceRows === null || deviceRows === void 0 ? void 0 : deviceRows.findAndRemove({
+            udid: { $in: [SHARED_UDID, TEAM_A_UDID, TEAM_B_UDID, TEAM_B_NODE_UDID] },
         });
-        yield prisma_1.prisma.teamMember.deleteMany({ where: { teamId: { in: [teamA.id, teamB.id] } } });
-        yield prisma_1.prisma.team.delete({ where: { id: teamA.id } }).catch(() => undefined);
-        yield prisma_1.prisma.team.delete({ where: { id: teamB.id } }).catch(() => undefined);
-        yield sa.cleanup();
-        yield alice.cleanup();
         for (const restore of restores.reverse())
             restore();
         fs_1.default.rmSync(keyDir, { recursive: true, force: true });
-    }));
+    });
     /**
      * The /xenon/api stack as src/app/index.ts builds it, as far as /control
      * goes: cors, auth, the control router, then `tail`.
@@ -181,8 +201,8 @@ describe('team boundary on /control (integration)', function () {
     }
     function send(who, method, udid, action, tail = 'api') {
         const url = `/xenon/api/control/${encodeURIComponent(udid)}/${action}`;
-        const req = (0, supertest_1.default)(buildApp(tail))[method](url);
-        return req.set('Cookie', who.cookie).set('Host', HOST_HEADER);
+        const req = (0, loopbackRequest_1.default)(buildApp(tail))[method](url);
+        return req.set('Cookie', who.cookie);
     }
     /** What a caller can observe of an answer, with the requested udid masked out. */
     function observed(res, udid) {
@@ -195,12 +215,12 @@ describe('team boundary on /control (integration)', function () {
             allow: res.headers['allow'],
         };
     }
-    function expectSameAnswer(method, action, tail) {
+    function expectSameAnswer(udid, method, action, tail) {
         return __awaiter(this, void 0, void 0, function* () {
             var _a;
-            const hidden = yield send(alice, method, TEAM_B_UDID, action, tail);
+            const hidden = yield send(alice, method, udid, action, tail);
             const unknown = yield send(alice, method, UNKNOWN_UDID, action, tail);
-            (0, chai_1.expect)(observed(hidden, TEAM_B_UDID)).to.deep.equal(observed(unknown, UNKNOWN_UDID));
+            (0, chai_1.expect)(observed(hidden, udid)).to.deep.equal(observed(unknown, UNKNOWN_UDID));
             // The guard's placeholder never reaches the caller, in a body or a header.
             (0, chai_1.expect)((_a = hidden.text) !== null && _a !== void 0 ? _a : '', 'body').to.not.include(controlDevice_1.HIDDEN_DEVICE_UDID);
             (0, chai_1.expect)(JSON.stringify(hidden.headers), 'headers').to.not.include(controlDevice_1.HIDDEN_DEVICE_UDID);
@@ -274,51 +294,58 @@ describe('team boundary on /control (integration)', function () {
     // has this phone. Hold every request to that: another team's phone has to
     // get the same status, body, content type, length and Allow header as a
     // udid that does not exist, whether a route handles the request or not.
-    describe("another team's phone answers exactly like an unknown udid", () => {
-        describe('on every route', () => {
-            for (const { method, action } of CONTROL_ROUTES) {
-                it(`${method.toUpperCase()} ${action}`, () => __awaiter(this, void 0, void 0, function* () {
-                    const res = yield expectSameAnswer(method, action, 'api');
-                    (0, chai_1.expect)(res.status, 'status').to.equal(404);
-                }));
-            }
-        });
-        const TAIL_LABEL = {
-            api: "the API's JSON 404",
-            express: "Express's own 404",
-            'echo-url': 'a later layer that echoes req.url',
-        };
-        for (const tail of ['api', 'express', 'echo-url']) {
-            describe(`where no route handles the request (${TAIL_LABEL[tail]})`, () => {
-                for (const [method, action] of [
-                    ['get', 'bogus'],
-                    ['post', 'bogus'],
-                    ['post', 'stream/bogus'],
-                    ['get', ''],
-                ]) {
-                    it(`${method.toUpperCase()} ${action || '(no action)'}`, () => __awaiter(this, void 0, void 0, function* () {
-                        yield expectSameAnswer(method, action, tail);
+    // On this server or on a node: a node's phone must not get the gate's
+    // forward or its refusal naming the node.
+    for (const [label, hiddenUdid] of [
+        ["another team's phone", TEAM_B_UDID],
+        ["another team's phone on a node", TEAM_B_NODE_UDID],
+    ]) {
+        describe(`${label} answers exactly like an unknown udid`, () => {
+            describe('on every route', () => {
+                for (const { method, action } of CONTROL_ROUTES) {
+                    it(`${method.toUpperCase()} ${action}`, () => __awaiter(this, void 0, void 0, function* () {
+                        const res = yield expectSameAnswer(hiddenUdid, method, action, 'api');
+                        (0, chai_1.expect)(res.status, 'status').to.equal(404);
                     }));
                 }
+            });
+            const TAIL_LABEL = {
+                api: "the API's JSON 404",
+                express: "Express's own 404",
+                'echo-url': 'a later layer that echoes req.url',
+            };
+            for (const tail of ['api', 'express', 'echo-url']) {
+                describe(`where no route handles the request (${TAIL_LABEL[tail]})`, () => {
+                    for (const [method, action] of [
+                        ['get', 'bogus'],
+                        ['post', 'bogus'],
+                        ['post', 'stream/bogus'],
+                        ['get', ''],
+                    ]) {
+                        it(`${method.toUpperCase()} ${action || '(no action)'}`, () => __awaiter(this, void 0, void 0, function* () {
+                            yield expectSameAnswer(hiddenUdid, method, action, tail);
+                        }));
+                    }
+                    for (const [action, methods] of METHODS_BY_ACTION) {
+                        const wrong = methods.includes('get') ? 'post' : 'get';
+                        if (methods.includes(wrong))
+                            continue;
+                        it(`${wrong.toUpperCase()} ${action} (the wrong method)`, () => __awaiter(this, void 0, void 0, function* () {
+                            yield expectSameAnswer(hiddenUdid, wrong, action, tail);
+                        }));
+                    }
+                });
+            }
+            describe('OPTIONS', () => {
                 for (const [action, methods] of METHODS_BY_ACTION) {
-                    const wrong = methods.includes('get') ? 'post' : 'get';
-                    if (methods.includes(wrong))
-                        continue;
-                    it(`${wrong.toUpperCase()} ${action} (the wrong method)`, () => __awaiter(this, void 0, void 0, function* () {
-                        yield expectSameAnswer(wrong, action, tail);
+                    it(`OPTIONS ${action}`, () => __awaiter(this, void 0, void 0, function* () {
+                        const res = yield expectSameAnswer(hiddenUdid, 'options', action, 'api');
+                        (0, chai_1.expect)(res.headers['allow'], 'allow').to.be.a('string');
+                        for (const m of methods)
+                            (0, chai_1.expect)(res.headers['allow']).to.include(m.toUpperCase());
                     }));
                 }
             });
-        }
-        describe('OPTIONS', () => {
-            for (const [action, methods] of METHODS_BY_ACTION) {
-                it(`OPTIONS ${action}`, () => __awaiter(this, void 0, void 0, function* () {
-                    const res = yield expectSameAnswer('options', action, 'api');
-                    (0, chai_1.expect)(res.headers['allow'], 'allow').to.be.a('string');
-                    for (const m of methods)
-                        (0, chai_1.expect)(res.headers['allow']).to.include(m.toUpperCase());
-                }));
-            }
         });
-    });
+    }
 });

package/lib/test/integration/team-visibility-dashboard.spec.js

@@ -15,15 +15,17 @@ Object.defineProperty(exports, "__esModule", { value: true });
 require("reflect-metadata");
 const chai_1 = require("chai");
 const express_1 = __importDefault(require("express"));
-const supertest_1 = __importDefault(require("supertest"));
+const loopbackRequest_1 = __importDefault(require("../helpers/loopbackRequest"));
 const authMiddleware_1 = require("../../src/middleware/authMiddleware");
 const dashboard_1 = __importDefault(require("../../src/app/routers/dashboard"));
 const typedi_1 = require("typedi");
 const TeamService_1 = require("../../src/services/TeamService");
 const prisma_1 = require("../../src/prisma");
 const seedUser_1 = require("../helpers/seedUser");
+const scratch_database_1 = require("../helpers/scratch-database");
 describe('team visibility on /dashboard reads (integration)', function () {
     this.timeout(60000);
+    (0, scratch_database_1.useScratchDatabase)({ wholeSuite: true });
     let sa;
     let aliceMember;
     let teamA;
@@ -94,24 +96,6 @@ describe('team visibility on /dashboard reads (integration)', function () {
             data: Object.assign({ id: `sess-b-${stamp}`, device_udid: TEAM_B_UDID, build_id: buildTeamB.id }, baseSession),
         });
     }));
-    after(() => __awaiter(this, void 0, void 0, function* () {
-        yield prisma_1.prisma.session.deleteMany({
-            where: { id: { in: [sessionShared.id, sessionTeamA.id, sessionTeamB.id] } },
-        });
-        yield prisma_1.prisma.build.deleteMany({
-            where: { id: { in: [buildShared.id, buildTeamA.id, buildTeamB.id] } },
-        });
-        yield prisma_1.prisma.device.deleteMany({
-            where: { udid: { in: [SHARED_UDID, TEAM_A_UDID, TEAM_B_UDID] } },
-        });
-        yield prisma_1.prisma.teamMember.deleteMany({
-            where: { teamId: { in: [teamA.id, teamB.id] } },
-        });
-        yield prisma_1.prisma.team.delete({ where: { id: teamA.id } }).catch(() => undefined);
-        yield prisma_1.prisma.team.delete({ where: { id: teamB.id } }).catch(() => undefined);
-        yield sa.cleanup();
-        yield aliceMember.cleanup();
-    }));
     function buildApp() {
         const app = (0, express_1.default)();
         app.use(express_1.default.json());
@@ -121,13 +105,13 @@ describe('team visibility on /dashboard reads (integration)', function () {
     }
     it('SA sees all three sessions; Alice sees only shared + team-A', () => __awaiter(this, void 0, void 0, function* () {
         const app = buildApp();
-        const saList = yield (0, supertest_1.default)(app).get('/session').set('Cookie', sa.cookie);
+        const saList = yield (0, loopbackRequest_1.default)(app).get('/session').set('Cookie', sa.cookie);
         (0, chai_1.expect)(saList.status).to.equal(200);
         const saIds = saList.body.map((s) => s.id);
         (0, chai_1.expect)(saIds).to.include(sessionShared.id);
         (0, chai_1.expect)(saIds).to.include(sessionTeamA.id);
         (0, chai_1.expect)(saIds).to.include(sessionTeamB.id);
-        const aliceList = yield (0, supertest_1.default)(app).get('/session').set('Cookie', aliceMember.cookie);
+        const aliceList = yield (0, loopbackRequest_1.default)(app).get('/session').set('Cookie', aliceMember.cookie);
         (0, chai_1.expect)(aliceList.status).to.equal(200);
         const aliceIds = aliceList.body.map((s) => s.id);
         (0, chai_1.expect)(aliceIds).to.include(sessionShared.id);
@@ -135,13 +119,13 @@ describe('team visibility on /dashboard reads (integration)', function () {
         (0, chai_1.expect)(aliceIds).to.not.include(sessionTeamB.id);
     }));
     it('Alice GET /session/:teamB-id → 404', () => __awaiter(this, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(buildApp())
+        const r = yield (0, loopbackRequest_1.default)(buildApp())
             .get(`/session/${sessionTeamB.id}`)
             .set('Cookie', aliceMember.cookie);
         (0, chai_1.expect)(r.status).to.equal(404);
     }));
     it('Alice GET /build → does not include team-B-only build', () => __awaiter(this, void 0, void 0, function* () {
-        const r = yield (0, supertest_1.default)(buildApp()).get('/build').set('Cookie', aliceMember.cookie);
+        const r = yield (0, loopbackRequest_1.default)(buildApp()).get('/build').set('Cookie', aliceMember.cookie);
         (0, chai_1.expect)(r.status).to.equal(200);
         const ids = r.body.map((b) => b.id);
         (0, chai_1.expect)(ids).to.include(buildShared.id);