@woosh/meep-engine 3.64.1 → 3.65.0

package/src/core/geom/3d/topology/struct/binary/io/bt_mesh_fill_small_holes.js

@@ -1,4 +1,5 @@
-import { bt_boundary_loop_fan_fill, bt_boundary_loop_order_from } from "./bt_boundary_loop.js";
+import { bt_boundary_loop_min_area_fill, bt_boundary_loop_order_from } from "./bt_boundary_loop.js";
+import { bt_mesh_compute_face_islands } from "../query/bt_mesh_compute_face_islands.js";
 import { bt_mesh_walk_boundary_loops } from "../query/bt_mesh_walk_boundary_loops.js";
 
 const _p = [0, 0, 0];
@@ -29,7 +30,14 @@ function loop_perimeter_and_area(mesh, verts) {
  * tiny boundary loop - that are numerical noise rather than meaningful openings. Such slivers inflate
  * the boundary length, the face count, and the loop count. This measures every boundary loop's mean
  * width (2*area/perimeter, the inradius of the area-equivalent disc) and fills each inner loop narrower
- * than `min_width`. The single largest-area loop is treated as the outer boundary and is never filled.
+ * than `min_width`.
+ *
+ * The largest-area loop of each island - each group of faces connected through shared edges - is that
+ * island's outline rather than a hole in it, and is never filled, however narrow the island is.
+ *
+ * Each hole is closed by {@link bt_boundary_loop_min_area_fill}: the triangles of least total area over
+ * the hole's own vertices. No vertex is added. A hole that cannot be closed without doubling an edge
+ * the mesh already has is left open and not counted.
  *
  * @param {BinaryTopology} mesh mesh whose boundary loops are inspected and (where too thin) filled in place
  * @param {number} min_width minimum mean width an inner loop must have to be kept; thinner loops are filled
@@ -48,7 +56,6 @@ export function bt_mesh_fill_small_holes(mesh, min_width) {
     }
     if (cycles.length <= 1) return 0;
 
-    // measure every loop; the largest-area one is the outer boundary and is never filled
     const measures = cycles.map(c => {
         const n = c.length;
         const verts = new Array(n);
@@ -58,19 +65,47 @@ export function bt_mesh_fill_small_holes(mesh, min_width) {
         return loop_perimeter_and_area(mesh, verts);
     });
 
-    let outer = 0;
-    for (let i = 1; i < measures.length; i++) {
-        if (measures[i].area > measures[outer].area) outer = i;
+    // mean width of a loop = 2*area/perimeter; only a loop below the requested threshold can be a hole to fill
+    let has_thin_loop = false;
+    for (let i = 0; i < measures.length; i++) {
+        const { perimeter, area } = measures[i];
+        if (perimeter > 0 && 2 * area / perimeter < min_width) {
+            has_thin_loop = true;
+            break;
+        }
+    }
+    if (!has_thin_loop) return 0;
+
+    // Which island each loop bounds. The faces along a loop are all one island's, so the face on any one
+    // of its edges says which.
+    const islands = bt_mesh_compute_face_islands(mesh);
+    const island_of_face = new Uint32Array(mesh.faces.size);
+    for (let i = 0; i < islands.length; i++) {
+        const island = islands[i];
+        for (let j = 0; j < island.length; j++) {
+            island_of_face[island[j]] = i;
+        }
+    }
+
+    // the largest-area loop of an island is its outline, and is never filled
+    const island_of_loop = new Uint32Array(cycles.length);
+    const outline_of_island = new Int32Array(islands.length).fill(-1);
+    for (let i = 0; i < cycles.length; i++) {
+        const island = island_of_face[mesh.loop_read_face(mesh.edge_read_loop(cycles[i][0]))];
+        island_of_loop[i] = island;
+
+        const outline = outline_of_island[island];
+        if (outline === -1 || measures[i].area > measures[outline].area) {
+            outline_of_island[island] = i;
+        }
     }
 
     let filled = 0;
     for (let i = 0; i < cycles.length; i++) {
-        if (i === outer) continue;
+        if (outline_of_island[island_of_loop[i]] === i) continue;
         const { perimeter, area } = measures[i];
         if (perimeter <= 0) continue;
-        // mean width of the hole = 2*area/perimeter; fill when it is below the requested threshold
-        if (2 * area / perimeter < min_width) {
-            bt_boundary_loop_fan_fill(mesh, cycles[i]);
+        if (2 * area / perimeter < min_width && bt_boundary_loop_min_area_fill(mesh, cycles[i])) {
             filled++;
         }
     }

package/src/core/geom/3d/topology/struct/binary/query/bt_mesh_face_find_path_polyanya.d.ts.map

@@ -1 +1 @@
-{"version":3,"file":"bt_mesh_face_find_path_polyanya.d.ts","sourceRoot":"","sources":["../../../../../../../../../src/core/geom/3d/topology/struct/binary/query/bt_mesh_face_find_path_polyanya.js"],"names":[],"mappings":"AAuTA;;;;;;;;;;;;;;GAcG;AACH,wDAZW,MAAM,EAAE,GAAC,YAAY,GAAC,YAAY,gCAElC,MAAM,MACN,MAAM,MACN,MAAM,cACN,MAAM,MACN,MAAM,MACN,MAAM,MACN,MAAM,aACN,MAAM,GACJ,MAAM,CAyIlB"}
+{"version":3,"file":"bt_mesh_face_find_path_polyanya.d.ts","sourceRoot":"","sources":["../../../../../../../../../src/core/geom/3d/topology/struct/binary/query/bt_mesh_face_find_path_polyanya.js"],"names":[],"mappings":"AA+VA;;;;;;;;;;;;;;GAcG;AACH,wDAZW,MAAM,EAAE,GAAC,YAAY,GAAC,YAAY,gCAElC,MAAM,MACN,MAAM,MACN,MAAM,cACN,MAAM,MACN,MAAM,MACN,MAAM,MACN,MAAM,aACN,MAAM,GACJ,MAAM,CAuJlB"}