@windyroad/retrospective 0.27.1 → 0.27.2

package/scripts/test/check-tickets-deferred-cause.bats

@@ -1,330 +0,0 @@
-#!/usr/bin/env bats
-#
-# packages/retrospective/scripts/test/check-tickets-deferred-cause.bats
-#
-# Behavioural tests for `check-tickets-deferred-cause.sh` — the
-# Tickets Deferred cause-allowlist advisory script (P148). Mirrors
-# the fixture-based test pattern of `check-ask-hygiene.bats`.
-#
-# Tests are behavioural per ADR-005 / ADR-037 / P081 — they exercise
-# the script end-to-end against fixture retro summary directories
-# and assert on stdout / stderr / exit shape. No structural greps of
-# the script source itself.
-#
-# @problem P148 (Agent defers ticket creation — broadens Stage 1 fallback gate)
-# @problem P081 (Structural-content tests are wasteful — behavioural preferred)
-# @adr ADR-044 (Decision-Delegation Contract)
-# @adr ADR-040 (Tier 3 advisory-not-fail-closed)
-# @adr ADR-013 Rule 6 (non-interactive fail-safe)
-# @adr ADR-005 / ADR-037 (Plugin testing strategy — behavioural tests)
-# @jtbd JTBD-001 / JTBD-006 / JTBD-201
-
-SCRIPT="${BATS_TEST_DIRNAME}/../check-tickets-deferred-cause.sh"
-
-setup() {
-  TEST_DIR="$(mktemp -d)"
-}
-
-teardown() {
-  rm -rf "$TEST_DIR"
-}
-
-# ── Pre-checks ──────────────────────────────────────────────────────────────
-
-@test "script file exists and is executable" {
-  [ -f "$SCRIPT" ]
-  [ -x "$SCRIPT" ]
-}
-
-@test "missing retros dir exits 2 with error message on stderr" {
-  run bash "$SCRIPT" "$TEST_DIR/does-not-exist"
-  [ "$status" -eq 2 ]
-  [[ "$output" == *"retros dir not found"* ]]
-}
-
-@test "empty retros dir exits 0 with empty stdout" {
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-@test "default retros-dir argument is docs/retros (when omitted)" {
-  cd "$TEST_DIR"
-  run bash "$SCRIPT"
-  [ "$status" -eq 2 ]
-  [[ "$output" == *"docs/retros"* ]]
-}
-
-# ── No-defer steady state ───────────────────────────────────────────────────
-
-@test "retro file with no Tickets Deferred section emits no output" {
-  cat > "$TEST_DIR/2026-04-29-retro.md" <<'RETRO'
-## Session Retrospective
-
-### Briefing Changes
-- Added: foo
-
-### Problems Created/Updated
-- P148: opened
-
-### No Action Needed
-- learning captured
-RETRO
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-# ── Good fixture (skill_unavailable cause) ──────────────────────────────────
-
-@test "good fixture: skill_unavailable cause → 0 violations" {
-  cat > "$TEST_DIR/2026-04-29-retro.md" <<'RETRO'
-## Session Retrospective
-
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| Polling regex deadlock observation | `skill_unavailable` | Step 2b detection |
-| SIGTERM flush caveat | `skill_unavailable` | Step 4a verification |
-RETRO
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"deferred=2"* ]]
-  [[ "$output" == *"with_valid_cause=2"* ]]
-  [[ "$output" == *"violations=0"* ]]
-}
-
-# ── Bad fixture (session_pressure cause — the P148 anti-pattern) ────────────
-
-@test "bad fixture: session_pressure cause → all entries are violations" {
-  cat > "$TEST_DIR/2026-04-29-retro.md" <<'RETRO'
-## Session Retrospective
-
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| Polling regex deadlock | `session_pressure` | Step 2b |
-| SIGTERM flush caveat | `context_heavyweight` | Step 4a |
-RETRO
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"deferred=2"* ]]
-  [[ "$output" == *"with_valid_cause=0"* ]]
-  [[ "$output" == *"violations=2"* ]]
-}
-
-# ── Legacy fixture (no Cause column — pre-P148 retro shape) ─────────────────
-
-@test "legacy fixture: no Cause column → all entries are violations" {
-  cat > "$TEST_DIR/2026-04-29-retro.md" <<'RETRO'
-## Session Retrospective
-
-### Tickets Deferred
-
-| Observation | Citation |
-|-------------|----------|
-| Polling regex deadlock | Step 2b |
-| SIGTERM flush caveat | Step 4a |
-RETRO
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"deferred=2"* ]]
-  [[ "$output" == *"violations=2"* ]]
-}
-
-@test "legacy fixture exit code is 0 — advisory contract holds for AFK safety" {
-  # JTBD-006 line 32 (extended AFK safety): legacy retros lacking the Cause
-  # column would break AFK loops if exit code went non-zero. Fail-closed
-  # escalation belongs at a future hook tier per P135 R6 trajectory, not
-  # at the script.
-  cat > "$TEST_DIR/2026-04-29-retro.md" <<'RETRO'
-### Tickets Deferred
-
-| Observation | Citation |
-|-------------|----------|
-| obs1 | step1 |
-RETRO
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-}
-
-# ── Mixed fixture ───────────────────────────────────────────────────────────
-
-@test "mixed fixture: one valid + one invalid → violations=1, with_valid_cause=1" {
-  cat > "$TEST_DIR/2026-04-29-retro.md" <<'RETRO'
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| Valid observation | `skill_unavailable` | Step 2b |
-| Invalid observation | `session_pressure` | Step 4a |
-RETRO
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"deferred=2"* ]]
-  [[ "$output" == *"with_valid_cause=1"* ]]
-  [[ "$output" == *"violations=1"* ]]
-}
-
-# ── Empty Cause cell ────────────────────────────────────────────────────────
-
-@test "empty Cause cell counts as a violation (cause-required invariant)" {
-  cat > "$TEST_DIR/2026-04-29-retro.md" <<'RETRO'
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| Observation with empty cause |   | Step 2b |
-RETRO
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"violations=1"* ]]
-}
-
-# ── Format tolerance ────────────────────────────────────────────────────────
-
-@test "Cause cell tolerates surrounding whitespace and bold markers" {
-  cat > "$TEST_DIR/2026-04-29-retro.md" <<'RETRO'
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| obs1 |    `skill_unavailable`    | Step 2b |
-| obs2 | **skill_unavailable** | Step 4a |
-RETRO
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"deferred=2"* ]]
-  [[ "$output" == *"with_valid_cause=2"* ]]
-  [[ "$output" == *"violations=0"* ]]
-}
-
-@test "placeholder template row is skipped — not counted as a deferred entry" {
-  # The retro summary template includes a placeholder example row in the
-  # SKILL.md template (with `<one-line observation summary>` literal text).
-  # When a retro is rendered with no real deferred entries, the template
-  # row may persist; the script must NOT count it as a real deferred
-  # observation.
-  cat > "$TEST_DIR/2026-04-29-retro.md" <<'RETRO'
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| <one-line observation summary> | `skill_unavailable` | <retro-step-citation> |
-RETRO
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-# ── Multi-file behaviour ────────────────────────────────────────────────────
-
-@test "multiple retro files emit per-file lines plus a TOTAL summary line" {
-  cat > "$TEST_DIR/2026-04-25-retro.md" <<'RETRO'
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| good obs | `skill_unavailable` | Step 2b |
-RETRO
-  cat > "$TEST_DIR/2026-04-29-retro.md" <<'RETRO'
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| bad obs | `session_pressure` | Step 4a |
-RETRO
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"RETRO 2026-04-25"* ]]
-  [[ "$output" == *"RETRO 2026-04-29"* ]]
-  [[ "$output" == *"TOTAL files=2 deferred=2 with_valid_cause=1 violations=1"* ]]
-}
-
-@test "files sorted oldest-first by date prefix" {
-  for d in 27 25 26; do
-    cat > "$TEST_DIR/2026-04-$d-retro.md" <<RETRO
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| obs$d | \`skill_unavailable\` | Step$d |
-RETRO
-  done
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  line1="${lines[0]}"
-  line2="${lines[1]}"
-  line3="${lines[2]}"
-  [[ "$line1" == *"2026-04-25"* ]]
-  [[ "$line2" == *"2026-04-26"* ]]
-  [[ "$line3" == *"2026-04-27"* ]]
-}
-
-# ── File-type filtering ─────────────────────────────────────────────────────
-
-@test "ask-hygiene trail files are skipped (not retro summaries)" {
-  cat > "$TEST_DIR/2026-04-29-ask-hygiene.md" <<'TRAIL'
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| should be ignored | `session_pressure` | irrelevant |
-TRAIL
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-@test "context-analysis files are skipped (not retro summaries)" {
-  cat > "$TEST_DIR/2026-04-29-context-analysis.md" <<'CTX'
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| should be ignored | `session_pressure` | irrelevant |
-CTX
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-@test "files without a YYYY-MM-DD date prefix are skipped" {
-  cat > "$TEST_DIR/README.md" <<'RM'
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| should be ignored | `session_pressure` | irrelevant |
-RM
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-# ── Cross-shell portability (P124 / P133 lessons) ───────────────────────────
-
-@test "script glob iteration uses portable for-loop existence check" {
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"*.md"* ]]
-}
-
-# ── Read-only contract ──────────────────────────────────────────────────────
-
-@test "script is read-only — fixture tree unchanged after run" {
-  cat > "$TEST_DIR/2026-04-29-retro.md" <<'RETRO'
-### Tickets Deferred
-
-| Observation | Cause | Citation |
-|-------------|-------|----------|
-| obs1 | `skill_unavailable` | Step 2b |
-RETRO
-  pre_hash=$(find "$TEST_DIR" -type f -exec cksum {} \; 2>/dev/null | sort | cksum | awk '{print $1}')
-  run bash "$SCRIPT" "$TEST_DIR"
-  [ "$status" -eq 0 ]
-  post_hash=$(find "$TEST_DIR" -type f -exec cksum {} \; 2>/dev/null | sort | cksum | awk '{print $1}')
-  [ "$pre_hash" = "$post_hash" ]
-}

package/scripts/test/list-plugin-attribution.bats

@@ -1,149 +0,0 @@
-#!/usr/bin/env bats
-
-# @problem P153 — Published skills enumerate repo-relative directories.
-# `/wr-retrospective:analyze-context` SKILL.md L56-67 used a `for plugin_dir
-# in packages/*/hooks; do ... done` glob loop that expanded to nothing in
-# adopter trees, silently emitting zero PLUGIN-HOOKS / PLUGIN-SKILLS rows.
-#
-# Fix: extract the loop into a helper script that probes for the source-
-# tree first (preserves dev-session output) and falls back to a `$PATH`-
-# derived plugin-cache walk so adopter sessions resolve too. Same row
-# shape; backward compatible with deep-layer SKILL.md Step 4 sum-check.
-#
-# Contract:
-#   list-plugin-attribution.sh [<project-root>]
-#
-# Default project-root is the current working directory.
-#
-# Output (one line per row, terse machine-readable per ADR-038 ≤150 bytes):
-#   PLUGIN-HOOKS <plugin> bytes=<N>
-#   PLUGIN-SKILLS <plugin> bytes=<N>
-#   PLUGIN-ATTRIBUTION not-measured reason=<reason>
-#
-# Exit code: 0 always (advisory, matches measure-context-budget.sh contract).
-#
-# Resolution order:
-#   1. Source-tree mode — if `<project-root>/packages/*/hooks` glob expands
-#      to anything, walk it. Same applies to `packages/*/skills`.
-#   2. Cache-fallback mode — sniff `$PATH` entries that match
-#      `*/cache/<owner>/<plugin>/<version>/bin`; walk back to each
-#      plugin's root and emit the same row shape.
-#   3. Neither — emit `PLUGIN-ATTRIBUTION not-measured
-#      reason=no-plugin-source-resolvable`.
-#
-# @adr ADR-049 (Plugin-bundled scripts via `bin/` on `$PATH` —
-#   reassessment-criteria clause 3 explicitly anticipates this surface)
-# @adr ADR-038 (Progressive disclosure — per-row byte budget)
-# @adr ADR-026 (Agent output grounding — explicit not-measured sentinels)
-# @adr ADR-005 (Plugin testing strategy)
-# @adr ADR-037 (Skill testing strategy — bats-contract precedent)
-# @jtbd JTBD-301 (Plugin-user) / JTBD-101 (Plugin-developer)
-
-setup() {
-  SCRIPTS_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SCRIPT="$SCRIPTS_DIR/list-plugin-attribution.sh"
-  FIXTURE_DIR="$(mktemp -d)"
-  # Minimal PATH for bash + coreutils, but no plugin-cache bin dirs.
-  # Tests that exercise cache-fallback explicitly prepend a synthetic
-  # cache bin to this MIN_PATH.
-  MIN_PATH="/usr/bin:/bin"
-}
-
-teardown() {
-  rm -rf "$FIXTURE_DIR"
-}
-
-# ── Existence + executable ──────────────────────────────────────────────────
-
-@test "list-plugin-attribution: script file exists at expected path" {
-  [ -f "$SCRIPT" ]
-}
-
-@test "list-plugin-attribution: script is executable" {
-  [ -x "$SCRIPT" ]
-}
-
-# ── Exit code ───────────────────────────────────────────────────────────────
-
-@test "list-plugin-attribution: empty fixture exits 0 (advisory)" {
-  # Run with an empty PATH so the cache-fallback yields nothing too.
-  run env PATH="$MIN_PATH" bash "$SCRIPT" "$FIXTURE_DIR"
-  [ "$status" -eq 0 ]
-}
-
-# ── Source-tree mode ────────────────────────────────────────────────────────
-
-@test "list-plugin-attribution: source-tree mode emits PLUGIN-HOOKS row for packages/<plugin>/hooks" {
-  mkdir -p "$FIXTURE_DIR/packages/foo/hooks"
-  printf '%s' 'echo hi' > "$FIXTURE_DIR/packages/foo/hooks/h.sh"
-  run env PATH="$MIN_PATH" bash "$SCRIPT" "$FIXTURE_DIR"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -qE '^PLUGIN-HOOKS foo bytes=[0-9]+$'
-}
-
-@test "list-plugin-attribution: source-tree mode emits PLUGIN-SKILLS row for packages/<plugin>/skills" {
-  mkdir -p "$FIXTURE_DIR/packages/foo/skills/wizard"
-  printf '%s' '# Wizard' > "$FIXTURE_DIR/packages/foo/skills/wizard/SKILL.md"
-  run env PATH="$MIN_PATH" bash "$SCRIPT" "$FIXTURE_DIR"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -qE '^PLUGIN-SKILLS foo bytes=[0-9]+$'
-}
-
-@test "list-plugin-attribution: source-tree mode reports nonzero hook bytes when files present" {
-  mkdir -p "$FIXTURE_DIR/packages/foo/hooks"
-  printf '%s' 'echo hi' > "$FIXTURE_DIR/packages/foo/hooks/h.sh"   # 7 bytes
-  run env PATH="$MIN_PATH" bash "$SCRIPT" "$FIXTURE_DIR"
-  bytes=$(echo "$output" | awk '/^PLUGIN-HOOKS foo bytes=/{ split($3, a, "="); print a[2] }')
-  [ "${bytes:-0}" -gt 0 ]
-}
-
-@test "list-plugin-attribution: source-tree mode emits one row per plugin (multi-plugin)" {
-  mkdir -p "$FIXTURE_DIR/packages/foo/hooks" "$FIXTURE_DIR/packages/bar/hooks"
-  printf 'x' > "$FIXTURE_DIR/packages/foo/hooks/h.sh"
-  printf 'x' > "$FIXTURE_DIR/packages/bar/hooks/h.sh"
-  run env PATH="$MIN_PATH" bash "$SCRIPT" "$FIXTURE_DIR"
-  echo "$output" | grep -qE '^PLUGIN-HOOKS foo bytes='
-  echo "$output" | grep -qE '^PLUGIN-HOOKS bar bytes='
-}
-
-# ── Cache-fallback mode ─────────────────────────────────────────────────────
-
-@test "list-plugin-attribution: cache-fallback mode resolves plugins via PATH-derived bin dirs" {
-  # Synthesise an adopter-shaped layout: ~/.claude/plugins/cache/<owner>/<plugin>/<version>/
-  cache_root="$FIXTURE_DIR/.claude/plugins/cache/wroad/myplug/0.0.1"
-  mkdir -p "$cache_root/bin" "$cache_root/hooks" "$cache_root/skills/s1"
-  printf '%s' 'exec true' > "$cache_root/bin/wr-myplug-cmd"
-  chmod +x "$cache_root/bin/wr-myplug-cmd"
-  printf 'hook' > "$cache_root/hooks/h.sh"
-  printf 'skill' > "$cache_root/skills/s1/SKILL.md"
-
-  # CWD has no packages/ dir → forces cache-fallback path.
-  empty_cwd="$FIXTURE_DIR/empty"
-  mkdir -p "$empty_cwd"
-
-  run env PATH="$cache_root/bin:$MIN_PATH" bash "$SCRIPT" "$empty_cwd"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -qE '^PLUGIN-HOOKS myplug bytes=[0-9]+$'
-  echo "$output" | grep -qE '^PLUGIN-SKILLS myplug bytes=[0-9]+$'
-}
-
-# ── Neither source nor cache resolves ───────────────────────────────────────
-
-@test "list-plugin-attribution: emits not-measured sentinel when nothing resolves" {
-  # Empty fixture, empty PATH → zero source + zero cache.
-  run env PATH="$MIN_PATH" bash "$SCRIPT" "$FIXTURE_DIR"
-  [ "$status" -eq 0 ]
-  echo "$output" | grep -qE '^PLUGIN-ATTRIBUTION not-measured reason=no-plugin-source-resolvable$'
-}
-
-# ── Output budget ───────────────────────────────────────────────────────────
-
-@test "list-plugin-attribution: every output row is under 150 bytes (ADR-038)" {
-  mkdir -p "$FIXTURE_DIR/packages/foo/hooks" "$FIXTURE_DIR/packages/foo/skills/s1"
-  printf 'x' > "$FIXTURE_DIR/packages/foo/hooks/h.sh"
-  printf 'x' > "$FIXTURE_DIR/packages/foo/skills/s1/SKILL.md"
-  run env PATH="$MIN_PATH" bash "$SCRIPT" "$FIXTURE_DIR"
-  while IFS= read -r line; do
-    [ "${#line}" -le 150 ]
-  done <<< "$output"
-}