@windyroad/retrospective 0.27.1 → 0.27.2

package/scripts/test/check-plugin-maturity-drift.bats

@@ -1,269 +0,0 @@
-#!/usr/bin/env bats
-
-# @problem P238 — Phase 3b drift detector behavioural confirmation.
-# @problem P087 — parent: plugin maturity battle-hardening signal.
-# @problem P152 — sibling drift-detector pattern (JTBD-currency).
-#
-# Contract under test:
-# `packages/retrospective/scripts/check-plugin-maturity-drift.sh` is an
-# advisory drift detector. It compares each plugin's rendered README
-# maturity badge against the canonical `plugin.json` `maturity:` field
-# and emits NDJSON-per-drift signals to stdout. Exit code 0 always per
-# ADR-013 Rule 6 — drift is data, not failure.
-#
-# Drift classes:
-#   missing-badge      — plugin.json has maturity but README has no badge
-#   stale-band         — badge band mismatches canonical record
-#   orphan-badge       — README has badge but plugin.json has no maturity
-#   anti-pattern-section — README has standalone ## Maturity section
-#   anti-pattern-url   — README has shields.io / SVG badge URL
-#
-# @adr ADR-063 (Plugin maturity presentation layer — Phase 3b contract)
-# @adr ADR-051 (Sibling drift-detector pattern — `check-readme-jtbd-currency.sh`)
-# @adr ADR-013 Rule 6 (non-interactive fail-safe — exit 0 always)
-# @adr ADR-049 (Shim grammar — `wr-retrospective-check-plugin-maturity-drift` on $PATH)
-# @adr ADR-052 (Behavioural tests default)
-
-setup() {
-  SCRIPTS_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SCRIPT="$SCRIPTS_DIR/check-plugin-maturity-drift.sh"
-  FIXTURE_DIR="$(mktemp -d)"
-  PROJECT_ROOT="$FIXTURE_DIR/project"
-  PKG_DIR="$PROJECT_ROOT/packages"
-  mkdir -p "$PKG_DIR"
-}
-
-teardown() {
-  rm -rf "$FIXTURE_DIR"
-}
-
-# Helper: write a synthetic plugin layout with plugin.json + README.md
-make_plugin() {
-  local name="$1"
-  local plugin_json="$2"
-  local readme="$3"
-  local pkg="$PKG_DIR/$name"
-  mkdir -p "$pkg/.claude-plugin"
-  printf '%s\n' "$plugin_json" > "$pkg/.claude-plugin/plugin.json"
-  printf '%s\n' "$readme" > "$pkg/README.md"
-}
-
-# ── Pre-checks ──────────────────────────────────────────────────────────────
-
-@test "script file exists and is executable" {
-  [ -f "$SCRIPT" ]
-  [ -x "$SCRIPT" ]
-}
-
-@test "missing packages dir exits 2 with error message on stderr" {
-  run bash "$SCRIPT" "$FIXTURE_DIR/does-not-exist"
-  [ "$status" -eq 2 ]
-  [[ "$output" == *"packages dir not found"* ]]
-}
-
-@test "empty packages dir exits 0 with empty stdout" {
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"TOTAL"* ]] || [ -z "$output" ]
-}
-
-# ── Clean fixture: badge matches plugin.json record ─────────────────────────
-
-@test "clean fixture: matching badge + record emits no drift hints" {
-  make_plugin "stub" '{"name":"wr-stub","version":"0.1.0","description":"Stub","maturity":{"schema_version":"1.0","band":"Alpha"}}' \
-"# @windyroad/stub
-
-**Stub plugin description.** *Maturity: Alpha.*
-
-## Skills
-"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"package=stub"* ]]
-  [[ "$output" == *"drift_hints="* ]]
-  [[ "$output" != *"stale-band"* ]]
-  [[ "$output" != *"missing-badge"* ]]
-}
-
-# ── Stale-band fixture: badge != canonical record ───────────────────────────
-
-@test "stale-band fixture: README badge band mismatches plugin.json record" {
-  make_plugin "stub" '{"name":"wr-stub","version":"0.1.0","description":"Stub","maturity":{"schema_version":"1.0","band":"Beta"}}' \
-"# @windyroad/stub
-
-**Stub plugin description.** *Maturity: Alpha.*
-
-## Skills
-"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"package=stub"* ]]
-  [[ "$output" == *"stale-band"* ]]
-}
-
-# ── Missing-badge fixture: plugin.json has maturity, README has no badge ────
-
-@test "missing-badge fixture: plugin.json has maturity but README has no badge" {
-  make_plugin "stub" '{"name":"wr-stub","version":"0.1.0","description":"Stub","maturity":{"schema_version":"1.0","band":"Alpha"}}' \
-"# @windyroad/stub
-
-**Stub plugin description.**
-
-## Skills
-"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"package=stub"* ]]
-  [[ "$output" == *"missing-badge"* ]]
-}
-
-# ── Orphan-badge fixture: README has badge, plugin.json has no maturity ─────
-
-@test "orphan-badge fixture: README badge present but plugin.json lacks maturity field" {
-  make_plugin "stub" '{"name":"wr-stub","version":"0.1.0","description":"Stub"}' \
-"# @windyroad/stub
-
-**Stub plugin description.** *Maturity: Alpha.*
-
-## Skills
-"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"package=stub"* ]]
-  [[ "$output" == *"orphan-badge"* ]]
-}
-
-# ── Anti-pattern: standalone ## Maturity section ────────────────────────────
-
-@test "anti-pattern: standalone ## Maturity section emits anti-pattern-section hint" {
-  make_plugin "stub" '{"name":"wr-stub","version":"0.1.0","description":"Stub","maturity":{"schema_version":"1.0","band":"Alpha"}}' \
-"# @windyroad/stub
-
-**Stub plugin description.** *Maturity: Alpha.*
-
-## Maturity
-
-Alpha band.
-
-## Skills
-"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"package=stub"* ]]
-  [[ "$output" == *"anti-pattern-section"* ]]
-}
-
-# ── Anti-pattern: shields.io URL ────────────────────────────────────────────
-
-@test "anti-pattern: shields.io URL emits anti-pattern-url hint" {
-  make_plugin "stub" '{"name":"wr-stub","version":"0.1.0","description":"Stub","maturity":{"schema_version":"1.0","band":"Alpha"}}' \
-"# @windyroad/stub
-
-**Stub plugin description.** *Maturity: Alpha.* ![Maturity](https://img.shields.io/badge/maturity-alpha-orange)
-
-## Skills
-"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"package=stub"* ]]
-  [[ "$output" == *"anti-pattern-url"* ]]
-}
-
-# ── TOTAL summary line ──────────────────────────────────────────────────────
-
-@test "multi-plugin aggregation: emits TOTAL summary with drift count" {
-  make_plugin "alpha" '{"name":"wr-alpha","version":"0.1.0","description":"Alpha","maturity":{"schema_version":"1.0","band":"Alpha"}}' \
-"# @windyroad/alpha
-
-**Alpha plugin.** *Maturity: Alpha.*
-
-## Skills
-"
-  make_plugin "bravo" '{"name":"wr-bravo","version":"0.1.0","description":"Bravo","maturity":{"schema_version":"1.0","band":"Beta"}}' \
-"# @windyroad/bravo
-
-**Bravo plugin.**
-
-## Skills
-"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"package=alpha"* ]]
-  [[ "$output" == *"package=bravo"* ]]
-  [[ "$output" == *"TOTAL packages=2"* ]]
-  [[ "$output" == *"drift_instances=1"* ]]
-}
-
-# ── Exit-0-always invariant ─────────────────────────────────────────────────
-
-@test "exit-0-always: even with multiple drift entries, exit code is 0" {
-  make_plugin "alpha" '{"name":"wr-alpha","version":"0.1.0","description":"Alpha","maturity":{"schema_version":"1.0","band":"Beta"}}' \
-"# @windyroad/alpha
-
-**Alpha plugin.** *Maturity: Alpha.*
-
-## Skills
-"
-  make_plugin "bravo" '{"name":"wr-bravo","version":"0.1.0","description":"Bravo","maturity":{"schema_version":"1.0","band":"Stable"}}' \
-"# @windyroad/bravo
-
-**Bravo plugin.**
-
-## Skills
-"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-}
-
-# ── Package without README is silently skipped ──────────────────────────────
-
-@test "package without README.md is silently skipped" {
-  local pkg="$PKG_DIR/no-readme"
-  mkdir -p "$pkg/.claude-plugin"
-  echo '{"name":"wr-no-readme","version":"0.1.0","description":"No README","maturity":{"schema_version":"1.0","band":"Alpha"}}' > "$pkg/.claude-plugin/plugin.json"
-
-  make_plugin "with-readme" '{"name":"wr-with-readme","version":"0.1.0","description":"With README","maturity":{"schema_version":"1.0","band":"Alpha"}}' \
-"# @windyroad/with-readme
-
-**With README.** *Maturity: Alpha.*
-"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"package=no-readme"* ]]
-  [[ "$output" == *"package=with-readme"* ]]
-}
-
-# ── No-network primitive: ADR-035 privacy posture ───────────────────────────
-
-@test "ADR-035: script body invokes no network primitive" {
-  run grep -E "(curl|wget|nc -|netcat|ssh |scp |rsync|http\.client|urllib|requests)" "$SCRIPT"
-  [ "$status" -ne 0 ]
-}
-
-# ── NDJSON output: per-line shape parseable as structured signal ────────────
-
-@test "NDJSON output: each README line follows package=<name> <key>=<value> shape" {
-  make_plugin "stub" '{"name":"wr-stub","version":"0.1.0","description":"Stub","maturity":{"schema_version":"1.0","band":"Alpha"}}' \
-"# @windyroad/stub
-
-**Stub plugin description.** *Maturity: Alpha.*
-
-## Skills
-"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  # Per-package README line is space-separated key=value tokens
-  [[ "$output" == *"README package=stub"* ]]
-  [[ "$output" == *"badge_band="* ]]
-  [[ "$output" == *"record_band="* ]]
-}

package/scripts/test/check-readme-jtbd-currency.bats

@@ -1,165 +0,0 @@
-#!/usr/bin/env bats
-#
-# packages/retrospective/scripts/test/check-readme-jtbd-currency.bats
-#
-# Behavioural tests for `check-readme-jtbd-currency.sh` — the skill-inventory
-# README currency advisory (ADR-069 / P294, superseding ADR-051's JTBD-ID
-# rule). Mirrors the fixture-based pattern of sibling detectors
-# (`check-briefing-budgets.bats`, `check-ask-hygiene.bats`).
-#
-# Tests are behavioural per ADR-005 / ADR-052 / P081 — they exercise the
-# script end-to-end against fixture packages/ trees and assert on stdout /
-# exit code shape. No structural greps of the script source.
-#
-# @problem P152 (No pressure or nudge for documentation currency — original driver)
-# @problem P294 (ADR-051 superseded — README markets the persona's problem, no JTBD-ID citation)
-# @problem P081 (Structural-content tests are wasteful — behavioural preferred)
-# @adr ADR-069 (README markets persona problem; skill-inventory currency gate)
-# @adr ADR-051 (superseded — original JTBD-anchored README rule)
-# @adr ADR-013 Rule 6 (non-interactive fail-safe)
-# @adr ADR-005 / ADR-052 (Plugin testing strategy — behavioural tests)
-
-SCRIPT="${BATS_TEST_DIRNAME}/../check-readme-jtbd-currency.sh"
-
-setup() {
-  TEST_DIR="$(mktemp -d)"
-  PKG_DIR="$TEST_DIR/packages"
-  mkdir -p "$PKG_DIR"
-}
-
-teardown() {
-  rm -rf "$TEST_DIR"
-}
-
-# Helper: write a synthetic plugin README into PKG_DIR
-make_plugin() {
-  local name="$1"
-  local readme_content="$2"
-  mkdir -p "$PKG_DIR/$name"
-  printf '%s\n' "$readme_content" > "$PKG_DIR/$name/README.md"
-}
-
-# ── Pre-checks ──────────────────────────────────────────────────────────────
-
-@test "script file exists and is executable" {
-  [ -f "$SCRIPT" ]
-  [ -x "$SCRIPT" ]
-}
-
-@test "missing packages dir exits 2 with error message on stderr" {
-  run bash "$SCRIPT" "$TEST_DIR/does-not-exist"
-  [ "$status" -eq 2 ]
-  [[ "$output" == *"packages dir not found"* ]]
-}
-
-@test "empty packages dir exits 0 with empty stdout" {
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [ -z "$output" ]
-}
-
-@test "legacy second argument (former jtbd-dir) is accepted and ignored" {
-  make_plugin "stub" "# @windyroad/stub
-A plugin that solves a problem."
-  run bash "$SCRIPT" "$PKG_DIR" "/some/legacy/jtbd/path"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"package=stub"* ]]
-  [[ "$output" == *"TOTAL packages=1 drift_instances=0"* ]]
-}
-
-# ── Drift fixture: skills/ directory not named in README ────────────────────
-
-@test "drift fixture: skills/ directory not named in README emits skill-inventory-drift" {
-  mkdir -p "$PKG_DIR/stub/skills/orphan-widget"
-  printf '%s\n' "# @windyroad/stub
-This README documents no skills." > "$PKG_DIR/stub/README.md"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"package=stub"* ]]
-  [[ "$output" == *"skills=1"* ]]
-  [[ "$output" == *"in_readme=0"* ]]
-  [[ "$output" == *"drift_hints="*"skill-inventory-drift"* ]]
-  [[ "$output" == *"TOTAL packages=1 drift_instances=1"* ]]
-}
-
-# ── Clean fixture: every skill named in README ──────────────────────────────
-
-@test "clean fixture: all skills/ directories named in README emit empty drift_hints" {
-  mkdir -p "$PKG_DIR/stub/skills/manage-secret"
-  printf '%s\n' "# @windyroad/stub
-Run /wr-stub:manage-secret to rotate a secret." > "$PKG_DIR/stub/README.md"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"package=stub"* ]]
-  [[ "$output" == *"skills=1"* ]]
-  [[ "$output" == *"in_readme=1"* ]]
-  [[ "$output" != *"skill-inventory-drift"* ]]
-  [[ "$output" == *"TOTAL packages=1 drift_instances=0"* ]]
-}
-
-# ── Regression guard: a JTBD-NNN citation must NOT change the verdict ────────
-# (ADR-069 removed the JTBD-ID rule; the detector no longer reads JTBD IDs.)
-
-@test "regression: README with NO JTBD-NNN citation is clean when its skills are named" {
-  mkdir -p "$PKG_DIR/stub/skills/do-thing"
-  printf '%s\n' "# @windyroad/stub
-Markets a problem in plain prose. Run /wr-stub:do-thing. No JTBD IDs here." > "$PKG_DIR/stub/README.md"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"missing-jtbd-section"* ]]
-  [[ "$output" != *"stale-jtbd-citation"* ]]
-  [[ "$output" == *"TOTAL packages=1 drift_instances=0"* ]]
-}
-
-# ── Package with no skills/ directory ───────────────────────────────────────
-
-@test "package without a skills/ directory reports skills=0 and no drift" {
-  make_plugin "umbrella" "# @windyroad/umbrella
-A marketplace package with no skills of its own."
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"package=umbrella"* ]]
-  [[ "$output" == *"skills=0"* ]]
-  [[ "$output" == *"in_readme=0"* ]]
-  [[ "$output" != *"skill-inventory-drift"* ]]
-}
-
-# ── Multi-package aggregation ───────────────────────────────────────────────
-
-@test "multi-package aggregation: emits one README line per package + TOTAL summary" {
-  mkdir -p "$PKG_DIR/alpha/skills/run-alpha"
-  printf '%s\n' "# alpha
-Run /wr-alpha:run-alpha." > "$PKG_DIR/alpha/README.md"
-  mkdir -p "$PKG_DIR/bravo/skills/lost-skill"
-  printf '%s\n' "# bravo
-README forgot to mention its skill." > "$PKG_DIR/bravo/README.md"
-  make_plugin "charlie" "# charlie
-No skills directory at all."
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"package=alpha"* ]]
-  [[ "$output" == *"package=bravo"* ]]
-  [[ "$output" == *"package=charlie"* ]]
-  # only bravo drifts (lost-skill not named)
-  [[ "$output" == *"TOTAL packages=3 drift_instances=1"* ]]
-}
-
-# ── Package without README is skipped ───────────────────────────────────────
-
-@test "package without README.md is silently skipped" {
-  mkdir -p "$PKG_DIR/no-readme/skills/x"
-  mkdir -p "$PKG_DIR/with-readme/skills/y"
-  printf '%s\n' "# with-readme
-Run /wr-with-readme:y." > "$PKG_DIR/with-readme/README.md"
-
-  run bash "$SCRIPT" "$PKG_DIR"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"package=no-readme"* ]]
-  [[ "$output" == *"package=with-readme"* ]]
-  [[ "$output" == *"TOTAL packages=1"* ]]
-}