@windyroad/retrospective 0.27.1 → 0.27.2

package/skills/run-retro/test/run-retro-ticket-first-flow.bats

@@ -1,161 +0,0 @@
-#!/usr/bin/env bats
-# Doc-lint guard: run-retro SKILL.md Step 4b must implement the two-stage
-# ticket-first flow introduced by P075. Every codify-worthy observation files
-# a problem ticket first (mechanical, Stage 1); the codification shape is
-# recorded as the proposed fix strategy on the ticket (user-interactive,
-# Stage 2). The 19-option flat AskUserQuestion is removed.
-#
-# Structural assertion — Permitted Exception to the source-grep ban
-# (ADR-005 / P011 / ADR-037 contract-assertion pattern). These tests assert
-# that the SKILL.md contract document carries the new two-stage structure
-# and the architect-required audit notes.
-#
-# @problem P075
-# @jtbd JTBD-001 (enforce governance without slowing down — removes redundant ticketing axis)
-# @jtbd JTBD-006 (progress the backlog while I'm away — AFK-safe Rule 6 fallback)
-# @jtbd JTBD-101 (extend the suite with clear patterns)
-# @jtbd JTBD-201 (audit trail of AI-assisted work — every observation lands in the backlog)
-#
-# Cross-reference:
-#   P075: docs/problems/075-run-retro-codification-prompt-redundant-every-observation-is-a-problem.open.md
-#   P016: concern-boundary split preserved in Stage 1
-#   P044 / P050 / P051: reframed by P075 — fix-strategy on a problem ticket, not one option among 19
-#   ADR-013 Rule 1 / Rule 6 (docs/decisions/013-structured-user-interaction-for-governance-decisions.proposed.md)
-#   ADR-032 (docs/decisions/032-governance-skill-invocation-patterns.proposed.md) —
-#     foreground-spawns-N-background-fanout pattern and deferred-question contract
-#   ADR-037 (docs/decisions/037-skill-testing-strategy.proposed.md) — contract-assertion bats pattern
-
-setup() {
-  SKILL_DIR="$(cd "$(dirname "$BATS_TEST_FILENAME")/.." && pwd)"
-  SKILL_FILE="${SKILL_DIR}/SKILL.md"
-}
-
-@test "SKILL.md Step 4b has Stage 1 and Stage 2 headings (P075)" {
-  # Two-stage flow is the load-bearing shape of the P075 fix.
-  run grep -inE "Stage 1[: —-]|### Stage 1|\*\*Stage 1\*\*" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  run grep -inE "Stage 2[: —-]|### Stage 2|\*\*Stage 2\*\*" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 4b Stage 1 delegates to manage-problem (P075)" {
-  # Stage 1 fires mechanically: every codify-worthy observation becomes a
-  # problem ticket via the ticket-creation delegation path. Accept either the
-  # foreground manage-problem path or the future capture-problem background
-  # path (ADR-032 sibling).
-  run grep -inE "/wr-itil:manage-problem|/wr-itil:capture-problem" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 4b Stage 1 is mechanical — no ticketing AskUserQuestion (P075)" {
-  # The P075 user directive: "The answer should always be 'create a problem
-  # ticket' so the question is redundant." Stage 1 must NOT present
-  # ticketing as an AskUserQuestion option alongside other shapes. The
-  # literal "Problem — invoke manage-problem" option from the legacy
-  # 19-option flat list must be gone.
-  run grep -in "Problem — invoke manage-problem\|Problem - invoke manage-problem" "$SKILL_FILE"
-  [ "$status" -ne 0 ]
-}
-
-@test "SKILL.md Step 4b Stage 2 is silent agent action per ADR-044 (no AskUserQuestion)" {
-  # P135 Phase 2 / ADR-044: Stage 2 is no longer an AskUserQuestion per ticket;
-  # the agent picks the obvious-fit shape from the catalog. The legacy
-  # 'Proposed fix' AskUserQuestion header is GONE; the new contract is
-  # silent-agent-picks-from-catalog with user-edits-ticket-if-wrong correction.
-  run awk '/^#### Stage 2:/,/^#### Stub templates by Option/ {print}' "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"ADR-044"* ]]
-  [[ "$output" == *"silent"* ]]
-  # Negative: header line must NOT contain Proposed fix as an AskUserQuestion header
-  [[ "$output" != *"header: \"Proposed fix\""* ]]
-  [[ "$output" != *"header: 'Proposed fix'"* ]]
-}
-
-@test "SKILL.md Step 4b Stage 2 retains the four shape choices in the catalog (architect-pinned shapes preserved)" {
-  # Phase 2 removed the AskUserQuestion but preserved the four shape choices
-  # in the catalog narrative — agent now picks among them silently. The four
-  # shape labels must still be enumerated so the agent has a deterministic
-  # catalog to pick from.
-  run grep -cE "^[[:space:]]*[0-9]+\.[[:space:]]+\*\*(Skill — create stub|Skill — improvement stub|Other codification shape|Self-contained work)" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-  [ "$output" -ge 4 ]
-}
-
-@test "SKILL.md Step 4b Stage 2 option 4 is 'Self-contained work — no codification stub' (P075 + architect Q2)" {
-  # Architect Q2: the "no codification" option must not re-create the P044
-  # escape hatch. Required rename to "Self-contained work — no codification
-  # stub" with a Rule 6 audit note clarifying the valid scope.
-  run grep -inE "Self-contained work[[:space:]]*—[[:space:]]*no codification stub" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 4b Stage 2 option 4 carries a Rule 6 audit note (P075 + architect Q2)" {
-  # Architect-required audit note: Option 4 valid only when the problem is a
-  # bounded one-shot edit with no recurring-pattern signal. Protects P044's
-  # recommend-skills intent from leaking.
-  run grep -inE "bounded one-shot|no recurring[- ]pattern signal|not a recurring pattern|one-shot edit" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 4b Stage 2 option 3 captures 'Other codification shape' via free-text (P075 + architect Q4)" {
-  # Architect Q4 lean (b): free-text Fix Strategy capture, not cascading
-  # AskUserQuestion batches. The option must name the free-text capture
-  # path so downstream readers can tell cascading was rejected.
-  run grep -inE "Other codification shape.*free[- ]text|free[- ]text.*Fix Strategy|free[- ]text capture" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 4b records proposed fix on the ticket's '## Fix Strategy' section (P075)" {
-  # Fix strategy lives on the ticket, not in the retro summary. This is the
-  # structural invariant that decouples ticketing (Stage 1) from codification
-  # (Stage 2).
-  run grep -inE "## Fix Strategy|Fix Strategy section" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 4b cites ADR-032 for Stage 1 foreground-spawns-N-background fanout (architect Q1)" {
-  # Architect Q1: Stage 1 is a legitimate foreground-spawns-N-background case
-  # that ADR-032 does not currently contemplate. The SKILL.md must cite
-  # ADR-032 explicitly so the cross-plugin ownership boundary is legible.
-  run grep -inE "ADR-032|032-governance-skill-invocation-patterns" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 4b Stage 2 AFK fallback defers via deferred-question contract (P075 + architect Q3)" {
-  # Architect Q3: ADR-032 lines 90-110 define the deferred-question artefact
-  # shape (pending-questions + resumption context, FIFO). Stage 2 AFK branch
-  # must cite that contract, not re-invent a new artefact.
-  run grep -inE "deferred[- ]question|deferred question|pending[- ]question" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 4b Stage 1 preserves P016 concern-boundary split (P075)" {
-  # Stage 1's mechanical ticketing must still apply the concern-boundary rule
-  # so multi-concern observations split into separate tickets, not land as one
-  # conflated ticket.
-  run grep -inE "P016|concern[- ]boundary" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 4b retains ADR-013 Rule 6 non-interactive fallback (P075)" {
-  # Rule 6 must still apply: when AskUserQuestion is unavailable, Stage 2
-  # defers; Stage 1 fires regardless because it is mechanical.
-  run grep -inE "Rule 6|non-interactive" "$SKILL_FILE"
-  [ "$status" -eq 0 ]
-}
-
-@test "SKILL.md Step 4b drops the legacy 19-option flat list (P075 regression guard)" {
-  # The legacy flat list had option rows like "Settings — propose entry",
-  # "CI — propose step", "Test fixture — create stub", "Memory — propose
-  # note". Those rows are replaced by Stage 2 Option 3's free-text capture.
-  # This test is the regression guard — the legacy rows must not survive
-  # the rewrite.
-  run grep -inE "^[[:space:]]+[0-9]+\.[[:space:]]+\`?Settings[[:space:]]*—[[:space:]]*propose entry" "$SKILL_FILE"
-  [ "$status" -ne 0 ]
-  run grep -inE "^[[:space:]]+[0-9]+\.[[:space:]]+\`?CI[[:space:]]*—[[:space:]]*propose step" "$SKILL_FILE"
-  [ "$status" -ne 0 ]
-  run grep -inE "^[[:space:]]+[0-9]+\.[[:space:]]+\`?Test fixture[[:space:]]*—[[:space:]]*create stub" "$SKILL_FILE"
-  [ "$status" -ne 0 ]
-  run grep -inE "^[[:space:]]+[0-9]+\.[[:space:]]+\`?Memory[[:space:]]*—[[:space:]]*propose note" "$SKILL_FILE"
-  [ "$status" -ne 0 ]
-}

package/skills/run-retro/test/run-retro-verification-close-housekeeping.bats

@@ -1,132 +0,0 @@
-#!/usr/bin/env bats
-
-# P068: run-retro SKILL.md documents the Verification-close housekeeping
-# step (Step 4a) that surfaces in-session evidence for `.verifying.md`
-# tickets and delegates the close transition to /wr-itil:manage-problem.
-#
-# Doc-lint structural test (Permitted Exception per ADR-005). Asserts
-# SKILL.md wording for: the glob, the evidence-scan grounding (ADR-026),
-# the three categorisation buckets, the AskUserQuestion prompt contract
-# (ADR-013 Rule 1), the AFK fallback (ADR-013 Rule 6), the delegation
-# boundary to manage-problem Step 7 (ADR-022 + ADR-014 ownership), and
-# the ADR-027 auto-delegation compatibility note.
-
-setup() {
-  REPO_ROOT="$(cd "$(dirname "$BATS_TEST_FILENAME")/../../../../.." && pwd)"
-  SKILL_MD="$REPO_ROOT/packages/retrospective/skills/run-retro/SKILL.md"
-}
-
-@test "run-retro: SKILL.md contains Step 4a Verification-close housekeeping (P068)" {
-  run grep -F '### 4a. Verification-close housekeeping (P068)' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "run-retro: Step 4a globs docs/problems/*.verifying.md per ADR-022" {
-  run grep -F 'docs/problems/*.verifying.md' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "run-retro: Step 4a delegates the close transition to /wr-itil:manage-problem Step 7" {
-  run grep -F '/wr-itil:manage-problem' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-  run grep -F 'run-retro does **not** rename, edit the Status field, or commit' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "run-retro: Step 4a documents all three evidence-category buckets" {
-  run grep -F 'Exercised successfully in-session' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-  run grep -F 'Not exercised in-session' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-  run grep -F 'Exercised with regression' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "run-retro: Step 4a requires specific-citation grounding (ADR-026)" {
-  run grep -F 'ADR-026 grounding' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-  run grep -F 'not bare counts' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "run-retro: Step 4a close-on-evidence dispatches to /wr-itil:transition-problem (P135 Phase 2 / ADR-044)" {
-  # Phase 2 superseded the per-candidate AskUserQuestion (Close/Leave/Flag) with
-  # close-on-evidence delegation per ADR-044. The bats now assert the new
-  # contract: Step 4a delegates to /wr-itil:transition-problem WITHOUT asking,
-  # and ADR-044 framework-resolution boundary is the rationale.
-  run grep -F '/wr-itil:transition-problem' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-  run grep -F 'ADR-044' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "run-retro: Step 4a close-on-evidence requires concrete in-session citation (ADR-026 grounding)" {
-  # Phase 2 preserves the evidence requirement (ADR-026); without concrete
-  # citation, the ticket stays Verification Pending (ambiguous-evidence path).
-  run grep -F 'ADR-026' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "run-retro: Step 4a documents recovery path inline (P135 R5 — closes are reversible)" {
-  # Phase 2's close-on-evidence is reversible via /wr-itil:transition-problem
-  # known-error flip-back (the 2026-04-27 P124 precedent). Recovery path is
-  # documented inline alongside each close action in the Step 5 retro summary.
-  run awk '/^### 4a\./,/^### 4b\./ {print}' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-  [[ "$output" == *"Recovery"* ]] || [[ "$output" == *"reversible"* ]]
-}
-
-@test "run-retro: Step 4a AFK and interactive modes use identical close-on-evidence behaviour (ADR-044)" {
-  # Phase 2 collapsed the legacy AskUserQuestion-with-AFK-fallback into a
-  # single silent-close-on-evidence path. Per ADR-044 framework-resolution
-  # boundary: when the framework resolves the decision (concrete evidence
-  # per ADR-022 + ADR-026), the agent acts; per-candidate ask is lazy
-  # deferral. AFK and interactive paths are identical for this surface.
-  # Asserting the legacy "Non-interactive / AFK fallback (per ADR-013 Rule 6)"
-  # AskUserQuestion-vs-fallback split is GONE from Step 4a.
-  run awk '/^### 4a\./,/^### 4b\./ {print}' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-  [[ "$output" != *"do NOT auto-close"* ]]
-  [[ "$output" != *"Close P<NNN>\` — description"* ]]
-}
-
-@test "run-retro: Step 4a ADR-032 supersession note documents post-supersession context handling" {
-  # ADR-027 was superseded by ADR-032 (2026-04-21). The former
-  # "ADR-027 compatibility note" was rewritten to an ADR-032 supersession
-  # note that records the obviation of any Step-0 subagent migration.
-  # Structural grep retained for now (P081 anti-pattern; convert to
-  # behavioural fixture in a follow-up — tracked separately).
-  run grep -F 'ADR-032 supersession note' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-  run grep -F 'No Step-0 subagent migration applies' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "run-retro: Step 4a cites feedback_verify_from_own_observation memory for the deferred-close rationale" {
-  run grep -F 'feedback_verify_from_own_observation.md' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "run-retro: Step 4a documents interaction with manage-problem Step 9d and same-session verifyings are skipped" {
-  run grep -F 'manage-problem Step 9d' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-  run grep -F 'same-session verifyings' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "run-retro: Step 5 summary adds a Verification Candidates section" {
-  run grep -F '### Verification Candidates' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "run-retro: Verification Candidates table columns match the Step 4a output semantics" {
-  run grep -F '| Ticket | Fix summary | In-session citations | Decision |' "$SKILL_MD"
-  [ "$status" -eq 0 ]
-}
-
-@test "run-retro: Step 4a does not miscite ADR-018 as the retrospective contract (P068 architect review)" {
-  # The SKILL.md change must not claim ADR-018 governs the run-retro contract.
-  # ADR-018 is about AFK inter-iteration release cadence, not retrospective.
-  run grep -iE 'ADR-018.*retrospective (contract|ADR)|retrospective (contract|ADR).*ADR-018' "$SKILL_MD"
-  [ "$status" -ne 0 ]
-}