@wazo/sdk 0.39.14 → 0.40.0

package/esm/__tests__/api-client.test.js

@@ -74,7 +74,6 @@ client.setToken(token);
 describe('With correct API results', () => {
     beforeEach(() => {
         jest.resetModules();
-        // @ts-expect-error
         global.fetch = jest.fn(() => Promise.resolve(mockedJson));
     });
     describe('logIn test', () => {
@@ -87,13 +86,11 @@ describe('With correct API results', () => {
                 Authorization: `Basic ${Base64.encode(`${username}:${password}`)}`,
                 'Content-Type': 'application/json',
             };
-            // @ts-expect-error
             const result = await client.auth.logIn({
                 username,
                 password,
             });
             expect(result).toBeInstanceOf(Session);
-            // @ts-expect-error
             expect(result.token).toBe(1);
             expect(global.fetch).toBeCalledWith(`https://${server}/api/auth/${authVersion}/token`, {
                 method: 'post',
@@ -107,7 +104,6 @@ describe('With correct API results', () => {
     describe('logOut test', () => {
         it('should delete the specified token', async () => {
             const oldToken = 123;
-            // @ts-expect-error
             await client.auth.logOut(oldToken);
             expect(global.fetch).toBeCalledWith(`https://${server}/api/auth/${authVersion}/token/${oldToken}`, {
                 method: 'delete',
@@ -122,7 +118,6 @@ describe('With correct API results', () => {
 describe('With unAuthorized API results', () => {
     beforeEach(() => {
         jest.resetModules();
-        // @ts-expect-error
         global.fetch = jest.fn(() => Promise.resolve(mockedUnAuthorized));
     });
     describe('checkLogin test', () => {
@@ -143,7 +138,6 @@ describe('With unAuthorized API results', () => {
 describe('With not found API results', () => {
     beforeEach(() => {
         jest.resetModules();
-        // @ts-expect-error
         global.fetch = jest.fn(() => Promise.resolve(mockedNotFound));
     });
     describe('fetchVoicemail test', () => {
@@ -176,13 +170,11 @@ describe('With not found API results', () => {
 describe('With erroneous text API results', () => {
     beforeEach(() => {
         jest.resetModules();
-        // @ts-expect-error
         global.fetch = jest.fn(() => Promise.resolve(mockedTextError));
     });
     it('throw an exception when the response is >= 500', async () => {
         let error = null;
         try {
-            // @ts-expect-error
             await client.auth.logIn({
                 username,
                 password,
@@ -200,13 +192,11 @@ describe('With erroneous text API results', () => {
 describe('With erroneous json API results', () => {
     beforeEach(() => {
         jest.resetModules();
-        // @ts-expect-error
         global.fetch = jest.fn(() => Promise.resolve(mockedJsonError));
     });
     it('throw an exception when the response is >= 500', async () => {
         let error = null;
         try {
-            // @ts-expect-error
             await client.auth.logIn({
                 username,
                 password,

package/esm/__tests__/web-rtc-client.test.js

@@ -3,15 +3,12 @@ jest.mock('sip.js/lib/platform/web/transport');
 jest.mock('sip.js/lib/api/user-agent', () => ({
     start: () => { },
     UserAgent: class UserAgent {
-        // @ts-ignore
-        static makeURI = () => { };
-        // @ts-ignore
+        static makeURI = () => null;
         start = () => { };
         transport = {};
     },
 }));
-// @ts-expect-error
-const client = new WebRTCClient({});
+const client = new WebRTCClient({}, null, undefined);
 describe('WebRTC client', () => {
     it('should compute muted/unmuted state', async () => {
         const mutedSession = {
@@ -60,13 +57,9 @@ describe('WebRTC client', () => {
                 },
             },
         };
-        // @ts-expect-error
         expect(client.isAudioMuted(mutedSession)).toBeTruthy();
-        // @ts-expect-error
         expect(client.isAudioMuted(oldKindMuted)).toBeTruthy();
-        // @ts-expect-error
         expect(client.isAudioMuted(unMutedSession)).toBeFalsy();
-        // @ts-expect-error
         expect(client.isAudioMuted(oldKindUnmuted)).toBeFalsy();
     });
 });
@@ -126,26 +119,20 @@ describe('changeAudioInputDevice', () => {
         },
     });
     it('should change the audio input track if the provided id is different', async () => {
-        // @ts-expect-error
         client.setMediaConstraints(constraints);
         expect(client.getAudioDeviceId()).toBe(defaultId);
-        // @ts-expect-error
         const result = await client.changeAudioInputDevice(deviceId, session);
         expect(result).toBeTruthy();
     });
     it('should NOT change the audio input track if the provided id is the same', async () => {
-        // @ts-expect-error
         client.setMediaConstraints(constraints);
         expect(client.getAudioDeviceId()).toBe(defaultId);
-        // @ts-expect-error
         const result = await client.changeAudioInputDevice(defaultId, session);
         expect(result).toBeFalsy();
     });
     it('should change the audio input track if the provided id is the same and force param is TRUE', async () => {
-        // @ts-expect-error
         client.setMediaConstraints(constraints);
         expect(client.getAudioDeviceId()).toBe(defaultId);
-        // @ts-expect-error
         const result = await client.changeAudioInputDevice(defaultId, session, true);
         expect(result).toBeTruthy();
     });

package/esm/api/amid.js

@@ -1,9 +1,17 @@
 export default ((client, baseUrl) => ({
     action: (action, args = {}) => client.post(`${baseUrl}/action/${action}`, args),
     getAors: async (endpoint) => {
-        const rawEvents = await client.post(`${baseUrl}/action/PJSIPShowEndpoint`, {
-            Endpoint: endpoint,
-        }) || [];
-        return rawEvents.filter((event) => event.Event === 'ContactStatusDetail');
+        try {
+            const rawEvents = await client.post(`${baseUrl}/action/PJSIPShowEndpoint`, {
+                Endpoint: endpoint,
+            }) || [];
+            if (!rawEvents) {
+                return [];
+            }
+            return rawEvents.filter((event) => event.Event === 'ContactStatusDetail');
+        }
+        catch {
+            return [];
+        }
     },
 }));

package/esm/api/chatd.js

@@ -24,7 +24,6 @@ export default ((client, baseUrl) => ({
         if (uuids.length > MAX_PRESENCE_FETCHED) {
             const requests = uuids.reduce((acc, _, i) => {
                 if (i % MAX_PRESENCE_FETCHED === 0) {
-                    // @ts-ignore
                     acc.push(this.getMultipleLineState(uuids.slice(i, i + MAX_PRESENCE_FETCHED)));
                 }
                 return acc;

package/esm/api/dird.js

@@ -1,13 +1,10 @@
 import { jsonToGraphQLQuery } from 'json-to-graphql-query/lib/jsonToGraphQLQuery';
 import ApiRequester from '../utils/api-requester';
-import Contact from '../domain/Contact';
+import { Contact } from '../index';
 const getContactPayload = (contact) => ({
     email: contact.email,
-    // @ts-ignore
     firstname: contact.firstName ? contact.firstName : '',
-    // @ts-ignore
     lastname: contact.lastName ? contact.lastName : '',
-    // @ts-ignore
     number: contact.phoneNumber ? contact.phoneNumber : '',
     entreprise: contact.entreprise ? contact.entreprise : '',
     birthday: contact.birthday ? contact.birthday : '',
@@ -41,7 +38,7 @@ export default ((client, baseUrl) => ({
     }),
     fetchOffice365Contacts: (source, queryParams = null) => {
         if (!source) {
-            return null;
+            return Promise.resolve([]);
         }
         return client.get(`${baseUrl}/backends/office365/sources/${source.uuid}/contacts`, queryParams).then((response) => Contact.parseManyOffice365(response.items, source));
     },
@@ -51,7 +48,7 @@ export default ((client, baseUrl) => ({
     // Can be used with `queryParams = { uuid: uuid1, uuid2 }` to fetch multiple contacts
     fetchWazoContacts: (source, queryParams = null) => {
         if (!source) {
-            return null;
+            return Promise.resolve([]);
         }
         return client.get(`${baseUrl}/backends/wazo/sources/${source.uuid}/contacts`, queryParams).then((response) => Contact.parseManyWazo(response.items, source));
     },
@@ -60,7 +57,7 @@ export default ((client, baseUrl) => ({
     }),
     fetchGoogleContacts: (source, queryParams = null) => {
         if (!source) {
-            return null;
+            return Promise.resolve([]);
         }
         return client.get(`${baseUrl}/backends/google/sources/${source.uuid}/contacts`, queryParams).then((response) => Contact.parseManyGoogle(response.items, source));
     },
@@ -68,15 +65,15 @@ export default ((client, baseUrl) => ({
         backend: 'conference',
     }),
     fetchSourcesFor: (context, backend) => client.get(`${baseUrl}/directories/${context}/sources`, { backend }),
-    fetchPhonebookContacts: (source, params = null) => {
+    fetchPhonebookContacts: (source, params) => {
         if (!source) {
-            return null;
+            return Promise.resolve({ items: [], total: 0 });
         }
         return client.get(`${baseUrl}/backends/phonebook/sources/${source.uuid}/contacts`, params);
     },
     fetchConferenceContacts: (source) => {
         if (!source) {
-            return null;
+            return Promise.resolve([]);
         }
         return client.get(`${baseUrl}/backends/conference/sources/${source.uuid}/contacts`).then((response) => Contact.parseManyConference(response.items, source));
     },

package/esm/checker/checks/ice-ipv4.js

@@ -35,7 +35,7 @@ export default {
                 ...config.iceServers, };
         }
         if (externalAppConfig && externalAppConfig.turn_servers) {
-            config.iceServers = [...JSON.parse(externalAppConfig.turn_servers), ...config.iceServers];
+            config.iceServers = [...JSON.parse(externalAppConfig.turn_servers), ...(config.iceServers || [])];
             // Force to use TURN when defined in config
             config.iceTransportPolicy = 'relay';
         }
@@ -55,8 +55,7 @@ export default {
                     return reject(new Error('No `srflx` or `relay` found in candidate. Please consider using a TURN server.'));
                 }
                 if (ips.every(checkIsIPV4)) {
-                    // @ts-ignore
-                    resolve();
+                    resolve(null);
                 }
                 else {
                     const nonIPV4 = ips.find(ip => !checkIsIPV4(ip));

package/esm/checker/checks/symmetric-nat.js

@@ -36,16 +36,19 @@ export default {
         };
         timeout = setTimeout(onEnded, timeoutDuration);
         pc.createDataChannel('wazo-check-nat');
-        pc.onicecandidate = e => {
+        pc.onicecandidate = (e) => {
             nbCandidates++;
             if (e.candidate) {
                 rawCandidates.push(e.candidate.candidate);
             }
             if (e.candidate && e.candidate.candidate.indexOf('srflx') !== -1) {
                 const cand = parseCandidate(e.candidate.candidate);
-                if (!candidates[cand.relatedPort])
-                    candidates[cand.relatedPort] = [];
-                candidates[cand.relatedPort].push(cand.port);
+                if (cand.relatedPort) {
+                    if (!candidates[cand.relatedPort]) {
+                        candidates[cand.relatedPort] = [];
+                    }
+                    candidates[cand.relatedPort].push(cand.port);
+                }
             }
             else if (!e.candidate) {
                 onEnded();

package/esm/domain/AdHocAPIConference.js

@@ -25,7 +25,7 @@ export default class AdHocAPIConference {
     }
     async start() {
         this.started = true;
-        // @ts-ignore
+        // @ts-ignore: date / number
         this.answerTime = Object.values(this.participants).length ? Object.values(this.participants)[0].answerTime : null;
         const participantIds = Object.keys(this.participants);
         const conference = await getApiClient().calld.createAdHocConference(this.host.callId, participantIds);

package/esm/domain/CallLog.js

@@ -54,7 +54,7 @@ export default class CallLog {
     static parseNew(plain, session) {
         const callLog = CallLog.parse(plain);
         // @TODO: FIXME add verification declined vs missed call
-        callLog.newMissedCall = session && session.hasExtension(plain.requested_extension || plain.destination_extension) && !plain.answered;
+        callLog.newMissedCall = session && session.hasExtension((plain.requested_extension || plain.destination_extension)) && !plain.answered;
         return callLog;
     }
     static newFrom(profile) {

package/esm/domain/Contact.js

@@ -10,6 +10,7 @@ export const BACKEND = {
 };
 const SOURCE_MOBILE = 'mobile';
 export default class Contact {
+    static BACKEND = BACKEND;
     type;
     id;
     uuid;
@@ -404,7 +405,7 @@ export default class Contact {
     }
     merge(old) {
         Object.keys(old).filter(key => key !== 'lineState').forEach(key => {
-            // @ts-ignore
+            // @ts-ignore: keys
             this[key] = old[key] || this[key];
         });
         if (old.lineState) {

package/esm/domain/MeetingAuthorization.js

@@ -5,6 +5,12 @@ export const POST_PROCESSING = 'post_processing';
 export const POST_PROCESSED_SUCCESS = 'post_processed_success';
 export const POST_PROCESSED_ERROR = 'post_processed_error';
 export default class MeetingAuthorization {
+    static PENDING = PENDING;
+    static ACCEPTED = ACCEPTED;
+    static REJECTED = REJECTED;
+    static POST_PROCESSING = POST_PROCESSING;
+    static POST_PROCESSED_SUCCESS = POST_PROCESSED_SUCCESS;
+    static POST_PROCESSED_ERROR = POST_PROCESSED_ERROR;
     meetingUuid;
     uuid;
     userUuid;

package/esm/domain/Phone/CTIPhone.js

@@ -11,6 +11,7 @@ export default class CTIPhone extends Emitter {
     isMobile;
     callbackAllLines;
     currentCall;
+    client = null;
     constructor(session, isMobile = false, callbackAllLines = false) {
         super();
         logger.info('CTI Phone created');
@@ -283,4 +284,5 @@ export default class CTIPhone extends Emitter {
     }
     useLocalVideoElement() { }
     setMediaConstraints() { }
+    register() { return Promise.resolve(null); }
 }

package/esm/domain/Phone/WebRTCPhone.js

@@ -243,7 +243,6 @@ export default class WebRTCPhone extends Emitter {
         const shouldScreenShare = constraints && !!constraints.screen;
         const desktop = constraints && constraints.desktop;
         const options = sipSession.sessionDescriptionHandlerOptionsReInvite;
-        // @ts-ignore
         const wasAudioOnly = options?.audioOnly;
         const newStream = await this.client.upgradeToVideo(sipSession, constraints, isConference);
         if (callSession) {
@@ -340,9 +339,12 @@ export default class WebRTCPhone extends Emitter {
             return;
         }
         // Video events
-        const { 
-        // @ts-ignore
-        peerConnection, } = sipSession.sessionDescriptionHandler;
+        const sdh = sipSession.sessionDescriptionHandler;
+        const peerConnection = sdh.peerConnection;
+        if (!peerConnection) {
+            logger.info('null peer connection');
+            return;
+        }
         peerConnection.ontrack = (rawEvent) => {
             const event = rawEvent;
             const [stream] = event.streams;
@@ -477,6 +479,13 @@ export default class WebRTCPhone extends Emitter {
             cameraEnabled,
         });
         const callSession = this._createAcceptedCallSession(sipSession, cameraEnabled);
+        if (this.currentSipSession && !this.isCurrentCallSipSession(callSession)) {
+            logger.info('WebRTC phone - on call accepted with another ongoing call, holding it', {
+                sipId: sipSession.id,
+                cameraEnabled,
+            });
+            this.holdSipSession(this.currentSipSession, this.currentCallSession, true);
+        }
         this.currentSipSession = sipSession;
         this.currentCallSession = callSession;
         this.eventEmitter.emit(ON_TERMINATE_SOUND, callSession, 'call accepted');
@@ -593,7 +602,7 @@ export default class WebRTCPhone extends Emitter {
         if (callSession.getId() in this.ignoredSessions) {
             return false;
         }
-        // @ts-ignore
+        // @ts-ignore: does not exist
         if (!sipSession.isCanceled) {
             setTimeout(() => {
                 this.eventEmitter.emit(ON_PLAY_HANGUP_SOUND, this.audioOutputDeviceId, this.audioOutputVolume, callSession);
@@ -619,9 +628,8 @@ export default class WebRTCPhone extends Emitter {
         if (!sipSession) {
             return false;
         }
-        const { 
-        // @ts-ignore
-        peerConnection, } = sipSession.sessionDescriptionHandler;
+        const sdh = sipSession.sessionDescriptionHandler;
+        const peerConnection = sdh.peerConnection;
         const remoteStream = peerConnection.getRemoteStreams().find((stream) => !!stream.getVideoTracks().length);
         return remoteStream && remoteStream.getVideoTracks().some(track => !track.muted);
     }
@@ -981,9 +989,9 @@ export default class WebRTCPhone extends Emitter {
         this.currentCallSession = callSession;
         this.eventEmitter.emit(ON_CALL_OUTGOING, callSession);
         // If an invite promise exists, catch exceptions on it to trigger error like OverConstraintsError.
-        // @ts-ignore
+        // @ts-ignore: does not exist
         if (sipSession.invitePromise) {
-            // @ts-ignore
+            // @ts-ignore: does not exist
             sipSession.invitePromise.catch(error => {
                 this.eventEmitter.emit(ON_CALL_ERROR, error, callSession);
             });
@@ -1063,12 +1071,12 @@ export default class WebRTCPhone extends Emitter {
         return sipSession ? this.client.stopNetworkMonitoring(sipSession) : null;
     }
     forceCancel(sipSession) {
-        // @ts-ignore
+        // @ts-ignore: private
         if (!sipSession || !sipSession.outgoingInviteRequest) {
             return;
         }
         try {
-            // @ts-ignore
+            // @ts-ignore: private
             sipSession.outgoingInviteRequest.cancel();
         }
         catch (e) {
@@ -1282,7 +1290,6 @@ export default class WebRTCPhone extends Emitter {
             // send a reinvite to renegociate ICE with new IP
             if (this.shouldSendReinvite && this.currentSipSession && this.currentSipSession.state === SessionState.Established) {
                 this.shouldSendReinvite = false;
-                // @ts-ignore
                 const pc = this.currentSipSession?.sessionDescriptionHandler?.peerConnection;
                 const isConference = pc ? pc.sfu : false;
                 const hasVideo = this.currentCallSession && this.currentCallSession.cameraEnabled;
@@ -1365,14 +1372,12 @@ export default class WebRTCPhone extends Emitter {
         }
     }
     _onMessage(message) {
-        // @ts-ignore
         if (!message || message.method !== 'MESSAGE') {
             return;
         }
         let body;
         try {
-            // @ts-ignore
-            body = JSON.parse(message.body);
+            body = JSON.parse(message.body || '');
         }
         catch (e) {
             return;
@@ -1433,7 +1438,7 @@ export default class WebRTCPhone extends Emitter {
     _createCallSession(sipSession, fromSession, extra = {}) {
         // eslint-disable-next-line
         const identity = sipSession ? sipSession.remoteIdentity || sipSession.assertedIdentity : null;
-        // @ts-ignore
+        // @ts-ignore: private
         const number = identity ? identity.uri._normal.user : null;
         const { state, } = sipSession || {};
         const sessionId = this.getSipSessionId(sipSession);
@@ -1443,7 +1448,7 @@ export default class WebRTCPhone extends Emitter {
             sipCallId: sessionId,
             sipStatus: state,
             displayName: identity ? identity.displayName || number : number,
-            // @ts-ignore: @HEADSUP: startTime should be a number, not a date
+            // @ts-ignore: date / number
             startTime: fromSession ? fromSession.startTime : new Date(),
             creationTime: fromSession ? fromSession.creationTime : null,
             answerTime: fromSession ? fromSession.answerTime : null,

package/esm/domain/Session.js

@@ -28,7 +28,7 @@ export default class Session {
         if (token) {
             const isValid = jws.JWS.verifyJWT(token, swarmKey, {
                 alg: ['RS256'],
-                // @ts-ignore
+                // @ts-ignore: date / number
                 verifyAt: new Date(),
             });
             if (isValid) {
@@ -133,7 +133,7 @@ export default class Session {
         return line && Array.isArray(line.extensions) && line.extensions.length > 0 ? line.extensions[0].context : 'default';
     }
     hasEngineVersionGte(version) {
-        return this.engineVersion && compareVersions(String(this.engineVersion), String(version)) >= 0;
+        return !!this.engineVersion && compareVersions(String(this.engineVersion), String(version)) >= 0;
     }
     primaryNumber() {
         const line = this.primaryLine();

package/esm/domain/__tests__/Agent.test.js

@@ -26,14 +26,12 @@ Object.keys(fieldMap).forEach((field) => {
 });
 describe('Call Center Agent domain', () => {
     it('should keep its values', () => {
-        // @ts-expect-error
         const agent = new Agent(formatted);
         expect(agent).toBeInstanceOf(Agent);
         Object.keys(fieldMap).map(key => expect(agent[key]).toBe(formatted[key]));
     });
     it('can parse a plain call center agent to domain', () => {
         const agent = Agent.parse(plain);
-        // @ts-expect-error
         expect(agent).toEqual(new Agent(formatted));
     });
 });

package/esm/domain/__tests__/Call.test.js

@@ -1,4 +1,3 @@
-// @ts-nocheck
 import Call from '../Call';
 describe('Call domain', () => {
     it('can return the elapsed time since its creation in seconds', () => {

package/esm/domain/__tests__/CallLog.test.js

@@ -1,4 +1,3 @@
-// @ts-nocheck
 import moment from 'moment';
 import CallLog from '../CallLog';
 import Recording from '../Recording';

package/esm/domain/__tests__/CallSession.test.js

@@ -1,6 +1,5 @@
-// @ts-nocheck
 import CallSession from '../CallSession';
-const stringify = cs => JSON.parse(JSON.stringify(cs));
+const stringify = (cs) => JSON.parse(JSON.stringify(cs));
 describe('CallSession domain', () => {
     it('should update from another CallSession without data loss', () => {
         const callSession = new CallSession({

package/esm/domain/__tests__/Contact.test.js

@@ -303,13 +303,11 @@ describe('Contact domain', () => {
         const noBirthdayContact = new Contact({
             uuid: 'uuid-12345',
             lastActivity: 'yesterday',
-            // @ts-expect-error
-            birthday: null,
+            birthday: undefined,
         });
         const noLastActivityContact = new Contact({
             uuid: 'uuid-12345',
-            // @ts-expect-error
-            lastActivity: null,
+            lastActivity: undefined,
             birthday: 'tomorrow',
         });
         const result = noBirthdayContact.merge(noLastActivityContact);

package/esm/domain/__tests__/IndirectTransfer.test.js

@@ -1,4 +1,3 @@
-// @ts-nocheck
 import CallSession from '../CallSession';
 import IndirectTransfer from '../IndirectTransfer';
 describe('Indirect transfer', () => {

package/esm/domain/__tests__/Profile.test.js

@@ -1,4 +1,3 @@
-// @ts-nocheck
 import Profile from '../Profile';
 import Line from '../Line';
 import ForwardOption, { FORWARD_KEYS } from '../ForwardOption';