@wazo/sdk 0.39.14 → 0.40.0

package/esm/websocket-client.js

@@ -197,10 +197,9 @@ class WebSocketClient extends Emitter {
                 default:
             }
         };
-        this.socket.onerror = event => {
+        this.socket.onerror = (event) => {
             logger.info('Wazo WS error', {
                 message: event.message,
-                // @ts-ignore
                 code: event.code,
                 readyState: event.target.readyState,
             });

package/index.js

@@ -0,0 +1 @@
+module.exports = require('./lib/index');

package/lib/__tests__/api-client.test.js

@@ -88,7 +88,6 @@ client.setToken(token);
 describe('With correct API results', () => {
     beforeEach(() => {
         jest.resetModules();
-        // @ts-expect-error
         global.fetch = jest.fn(() => Promise.resolve(mockedJson));
     });
     describe('logIn test', () => {
@@ -101,13 +100,11 @@ describe('With correct API results', () => {
                 Authorization: `Basic ${js_base64_1.Base64.encode(`${username}:${password}`)}`,
                 'Content-Type': 'application/json',
             };
-            // @ts-expect-error
             const result = yield client.auth.logIn({
                 username,
                 password,
             });
             expect(result).toBeInstanceOf(Session_1.default);
-            // @ts-expect-error
             expect(result.token).toBe(1);
             expect(global.fetch).toBeCalledWith(`https://${server}/api/auth/${authVersion}/token`, {
                 method: 'post',
@@ -121,7 +118,6 @@ describe('With correct API results', () => {
     describe('logOut test', () => {
         it('should delete the specified token', () => __awaiter(void 0, void 0, void 0, function* () {
             const oldToken = 123;
-            // @ts-expect-error
             yield client.auth.logOut(oldToken);
             expect(global.fetch).toBeCalledWith(`https://${server}/api/auth/${authVersion}/token/${oldToken}`, {
                 method: 'delete',
@@ -136,7 +132,6 @@ describe('With correct API results', () => {
 describe('With unAuthorized API results', () => {
     beforeEach(() => {
         jest.resetModules();
-        // @ts-expect-error
         global.fetch = jest.fn(() => Promise.resolve(mockedUnAuthorized));
     });
     describe('checkLogin test', () => {
@@ -157,7 +152,6 @@ describe('With unAuthorized API results', () => {
 describe('With not found API results', () => {
     beforeEach(() => {
         jest.resetModules();
-        // @ts-expect-error
         global.fetch = jest.fn(() => Promise.resolve(mockedNotFound));
     });
     describe('fetchVoicemail test', () => {
@@ -190,13 +184,11 @@ describe('With not found API results', () => {
 describe('With erroneous text API results', () => {
     beforeEach(() => {
         jest.resetModules();
-        // @ts-expect-error
         global.fetch = jest.fn(() => Promise.resolve(mockedTextError));
     });
     it('throw an exception when the response is >= 500', () => __awaiter(void 0, void 0, void 0, function* () {
         let error = null;
         try {
-            // @ts-expect-error
             yield client.auth.logIn({
                 username,
                 password,
@@ -214,13 +206,11 @@ describe('With erroneous text API results', () => {
 describe('With erroneous json API results', () => {
     beforeEach(() => {
         jest.resetModules();
-        // @ts-expect-error
         global.fetch = jest.fn(() => Promise.resolve(mockedJsonError));
     });
     it('throw an exception when the response is >= 500', () => __awaiter(void 0, void 0, void 0, function* () {
         let error = null;
         try {
-            // @ts-expect-error
             yield client.auth.logIn({
                 username,
                 password,

package/lib/__tests__/web-rtc-client.test.js

@@ -20,18 +20,15 @@ jest.mock('sip.js/lib/api/user-agent', () => {
         start: () => { },
         UserAgent: (_a = class UserAgent {
                 constructor() {
-                    // @ts-ignore
                     this.start = () => { };
                     this.transport = {};
                 }
             },
-            // @ts-ignore
-            _a.makeURI = () => { },
+            _a.makeURI = () => null,
             _a),
     });
 });
-// @ts-expect-error
-const client = new web_rtc_client_1.default({});
+const client = new web_rtc_client_1.default({}, null, undefined);
 describe('WebRTC client', () => {
     it('should compute muted/unmuted state', () => __awaiter(void 0, void 0, void 0, function* () {
         const mutedSession = {
@@ -80,13 +77,9 @@ describe('WebRTC client', () => {
                 },
             },
         };
-        // @ts-expect-error
         expect(client.isAudioMuted(mutedSession)).toBeTruthy();
-        // @ts-expect-error
         expect(client.isAudioMuted(oldKindMuted)).toBeTruthy();
-        // @ts-expect-error
         expect(client.isAudioMuted(unMutedSession)).toBeFalsy();
-        // @ts-expect-error
         expect(client.isAudioMuted(oldKindUnmuted)).toBeFalsy();
     }));
 });
@@ -146,26 +139,20 @@ describe('changeAudioInputDevice', () => {
         },
     });
     it('should change the audio input track if the provided id is different', () => __awaiter(void 0, void 0, void 0, function* () {
-        // @ts-expect-error
         client.setMediaConstraints(constraints);
         expect(client.getAudioDeviceId()).toBe(defaultId);
-        // @ts-expect-error
         const result = yield client.changeAudioInputDevice(deviceId, session);
         expect(result).toBeTruthy();
     }));
     it('should NOT change the audio input track if the provided id is the same', () => __awaiter(void 0, void 0, void 0, function* () {
-        // @ts-expect-error
         client.setMediaConstraints(constraints);
         expect(client.getAudioDeviceId()).toBe(defaultId);
-        // @ts-expect-error
         const result = yield client.changeAudioInputDevice(defaultId, session);
         expect(result).toBeFalsy();
     }));
     it('should change the audio input track if the provided id is the same and force param is TRUE', () => __awaiter(void 0, void 0, void 0, function* () {
-        // @ts-expect-error
         client.setMediaConstraints(constraints);
         expect(client.getAudioDeviceId()).toBe(defaultId);
-        // @ts-expect-error
         const result = yield client.changeAudioInputDevice(defaultId, session, true);
         expect(result).toBeTruthy();
     }));

package/lib/api/amid.js

@@ -12,9 +12,17 @@ Object.defineProperty(exports, "__esModule", { value: true });
 exports.default = ((client, baseUrl) => ({
     action: (action, args = {}) => client.post(`${baseUrl}/action/${action}`, args),
     getAors: (endpoint) => __awaiter(void 0, void 0, void 0, function* () {
-        const rawEvents = (yield client.post(`${baseUrl}/action/PJSIPShowEndpoint`, {
-            Endpoint: endpoint,
-        })) || [];
-        return rawEvents.filter((event) => event.Event === 'ContactStatusDetail');
+        try {
+            const rawEvents = (yield client.post(`${baseUrl}/action/PJSIPShowEndpoint`, {
+                Endpoint: endpoint,
+            })) || [];
+            if (!rawEvents) {
+                return [];
+            }
+            return rawEvents.filter((event) => event.Event === 'ContactStatusDetail');
+        }
+        catch (_a) {
+            return [];
+        }
     }),
 }));

package/lib/api/chatd.js

@@ -39,7 +39,6 @@ exports.default = ((client, baseUrl) => ({
             if (uuids.length > MAX_PRESENCE_FETCHED) {
                 const requests = uuids.reduce((acc, _, i) => {
                     if (i % MAX_PRESENCE_FETCHED === 0) {
-                        // @ts-ignore
                         acc.push(this.getMultipleLineState(uuids.slice(i, i + MAX_PRESENCE_FETCHED)));
                     }
                     return acc;

package/lib/api/dird.js

@@ -5,14 +5,11 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
 Object.defineProperty(exports, "__esModule", { value: true });
 const jsonToGraphQLQuery_1 = require("json-to-graphql-query/lib/jsonToGraphQLQuery");
 const api_requester_1 = __importDefault(require("../utils/api-requester"));
-const Contact_1 = __importDefault(require("../domain/Contact"));
+const index_1 = require("../index");
 const getContactPayload = (contact) => ({
     email: contact.email,
-    // @ts-ignore
     firstname: contact.firstName ? contact.firstName : '',
-    // @ts-ignore
     lastname: contact.lastName ? contact.lastName : '',
-    // @ts-ignore
     number: contact.phoneNumber ? contact.phoneNumber : '',
     entreprise: contact.entreprise ? contact.entreprise : '',
     birthday: contact.birthday ? contact.birthday : '',
@@ -22,20 +19,20 @@ const getContactPayload = (contact) => ({
 exports.default = ((client, baseUrl) => ({
     search: (context, term, offset = 0, limit = null) => client.get(`${baseUrl}/directories/lookup/${context}`, {
         term,
-    }).then((response) => Contact_1.default.parseMany(response, offset, limit)),
-    listPersonalContacts: (queryParams = null) => client.get(`${baseUrl}/personal`, queryParams).then((response) => Contact_1.default.parseManyPersonal(response.items)),
-    fetchPersonalContact: (contactUuid) => client.get(`${baseUrl}/personal/${contactUuid}`).then(Contact_1.default.parsePersonal),
-    addContact: (contact) => client.post(`${baseUrl}/personal`, getContactPayload(contact)).then(Contact_1.default.parsePersonal),
-    editContact: (contact) => client.put(`${baseUrl}/personal/${contact.sourceId || contact.id || ''}`, getContactPayload(contact)).then(Contact_1.default.parsePersonal),
+    }).then((response) => index_1.Contact.parseMany(response, offset, limit)),
+    listPersonalContacts: (queryParams = null) => client.get(`${baseUrl}/personal`, queryParams).then((response) => index_1.Contact.parseManyPersonal(response.items)),
+    fetchPersonalContact: (contactUuid) => client.get(`${baseUrl}/personal/${contactUuid}`).then(index_1.Contact.parsePersonal),
+    addContact: (contact) => client.post(`${baseUrl}/personal`, getContactPayload(contact)).then(index_1.Contact.parsePersonal),
+    editContact: (contact) => client.put(`${baseUrl}/personal/${contact.sourceId || contact.id || ''}`, getContactPayload(contact)).then(index_1.Contact.parsePersonal),
     importContacts: (csv) => {
         const headers = {
             'Content-Type': 'text/csv; charset=utf-8',
             'X-Auth-Token': client.token,
         };
-        return client.post(`${baseUrl}/personal/import`, csv, headers).then((result) => Contact_1.default.parseManyPersonal(result.created));
+        return client.post(`${baseUrl}/personal/import`, csv, headers).then((result) => index_1.Contact.parseManyPersonal(result.created));
     },
     deleteContact: (contactUuid) => client.delete(`${baseUrl}/personal/${contactUuid}`),
-    listFavorites: (context) => client.get(`${baseUrl}/directories/favorites/${context}`).then(Contact_1.default.parseMany),
+    listFavorites: (context) => client.get(`${baseUrl}/directories/favorites/${context}`).then(index_1.Contact.parseMany),
     markAsFavorite: (source, sourceId) => {
         const url = `${baseUrl}/directories/favorites/${source}/${sourceId}`;
         return client.put(url, null, null, api_requester_1.default.successResponseParser);
@@ -46,9 +43,9 @@ exports.default = ((client, baseUrl) => ({
     }),
     fetchOffice365Contacts: (source, queryParams = null) => {
         if (!source) {
-            return null;
+            return Promise.resolve([]);
         }
-        return client.get(`${baseUrl}/backends/office365/sources/${source.uuid}/contacts`, queryParams).then((response) => Contact_1.default.parseManyOffice365(response.items, source));
+        return client.get(`${baseUrl}/backends/office365/sources/${source.uuid}/contacts`, queryParams).then((response) => index_1.Contact.parseManyOffice365(response.items, source));
     },
     fetchWazoSource: (context) => client.get(`${baseUrl}/directories/${context}/sources`, {
         backend: 'wazo',
@@ -56,34 +53,34 @@ exports.default = ((client, baseUrl) => ({
     // Can be used with `queryParams = { uuid: uuid1, uuid2 }` to fetch multiple contacts
     fetchWazoContacts: (source, queryParams = null) => {
         if (!source) {
-            return null;
+            return Promise.resolve([]);
         }
-        return client.get(`${baseUrl}/backends/wazo/sources/${source.uuid}/contacts`, queryParams).then((response) => Contact_1.default.parseManyWazo(response.items, source));
+        return client.get(`${baseUrl}/backends/wazo/sources/${source.uuid}/contacts`, queryParams).then((response) => index_1.Contact.parseManyWazo(response.items, source));
     },
     fetchGoogleSource: (context) => client.get(`${baseUrl}/directories/${context}/sources`, {
         backend: 'google',
     }),
     fetchGoogleContacts: (source, queryParams = null) => {
         if (!source) {
-            return null;
+            return Promise.resolve([]);
         }
-        return client.get(`${baseUrl}/backends/google/sources/${source.uuid}/contacts`, queryParams).then((response) => Contact_1.default.parseManyGoogle(response.items, source));
+        return client.get(`${baseUrl}/backends/google/sources/${source.uuid}/contacts`, queryParams).then((response) => index_1.Contact.parseManyGoogle(response.items, source));
     },
     fetchConferenceSource: (context) => client.get(`${baseUrl}/directories/${context}/sources`, {
         backend: 'conference',
     }),
     fetchSourcesFor: (context, backend) => client.get(`${baseUrl}/directories/${context}/sources`, { backend }),
-    fetchPhonebookContacts: (source, params = null) => {
+    fetchPhonebookContacts: (source, params) => {
         if (!source) {
-            return null;
+            return Promise.resolve({ items: [], total: 0 });
         }
         return client.get(`${baseUrl}/backends/phonebook/sources/${source.uuid}/contacts`, params);
     },
     fetchConferenceContacts: (source) => {
         if (!source) {
-            return null;
+            return Promise.resolve([]);
         }
-        return client.get(`${baseUrl}/backends/conference/sources/${source.uuid}/contacts`).then((response) => Contact_1.default.parseManyConference(response.items, source));
+        return client.get(`${baseUrl}/backends/conference/sources/${source.uuid}/contacts`).then((response) => index_1.Contact.parseManyConference(response.items, source));
     },
     // Graphql
     findMultipleContactsByNumber: (numbers, fields) => {
@@ -113,6 +110,6 @@ exports.default = ((client, baseUrl) => ({
         });
         return client.post(`${baseUrl}/graphql`, {
             query: `{${query}}`,
-        }).then(Contact_1.default.manyGraphQlWithNumbersParser(numbers));
+        }).then(index_1.Contact.manyGraphQlWithNumbersParser(numbers));
     },
 }));

package/lib/checker/checks/ice-ipv4.js

@@ -39,7 +39,7 @@ exports.default = {
             }))), config.iceServers);
         }
         if (externalAppConfig && externalAppConfig.turn_servers) {
-            config.iceServers = [...JSON.parse(externalAppConfig.turn_servers), ...config.iceServers];
+            config.iceServers = [...JSON.parse(externalAppConfig.turn_servers), ...(config.iceServers || [])];
             // Force to use TURN when defined in config
             config.iceTransportPolicy = 'relay';
         }
@@ -59,8 +59,7 @@ exports.default = {
                     return reject(new Error('No `srflx` or `relay` found in candidate. Please consider using a TURN server.'));
                 }
                 if (ips.every(checkIsIPV4)) {
-                    // @ts-ignore
-                    resolve();
+                    resolve(null);
                 }
                 else {
                     const nonIPV4 = ips.find(ip => !checkIsIPV4(ip));

package/lib/checker/checks/symmetric-nat.js

@@ -38,16 +38,19 @@ exports.default = {
         };
         timeout = setTimeout(onEnded, timeoutDuration);
         pc.createDataChannel('wazo-check-nat');
-        pc.onicecandidate = e => {
+        pc.onicecandidate = (e) => {
             nbCandidates++;
             if (e.candidate) {
                 rawCandidates.push(e.candidate.candidate);
             }
             if (e.candidate && e.candidate.candidate.indexOf('srflx') !== -1) {
                 const cand = (0, webrtc_1.parseCandidate)(e.candidate.candidate);
-                if (!candidates[cand.relatedPort])
-                    candidates[cand.relatedPort] = [];
-                candidates[cand.relatedPort].push(cand.port);
+                if (cand.relatedPort) {
+                    if (!candidates[cand.relatedPort]) {
+                        candidates[cand.relatedPort] = [];
+                    }
+                    candidates[cand.relatedPort].push(cand.port);
+                }
             }
             else if (!e.candidate) {
                 onEnded();

package/lib/domain/AdHocAPIConference.js

@@ -31,7 +31,7 @@ class AdHocAPIConference {
     start() {
         return __awaiter(this, void 0, void 0, function* () {
             this.started = true;
-            // @ts-ignore
+            // @ts-ignore: date / number
             this.answerTime = Object.values(this.participants).length ? Object.values(this.participants)[0].answerTime : null;
             const participantIds = Object.keys(this.participants);
             const conference = yield (0, getApiClient_1.default)().calld.createAdHocConference(this.host.callId, participantIds);

package/lib/domain/CallLog.js

@@ -47,7 +47,7 @@ class CallLog {
     static parseNew(plain, session) {
         const callLog = CallLog.parse(plain);
         // @TODO: FIXME add verification declined vs missed call
-        callLog.newMissedCall = session && session.hasExtension(plain.requested_extension || plain.destination_extension) && !plain.answered;
+        callLog.newMissedCall = session && session.hasExtension((plain.requested_extension || plain.destination_extension)) && !plain.answered;
         return callLog;
     }
     static newFrom(profile) {

package/lib/domain/Contact.js

@@ -380,7 +380,7 @@ class Contact {
     }
     merge(old) {
         Object.keys(old).filter(key => key !== 'lineState').forEach(key => {
-            // @ts-ignore
+            // @ts-ignore: keys
             this[key] = old[key] || this[key];
         });
         if (old.lineState) {
@@ -419,4 +419,5 @@ class Contact {
         };
     }
 }
+Contact.BACKEND = exports.BACKEND;
 exports.default = Contact;

package/lib/domain/MeetingAuthorization.js

@@ -36,4 +36,10 @@ class MeetingAuthorization {
         return items.map(MeetingAuthorization.parse);
     }
 }
+MeetingAuthorization.PENDING = exports.PENDING;
+MeetingAuthorization.ACCEPTED = exports.ACCEPTED;
+MeetingAuthorization.REJECTED = exports.REJECTED;
+MeetingAuthorization.POST_PROCESSING = exports.POST_PROCESSING;
+MeetingAuthorization.POST_PROCESSED_SUCCESS = exports.POST_PROCESSED_SUCCESS;
+MeetingAuthorization.POST_PROCESSED_ERROR = exports.POST_PROCESSED_ERROR;
 exports.default = MeetingAuthorization;

package/lib/domain/Phone/CTIPhone.js

@@ -24,6 +24,7 @@ const logger = IssueReporter_1.default ? IssueReporter_1.default.loggerFor('cti-
 class CTIPhone extends Emitter_1.default {
     constructor(session, isMobile = false, callbackAllLines = false) {
         super();
+        this.client = null;
         logger.info('CTI Phone created');
         this.session = session;
         this.isMobile = isMobile;
@@ -318,5 +319,6 @@ class CTIPhone extends Emitter_1.default {
     }
     useLocalVideoElement() { }
     setMediaConstraints() { }
+    register() { return Promise.resolve(null); }
 }
 exports.default = CTIPhone;

package/lib/domain/Phone/WebRTCPhone.js

@@ -245,7 +245,6 @@ class WebRTCPhone extends Emitter_1.default {
             const shouldScreenShare = constraints && !!constraints.screen;
             const desktop = constraints && constraints.desktop;
             const options = sipSession.sessionDescriptionHandlerOptionsReInvite;
-            // @ts-ignore
             const wasAudioOnly = options === null || options === void 0 ? void 0 : options.audioOnly;
             const newStream = yield this.client.upgradeToVideo(sipSession, constraints, isConference);
             if (callSession) {
@@ -343,9 +342,12 @@ class WebRTCPhone extends Emitter_1.default {
             return;
         }
         // Video events
-        const { 
-        // @ts-ignore
-        peerConnection, } = sipSession.sessionDescriptionHandler;
+        const sdh = sipSession.sessionDescriptionHandler;
+        const peerConnection = sdh.peerConnection;
+        if (!peerConnection) {
+            logger.info('null peer connection');
+            return;
+        }
         peerConnection.ontrack = (rawEvent) => {
             const event = rawEvent;
             const [stream] = event.streams;
@@ -484,6 +486,13 @@ class WebRTCPhone extends Emitter_1.default {
             cameraEnabled,
         });
         const callSession = this._createAcceptedCallSession(sipSession, cameraEnabled);
+        if (this.currentSipSession && !this.isCurrentCallSipSession(callSession)) {
+            logger.info('WebRTC phone - on call accepted with another ongoing call, holding it', {
+                sipId: sipSession.id,
+                cameraEnabled,
+            });
+            this.holdSipSession(this.currentSipSession, this.currentCallSession, true);
+        }
         this.currentSipSession = sipSession;
         this.currentCallSession = callSession;
         this.eventEmitter.emit(exports.ON_TERMINATE_SOUND, callSession, 'call accepted');
@@ -602,7 +611,7 @@ class WebRTCPhone extends Emitter_1.default {
         if (callSession.getId() in this.ignoredSessions) {
             return false;
         }
-        // @ts-ignore
+        // @ts-ignore: does not exist
         if (!sipSession.isCanceled) {
             setTimeout(() => {
                 this.eventEmitter.emit(exports.ON_PLAY_HANGUP_SOUND, this.audioOutputDeviceId, this.audioOutputVolume, callSession);
@@ -628,9 +637,8 @@ class WebRTCPhone extends Emitter_1.default {
         if (!sipSession) {
             return false;
         }
-        const { 
-        // @ts-ignore
-        peerConnection, } = sipSession.sessionDescriptionHandler;
+        const sdh = sipSession.sessionDescriptionHandler;
+        const peerConnection = sdh.peerConnection;
         const remoteStream = peerConnection.getRemoteStreams().find((stream) => !!stream.getVideoTracks().length);
         return remoteStream && remoteStream.getVideoTracks().some(track => !track.muted);
     }
@@ -999,9 +1007,9 @@ class WebRTCPhone extends Emitter_1.default {
             this.currentCallSession = callSession;
             this.eventEmitter.emit(exports.ON_CALL_OUTGOING, callSession);
             // If an invite promise exists, catch exceptions on it to trigger error like OverConstraintsError.
-            // @ts-ignore
+            // @ts-ignore: does not exist
             if (sipSession.invitePromise) {
-                // @ts-ignore
+                // @ts-ignore: does not exist
                 sipSession.invitePromise.catch(error => {
                     this.eventEmitter.emit(exports.ON_CALL_ERROR, error, callSession);
                 });
@@ -1088,12 +1096,12 @@ class WebRTCPhone extends Emitter_1.default {
         return sipSession ? this.client.stopNetworkMonitoring(sipSession) : null;
     }
     forceCancel(sipSession) {
-        // @ts-ignore
+        // @ts-ignore: private
         if (!sipSession || !sipSession.outgoingInviteRequest) {
             return;
         }
         try {
-            // @ts-ignore
+            // @ts-ignore: private
             sipSession.outgoingInviteRequest.cancel();
         }
         catch (e) {
@@ -1310,7 +1318,6 @@ class WebRTCPhone extends Emitter_1.default {
             // send a reinvite to renegociate ICE with new IP
             if (this.shouldSendReinvite && this.currentSipSession && this.currentSipSession.state === session_state_1.SessionState.Established) {
                 this.shouldSendReinvite = false;
-                // @ts-ignore
                 const pc = (_b = (_a = this.currentSipSession) === null || _a === void 0 ? void 0 : _a.sessionDescriptionHandler) === null || _b === void 0 ? void 0 : _b.peerConnection;
                 const isConference = pc ? pc.sfu : false;
                 const hasVideo = this.currentCallSession && this.currentCallSession.cameraEnabled;
@@ -1393,14 +1400,12 @@ class WebRTCPhone extends Emitter_1.default {
         }
     }
     _onMessage(message) {
-        // @ts-ignore
         if (!message || message.method !== 'MESSAGE') {
             return;
         }
         let body;
         try {
-            // @ts-ignore
-            body = JSON.parse(message.body);
+            body = JSON.parse(message.body || '');
         }
         catch (e) {
             return;
@@ -1461,13 +1466,13 @@ class WebRTCPhone extends Emitter_1.default {
     _createCallSession(sipSession, fromSession, extra = {}) {
         // eslint-disable-next-line
         const identity = sipSession ? sipSession.remoteIdentity || sipSession.assertedIdentity : null;
-        // @ts-ignore
+        // @ts-ignore: private
         const number = identity ? identity.uri._normal.user : null;
         const { state, } = sipSession || {};
         const sessionId = this.getSipSessionId(sipSession);
         fromSession = fromSession || this.callSessions[sessionId];
         const callSession = new CallSession_1.default(Object.assign({ callId: fromSession && fromSession.callId, sipCallId: sessionId, sipStatus: state, displayName: identity ? identity.displayName || number : number, 
-            // @ts-ignore: @HEADSUP: startTime should be a number, not a date
+            // @ts-ignore: date / number
             startTime: fromSession ? fromSession.startTime : new Date(), creationTime: fromSession ? fromSession.creationTime : null, answerTime: fromSession ? fromSession.answerTime : null, endTime: fromSession ? fromSession.endTime : null, answered: state === session_state_1.SessionState.Established, paused: this.client.isCallHeld(sipSession), isCaller: fromSession ? fromSession.isCaller : 'incoming' in extra ? !extra.incoming : false, cameraEnabled: fromSession ? fromSession.isCameraEnabled() : this.client.hasVideo(sessionId), number, ringing: false, muted: fromSession ? fromSession.isMuted() : this.client.isAudioMuted(sipSession), videoMuted: fromSession ? fromSession.isVideoMuted() : false, recording: fromSession ? fromSession.isRecording() : false, recordingPaused: false, sipSession, conference: !!fromSession && fromSession.isConference() }, extra));
         this.callSessions[sessionId] = callSession;
         return callSession;

package/lib/domain/Session.js

@@ -21,7 +21,7 @@ class Session {
         if (token) {
             const isValid = jws.JWS.verifyJWT(token, swarmKey, {
                 alg: ['RS256'],
-                // @ts-ignore
+                // @ts-ignore: date / number
                 verifyAt: new Date(),
             });
             if (isValid) {
@@ -126,7 +126,7 @@ class Session {
         return line && Array.isArray(line.extensions) && line.extensions.length > 0 ? line.extensions[0].context : 'default';
     }
     hasEngineVersionGte(version) {
-        return this.engineVersion && (0, compare_version_1.default)(String(this.engineVersion), String(version)) >= 0;
+        return !!this.engineVersion && (0, compare_version_1.default)(String(this.engineVersion), String(version)) >= 0;
     }
     primaryNumber() {
         const line = this.primaryLine();

package/lib/domain/__tests__/Agent.test.js

@@ -31,14 +31,12 @@ Object.keys(fieldMap).forEach((field) => {
 });
 describe('Call Center Agent domain', () => {
     it('should keep its values', () => {
-        // @ts-expect-error
         const agent = new Agent_1.default(formatted);
         expect(agent).toBeInstanceOf(Agent_1.default);
         Object.keys(fieldMap).map(key => expect(agent[key]).toBe(formatted[key]));
     });
     it('can parse a plain call center agent to domain', () => {
         const agent = Agent_1.default.parse(plain);
-        // @ts-expect-error
         expect(agent).toEqual(new Agent_1.default(formatted));
     });
 });

package/lib/domain/__tests__/Call.test.js

@@ -3,7 +3,6 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-// @ts-nocheck
 const Call_1 = __importDefault(require("../Call"));
 describe('Call domain', () => {
     it('can return the elapsed time since its creation in seconds', () => {

package/lib/domain/__tests__/CallLog.test.js

@@ -1,5 +1,4 @@
 "use strict";
-// @ts-nocheck
 var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };

package/lib/domain/__tests__/CallSession.test.js

@@ -3,9 +3,8 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-// @ts-nocheck
 const CallSession_1 = __importDefault(require("../CallSession"));
-const stringify = cs => JSON.parse(JSON.stringify(cs));
+const stringify = (cs) => JSON.parse(JSON.stringify(cs));
 describe('CallSession domain', () => {
     it('should update from another CallSession without data loss', () => {
         const callSession = new CallSession_1.default({

package/lib/domain/__tests__/Contact.test.js

@@ -305,13 +305,11 @@ describe('Contact domain', () => {
         const noBirthdayContact = new Contact_1.default({
             uuid: 'uuid-12345',
             lastActivity: 'yesterday',
-            // @ts-expect-error
-            birthday: null,
+            birthday: undefined,
         });
         const noLastActivityContact = new Contact_1.default({
             uuid: 'uuid-12345',
-            // @ts-expect-error
-            lastActivity: null,
+            lastActivity: undefined,
             birthday: 'tomorrow',
         });
         const result = noBirthdayContact.merge(noLastActivityContact);

package/lib/domain/__tests__/IndirectTransfer.test.js

@@ -12,7 +12,6 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-// @ts-nocheck
 const CallSession_1 = __importDefault(require("../CallSession"));
 const IndirectTransfer_1 = __importDefault(require("../IndirectTransfer"));
 describe('Indirect transfer', () => {

package/lib/domain/__tests__/Profile.test.js

@@ -26,7 +26,6 @@ var __importDefault = (this && this.__importDefault) || function (mod) {
     return (mod && mod.__esModule) ? mod : { "default": mod };
 };
 Object.defineProperty(exports, "__esModule", { value: true });
-// @ts-nocheck
 const Profile_1 = __importDefault(require("../Profile"));
 const Line_1 = __importDefault(require("../Line"));
 const ForwardOption_1 = __importStar(require("../ForwardOption"));