@wazo/sdk 0.39.14 → 0.40.0

package/src/domain/Session.ts

@@ -108,7 +108,7 @@ export default class Session {
     if (token) {
       const isValid = jws.JWS.verifyJWT(token, swarmKey, {
         alg: ['RS256'],
-        // @ts-ignore
+        // @ts-ignore: date / number
         verifyAt: new Date(),
       });
 
@@ -247,8 +247,8 @@ export default class Session {
     return line && Array.isArray(line.extensions) && line.extensions.length > 0 ? line.extensions[0].context : 'default';
   }
 
-  hasEngineVersionGte(version: string) {
-    return this.engineVersion && compareVersions(String(this.engineVersion), String(version)) >= 0;
+  hasEngineVersionGte(version: string): boolean {
+    return !!this.engineVersion && compareVersions(String(this.engineVersion), String(version)) >= 0;
   }
 
   primaryNumber(): string | null | undefined {

package/src/domain/SipLine.ts

@@ -3,7 +3,7 @@ import type { Endpoint } from './Line';
 
 const availableCodecs = ['vp8', 'vp9', 'h264'];
 type SipLineResponse = {
-  id: number;
+  id: string;
   uuid: string;
   tenant_uuid: string;
   username: string;
@@ -18,7 +18,7 @@ type SipLineResponse = {
   line: Endpoint;
 };
 type SipLineArguments = {
-  id: number;
+  id: string;
   uuid: string;
   tenantUuid: string;
   username: string;
@@ -32,7 +32,7 @@ type SipLineArguments = {
   line: Endpoint;
 };
 export default class SipLine {
-  id: any;
+  id: string;
 
   uuid: string;
 

package/src/domain/__tests__/Agent.test.ts

@@ -1,4 +1,4 @@
-import Agent, { AgentResponse } from '../Agent';
+import Agent, { AgentArguments, AgentResponse } from '../Agent';
 
 const fieldMap: Record<string, any> = {
   context: 'context',
@@ -27,14 +27,12 @@ Object.keys(fieldMap).forEach((field: string) => {
 });
 describe('Call Center Agent domain', () => {
   it('should keep its values', () => {
-    // @ts-expect-error
-    const agent = new Agent(formatted) as any;
+    const agent = new Agent(formatted as AgentArguments) as any;
     expect(agent).toBeInstanceOf(Agent);
     Object.keys(fieldMap).map(key => expect(agent[key]).toBe(formatted[key]));
   });
   it('can parse a plain call center agent to domain', () => {
     const agent = Agent.parse(plain as AgentResponse);
-    // @ts-expect-error
-    expect(agent).toEqual(new Agent(formatted));
+    expect(agent).toEqual(new Agent(formatted as AgentArguments));
   });
 });

package/src/domain/__tests__/Call.test.ts

@@ -1,12 +1,11 @@
-// @ts-nocheck
 import Call from '../Call';
 
 describe('Call domain', () => {
   it('can return the elapsed time since its creation in seconds', () => {
-    Date.now = jest.fn(() => new Date(2012, 7, 28, 13, 0, 0));
+    Date.now = jest.fn(() => new Date(2012, 7, 28, 13, 0, 0)) as any;
     const call = new Call({
       startingTime: new Date(2012, 7, 28, 12, 30, 0),
-    });
+    } as any);
     const elapsedTimeInSeconds = call.getElapsedTimeInSeconds();
     expect(elapsedTimeInSeconds).toBe(30 * 60);
   });
@@ -14,14 +13,14 @@ describe('Call domain', () => {
     const call = new Call({
       calleeName: 'John Doe',
       calleeNumber: '911',
-    });
+    } as any);
     expect(call.hasNumber('911')).toBeTruthy();
   });
   it('does not have the number provided it is a different number', () => {
     const call = new Call({
       calleeName: 'John Doe',
       calleeNumber: '911',
-    });
+    } as any);
     expect(call.hasNumber('418-222-5555')).toBeFalsy();
   });
 });

package/src/domain/__tests__/CallLog.test.ts

@@ -1,5 +1,3 @@
-// @ts-nocheck
-
 import moment from 'moment';
 import CallLog from '../CallLog';
 import Recording from '../Recording';
@@ -34,7 +32,7 @@ describe('CallLog domain', () => {
       }],
       total: 233,
     };
-    const logs = CallLog.parseMany(response);
+    const logs = CallLog.parseMany(response as any);
     expect(logs).toEqual([new CallLog({
       answer: moment('2017-08-07T13:51:18.892002+00:00').toDate(),
       answered: true,

package/src/domain/__tests__/CallSession.test.ts

@@ -1,7 +1,6 @@
-// @ts-nocheck
 import CallSession from '../CallSession';
 
-const stringify = cs => JSON.parse(JSON.stringify(cs));
+const stringify = (cs: any) => JSON.parse(JSON.stringify(cs));
 
 describe('CallSession domain', () => {
   it('should update from another CallSession without data loss', () => {
@@ -12,14 +11,14 @@ describe('CallSession domain', () => {
       number: '8001',
       isCaller: true,
       dialedExtension: null,
-    });
+    } as any);
     const anotherCallSession = new CallSession({
       callId: 345,
       callerNumber: '8008',
       number: '8008',
       isCaller: false,
       dialedExtension: undefined,
-    });
+    } as any);
     callSession.updateFrom(anotherCallSession);
     expect(callSession.callId).toBe(345);
     expect(callSession.sipCallId).toBe(123);
@@ -34,22 +33,22 @@ describe('CallSession domain', () => {
     const cs1 = new CallSession({
       callId: 123,
       sipCallId: 456,
-    });
+    } as any);
     const cs2 = new CallSession({
       callId: 123,
       sipCallId: null,
-    });
+    } as any);
     expect(cs1.is(cs2)).toBeTruthy();
     expect(cs2.is(cs1)).toBeTruthy();
   });
   it('should set answerTime when setting answered to true', () => {
-    const cs1 = new CallSession({});
+    const cs1 = new CallSession({} as any);
     cs1.answered = true;
-    const cs2 = new CallSession({});
+    const cs2 = new CallSession({} as any);
     cs2.answer();
     const cs3 = new CallSession({
       answered: true,
-    });
+    } as any);
     expect(cs1.answered).toEqual(true);
     expect(cs1.answerTime).not.toBeNull();
     expect(cs2.answered).toEqual(true);
@@ -64,11 +63,11 @@ describe('CallSession domain', () => {
     expect(cs6.answered).toEqual(true);
   });
   it('should reset answerTime when setting answered to false', () => {
-    const cs1 = new CallSession({});
+    const cs1 = new CallSession({} as any);
     cs1.answered = false;
     const cs2 = new CallSession({
       answered: false,
-    });
+    } as any);
     expect(cs1.answered).toEqual(false);
     expect(cs1.answerTime).toBeNull();
     expect(cs2.answered).toEqual(false);

package/src/domain/__tests__/Contact.test.ts

@@ -309,13 +309,11 @@ describe('Contact domain', () => {
     const noBirthdayContact = new Contact({
       uuid: 'uuid-12345',
       lastActivity: 'yesterday',
-      // @ts-expect-error
-      birthday: null,
+      birthday: undefined,
     });
     const noLastActivityContact = new Contact({
       uuid: 'uuid-12345',
-      // @ts-expect-error
-      lastActivity: null,
+      lastActivity: undefined,
       birthday: 'tomorrow',
     });
     const result = noBirthdayContact.merge(noLastActivityContact);

package/src/domain/__tests__/IndirectTransfer.test.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck
 import CallSession from '../CallSession';
 import IndirectTransfer from '../IndirectTransfer';
 
@@ -9,9 +8,9 @@ describe('Indirect transfer', () => {
       const destinationId = 'destination-id';
       const indirectTransfer = IndirectTransfer.parseFromCallSession(new CallSession({
         callId: sourceId,
-      }), new CallSession({
+      } as any), new CallSession({
         callId: destinationId,
-      }));
+      } as any));
       expect(indirectTransfer).toEqual({
         sourceId,
         destinationId,
@@ -27,7 +26,7 @@ describe('Indirect transfer', () => {
       });
       const isDestination = indirectTransfer.destinationIs(new CallSession({
         callId: destinationId,
-      }));
+      } as any));
       expect(isDestination).toBeTruthy();
     });
     it('should NOT match when destination is the different', async () => {
@@ -38,7 +37,7 @@ describe('Indirect transfer', () => {
       });
       const isDestination = indirectTransfer.destinationIs(new CallSession({
         callId: destinationId,
-      }));
+      } as any));
       expect(isDestination).toBeFalsy();
     });
   });
@@ -51,7 +50,7 @@ describe('Indirect transfer', () => {
       });
       const isSource = indirectTransfer.sourceIs(new CallSession({
         callId: sourceId,
-      }));
+      } as any));
       expect(isSource).toBeTruthy();
     });
     it('should NOT match when source is the different', async () => {
@@ -62,7 +61,7 @@ describe('Indirect transfer', () => {
       });
       const isSource = indirectTransfer.sourceIs(new CallSession({
         callId: sourceId,
-      }));
+      } as any));
       expect(isSource).toBeFalsy();
     });
   });

package/src/domain/__tests__/Profile.test.ts

@@ -1,4 +1,3 @@
-// @ts-nocheck
 import Profile from '../Profile';
 import Line from '../Line';
 import ForwardOption, { FORWARD_KEYS } from '../ForwardOption';
@@ -18,12 +17,12 @@ describe('Profile domain', () => {
           context: 'default',
         }],
         endpoint_custom: null,
-      })],
+      } as any)],
       username: 'john.doe',
       forwards: [],
       mobileNumber: '123',
     };
-    const oldProfile = new Profile(attributes);
+    const oldProfile = new Profile(attributes as any);
     const newProfile = Profile.newFrom(oldProfile);
     expect(newProfile).toBeInstanceOf(Profile);
     expect(newProfile.firstName).toBe(attributes.firstName);
@@ -88,7 +87,7 @@ describe('Profile domain', () => {
       }],
       online_call_record_enabled: true,
     };
-    const profile = Profile.parse(plain);
+    const profile = Profile.parse(plain as any);
     expect(profile).toEqual(new Profile({
       id: 'xxx-xxx-xxx-xx',
       firstName: 'John',

package/src/domain/__tests__/Room.test.ts

@@ -8,10 +8,9 @@ describe('Room', () => {
         const number = 'some-number';
         const room = new Room({
           id: 'some-id',
-          // @ts-expect-error
           connectedCallSession: new CallSession({
             number,
-          }),
+          } as any),
           participants: [],
         });
         const extension = room.getExtension();
@@ -32,14 +31,12 @@ describe('Room', () => {
   });
   describe('on connect call', () => {
     it('should add call to room', async () => {
-      // @ts-expect-error
       const room = new Room({
         id: 'some-id',
-      });
-      // @ts-expect-error
+      } as any);
       const callSession = new CallSession({
         callId: 'some-call-id',
-      });
+      } as any);
       const connectedRoom = room.connect(callSession);
       expect(connectedRoom.connectedCallSession).toBe(callSession);
     });
@@ -47,42 +44,35 @@ describe('Room', () => {
   describe('on room has call', () => {
     describe('given no connected call', () => {
       it('should be false', async () => {
-        // @ts-expect-error
         const room = new Room({
           connectedCallSession: null,
-        });
-        // @ts-expect-error
-        const callSession = new CallSession({});
+        } as any);
+        const callSession = new CallSession({} as any);
         const roomHasCall = room.has(callSession);
         expect(roomHasCall).toBeFalsy();
       });
     });
     describe('given a connected call', () => {
       it('should be true if same calls', async () => {
-        // @ts-expect-error
         const callSession = new CallSession({
           callId: 'some-call-id',
-        });
-        // @ts-expect-error
+        } as any);
         const room = new Room({
           connectedCallSession: callSession,
-        });
+        } as any);
         const roomHasCall = room.has(callSession);
         expect(roomHasCall).toBeTruthy();
       });
       it('should be false if different calls', async () => {
-        // @ts-expect-error
         const call1 = new CallSession({
           callId: 'some-call-id',
-        });
-        // @ts-expect-error
+        } as any);
         const call2 = new CallSession({
           callId: 'some-other-call-id',
-        });
-        // @ts-expect-error
+        } as any);
         const room = new Room({
           connectedCallSession: call1,
-        });
+        } as any);
         const roomHasCall = room.has(call2);
         expect(roomHasCall).toBeFalsy();
       });
@@ -93,9 +83,8 @@ describe('Room', () => {
       const participants = [{}];
       const room = new Room({
         connectedCallSession: null,
-        // @ts-expect-error
         participants,
-      });
+      } as any);
       const participantUuid = 'some-uuid';
       const participantExtension = 'some-extension';
       const updatedRoom = room.addParticipant(participantUuid, participantExtension);
@@ -106,10 +95,9 @@ describe('Room', () => {
   describe('on room has call with id', () => {
     describe('given no connected call', () => {
       it('should be false', async () => {
-        // @ts-expect-error
         const room = new Room({
           connectedCallSession: null,
-        });
+        } as any);
         const callId = 'some-call-id';
         const roomHasCall = room.hasCallWithId(callId);
         expect(roomHasCall).toBeFalsy();
@@ -118,25 +106,21 @@ describe('Room', () => {
     describe('given a connected call', () => {
       it('should be true if same calls', async () => {
         const callId = 'some-call-id';
-        // @ts-expect-error
         const room = new Room({
-          // @ts-expect-error
           connectedCallSession: new CallSession({
             callId,
-          }),
-        });
+          } as any),
+        } as any);
         const roomHasCall = room.hasCallWithId(callId);
         expect(roomHasCall).toBeTruthy();
       });
       it('should be false if different calls', async () => {
         const callId = 'some-call-id';
-        // @ts-expect-error
         const room = new Room({
-          // @ts-expect-error
           connectedCallSession: new CallSession({
             callId: 'some-other-call-id',
-          }),
-        });
+          } as any),
+        } as any);
         const roomHasCall = room.hasCallWithId(callId);
         expect(roomHasCall).toBeFalsy();
       });
@@ -146,55 +130,49 @@ describe('Room', () => {
     it('should updated participant with corresponding UUID', async () => {
       const uuid = 'some-uuid';
       const room = new Room({
-        // @ts-expect-error
         participants: [{
           uuid,
           talking: true,
         }],
-      });
+      } as any);
       expect(room.participants[0].talking).toBeTruthy();
       const updatedRoom = room.updateParticipant(uuid, {
         talking: false,
-      });
+      } as any);
       expect(updatedRoom.participants[0].talking).toBeFalsy();
     });
     it('should add participant when not found', async () => {
       const uuid = 'some-uuid';
-      // @ts-expect-error
       const room = new Room({
         participants: [],
-      });
+      } as any);
       const updatedRoom = room.updateParticipant(uuid, {
         talking: false,
-      }, true);
+      } as any, true);
       expect(updatedRoom.participants[0].talking).toBeFalsy();
     });
   });
   describe('on updated participant by extension', () => {
     it('should updated participant with corresponding extension', async () => {
-      const extension = 1234;
+      const extension = '1234';
       const room = new Room({
         participants: [{
-          // @ts-expect-error
           extension,
           talking: false,
         }],
-      });
+      } as any);
       expect(room.participants[0].talking).toBeFalsy();
-      // @ts-expect-error
       const updatedRoom = room.updateParticipantByExtension(extension, {
         talking: true,
-      });
+      } as any);
       expect(updatedRoom.participants[0].talking).toBeTruthy();
     });
   });
   describe('on disconnect', () => {
     it('should destroy connected call', async () => {
-      // @ts-expect-error
       const room = new Room({
-        // @ts-expect-error
-        connectedCallSession: new CallSession({}),
-      });
+        connectedCallSession: new CallSession({} as any),
+      } as any);
       expect(room.connectedCallSession).not.toBeNull();
       const updatedRoom = room.disconnect();
       expect(updatedRoom.connectedCallSession).toBeNull();
@@ -204,11 +182,10 @@ describe('Room', () => {
     it('should remove participant with corresponding UUID', async () => {
       const uuid = 'some-uuid';
       const room = new Room({
-        // @ts-expect-error
         participants: [{
           uuid,
         }],
-      });
+      } as any);
       expect(room.participants.some(participant => participant.uuid === uuid)).toBeTruthy();
       const updatedRoom = room.removeParticipantWithUUID(uuid);
       expect(updatedRoom.participants.some(participant => participant.uuid === uuid)).toBeFalsy();
@@ -218,11 +195,10 @@ describe('Room', () => {
     it('should remove participant with corresponding UUID', async () => {
       const extension = 'some-extension';
       const room = new Room({
-        // @ts-expect-error
         participants: [{
           extension,
         }],
-      });
+      } as any);
       expect(room.participants.some(participant => participant.extension === extension)).toBeTruthy();
       const updatedRoom = room.removeParticipantWithExtension(extension);
       expect(updatedRoom.participants.some(participant => participant.extension === extension)).toBeFalsy();

package/src/domain/__tests__/Session.test.ts

@@ -27,8 +27,7 @@ describe('Session domain', () => {
         xivo_user_uuid: null,
       },
     };
-    // @ts-ignore
-    const session = Session.parse(plain);
+    const session = Session.parse(plain as any);
     expect(session).toEqual(new Session({
       token: 'b93ae6bd-08d7-4001-9e61-057e72bbc4b3',
       refreshToken: null,
@@ -47,13 +46,13 @@ describe('Session domain', () => {
       const session = new Session({
         token: 'ref-12345',
         uuid: '1234',
-        // @ts-expect-error
+        //
         profile: new Profile({
           voicemail: {
             id: 1234,
             name: 'inbox',
           },
-        }),
+        } as any),
         expiresAt: A_DATE,
       });
       expect(session.hasAccessToVoicemail()).toBeTruthy();
@@ -64,7 +63,7 @@ describe('Session domain', () => {
           const session = new Session({
             token: 'ref-12345',
             uuid: '1234',
-            // @ts-expect-error
+            //
             profile: new Profile({
               lines: [new Line({
                 id: 9012,
@@ -81,7 +80,7 @@ describe('Session domain', () => {
                   context: 'internal',
                 }],
               })],
-            }),
+            } as any),
             expiresAt: A_DATE,
           });
           expect(session.allNumbers().length).toBeGreaterThan(1);
@@ -92,7 +91,7 @@ describe('Session domain', () => {
           const session = new Session({
             token: 'ref-12345',
             uuid: '1234',
-            // @ts-expect-error
+            //
             profile: new Profile({
               lines: [new Line({
                 id: 9012,
@@ -102,7 +101,7 @@ describe('Session domain', () => {
                   context: 'default',
                 }],
               })],
-            }),
+            } as any),
             expiresAt: A_DATE,
           });
           expect(session.allNumbers().length).toEqual(1);
@@ -113,10 +112,10 @@ describe('Session domain', () => {
       const session = new Session({
         token: 'ref-12345',
         uuid: '1234',
-        // @ts-expect-error
+        //
         profile: new Profile({
           voicemail: undefined,
-        }),
+        } as any),
         expiresAt: A_DATE,
       });
       expect(session.hasAccessToVoicemail()).toBeFalsy();
@@ -164,7 +163,7 @@ describe('Session domain', () => {
     const session = new Session({
       token: 'ref-12345',
       uuid: '1234',
-      // @ts-expect-error
+      //
       profile: new Profile({
         lines: [new Line({
           id: 9012,
@@ -181,7 +180,7 @@ describe('Session domain', () => {
             context: 'internal',
           }],
         })],
-      }),
+      } as any),
       expiresAt: new Date(9999, 0, 1),
     });
     it('should return true given it owns the extension', () => {
@@ -226,10 +225,10 @@ describe('Session domain', () => {
       describe('and NO lines', () => {
         beforeEach(() => {
           A_SESSION = new Session({ ...A_SESSION,
-            // @ts-expect-error
+            //
             profile: new Profile({
               lines: [],
-            }),
+            } as any),
           });
         });
         it('should return default context', async () => {
@@ -246,13 +245,13 @@ describe('Session domain', () => {
               exten: '1',
             }],
             id: 1,
-            // @ts-expect-error
+            //
             exten: 1,
-          });
-          // @ts-expect-error
+          } as any);
+          //
           const profile = new Profile({
             lines: [line],
-          });
+          } as any);
           A_SESSION = new Session({ ...A_SESSION,
             profile,
           });
@@ -272,10 +271,10 @@ describe('Session domain', () => {
         });
         describe('and NO lines', () => {
           beforeEach(() => {
-            // @ts-expect-error
+            //
             const profile = new Profile({
               lines: [],
-            });
+            } as any);
             A_SESSION = new Session({ ...A_SESSION,
               profile,
             });
@@ -294,13 +293,13 @@ describe('Session domain', () => {
                 exten: '1',
               }],
               id: 1,
-              // @ts-expect-error
+              //
               exten: 1,
-            });
-            // @ts-expect-error
+            } as any);
+            //
             const profile = new Profile({
               lines: [line],
-            });
+            } as any);
             A_SESSION = new Session({ ...A_SESSION,
               profile,
               engineVersion: '18.08',
@@ -329,13 +328,13 @@ describe('Session domain', () => {
                   exten: '1',
                 }],
                 id: 1,
-                // @ts-expect-error
+                //
                 exten: 1,
-              });
-              // @ts-expect-error
+              } as any);
+              //
               const profile = new Profile({
                 lines: [line],
-              });
+              } as any);
               A_SESSION = new Session({ ...A_SESSION,
                 profile,
               });