@vpmedia/phaser 1.124.0 → 1.125.0

package/src/phaser/core/scale_manager.ts

@@ -5,6 +5,7 @@ import type { Game, GameConfig } from './game.js';
 import { DOM } from './dom.js';
 import { Signal } from './signal.js';
 import type { AppliedCallback, Callback } from './callback.js';
+import type { Input } from './input.js';
 
 /** The gap the canvas leaves around itself inside its parent. */
 export type ScaleMargin = { left: number; top: number; right: number; bottom: number; x: number; y: number };
@@ -159,7 +160,7 @@ export class ScaleManager {
     this._lastReportedCanvasSize = new Rectangle();
     this._lastReportedGameSize = new Rectangle();
     this._booted = false;
-    if (game.config) {
+    if (game.config as GameConfig | undefined) {
       this.parseConfig(game.config);
     }
     this.setupScale(width, height);
@@ -249,7 +250,7 @@ export class ScaleManager {
       if (typeof this.game.parent === 'string') {
         // hopefully an element ID
         target = document.querySelector<HTMLElement>(`#${CSS.escape(this.game.parent)}`);
-      } else if (this.game.parent && this.game.parent.nodeType === 1) {
+      } else if (typeof this.game.parent === 'object' && this.game.parent.nodeType === 1) {
         // quick test for a HTMLelement
         target = this.game.parent;
       }
@@ -447,12 +448,12 @@ export class ScaleManager {
     this.scaleFactorInversed.y = this.height / this.game.height;
     this.aspectRatio = this.width / this.height;
     // This can be invoked in boot pre-canvas
-    if (this.game.canvas) {
+    if (this.game.canvas as HTMLCanvasElement | undefined) {
       this.dom.getOffset(this.game.canvas, this.offset);
     }
     this.bounds.setTo(this.offset.x, this.offset.y, this.width, this.height);
     // Can be invoked in boot pre-input
-    if (this.game.input && this.game.input.scale) {
+    if (this.game.input as Input | undefined) {
       this.game.input.scale.setTo(this.scaleFactor.x, this.scaleFactor.y);
     }
   }
@@ -579,7 +580,7 @@ export class ScaleManager {
    * @returns {Rectangle} TBD.
    */
   public getParentBounds(target: Rectangle): Rectangle {
-    const bounds = target || new Rectangle();
+    const bounds = target ?? new Rectangle();
     const parentNode = this.boundingParent;
     const { visualBounds } = this.dom;
     const { layoutBounds } = this.dom;
@@ -757,10 +758,10 @@ export class ScaleManager {
       // Max/min not honored fullscreen
       return;
     }
-    if (this.maxWidth) {
+    if (this.maxWidth !== null) {
       this.width = Math.min(this.width, this.maxWidth);
     }
-    if (this.maxHeight) {
+    if (this.maxHeight !== null) {
       this.height = Math.min(this.height, this.maxHeight);
     }
   }
@@ -796,7 +797,7 @@ export class ScaleManager {
     }
     if (this.compatibility.clickTrampoline === 'when-not-mouse') {
       const { input } = this.game;
-      if (input.activePointer && input.activePointer !== input.mousePointer && allowTrampoline) {
+      if (input.activePointer !== null && input.activePointer !== input.mousePointer && allowTrampoline) {
         input.activePointer.addClickTrampoline('startFullScreen', this.startFullScreen, this, [antialias, false]);
         return false;
       }
@@ -953,7 +954,7 @@ export class ScaleManager {
     if (this.parentIsWindow || (this.isFullScreen && this.hasPhaserSetFullScreen && !this._createdFullScreenTarget)) {
       return null;
     }
-    const parentNode = this.game.canvas ? (this.game.canvas.parentNode as HTMLElement | null) : null;
+    const parentNode = (this.game.canvas.parentNode as HTMLElement | null) ?? null;
     return parentNode ?? null;
   }
 

package/src/phaser/core/scene_manager.ts

@@ -137,7 +137,7 @@ export class SceneManager {
       this._pendingState = key;
       this._clearWorld = clearWorld;
       this._clearCache = clearCache;
-      if (args && args.length > 0) {
+      if (args.length > 0) {
         this._args = [...args];
       }
     }
@@ -153,7 +153,7 @@ export class SceneManager {
     this._pendingState = this.current;
     this._clearWorld = clearWorld;
     this._clearCache = clearCache;
-    if (args && args.length > 0) {
+    if (args.length > 0) {
       this._args = [...args];
     }
   }

package/src/phaser/core/signal.ts

@@ -185,7 +185,7 @@ export class Signal {
     let n = this._bindings.length;
     while (n) {
       n -= 1;
-      if (context) {
+      if (context !== null) {
         if (this._bindings[n]!.context === context) {
           this._bindings[n]!._destroy();
           this._bindings.splice(n, 1);
@@ -194,7 +194,7 @@ export class Signal {
         this._bindings[n]!._destroy();
       }
     }
-    if (!context) {
+    if (context === null) {
       this._bindings.length = 0;
     }
   }

package/src/phaser/core/sound.ts

@@ -81,7 +81,7 @@ export class Sound {
    */
   public constructor(game: Game, key: string, volume = 1, loop = false, connect: boolean | null = null) {
     // https://developer.mozilla.org/en-US/docs/Web/API/Web_Audio_API/Migrating_from_webkitAudioContext
-    connect ??= game.sound.connectToMaster;
+    const connectToMaster = connect ?? game.sound.connectToMaster;
     this.game = game;
     this.name = key;
     this.key = key;
@@ -116,7 +116,7 @@ export class Sound {
         : this.context!.createGain();
     this.gainNode = gainNode;
     gainNode.gain.value = volume * this.game.sound.volume;
-    if (connect && this.masterGainNode) {
+    if (connectToMaster && this.masterGainNode !== null) {
       gainNode.connect(this.masterGainNode);
     }
     this.onPlay = new Signal();
@@ -193,7 +193,7 @@ export class Sound {
     }
     if (this.externalNode) {
       this._sound.disconnect(this.externalNode);
-    } else if (this.gainNode) {
+    } else if (this.gainNode as GainNode | undefined) {
       this._sound.disconnect(this.gainNode);
     }
     if (this._removeFromSoundManager) {
@@ -270,16 +270,14 @@ export class Sound {
    * @returns {Sound} This Sound instance for chaining.
    */
   public play(marker: string | false | null = '', position = 0, volume = 1, loop = false, forceRestart = true): this {
-    if (marker === undefined || marker === false || marker === null) {
-      marker = '';
-    }
-    forceRestart ??= true;
+    const markerName = marker === undefined || marker === false || marker === null ? '' : marker;
 
     if (this.isPlaying && !this.allowMultiple && !forceRestart && !this.override) {
       //  Use Restart instead
       return this;
     }
-    if (this._sound && this.isPlaying && !this.allowMultiple && (this.override || forceRestart)) {
+    const source = this._sound as AudioBufferSourceNode | undefined;
+    if (source && this.isPlaying && !this.allowMultiple && (this.override || forceRestart)) {
       if (this._sound.stop === undefined) {
         (this._sound as unknown as LegacyBufferSource).noteOff(0);
       } else {
@@ -287,20 +285,20 @@ export class Sound {
       }
       if (this.externalNode) {
         this._sound.disconnect(this.externalNode);
-      } else if (this.gainNode) {
+      } else if (this.gainNode as GainNode | undefined) {
         this._sound.disconnect(this.gainNode);
       }
       this.isPlaying = false;
     }
-    if (marker === '' && Object.keys(this.markers).length > 0) {
+    if (markerName === '' && Object.keys(this.markers).length > 0) {
       //  If they didn't specify a marker but this is an audio sprite,
       //  We should never play the entire thing
       return this;
     }
-    const markerData = marker === '' ? undefined : this.markers[marker];
-    if (marker !== '') {
+    const markerData = markerName === '' ? undefined : this.markers[markerName];
+    if (markerName !== '') {
       if (markerData) {
-        this.currentMarker = marker;
+        this.currentMarker = markerName;
         //  Playing a marker? Then we default to the marker values
         this.position = markerData.start;
         this.volume = markerData.volume;
@@ -313,32 +311,27 @@ export class Sound {
         if (loop !== undefined) {
           this.loop = loop;
         }
-        this._tempMarker = marker;
+        this._tempMarker = markerName;
         this._tempPosition = this.position;
         this._tempVolume = this.volume;
         this._tempLoop = this.loop;
       } else {
-        this.game.logger.warn(`Sound.play: audio marker ${marker} does not exist`);
+        this.game.logger.warn(`Sound.play: audio marker ${markerName} does not exist`);
         return this;
       }
     } else {
-      position ??= 0;
-      volume ??= this._volume;
-      if (loop === undefined) {
-        ({ loop } = this);
-      }
-      this.position = Math.max(0, position);
-      this.volume = volume;
-      this.loop = loop;
+      this.position = Math.max(0, position ?? 0);
+      this.volume = volume ?? this._volume;
+      this.loop = loop ?? this.loop;
       this.duration = 0;
       this.durationMS = 0;
-      this._tempMarker = marker;
+      this._tempMarker = markerName;
       this._tempPosition = position;
       this._tempVolume = volume;
       this._tempLoop = loop;
     }
     //  Does the sound need decoding?
-    if (this.game.cache.isSoundDecoded(this.key)) {
+    if (this.game.cache.isSoundDecoded(this.key) === true) {
       this._sound = this.context!.createBufferSource();
       if (this.externalNode) {
         this._sound.connect(this.externalNode);
@@ -347,10 +340,10 @@ export class Sound {
       }
       this._buffer = this.game.cache.getSoundData(this.key) as AudioBuffer | null;
       this._sound.buffer = this._buffer;
-      if (this.loop && marker === '') {
+      if (this.loop && markerName === '') {
         this._sound.loop = true;
       }
-      if (!this.loop && marker === '') {
+      if (!this.loop && markerName === '') {
         this._sound.addEventListener('ended', this.onEndedHandler, { once: true });
       }
       this.totalDuration = this._sound.buffer?.duration ?? 0;
@@ -361,7 +354,7 @@ export class Sound {
       //  Useful to cache this somewhere perhaps?
       if (this._sound.start === undefined) {
         (this._sound as unknown as LegacyBufferSource).noteGrainOn(0, this.position, this.duration);
-      } else if (this.loop && marker === '') {
+      } else if (this.loop && markerName === '') {
         this._sound.start(0, 0);
       } else {
         this._sound.start(0, this.position, this.duration);
@@ -395,7 +388,7 @@ export class Sound {
    * Pauses the sound.
    */
   public pause(): void {
-    if (this.isPlaying && this._sound) {
+    if (this.isPlaying && (this._sound as AudioBufferSourceNode | undefined)) {
       this.paused = true;
       this.pausedPosition = this.currentTime;
       this.pausedTime = this.game.time.time;
@@ -409,7 +402,7 @@ export class Sound {
    * Resumes the sound.
    */
   public resume(): void {
-    if (this.paused && this._sound) {
+    if (this.paused && (this._sound as AudioBufferSourceNode | undefined)) {
       const p = Math.max(0, this.position + this.pausedPosition / 1000);
       this._sound = this.context!.createBufferSource();
       this._sound.buffer = this._buffer;
@@ -441,7 +434,7 @@ export class Sound {
    * Stops the sound.
    */
   public stop(): void {
-    if (this.isPlaying && this._sound) {
+    if (this.isPlaying && (this._sound as AudioBufferSourceNode | undefined)) {
       if (this._sound.stop === undefined) {
         (this._sound as unknown as LegacyBufferSource).noteOff(0);
       } else {
@@ -449,7 +442,7 @@ export class Sound {
       }
       if (this.externalNode) {
         this._sound.disconnect(this.externalNode);
-      } else if (this.gainNode) {
+      } else if (this.gainNode as GainNode | undefined) {
         this._sound.disconnect(this.gainNode);
       }
     }

package/src/phaser/core/sound_manager.ts

@@ -73,7 +73,7 @@ export class SoundManager {
       setAudioDisabledState();
       return;
     }
-    if (globalThis.AudioContext) {
+    if (globalThis.AudioContext as typeof AudioContext | undefined) {
       try {
         this.game.logger.info('initAudioContext');
         this.context = new globalThis.AudioContext();
@@ -240,7 +240,7 @@ export class SoundManager {
       return;
     }
     for (const sound of this._sounds) {
-      if (sound) {
+      if (sound !== null) {
         sound.stop();
       }
     }
@@ -254,7 +254,7 @@ export class SoundManager {
       return;
     }
     for (const sound of this._sounds) {
-      if (sound) {
+      if (sound !== null) {
         sound.pause();
       }
     }
@@ -268,7 +268,7 @@ export class SoundManager {
       return;
     }
     for (const sound of this._sounds) {
-      if (sound) {
+      if (sound !== null) {
         sound.resume();
       }
     }
@@ -317,7 +317,7 @@ export class SoundManager {
     this._watchList.reset();
     for (const file of candidates) {
       const key = file instanceof Sound ? file.key : file;
-      if (!this.game.cache.isSoundDecoded(key)) {
+      if (this.game.cache.isSoundDecoded(key) !== true) {
         this._watchList.add(key);
       }
     }
@@ -344,8 +344,8 @@ export class SoundManager {
     }
     if (this._watching) {
       let key = this._watchList.first;
-      while (key) {
-        if (this.game.cache.isSoundDecoded(key)) {
+      while (key !== null) {
+        if (this.game.cache.isSoundDecoded(key) === true) {
           this._watchList.remove(key);
         }
         key = this._watchList.next;
@@ -469,7 +469,7 @@ export class SoundManager {
   public destroy(): void {
     this.stopAll();
     for (const sound of this._sounds) {
-      if (sound) {
+      if (sound !== null) {
         sound.destroy();
       }
     }
@@ -519,15 +519,11 @@ export class SoundManager {
    * Sets the volume level of the sound manager.
    */
   public set volume(value: number) {
-    if (value < 0) {
-      value = 0;
-    } else if (value > 1) {
-      value = 1;
-    }
-    if (this._volume !== value) {
-      this._volume = value;
+    const level = Math.min(1, Math.max(0, value));
+    if (this._volume !== level) {
+      this._volume = level;
       if (!this.noAudio) {
-        this.masterGain.gain.value = value;
+        this.masterGain.gain.value = level;
       }
     }
   }

package/src/phaser/core/sound_sprite.ts

@@ -38,7 +38,7 @@ export class SoundSprite {
       sound.addMarker(markerKey, marker.start, marker.end - marker.start, undefined, marker.loop);
       this.sounds[markerKey] = sound;
     }
-    if (this.config.autoplay) {
+    if (this.config.autoplay !== undefined) {
       this.autoplayKey = this.config.autoplay;
       this.play(this.autoplayKey);
       this.autoplay = this.sounds[this.autoplayKey]!;

package/src/phaser/core/stage.ts

@@ -37,11 +37,11 @@ export class Stage extends DisplayObject {
       color: 0,
       rgba: '#000000',
     };
-    if (!game.config.transparent) {
+    if (game.config.transparent === false) {
       // transparent = 0,0,0,0 - otherwise r,g,b,1
       this._bgColor.a = 1;
     }
-    if (game.config.backgroundColor && !this.game.config.transparent) {
+    if (game.config.backgroundColor !== 0 && this.game.config.transparent === false) {
       this.setBackgroundColor(game.config.backgroundColor);
     }
   }
@@ -51,7 +51,7 @@ export class Stage extends DisplayObject {
    * @param {number} color - The color to set as the background.
    */
   public setBackgroundColor(color: number): void {
-    if (this.game.config.transparent) {
+    if (this.game.config.transparent !== false) {
       return;
     }
     valueToColor(color, this._bgColor);

package/src/phaser/core/timer.ts

@@ -215,7 +215,7 @@ export class Timer {
     this._i = this.events.length;
     while (this._i) {
       this._i -= 1;
-      if (this.events[this._i]?.pendingDelete) {
+      if (this.events[this._i]?.pendingDelete === true) {
         this.events.splice(this._i, 1);
       }
     }

package/src/phaser/core/tween.ts

@@ -167,10 +167,7 @@ export class Tween {
     }
     this.manager.add(this);
     this.isRunning = true;
-    if (index < 0 || index > this.timeline.length - 1) {
-      index = 0;
-    }
-    this.current = index;
+    this.current = index < 0 || index > this.timeline.length - 1 ? 0 : index;
     this.timeline[this.current]!.start();
     return this;
   }
@@ -290,10 +287,7 @@ export class Tween {
    * @returns {Tween} This Tween object for chaining.
    */
   public easing(ease: string | EasingFunction, index: number): this {
-    if (typeof ease === 'string' && this.manager.easeMap[ease]) {
-      ease = this.manager.easeMap[ease]!;
-    }
-    return this.updateTweenData('easingFunction', ease, index);
+    return this.updateTweenData('easingFunction', this.resolveEasing(ease), index);
   }
 
   /**
@@ -407,7 +401,7 @@ export class Tween {
    * @returns {boolean} True if the tween should continue running, false if it's complete.
    */
   public update(time: number): boolean {
-    if (this.pendingDelete || !this.target) {
+    if (this.pendingDelete || !(this.target as TweenTarget | undefined)) {
       return false;
     }
     if (this.isPaused) {
@@ -507,10 +501,11 @@ export class Tween {
     for (const tweenData of this.timeline) {
       tweenData.loadValues();
     }
+    const frames = [...data];
     for (const tweenData of this.timeline) {
-      data = [...data, ...tweenData.generateData(frameRate)];
+      frames.push(...tweenData.generateData(frameRate));
     }
-    return data;
+    return frames;
   }
 
   /**

package/src/phaser/display/bitmap_text.ts

@@ -80,7 +80,7 @@ export class BitmapText extends DisplayObject {
       return;
     }
 
-    if (!this.exists || !this.parent?.exists) {
+    if (!this.exists || this.parent?.exists !== true) {
       this.renderOrderID = -1;
       return;
     }
@@ -150,7 +150,7 @@ export class BitmapText extends DisplayObject {
       //  What will the line width be if we add this character to it?
       c = (kerning + (charData.texture?.width ?? 0) + charData.xOffset) * scale;
       //  Do we need to line-wrap?
-      if (maxWidth && w + c >= maxWidth && lastSpace > -1) {
+      if (maxWidth !== null && w + c >= maxWidth && lastSpace > -1) {
         //  The last space was at "lastSpace" which was "i - lastSpace" characters ago
         return {
           width: wrappedWidth || w,
@@ -463,7 +463,7 @@ export class BitmapText extends DisplayObject {
    * @returns {boolean} True if smoothing is enabled, false otherwise.
    */
   public get smoothed(): boolean {
-    return !this._data?.base.scaleMode;
+    return this._data?.base.scaleMode === 0;
   }
 
   /**

package/src/phaser/display/button.ts

@@ -93,7 +93,7 @@ export class Button extends Image {
     this._onDownFrame = null;
     this._onUpFrame = null;
     this._onDisabledFrame = null;
-    if (this.onInputOver) {
+    if (this.onInputOver !== null) {
       this.onInputOver.dispose();
       this.onInputOut.dispose();
       this.onInputDown.dispose();
@@ -103,7 +103,7 @@ export class Button extends Image {
     this.onInputOut = null!;
     this.onInputDown = null!;
     this.onInputUp = null!;
-    if (this.input) {
+    if (this.input !== null) {
       this.input.destroy();
     }
     this.input = null!;
@@ -148,7 +148,7 @@ export class Button extends Image {
    */
   public setStateFrame(state: string, frame: string | null, switchImmediately = false): void {
     const frameKey: `_on${string}Frame` = `_on${state}Frame`;
-    if (frame) {
+    if (frame !== null) {
       this[frameKey] = frame;
       if (switchImmediately) {
         this.changeStateFrame(state);
@@ -167,7 +167,7 @@ export class Button extends Image {
     if (this.freezeFrames) {
       return false;
     }
-    const state = this.input.enabled || !this._onDisabledFrame ? newState : STATE_DISABLED;
+    const state = this.input.enabled || this._onDisabledFrame === null ? newState : STATE_DISABLED;
     const frameKey: `_on${string}Frame` = `_on${state}Frame`;
     const frame = this[frameKey];
     if (typeof frame === 'string') {
@@ -199,7 +199,7 @@ export class Button extends Image {
     this.setStateFrame(STATE_OUT, outFrame, !this.input.pointerOver());
     this.setStateFrame(STATE_DOWN, downFrame, this.input.pointerDown());
     this.setStateFrame(STATE_UP, upFrame, this.input.pointerUp());
-    if (disabledFrame) {
+    if (disabledFrame !== null) {
       this.setStateFrame(STATE_DISABLED, disabledFrame, !this.input.enabled);
     }
   }
@@ -218,7 +218,7 @@ export class Button extends Image {
     if (this.onOverMouseOnly && !pointer.isMouse) {
       return;
     }
-    if (this.onInputOver) {
+    if (this.onInputOver !== null) {
       this.onInputOver.dispatch(this, pointer);
     }
   }
@@ -230,7 +230,7 @@ export class Button extends Image {
    */
   public onInputOutHandler(_sprite: Image, pointer: Pointer): void {
     this.changeStateFrame(STATE_OUT);
-    if (this.onInputOut) {
+    if (this.onInputOut !== null) {
       this.onInputOut.dispatch(this, pointer);
     }
   }
@@ -242,7 +242,7 @@ export class Button extends Image {
    */
   public onInputDownHandler(_sprite: Image, pointer: Pointer): void {
     this.changeStateFrame(STATE_DOWN);
-    if (this.onInputDown) {
+    if (this.onInputDown !== null) {
       this.onInputDown.dispatch(this, pointer);
     }
   }
@@ -254,7 +254,7 @@ export class Button extends Image {
    * @param {boolean} isOver - Whether the pointer is currently over the button (default: true).
    */
   public onInputUpHandler(_sprite: Image, pointer: Pointer, isOver: boolean): void {
-    if (this.onInputUp) {
+    if (this.onInputUp !== null) {
       this.onInputUp.dispatch(this, pointer, isOver);
     }
     if (this.freezeFrames) {
@@ -281,7 +281,7 @@ export class Button extends Image {
    * @returns {boolean} True if input is enabled, false otherwise.
    */
   public get inputEnabled(): boolean {
-    return this.input && this.input.enabled;
+    return this.input !== null && this.input.enabled;
   }
 
   /**
@@ -293,10 +293,10 @@ export class Button extends Image {
       if (this.input === null) {
         this.input = new InputHandler(this);
         this.input.start();
-      } else if (this.input && !this.input.enabled) {
+      } else if (this.input !== null && !this.input.enabled) {
         this.input.start();
       }
-    } else if (this.input && this.input.enabled) {
+    } else if (this.input !== null && this.input.enabled) {
       this.input.stop();
     }
   }

package/src/phaser/display/canvas/graphics.ts

@@ -71,7 +71,7 @@ export const renderGraphics = (graphics: Graphics, context: CanvasRenderingConte
         context.stroke();
       }
     } else if (shape instanceof Rectangle) {
-      if (data.fillColor || data.fillColor === 0) {
+      if (data.fillColor !== null) {
         context.globalAlpha = data.fillAlpha * worldAlpha;
         context.fillStyle = `#${`00000${Math.trunc(fillColor ?? 0).toString(16)}`.slice(-6)}`;
         context.fillRect(shape.x, shape.y, shape.width, shape.height);
@@ -144,7 +144,7 @@ export const renderGraphics = (graphics: Graphics, context: CanvasRenderingConte
       context.lineTo(rx + radius, ry);
       context.quadraticCurveTo(rx, ry, rx, ry + radius);
       context.closePath();
-      if (data.fillColor || data.fillColor === 0) {
+      if (data.fillColor !== null) {
         context.globalAlpha = data.fillAlpha * worldAlpha;
         context.fillStyle = `#${`00000${Math.trunc(fillColor ?? 0).toString(16)}`.slice(-6)}`;
         context.fill();

package/src/phaser/display/canvas/pool.ts

@@ -16,7 +16,7 @@ export const getPool = (): CanvasPoolEntry[] => {
 export const getFirst = (): number => {
   const pool = getPool();
   for (let i = 0; i < pool.length; i += 1) {
-    if (!pool[i]!.parent) {
+    if (pool[i]!.parent === null) {
       return i;
     }
   }
@@ -61,7 +61,7 @@ export const getTotal = (): number => {
   const pool = getPool();
   let c = 0;
   for (const entry of pool) {
-    if (entry.parent) {
+    if (entry.parent !== null) {
       c += 1;
     }
   }
@@ -76,7 +76,7 @@ export const getFree = (): number => {
   const pool = getPool();
   let c = 0;
   for (const entry of pool) {
-    if (!entry.parent) {
+    if (entry.parent === null) {
       c += 1;
     }
   }