@vpmedia/phaser 1.124.0 → 1.125.0

package/src/phaser/core/device_util.ts

@@ -96,7 +96,7 @@ export const checkFullScreenSupport = (device: Device): void => {
   const element = document.createElement('div');
   const elementApi = element as unknown as Record<string, unknown>;
   for (const name of fs) {
-    if (elementApi[name]) {
+    if (elementApi[name] !== undefined) {
       device.fullscreen = true;
       device.requestFullscreen = name;
       break;
@@ -105,13 +105,13 @@ export const checkFullScreenSupport = (device: Device): void => {
   if (device.fullscreen) {
     const documentApi = document as unknown as Record<string, unknown>;
     for (const name of cfs) {
-      if (documentApi[name]) {
+      if (documentApi[name] !== undefined) {
         device.cancelFullscreen = name;
         break;
       }
     }
     // ALLOW_KEYBOARD_INPUT is a legacy webkit fullscreen flag, absent from lib.dom
-    if (globalThis.Element && (Element as unknown as { ALLOW_KEYBOARD_INPUT?: number }).ALLOW_KEYBOARD_INPUT) {
+    if ((Element as unknown as { ALLOW_KEYBOARD_INPUT?: number }).ALLOW_KEYBOARD_INPUT !== undefined) {
       device.fullscreenKeyboard = true;
     }
   }
@@ -190,7 +190,7 @@ export const checkAudio = (device: Device): void => {
   for (const format of formats) {
     const { type, codecs } = format;
     for (const codec of codecs) {
-      if (!device.supportedAudioFormats[type]) {
+      if (device.supportedAudioFormats[type] !== true) {
         const isSupported = isMediaSourceTypeSupported(codec) || canPlayType(audioElement, codec);
         if (isSupported) {
           device.supportedAudioFormats[type] = isSupported;

package/src/phaser/core/dom.ts

@@ -17,7 +17,7 @@ class VisualBoundsDesktopRectangle {
    * @returns {number} The horizontal scroll position in pixels.
    */
   public get x(): number {
-    return globalThis && 'pageXOffset' in globalThis ? window.pageXOffset : document.documentElement.scrollLeft;
+    return 'pageXOffset' in globalThis ? window.pageXOffset : document.documentElement.scrollLeft;
   }
 
   /**
@@ -25,7 +25,7 @@ class VisualBoundsDesktopRectangle {
    * @returns {number} The vertical scroll position in pixels.
    */
   public get y(): number {
-    return globalThis && 'pageYOffset' in globalThis ? window.pageYOffset : document.documentElement.scrollTop;
+    return 'pageYOffset' in globalThis ? window.pageYOffset : document.documentElement.scrollTop;
   }
 
   /**
@@ -81,7 +81,7 @@ class VisualBoundsRectangle {
    * @returns {number} The horizontal scroll position in pixels.
    */
   public get x(): number {
-    return globalThis && 'pageXOffset' in globalThis ? window.pageXOffset : document.documentElement.scrollLeft;
+    return 'pageXOffset' in globalThis ? window.pageXOffset : document.documentElement.scrollLeft;
   }
 
   /**
@@ -89,7 +89,7 @@ class VisualBoundsRectangle {
    * @returns {number} The vertical scroll position in pixels.
    */
   public get y(): number {
-    return globalThis && 'pageYOffset' in globalThis ? window.pageYOffset : document.documentElement.scrollTop;
+    return 'pageYOffset' in globalThis ? window.pageYOffset : document.documentElement.scrollTop;
   }
 
   /**
@@ -199,13 +199,11 @@ export class DOM {
     this.layoutBounds = this.treatAsDesktop ? new LayoutBoundsDesktopRectangle() : new LayoutBoundsRectangle();
     this.documentBounds = new DocumentBoundsRectangle();
     this.scrollXProvider =
-      globalThis && 'pageXOffset' in globalThis
+      'pageXOffset' in globalThis
         ? (): number => window.pageXOffset
         : (): number => document.documentElement.scrollLeft;
     this.scrollYProvider =
-      globalThis && 'pageYOffset' in globalThis
-        ? (): number => window.pageYOffset
-        : (): number => document.documentElement.scrollTop;
+      'pageYOffset' in globalThis ? (): number => window.pageYOffset : (): number => document.documentElement.scrollTop;
   }
 
   /**
@@ -233,11 +231,12 @@ export class DOM {
    * @returns {boolean} True if bounds were successfully retrieved, false otherwise.
    */
   public getBounds(element: HTMLCanvasElement, cushion = 0): CalibratedBounds | false {
-    element = element && !element.nodeType ? (element as unknown as HTMLCanvasElement[])[0]! : element;
-    if (!element || element.nodeType !== 1) {
+    // a jQuery-style wrapper was accepted here historically, so unwrap the first entry of one
+    const target = element.nodeType === undefined ? (element as unknown as HTMLCanvasElement[])[0] : element;
+    if (target?.nodeType !== 1) {
       return false;
     }
-    return this.calibrate(element.getBoundingClientRect(), cushion);
+    return this.calibrate(target.getBoundingClientRect(), cushion);
   }
 
   /**
@@ -266,16 +265,21 @@ export class DOM {
    * @returns {string} The screen orientation ('portrait-primary', 'landscape-primary', etc.).
    */
   public getScreenOrientation(primaryFallback: string | null = null): OrientationType {
-    const { screen } = globalThis;
-    // @ts-expect-error the prefixed orientation properties predate the standard one and are absent from lib.dom
-    const orientation = screen.orientation || screen.mozOrientation || screen.msOrientation;
-    if (orientation && typeof orientation.type === 'string') {
-      // Screen Orientation API specification
-      return orientation.type;
-    } else if (typeof orientation === 'string') {
+    // the prefixed orientation properties predate the standard one and are absent from lib.dom
+    const screen = globalThis.screen as Screen & {
+      mozOrientation?: string;
+      msOrientation?: string;
+    };
+    const orientation: ScreenOrientation | string | undefined =
+      screen.orientation ?? screen.mozOrientation ?? screen.msOrientation;
+    if (typeof orientation === 'string') {
       // moz/ms-orientation are strings
       return orientation;
     }
+    if (typeof orientation?.type === 'string') {
+      // Screen Orientation API specification
+      return orientation.type;
+    }
     const PORTRAIT = 'portrait-primary';
     const LANDSCAPE = 'landscape-primary';
     if (primaryFallback === 'screen') {
@@ -288,7 +292,7 @@ export class DOM {
     if (primaryFallback === 'window.orientation' && typeof legacyOrientation === 'number') {
       // This may change by device based on "natural" orientation.
       return legacyOrientation === 0 || legacyOrientation === 180 ? PORTRAIT : LANDSCAPE;
-    } else if (globalThis.matchMedia) {
+    } else if (typeof globalThis.matchMedia === 'function') {
       if (globalThis.matchMedia('(orientation: portrait)').matches) {
         return PORTRAIT;
       } else if (globalThis.matchMedia('(orientation: landscape)').matches) {

package/src/phaser/core/frame_data.ts

@@ -20,10 +20,7 @@ export class FrameData {
   }
 
   public getFrame(index = 0): Frame {
-    if (index >= this._frames.length) {
-      index = 0;
-    }
-    return this._frames[index]!;
+    return this._frames[index >= this._frames.length ? 0 : index]!;
   }
 
   public getFrameByName(name: string): Frame | null {
@@ -59,7 +56,7 @@ export class FrameData {
     output: number[] | null = null
   ): number[] {
     const result = output ?? [];
-    if (frames && frames.length > 0) {
+    if (frames.length > 0) {
       for (const f of frames) {
         if (useNumericIndex && this._frames[f as number]) {
           result.push(this._frames[f as number]!.index);

package/src/phaser/core/game.ts

@@ -165,10 +165,10 @@ export class Game {
     this.input.boot();
     this.sound.boot();
     this.state.boot();
-    if (window.focus) {
+    if (typeof window.focus === 'function') {
       window.focus();
     }
-    if (!this.config.isSkipTicker) {
+    if (this.config.isSkipTicker !== true) {
       this.raf = new RequestAnimationFrame(this);
       this.raf.start();
     }
@@ -180,7 +180,7 @@ export class Game {
    */
   public createRendererCanvas(): void {
     this.logger.info('createRendererCanvas');
-    if (this.canvas) {
+    if (this.canvas as HTMLCanvasElement | undefined) {
       removeFromDOM(this.canvas);
     }
     this.canvas = this.config.canvas ?? create(this, this.width, this.height, this.config.canvasID, true);
@@ -212,10 +212,10 @@ export class Game {
         isWebGlReady = true;
       } catch (error) {
         isWebGlReady = false;
-        if (globalThis.PhaserRegistry?.GL_PROGRAM_INFO_LOG) {
+        if (globalThis.PhaserRegistry?.GL_PROGRAM_INFO_LOG != null) {
           this.logger.warn('WebGL program info', { log: globalThis.PhaserRegistry.GL_PROGRAM_INFO_LOG });
         }
-        if (globalThis.PhaserRegistry?.GL_SHADER_INFO_LOG) {
+        if (globalThis.PhaserRegistry?.GL_SHADER_INFO_LOG != null) {
           this.logger.warn('WebGL shader info', { log: globalThis.PhaserRegistry.GL_SHADER_INFO_LOG });
         }
         const typedError = error instanceof Error ? error : new Error(String(error));
@@ -229,7 +229,7 @@ export class Game {
       if (this.contextRestoredBinded) {
         this.canvas.removeEventListener('webglcontextlost', this.contextRestoredBinded, false);
       }
-      if (this.renderer) {
+      if (this.renderer as CanvasRenderer | WebGLRenderer | undefined) {
         this.renderer.destroy();
       }
       this.createRendererCanvas();
@@ -278,7 +278,7 @@ export class Game {
     this.parseConfigElement(config, 'renderType', RENDER_AUTO);
     this.parseConfigElement(config, 'isForceDisabledAudio', false);
     this.parseConfigElement(config, 'maxParallelDownloads', 16);
-    if (config.parent) {
+    if (config.parent !== undefined) {
       this.parent = config.parent;
     }
     this.state = new SceneManager(this, config.state ?? null);
@@ -291,7 +291,7 @@ export class Game {
   public contextLost(event: Event): void {
     this.logger.info('contextLost', { type: event.type });
     event.preventDefault();
-    if (this.renderer) {
+    if (this.renderer as CanvasRenderer | WebGLRenderer | undefined) {
       this.renderer.contextLost = true;
     }
   }
@@ -302,7 +302,7 @@ export class Game {
    */
   public contextRestored(event: Event): void {
     this.logger.info('contextRestored', { type: event.type });
-    if (this.renderer) {
+    if (this.renderer as CanvasRenderer | WebGLRenderer | undefined) {
       this.renderer.initContext(this);
       // This.cache.clearGLTextures();
       this.renderer.contextLost = false;
@@ -340,10 +340,10 @@ export class Game {
     this.logger.info('destroy');
     this.isPaused = true;
 
-    if (!this.cache) {
+    if (!(this.cache as Cache | undefined)) {
       return;
     }
-    if (this.raf) {
+    if (this.raf as RequestAnimationFrame | undefined) {
       this.raf.stop();
     }
 
@@ -354,7 +354,7 @@ export class Game {
     this.stage.destroy();
     this.input.destroy();
 
-    if (this.canvas) {
+    if (this.canvas as HTMLCanvasElement | undefined) {
       if (this.contextLostBinded) {
         this.canvas.removeEventListener('webglcontextlost', this.contextLostBinded, false);
       }

package/src/phaser/core/input.ts

@@ -443,7 +443,7 @@ export class Input {
     }
     this.getLocalPosition(displayObject, pointer, this._localPoint);
     localPoint.copyFrom(this._localPoint);
-    if (displayObject.hitArea && displayObject.hitArea.contains) {
+    if (displayObject.hitArea !== null) {
       return displayObject.hitArea.contains(this._localPoint.x, this._localPoint.y);
     } else if (displayObject instanceof Image) {
       const { width } = displayObject.texture.frame;
@@ -457,7 +457,7 @@ export class Input {
       }
     } else if (displayObject instanceof Graphics) {
       for (const data of displayObject.graphicsData) {
-        if (data.fill && data.shape && data.shape.contains(this._localPoint.x, this._localPoint.y)) {
+        if (data.fill && (data.shape?.contains(this._localPoint.x, this._localPoint.y) ?? false)) {
           // Only deal with fills..
           return true;
         }

package/src/phaser/core/input_handler.ts

@@ -223,7 +223,7 @@ export class InputHandler {
    * TBD.
    */
   public destroy(): void {
-    if (this.sprite) {
+    if (this.sprite !== null) {
       if (this._setHandCursor) {
         this.game.canvas.style.cursor = 'default';
         this._setHandCursor = false;
@@ -402,7 +402,7 @@ export class InputHandler {
     if (
       !pointer.isDown ||
       !this.enabled ||
-      !this.sprite ||
+      this.sprite === null ||
       !this.sprite.parent ||
       !this.sprite.visible ||
       !this.sprite.parent.visible ||
@@ -430,7 +430,7 @@ export class InputHandler {
   public checkPointerOver(pointer: Pointer, fastTest = false): boolean {
     if (
       !this.enabled ||
-      !this.sprite ||
+      this.sprite === null ||
       !this.sprite.parent ||
       !this.sprite.visible ||
       !this.sprite.parent.visible ||
@@ -511,7 +511,7 @@ export class InputHandler {
       // Abort. We've been destroyed.
       return false;
     }
-    if (!this.enabled || !this.sprite.visible || !this.sprite.parent?.visible) {
+    if (!this.enabled || !this.sprite.visible || this.sprite.parent?.visible !== true) {
       this._pointerOutHandler(pointer);
       return false;
     }
@@ -560,7 +560,7 @@ export class InputHandler {
         this.game.canvas.style.cursor = 'pointer';
         this._setHandCursor = true;
       }
-      if (!silent && sendEvent && this.sprite && this.sprite.events) {
+      if (!silent && sendEvent && this.sprite !== null) {
         this.sprite.events.onInputOver$dispatch(this.sprite, pointer);
       }
       if (this.sprite.parent && this.sprite.parent.type === GROUP) {
@@ -587,9 +587,9 @@ export class InputHandler {
       this.game.canvas.style.cursor = 'default';
       this._setHandCursor = false;
     }
-    if (!silent && this.sprite && this.sprite.events) {
+    if (!silent && this.sprite !== null) {
       this.sprite.events.onInputOut$dispatch(this.sprite, pointer);
-      if (this.sprite && this.sprite.parent && this.sprite.parent.type === GROUP) {
+      if (this.sprite?.parent?.type === GROUP) {
         (this.sprite.parent as Group).onChildInputOut.dispatch(this.sprite, pointer);
       }
     }
@@ -615,10 +615,10 @@ export class InputHandler {
       this.downPoint.setTo(pointer.x, pointer.y);
       // It's possible the onInputDown event creates a new Sprite that is on-top of this one, so we ought to force a Pointer update
       pointer.dirty = true;
-      if (this.sprite && this.sprite.events) {
+      if (this.sprite !== null) {
         this.sprite.events.onInputDown$dispatch(this.sprite, pointer);
         // The event above might have destroyed this sprite.
-        if (this.sprite && this.sprite.parent && this.sprite.parent.type === GROUP) {
+        if (this.sprite?.parent?.type === GROUP) {
           (this.sprite.parent as Group).onChildInputDown.dispatch(this.sprite, pointer);
         }
         //  The events might have destroyed this sprite.
@@ -650,7 +650,7 @@ export class InputHandler {
    */
   public dragTimeElapsed(pointer: Pointer): void {
     this._dragTimePass = true;
-    if (this._pendingDrag && this.sprite && this._dragDistancePass) {
+    if (this._pendingDrag && this.sprite !== null && this._dragDistancePass) {
       this.startDrag(pointer);
     }
   }
@@ -673,14 +673,14 @@ export class InputHandler {
       data.downDuration = data.timeUp - data.timeDown;
       // Only release the InputUp signal if the pointer is still over this sprite
       let isOver = this.checkPointerOver(pointer);
-      if (this.sprite && this.sprite.events) {
+      if (this.sprite !== null) {
         if (
           !this.dragStopBlocksInputUp ||
           (this.dragStopBlocksInputUp && !(this.draggable && this.isDragged && this._draggedPointerID === pointer.id))
         ) {
           this.sprite.events.onInputUp$dispatch(this.sprite, pointer, isOver);
         }
-        if (this.sprite && this.sprite.parent && this.sprite.parent.type === GROUP) {
+        if (this.sprite?.parent?.type === GROUP) {
           (this.sprite.parent as Group).onChildInputUp.dispatch(this.sprite, pointer, isOver);
         }
         // The onInputUp event may have changed the sprite so that checkPointerOver is no longer true, so update it.
@@ -843,7 +843,7 @@ export class InputHandler {
    * TBD.
    */
   public disableDrag(): void {
-    if (this._pointerData) {
+    if (this._pointerData.length > 0) {
       for (let i = 0; i < 10; i += 1) {
         this.pointerData(i).isDragged = false;
       }

package/src/phaser/core/input_mouse.ts

@@ -106,7 +106,7 @@ export class Mouse {
     canvas.addEventListener('mouseover', this._onMouseOver, true);
     canvas.addEventListener('mouseout', this._onMouseOut, true);
     const { wheelEvent } = this.game.device;
-    if (wheelEvent) {
+    if (wheelEvent !== null) {
       canvas.addEventListener(wheelEvent, this._onMouseWheel, true);
     }
   }
@@ -132,13 +132,13 @@ export class Mouse {
       canvas.removeEventListener('mouseout', this._onMouseOut, true);
     }
     const { wheelEvent } = this.game.device;
-    if (wheelEvent && this._onMouseWheel) {
+    if (wheelEvent !== null && this._onMouseWheel) {
       canvas.removeEventListener(wheelEvent, this._onMouseWheel, true);
     }
-    if (this._onMouseUpGlobal) {
+    if (this._onMouseUpGlobal !== null) {
       globalThis.removeEventListener('mouseup', this._onMouseUpGlobal, true);
     }
-    if (this._onMouseOutGlobal) {
+    if (this._onMouseOutGlobal !== null) {
       globalThis.removeEventListener('mouseout', this._onMouseOutGlobal, true);
     }
   }

package/src/phaser/core/input_pointer.ts

@@ -149,7 +149,7 @@ export class Pointer {
    */
   public start(event: InputEvent): this {
     const { input } = this.game;
-    if (event.pointerId) {
+    if (event.pointerId !== undefined) {
       this.pointerId = event.pointerId;
     }
     this.identifier = event.identifier ?? null;

package/src/phaser/core/loader.ts

@@ -282,19 +282,19 @@ export class Loader {
       this.game.logger.warn(`Loader: Invalid or no key given of type ${type}`);
       return this;
     }
-    if (url === undefined || url === null) {
-      if (extension) {
-        url = key + extension;
-      } else {
+    let resolvedUrl = url;
+    if (resolvedUrl === undefined || resolvedUrl === null) {
+      if (extension === null) {
         this.game.logger.warn(`Loader: No URL given for file type: ${type} key: ${key}`);
         return this;
       }
+      resolvedUrl = key + extension;
     }
     const file: LoaderFile = {
       type,
       key,
       path: this.path,
-      url,
+      url: resolvedUrl,
       syncPoint: this._withSyncPointDepth > 0,
       data: null,
       loading: false,
@@ -351,11 +351,9 @@ export class Loader {
       error: false,
       callbackContext,
     };
-    if (data) {
-      if (typeof data === 'string') {
-        data = JSON.parse(data);
-      }
-      pack.data = (data ?? {}) as LoaderFileData;
+    if (data !== null) {
+      const parsed: unknown = typeof data === 'string' ? JSON.parse(data) : data;
+      pack.data = (parsed ?? {}) as LoaderFileData;
       pack.loaded = true;
     }
     for (let i = 0; i < this._fileList.length + 1; i += 1) {
@@ -473,10 +471,8 @@ export class Loader {
     if (this.game.sound.noAudio || this.game.device.noAudioFormat) {
       return this;
     }
-    if (typeof urls === 'string') {
-      urls = [urls];
-    }
-    return this.addToFileList('audio', key, urls, { buffer: null, autoDecode });
+    const sources = typeof urls === 'string' ? [urls] : urls;
+    return this.addToFileList('audio', key, sources, { buffer: null, autoDecode });
   }
 
   /**
@@ -495,11 +491,9 @@ export class Loader {
     this.audio(key, urls, autoDecode);
     if (jsonURL) {
       this.json(`${key}-audioatlas`, jsonURL);
-    } else if (jsonData) {
-      if (typeof jsonData === 'string') {
-        jsonData = JSON.parse(jsonData);
-      }
-      this.cache.addJSON(`${key}-audioatlas`, '', jsonData);
+    } else if (jsonData !== null) {
+      const parsed: unknown = typeof jsonData === 'string' ? JSON.parse(jsonData) : jsonData;
+      this.cache.addJSON(`${key}-audioatlas`, '', parsed);
     }
     return this;
   }
@@ -523,13 +517,11 @@ export class Loader {
     xSpacing = 0,
     ySpacing = 0
   ): this {
-    textureURL ??= `${key}.png`;
-    if (atlasURL === null && atlasData === null) {
-      atlasURL = `${key}.xml`;
-    }
+    const texture = textureURL ?? `${key}.png`;
+    const atlas = atlasURL === null && atlasData === null ? `${key}.xml` : atlasURL;
     //  A URL to a json/xml atlas has been given
-    if (atlasURL) {
-      this.addToFileList('bitmapfont', key, textureURL, { atlasURL, xSpacing, ySpacing });
+    if (atlas !== null) {
+      this.addToFileList('bitmapfont', key, texture, { atlasURL: atlas, xSpacing, ySpacing });
     } else if (typeof atlasData === 'string') {
       //  A stringified xml/json atlas has been given
       let json: unknown = null;
@@ -539,13 +531,13 @@ export class Loader {
       } catch {
         xml = this.parseXml(atlasData);
       }
-      if (!xml && !json) {
+      if (xml === null && json === null) {
         throw new Error(ENGINE_ERROR_INVALID_BITMAP_FONT_ATLAS);
       }
-      this.addToFileList('bitmapfont', key, textureURL, {
+      this.addToFileList('bitmapfont', key, texture, {
         atlasURL: null,
         atlasData: json ?? xml,
-        atlasType: json ? 'json' : 'xml',
+        atlasType: json === null ? 'xml' : 'json',
         xSpacing,
         ySpacing,
       });
@@ -569,15 +561,13 @@ export class Loader {
     atlasData: unknown = null,
     format: number = TEXTURE_ATLAS_JSON_HASH
   ): this {
-    textureURL ??= `${key}.png`;
-    if (!atlasURL && !atlasData) {
-      atlasURL = `${key}.json`;
-    }
+    const texture = textureURL ?? `${key}.png`;
+    const atlas = atlasURL === null && atlasData === null ? `${key}.json` : atlasURL;
     //  A URL to a json/xml file has been given
-    if (atlasURL) {
-      this.addToFileList('textureatlas', key, textureURL, { atlasURL, format });
+    if (atlas !== null) {
+      this.addToFileList('textureatlas', key, texture, { atlasURL: atlas, format });
     } else {
-      this.addToFileList('textureatlas', key, textureURL, { atlasURL: null, atlasData, format });
+      this.addToFileList('textureatlas', key, texture, { atlasURL: null, atlasData, format });
     }
     return this;
   }
@@ -701,7 +691,7 @@ export class Loader {
         }
       } else if (!file.loading && this._flightQueue.length < inflightLimit) {
         // -> not loaded/failed, not loading
-        if (file.type === 'packfile' && !file.data) {
+        if (file.type === 'packfile' && file.data === null) {
           // Fetches the pack data: the pack is processed above as it reaches queue-start.
           // (Packs do not trigger onLoadStart or onFileStart.)
           this._flightQueue.push(file);
@@ -892,7 +882,7 @@ export class Loader {
       }
       case 'audio': {
         const resolved = this.getAudioURL(file.url);
-        if (resolved) {
+        if (resolved !== null) {
           file.url = resolved;
           this.xhrLoad(file, this.transformUrl(resolved, file), 'arraybuffer', this.fileComplete);
         } else if (this.game.sound.noAudio) {
@@ -947,9 +937,9 @@ export class Loader {
       { once: true }
     );
     image.addEventListener('error', (): void => {
-      if (this.isUseRetry && (!file.numRetry || file.numRetry < this.maxRetry)) {
+      if (this.isUseRetry && (file.numRetry === undefined || file.numRetry < this.maxRetry)) {
         setTimeout((): void => {
-          file.numRetry = file.numRetry ? file.numRetry + 1 : 1;
+          file.numRetry = file.numRetry === undefined ? 1 : file.numRetry + 1;
           this.loadImageTag(file);
         }, 1000);
       } else if (!settled) {
@@ -993,16 +983,16 @@ export class Loader {
       xhr.setRequestHeader('X-Requested-With', requestedWith);
     }
     const acceptHeader = this.headers[file.type];
-    if (acceptHeader) {
+    if (acceptHeader !== undefined && acceptHeader !== false) {
       xhr.setRequestHeader('Accept', acceptHeader);
     }
     const handleError = onerror ?? this.fileError;
     const retry = (): boolean => {
-      if (!this.isUseRetry || (file.numRetry && file.numRetry >= this.maxRetry)) {
+      if (!this.isUseRetry || (file.numRetry !== undefined && file.numRetry >= this.maxRetry)) {
         return false;
       }
       setTimeout((): void => {
-        file.numRetry = file.numRetry ? file.numRetry + 1 : 1;
+        file.numRetry = file.numRetry === undefined ? 1 : file.numRetry + 1;
         this.xhrLoad(file, url, type, onload, handleError);
       }, 1000);
       return true;
@@ -1101,10 +1091,8 @@ export class Loader {
    */
   public fileError(file: LoaderFile, xhr: XMLHttpRequest | null = null, reason: unknown = 0): void {
     // const url = file.requestUrl || this.transformUrl(file.url, file);
-    if (!reason && xhr) {
-      reason = xhr.status;
-    }
-    const message = `Error loading asset (${String(reason)})`;
+    const cause = reason === 0 && xhr !== null ? xhr.status : reason;
+    const message = `Error loading asset (${String(cause)})`;
     this.asyncComplete(file, message);
   }
 
@@ -1156,7 +1144,7 @@ export class Loader {
         break;
       }
       case 'bitmapfont': {
-        if (!file.atlasURL) {
+        if (file.atlasURL === null || file.atlasURL === undefined) {
           this.cache.addBitmapFont(
             file.key,
             url,
@@ -1181,7 +1169,7 @@ export class Loader {
               } catch {
                 // pass
               }
-              if (json) {
+              if (json !== undefined) {
                 bitmapFontFile.atlasType = 'json';
                 this.jsonLoadComplete(bitmapFontFile, bitmapFontXhr);
               } else {
@@ -1197,7 +1185,7 @@ export class Loader {
         const audio = response.response as ArrayBuffer;
         file.data = audio;
         this.cache.addSound(file.key, url, audio);
-        if (file.autoDecode) {
+        if (file.autoDecode === true) {
           void this.game.sound.decode(file.key);
         }
         break;
@@ -1314,7 +1302,7 @@ export class Loader {
       } else {
         this.preloadSprite.rect.height = Math.floor((this.preloadSprite.height / 100) * this.progress);
       }
-      if (this.preloadSprite.sprite) {
+      if (this.preloadSprite.sprite !== null) {
         this.preloadSprite.sprite.updateCrop();
       } else {
         // We seem to have lost our sprite - maybe it was destroyed?