@vibescope/mcp-server 0.0.1 → 0.1.0

package/src/handlers/requests.test.ts

@@ -1,97 +1,8 @@
 import { describe, it, expect, vi, beforeEach } from 'vitest';
-import type { SupabaseClient } from '@supabase/supabase-js';
-import type { HandlerContext, TokenUsage } from './types.js';
 import { getPendingRequests, acknowledgeRequest, answerQuestion } from './requests.js';
 import { ValidationError } from '../validators.js';
-
-// ============================================================================
-// Test Utilities
-// ============================================================================
-
-function createMockSupabase(overrides: {
-	selectResult?: { data: unknown; error: unknown };
-	updateResult?: { data: unknown; error: unknown };
-	sessionsResult?: { data: unknown; error: unknown };
-} = {}) {
-	const defaultResult = { data: null, error: null };
-	// Use an object to track state so it persists across all mock function calls
-	const state = {
-		currentOperation: 'select' as string,
-		currentTable: '' as string,
-		updateCalled: false,
-	};
-
-	const mock = {
-		from: vi.fn((table: string) => {
-			state.currentTable = table;
-			// Reset state for new query chain
-			state.currentOperation = 'select';
-			state.updateCalled = false;
-			return mock;
-		}),
-		select: vi.fn(() => {
-			// Don't reset updateCalled - we need to know if update was in this chain
-			if (!state.updateCalled) {
-				state.currentOperation = 'select';
-			}
-			return mock;
-		}),
-		update: vi.fn(() => {
-			state.currentOperation = 'update';
-			state.updateCalled = true;
-			return mock;
-		}),
-		eq: vi.fn().mockReturnThis(),
-		or: vi.fn().mockReturnThis(),
-		order: vi.fn().mockReturnThis(),
-		single: vi.fn(() => {
-			// If update was called in this chain, return updateResult
-			if (state.updateCalled) {
-				return Promise.resolve(overrides.updateResult ?? defaultResult);
-			}
-			return Promise.resolve(overrides.selectResult ?? defaultResult);
-		}),
-		then: vi.fn((resolve: (value: unknown) => void) => {
-			if (state.currentTable === 'agent_sessions') {
-				return Promise.resolve(overrides.sessionsResult ?? { data: [], error: null }).then(resolve);
-			}
-			if (state.updateCalled) {
-				return Promise.resolve(overrides.updateResult ?? defaultResult).then(resolve);
-			}
-			if (state.currentOperation === 'select') {
-				return Promise.resolve(overrides.selectResult ?? defaultResult).then(resolve);
-			}
-			return Promise.resolve(defaultResult).then(resolve);
-		}),
-	};
-
-	return mock as unknown as SupabaseClient;
-}
-
-function createMockContext(
-	supabase: SupabaseClient,
-	options: { sessionId?: string | null } = {}
-): HandlerContext {
-	const defaultTokenUsage: TokenUsage = {
-		callCount: 5,
-		totalTokens: 2500,
-		byTool: {},
-	};
-
-	const sessionId = 'sessionId' in options ? options.sessionId : 'session-123';
-
-	return {
-		supabase,
-		auth: { userId: 'user-123', apiKeyId: 'api-key-123' },
-		session: {
-			instanceId: 'instance-abc',
-			currentSessionId: sessionId,
-			currentPersona: 'Wave',
-			tokenUsage: defaultTokenUsage,
-		},
-		updateSession: vi.fn(),
-	};
-}
+import { createMockContext } from './__test-utils__.js';
+import { mockApiClient } from './__test-setup__.js';
 
 // ============================================================================
 // getPendingRequests Tests
@@ -101,15 +12,13 @@ describe('getPendingRequests', () => {
 	beforeEach(() => vi.clearAllMocks());
 
 	it('should throw error for missing project_id', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(getPendingRequests({}, ctx)).rejects.toThrow(ValidationError);
 	});
 
 	it('should throw error for invalid project_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			getPendingRequests({ project_id: 'invalid' }, ctx)
@@ -117,11 +26,11 @@ describe('getPendingRequests', () => {
 	});
 
 	it('should return empty list when no requests', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: [], error: null },
-			sessionsResult: { data: [], error: null },
+		mockApiClient.getPendingRequests.mockResolvedValue({
+			ok: true,
+			data: { requests: [] },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await getPendingRequests(
 			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
@@ -131,7 +40,6 @@ describe('getPendingRequests', () => {
 		expect(result.result).toMatchObject({
 			requests: [],
 			count: 0,
-			questions_count: 0,
 		});
 	});
 
@@ -141,181 +49,57 @@ describe('getPendingRequests', () => {
 				id: 'r1',
 				request_type: 'task',
 				content: 'Please do this',
-				session_id: null, // broadcast
-				acknowledged_at: null,
-				created_at: '2025-01-14T10:00:00Z',
-			},
-		];
-
-		const supabase = createMockSupabase({
-			selectResult: { data: mockRequests, error: null },
-			sessionsResult: { data: [], error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		const result = await getPendingRequests(
-			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
-			ctx
-		);
-
-		expect((result.result as { count: number }).count).toBe(1);
-	});
-
-	it('should filter broadcast requests (session_id is null)', async () => {
-		const mockRequests = [
-			{
-				id: 'r1',
-				request_type: 'task',
-				content: 'Broadcast request',
 				session_id: null,
 				acknowledged_at: null,
 				created_at: '2025-01-14T10:00:00Z',
 			},
 		];
 
-		const supabase = createMockSupabase({
-			selectResult: { data: mockRequests, error: null },
-			sessionsResult: { data: [], error: null },
+		mockApiClient.getPendingRequests.mockResolvedValue({
+			ok: true,
+			data: { requests: mockRequests },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await getPendingRequests(
 			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
 			ctx
 		);
 
-		// Broadcast request should be included
 		expect((result.result as { count: number }).count).toBe(1);
 	});
 
-	it('should include requests targeted to current session', async () => {
-		const mockRequests = [
-			{
-				id: 'r1',
-				request_type: 'task',
-				content: 'Targeted request',
-				session_id: 'session-123',
-				acknowledged_at: null,
-				created_at: '2025-01-14T10:00:00Z',
-			},
-		];
-
-		const supabase = createMockSupabase({
-			selectResult: { data: mockRequests, error: null },
-			sessionsResult: { data: [], error: null },
-		});
-		const ctx = createMockContext(supabase, { sessionId: 'session-123' });
-
-		const result = await getPendingRequests(
-			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
-			ctx
-		);
-
-		expect((result.result as { count: number }).count).toBe(1);
-	});
-
-	it('should exclude requests targeted to other sessions', async () => {
-		const mockRequests = [
-			{
-				id: 'r1',
-				request_type: 'task',
-				content: 'Other session request',
-				session_id: 'other-session',
-				acknowledged_at: null,
-				created_at: '2025-01-14T10:00:00Z',
-			},
-		];
-
-		const supabase = createMockSupabase({
-			selectResult: { data: mockRequests, error: null },
-			sessionsResult: { data: [{ id: 'other-session' }], error: null },
+	it('should call API client with project_id and session_id', async () => {
+		mockApiClient.getPendingRequests.mockResolvedValue({
+			ok: true,
+			data: { requests: [] },
 		});
-		const ctx = createMockContext(supabase, { sessionId: 'session-123' });
+		const ctx = createMockContext({ sessionId: 'my-session' });
 
-		const result = await getPendingRequests(
-			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
-			ctx
-		);
-
-		// Should be excluded because targeted to an active other session
-		expect((result.result as { count: number }).count).toBe(0);
-	});
-
-	it('should count unanswered questions', async () => {
-		const mockRequests = [
-			{
-				id: 'r1',
-				request_type: 'question',
-				content: 'What is this?',
-				session_id: null,
-				acknowledged_at: null,
-				answered_at: null,
-				created_at: '2025-01-14T10:00:00Z',
-			},
-			{
-				id: 'r2',
-				request_type: 'task',
-				content: 'Do this',
-				session_id: null,
-				acknowledged_at: null,
-				created_at: '2025-01-14T11:00:00Z',
-			},
-		];
-
-		const supabase = createMockSupabase({
-			selectResult: { data: mockRequests, error: null },
-			sessionsResult: { data: [], error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		const result = await getPendingRequests(
+		await getPendingRequests(
 			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
 			ctx
 		);
 
-		expect((result.result as { questions_count: number }).questions_count).toBe(1);
-	});
-
-	it('should add wait_minutes to requests', async () => {
-		const mockRequests = [
-			{
-				id: 'r1',
-				request_type: 'task',
-				content: 'Request',
-				session_id: null,
-				acknowledged_at: null,
-				created_at: new Date(Date.now() - 5 * 60000).toISOString(), // 5 minutes ago
-			},
-		];
-
-		const supabase = createMockSupabase({
-			selectResult: { data: mockRequests, error: null },
-			sessionsResult: { data: [], error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		const result = await getPendingRequests(
-			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
-			ctx
+		expect(mockApiClient.getPendingRequests).toHaveBeenCalledWith(
+			'123e4567-e89b-12d3-a456-426614174000',
+			'my-session'
 		);
-
-		const requests = (result.result as { requests: { wait_minutes: number }[] }).requests;
-		expect(requests[0].wait_minutes).toBeGreaterThanOrEqual(4); // Allow some margin
 	});
 
-	it('should query agent_requests table', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: [], error: null },
-			sessionsResult: { data: [], error: null },
+	it('should throw error when API call fails', async () => {
+		mockApiClient.getPendingRequests.mockResolvedValue({
+			ok: false,
+			error: 'Query failed',
 		});
-		const ctx = createMockContext(supabase);
-
-		await getPendingRequests(
-			{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
-			ctx
-		);
+		const ctx = createMockContext();
 
-		expect(supabase.from).toHaveBeenCalledWith('agent_requests');
+		await expect(
+			getPendingRequests(
+				{ project_id: '123e4567-e89b-12d3-a456-426614174000' },
+				ctx
+			)
+		).rejects.toThrow('Failed to get pending requests: Query failed');
 	});
 });
 
@@ -327,15 +111,13 @@ describe('acknowledgeRequest', () => {
 	beforeEach(() => vi.clearAllMocks());
 
 	it('should throw error for missing request_id', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(acknowledgeRequest({}, ctx)).rejects.toThrow(ValidationError);
 	});
 
 	it('should throw error for invalid request_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			acknowledgeRequest({ request_id: 'invalid' }, ctx)
@@ -343,17 +125,11 @@ describe('acknowledgeRequest', () => {
 	});
 
 	it('should acknowledge request successfully', async () => {
-		const mockRequest = {
-			id: 'r1',
-			request_type: 'task',
-			content: 'Do this',
-			acknowledged_at: '2025-01-14T12:00:00Z',
-		};
-
-		const supabase = createMockSupabase({
-			updateResult: { data: mockRequest, error: null },
+		mockApiClient.acknowledgeRequest.mockResolvedValue({
+			ok: true,
+			data: { success: true },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await acknowledgeRequest(
 			{ request_id: '123e4567-e89b-12d3-a456-426614174000' },
@@ -362,52 +138,37 @@ describe('acknowledgeRequest', () => {
 
 		expect(result.result).toMatchObject({
 			success: true,
-			request: mockRequest,
 		});
 	});
 
-	it('should set acknowledged_at and acknowledged_by_session_id', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: { id: 'r1' }, error: null },
+	it('should call API client with request_id and session_id', async () => {
+		mockApiClient.acknowledgeRequest.mockResolvedValue({
+			ok: true,
+			data: { success: true },
 		});
-		const ctx = createMockContext(supabase, { sessionId: 'my-session' });
+		const ctx = createMockContext({ sessionId: 'my-session' });
 
 		await acknowledgeRequest(
 			{ request_id: '123e4567-e89b-12d3-a456-426614174000' },
 			ctx
 		);
 
-		expect(supabase.update).toHaveBeenCalledWith(
-			expect.objectContaining({
-				acknowledged_at: expect.any(String),
-				acknowledged_by_session_id: 'my-session',
-			})
-		);
-	});
-
-	it('should query agent_requests table', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: { id: 'r1' }, error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		await acknowledgeRequest(
-			{ request_id: '123e4567-e89b-12d3-a456-426614174000' },
-			ctx
+		expect(mockApiClient.acknowledgeRequest).toHaveBeenCalledWith(
+			'123e4567-e89b-12d3-a456-426614174000',
+			'my-session'
 		);
-
-		expect(supabase.from).toHaveBeenCalledWith('agent_requests');
 	});
 
-	it('should throw error when update fails', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: null, error: { message: 'Update failed' } },
+	it('should throw error when API call fails', async () => {
+		mockApiClient.acknowledgeRequest.mockResolvedValue({
+			ok: false,
+			error: 'Update failed',
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			acknowledgeRequest({ request_id: '123e4567-e89b-12d3-a456-426614174000' }, ctx)
-		).rejects.toThrow();
+		).rejects.toThrow('Failed to acknowledge request: Update failed');
 	});
 });
 
@@ -419,8 +180,7 @@ describe('answerQuestion', () => {
 	beforeEach(() => vi.clearAllMocks());
 
 	it('should throw error for missing request_id', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			answerQuestion({ answer: 'The answer' }, ctx)
@@ -428,8 +188,7 @@ describe('answerQuestion', () => {
 	});
 
 	it('should throw error for missing answer', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			answerQuestion({ request_id: '123e4567-e89b-12d3-a456-426614174000' }, ctx)
@@ -437,8 +196,7 @@ describe('answerQuestion', () => {
 	});
 
 	it('should throw error for invalid request_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			answerQuestion({ request_id: 'invalid', answer: 'The answer' }, ctx)
@@ -446,18 +204,11 @@ describe('answerQuestion', () => {
 	});
 
 	it('should answer question successfully', async () => {
-		const mockRequest = {
-			id: 'r1',
-			request_type: 'question',
-			content: 'What is this?',
-			answer: 'This is the answer',
-			answered_at: '2025-01-14T12:00:00Z',
-		};
-
-		const supabase = createMockSupabase({
-			updateResult: { data: mockRequest, error: null },
+		mockApiClient.answerQuestion.mockResolvedValue({
+			ok: true,
+			data: { success: true },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await answerQuestion(
 			{
@@ -470,15 +221,15 @@ describe('answerQuestion', () => {
 		expect(result.result).toMatchObject({
 			success: true,
 			message: 'Question answered successfully',
-			request: mockRequest,
 		});
 	});
 
-	it('should set answer, answered_at, and acknowledgment fields', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: { id: 'r1' }, error: null },
+	it('should call API client with request_id, answer, and session_id', async () => {
+		mockApiClient.answerQuestion.mockResolvedValue({
+			ok: true,
+			data: { success: true },
 		});
-		const ctx = createMockContext(supabase, { sessionId: 'my-session' });
+		const ctx = createMockContext({ sessionId: 'my-session' });
 
 		await answerQuestion(
 			{
@@ -488,44 +239,25 @@ describe('answerQuestion', () => {
 			ctx
 		);
 
-		expect(supabase.update).toHaveBeenCalledWith(
-			expect.objectContaining({
-				answer: 'The answer to the question',
-				answered_at: expect.any(String),
-				acknowledged_at: expect.any(String),
-				acknowledged_by_session_id: 'my-session',
-			})
+		expect(mockApiClient.answerQuestion).toHaveBeenCalledWith(
+			'123e4567-e89b-12d3-a456-426614174000',
+			'The answer to the question',
+			'my-session'
 		);
 	});
 
-	it('should query agent_requests table', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: { id: 'r1' }, error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		await answerQuestion(
-			{
-				request_id: '123e4567-e89b-12d3-a456-426614174000',
-				answer: 'Answer',
-			},
-			ctx
-		);
-
-		expect(supabase.from).toHaveBeenCalledWith('agent_requests');
-	});
-
-	it('should throw error when update fails', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: null, error: { message: 'Update failed' } },
+	it('should throw error when API call fails', async () => {
+		mockApiClient.answerQuestion.mockResolvedValue({
+			ok: false,
+			error: 'Update failed',
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			answerQuestion({
 				request_id: '123e4567-e89b-12d3-a456-426614174000',
 				answer: 'Answer',
 			}, ctx)
-		).rejects.toThrow();
+		).rejects.toThrow('Failed to answer question: Update failed');
 	});
 });