@vibescope/mcp-server 0.0.1 → 0.1.0

package/src/handlers/milestones.test.ts

@@ -1,6 +1,4 @@
-import { describe, it, expect, vi, beforeEach } from 'vitest';
-import type { SupabaseClient } from '@supabase/supabase-js';
-import type { HandlerContext, TokenUsage } from './types.js';
+import { describe, it, expect, beforeEach } from 'vitest';
 import {
 	addMilestone,
 	updateMilestone,
@@ -9,129 +7,18 @@ import {
 	getMilestones,
 } from './milestones.js';
 import { ValidationError } from '../validators.js';
-
-// ============================================================================
-// Test Utilities
-// ============================================================================
-
-function createMockSupabase(overrides: {
-	selectResult?: { data: unknown; error: unknown };
-	insertResult?: { data: unknown; error: unknown };
-	updateResult?: { data: unknown; error: unknown };
-	deleteResult?: { data: unknown; error: unknown };
-} = {}) {
-	const defaultResult = { data: null, error: null };
-	let currentOperation = 'select';
-	let insertThenSelect = false;
-
-	const mock = {
-		from: vi.fn().mockReturnThis(),
-		select: vi.fn(() => {
-			if (currentOperation === 'insert' || currentOperation === 'update') {
-				insertThenSelect = true;
-			} else {
-				currentOperation = 'select';
-				insertThenSelect = false;
-			}
-			return mock;
-		}),
-		insert: vi.fn(() => {
-			currentOperation = 'insert';
-			insertThenSelect = false;
-			return mock;
-		}),
-		update: vi.fn(() => {
-			currentOperation = 'update';
-			insertThenSelect = false;
-			return mock;
-		}),
-		delete: vi.fn(() => {
-			currentOperation = 'delete';
-			insertThenSelect = false;
-			return mock;
-		}),
-		eq: vi.fn().mockReturnThis(),
-		neq: vi.fn().mockReturnThis(),
-		in: vi.fn().mockReturnThis(),
-		is: vi.fn().mockReturnThis(),
-		not: vi.fn().mockReturnThis(),
-		or: vi.fn().mockReturnThis(),
-		gt: vi.fn().mockReturnThis(),
-		gte: vi.fn().mockReturnThis(),
-		lte: vi.fn().mockReturnThis(),
-		lt: vi.fn().mockReturnThis(),
-		order: vi.fn().mockReturnThis(),
-		limit: vi.fn().mockReturnThis(),
-		single: vi.fn(() => {
-			if (currentOperation === 'insert' || insertThenSelect) {
-				return Promise.resolve(overrides.insertResult ?? defaultResult);
-			}
-			if (currentOperation === 'select') {
-				return Promise.resolve(overrides.selectResult ?? defaultResult);
-			}
-			if (currentOperation === 'update') {
-				return Promise.resolve(overrides.updateResult ?? defaultResult);
-			}
-			return Promise.resolve(defaultResult);
-		}),
-		maybeSingle: vi.fn(() => {
-			return Promise.resolve(overrides.selectResult ?? defaultResult);
-		}),
-		then: vi.fn((resolve: (value: unknown) => void) => {
-			if (currentOperation === 'insert' || insertThenSelect) {
-				return Promise.resolve(overrides.insertResult ?? defaultResult).then(resolve);
-			}
-			if (currentOperation === 'select') {
-				return Promise.resolve(overrides.selectResult ?? defaultResult).then(resolve);
-			}
-			if (currentOperation === 'update') {
-				return Promise.resolve(overrides.updateResult ?? defaultResult).then(resolve);
-			}
-			if (currentOperation === 'delete') {
-				return Promise.resolve(overrides.deleteResult ?? defaultResult).then(resolve);
-			}
-			return Promise.resolve(defaultResult).then(resolve);
-		}),
-	};
-
-	return mock as unknown as SupabaseClient;
-}
-
-function createMockContext(
-	supabase: SupabaseClient,
-	options: { sessionId?: string | null } = {}
-): HandlerContext {
-	const defaultTokenUsage: TokenUsage = {
-		callCount: 5,
-		totalTokens: 2500,
-		byTool: {},
-	};
-
-	const sessionId = 'sessionId' in options ? options.sessionId : 'session-123';
-
-	return {
-		supabase,
-		auth: { userId: 'user-123', apiKeyId: 'api-key-123' },
-		session: {
-			instanceId: 'instance-abc',
-			currentSessionId: sessionId,
-			currentPersona: 'Wave',
-			tokenUsage: defaultTokenUsage,
-		},
-		updateSession: vi.fn(),
-	};
-}
+import { createMockContext } from './__test-utils__.js';
+import { mockApiClient } from './__test-setup__.js';
 
 // ============================================================================
 // addMilestone Tests
 // ============================================================================
 
 describe('addMilestone', () => {
-	beforeEach(() => vi.clearAllMocks());
+	beforeEach(() => mockApiClient.addMilestone.mockReset());
 
 	it('should throw error for missing task_id', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			addMilestone({ title: 'Milestone 1' }, ctx)
@@ -139,8 +26,7 @@ describe('addMilestone', () => {
 	});
 
 	it('should throw error for invalid task_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			addMilestone({ task_id: 'invalid', title: 'Milestone 1' }, ctx)
@@ -148,42 +34,19 @@ describe('addMilestone', () => {
 	});
 
 	it('should throw error for missing title', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			addMilestone({ task_id: '123e4567-e89b-12d3-a456-426614174000' }, ctx)
 		).rejects.toThrow(ValidationError);
 	});
 
-	it('should throw error when task not found', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: null, error: { message: 'Not found' } },
-		});
-		const ctx = createMockContext(supabase);
-
-		await expect(
-			addMilestone({
-				task_id: '123e4567-e89b-12d3-a456-426614174000',
-				title: 'Milestone 1',
-			}, ctx)
-		).rejects.toThrow('Task not found');
-	});
-
 	it('should add milestone successfully', async () => {
-		const mockMilestone = {
-			id: 'milestone-1',
-			task_id: '123e4567-e89b-12d3-a456-426614174000',
-			title: 'First Milestone',
-			order_index: 0,
-			status: 'pending',
-		};
-
-		const supabase = createMockSupabase({
-			selectResult: { data: { id: 'task-1', project_id: 'proj-1' }, error: null },
-			insertResult: { data: mockMilestone, error: null },
+		mockApiClient.addMilestone.mockResolvedValue({
+			ok: true,
+			data: { milestone_id: 'milestone-1' },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await addMilestone(
 			{
@@ -195,54 +58,51 @@ describe('addMilestone', () => {
 
 		expect(result.result).toMatchObject({
 			success: true,
-			milestone: mockMilestone,
+			milestone_id: 'milestone-1',
 		});
 	});
 
-	it('should use provided order_index', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: { id: 'task-1', project_id: 'proj-1' }, error: null },
-			insertResult: { data: { id: 'milestone-1', order_index: 5 }, error: null },
+	it('should call API client with correct parameters', async () => {
+		mockApiClient.addMilestone.mockResolvedValue({
+			ok: true,
+			data: { milestone_id: 'milestone-1' },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await addMilestone(
 			{
 				task_id: '123e4567-e89b-12d3-a456-426614174000',
 				title: 'Test Milestone',
+				description: 'A test milestone',
 				order_index: 5,
 			},
 			ctx
 		);
 
-		expect(supabase.insert).toHaveBeenCalledWith(
-			expect.objectContaining({
+		expect(mockApiClient.addMilestone).toHaveBeenCalledWith(
+			'123e4567-e89b-12d3-a456-426614174000',
+			{
+				title: 'Test Milestone',
+				description: 'A test milestone',
 				order_index: 5,
-			})
+			},
+			'session-123'
 		);
 	});
 
-	it('should include session_id in insert', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: { id: 'task-1', project_id: 'proj-1' }, error: null },
-			insertResult: { data: { id: 'milestone-1' }, error: null },
+	it('should throw error when API call fails', async () => {
+		mockApiClient.addMilestone.mockResolvedValue({
+			ok: false,
+			error: 'Task not found',
 		});
-		const ctx = createMockContext(supabase, { sessionId: 'my-session' });
+		const ctx = createMockContext();
 
-		await addMilestone(
-			{
+		await expect(
+			addMilestone({
 				task_id: '123e4567-e89b-12d3-a456-426614174000',
-				title: 'Test',
-			},
-			ctx
-		);
-
-		expect(supabase.insert).toHaveBeenCalledWith(
-			expect.objectContaining({
-				created_by: 'agent',
-				created_by_session_id: 'my-session',
-			})
-		);
+				title: 'Milestone 1',
+			}, ctx)
+		).rejects.toThrow('Failed to add milestone: Task not found');
 	});
 });
 
@@ -251,18 +111,16 @@ describe('addMilestone', () => {
 // ============================================================================
 
 describe('updateMilestone', () => {
-	beforeEach(() => vi.clearAllMocks());
+	beforeEach(() => mockApiClient.updateMilestone.mockReset());
 
 	it('should throw error for missing milestone_id', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(updateMilestone({}, ctx)).rejects.toThrow(ValidationError);
 	});
 
 	it('should throw error for invalid milestone_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			updateMilestone({ milestone_id: 'invalid', title: 'New Title' }, ctx)
@@ -270,8 +128,7 @@ describe('updateMilestone', () => {
 	});
 
 	it('should throw error when no fields to update', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			updateMilestone({ milestone_id: '123e4567-e89b-12d3-a456-426614174000' }, ctx)
@@ -279,8 +136,7 @@ describe('updateMilestone', () => {
 	});
 
 	it('should throw error for invalid status', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			updateMilestone({
@@ -291,10 +147,11 @@ describe('updateMilestone', () => {
 	});
 
 	it('should update title successfully', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: { id: 'milestone-1', title: 'Updated Title' }, error: null },
+		mockApiClient.updateMilestone.mockResolvedValue({
+			ok: true,
+			data: { milestone: { id: 'milestone-1', title: 'Updated Title' } },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await updateMilestone(
 			{
@@ -309,11 +166,12 @@ describe('updateMilestone', () => {
 		});
 	});
 
-	it('should set completed_at when status is completed', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: { id: 'milestone-1', status: 'completed' }, error: null },
+	it('should call API client with correct parameters', async () => {
+		mockApiClient.updateMilestone.mockResolvedValue({
+			ok: true,
+			data: { milestone: { id: 'milestone-1', status: 'completed' } },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await updateMilestone(
 			{
@@ -323,34 +181,30 @@ describe('updateMilestone', () => {
 			ctx
 		);
 
-		expect(supabase.update).toHaveBeenCalledWith(
-			expect.objectContaining({
+		expect(mockApiClient.updateMilestone).toHaveBeenCalledWith(
+			'123e4567-e89b-12d3-a456-426614174000',
+			{
+				title: undefined,
+				description: undefined,
 				status: 'completed',
-				completed_at: expect.any(String),
-			})
+				order_index: undefined,
+			}
 		);
 	});
 
-	it('should clear completed_at when status is not completed', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: { id: 'milestone-1', status: 'in_progress' }, error: null },
+	it('should throw error when API call fails', async () => {
+		mockApiClient.updateMilestone.mockResolvedValue({
+			ok: false,
+			error: 'Milestone not found',
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
-		await updateMilestone(
-			{
+		await expect(
+			updateMilestone({
 				milestone_id: '123e4567-e89b-12d3-a456-426614174000',
-				status: 'in_progress',
-			},
-			ctx
-		);
-
-		expect(supabase.update).toHaveBeenCalledWith(
-			expect.objectContaining({
-				status: 'in_progress',
-				completed_at: null,
-			})
-		);
+				title: 'New Title',
+			}, ctx)
+		).rejects.toThrow('Failed to update milestone: Milestone not found');
 	});
 });
 
@@ -359,18 +213,16 @@ describe('updateMilestone', () => {
 // ============================================================================
 
 describe('completeMilestone', () => {
-	beforeEach(() => vi.clearAllMocks());
+	beforeEach(() => mockApiClient.completeMilestone.mockReset());
 
 	it('should throw error for missing milestone_id', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(completeMilestone({}, ctx)).rejects.toThrow(ValidationError);
 	});
 
 	it('should throw error for invalid milestone_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			completeMilestone({ milestone_id: 'invalid' }, ctx)
@@ -378,13 +230,11 @@ describe('completeMilestone', () => {
 	});
 
 	it('should complete milestone successfully', async () => {
-		const supabase = createMockSupabase({
-			updateResult: {
-				data: { id: 'milestone-1', status: 'completed', completed_at: '2025-01-14T12:00:00Z' },
-				error: null,
-			},
+		mockApiClient.completeMilestone.mockResolvedValue({
+			ok: true,
+			data: { milestone: { id: 'milestone-1', status: 'completed' } },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await completeMilestone(
 			{ milestone_id: '123e4567-e89b-12d3-a456-426614174000' },
@@ -396,24 +246,34 @@ describe('completeMilestone', () => {
 		});
 	});
 
-	it('should set status to completed with timestamp', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: { id: 'milestone-1' }, error: null },
+	it('should call API client completeMilestone', async () => {
+		mockApiClient.completeMilestone.mockResolvedValue({
+			ok: true,
+			data: { milestone: { id: 'milestone-1' } },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await completeMilestone(
 			{ milestone_id: '123e4567-e89b-12d3-a456-426614174000' },
 			ctx
 		);
 
-		expect(supabase.update).toHaveBeenCalledWith(
-			expect.objectContaining({
-				status: 'completed',
-				completed_at: expect.any(String),
-			})
+		expect(mockApiClient.completeMilestone).toHaveBeenCalledWith(
+			'123e4567-e89b-12d3-a456-426614174000'
 		);
 	});
+
+	it('should throw error when API call fails', async () => {
+		mockApiClient.completeMilestone.mockResolvedValue({
+			ok: false,
+			error: 'Milestone not found',
+		});
+		const ctx = createMockContext();
+
+		await expect(
+			completeMilestone({ milestone_id: '123e4567-e89b-12d3-a456-426614174000' }, ctx)
+		).rejects.toThrow('Failed to complete milestone: Milestone not found');
+	});
 });
 
 // ============================================================================
@@ -421,18 +281,16 @@ describe('completeMilestone', () => {
 // ============================================================================
 
 describe('deleteMilestone', () => {
-	beforeEach(() => vi.clearAllMocks());
+	beforeEach(() => mockApiClient.deleteMilestone.mockReset());
 
 	it('should throw error for missing milestone_id', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(deleteMilestone({}, ctx)).rejects.toThrow(ValidationError);
 	});
 
 	it('should throw error for invalid milestone_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			deleteMilestone({ milestone_id: 'invalid' }, ctx)
@@ -440,10 +298,11 @@ describe('deleteMilestone', () => {
 	});
 
 	it('should delete milestone successfully', async () => {
-		const supabase = createMockSupabase({
-			deleteResult: { data: null, error: null },
+		mockApiClient.deleteMilestone.mockResolvedValue({
+			ok: true,
+			data: { success: true },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await deleteMilestone(
 			{ milestone_id: '123e4567-e89b-12d3-a456-426614174000' },
@@ -456,19 +315,33 @@ describe('deleteMilestone', () => {
 		});
 	});
 
-	it('should call delete on task_milestones table', async () => {
-		const supabase = createMockSupabase({
-			deleteResult: { data: null, error: null },
+	it('should call API client deleteMilestone', async () => {
+		mockApiClient.deleteMilestone.mockResolvedValue({
+			ok: true,
+			data: { success: true },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await deleteMilestone(
 			{ milestone_id: '123e4567-e89b-12d3-a456-426614174000' },
 			ctx
 		);
 
-		expect(supabase.from).toHaveBeenCalledWith('task_milestones');
-		expect(supabase.delete).toHaveBeenCalled();
+		expect(mockApiClient.deleteMilestone).toHaveBeenCalledWith(
+			'123e4567-e89b-12d3-a456-426614174000'
+		);
+	});
+
+	it('should throw error when API call fails', async () => {
+		mockApiClient.deleteMilestone.mockResolvedValue({
+			ok: false,
+			error: 'Milestone not found',
+		});
+		const ctx = createMockContext();
+
+		await expect(
+			deleteMilestone({ milestone_id: '123e4567-e89b-12d3-a456-426614174000' }, ctx)
+		).rejects.toThrow('Failed to delete milestone: Milestone not found');
 	});
 });
 
@@ -477,18 +350,16 @@ describe('deleteMilestone', () => {
 // ============================================================================
 
 describe('getMilestones', () => {
-	beforeEach(() => vi.clearAllMocks());
+	beforeEach(() => mockApiClient.getMilestones.mockReset());
 
 	it('should throw error for missing task_id', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(getMilestones({}, ctx)).rejects.toThrow(ValidationError);
 	});
 
 	it('should throw error for invalid task_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			getMilestones({ task_id: 'invalid' }, ctx)
@@ -496,10 +367,20 @@ describe('getMilestones', () => {
 	});
 
 	it('should return empty list with zero stats', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: [], error: null },
+		mockApiClient.getMilestones.mockResolvedValue({
+			ok: true,
+			data: {
+				milestones: [],
+				stats: {
+					total: 0,
+					completed: 0,
+					in_progress: 0,
+					pending: 0,
+					progress_percentage: 0,
+				},
+			},
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await getMilestones(
 			{ task_id: '123e4567-e89b-12d3-a456-426614174000' },
@@ -518,7 +399,7 @@ describe('getMilestones', () => {
 		});
 	});
 
-	it('should return milestones with stats', async () => {
+	it('should return milestones with stats from API', async () => {
 		const mockMilestones = [
 			{ id: 'm1', title: 'Step 1', status: 'completed', order_index: 0 },
 			{ id: 'm2', title: 'Step 2', status: 'in_progress', order_index: 1 },
@@ -526,10 +407,20 @@ describe('getMilestones', () => {
 			{ id: 'm4', title: 'Step 4', status: 'pending', order_index: 3 },
 		];
 
-		const supabase = createMockSupabase({
-			selectResult: { data: mockMilestones, error: null },
+		mockApiClient.getMilestones.mockResolvedValue({
+			ok: true,
+			data: {
+				milestones: mockMilestones,
+				stats: {
+					total: 4,
+					completed: 1,
+					in_progress: 1,
+					pending: 2,
+					progress_percentage: 25,
+				},
+			},
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await getMilestones(
 			{ task_id: '123e4567-e89b-12d3-a456-426614174000' },
@@ -543,42 +434,37 @@ describe('getMilestones', () => {
 				completed: 1,
 				in_progress: 1,
 				pending: 2,
-				progress_percentage: 25, // 1/4 = 25%
+				progress_percentage: 25,
 			},
 		});
 	});
 
-	it('should calculate 100% when all completed', async () => {
-		const mockMilestones = [
-			{ id: 'm1', status: 'completed' },
-			{ id: 'm2', status: 'completed' },
-		];
-
-		const supabase = createMockSupabase({
-			selectResult: { data: mockMilestones, error: null },
+	it('should call API client getMilestones', async () => {
+		mockApiClient.getMilestones.mockResolvedValue({
+			ok: true,
+			data: { milestones: [], stats: {} },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
-		const result = await getMilestones(
+		await getMilestones(
 			{ task_id: '123e4567-e89b-12d3-a456-426614174000' },
 			ctx
 		);
 
-		expect((result.result as { stats: { progress_percentage: number } }).stats.progress_percentage).toBe(100);
+		expect(mockApiClient.getMilestones).toHaveBeenCalledWith(
+			'123e4567-e89b-12d3-a456-426614174000'
+		);
 	});
 
-	it('should query task_milestones table ordered by order_index', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: [], error: null },
+	it('should throw error when API call fails', async () => {
+		mockApiClient.getMilestones.mockResolvedValue({
+			ok: false,
+			error: 'Task not found',
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
-		await getMilestones(
-			{ task_id: '123e4567-e89b-12d3-a456-426614174000' },
-			ctx
-		);
-
-		expect(supabase.from).toHaveBeenCalledWith('task_milestones');
-		expect(supabase.order).toHaveBeenCalledWith('order_index', { ascending: true });
+		await expect(
+			getMilestones({ task_id: '123e4567-e89b-12d3-a456-426614174000' }, ctx)
+		).rejects.toThrow('Failed to get milestones: Task not found');
 	});
 });