@vibescope/mcp-server 0.0.1 → 0.1.0

package/src/handlers/findings.test.ts

@@ -1,6 +1,4 @@
 import { describe, it, expect, vi, beforeEach } from 'vitest';
-import type { SupabaseClient } from '@supabase/supabase-js';
-import type { HandlerContext, TokenUsage } from './types.js';
 import {
 	addFinding,
 	getFindings,
@@ -8,109 +6,8 @@ import {
 	deleteFinding,
 } from './findings.js';
 import { ValidationError } from '../validators.js';
-
-// ============================================================================
-// Test Utilities
-// ============================================================================
-
-function createMockSupabase(overrides: {
-	selectResult?: { data: unknown; error: unknown };
-	insertResult?: { data: unknown; error: unknown };
-	updateResult?: { data: unknown; error: unknown };
-	deleteResult?: { data: unknown; error: unknown };
-} = {}) {
-	const defaultResult = { data: null, error: null };
-	let currentOperation = 'select';
-	let insertThenSelect = false;
-
-	const mock = {
-		from: vi.fn().mockReturnThis(),
-		select: vi.fn(() => {
-			if (currentOperation === 'insert') {
-				insertThenSelect = true;
-			} else {
-				currentOperation = 'select';
-				insertThenSelect = false;
-			}
-			return mock;
-		}),
-		insert: vi.fn(() => {
-			currentOperation = 'insert';
-			insertThenSelect = false;
-			return mock;
-		}),
-		update: vi.fn(() => {
-			currentOperation = 'update';
-			insertThenSelect = false;
-			return mock;
-		}),
-		delete: vi.fn(() => {
-			currentOperation = 'delete';
-			insertThenSelect = false;
-			return mock;
-		}),
-		eq: vi.fn().mockReturnThis(),
-		neq: vi.fn().mockReturnThis(),
-		in: vi.fn().mockReturnThis(),
-		is: vi.fn().mockReturnThis(),
-		order: vi.fn().mockReturnThis(),
-		limit: vi.fn().mockReturnThis(),
-		single: vi.fn(() => {
-			if (currentOperation === 'insert' || insertThenSelect) {
-				return Promise.resolve(overrides.insertResult ?? defaultResult);
-			}
-			if (currentOperation === 'select') {
-				return Promise.resolve(overrides.selectResult ?? defaultResult);
-			}
-			if (currentOperation === 'update') {
-				return Promise.resolve(overrides.updateResult ?? defaultResult);
-			}
-			return Promise.resolve(defaultResult);
-		}),
-		then: vi.fn((resolve: (value: unknown) => void) => {
-			if (currentOperation === 'insert' || insertThenSelect) {
-				return Promise.resolve(overrides.insertResult ?? defaultResult).then(resolve);
-			}
-			if (currentOperation === 'select') {
-				return Promise.resolve(overrides.selectResult ?? defaultResult).then(resolve);
-			}
-			if (currentOperation === 'update') {
-				return Promise.resolve(overrides.updateResult ?? defaultResult).then(resolve);
-			}
-			if (currentOperation === 'delete') {
-				return Promise.resolve(overrides.deleteResult ?? defaultResult).then(resolve);
-			}
-			return Promise.resolve(defaultResult).then(resolve);
-		}),
-	};
-
-	return mock as unknown as SupabaseClient;
-}
-
-function createMockContext(
-	supabase: SupabaseClient,
-	options: { sessionId?: string | null } = {}
-): HandlerContext {
-	const defaultTokenUsage: TokenUsage = {
-		callCount: 5,
-		totalTokens: 2500,
-		byTool: {},
-	};
-
-	const sessionId = 'sessionId' in options ? options.sessionId : 'session-123';
-
-	return {
-		supabase,
-		auth: { userId: 'user-123', apiKeyId: 'api-key-123' },
-		session: {
-			instanceId: 'instance-abc',
-			currentSessionId: sessionId,
-			currentPersona: 'Wave',
-			tokenUsage: defaultTokenUsage,
-		},
-		updateSession: vi.fn(),
-	};
-}
+import { createMockContext } from './__test-utils__.js';
+import { mockApiClient } from './__test-setup__.js';
 
 const VALID_UUID = '123e4567-e89b-12d3-a456-426614174000';
 const VALID_UUID_2 = '223e4567-e89b-12d3-a456-426614174001';
@@ -123,15 +20,13 @@ describe('addFinding', () => {
 	beforeEach(() => vi.clearAllMocks());
 
 	it('should throw error for missing project_id', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(addFinding({ title: 'Test Finding' }, ctx)).rejects.toThrow(ValidationError);
 	});
 
 	it('should throw error for invalid project_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			addFinding({ project_id: 'invalid', title: 'Test' }, ctx)
@@ -139,8 +34,7 @@ describe('addFinding', () => {
 	});
 
 	it('should throw error for missing title', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			addFinding({ project_id: VALID_UUID }, ctx)
@@ -148,19 +42,19 @@ describe('addFinding', () => {
 	});
 
 	it('should throw error for invalid related_task_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			addFinding({ project_id: VALID_UUID, title: 'Test', related_task_id: 'invalid' }, ctx)
 		).rejects.toThrow(ValidationError);
 	});
 
-	it('should create finding with required fields and defaults', async () => {
-		const supabase = createMockSupabase({
-			insertResult: { data: { id: 'finding-1' }, error: null },
+	it('should create finding with required fields', async () => {
+		mockApiClient.addFinding.mockResolvedValue({
+			ok: true,
+			data: { success: true, finding_id: 'finding-1', title: 'Performance issue' },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await addFinding(
 			{ project_id: VALID_UUID, title: 'Performance issue' },
@@ -172,27 +66,14 @@ describe('addFinding', () => {
 			finding_id: 'finding-1',
 			title: 'Performance issue',
 		});
-		expect(supabase.from).toHaveBeenCalledWith('findings');
-		expect(supabase.insert).toHaveBeenCalledWith(
-			expect.objectContaining({
-				project_id: VALID_UUID,
-				title: 'Performance issue',
-				category: 'other',
-				severity: 'info',
-				description: null,
-				file_path: null,
-				line_number: null,
-				related_task_id: null,
-				created_by: 'agent',
-			})
-		);
 	});
 
-	it('should create finding with all optional fields', async () => {
-		const supabase = createMockSupabase({
-			insertResult: { data: { id: 'finding-2' }, error: null },
+	it('should call API client with all parameters', async () => {
+		mockApiClient.addFinding.mockResolvedValue({
+			ok: true,
+			data: { success: true, finding_id: 'finding-2' },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext({ sessionId: 'my-session' });
 
 		await addFinding(
 			{
@@ -208,8 +89,9 @@ describe('addFinding', () => {
 			ctx
 		);
 
-		expect(supabase.insert).toHaveBeenCalledWith(
-			expect.objectContaining({
+		expect(mockApiClient.addFinding).toHaveBeenCalledWith(
+			VALID_UUID,
+			{
 				title: 'SQL Injection vulnerability',
 				description: 'User input not sanitized',
 				category: 'security',
@@ -217,19 +99,21 @@ describe('addFinding', () => {
 				file_path: 'src/api/users.ts',
 				line_number: 42,
 				related_task_id: VALID_UUID_2,
-			})
+			},
+			'my-session'
 		);
 	});
 
-	it('should throw error when database insert fails', async () => {
-		const supabase = createMockSupabase({
-			insertResult: { data: null, error: { message: 'Insert failed' } },
+	it('should throw error when API call fails', async () => {
+		mockApiClient.addFinding.mockResolvedValue({
+			ok: false,
+			error: 'Insert failed',
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			addFinding({ project_id: VALID_UUID, title: 'Test' }, ctx)
-		).rejects.toThrow('Failed to add finding');
+		).rejects.toThrow('Insert failed');
 	});
 });
 
@@ -241,15 +125,13 @@ describe('getFindings', () => {
 	beforeEach(() => vi.clearAllMocks());
 
 	it('should throw error for missing project_id', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(getFindings({}, ctx)).rejects.toThrow(ValidationError);
 	});
 
 	it('should throw error for invalid project_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			getFindings({ project_id: 'invalid' }, ctx)
@@ -261,83 +143,68 @@ describe('getFindings', () => {
 			{ id: 'f1', title: 'Finding 1', category: 'security', severity: 'high', status: 'open', file_path: null, created_at: '2026-01-14' },
 			{ id: 'f2', title: 'Finding 2', category: 'performance', severity: 'medium', status: 'addressed', file_path: 'src/app.ts', created_at: '2026-01-13' },
 		];
-
-		const supabase = createMockSupabase({
-			selectResult: { data: mockFindings, error: null },
+		mockApiClient.getFindings.mockResolvedValue({
+			ok: true,
+			data: { findings: mockFindings },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await getFindings({ project_id: VALID_UUID }, ctx);
 
 		expect(result.result).toMatchObject({ findings: mockFindings });
-		expect(supabase.from).toHaveBeenCalledWith('findings');
-		expect(supabase.eq).toHaveBeenCalledWith('project_id', VALID_UUID);
-	});
-
-	it('should filter by category when provided', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: [], error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		await getFindings({ project_id: VALID_UUID, category: 'security' }, ctx);
-
-		expect(supabase.eq).toHaveBeenCalledWith('category', 'security');
-	});
-
-	it('should filter by severity when provided', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: [], error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		await getFindings({ project_id: VALID_UUID, severity: 'critical' }, ctx);
-
-		expect(supabase.eq).toHaveBeenCalledWith('severity', 'critical');
 	});
 
-	it('should filter by status when provided', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: [], error: null },
+	it('should pass filters to API client', async () => {
+		mockApiClient.getFindings.mockResolvedValue({
+			ok: true,
+			data: { findings: [] },
 		});
-		const ctx = createMockContext(supabase);
-
-		await getFindings({ project_id: VALID_UUID, status: 'open' }, ctx);
-
-		expect(supabase.eq).toHaveBeenCalledWith('status', 'open');
-	});
-
-	it('should use custom limit when provided', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: [], error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		await getFindings({ project_id: VALID_UUID, limit: 10 }, ctx);
-
-		expect(supabase.limit).toHaveBeenCalledWith(10);
+		const ctx = createMockContext();
+
+		await getFindings({
+			project_id: VALID_UUID,
+			category: 'security',
+			severity: 'critical',
+			status: 'open',
+			limit: 10
+		}, ctx);
+
+		expect(mockApiClient.getFindings).toHaveBeenCalledWith(
+			VALID_UUID,
+			{
+				category: 'security',
+				severity: 'critical',
+				status: 'open',
+				limit: 10,
+			}
+		);
 	});
 
 	it('should use default limit of 50', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: [], error: null },
+		mockApiClient.getFindings.mockResolvedValue({
+			ok: true,
+			data: { findings: [] },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await getFindings({ project_id: VALID_UUID }, ctx);
 
-		expect(supabase.limit).toHaveBeenCalledWith(50);
+		expect(mockApiClient.getFindings).toHaveBeenCalledWith(
+			VALID_UUID,
+			expect.objectContaining({ limit: 50 })
+		);
 	});
 
-	it('should throw error when database query fails', async () => {
-		const supabase = createMockSupabase({
-			selectResult: { data: null, error: { message: 'Query failed' } },
+	it('should throw error when API call fails', async () => {
+		mockApiClient.getFindings.mockResolvedValue({
+			ok: false,
+			error: 'Query failed',
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			getFindings({ project_id: VALID_UUID }, ctx)
-		).rejects.toThrow('Failed to get findings');
+		).rejects.toThrow('Query failed');
 	});
 });
 
@@ -349,15 +216,13 @@ describe('updateFinding', () => {
 	beforeEach(() => vi.clearAllMocks());
 
 	it('should throw error for missing finding_id', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(updateFinding({}, ctx)).rejects.toThrow(ValidationError);
 	});
 
 	it('should throw error for invalid finding_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			updateFinding({ finding_id: 'invalid' }, ctx)
@@ -365,10 +230,11 @@ describe('updateFinding', () => {
 	});
 
 	it('should update title', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: null, error: null },
+		mockApiClient.updateFinding.mockResolvedValue({
+			ok: true,
+			data: { success: true, finding_id: VALID_UUID },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await updateFinding(
 			{ finding_id: VALID_UUID, title: 'Updated Title' },
@@ -376,142 +242,49 @@ describe('updateFinding', () => {
 		);
 
 		expect(result.result).toMatchObject({ success: true, finding_id: VALID_UUID });
-		expect(supabase.update).toHaveBeenCalledWith(
-			expect.objectContaining({ title: 'Updated Title' })
-		);
 	});
 
-	it('should update severity', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: null, error: null },
+	it('should call API client with all update fields', async () => {
+		mockApiClient.updateFinding.mockResolvedValue({
+			ok: true,
+			data: { success: true },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await updateFinding(
-			{ finding_id: VALID_UUID, severity: 'high' },
-			ctx
-		);
-
-		expect(supabase.update).toHaveBeenCalledWith(
-			expect.objectContaining({ severity: 'high' })
-		);
-	});
-
-	it('should set addressed_at when status changed to addressed', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: null, error: null },
-		});
-		const ctx = createMockContext(supabase, { sessionId: 'resolver-session' });
-
-		await updateFinding(
-			{ finding_id: VALID_UUID, status: 'addressed' },
-			ctx
-		);
-
-		expect(supabase.update).toHaveBeenCalledWith(
-			expect.objectContaining({
+			{
+				finding_id: VALID_UUID,
+				title: 'New Title',
+				description: 'New description',
+				severity: 'high',
 				status: 'addressed',
-				addressed_at: expect.any(String),
-				addressed_by_session_id: 'resolver-session',
-			})
-		);
-	});
-
-	it('should set addressed_at when status changed to dismissed', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: null, error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		await updateFinding(
-			{ finding_id: VALID_UUID, status: 'dismissed' },
-			ctx
-		);
-
-		expect(supabase.update).toHaveBeenCalledWith(
-			expect.objectContaining({
-				status: 'dismissed',
-				addressed_at: expect.any(String),
-			})
-		);
-	});
-
-	it('should set addressed_at when status changed to wontfix', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: null, error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		await updateFinding(
-			{ finding_id: VALID_UUID, status: 'wontfix' },
-			ctx
-		);
-
-		expect(supabase.update).toHaveBeenCalledWith(
-			expect.objectContaining({
-				status: 'wontfix',
-				addressed_at: expect.any(String),
-			})
-		);
-	});
-
-	it('should not set addressed_at when status changed to open', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: null, error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		await updateFinding(
-			{ finding_id: VALID_UUID, status: 'open' },
-			ctx
-		);
-
-		const updateCall = vi.mocked(supabase.update).mock.calls[0][0] as Record<string, unknown>;
-		expect(updateCall.status).toBe('open');
-		expect(updateCall.addressed_at).toBeUndefined();
-	});
-
-	it('should update resolution_note', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: null, error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		await updateFinding(
-			{ finding_id: VALID_UUID, resolution_note: 'Fixed by sanitizing input' },
-			ctx
-		);
-
-		expect(supabase.update).toHaveBeenCalledWith(
-			expect.objectContaining({ resolution_note: 'Fixed by sanitizing input' })
-		);
-	});
-
-	it('should always update updated_at timestamp', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: null, error: null },
-		});
-		const ctx = createMockContext(supabase);
-
-		await updateFinding(
-			{ finding_id: VALID_UUID, title: 'Test' },
+				resolution_note: 'Fixed by sanitizing input'
+			},
 			ctx
 		);
 
-		expect(supabase.update).toHaveBeenCalledWith(
-			expect.objectContaining({ updated_at: expect.any(String) })
+		expect(mockApiClient.updateFinding).toHaveBeenCalledWith(
+			VALID_UUID,
+			{
+				title: 'New Title',
+				description: 'New description',
+				severity: 'high',
+				status: 'addressed',
+				resolution_note: 'Fixed by sanitizing input',
+			}
 		);
 	});
 
-	it('should throw error when database update fails', async () => {
-		const supabase = createMockSupabase({
-			updateResult: { data: null, error: { message: 'Update failed' } },
+	it('should throw error when API call fails', async () => {
+		mockApiClient.updateFinding.mockResolvedValue({
+			ok: false,
+			error: 'Update failed',
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			updateFinding({ finding_id: VALID_UUID, title: 'Test' }, ctx)
-		).rejects.toThrow('Failed to update finding');
+		).rejects.toThrow('Update failed');
 	});
 });
 
@@ -523,15 +296,13 @@ describe('deleteFinding', () => {
 	beforeEach(() => vi.clearAllMocks());
 
 	it('should throw error for missing finding_id', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(deleteFinding({}, ctx)).rejects.toThrow(ValidationError);
 	});
 
 	it('should throw error for invalid finding_id UUID', async () => {
-		const supabase = createMockSupabase();
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			deleteFinding({ finding_id: 'invalid' }, ctx)
@@ -539,27 +310,38 @@ describe('deleteFinding', () => {
 	});
 
 	it('should delete finding successfully', async () => {
-		const supabase = createMockSupabase({
-			deleteResult: { data: null, error: null },
+		mockApiClient.deleteFinding.mockResolvedValue({
+			ok: true,
+			data: { success: true },
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		const result = await deleteFinding({ finding_id: VALID_UUID }, ctx);
 
 		expect(result.result).toMatchObject({ success: true });
-		expect(supabase.from).toHaveBeenCalledWith('findings');
-		expect(supabase.delete).toHaveBeenCalled();
-		expect(supabase.eq).toHaveBeenCalledWith('id', VALID_UUID);
 	});
 
-	it('should throw error when database delete fails', async () => {
-		const supabase = createMockSupabase({
-			deleteResult: { data: null, error: { message: 'Delete failed' } },
+	it('should call API client deleteFinding', async () => {
+		mockApiClient.deleteFinding.mockResolvedValue({
+			ok: true,
+			data: { success: true },
+		});
+		const ctx = createMockContext();
+
+		await deleteFinding({ finding_id: VALID_UUID }, ctx);
+
+		expect(mockApiClient.deleteFinding).toHaveBeenCalledWith(VALID_UUID);
+	});
+
+	it('should throw error when API call fails', async () => {
+		mockApiClient.deleteFinding.mockResolvedValue({
+			ok: false,
+			error: 'Delete failed',
 		});
-		const ctx = createMockContext(supabase);
+		const ctx = createMockContext();
 
 		await expect(
 			deleteFinding({ finding_id: VALID_UUID }, ctx)
-		).rejects.toThrow('Failed to delete finding');
+		).rejects.toThrow('Delete failed');
 	});
 });