@vellumai/assistant 0.7.2 → 0.8.0

package/src/workspace/migrations/071-remove-safe-storage-release-note.ts

@@ -0,0 +1,111 @@
+import { existsSync, readFileSync, rmSync, writeFileSync } from "node:fs";
+import { join } from "node:path";
+
+import type { WorkspaceMigration } from "./types.js";
+
+const MIGRATION_ID = "071-remove-safe-storage-release-note";
+const SAFE_STORAGE_RELEASE_NOTE_ID = "067-release-notes-safe-storage-limits";
+const SAFE_STORAGE_MARKER = `<!-- release-note-id:${SAFE_STORAGE_RELEASE_NOTE_ID} -->`;
+const RELEASE_NOTE_MARKER_PREFIX = "<!-- release-note-id:";
+
+const SAFE_STORAGE_RELEASE_NOTE = `${SAFE_STORAGE_MARKER}
+## Safe storage limits
+
+A new storage protection mode is available behind the safe-storage-limits
+rollout flag. When enabled, the assistant watches workspace disk usage and
+enters cleanup mode if the volume reaches the critical 95% threshold.
+
+In cleanup mode, background processes pause and remote messages, including
+trusted-contact messages, are blocked until the guardian frees enough space or
+explicitly overrides the lock. The macOS app now shows a storage cleanup banner
+that must be acknowledged before cleanup chat continues, then keeps a status
+banner visible while cleanup mode is active.
+`;
+
+const LEADING_NEWLINES = /^(?:(?:\r\n)|\n|\r)+/;
+const TRAILING_NEWLINES = /(?:(?:\r\n)|\n|\r)+$/;
+
+function findNewlineStyle(...samples: string[]): string {
+  for (const sample of samples) {
+    const match = sample.match(/\r\n|\n|\r/);
+    if (match) {
+      return match[0];
+    }
+  }
+
+  return "\n";
+}
+
+function stitchAroundRemovedBlock(before: string, after: string): string {
+  if (before.trim() === "") {
+    return after.replace(LEADING_NEWLINES, "");
+  }
+
+  if (after.trim() === "") {
+    return `${before.replace(TRAILING_NEWLINES, "")}${findNewlineStyle(before)}`;
+  }
+
+  const newline = findNewlineStyle(before, after);
+  return `${before.replace(TRAILING_NEWLINES, "")}${newline}${newline}${after.replace(LEADING_NEWLINES, "")}`;
+}
+
+function removeRange(content: string, start: number, end: number): string {
+  return stitchAroundRemovedBlock(content.slice(0, start), content.slice(end));
+}
+
+function removeSafeStorageReleaseNote(content: string): string {
+  const exactStart = content.indexOf(SAFE_STORAGE_RELEASE_NOTE);
+  if (exactStart >= 0) {
+    return removeRange(
+      content,
+      exactStart,
+      exactStart + SAFE_STORAGE_RELEASE_NOTE.length,
+    );
+  }
+
+  const markerStart = content.indexOf(SAFE_STORAGE_MARKER);
+  if (markerStart < 0) {
+    return content;
+  }
+
+  const nextMarkerStart = content.indexOf(
+    RELEASE_NOTE_MARKER_PREFIX,
+    markerStart + SAFE_STORAGE_MARKER.length,
+  );
+
+  return removeRange(
+    content,
+    markerStart,
+    nextMarkerStart >= 0 ? nextMarkerStart : content.length,
+  );
+}
+
+export const removeSafeStorageReleaseNoteMigration: WorkspaceMigration = {
+  id: MIGRATION_ID,
+  description: "Remove safe storage release note from UPDATES.md",
+
+  run(workspaceDir: string): void {
+    const updatesPath = join(workspaceDir, "UPDATES.md");
+    if (!existsSync(updatesPath)) {
+      return;
+    }
+
+    const existing = readFileSync(updatesPath, "utf-8");
+    if (!existing.includes(SAFE_STORAGE_MARKER)) {
+      return;
+    }
+
+    const cleaned = removeSafeStorageReleaseNote(existing);
+    if (cleaned.trim() === "") {
+      rmSync(updatesPath, { force: true });
+      return;
+    }
+
+    writeFileSync(updatesPath, cleaned, "utf-8");
+  },
+
+  down(_workspaceDir: string): void {
+    // Forward-only: this removes a pending bulletin that should no longer be
+    // shown to users.
+  },
+};

package/src/workspace/migrations/registry.ts

@@ -62,6 +62,13 @@ import { moveBackupKeyToWorkspaceMigration } from "./061-move-backup-key-to-work
 import { dropMemoryV2EdgesJsonMigration } from "./062-drop-memory-v2-edges-json.js";
 import { releaseNotesDynamicModelContextMigration } from "./063-release-notes-dynamic-model-context.js";
 import { unwindMainAgentOpusSeedMigration } from "./064-unwind-main-agent-opus-seed.js";
+import { bumpStaleHeartbeatIntervalMigration } from "./065-bump-stale-heartbeat-interval.js";
+import { seedHeartbeatCallsiteCostDefaultMigration } from "./066-seed-heartbeat-callsite-cost-default.js";
+import { releaseNotesSafeStorageLimitsMigration } from "./067-release-notes-safe-storage-limits.js";
+import { releaseNotesLocalTimezoneMigration } from "./068-release-notes-local-timezone.js";
+import { seedOnboardingThreadsMigration } from "./069-seed-onboarding-threads.js";
+import { memoryV2SummarySchemaRebuildMigration } from "./070-memory-v2-summary-schema-rebuild.js";
+import { removeSafeStorageReleaseNoteMigration } from "./071-remove-safe-storage-release-note.js";
 import { migrateToWorkspaceVolumeMigration } from "./migrate-to-workspace-volume.js";
 import type { WorkspaceMigration } from "./types.js";
 
@@ -135,4 +142,11 @@ export const WORKSPACE_MIGRATIONS: WorkspaceMigration[] = [
   dropMemoryV2EdgesJsonMigration,
   releaseNotesDynamicModelContextMigration,
   unwindMainAgentOpusSeedMigration,
+  bumpStaleHeartbeatIntervalMigration,
+  seedHeartbeatCallsiteCostDefaultMigration,
+  releaseNotesSafeStorageLimitsMigration,
+  releaseNotesLocalTimezoneMigration,
+  seedOnboardingThreadsMigration,
+  memoryV2SummarySchemaRebuildMigration,
+  removeSafeStorageReleaseNoteMigration,
 ];

package/src/__tests__/conversation-tool-setup-memory-scope.test.ts

@@ -1,167 +0,0 @@
-/**
- * Tests that createToolExecutor propagates memoryScopeId from the session's
- * memory policy into the ToolContext passed to the underlying executor.
- */
-
-import { describe, expect, mock, test } from "bun:test";
-
-import type { ToolSetupContext } from "../daemon/conversation-tool-setup.js";
-import type { SurfaceData, SurfaceType } from "../daemon/message-protocol.js";
-import type { PermissionPrompter } from "../permissions/prompter.js";
-import type { SecretPrompter } from "../permissions/secret-prompter.js";
-import type { ToolExecutor } from "../tools/executor.js";
-import type { ToolContext, ToolExecutionResult } from "../tools/types.js";
-
-// ---------------------------------------------------------------------------
-// Mocks — must be set up before importing the module under test
-// ---------------------------------------------------------------------------
-
-mock.module("../daemon/conversation-surfaces.js", () => ({
-  refreshSurfacesForApp: mock(() => {}),
-  surfaceProxyResolver: mock(() =>
-    Promise.resolve({ content: "", isError: false }),
-  ),
-}));
-
-mock.module("../services/published-app-updater.js", () => ({
-  updatePublishedAppDeployment: mock(() => Promise.resolve()),
-}));
-
-mock.module("../tools/browser/browser-screencast.js", () => ({
-  registerConversationSender: mock(() => {}),
-}));
-
-// ---------------------------------------------------------------------------
-// Import after mocks
-// ---------------------------------------------------------------------------
-
-import { createToolExecutor } from "../daemon/conversation-tool-setup.js";
-
-// ---------------------------------------------------------------------------
-// Helpers
-// ---------------------------------------------------------------------------
-
-function makeCtx(overrides: Partial<ToolSetupContext> = {}): ToolSetupContext {
-  return {
-    conversationId: "conv-scope",
-    currentRequestId: "req-1",
-    workingDir: "/tmp/test",
-    abortController: null,
-    traceEmitter: { emit: () => {} },
-    sendToClient: mock(() => {}),
-    pendingSurfaceActions: new Map(),
-    lastSurfaceAction: new Map(),
-    surfaceState: new Map<
-      string,
-      { surfaceType: SurfaceType; data: SurfaceData; title?: string }
-    >(),
-    surfaceUndoStacks: new Map(),
-    accumulatedSurfaceState: new Map(),
-    surfaceActionRequestIds: new Set<string>(),
-    currentTurnSurfaces: [],
-    isProcessing: () => false,
-    enqueueMessage: () => ({ queued: false, requestId: "r" }),
-    getQueueDepth: () => 0,
-    processMessage: async () => "",
-    withSurface: async <T>(_id: string, fn: () => T | Promise<T>) => fn(),
-    memoryPolicy: { scopeId: "default" },
-    ...overrides,
-  };
-}
-
-/** Executor spy that captures the ToolContext passed to execute(). */
-function makeCapturingExecutor(
-  result: ToolExecutionResult = { content: "ok", isError: false },
-) {
-  let captured: ToolContext | undefined;
-  return {
-    executor: {
-      execute: mock(
-        async (
-          _name: string,
-          _input: Record<string, unknown>,
-          ctx: ToolContext,
-        ) => {
-          captured = ctx;
-          return result;
-        },
-      ),
-    },
-    getCaptured: () => captured,
-  };
-}
-
-const noopPrompter = {
-  prompt: mock(async () => ({ decision: "allow" as const })),
-} as unknown as PermissionPrompter;
-const noopSecretPrompter = {
-  prompt: mock(async () => ({ cancelled: true })),
-} as unknown as SecretPrompter;
-const noopLifecycleHandler = mock(() => {});
-
-// ---------------------------------------------------------------------------
-// Tests
-// ---------------------------------------------------------------------------
-
-describe("session-tool-setup memoryScopeId propagation", () => {
-  test("passes default memoryScopeId to executor context", async () => {
-    const ctx = makeCtx({
-      memoryPolicy: { scopeId: "default" },
-    });
-    const { executor, getCaptured } = makeCapturingExecutor();
-
-    const toolFn = createToolExecutor(
-      executor as unknown as ToolExecutor,
-      noopPrompter,
-      noopSecretPrompter,
-      ctx,
-      noopLifecycleHandler,
-    );
-
-    await toolFn("some_tool", { key: "value" });
-
-    expect(getCaptured()).toBeDefined();
-    expect(getCaptured()!.memoryScopeId).toBe("default");
-  });
-
-  test("passes custom memoryScopeId from session memory policy", async () => {
-    const ctx = makeCtx({
-      memoryPolicy: { scopeId: "custom-scope-abc" },
-    });
-    const { executor, getCaptured } = makeCapturingExecutor();
-
-    const toolFn = createToolExecutor(
-      executor as unknown as ToolExecutor,
-      noopPrompter,
-      noopSecretPrompter,
-      ctx,
-      noopLifecycleHandler,
-    );
-
-    await toolFn("memory_write", { content: "test" });
-
-    expect(getCaptured()!.memoryScopeId).toBe("custom-scope-abc");
-  });
-
-  test("reads memoryScopeId at call time, not construction time", async () => {
-    const ctx = makeCtx({
-      memoryPolicy: { scopeId: "initial" },
-    });
-    const { executor, getCaptured } = makeCapturingExecutor();
-
-    const toolFn = createToolExecutor(
-      executor as unknown as ToolExecutor,
-      noopPrompter,
-      noopSecretPrompter,
-      ctx,
-      noopLifecycleHandler,
-    );
-
-    // Mutate the memory policy after construction
-    ctx.memoryPolicy = { scopeId: "updated-scope" };
-
-    await toolFn("some_tool", {});
-
-    expect(getCaptured()!.memoryScopeId).toBe("updated-scope");
-  });
-});