@vellumai/assistant 0.7.2 → 0.8.0

package/src/calls/call-controller.ts

@@ -26,6 +26,7 @@ import type { TtsProvider, TtsProviderId } from "../tts/types.js";
 import { getLogger } from "../util/logger.js";
 import { createStreamingEntry } from "./audio-store.js";
 import {
+  getEndCallListenWindowMs,
   getMaxCallDurationMs,
   getSilenceTimeoutMs,
   getUserConsultationTimeoutMs,
@@ -37,6 +38,7 @@ import {
   registerCallController,
   unregisterCallController,
 } from "./call-state.js";
+import { isTerminalState } from "./call-state-machine.js";
 import {
   createPendingQuestion,
   expirePendingQuestions,
@@ -93,6 +95,7 @@ export class CallController {
   private currentTurnPromise: Promise<void> | null = null;
   private destroyed = false;
   private silenceTimer: ReturnType<typeof setTimeout> | null = null;
+  private endCallListenTimer: ReturnType<typeof setTimeout> | null = null;
   private durationTimer: ReturnType<typeof setTimeout> | null = null;
   private durationWarningTimer: ReturnType<typeof setTimeout> | null = null;
   /**
@@ -244,6 +247,8 @@ export class CallController {
     transcript: string,
     speaker?: PromptSpeakerContext,
   ): Promise<void> {
+    this.cancelPendingEndCall();
+
     const interruptedInFlight =
       this.state === "processing" || this.state === "speaking";
     // If we're already processing or speaking, abort the in-flight generation
@@ -295,6 +300,8 @@ export class CallController {
       return false;
     }
 
+    this.cancelPendingEndCall();
+
     // Clear the consultation timeout and record
     clearTimeout(this.pendingGuardianInput.timer);
     this.pendingGuardianInput = null;
@@ -326,6 +333,8 @@ export class CallController {
    * position once the current turn completes.
    */
   async handleUserInstruction(instructionText: string): Promise<void> {
+    this.cancelPendingEndCall();
+
     recordCallEvent(this.callSessionId, "user_instruction_relayed", {
       instruction: instructionText,
     });
@@ -408,6 +417,7 @@ export class CallController {
   destroy(): void {
     this.destroyed = true;
     if (this.silenceTimer) clearTimeout(this.silenceTimer);
+    if (this.endCallListenTimer) clearTimeout(this.endCallListenTimer);
     if (this.durationTimer) clearTimeout(this.durationTimer);
     if (this.durationWarningTimer) clearTimeout(this.durationWarningTimer);
     if (this.pendingGuardianInput) {
@@ -419,6 +429,7 @@ export class CallController {
       this.durationEndTimer = null;
     }
     this.pendingInstructions = [];
+    this.endCallListenTimer = null;
     this.llmRunVersion++;
     this.abortCurrentTurn();
     if (this.activeSynthesisAbort) {
@@ -1075,73 +1086,7 @@ export class CallController {
 
     // Check for END_CALL marker
     if (responseText.includes(END_CALL_MARKER)) {
-      // Clear any pending consultation before completing the call.
-      // Without this, the consultation timeout can fire on an already-ended
-      // call, overwriting 'completed' status back to 'in_progress' and
-      // starting a new LLM turn on a dead conversation. Similarly, a late
-      // handleUserAnswer could be accepted since pendingGuardianInput is
-      // still non-null.
-      if (this.pendingGuardianInput) {
-        clearTimeout(this.pendingGuardianInput.timer);
-
-        // Expire store-side consultation records so clients don't observe
-        // a completed call with a dangling pendingQuestion, and guardian
-        // replies are cleanly rejected instead of hitting answerCall failures.
-        expirePendingQuestions(this.callSessionId);
-        const previousRequest = getPendingCanonicalRequestByCallSessionId(
-          this.callSessionId,
-        );
-        if (previousRequest) {
-          expireCanonicalGuardianRequest(previousRequest.id);
-        }
-
-        this.pendingGuardianInput = null;
-      }
-
-      const currentSession = getCallSession(this.callSessionId);
-      const shouldNotifyCompletion = currentSession
-        ? currentSession.status !== "completed" &&
-          currentSession.status !== "failed" &&
-          currentSession.status !== "cancelled"
-        : false;
-
-      this.transport.endSession("Call completed");
-      updateCallSession(this.callSessionId, {
-        status: "completed",
-        endedAt: Date.now(),
-      });
-      recordCallEvent(this.callSessionId, "call_ended", {
-        reason: "completed",
-      });
-
-      // Notify the voice conversation
-      if (shouldNotifyCompletion && currentSession) {
-        finalizeCall(this.callSessionId, currentSession.conversationId);
-      }
-
-      // Post a pointer message in the initiating conversation
-      if (currentSession?.initiatedFromConversationId) {
-        const durationMs = currentSession.startedAt
-          ? Date.now() - currentSession.startedAt
-          : 0;
-        addPointerMessage(
-          currentSession.initiatedFromConversationId,
-          "completed",
-          currentSession.toNumber,
-          {
-            duration: durationMs > 0 ? formatDuration(durationMs) : undefined,
-          },
-        ).catch((err) => {
-          log.warn(
-            {
-              conversationId: currentSession.initiatedFromConversationId,
-              err,
-            },
-            "Skipping pointer write — origin conversation may no longer exist",
-          );
-        });
-      }
-      this.state = "idle";
+      this.scheduleEndCallAfterListenWindow();
       return;
     }
 
@@ -1153,6 +1098,124 @@ export class CallController {
     this.flushPendingInstructions();
   }
 
+  private scheduleEndCallAfterListenWindow(): void {
+    const currentSession = getCallSession(this.callSessionId);
+    if (currentSession && isTerminalState(currentSession.status)) {
+      this.state = "idle";
+      this.currentTurnHandle = null;
+      return;
+    }
+
+    const clearedPendingGuardianInput =
+      this.clearPendingGuardianInputForCallEnd();
+    this.state = "idle";
+    this.currentTurnHandle = null;
+
+    if (this.endCallListenTimer) {
+      clearTimeout(this.endCallListenTimer);
+      this.endCallListenTimer = null;
+    }
+
+    const listenWindowMs = getEndCallListenWindowMs();
+    const callContinues =
+      this.pendingInstructions.length > 0 || listenWindowMs > 0;
+    if (clearedPendingGuardianInput && callContinues) {
+      updateCallSession(this.callSessionId, { status: "in_progress" });
+    }
+
+    if (this.pendingInstructions.length > 0) {
+      this.flushPendingInstructions();
+      return;
+    }
+
+    if (listenWindowMs <= 0) {
+      this.completeCallFromEndMarker();
+      return;
+    }
+
+    this.resetSilenceTimer();
+    this.endCallListenTimer = setTimeout(() => {
+      this.endCallListenTimer = null;
+      this.completeCallFromEndMarker();
+    }, listenWindowMs);
+  }
+
+  private cancelPendingEndCall(): void {
+    if (!this.endCallListenTimer) return;
+    clearTimeout(this.endCallListenTimer);
+    this.endCallListenTimer = null;
+  }
+
+  private clearPendingGuardianInputForCallEnd(): boolean {
+    if (!this.pendingGuardianInput) return false;
+
+    clearTimeout(this.pendingGuardianInput.timer);
+
+    // Expire store-side consultation records so clients don't observe
+    // a completed call with a dangling pendingQuestion, and guardian
+    // replies are cleanly rejected instead of hitting answerCall failures.
+    expirePendingQuestions(this.callSessionId);
+    const previousRequest = getPendingCanonicalRequestByCallSessionId(
+      this.callSessionId,
+    );
+    if (previousRequest) {
+      expireCanonicalGuardianRequest(previousRequest.id);
+    }
+
+    this.pendingGuardianInput = null;
+    return true;
+  }
+
+  private completeCallFromEndMarker(): void {
+    if (this.destroyed) return;
+
+    const currentSession = getCallSession(this.callSessionId);
+    if (currentSession && isTerminalState(currentSession.status)) {
+      this.state = "idle";
+      return;
+    }
+
+    const shouldNotifyCompletion = !!currentSession;
+
+    this.transport.endSession("Call completed");
+    updateCallSession(this.callSessionId, {
+      status: "completed",
+      endedAt: Date.now(),
+    });
+    recordCallEvent(this.callSessionId, "call_ended", {
+      reason: "completed",
+    });
+
+    // Notify the voice conversation
+    if (shouldNotifyCompletion && currentSession) {
+      finalizeCall(this.callSessionId, currentSession.conversationId);
+    }
+
+    // Post a pointer message in the initiating conversation
+    if (currentSession?.initiatedFromConversationId) {
+      const durationMs = currentSession.startedAt
+        ? Date.now() - currentSession.startedAt
+        : 0;
+      addPointerMessage(
+        currentSession.initiatedFromConversationId,
+        "completed",
+        currentSession.toNumber,
+        {
+          duration: durationMs > 0 ? formatDuration(durationMs) : undefined,
+        },
+      ).catch((err) => {
+        log.warn(
+          {
+            conversationId: currentSession.initiatedFromConversationId,
+            err,
+          },
+          "Skipping pointer write — origin conversation may no longer exist",
+        );
+      });
+    }
+    this.state = "idle";
+  }
+
   private isExpectedAbortError(err: unknown): boolean {
     if (!(err instanceof Error)) return false;
     return err.name === "AbortError" || err.name === "APIUserAbortError";

package/src/calls/call-conversation-messages.ts

@@ -6,6 +6,21 @@
 import { addMessage } from "../memory/conversation-crud.js";
 import { getCallEvents, getCallSession } from "./call-store.js";
 
+function buildCallSummaryLabel(
+  status: string | undefined,
+  duration: number | null,
+  eventCount: number,
+): string {
+  const statusLabel =
+    status === "failed"
+      ? "Call failed"
+      : status === "cancelled"
+        ? "Call cancelled"
+        : "Call completed";
+  const durationStr = duration != null ? ` (${duration}s)` : "";
+  return `**${statusLabel}**${durationStr}. ${eventCount} event(s) recorded.`;
+}
+
 export function buildCallCompletionMessage(callSessionId: string): string {
   const callSession = getCallSession(callSessionId);
   const events = getCallEvents(callSessionId);
@@ -13,25 +28,46 @@ export function buildCallCompletionMessage(callSessionId: string): string {
     callSession?.endedAt && callSession?.startedAt
       ? Math.round((callSession.endedAt - callSession.startedAt) / 1000)
       : null;
-  const durationStr = duration != null ? ` (${duration}s)` : "";
-  const statusLabel =
-    callSession?.status === "failed"
-      ? "Call failed"
-      : callSession?.status === "cancelled"
-        ? "Call cancelled"
-        : "Call completed";
-  return `**${statusLabel}**${durationStr}. ${events.length} event(s) recorded.`;
+  return buildCallSummaryLabel(callSession?.status, duration, events.length);
 }
 
 export async function persistCallCompletionMessage(
   conversationId: string,
   callSessionId: string,
 ): Promise<string> {
-  const summaryText = buildCallCompletionMessage(callSessionId);
+  const callSession = getCallSession(callSessionId);
+  const events = getCallEvents(callSessionId);
+  const duration =
+    callSession?.endedAt && callSession?.startedAt
+      ? Math.round((callSession.endedAt - callSession.startedAt) / 1000)
+      : null;
+  const summaryText = buildCallSummaryLabel(
+    callSession?.status,
+    duration,
+    events.length,
+  );
+
   await addMessage(
     conversationId,
     "assistant",
-    JSON.stringify([{ type: "text", text: summaryText }]),
+    JSON.stringify([
+      {
+        type: "ui_surface",
+        surfaceType: "call_summary",
+        surfaceId: crypto.randomUUID(),
+        completed: true,
+        data: {
+          summaryText,
+          status: callSession?.status ?? "completed",
+          duration,
+          events: events.map((e) => ({
+            eventType: e.eventType,
+            payloadJson: e.payloadJson,
+            createdAt: e.createdAt,
+          })),
+        },
+      },
+    ]),
     {
       userMessageChannel: "phone",
       assistantMessageChannel: "phone",

package/src/calls/relay-server.ts

@@ -66,6 +66,8 @@ import {
 } from "./speaker-identification.js";
 
 const log = getLogger("relay-server");
+const UUID_SHAPED_NAME =
+  /^[0-9a-fA-F]{8}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{4}-[0-9a-fA-F]{12}$/;
 
 // ── ConversationRelay message types ──────────────────────────────────
 
@@ -1615,7 +1617,11 @@ export class RelayConnection {
   private resolveAssistantLabel(): string | null {
     try {
       const name = getAssistantName();
-      return name?.trim() || null;
+      const trimmedName = name?.trim();
+      if (!trimmedName || UUID_SHAPED_NAME.test(trimmedName)) {
+        return null;
+      }
+      return trimmedName;
     } catch {
       return null;
     }

package/src/calls/voice-session-bridge.ts

@@ -233,7 +233,7 @@ function buildVoiceCallControlPrompt(opts: {
       );
     } else {
       lines.push(
-        '7. If the latest user turn is "(call connected — deliver opening greeting)", this is an inbound call you are answering (not a call you initiated). Greet the caller warmly and ask how you can help. Introduce yourself once at the start using your assistant name if you know it (for example: "Hey there, this is Ava, Sam\'s assistant. How can I help?"). If your assistant name is not known, skip the name and just identify yourself as the guardian\'s assistant. Do NOT say "I\'m calling" or "I\'m calling on behalf of". Vary the wording; do not use a fixed template.',
+        '7. If the latest user turn is "(call connected — deliver opening greeting)", this is an inbound call you are answering (not a call you initiated). Greet the caller warmly and ask how you can help. Introduce yourself once at the start using your assistant name if you know it (for example: "Hey there, this is Ava, Sam\'s assistant. How can I help?"). If your assistant name is not known, skip the name and just identify yourself as the guardian\'s assistant. Never use a UUID-shaped internal assistant ID as your spoken name. Do NOT say "I\'m calling" or "I\'m calling on behalf of". Vary the wording; do not use a fixed template.',
       );
     }
     lines.push(

package/src/cli/commands/__tests__/webhooks.test.ts

@@ -14,7 +14,6 @@ let mockPlatformContext: Record<string, unknown> = {
   isPlatform: false,
   platformBaseUrl: "",
   assistantId: "",
-  hasInternalApiKey: false,
   hasAssistantApiKey: false,
   authHeader: null,
   enabled: false,
@@ -128,7 +127,6 @@ function connectedContext(
     isPlatform: false,
     platformBaseUrl: "https://test-platform.vellum.ai",
     assistantId: "019d6d4f-6dbd-779f-91d3-cb273b9429a5",
-    hasInternalApiKey: false,
     hasAssistantApiKey: true,
     authHeader: "Api-Key vak_test123",
     enabled: true,
@@ -145,7 +143,6 @@ describe("assistant webhooks register", () => {
       isPlatform: false,
       platformBaseUrl: "",
       assistantId: "",
-      hasInternalApiKey: false,
       hasAssistantApiKey: false,
       authHeader: null,
       enabled: false,
@@ -466,7 +463,6 @@ describe("assistant webhooks list", () => {
       isPlatform: false,
       platformBaseUrl: "",
       assistantId: "",
-      hasInternalApiKey: false,
       hasAssistantApiKey: false,
       authHeader: null,
       enabled: false,

package/src/cli/commands/bash.ts

@@ -1,23 +1,11 @@
-import { randomUUID } from "node:crypto";
-import {
-  existsSync,
-  mkdirSync,
-  readFileSync,
-  unlinkSync,
-  writeFileSync,
-} from "node:fs";
-import { join } from "node:path";
-
 import type { Command } from "commander";
 
-import { getSignalsDir } from "../../util/platform.js";
+import { cliIpcCall } from "../../ipc/cli-client.js";
 import { log } from "../logger.js";
 
 const DEFAULT_TIMEOUT_MS = 30_000;
-const POLL_INTERVAL_MS = 100;
 
-interface BashSignalResult {
-  requestId: string;
+interface DebugBashResult {
   stdout: string;
   stderr: string;
   exitCode: number | null;
@@ -39,20 +27,16 @@ export function registerBashCommand(program: Command): void {
     .addHelpText(
       "after",
       `
-Sends a shell command to the running assistant for execution via the
-signals directory. The assistant spawns the command in its own process environment
-and returns stdout, stderr, and the exit code.
+Sends a shell command to the running assistant for execution via the IPC
+socket. The assistant spawns the command in its own process environment and
+returns stdout, stderr, and the exit code.
 
 This is a developer debugging tool for inspecting how the assistant invokes and
 observes shell commands. The command runs with the assistant's environment, working
 directory, and process context — not the caller's shell.
 
 Requires the assistant to be running with VELLUM_DEBUG=1. When debug mode is off
-(the default), the assistant ignores bash signal files and returns an error.
-
-The CLI writes the command to signals/bash.<requestId> and polls
-signals/bash.<requestId>.result for the output. The assistant must be running
-for this to work.
+(the default), the assistant returns an error immediately.
 
 Arguments:
   command   The shell command string to execute (e.g. "echo hello", "ls -la").
@@ -64,7 +48,7 @@ Examples:
   $ assistant bash "env | grep PATH" --timeout 10000
   $ assistant bash "ls -la"`,
     )
-    .action((command: string, opts: { timeout: string }) => {
+    .action(async (command: string, opts: { timeout: string }) => {
       const timeoutMs = parseInt(opts.timeout, 10);
       if (!Number.isFinite(timeoutMs) || timeoutMs < 1) {
         log.error("Invalid timeout value. Must be a positive integer.");
@@ -72,105 +56,48 @@ Examples:
         return;
       }
 
-      const requestId = randomUUID();
-      const signalsDir = getSignalsDir();
+      const result = await cliIpcCall<DebugBashResult>(
+        "debug_bash",
+        { body: { command, timeoutMs } },
+        { timeoutMs: timeoutMs + 10_000 },
+      );
 
-      try {
-        mkdirSync(signalsDir, { recursive: true });
-      } catch {
-        log.error("Failed to create signals directory.");
+      if (!result.ok) {
+        log.error(result.error ?? "Failed to reach the assistant.");
         process.exitCode = 1;
         return;
       }
 
-      // Write the command signal for the assistant to pick up.
-      const signalPath = join(signalsDir, `bash.${requestId}`);
-      const resultPath = join(signalsDir, `bash.${requestId}.result`);
-
-      try {
-        writeFileSync(
-          signalPath,
-          JSON.stringify({ requestId, command, timeoutMs }),
-        );
-      } catch {
-        log.error("Failed to write bash signal file.");
+      const data = result.result!;
+
+      if (data.error) {
+        log.error(data.error);
         process.exitCode = 1;
         return;
       }
 
-      log.info(`Sent command to assistant (requestId: ${requestId})`);
-      log.info("Waiting for result...");
-
-      // Poll for the result file until timeout.
-      const deadline = Date.now() + timeoutMs + 5_000; // extra buffer for assistant overhead
-
-      const poll = setInterval(() => {
-        if (Date.now() > deadline) {
-          clearInterval(poll);
-          cleanupSignalFiles();
-          log.error(
-            "Timed out waiting for response. Is the assistant running?",
-          );
-          process.exitCode = 1;
-          return;
-        }
-
-        if (!existsSync(resultPath)) return;
-
-        let result: BashSignalResult;
-        try {
-          const content = readFileSync(resultPath, "utf-8");
-          result = JSON.parse(content) as BashSignalResult;
-        } catch {
-          // File may be partially written; retry on next poll.
-          return;
-        }
-
-        // Ignore stale results from a previous invocation.
-        if (result.requestId !== requestId) return;
-
-        clearInterval(poll);
-        cleanupSignalFiles();
-
-        if (result.error) {
-          log.error(result.error);
-          process.exitCode = 1;
-          return;
-        }
-
-        if (result.stdout) {
-          process.stdout.write(result.stdout);
-          if (!result.stdout.endsWith("\n")) {
-            process.stdout.write("\n");
-          }
-        }
-
-        if (result.stderr) {
-          process.stderr.write(result.stderr);
-          if (!result.stderr.endsWith("\n")) {
-            process.stderr.write("\n");
-          }
-        }
-
-        if (result.timedOut) {
-          log.info(`Command timed out in assistant.`);
+      if (data.stdout) {
+        process.stdout.write(data.stdout);
+        if (!data.stdout.endsWith("\n")) {
+          process.stdout.write("\n");
         }
+      }
 
-        if (result.exitCode != null && result.exitCode !== 0) {
-          log.info(`Exit code: ${result.exitCode}`);
+      if (data.stderr) {
+        process.stderr.write(data.stderr);
+        if (!data.stderr.endsWith("\n")) {
+          process.stderr.write("\n");
         }
+      }
 
-        process.exitCode = result.exitCode ?? 1;
-      }, POLL_INTERVAL_MS);
+      if (data.timedOut) {
+        log.info(`Command timed out in assistant.`);
+      }
 
-      function cleanupSignalFiles(): void {
-        for (const p of [signalPath, resultPath]) {
-          try {
-            unlinkSync(p);
-          } catch {
-            // Best-effort cleanup; the file may already be gone.
-          }
-        }
+      if (data.exitCode != null && data.exitCode !== 0) {
+        log.info(`Exit code: ${data.exitCode}`);
       }
+
+      process.exitCode = data.exitCode ?? 1;
     });
 }