@vellumai/assistant 0.7.2 → 0.8.0

package/node_modules/@vellumai/slack-text/src/index.test.ts

@@ -4,8 +4,6 @@ import {
   buildSlackUserLabelMap,
   extractSlackUserMentionIds,
   renderSlackTextForModel,
-  stripLeadingSlackMentionFallback,
-  stripLeadingSlackUserMention,
 } from "./index.js";
 
 describe("extractSlackUserMentionIds", () => {
@@ -16,34 +14,6 @@ describe("extractSlackUserMentionIds", () => {
   });
 });
 
-describe("stripLeadingSlackUserMention", () => {
-  test("strips only leading mentions for the exact bot ID", () => {
-    expect(stripLeadingSlackUserMention("<@U111> <@U222> hi", "U111")).toBe(
-      "<@U222> hi"
-    );
-  });
-
-  test("strips repeated leading mentions for the exact bot ID", () => {
-    expect(stripLeadingSlackUserMention(" <@U111> <@U111> hi", "U111")).toBe(
-      "hi"
-    );
-  });
-
-  test("preserves text when the leading mention is a different user", () => {
-    expect(stripLeadingSlackUserMention("<@U222> hi <@U111>", "U111")).toBe(
-      "<@U222> hi <@U111>"
-    );
-  });
-});
-
-describe("stripLeadingSlackMentionFallback", () => {
-  test("strips only the first leading Slack user mention", () => {
-    expect(stripLeadingSlackMentionFallback(" <@U111> <@U222> hi")).toBe(
-      "<@U222> hi"
-    );
-  });
-});
-
 describe("renderSlackTextForModel", () => {
   test("renders resolved user mentions", () => {
     expect(
@@ -123,19 +93,32 @@ describe("renderSlackTextForModel", () => {
 });
 
 describe("buildSlackUserLabelMap", () => {
-  test("dedupes mentioned users across text inputs and ignores configured IDs", async () => {
+  test("dedupes mentioned users across text inputs and resolves them in parallel", async () => {
     const resolved: string[] = [];
     const labels = await buildSlackUserLabelMap(
       ["<@U123> hi <@U999>", undefined, "<@U123> and <@W456>"],
       async (userId) => {
         resolved.push(userId);
+        if (userId === "U999") return "Charlie";
         return userId === "W456" ? "Bob" : "Alice";
-      },
-      { ignoredUserIds: ["U999"] }
+      }
+    );
+
+    expect(resolved.sort()).toEqual(["U123", "U999", "W456"]);
+    expect(labels).toEqual({ U123: "Alice", U999: "Charlie", W456: "Bob" });
+  });
+
+  test("resolves bot and human user mentions together", async () => {
+    const labels = await buildSlackUserLabelMap(
+      ["<@UBOT> can you help <@ULEO> with the deploy?"],
+      async (userId) => {
+        if (userId === "UBOT") return "vex";
+        if (userId === "ULEO") return "leo";
+        return undefined;
+      }
     );
 
-    expect(resolved).toEqual(["U123", "W456"]);
-    expect(labels).toEqual({ U123: "Alice", W456: "Bob" });
+    expect(labels).toEqual({ UBOT: "vex", ULEO: "leo" });
   });
 
   test("omits unresolved labels and labels equal to the Slack user ID", async () => {

package/node_modules/@vellumai/slack-text/src/index.ts

@@ -5,12 +5,7 @@ export interface RenderSlackTextOptions {
   channelFallbackLabel?: string;
 }
 
-export interface BuildSlackUserLabelMapOptions {
-  ignoredUserIds?: Iterable<string | undefined>;
-}
-
 const SLACK_USER_MENTION_RE = /<@([UW][A-Z0-9]+)>/g;
-const LEADING_SLACK_USER_MENTION_RE = /^\s*<@[UW][A-Z0-9]+>\s*/;
 
 export function extractSlackUserMentionIds(text: string): string[] {
   const seen = new Set<string>();
@@ -27,30 +22,6 @@ export function extractSlackUserMentionIds(text: string): string[] {
   return ids;
 }
 
-export function stripLeadingSlackUserMention(
-  text: string,
-  userId: string
-): string {
-  if (!isSlackUserId(userId)) {
-    return text;
-  }
-
-  const mention = `<@${userId}>`;
-  let stripped = text;
-
-  while (true) {
-    const next = stripLeadingExactToken(stripped, mention);
-    if (next === stripped) {
-      return stripped;
-    }
-    stripped = next;
-  }
-}
-
-export function stripLeadingSlackMentionFallback(text: string): string {
-  return text.replace(LEADING_SLACK_USER_MENTION_RE, "");
-}
-
 export function renderSlackTextForModel(
   text: string,
   options: RenderSlackTextOptions = {}
@@ -78,21 +49,15 @@ export function renderSlackTextForModel(
 
 export async function buildSlackUserLabelMap(
   texts: Iterable<string | undefined>,
-  resolveLabel: (userId: string) => Promise<string | undefined | null>,
-  options: BuildSlackUserLabelMapOptions = {}
+  resolveLabel: (userId: string) => Promise<string | undefined | null>
 ): Promise<Record<string, string>> {
-  const ignored = new Set(
-    [...(options.ignoredUserIds ?? [])].filter(
-      (id): id is string => typeof id === "string" && id.length > 0
-    )
-  );
   const ids: string[] = [];
   const seen = new Set<string>();
 
   for (const text of texts) {
     if (!text) continue;
     for (const id of extractSlackUserMentionIds(text)) {
-      if (ignored.has(id) || seen.has(id)) continue;
+      if (seen.has(id)) continue;
       seen.add(id);
       ids.push(id);
     }
@@ -215,17 +180,6 @@ function sanitizeOptionalLabel(label: string | undefined): string | undefined {
     .trim();
 }
 
-function stripLeadingExactToken(text: string, token: string): string {
-  const leadingWhitespaceLength = text.length - text.trimStart().length;
-  const afterWhitespace = text.slice(leadingWhitespaceLength);
-
-  if (!afterWhitespace.startsWith(token)) {
-    return text;
-  }
-
-  return afterWhitespace.slice(token.length).trimStart();
-}
-
 function isSlackUserId(value: string): boolean {
   return /^[UW][A-Z0-9]+$/.test(value);
 }