@vellumai/assistant 0.7.1 → 0.7.3

package/src/calls/relay-server.ts

@@ -14,10 +14,6 @@ import {
   findGuardianForChannel,
   listGuardianChannels,
 } from "../contacts/contact-store.js";
-import {
-  touchContactInteraction,
-  upsertContactChannel,
-} from "../contacts/contacts-write.js";
 import { getAssistantName } from "../daemon/identity-helpers.js";
 import type { ServerMessage } from "../daemon/message-protocol.js";
 import { getCanonicalGuardianRequest } from "../memory/canonical-guardian-store.js";
@@ -615,13 +611,6 @@ export class RelayConnection {
         this.startNameCapture(outcome.assistantId, outcome.fromNumber);
         return;
       case "verification":
-        if (
-          resolved.actorTrust.memberRecord &&
-          (resolved.actorTrust.trustClass === "guardian" ||
-            resolved.actorTrust.trustClass === "trusted_contact")
-        ) {
-          touchContactInteraction(resolved.actorTrust.memberRecord.channel.id);
-        }
         if (this.controller && resolved.actorTrust.trustClass !== "unknown") {
           this.controller.setTrustContext(
             toTrustContext(resolved.actorTrust, msg.from),
@@ -631,15 +620,6 @@ export class RelayConnection {
         return;
       case "normal_call":
         if (outcome.isInbound) {
-          if (
-            resolved.actorTrust.memberRecord &&
-            (resolved.actorTrust.trustClass === "guardian" ||
-              resolved.actorTrust.trustClass === "trusted_contact")
-          ) {
-            touchContactInteraction(
-              resolved.actorTrust.memberRecord.channel.id,
-            );
-          }
           if (this.controller && resolved.actorTrust.trustClass !== "unknown") {
             this.controller.setTrustContext(
               toTrustContext(resolved.actorTrust, msg.from),
@@ -796,8 +776,6 @@ export class RelayConnection {
   private continueCallAfterTrustedContactActivation(params: {
     assistantId: string;
     fromNumber: string;
-    callerName?: string;
-    skipMemberActivation?: boolean;
     activationReason?:
       | "invite_redeemed"
       | "access_approved"
@@ -805,25 +783,10 @@ export class RelayConnection {
     friendName?: string;
     guardianName?: string;
   }): void {
-    const { assistantId, fromNumber, callerName } = params;
-
-    if (!params.skipMemberActivation) {
-      try {
-        upsertContactChannel({
-          sourceChannel: "phone",
-          externalUserId: fromNumber,
-          externalChatId: fromNumber,
-          displayName: callerName,
-          status: "active",
-          policy: "allow",
-        });
-      } catch (err) {
-        log.error(
-          { err, callSessionId: this.callSessionId },
-          "Failed to activate voice caller as trusted contact",
-        );
-      }
-    }
+    const { assistantId, fromNumber } = params;
+
+    // Contact activation is handled by the gateway — the assistant no
+    // longer writes contact/channel records on inbound voice calls.
 
     const updatedTrust = resolveActorTrust({
       assistantId,
@@ -1411,7 +1374,6 @@ export class RelayConnection {
     this.continueCallAfterTrustedContactActivation({
       assistantId,
       fromNumber,
-      callerName: callerName ?? undefined,
       activationReason: "access_approved",
     });
 
@@ -1594,8 +1556,6 @@ export class RelayConnection {
       this.continueCallAfterTrustedContactActivation({
         assistantId: this.inviteRedemptionAssistantId,
         fromNumber: this.inviteRedemptionFromNumber,
-        callerName: this.inviteRedemptionFriendName ?? undefined,
-        skipMemberActivation: true,
         activationReason: "invite_redeemed",
         friendName: this.inviteRedemptionFriendName ?? undefined,
         guardianName: this.inviteRedemptionGuardianName ?? undefined,

package/src/calls/twilio-config.ts

@@ -1,8 +1,4 @@
 import { loadConfig } from "../config/loader.js";
-import {
-  getPublicBaseUrl,
-  getTwilioRelayUrl,
-} from "../inbound/public-ingress-urls.js";
 import { credentialKey } from "../security/credential-key.js";
 import { getSecureKeyAsync } from "../security/secure-keys.js";
 import { ConfigError } from "../util/errors.js";
@@ -14,8 +10,6 @@ export interface TwilioConfig {
   accountSid: string;
   authToken: string;
   phoneNumber: string;
-  webhookBaseUrl: string;
-  wssBaseUrl: string;
 }
 
 /**
@@ -39,19 +33,10 @@ export function resolveTwilioPhoneNumber(): string {
 }
 
 export async function getTwilioConfig(): Promise<TwilioConfig> {
-  const config = loadConfig();
-  const accountSid = config.twilio?.accountSid || "";
+  const accountSid = loadConfig().twilio?.accountSid || "";
   const authToken =
     (await getSecureKeyAsync(credentialKey("twilio", "auth_token"))) || "";
   const phoneNumber = resolveTwilioPhoneNumber();
-  const webhookBaseUrl = getPublicBaseUrl(config);
-
-  let wssBaseUrl: string;
-  try {
-    wssBaseUrl = getTwilioRelayUrl(config);
-  } catch {
-    wssBaseUrl = "";
-  }
 
   if (!accountSid || !authToken) {
     throw new ConfigError(
@@ -64,5 +49,5 @@ export async function getTwilioConfig(): Promise<TwilioConfig> {
 
   log.debug("Twilio config loaded successfully");
 
-  return { accountSid, authToken, phoneNumber, webhookBaseUrl, wssBaseUrl };
+  return { accountSid, authToken, phoneNumber };
 }

package/src/calls/twilio-rest.ts

@@ -6,6 +6,15 @@
  * config handler. Uses fetch() directly — no twilio npm package.
  */
 
+import {
+  lookupIncomingPhoneNumberSid,
+  twilioAuthHeader,
+  twilioBaseUrl,
+  TwilioRestError,
+  type TwilioWebhookUrls,
+  updatePhoneNumberWebhooks as updateTwilioPhoneNumberWebhooks,
+} from "@vellumai/twilio-client";
+
 import { loadConfig } from "../config/loader.js";
 import { credentialKey } from "../security/credential-key.js";
 import { getSecureKeyAsync } from "../security/secure-keys.js";
@@ -56,20 +65,7 @@ export async function hasTwilioCredentials(): Promise<boolean> {
   }
 }
 
-/** Build the HTTP Basic auth header for Twilio API requests. */
-export function twilioAuthHeader(
-  accountSid: string,
-  authToken: string,
-): string {
-  return (
-    "Basic " + Buffer.from(`${accountSid}:${authToken}`).toString("base64")
-  );
-}
-
-/** Build the Twilio REST API base URL for a given account. */
-export function twilioBaseUrl(accountSid: string): string {
-  return `https://api.twilio.com/2010-04-01/Accounts/${accountSid}`;
-}
+export { twilioAuthHeader, twilioBaseUrl };
 
 export interface TwilioPhoneNumber {
   phoneNumber: string;
@@ -210,9 +206,13 @@ export async function provisionPhoneNumber(
   };
 }
 
-export interface WebhookUrls {
-  voiceUrl: string;
-  statusCallbackUrl: string;
+export type WebhookUrls = TwilioWebhookUrls;
+
+function rethrowAsProviderError(err: unknown): never {
+  if (err instanceof TwilioRestError) {
+    throw new ProviderError(err.message, "twilio", err.status);
+  }
+  throw err;
 }
 
 /**
@@ -227,69 +227,15 @@ export async function updatePhoneNumberWebhooks(
   phoneNumber: string,
   webhooks: WebhookUrls,
 ): Promise<void> {
-  // First, find the SID for this phone number
-  const listRes = await fetch(
-    `${twilioBaseUrl(
+  try {
+    await updateTwilioPhoneNumberWebhooks({
       accountSid,
-    )}/IncomingPhoneNumbers.json?PhoneNumber=${encodeURIComponent(
+      authToken,
       phoneNumber,
-    )}`,
-    {
-      method: "GET",
-      headers: { Authorization: twilioAuthHeader(accountSid, authToken) },
-    },
-  );
-
-  if (!listRes.ok) {
-    const text = await listRes.text();
-    throw new ProviderError(
-      `Twilio API error ${listRes.status} looking up phone number: ${text}`,
-      "twilio",
-      listRes.status,
-    );
-  }
-
-  const listData = (await listRes.json()) as {
-    incoming_phone_numbers: Array<{ sid: string; phone_number: string }>;
-  };
-
-  const match = listData.incoming_phone_numbers.find(
-    (n) => n.phone_number === phoneNumber,
-  );
-  if (!match) {
-    throw new ProviderError(
-      `Phone number ${phoneNumber} not found on Twilio account ${accountSid}`,
-      "twilio",
-    );
-  }
-
-  // Update the phone number's webhook configuration
-  const body = new URLSearchParams({
-    VoiceUrl: webhooks.voiceUrl,
-    VoiceMethod: "POST",
-    StatusCallback: webhooks.statusCallbackUrl,
-    StatusCallbackMethod: "POST",
-  });
-
-  const updateRes = await fetch(
-    `${twilioBaseUrl(accountSid)}/IncomingPhoneNumbers/${match.sid}.json`,
-    {
-      method: "POST",
-      headers: {
-        Authorization: twilioAuthHeader(accountSid, authToken),
-        "Content-Type": "application/x-www-form-urlencoded",
-      },
-      body: body.toString(),
-    },
-  );
-
-  if (!updateRes.ok) {
-    const text = await updateRes.text();
-    throw new ProviderError(
-      `Twilio API error ${updateRes.status} updating webhooks: ${text}`,
-      "twilio",
-      updateRes.status,
-    );
+      webhooks,
+    });
+  } catch (err) {
+    rethrowAsProviderError(err);
   }
 }
 
@@ -302,35 +248,17 @@ async function getPhoneNumberSid(
   authToken: string,
   phoneNumber: string,
 ): Promise<string | null> {
-  const res = await fetch(
-    `${twilioBaseUrl(
-      accountSid,
-    )}/IncomingPhoneNumbers.json?PhoneNumber=${encodeURIComponent(
-      phoneNumber,
-    )}`,
-    {
-      method: "GET",
-      headers: { Authorization: twilioAuthHeader(accountSid, authToken) },
-    },
-  );
-
-  if (!res.ok) {
-    const text = await res.text();
-    throw new ProviderError(
-      `Twilio API error ${res.status} looking up phone number SID: ${text}`,
-      "twilio",
-      res.status,
+  try {
+    return (
+      (await lookupIncomingPhoneNumberSid({
+        accountSid,
+        authToken,
+        phoneNumber,
+      })) ?? null
     );
+  } catch (err) {
+    rethrowAsProviderError(err);
   }
-
-  const data = (await res.json()) as {
-    incoming_phone_numbers: Array<{ sid: string; phone_number: string }>;
-  };
-
-  const match = data.incoming_phone_numbers.find(
-    (n) => n.phone_number === phoneNumber,
-  );
-  return match?.sid ?? null;
 }
 
 /**

package/src/calls/twilio-routes.ts

@@ -21,11 +21,13 @@
  *   server-side.
  */
 
-import { loadConfig } from "../config/loader.js";
 import {
-  getTwilioMediaStreamUrl,
-  getTwilioRelayUrl,
-} from "../inbound/public-ingress-urls.js";
+  buildTwilioMediaStreamUrl,
+  buildTwilioRelayUrl,
+  TWILIO_PUBLIC_BASE_URL_PLACEHOLDER,
+} from "@vellumai/service-contracts/twilio-ingress";
+
+import { loadConfig } from "../config/loader.js";
 import { getProviderEntry } from "../providers/speech-to-text/provider-catalog.js";
 import {
   BadRequestError,
@@ -444,7 +446,6 @@ function buildVoiceWebhookTwiml(
     // calls don't fail entirely on a misconfigured provider.
     return buildConversationRelayTwiml(
       callSessionId,
-      cfg,
       profile,
       sessionContext,
       verificationSessionId,
@@ -457,7 +458,6 @@ function buildVoiceWebhookTwiml(
   if (strategy.strategy === "conversation-relay-native") {
     return buildConversationRelayTwiml(
       callSessionId,
-      cfg,
       profile,
       sessionContext,
       verificationSessionId,
@@ -500,7 +500,6 @@ function buildVoiceWebhookTwiml(
     // through the relay server which supports it natively.
     return buildConversationRelayTwiml(
       callSessionId,
-      cfg,
       profile,
       sessionContext,
       verificationSessionId,
@@ -508,7 +507,7 @@ function buildVoiceWebhookTwiml(
     );
   }
 
-  return buildMediaStreamTwiml(callSessionId, cfg, verificationSessionId);
+  return buildMediaStreamTwiml(callSessionId, verificationSessionId);
 }
 
 /**
@@ -516,7 +515,6 @@ function buildVoiceWebhookTwiml(
  */
 function buildConversationRelayTwiml(
   callSessionId: string,
-  cfg: ReturnType<typeof loadConfig>,
   profile: ReturnType<typeof resolveVoiceQualityProfile>,
   sessionContext: {
     task: string | null;
@@ -538,7 +536,7 @@ function buildConversationRelayTwiml(
     interruptSensitivity: profile.interruptSensitivity,
   };
 
-  const relayUrl = getTwilioRelayUrl(cfg);
+  const relayUrl = buildTwilioRelayUrl(TWILIO_PUBLIC_BASE_URL_PLACEHOLDER);
   const welcomeGreeting = buildWelcomeGreeting(sessionContext?.task ?? null);
   const relayToken = TWILIO_RELAY_TOKEN_PLACEHOLDER;
 
@@ -572,10 +570,11 @@ function buildConversationRelayTwiml(
  */
 function buildMediaStreamTwiml(
   callSessionId: string,
-  cfg: ReturnType<typeof loadConfig>,
   verificationSessionId: string | null | undefined,
 ): string {
-  const streamUrl = getTwilioMediaStreamUrl(cfg);
+  const streamUrl = buildTwilioMediaStreamUrl(
+    TWILIO_PUBLIC_BASE_URL_PLACEHOLDER,
+  );
   const relayToken = TWILIO_RELAY_TOKEN_PLACEHOLDER;
 
   const customParameters: Record<string, string> | undefined =

package/src/channels/types.ts

@@ -91,17 +91,18 @@ export function isInteractiveInterface(id: InterfaceId): boolean {
 
 /**
  * Host proxy capabilities that an interface can support. The macOS client
- * supports all four; the chrome-extension interface only supports
+ * supports all five; the chrome-extension interface only supports
  * host_browser (via the Chrome DevTools Protocol proxy).
  */
 export type HostProxyCapability =
   | "host_bash"
   | "host_file"
   | "host_cu"
-  | "host_browser";
+  | "host_browser"
+  | "host_app_control";
 
 /**
- * Interfaces that support the full desktop host-proxy set (all four
+ * Interfaces that support the full desktop host-proxy set (all five
  * `HostProxyCapability` values). This is the capability-level identity used
  * by the discriminated transport metadata union and by the
  * `supportsHostProxy(id)` type predicate.
@@ -135,10 +136,10 @@ export function supportsHostProxy(
   id: InterfaceId,
   capability?: HostProxyCapability,
 ): boolean {
-  // macOS supports all four host proxy capabilities including host_browser.
-  // The host_browser proxy is provisioned via the assistant event hub. When no
-  // extension is connected, browser tools fall through to cdp-inspect/local
-  // via the CDP factory's candidate chain.
+  // macOS supports all five host proxy capabilities including host_browser
+  // and host_app_control. The host_browser proxy is provisioned via the
+  // assistant event hub. When no extension is connected, browser tools fall
+  // through to cdp-inspect/local via the CDP factory's candidate chain.
   if (id === "macos") return true;
   if (id === "chrome-extension" && capability === "host_browser") return true;
   return false;