@vellumai/assistant 0.7.1 → 0.7.3

package/src/__tests__/conversation-routes-guardian-reply.test.ts

@@ -172,13 +172,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       hasPendingConfirmation: () => false,
       setHostBrowserProxy: () => {},
       setHostCuProxy: () => {},
+      setHostAppControlProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
     } as unknown as import("../daemon/conversation.js").Conversation;
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
+      headers: {
+        "Content-Type": "application/json",
+        "x-vellum-actor-principal-id": "test-user",
+        "x-vellum-principal-type": "actor",
+      },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "05BECB approve",
@@ -188,17 +193,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
     });
 
     const res = await callHandler(
-      (args) => handleSendMessage(args, {
-        sendMessageDeps: {
-          getOrCreateConversation: async () => session,
-          assistantEventHub: { publish: async () => {} } as any,
-          resolveAttachments: () => [],
-        },
-      }),
+      (args) =>
+        handleSendMessage(args, {
+          sendMessageDeps: {
+            getOrCreateConversation: async () => session,
+            assistantEventHub: { publish: async () => {} } as any,
+            resolveAttachments: () => [],
+          },
+        }),
       req,
       undefined,
       202,
-      );
+    );
 
     expect(res.status).toBe(202);
     const body = (await res.json()) as {
@@ -250,13 +256,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       hasPendingConfirmation: () => false,
       setHostBrowserProxy: () => {},
       setHostCuProxy: () => {},
+      setHostAppControlProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
     } as unknown as import("../daemon/conversation.js").Conversation;
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
+      headers: {
+        "Content-Type": "application/json",
+        "x-vellum-actor-principal-id": "test-user",
+        "x-vellum-principal-type": "actor",
+      },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "hello there",
@@ -266,17 +277,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
     });
 
     const res = await callHandler(
-      (args) => handleSendMessage(args, {
-        sendMessageDeps: {
-          getOrCreateConversation: async () => session,
-          assistantEventHub: { publish: async () => {} } as any,
-          resolveAttachments: () => [],
-        },
-      }),
+      (args) =>
+        handleSendMessage(args, {
+          sendMessageDeps: {
+            getOrCreateConversation: async () => session,
+            assistantEventHub: { publish: async () => {} } as any,
+            resolveAttachments: () => [],
+          },
+        }),
       req,
       undefined,
       202,
-      );
+    );
 
     expect(res.status).toBe(202);
     expect(routeGuardianReplyMock).toHaveBeenCalledTimes(1);
@@ -324,13 +336,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
         requestId === "tool-approval-live",
       setHostBrowserProxy: () => {},
       setHostCuProxy: () => {},
+      setHostAppControlProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
     } as unknown as import("../daemon/conversation.js").Conversation;
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
+      headers: {
+        "Content-Type": "application/json",
+        "x-vellum-actor-principal-id": "test-user",
+        "x-vellum-principal-type": "actor",
+      },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "approve",
@@ -340,17 +357,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
     });
 
     const res = await callHandler(
-      (args) => handleSendMessage(args, {
-        sendMessageDeps: {
-          getOrCreateConversation: async () => session,
-          assistantEventHub: { publish: async () => {} } as any,
-          resolveAttachments: () => [],
-        },
-      }),
+      (args) =>
+        handleSendMessage(args, {
+          sendMessageDeps: {
+            getOrCreateConversation: async () => session,
+            assistantEventHub: { publish: async () => {} } as any,
+            resolveAttachments: () => [],
+          },
+        }),
       req,
       undefined,
       202,
-      );
+    );
 
     expect(res.status).toBe(202);
     expect(routeGuardianReplyMock).toHaveBeenCalledTimes(1);
@@ -402,13 +420,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       hasPendingConfirmation: (id: string) => id === "tool-req-code-1",
       setHostBrowserProxy: () => {},
       setHostCuProxy: () => {},
+      setHostAppControlProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
     } as unknown as import("../daemon/conversation.js").Conversation;
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
+      headers: {
+        "Content-Type": "application/json",
+        "x-vellum-actor-principal-id": "test-user",
+        "x-vellum-principal-type": "actor",
+      },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "A1B2C3 approve",
@@ -418,17 +441,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
     });
 
     const res = await callHandler(
-      (args) => handleSendMessage(args, {
-        sendMessageDeps: {
-          getOrCreateConversation: async () => session,
-          assistantEventHub: { publish: async () => {} } as any,
-          resolveAttachments: () => [],
-        },
-      }),
+      (args) =>
+        handleSendMessage(args, {
+          sendMessageDeps: {
+            getOrCreateConversation: async () => session,
+            assistantEventHub: { publish: async () => {} } as any,
+            resolveAttachments: () => [],
+          },
+        }),
       req,
       undefined,
       202,
-      );
+    );
 
     expect(res.status).toBe(202);
     expect(routeGuardianReplyMock).toHaveBeenCalledTimes(1);
@@ -476,13 +500,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       hasPendingConfirmation: (id: string) => id === "pending-reject-1",
       setHostBrowserProxy: () => {},
       setHostCuProxy: () => {},
+      setHostAppControlProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
     } as unknown as import("../daemon/conversation.js").Conversation;
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
+      headers: {
+        "Content-Type": "application/json",
+        "x-vellum-actor-principal-id": "test-user",
+        "x-vellum-principal-type": "actor",
+      },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "reject",
@@ -492,17 +521,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
     });
 
     const res = await callHandler(
-      (args) => handleSendMessage(args, {
-        sendMessageDeps: {
-          getOrCreateConversation: async () => session,
-          assistantEventHub: { publish: async () => {} } as any,
-          resolveAttachments: () => [],
-        },
-      }),
+      (args) =>
+        handleSendMessage(args, {
+          sendMessageDeps: {
+            getOrCreateConversation: async () => session,
+            assistantEventHub: { publish: async () => {} } as any,
+            resolveAttachments: () => [],
+          },
+        }),
       req,
       undefined,
       202,
-      );
+    );
 
     expect(res.status).toBe(202);
     expect(routeGuardianReplyMock).toHaveBeenCalledTimes(1);
@@ -544,13 +574,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       hasPendingConfirmation: (id: string) => id === "pending-1",
       setHostBrowserProxy: () => {},
       setHostCuProxy: () => {},
+      setHostAppControlProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
     } as unknown as import("../daemon/conversation.js").Conversation;
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
+      headers: {
+        "Content-Type": "application/json",
+        "x-vellum-actor-principal-id": "test-user",
+        "x-vellum-principal-type": "actor",
+      },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "tell me more about this request",
@@ -560,17 +595,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
     });
 
     const res = await callHandler(
-      (args) => handleSendMessage(args, {
-        sendMessageDeps: {
-          getOrCreateConversation: async () => session,
-          assistantEventHub: { publish: async () => {} } as any,
-          resolveAttachments: () => [],
-        },
-      }),
+      (args) =>
+        handleSendMessage(args, {
+          sendMessageDeps: {
+            getOrCreateConversation: async () => session,
+            assistantEventHub: { publish: async () => {} } as any,
+            resolveAttachments: () => [],
+          },
+        }),
       req,
       undefined,
       202,
-      );
+    );
 
     expect(res.status).toBe(202);
     expect(routeGuardianReplyMock).toHaveBeenCalledTimes(1);
@@ -614,13 +650,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       hasPendingConfirmation: () => false,
       setHostBrowserProxy: () => {},
       setHostCuProxy: () => {},
+      setHostAppControlProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
     } as unknown as import("../daemon/conversation.js").Conversation;
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
+      headers: {
+        "Content-Type": "application/json",
+        "x-vellum-actor-principal-id": "test-user",
+        "x-vellum-principal-type": "actor",
+      },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "no sorry, beats 0 and 3 should be new threads",
@@ -630,14 +671,15 @@ describe("handleSendMessage canonical guardian reply interception", () => {
     });
 
     await callHandler(
-      (args) => handleSendMessage(args, {
-        sendMessageDeps: {
-          getOrCreateConversation: async () => session,
-          assistantEventHub: { publish: async () => {} } as any,
-          resolveAttachments: () => [],
-        },
-        approvalConversationGenerator: mockGenerator as any,
-      }),
+      (args) =>
+        handleSendMessage(args, {
+          sendMessageDeps: {
+            getOrCreateConversation: async () => session,
+            assistantEventHub: { publish: async () => {} } as any,
+            resolveAttachments: () => [],
+          },
+          approvalConversationGenerator: mockGenerator as any,
+        }),
       req,
       undefined,
       202,
@@ -685,13 +727,18 @@ describe("handleSendMessage canonical guardian reply interception", () => {
       hasPendingConfirmation: () => false,
       setHostBrowserProxy: () => {},
       setHostCuProxy: () => {},
+      setHostAppControlProxy: () => {},
       restoreBrowserProxyAvailability: () => {},
       addPreactivatedSkillId: () => {},
     } as unknown as import("../daemon/conversation.js").Conversation;
 
     const req = new Request("http://localhost/v1/messages", {
       method: "POST",
-      headers: { "Content-Type": "application/json", "x-vellum-actor-principal-id": "test-user", "x-vellum-principal-type": "actor" },
+      headers: {
+        "Content-Type": "application/json",
+        "x-vellum-actor-principal-id": "test-user",
+        "x-vellum-principal-type": "actor",
+      },
       body: JSON.stringify({
         conversationKey: "guardian-conversation-key",
         content: "no sorry, beats 0 and 3 should be new threads",
@@ -701,14 +748,15 @@ describe("handleSendMessage canonical guardian reply interception", () => {
     });
 
     await callHandler(
-      (args) => handleSendMessage(args, {
-        sendMessageDeps: {
-          getOrCreateConversation: async () => session,
-          assistantEventHub: { publish: async () => {} } as any,
-          resolveAttachments: () => [],
-        },
-        approvalConversationGenerator: mockGenerator as any,
-      }),
+      (args) =>
+        handleSendMessage(args, {
+          sendMessageDeps: {
+            getOrCreateConversation: async () => session,
+            assistantEventHub: { publish: async () => {} } as any,
+            resolveAttachments: () => [],
+          },
+          approvalConversationGenerator: mockGenerator as any,
+        }),
       req,
       undefined,
       202,

package/src/__tests__/conversation-routes-slash-commands.test.ts

@@ -260,6 +260,7 @@ function makeConversation() {
     hasPendingConfirmation: () => false,
     setHostBrowserProxy: () => {},
     setHostCuProxy: () => {},
+    setHostAppControlProxy: () => {},
     addPreactivatedSkillId: () => {},
     usageStats: {
       inputTokens: 1000,

package/src/__tests__/conversation-runtime-assembly.test.ts

@@ -1,5 +1,12 @@
 import { beforeEach, describe, expect, mock, test } from "bun:test";
 
+import { _setOverridesForTesting } from "../config/assistant-feature-flags.js";
+
+// This test exercises v1 conversation routing. The `memory-v2-enabled` flag
+// (registry default `true`) flips memory routing to v2 — disable it here so
+// the v1 paths under test stay active.
+_setOverridesForTesting({ "memory-v2-enabled": false });
+
 // PKB search is mocked so the reminder-hints tests can assert behavior
 // without standing up Qdrant. The mock returns whatever is staged in
 // `pkbSearchResults` / `pkbSearchThrows` for the enclosing test.
@@ -1430,6 +1437,64 @@ describe("buildUnifiedTurnContextBlock", () => {
     expect(text).toContain("time_since_last_message: yesterday");
     expect(text).toContain("canonical_actor_identity: user-1");
   });
+
+  test("timezone mismatch: omits extra lines when there is no manual override", () => {
+    const text = buildUnifiedTurnContextBlock({
+      timestamp: "2026-04-02 (Thursday) 08:00:00 -04:00 (America/New_York)",
+      clientTimezone: "America/New_York",
+      detectedTimezone: "America/New_York",
+    });
+
+    expect(text).toContain(
+      "current_time: 2026-04-02 (Thursday) 08:00:00 -04:00 (America/New_York)",
+    );
+    expect(text).not.toContain("configured_user_timezone:");
+    expect(text).not.toContain("client_device_timezone:");
+    expect(text).not.toContain("timezone_update_available:");
+  });
+
+  test("timezone mismatch: omits extra lines when configured and client timezone match", () => {
+    const text = buildUnifiedTurnContextBlock({
+      timestamp: "2026-04-02 (Thursday) 08:00:00 -04:00 (America/New_York)",
+      configuredUserTimezone: "America/New_York",
+      clientTimezone: "America/New_York",
+      detectedTimezone: "America/New_York",
+    });
+
+    expect(text).not.toContain("configured_user_timezone:");
+    expect(text).not.toContain("client_device_timezone:");
+    expect(text).not.toContain("timezone_update_available:");
+  });
+
+  test("timezone mismatch: emits configured and client device timezone when they differ", () => {
+    const text = buildUnifiedTurnContextBlock({
+      timestamp: "2026-04-02 (Thursday) 08:00:00 -04:00 (America/New_York)",
+      configuredUserTimezone: "America/New_York",
+      clientTimezone: "America/Los_Angeles",
+      detectedTimezone: "America/Los_Angeles",
+    });
+
+    expect(text).toContain("configured_user_timezone: America/New_York");
+    expect(text).toContain("client_device_timezone: America/Los_Angeles");
+  });
+
+  test("timezone mismatch: emits CLI affordance only in mismatch case", () => {
+    const mismatchText = buildUnifiedTurnContextBlock({
+      timestamp: "2026-04-02 (Thursday) 08:00:00 -04:00 (America/New_York)",
+      configuredUserTimezone: "America/New_York",
+      clientTimezone: "America/Los_Angeles",
+    });
+    const matchingText = buildUnifiedTurnContextBlock({
+      timestamp: "2026-04-02 (Thursday) 08:00:00 -04:00 (America/New_York)",
+      configuredUserTimezone: "America/New_York",
+      clientTimezone: "America/New_York",
+    });
+
+    expect(mismatchText).toContain(
+      'timezone_update_available: after explicit user confirmation, persist client_device_timezone with `assistant config set ui.userTimezone "America/Los_Angeles"`',
+    );
+    expect(matchingText).not.toContain("timezone_update_available:");
+  });
 });
 
 // ---------------------------------------------------------------------------

package/src/__tests__/conversation-slash-commands.test.ts

@@ -115,8 +115,6 @@ describe("resolveSlash command contract", () => {
       "/context foo",
       "/models foo",
       "/status foo",
-      "/pair foo",
-      "/pair",
       "/btw",
     ];
 
@@ -138,7 +136,6 @@ describe("classifySlash is a pure classifier matching resolveSlash kinds", () =>
     input: string;
     kind: "passthrough" | "compact" | "unknown";
   }> = [
-    { input: "/pair", kind: "passthrough" },
     { input: "/models", kind: "unknown" },
     { input: "/context", kind: "unknown" },
     { input: "/status", kind: "unknown" },
@@ -149,7 +146,6 @@ describe("classifySlash is a pure classifier matching resolveSlash kinds", () =>
     { input: "/opus", kind: "unknown" },
     { input: "hello", kind: "passthrough" },
     { input: "  /compact  ", kind: "compact" },
-    { input: "/pair foo", kind: "passthrough" },
     { input: "/models foo", kind: "passthrough" },
   ];
 

package/src/__tests__/conversation-slash-unknown.test.ts

@@ -5,9 +5,15 @@ import type {
   CheckpointDecision,
   CheckpointInfo,
 } from "../agent/loop.js";
+import { _setOverridesForTesting } from "../config/assistant-feature-flags.js";
 import type { ServerMessage } from "../daemon/message-protocol.js";
 import type { Message, ProviderResponse } from "../providers/types.js";
 
+// This test exercises v1 conversation routing. The `memory-v2-enabled` flag
+// (registry default `true`) flips memory routing to v2 — disable it here so
+// the v1 paths under test stay active.
+_setOverridesForTesting({ "memory-v2-enabled": false });
+
 // ---------------------------------------------------------------------------
 // Mocks — must precede the Conversation import so Bun applies them at load time.
 // ---------------------------------------------------------------------------

package/src/__tests__/conversation-speed-override.test.ts

@@ -294,7 +294,6 @@ describe("per-conversation speed override", () => {
       4096,
       makeSendToClient(),
       "/tmp",
-      undefined, // memoryPolicy
       undefined, // sharedCesClient
       "standard", // speedOverride
     );
@@ -315,7 +314,6 @@ describe("per-conversation speed override", () => {
       4096,
       makeSendToClient(),
       "/tmp",
-      undefined, // memoryPolicy
       undefined, // sharedCesClient
       // no speedOverride — should fall back to global config "fast"
     );
@@ -335,7 +333,6 @@ describe("per-conversation speed override", () => {
       4096,
       makeSendToClient(),
       "/tmp",
-      undefined, // memoryPolicy
       undefined, // sharedCesClient
       "fast", // speedOverride
     );

package/src/__tests__/conversation-store.test.ts

@@ -19,7 +19,6 @@ import {
   createConversation,
   deleteLastExchange,
   getConversation,
-  getConversationMemoryScopeId,
   getMessages,
 } from "../memory/conversation-crud.js";
 import { isLastUserMessageToolResult } from "../memory/conversation-queries.js";
@@ -454,23 +453,6 @@ describe("createConversation with conversation type option", () => {
   });
 });
 
-describe("conversation metadata read helpers", () => {
-  beforeEach(() => {
-    const db = getDb();
-    db.run(`DELETE FROM messages`);
-    db.run(`DELETE FROM conversations`);
-  });
-
-  test("getConversationMemoryScopeId returns default for standard conversation", () => {
-    const conv = createConversation("test");
-    expect(getConversationMemoryScopeId(conv.id)).toBe("default");
-  });
-
-  test("getConversationMemoryScopeId returns default for missing conversation", () => {
-    expect(getConversationMemoryScopeId("nonexistent-id")).toBe("default");
-  });
-});
-
 // ---------------------------------------------------------------------------
 // Baseline: attachment reuse across conversations
 // ---------------------------------------------------------------------------