@vellumai/assistant 0.7.1 → 0.7.3

package/src/oauth/seed-providers.ts

@@ -393,6 +393,7 @@ export const PROVIDER_SEED_DATA: Record<
       { scope: "project:delete", description: "Delete entire projects" },
     ],
     loopbackPort: 17325,
+    managedServiceConfigKey: "todoist-oauth",
     injectionTemplates: [
       {
         hostPattern: "api.todoist.com",
@@ -402,7 +403,7 @@ export const PROVIDER_SEED_DATA: Record<
       },
     ],
     appType: "App",
-    identityUrl: "https://api.todoist.com/sync/v9/sync",
+    identityUrl: "https://api.todoist.com/api/v1/sync",
     identityMethod: "POST",
     identityHeaders: { "Content-Type": "application/x-www-form-urlencoded" },
     identityBody: "sync_token=*&resource_types=[%22user%22]",
@@ -429,6 +430,7 @@ export const PROVIDER_SEED_DATA: Record<
     availableScopes:
       "https://discord.com/developers/docs/topics/oauth2#shared-resources-oauth2-scopes",
     loopbackPort: 17326,
+    managedServiceConfigKey: "discord-oauth",
     injectionTemplates: [
       {
         hostPattern: "discord.com",
@@ -497,6 +499,7 @@ export const PROVIDER_SEED_DATA: Record<
     defaultScopes: ["default"],
     availableScopes: "https://developers.asana.com/docs/oauth-scopes",
     loopbackPort: 17328,
+    managedServiceConfigKey: "asana-oauth",
     injectionTemplates: [
       {
         hostPattern: "app.asana.com",
@@ -563,6 +566,7 @@ export const PROVIDER_SEED_DATA: Record<
     availableScopes:
       "https://developers.hubspot.com/docs/guides/apps/authentication/scopes",
     loopbackPort: 17330,
+    managedServiceConfigKey: "hubspot-oauth",
     injectionTemplates: [
       {
         hostPattern: "api.hubapi.com",
@@ -576,6 +580,59 @@ export const PROVIDER_SEED_DATA: Record<
     identityResponsePaths: ["user", "hub_domain"],
   },
 
+  salesforce: {
+    provider: "salesforce",
+    authorizeUrl: "https://login.salesforce.com/services/oauth2/authorize",
+    tokenExchangeUrl: "https://login.salesforce.com/services/oauth2/token",
+    refreshUrl: "https://login.salesforce.com/services/oauth2/token",
+    pingUrl: "https://login.salesforce.com/services/oauth2/userinfo",
+    // baseUrl points at the login domain — correct for the OAuth handshake
+    // and for ``/services/oauth2/userinfo``/``revoke`` calls. REST API calls
+    // to ``/services/data/...`` go to the per-org instance host returned in
+    // the token response as ``instance_url`` and stored on
+    // ``oauth_connection.metadata``. ``connection-resolver.ts`` substitutes
+    // that instance URL when constructing the BYO connection so callers
+    // don't need to override ``baseUrl`` per request.
+    baseUrl: "https://login.salesforce.com",
+    displayLabel: "Salesforce",
+    description: "CRM contacts, leads, and opportunities",
+    dashboardUrl:
+      "https://help.salesforce.com/s/articleView?id=sf.connected_app_create.htm&type=5",
+    clientIdPlaceholder: null,
+    logoUrl:
+      "https://cdn.jsdelivr.net/gh/glincker/thesvg@main/public/icons/salesforce/default.svg",
+    defaultScopes: ["api", "refresh_token", "openid", "email", "profile"],
+    availableScopes:
+      "https://help.salesforce.com/s/articleView?id=sf.remoteaccess_oauth_tokens_scopes.htm",
+    authorizeParams: { prompt: "consent" },
+    tokenEndpointAuthMethod: "client_secret_post",
+    loopbackPort: 17336,
+    // Salesforce REST traffic goes to per-org instance hosts like
+    // ``acme.my.salesforce.com`` and ``acme.lightning.force.com``.
+    // ``matchHostPattern`` only treats ``*.<domain>`` as a wildcard match —
+    // bare ``salesforce.com`` would only match the apex. Use wildcards so
+    // ``Authorization: Bearer`` injection actually fires on tenant hosts.
+    injectionTemplates: [
+      {
+        hostPattern: "*.salesforce.com",
+        injectionType: "header",
+        headerName: "Authorization",
+        valuePrefix: "Bearer ",
+      },
+      {
+        hostPattern: "*.force.com",
+        injectionType: "header",
+        headerName: "Authorization",
+        valuePrefix: "Bearer ",
+      },
+    ],
+    revokeUrl: "https://login.salesforce.com/services/oauth2/revoke",
+    revokeBodyTemplate: { token: "{access_token}" },
+    appType: "Connected App",
+    identityUrl: "https://login.salesforce.com/services/oauth2/userinfo",
+    identityResponsePaths: ["email", "preferred_username"],
+  },
+
   figma: {
     provider: "figma",
     authorizeUrl: "https://www.figma.com/oauth",

package/src/outbound-proxy/index.ts

@@ -3,40 +3,11 @@
 // ---------------------------------------------------------------------------
 
 export type {
-  CredentialInjectionTemplate,
-  CredentialInjectionType,
   PolicyDecision,
-  PolicyDecisionAmbiguous,
-  PolicyDecisionAskMissingCredential,
-  PolicyDecisionAskUnauthenticated,
-  PolicyDecisionMatched,
-  PolicyDecisionMissing,
-  PolicyDecisionUnauthenticated,
   ProxyApprovalCallback,
   ProxyApprovalRequest,
-  ProxyEnvVars,
-  ProxySession,
-  ProxySessionConfig,
-  ProxySessionId,
-  ProxySessionStatus,
-  RequestTargetContext,
 } from "@vellumai/egress-proxy";
 
-// ---------------------------------------------------------------------------
-// Conversation core — re-exported from @vellumai/egress-proxy shared package
-// ---------------------------------------------------------------------------
-
-export type { ManagedSession, SessionStartHooks } from "@vellumai/egress-proxy";
-
-// ---------------------------------------------------------------------------
-// Host pattern matching
-// ---------------------------------------------------------------------------
-
-export type {
-  HostMatchKind,
-  MatchHostPatternOptions,
-} from "./host-pattern-match.js";
-
 // Certificate management
 export {
   ensureCombinedCABundle,
@@ -49,7 +20,6 @@ export {
 export type { RewriteCallback } from "./mitm-handler.js";
 
 // Router
-export type { RouteDecision, RouteReason } from "./router.js";
 export { routeConnection } from "./router.js";
 
 // CONNECT tunnel
@@ -60,15 +30,9 @@ export { evaluateRequest, evaluateRequestWithApproval } from "./policy.js";
 // HTTP forwarder
 
 // Proxy server
-export type { MitmHandlerConfig, ProxyServerConfig } from "./server.js";
+export type { ProxyServerConfig } from "./server.js";
 export { createProxyServer } from "./server.js";
 
-// Sidecar configuration
-export type { SidecarConfig } from "./config.js";
-
-// Health / readiness server
-export type { HealthServerOptions } from "./health.js";
-
 // Logging/diagnostics
 export type { CredentialRefTrace, ProxyDecisionTrace } from "./logging.js";
 export {

package/src/outbound-proxy/logging.ts

@@ -7,7 +7,7 @@
  * candidate counts.
  */
 
-import type { PolicyDecision } from "./types.js";
+import type { PolicyDecision } from "@vellumai/egress-proxy";
 
 const REDACTED = "[REDACTED]";
 

package/src/outbound-proxy/policy.ts

@@ -3,16 +3,17 @@
  * injection templates and emits deterministic policy decisions.
  */
 
+import type {
+  CredentialInjectionTemplate,
+  PolicyDecision,
+  RequestTargetContext,
+} from "@vellumai/egress-proxy";
+
 import {
   compareMatchSpecificity,
   type HostMatchKind,
   matchHostPattern,
 } from "./host-pattern-match.js";
-import type {
-  CredentialInjectionTemplate,
-  PolicyDecision,
-  RequestTargetContext,
-} from "./types.js";
 
 interface MatchCandidate {
   credentialId: string;

package/src/outbound-proxy/router.ts

@@ -7,8 +7,9 @@
  * pay the cost of TLS termination, cert issuance, and request rewriting.
  */
 
+import type { CredentialInjectionTemplate } from "@vellumai/egress-proxy";
+
 import { matchHostPattern } from "./host-pattern-match.js";
-import type { CredentialInjectionTemplate } from "./types.js";
 
 // ---- Public types ----------------------------------------------------------
 

package/src/permissions/approval-policy.test.ts

@@ -1,7 +1,7 @@
 import { describe, expect, test } from "bun:test";
 
 import type { ApprovalContext, ApprovalDecision } from "./approval-policy.js";
-import { DefaultApprovalPolicy, resolveThreshold } from "./approval-policy.js";
+import { DefaultApprovalPolicy } from "./approval-policy.js";
 import type { TrustRule } from "./types.js";
 import { RiskLevel } from "./types.js";
 
@@ -74,7 +74,11 @@ describe("ask rule", () => {
   const askRule = makeRule({ decision: "ask" });
 
   test("ask at Low risk", () => {
-    const result = evaluate({ riskLevel: RiskLevel.Low, matchedRule: askRule, autoApproveUpTo: "none" });
+    const result = evaluate({
+      riskLevel: RiskLevel.Low,
+      matchedRule: askRule,
+      autoApproveUpTo: "none",
+    });
     expect(result.decision).toBe("prompt");
     expect(result.reason).toContain("ask rule");
     expect(result.matchedRule).toBe(askRule);
@@ -965,276 +969,3 @@ describe("autoApproveUpTo threshold", () => {
     });
   });
 });
-
-// ── resolveThreshold ─────────────────────────────────────────────────────────
-
-describe("resolveThreshold", () => {
-  describe("scalar form", () => {
-    test("returns scalar for conversation context", () => {
-      expect(resolveThreshold("low", "conversation")).toBe("low");
-    });
-
-    test("returns scalar for background context", () => {
-      expect(resolveThreshold("medium", "background")).toBe("medium");
-    });
-
-    test("returns scalar for headless context", () => {
-      expect(resolveThreshold("none", "headless")).toBe("none");
-    });
-
-    test("returns high scalar for any context", () => {
-      expect(resolveThreshold("high", "conversation")).toBe("high");
-      expect(resolveThreshold("high", "background")).toBe("high");
-      expect(resolveThreshold("high", "headless")).toBe("high");
-    });
-
-    test("returns scalar when executionContext is omitted", () => {
-      expect(resolveThreshold("low")).toBe("low");
-    });
-  });
-
-  describe("object form", () => {
-    const perContext = {
-      conversation: "low" as const,
-      autonomous: "medium" as const,
-    };
-
-    test("returns conversation threshold for conversation context", () => {
-      expect(resolveThreshold(perContext, "conversation")).toBe("low");
-    });
-
-    test("returns autonomous threshold for background context", () => {
-      expect(resolveThreshold(perContext, "background")).toBe("medium");
-    });
-
-    test("returns autonomous threshold for headless context", () => {
-      expect(resolveThreshold(perContext, "headless")).toBe("medium");
-    });
-
-    test("defaults to conversation when executionContext is omitted", () => {
-      expect(resolveThreshold(perContext)).toBe("low");
-    });
-  });
-
-  describe("per-context thresholds in policy evaluation", () => {
-    test("conversation context with low threshold prompts medium risk", () => {
-      const result = evaluate({
-        riskLevel: RiskLevel.Medium,
-        toolName: "some_tool",
-        autoApproveUpTo: "low",
-      });
-      expect(result.decision).toBe("prompt");
-    });
-
-    test("background context with medium threshold allows medium risk", () => {
-      const result = evaluate({
-        riskLevel: RiskLevel.Medium,
-        toolName: "some_tool",
-        autoApproveUpTo: "medium",
-      });
-      expect(result.decision).toBe("allow");
-      expect(result.reason).toContain("within auto-approve threshold");
-    });
-
-    test("headless context with none threshold prompts low risk", () => {
-      const result = evaluate({
-        riskLevel: RiskLevel.Low,
-        toolName: "some_tool",
-        autoApproveUpTo: "none",
-      });
-      expect(result.decision).toBe("prompt");
-      expect(result.reason).toContain("above auto-approve threshold");
-    });
-
-    test("background context with medium threshold prompts high risk", () => {
-      const result = evaluate({
-        riskLevel: RiskLevel.High,
-        toolName: "some_tool",
-        autoApproveUpTo: "medium",
-      });
-      expect(result.decision).toBe("prompt");
-      expect(result.reason).toContain("above auto-approve threshold");
-    });
-  });
-});
-
-// ── Guardian threshold-based auto-approve ────────────────────────────────────
-// These tests verify the ordinal comparison used in permission-checker.ts
-// to decide whether a guardian non-interactive session should auto-approve.
-// The comparison logic: riskOrdinal <= thresholdOrdinal.
-
-describe("guardian threshold-based auto-approve (ordinal comparison)", () => {
-  // Helper that mirrors the ordinal comparison from permission-checker.ts.
-  // This is the logic that replaces the old `riskLevel !== RiskLevel.High` check.
-  function isWithinThreshold(
-    riskLevel: RiskLevel,
-    bgThreshold: "none" | "low" | "medium" | "high",
-  ): boolean {
-    const thresholdOrdinal: Record<string, number> = {
-      none: -1,
-      low: 0,
-      medium: 1,
-      high: 2,
-    };
-    const riskOrdinal: Record<string, number> = {
-      [RiskLevel.Low]: 0,
-      [RiskLevel.Medium]: 1,
-      [RiskLevel.High]: 2,
-    };
-    return (
-      (riskOrdinal[riskLevel] ?? 2) <= (thresholdOrdinal[bgThreshold] ?? 0)
-    );
-  }
-
-  describe('default config (autonomous: "medium") — behavioral parity with old riskLevel !== High', () => {
-    test("Low risk → within threshold (auto-approve)", () => {
-      const bgThreshold = resolveThreshold(
-        { conversation: "low", autonomous: "medium" },
-        "background",
-      );
-      expect(bgThreshold).toBe("medium");
-      expect(isWithinThreshold(RiskLevel.Low, bgThreshold)).toBe(true);
-    });
-
-    test("Medium risk → within threshold (auto-approve)", () => {
-      const bgThreshold = resolveThreshold(
-        { conversation: "low", autonomous: "medium" },
-        "background",
-      );
-      expect(isWithinThreshold(RiskLevel.Medium, bgThreshold)).toBe(true);
-    });
-
-    test("High risk → above threshold (prompt)", () => {
-      const bgThreshold = resolveThreshold(
-        { conversation: "low", autonomous: "medium" },
-        "background",
-      );
-      expect(isWithinThreshold(RiskLevel.High, bgThreshold)).toBe(false);
-    });
-  });
-
-  describe('tighter config (autonomous: "low") — only Low auto-approves', () => {
-    test("Low risk → within threshold", () => {
-      const bgThreshold = resolveThreshold(
-        { conversation: "low", autonomous: "low" },
-        "background",
-      );
-      expect(bgThreshold).toBe("low");
-      expect(isWithinThreshold(RiskLevel.Low, bgThreshold)).toBe(true);
-    });
-
-    test("Medium risk → above threshold (prompt)", () => {
-      const bgThreshold = resolveThreshold(
-        { conversation: "low", autonomous: "low" },
-        "background",
-      );
-      expect(isWithinThreshold(RiskLevel.Medium, bgThreshold)).toBe(false);
-    });
-
-    test("High risk → above threshold (prompt)", () => {
-      const bgThreshold = resolveThreshold(
-        { conversation: "low", autonomous: "low" },
-        "background",
-      );
-      expect(isWithinThreshold(RiskLevel.High, bgThreshold)).toBe(false);
-    });
-  });
-
-  describe('strictest config (autonomous: "none") — nothing auto-approves', () => {
-    test("Low risk → above threshold (prompt)", () => {
-      const bgThreshold = resolveThreshold(
-        { conversation: "low", autonomous: "none" },
-        "background",
-      );
-      expect(bgThreshold).toBe("none");
-      expect(isWithinThreshold(RiskLevel.Low, bgThreshold)).toBe(false);
-    });
-
-    test("Medium risk → above threshold (prompt)", () => {
-      const bgThreshold = resolveThreshold(
-        { conversation: "low", autonomous: "none" },
-        "background",
-      );
-      expect(isWithinThreshold(RiskLevel.Medium, bgThreshold)).toBe(false);
-    });
-
-    test("High risk → above threshold (prompt)", () => {
-      const bgThreshold = resolveThreshold(
-        { conversation: "low", autonomous: "none" },
-        "background",
-      );
-      expect(isWithinThreshold(RiskLevel.High, bgThreshold)).toBe(false);
-    });
-  });
-
-  describe('loosest config (autonomous: "high") — everything auto-approves', () => {
-    test("Low risk → within threshold (auto-approve)", () => {
-      const bgThreshold = resolveThreshold(
-        { conversation: "low", autonomous: "high" },
-        "background",
-      );
-      expect(bgThreshold).toBe("high");
-      expect(isWithinThreshold(RiskLevel.Low, bgThreshold)).toBe(true);
-    });
-
-    test("Medium risk → within threshold (auto-approve)", () => {
-      const bgThreshold = resolveThreshold(
-        { conversation: "low", autonomous: "high" },
-        "background",
-      );
-      expect(isWithinThreshold(RiskLevel.Medium, bgThreshold)).toBe(true);
-    });
-
-    test("High risk → within threshold (auto-approve)", () => {
-      const bgThreshold = resolveThreshold(
-        { conversation: "low", autonomous: "high" },
-        "background",
-      );
-      expect(isWithinThreshold(RiskLevel.High, bgThreshold)).toBe(true);
-    });
-  });
-
-  describe("scalar config form resolves correctly for background context", () => {
-    test('scalar "high" → background resolves to high', () => {
-      expect(resolveThreshold("high", "background")).toBe("high");
-    });
-
-    test('scalar "medium" → background resolves to medium', () => {
-      expect(resolveThreshold("medium", "background")).toBe("medium");
-    });
-
-    test('scalar "low" → background resolves to low', () => {
-      expect(resolveThreshold("low", "background")).toBe("low");
-    });
-
-    test('scalar "none" → background resolves to none', () => {
-      expect(resolveThreshold("none", "background")).toBe("none");
-    });
-  });
-
-  describe("default (undefined) resolves per-context defaults", () => {
-    test("undefined config → low threshold for background", () => {
-      const bgThreshold = resolveThreshold(undefined, "background");
-      expect(bgThreshold).toBe("low");
-      // Low-risk auto-approves at the "low" threshold
-      expect(isWithinThreshold(RiskLevel.Low, bgThreshold)).toBe(true);
-      expect(isWithinThreshold(RiskLevel.Medium, bgThreshold)).toBe(false);
-      expect(isWithinThreshold(RiskLevel.High, bgThreshold)).toBe(false);
-    });
-
-    test("undefined config → medium threshold for conversation", () => {
-      const convThreshold = resolveThreshold(undefined, "conversation");
-      expect(convThreshold).toBe("medium");
-    });
-
-    test("undefined config → low threshold for headless", () => {
-      const hlThreshold = resolveThreshold(undefined, "headless");
-      expect(hlThreshold).toBe("low");
-    });
-
-    test("undefined config + no context → medium (conversation default)", () => {
-      const threshold = resolveThreshold(undefined);
-      expect(threshold).toBe("medium");
-    });
-  });
-});

package/src/permissions/approval-policy.ts

@@ -31,57 +31,6 @@ export interface ApprovalContext {
   autoApproveUpTo?: "none" | "low" | "medium" | "high";
 }
 
-// ── Threshold resolution ─────────────────────────────────────────────────────
-
-/**
- * Per-context defaults when no threshold is provided by the gateway. These
- * mirror the gateway's own defaults and serve as defense-in-depth for tests /
- * direct callers that bypass the IPC path.
- *
- * Note: when a scalar value (e.g. `"low"`) is passed, it applies uniformly to
- * ALL contexts — including autonomous, whose default here is `"low"`. A scalar
- * `"none"` is therefore *more strict* than the autonomous default. This is
- * intentional: the caller explicitly chose a uniform threshold.
- */
-const CONTEXT_DEFAULTS: Record<
-  ExecutionContext,
-  "none" | "low" | "medium" | "high"
-> = {
-  conversation: "medium",
-  background: "low",
-  headless: "low",
-};
-
-type ThresholdScalar = "none" | "low" | "medium" | "high";
-type ThresholdConfig =
-  | ThresholdScalar
-  | { conversation: ThresholdScalar; autonomous: ThresholdScalar };
-
-/**
- * Resolve a threshold config to a scalar threshold for the given execution
- * context.
- *
- * - Scalar string → returned as-is for all contexts
- * - Object with per-context overrides → returns the value for the context
- *   (`background` and `headless` both resolve to the `autonomous` field)
- *
- * When `executionContext` is omitted, defaults to `"conversation"`.
- */
-export function resolveThreshold(
-  configValue: ThresholdConfig | undefined,
-  executionContext?: ExecutionContext,
-): ThresholdScalar {
-  if (configValue == null) {
-    return CONTEXT_DEFAULTS[executionContext ?? "conversation"];
-  }
-  if (typeof configValue === "string") {
-    return configValue;
-  }
-  const ctx = executionContext ?? "conversation";
-  if (ctx === "conversation") return configValue.conversation;
-  return configValue.autonomous;
-}
-
 // ── Ordinal maps for threshold comparison ─────────────────────────────────────
 // Hoisted to module level since these are constant. Unknown enum values
 // conservatively map to the strictest interpretation: risk defaults to 2 (high)

package/src/permissions/checker.test.ts

@@ -25,7 +25,6 @@ mock.module("../config/loader.js", () => ({
   getConfig: () => testConfig,
   loadConfig: () => testConfig,
   invalidateConfigCache: () => {},
-  saveConfig: () => {},
   loadRawConfig: () => ({}),
   saveRawConfig: () => {},
   getNestedValue: () => undefined,

package/src/permissions/checker.ts

@@ -2,7 +2,6 @@ import { createHash } from "node:crypto";
 import { homedir } from "node:os";
 import { dirname, join } from "node:path";
 
-import { isAssistantFeatureFlagEnabled } from "../config/assistant-feature-flags.js";
 import { getIsContainerized } from "../config/env-registry.js";
 import { getConfig } from "../config/loader.js";
 import { loadSkillCatalog, resolveSkillSelector } from "../config/skills.js";
@@ -268,23 +267,17 @@ function resolveSkillMetadata(selector: string): SkillMetadata | undefined {
   const resolved = resolveSkillIdAndHash(selector);
   if (!resolved) return undefined;
 
-  const config = getConfig();
-  const inlineEnabled = isAssistantFeatureFlagEnabled(
-    "inline-skill-commands",
-    config,
-  );
   const inlineExpansions = hasInlineExpansions(resolved.id);
-  const isDynamic = inlineEnabled && inlineExpansions;
 
   return {
     skillId: resolved.id,
     selector,
     versionHash: resolved.versionHash ?? "",
-    transitiveHash: isDynamic
+    transitiveHash: inlineExpansions
       ? computeTransitiveHashSafe(resolved.id)
       : undefined,
     hasInlineExpansions: inlineExpansions,
-    isDynamic,
+    isDynamic: inlineExpansions,
   };
 }
 
@@ -726,14 +719,7 @@ function skillLoadAllowlistStrategy(
   if (rawSelector) {
     const resolved = resolveSkillIdAndHash(rawSelector);
 
-    // Check whether this is a dynamic (inline-command) skill load
-    const config = getConfig();
-    const inlineEnabled = isAssistantFeatureFlagEnabled(
-      "inline-skill-commands",
-      config,
-    );
-
-    if (resolved && inlineEnabled && hasInlineExpansions(resolved.id)) {
+    if (resolved && hasInlineExpansions(resolved.id)) {
       const transitiveHash = computeTransitiveHashSafe(resolved.id);
       const options: AllowlistOption[] = [];
       if (transitiveHash) {

package/src/permissions/gateway-threshold-reader.ts

@@ -20,6 +20,7 @@ type Threshold = "none" | "low" | "medium" | "high";
 interface GlobalThresholds {
   interactive: string;
   autonomous: string;
+  headless: string;
 }
 
 interface ConversationThreshold {
@@ -58,6 +59,7 @@ function mapExecutionContextToField(
   executionContext: ExecutionContext,
 ): keyof GlobalThresholds {
   if (executionContext === "conversation") return "interactive";
+  if (executionContext === "headless") return "headless";
   return "autonomous";
 }