@vellumai/assistant 0.7.0 → 0.7.2

package/src/calls/guardian-question-copy.ts

@@ -6,18 +6,7 @@
  * when the provider is unavailable or generation fails/times out.
  */
 
-import {
-  createTimeout,
-  extractText,
-  resolveConfiguredProvider,
-  userMessage,
-} from "../providers/provider-send-message.js";
-import { getLogger } from "../util/logger.js";
-
-const log = getLogger("guardian-question-copy");
-
 /** Timeout for the generative copy call (ms). */
-const GENERATION_TIMEOUT_MS = 5_000;
 
 export interface GuardianCopy {
   conversationTitle: string;
@@ -39,100 +28,3 @@ export function buildFallbackCopy(questionText: string): GuardianCopy {
     ].join("\n"),
   };
 }
-
-/**
- * Generate guardian conversation copy (title + initial message) via the configured
- * LLM provider. Returns deterministic fallback when the provider is unavailable,
- * generation times out, or any error occurs.
- */
-export async function generateGuardianCopy(
-  questionText: string,
-  requestCode?: string,
-): Promise<GuardianCopy> {
-  const fallback = buildFallbackCopy(questionText);
-
-  // If no provider is configured, return fallback immediately
-  const resolved = await resolveConfiguredProvider("guardianQuestionCopy");
-  if (!resolved) {
-    log.debug(
-      "No provider available for guardian copy generation, using fallback",
-    );
-    return fallback;
-  }
-
-  const { signal, cleanup } = createTimeout(GENERATION_TIMEOUT_MS);
-
-  try {
-    const prompt = [
-      "Generate a conversation title and initial message for a guardian question during a live phone call.",
-      "",
-      `Question: ${questionText}`,
-      ...(requestCode ? [`Reference code: ${requestCode}`] : []),
-      "",
-      "Requirements:",
-      '- TITLE: An emoji-prefixed, attention-oriented, concise title (under 80 characters). Do NOT start with "Guardian question:". Use a relevant warning or alert emoji.',
-      "- MESSAGE: A clear initial message that includes the question text, mentions this is a live phone call waiting for the user's input, and asks them to reply with their answer.",
-      "",
-      "Respond in exactly this format (no extra text):",
-      "TITLE: <your title>",
-      "MESSAGE: <your message>",
-    ].join("\n");
-
-    const response = await resolved.provider.sendMessage(
-      [userMessage(prompt)],
-      undefined,
-      undefined,
-      { signal, config: { callSite: "guardianQuestionCopy" } },
-    );
-
-    const text = extractText(response);
-    const parsed = parseGeneratedCopy(text);
-
-    if (parsed) {
-      return parsed;
-    }
-
-    log.warn(
-      { raw: text },
-      "Failed to parse generated guardian copy, using fallback",
-    );
-    return fallback;
-  } catch (err) {
-    if (signal.aborted) {
-      log.warn("Guardian copy generation timed out, using fallback");
-    } else {
-      log.warn({ err }, "Guardian copy generation failed, using fallback");
-    }
-    return fallback;
-  } finally {
-    cleanup();
-  }
-}
-
-/**
- * Parse the structured TITLE/MESSAGE response from the model.
- * Returns null if the format is not matched.
- */
-function parseGeneratedCopy(text: string): GuardianCopy | null {
-  const titleMatch = text.match(/^TITLE:\s*(.+)/m);
-  const messageMatch = text.match(/^MESSAGE:\s*([\s\S]+)/m);
-
-  if (!titleMatch || !messageMatch) {
-    return null;
-  }
-
-  const title = titleMatch[1].trim();
-  const message = messageMatch[1].trim();
-
-  // Sanity checks: title must be non-empty and under 80 chars, message must be non-empty
-  if (!title || title.length > 80 || !message) {
-    return null;
-  }
-
-  // Reject the old static prefix — the model is guided towards better titles but has final say
-  if (/^guardian question:/i.test(title)) {
-    return null;
-  }
-
-  return { conversationTitle: title, initialMessage: message };
-}

package/src/calls/relay-server.ts

@@ -14,12 +14,6 @@ import {
   findGuardianForChannel,
   listGuardianChannels,
 } from "../contacts/contact-store.js";
-import {
-  createGuardianBinding,
-  revokeGuardianBinding,
-  touchContactInteraction,
-  upsertContactChannel,
-} from "../contacts/contacts-write.js";
 import { getAssistantName } from "../daemon/identity-helpers.js";
 import type { ServerMessage } from "../daemon/message-protocol.js";
 import { getCanonicalGuardianRequest } from "../memory/canonical-guardian-store.js";
@@ -617,13 +611,6 @@ export class RelayConnection {
         this.startNameCapture(outcome.assistantId, outcome.fromNumber);
         return;
       case "verification":
-        if (
-          resolved.actorTrust.memberRecord &&
-          (resolved.actorTrust.trustClass === "guardian" ||
-            resolved.actorTrust.trustClass === "trusted_contact")
-        ) {
-          touchContactInteraction(resolved.actorTrust.memberRecord.channel.id);
-        }
         if (this.controller && resolved.actorTrust.trustClass !== "unknown") {
           this.controller.setTrustContext(
             toTrustContext(resolved.actorTrust, msg.from),
@@ -633,15 +620,6 @@ export class RelayConnection {
         return;
       case "normal_call":
         if (outcome.isInbound) {
-          if (
-            resolved.actorTrust.memberRecord &&
-            (resolved.actorTrust.trustClass === "guardian" ||
-              resolved.actorTrust.trustClass === "trusted_contact")
-          ) {
-            touchContactInteraction(
-              resolved.actorTrust.memberRecord.channel.id,
-            );
-          }
           if (this.controller && resolved.actorTrust.trustClass !== "unknown") {
             this.controller.setTrustContext(
               toTrustContext(resolved.actorTrust, msg.from),
@@ -798,8 +776,6 @@ export class RelayConnection {
   private continueCallAfterTrustedContactActivation(params: {
     assistantId: string;
     fromNumber: string;
-    callerName?: string;
-    skipMemberActivation?: boolean;
     activationReason?:
       | "invite_redeemed"
       | "access_approved"
@@ -807,25 +783,10 @@ export class RelayConnection {
     friendName?: string;
     guardianName?: string;
   }): void {
-    const { assistantId, fromNumber, callerName } = params;
-
-    if (!params.skipMemberActivation) {
-      try {
-        upsertContactChannel({
-          sourceChannel: "phone",
-          externalUserId: fromNumber,
-          externalChatId: fromNumber,
-          displayName: callerName,
-          status: "active",
-          policy: "allow",
-        });
-      } catch (err) {
-        log.error(
-          { err, callSessionId: this.callSessionId },
-          "Failed to activate voice caller as trusted contact",
-        );
-      }
-    }
+    const { assistantId, fromNumber } = params;
+
+    // Contact activation is handled by the gateway — the assistant no
+    // longer writes contact/channel records on inbound voice calls.
 
     const updatedTrust = resolveActorTrust({
       assistantId,
@@ -998,28 +959,6 @@ export class RelayConnection {
         "Guardian voice verification succeeded",
       );
 
-      // Create the guardian binding now that verification succeeded.
-      if (result.verificationType === "guardian") {
-        if (result.bindingConflict) {
-          log.warn(
-            {
-              callSessionId: this.callSessionId,
-              existingGuardian: result.bindingConflict.existingGuardian,
-            },
-            "Guardian binding conflict: another user already holds the voice binding",
-          );
-        } else {
-          revokeGuardianBinding("phone");
-          createGuardianBinding({
-            channel: "phone",
-            guardianExternalUserId: fromNumber,
-            guardianDeliveryChatId: fromNumber,
-            guardianPrincipalId: result.canonicalPrincipal!,
-            verifiedVia: "challenge",
-          });
-        }
-      }
-
       if (isOutbound) {
         // Keep the pointer message back to the initiating conversation
         const successSession = getCallSession(this.callSessionId);
@@ -1435,7 +1374,6 @@ export class RelayConnection {
     this.continueCallAfterTrustedContactActivation({
       assistantId,
       fromNumber,
-      callerName: callerName ?? undefined,
       activationReason: "access_approved",
     });
 
@@ -1618,8 +1556,6 @@ export class RelayConnection {
       this.continueCallAfterTrustedContactActivation({
         assistantId: this.inviteRedemptionAssistantId,
         fromNumber: this.inviteRedemptionFromNumber,
-        callerName: this.inviteRedemptionFriendName ?? undefined,
-        skipMemberActivation: true,
         activationReason: "invite_redeemed",
         friendName: this.inviteRedemptionFriendName ?? undefined,
         guardianName: this.inviteRedemptionGuardianName ?? undefined,

package/src/calls/twilio-config.ts

@@ -1,8 +1,4 @@
 import { loadConfig } from "../config/loader.js";
-import {
-  getPublicBaseUrl,
-  getTwilioRelayUrl,
-} from "../inbound/public-ingress-urls.js";
 import { credentialKey } from "../security/credential-key.js";
 import { getSecureKeyAsync } from "../security/secure-keys.js";
 import { ConfigError } from "../util/errors.js";
@@ -14,8 +10,6 @@ export interface TwilioConfig {
   accountSid: string;
   authToken: string;
   phoneNumber: string;
-  webhookBaseUrl: string;
-  wssBaseUrl: string;
 }
 
 /**
@@ -39,19 +33,10 @@ export function resolveTwilioPhoneNumber(): string {
 }
 
 export async function getTwilioConfig(): Promise<TwilioConfig> {
-  const config = loadConfig();
-  const accountSid = config.twilio?.accountSid || "";
+  const accountSid = loadConfig().twilio?.accountSid || "";
   const authToken =
     (await getSecureKeyAsync(credentialKey("twilio", "auth_token"))) || "";
   const phoneNumber = resolveTwilioPhoneNumber();
-  const webhookBaseUrl = getPublicBaseUrl(config);
-
-  let wssBaseUrl: string;
-  try {
-    wssBaseUrl = getTwilioRelayUrl(config);
-  } catch {
-    wssBaseUrl = "";
-  }
 
   if (!accountSid || !authToken) {
     throw new ConfigError(
@@ -64,5 +49,5 @@ export async function getTwilioConfig(): Promise<TwilioConfig> {
 
   log.debug("Twilio config loaded successfully");
 
-  return { accountSid, authToken, phoneNumber, webhookBaseUrl, wssBaseUrl };
+  return { accountSid, authToken, phoneNumber };
 }

package/src/calls/twilio-rest.ts

@@ -6,6 +6,15 @@
  * config handler. Uses fetch() directly — no twilio npm package.
  */
 
+import {
+  lookupIncomingPhoneNumberSid,
+  twilioAuthHeader,
+  twilioBaseUrl,
+  TwilioRestError,
+  type TwilioWebhookUrls,
+  updatePhoneNumberWebhooks as updateTwilioPhoneNumberWebhooks,
+} from "@vellumai/twilio-client";
+
 import { loadConfig } from "../config/loader.js";
 import { credentialKey } from "../security/credential-key.js";
 import { getSecureKeyAsync } from "../security/secure-keys.js";
@@ -56,20 +65,7 @@ export async function hasTwilioCredentials(): Promise<boolean> {
   }
 }
 
-/** Build the HTTP Basic auth header for Twilio API requests. */
-export function twilioAuthHeader(
-  accountSid: string,
-  authToken: string,
-): string {
-  return (
-    "Basic " + Buffer.from(`${accountSid}:${authToken}`).toString("base64")
-  );
-}
-
-/** Build the Twilio REST API base URL for a given account. */
-export function twilioBaseUrl(accountSid: string): string {
-  return `https://api.twilio.com/2010-04-01/Accounts/${accountSid}`;
-}
+export { twilioAuthHeader, twilioBaseUrl };
 
 export interface TwilioPhoneNumber {
   phoneNumber: string;
@@ -210,47 +206,13 @@ export async function provisionPhoneNumber(
   };
 }
 
-/** Fetch the current status of a Twilio message by SID. */
-export async function fetchMessageStatus(
-  accountSid: string,
-  authToken: string,
-  messageSid: string,
-): Promise<{ status: string; errorCode?: string; errorMessage?: string }> {
-  const res = await fetch(
-    `${twilioBaseUrl(accountSid)}/Messages/${encodeURIComponent(
-      messageSid,
-    )}.json`,
-    {
-      method: "GET",
-      headers: { Authorization: twilioAuthHeader(accountSid, authToken) },
-    },
-  );
+export type WebhookUrls = TwilioWebhookUrls;
 
-  if (!res.ok) {
-    const text = await res.text();
-    throw new ProviderError(
-      `Twilio API error ${res.status}: ${text}`,
-      "twilio",
-      res.status,
-    );
+function rethrowAsProviderError(err: unknown): never {
+  if (err instanceof TwilioRestError) {
+    throw new ProviderError(err.message, "twilio", err.status);
   }
-
-  const data = (await res.json()) as {
-    status?: string;
-    error_code?: number | null;
-    error_message?: string | null;
-  };
-
-  return {
-    status: data.status ?? "unknown",
-    errorCode: data.error_code != null ? String(data.error_code) : undefined,
-    errorMessage: data.error_message ?? undefined,
-  };
-}
-
-export interface WebhookUrls {
-  voiceUrl: string;
-  statusCallbackUrl: string;
+  throw err;
 }
 
 /**
@@ -265,69 +227,15 @@ export async function updatePhoneNumberWebhooks(
   phoneNumber: string,
   webhooks: WebhookUrls,
 ): Promise<void> {
-  // First, find the SID for this phone number
-  const listRes = await fetch(
-    `${twilioBaseUrl(
+  try {
+    await updateTwilioPhoneNumberWebhooks({
       accountSid,
-    )}/IncomingPhoneNumbers.json?PhoneNumber=${encodeURIComponent(
+      authToken,
       phoneNumber,
-    )}`,
-    {
-      method: "GET",
-      headers: { Authorization: twilioAuthHeader(accountSid, authToken) },
-    },
-  );
-
-  if (!listRes.ok) {
-    const text = await listRes.text();
-    throw new ProviderError(
-      `Twilio API error ${listRes.status} looking up phone number: ${text}`,
-      "twilio",
-      listRes.status,
-    );
-  }
-
-  const listData = (await listRes.json()) as {
-    incoming_phone_numbers: Array<{ sid: string; phone_number: string }>;
-  };
-
-  const match = listData.incoming_phone_numbers.find(
-    (n) => n.phone_number === phoneNumber,
-  );
-  if (!match) {
-    throw new ProviderError(
-      `Phone number ${phoneNumber} not found on Twilio account ${accountSid}`,
-      "twilio",
-    );
-  }
-
-  // Update the phone number's webhook configuration
-  const body = new URLSearchParams({
-    VoiceUrl: webhooks.voiceUrl,
-    VoiceMethod: "POST",
-    StatusCallback: webhooks.statusCallbackUrl,
-    StatusCallbackMethod: "POST",
-  });
-
-  const updateRes = await fetch(
-    `${twilioBaseUrl(accountSid)}/IncomingPhoneNumbers/${match.sid}.json`,
-    {
-      method: "POST",
-      headers: {
-        Authorization: twilioAuthHeader(accountSid, authToken),
-        "Content-Type": "application/x-www-form-urlencoded",
-      },
-      body: body.toString(),
-    },
-  );
-
-  if (!updateRes.ok) {
-    const text = await updateRes.text();
-    throw new ProviderError(
-      `Twilio API error ${updateRes.status} updating webhooks: ${text}`,
-      "twilio",
-      updateRes.status,
-    );
+      webhooks,
+    });
+  } catch (err) {
+    rethrowAsProviderError(err);
   }
 }
 
@@ -340,35 +248,17 @@ async function getPhoneNumberSid(
   authToken: string,
   phoneNumber: string,
 ): Promise<string | null> {
-  const res = await fetch(
-    `${twilioBaseUrl(
-      accountSid,
-    )}/IncomingPhoneNumbers.json?PhoneNumber=${encodeURIComponent(
-      phoneNumber,
-    )}`,
-    {
-      method: "GET",
-      headers: { Authorization: twilioAuthHeader(accountSid, authToken) },
-    },
-  );
-
-  if (!res.ok) {
-    const text = await res.text();
-    throw new ProviderError(
-      `Twilio API error ${res.status} looking up phone number SID: ${text}`,
-      "twilio",
-      res.status,
+  try {
+    return (
+      (await lookupIncomingPhoneNumberSid({
+        accountSid,
+        authToken,
+        phoneNumber,
+      })) ?? null
     );
+  } catch (err) {
+    rethrowAsProviderError(err);
   }
-
-  const data = (await res.json()) as {
-    incoming_phone_numbers: Array<{ sid: string; phone_number: string }>;
-  };
-
-  const match = data.incoming_phone_numbers.find(
-    (n) => n.phone_number === phoneNumber,
-  );
-  return match?.sid ?? null;
 }
 
 /**

package/src/calls/twilio-routes.ts

@@ -21,11 +21,13 @@
  *   server-side.
  */
 
-import { loadConfig } from "../config/loader.js";
 import {
-  getTwilioMediaStreamUrl,
-  getTwilioRelayUrl,
-} from "../inbound/public-ingress-urls.js";
+  buildTwilioMediaStreamUrl,
+  buildTwilioRelayUrl,
+  TWILIO_PUBLIC_BASE_URL_PLACEHOLDER,
+} from "@vellumai/service-contracts/twilio-ingress";
+
+import { loadConfig } from "../config/loader.js";
 import { getProviderEntry } from "../providers/speech-to-text/provider-catalog.js";
 import {
   BadRequestError,
@@ -65,7 +67,7 @@ const log = getLogger("twilio-routes");
  * The gateway replaces this with a real JWT before returning TwiML to Twilio.
  * This keeps the signing key out of the daemon for voice webhook responses.
  */
-export const TWILIO_RELAY_TOKEN_PLACEHOLDER = "__VELLUM_RELAY_TOKEN__";
+const TWILIO_RELAY_TOKEN_PLACEHOLDER = "__VELLUM_RELAY_TOKEN__";
 
 // ── Speech config type ───────────────────────────────────────────────
 
@@ -444,7 +446,6 @@ function buildVoiceWebhookTwiml(
     // calls don't fail entirely on a misconfigured provider.
     return buildConversationRelayTwiml(
       callSessionId,
-      cfg,
       profile,
       sessionContext,
       verificationSessionId,
@@ -457,7 +458,6 @@ function buildVoiceWebhookTwiml(
   if (strategy.strategy === "conversation-relay-native") {
     return buildConversationRelayTwiml(
       callSessionId,
-      cfg,
       profile,
       sessionContext,
       verificationSessionId,
@@ -500,7 +500,6 @@ function buildVoiceWebhookTwiml(
     // through the relay server which supports it natively.
     return buildConversationRelayTwiml(
       callSessionId,
-      cfg,
       profile,
       sessionContext,
       verificationSessionId,
@@ -508,7 +507,7 @@ function buildVoiceWebhookTwiml(
     );
   }
 
-  return buildMediaStreamTwiml(callSessionId, cfg, verificationSessionId);
+  return buildMediaStreamTwiml(callSessionId, verificationSessionId);
 }
 
 /**
@@ -516,7 +515,6 @@ function buildVoiceWebhookTwiml(
  */
 function buildConversationRelayTwiml(
   callSessionId: string,
-  cfg: ReturnType<typeof loadConfig>,
   profile: ReturnType<typeof resolveVoiceQualityProfile>,
   sessionContext: {
     task: string | null;
@@ -538,7 +536,7 @@ function buildConversationRelayTwiml(
     interruptSensitivity: profile.interruptSensitivity,
   };
 
-  const relayUrl = getTwilioRelayUrl(cfg);
+  const relayUrl = buildTwilioRelayUrl(TWILIO_PUBLIC_BASE_URL_PLACEHOLDER);
   const welcomeGreeting = buildWelcomeGreeting(sessionContext?.task ?? null);
   const relayToken = TWILIO_RELAY_TOKEN_PLACEHOLDER;
 
@@ -572,10 +570,11 @@ function buildConversationRelayTwiml(
  */
 function buildMediaStreamTwiml(
   callSessionId: string,
-  cfg: ReturnType<typeof loadConfig>,
   verificationSessionId: string | null | undefined,
 ): string {
-  const streamUrl = getTwilioMediaStreamUrl(cfg);
+  const streamUrl = buildTwilioMediaStreamUrl(
+    TWILIO_PUBLIC_BASE_URL_PLACEHOLDER,
+  );
   const relayToken = TWILIO_RELAY_TOKEN_PLACEHOLDER;
 
   const customParameters: Record<string, string> | undefined =

package/src/calls/voice-session-bridge.ts

@@ -22,8 +22,7 @@ import type { Conversation } from "../daemon/conversation.js";
 import { resolveChannelCapabilities } from "../daemon/conversation-runtime-assembly.js";
 import type { ServerMessage } from "../daemon/message-protocol.js";
 import type { TrustContext } from "../daemon/trust-context.js";
-import { buildAssistantEvent } from "../runtime/assistant-event.js";
-import { assistantEventHub } from "../runtime/assistant-event-hub.js";
+import { broadcastMessage } from "../runtime/assistant-event-hub.js";
 import { DAEMON_INTERNAL_ASSISTANT_ID } from "../runtime/assistant-scope.js";
 import * as pendingInteractions from "../runtime/pending-interactions.js";
 import { computeToolApprovalDigest } from "../security/tool-approval-digest.js";
@@ -418,34 +417,6 @@ export async function startVoiceTurn(
     );
   }
 
-  // Serialized publish chain so hub subscribers observe events in order.
-  let hubChain: Promise<void> = Promise.resolve();
-  const publishToHub = (msg: ServerMessage): void => {
-    // ServerMessage is a large union; conversationId exists on most but not all variants.
-    const msgConversationId =
-      "conversationId" in msg &&
-      typeof (msg as { conversationId?: unknown }).conversationId === "string"
-        ? (msg as { conversationId: string }).conversationId
-        : undefined;
-    const resolvedConversationId = msgConversationId ?? opts.conversationId;
-    const event = buildAssistantEvent(
-      DAEMON_INTERNAL_ASSISTANT_ID,
-      msg,
-      resolvedConversationId,
-    );
-    hubChain = (async () => {
-      await hubChain;
-      try {
-        await assistantEventHub.publish(event);
-      } catch (err) {
-        log.warn(
-          { err },
-          "assistant-events hub subscriber threw during voice turn",
-        );
-      }
-    })();
-  };
-
   // Hook into conversation to intercept confirmation_request and secret_request events.
   // Voice auto-denies/auto-allows/auto-resolves these since there's no interactive UI.
   const autoDeny = !isGuardian;
@@ -455,7 +426,6 @@ export async function startVoiceTurn(
     if (msg.type === "confirmation_request") {
       if (usesLocalInteractiveApprovals) {
         pendingInteractions.register(msg.requestId, {
-          conversation,
           conversationId: opts.conversationId,
           kind: "confirmation",
           confirmationDetails: {
@@ -470,7 +440,7 @@ export async function startVoiceTurn(
             acpOptions: msg.acpOptions,
           },
         });
-        publishToHub(msg);
+        broadcastMessage(msg);
         return;
       }
       if (autoDeny) {
@@ -518,7 +488,7 @@ export async function startVoiceTurn(
               undefined,
               `Permission approved for "${msg.toolName}": guardian pre-approved via scoped grant.`,
             );
-            publishToHub(msg);
+            broadcastMessage(msg);
             return;
           }
         } catch (err) {
@@ -539,7 +509,7 @@ export async function startVoiceTurn(
           undefined,
           `Permission denied for "${msg.toolName}": this voice call does not have interactive approval capabilities. Side-effect tools are not available for non-guardian voice callers. In your next assistant reply, explain briefly that this action requires guardian-level access and cannot be performed during this call.`,
         );
-        publishToHub(msg);
+        broadcastMessage(msg);
         return;
       }
       if (autoAllow) {
@@ -554,7 +524,7 @@ export async function startVoiceTurn(
           undefined,
           `Permission approved for "${msg.toolName}": this is a verified guardian voice call.`,
         );
-        publishToHub(msg);
+        broadcastMessage(msg);
         return;
       }
     } else if (msg.type === "secret_request") {
@@ -564,10 +534,9 @@ export async function startVoiceTurn(
         "Auto-resolving secret request for voice turn (no secret-entry UI)",
       );
       conversation.handleSecretResponse(msg.requestId, undefined, "store");
-      publishToHub(msg);
       return;
     }
-    publishToHub(msg);
+    broadcastMessage(msg);
   });
 
   // Fire-and-forget the agent loop
@@ -596,7 +565,7 @@ export async function startVoiceTurn(
           } else if (msg.type === "conversation_error") {
             lastError = msg.userMessage;
           }
-          publishToHub(msg);
+          broadcastMessage(msg);
 
           // Forward voice-relevant events to the real-time event sink
           if (msg.type === "assistant_text_delta") {