@vellumai/assistant 0.7.0 → 0.7.2

package/src/__tests__/send-endpoint-busy.test.ts

@@ -10,7 +10,6 @@ import { afterEach, beforeEach, describe, expect, mock, test } from "bun:test";
 
 mock.module("../config/env.js", () => ({ isHttpAuthDisabled: () => true }));
 
-import { createGuardianBinding } from "../contacts/contacts-write.js";
 import type { Conversation } from "../daemon/conversation.js";
 import type { ServerMessage } from "../daemon/message-protocol.js";
 import {
@@ -21,6 +20,7 @@ import {
   getConversationByKey,
   getOrCreateConversation,
 } from "../memory/conversation-key-store.js";
+import { createGuardianBinding } from "./helpers/create-guardian-binding.js";
 
 mock.module("../util/logger.js", () => ({
   getLogger: () =>
@@ -92,6 +92,10 @@ let _conversationFactory: (() => Conversation) | undefined;
 let _approvalGenerator: unknown;
 
 mock.module("../daemon/conversation-store.js", () => ({
+  findConversation: () => {
+    if (!_conversationFactory) return undefined;
+    return _conversationFactory();
+  },
   getOrCreateConversation: async (..._args: unknown[]) => {
     if (!_conversationFactory)
       throw new Error("_conversationFactory not set in test");
@@ -154,12 +158,9 @@ function makeCompletingConversation(): Conversation {
     ensureActorScopedHistory: async () => {},
     usageStats: { inputTokens: 0, outputTokens: 0, estimatedCost: 0 },
     updateClient: () => {},
-    setHostBashProxy: () => {},
     setHostBrowserProxy: () => {},
-    setHostFileProxy: () => {},
-    setHostTransferProxy: () => {},
-    getHostTransferProxy: () => undefined,
     setHostCuProxy: () => {},
+    setHostAppControlProxy: () => {},
     addPreactivatedSkillId: () => {},
     hasAnyPendingConfirmation: () => false,
     hasPendingConfirmation: () => false,
@@ -214,12 +215,9 @@ function makeHangingConversation(): Conversation {
     ensureActorScopedHistory: async () => {},
     usageStats: { inputTokens: 0, outputTokens: 0, estimatedCost: 0 },
     updateClient: () => {},
-    setHostBashProxy: () => {},
     setHostBrowserProxy: () => {},
-    setHostFileProxy: () => {},
-    setHostTransferProxy: () => {},
-    getHostTransferProxy: () => undefined,
     setHostCuProxy: () => {},
+    setHostAppControlProxy: () => {},
     addPreactivatedSkillId: () => {},
     hasAnyPendingConfirmation: () => false,
     hasPendingConfirmation: () => false,
@@ -302,12 +300,9 @@ function makePendingApprovalConversation(
     ensureActorScopedHistory: async () => {},
     usageStats: { inputTokens: 0, outputTokens: 0, estimatedCost: 0 },
     updateClient: () => {},
-    setHostBashProxy: () => {},
     setHostBrowserProxy: () => {},
-    setHostFileProxy: () => {},
-    setHostTransferProxy: () => {},
-    getHostTransferProxy: () => undefined,
     setHostCuProxy: () => {},
+    setHostAppControlProxy: () => {},
     addPreactivatedSkillId: () => {},
     hasAnyPendingConfirmation: () => pending.size > 0,
     hasPendingConfirmation: (candidateRequestId: string) =>
@@ -425,12 +420,12 @@ describe("POST /v1/messages — queue-if-busy and hub publishing", () => {
     // Subscribe on the module-level singleton that the route handler publishes to
     const { assistantEventHub: routeEventHub } =
       await import("../runtime/assistant-event-hub.js");
-    routeEventHub.subscribe(
-      { assistantId: "self" },
-      (event: AssistantEvent) => {
+    routeEventHub.subscribe({
+      type: "process",
+      callback: (event: AssistantEvent) => {
         publishedEvents.push(event);
       },
-    );
+    });
 
     const res = await fetch(messagesUrl(), {
       method: "POST",
@@ -468,7 +463,6 @@ describe("POST /v1/messages — queue-if-busy and hub publishing", () => {
     } = makePendingApprovalConversation(requestId, false);
 
     pendingInteractions.register(requestId, {
-      conversation,
       conversationId,
       kind: "confirmation",
     });
@@ -528,7 +522,6 @@ describe("POST /v1/messages — queue-if-busy and hub publishing", () => {
     } = makePendingApprovalConversation(requestId, false);
 
     pendingInteractions.register(requestId, {
-      conversation,
       conversationId,
       kind: "confirmation",
     });
@@ -596,7 +589,6 @@ describe("POST /v1/messages — queue-if-busy and hub publishing", () => {
     } = makePendingApprovalConversation(requestId, true);
 
     pendingInteractions.register(requestId, {
-      conversation,
       conversationId,
       kind: "confirmation",
     });
@@ -656,7 +648,6 @@ describe("POST /v1/messages — queue-if-busy and hub publishing", () => {
     } = makePendingApprovalConversation(requestId, true, { queueDepth: 2 });
 
     pendingInteractions.register(requestId, {
-      conversation,
       conversationId,
       kind: "confirmation",
     });
@@ -716,7 +707,6 @@ describe("POST /v1/messages — queue-if-busy and hub publishing", () => {
     } = makePendingApprovalConversation(requestId, false);
 
     pendingInteractions.register(requestId, {
-      conversation,
       conversationId,
       kind: "confirmation",
     });
@@ -774,7 +764,6 @@ describe("POST /v1/messages — queue-if-busy and hub publishing", () => {
     );
 
     pendingInteractions.register(requestId, {
-      conversation,
       conversationId,
       kind: "confirmation",
     });
@@ -969,7 +958,6 @@ describe("POST /v1/messages — queue-if-busy and hub publishing", () => {
       makePendingApprovalConversation(requestId, false);
 
     pendingInteractions.register(requestId, {
-      conversation,
       conversationId,
       kind: "confirmation",
     });

package/src/__tests__/settings-routes.test.ts

@@ -17,12 +17,12 @@ mock.module("../util/logger.js", () => ({
     }),
 }));
 
-import { createGuardianBinding } from "../contacts/contacts-write.js";
 import { getSqlite } from "../memory/db-connection.js";
 import { initializeDb } from "../memory/db-init.js";
 import { BadRequestError, NotFoundError } from "../runtime/routes/errors.js";
 import { ROUTES } from "../runtime/routes/settings-routes.js";
 import type { RouteHandlerArgs } from "../runtime/routes/types.js";
+import { createGuardianBinding } from "./helpers/create-guardian-binding.js";
 
 initializeDb();
 

package/src/__tests__/shell-credential-ref.test.ts

@@ -32,14 +32,6 @@ mock.module("../security/secret-scanner.js", () => ({
   redactSecrets: (s: string) => s,
 }));
 
-// Mock sandbox
-mock.module("../tools/terminal/sandbox.js", () => ({
-  wrapCommand: (cmd: string, _cwd: string) => ({
-    command: "/bin/sh",
-    args: ["-c", cmd],
-  }),
-}));
-
 // Mock safe-env
 mock.module("../tools/terminal/safe-env.js", () => ({
   buildSanitizedEnv: () => ({ PATH: "/usr/bin" }),

package/src/__tests__/shell-tool-proxy-mode.test.ts

@@ -37,8 +37,6 @@ const mockConfig = {
   rateLimit: { maxRequestsPerMinute: 0 },
   secretDetection: {
     enabled: true,
-    action: "warn" as const,
-    entropyThreshold: 4.0,
   },
   auditLog: { retentionDays: 0 },
 };
@@ -47,7 +45,6 @@ mock.module("../config/loader.js", () => ({
   getConfig: () => mockConfig,
   loadConfig: () => mockConfig,
   invalidateConfigCache: () => {},
-  saveConfig: () => {},
   loadRawConfig: () => ({}),
   saveRawConfig: () => {},
   getNestedValue: () => undefined,
@@ -65,26 +62,6 @@ mock.module("../security/secret-scanner.js", () => ({
   redactSecrets: (s: string) => s,
 }));
 
-// Track wrapCommand calls to verify networkMode is forwarded
-let wrapCommandCalls: {
-  cmd: string;
-  workingDir: string;
-  config: unknown;
-  options: unknown;
-}[] = [];
-
-mock.module("../tools/terminal/sandbox.js", () => ({
-  wrapCommand: (
-    cmd: string,
-    workingDir: string,
-    config: unknown,
-    options?: unknown,
-  ) => {
-    wrapCommandCalls.push({ cmd, workingDir, config, options });
-    return { command: "/bin/sh", args: ["-c", cmd], sandboxed: false };
-  },
-}));
-
 // --- Proxy session mocks ---
 let mockActiveSession: { id: string; conversationId: string } | undefined;
 let getOrStartSessionCalls: {
@@ -181,7 +158,6 @@ function makeContext(overrides?: Partial<ToolContext>): ToolContext {
 
 afterEach(() => {
   spawnCalls.length = 0;
-  wrapCommandCalls = [];
   getOrStartSessionCalls = [];
   getSessionEnvCalls = [];
   mockActiveSession = undefined;
@@ -303,37 +279,4 @@ describe("shell tool proxy mode", () => {
     expect(props.network_mode).toBeDefined();
     expect(props.credential_ids).toBeDefined();
   });
-
-  test('wrapCommand receives { networkMode: "proxied" } when network_mode=proxied', async () => {
-    const result = await shellTool.execute(
-      { command: "echo proxied-wrap", network_mode: "proxied" },
-      makeContext(),
-    );
-
-    expect(result.isError).toBe(false);
-    expect(wrapCommandCalls).toHaveLength(1);
-    expect(wrapCommandCalls[0].options).toEqual({ networkMode: "proxied" });
-  });
-
-  test('wrapCommand receives { networkMode: "off" } when network_mode is absent', async () => {
-    const result = await shellTool.execute(
-      { command: "echo default-wrap" },
-      makeContext(),
-    );
-
-    expect(result.isError).toBe(false);
-    expect(wrapCommandCalls).toHaveLength(1);
-    expect(wrapCommandCalls[0].options).toEqual({ networkMode: "off" });
-  });
-
-  test('wrapCommand receives { networkMode: "off" } when network_mode=off', async () => {
-    const result = await shellTool.execute(
-      { command: "echo off-wrap", network_mode: "off" },
-      makeContext(),
-    );
-
-    expect(result.isError).toBe(false);
-    expect(wrapCommandCalls).toHaveLength(1);
-    expect(wrapCommandCalls[0].options).toEqual({ networkMode: "off" });
-  });
 });

package/src/__tests__/skill-feature-flags.test.ts

@@ -16,10 +16,11 @@ afterEach(() => {
   _setOverridesForTesting({});
 });
 
-const DECLARED_FLAG_ID = "sounds";
+const DECLARED_FLAG_ID = "email-channel";
 const DECLARED_FLAG_KEY = DECLARED_FLAG_ID;
-const DECLARED_SKILL_ID = "sounds";
-const APP_BUILDER_MULTIFILE_FLAG_KEY = "app-builder-multifile";
+const DECLARED_SKILL_ID = "email-channel";
+const ENABLED_UNDECLARED_FLAG_KEY = "enabled-undeclared-flag";
+const ENABLED_UNDECLARED_SKILL_ID = "enabled-undeclared-skill";
 // ---------------------------------------------------------------------------
 // Helpers
 // ---------------------------------------------------------------------------
@@ -91,14 +92,14 @@ describe("skillFlagKey", () => {
 // ---------------------------------------------------------------------------
 
 describe("isAssistantFeatureFlagEnabled with skillFlagKey", () => {
-  test("returns true when no flag overrides (registry default is true)", () => {
+  test("returns false when no flag overrides (registry default is false)", () => {
     const config = makeConfig();
     expect(
       isAssistantFeatureFlagEnabled(
         skillFlagKey({ featureFlag: DECLARED_FLAG_ID })!,
         config,
       ),
-    ).toBe(true);
+    ).toBe(false);
   });
 
   test("returns true when skill key is explicitly true", () => {
@@ -144,27 +145,18 @@ describe("isAssistantFeatureFlagEnabled", () => {
 
   test("falls back to registry default when no override", () => {
     const config = makeConfig();
-    // sounds defaults to true in the registry
-    expect(isAssistantFeatureFlagEnabled(DECLARED_FLAG_KEY, config)).toBe(true);
+    // email-channel defaults to false in the registry
+    expect(isAssistantFeatureFlagEnabled(DECLARED_FLAG_KEY, config)).toBe(
+      false,
+    );
   });
 
   test("respects persisted overrides for undeclared keys", () => {
-    _setOverridesForTesting({ browser: false });
-    const config = makeConfig();
-    expect(isAssistantFeatureFlagEnabled("browser", config)).toBe(false);
-  });
-
-  test("declared keys with no persisted override use registry default", () => {
-    const config = makeConfig();
-    // browser is declared in the registry with defaultEnabled: true
-    expect(isAssistantFeatureFlagEnabled("browser", config)).toBe(true);
-  });
-
-  test("app-builder-multifile defaults to enabled when no override is set", () => {
+    _setOverridesForTesting({ "some-undeclared-flag": false });
     const config = makeConfig();
-    expect(
-      isAssistantFeatureFlagEnabled(APP_BUILDER_MULTIFILE_FLAG_KEY, config),
-    ).toBe(true);
+    expect(isAssistantFeatureFlagEnabled("some-undeclared-flag", config)).toBe(
+      false,
+    );
   });
 });
 
@@ -176,11 +168,15 @@ describe("resolveSkillStates with feature flags", () => {
   test("flag OFF skill does not appear in resolved list", () => {
     _setOverridesForTesting({
       [DECLARED_FLAG_KEY]: false,
-      browser: true,
+      [ENABLED_UNDECLARED_FLAG_KEY]: true,
     });
     const catalog = [
       makeSkill(DECLARED_SKILL_ID, "bundled", DECLARED_FLAG_ID),
-      makeSkill("browser", "bundled", "browser"),
+      makeSkill(
+        ENABLED_UNDECLARED_SKILL_ID,
+        "bundled",
+        ENABLED_UNDECLARED_FLAG_KEY,
+      ),
     ];
     const config = makeConfig();
 
@@ -188,17 +184,21 @@ describe("resolveSkillStates with feature flags", () => {
     const ids = resolved.map((r) => r.summary.id);
 
     expect(ids).not.toContain(DECLARED_SKILL_ID);
-    expect(ids).toContain("browser");
+    expect(ids).toContain(ENABLED_UNDECLARED_SKILL_ID);
   });
 
   test("flag ON skill appears normally", () => {
     _setOverridesForTesting({
       [DECLARED_FLAG_KEY]: true,
-      browser: true,
+      [ENABLED_UNDECLARED_FLAG_KEY]: true,
     });
     const catalog = [
       makeSkill(DECLARED_SKILL_ID, "bundled", DECLARED_FLAG_ID),
-      makeSkill("browser", "bundled", "browser"),
+      makeSkill(
+        ENABLED_UNDECLARED_SKILL_ID,
+        "bundled",
+        ENABLED_UNDECLARED_FLAG_KEY,
+      ),
     ];
     const config = makeConfig();
 
@@ -206,17 +206,16 @@ describe("resolveSkillStates with feature flags", () => {
     const ids = resolved.map((r) => r.summary.id);
 
     expect(ids).toContain(DECLARED_SKILL_ID);
-    expect(ids).toContain("browser");
+    expect(ids).toContain(ENABLED_UNDECLARED_SKILL_ID);
   });
 
-  test("declared flag key defaults to registry value (true)", () => {
+  test("declared flag key defaults to registry value (false)", () => {
     const catalog = [makeSkill(DECLARED_SKILL_ID, "bundled", DECLARED_FLAG_ID)];
     const config = makeConfig();
 
     const resolved = resolveSkillStates(catalog, config);
-    // sounds registry default is true, so it passes through
-    expect(resolved.length).toBe(1);
-    expect(resolved[0].summary.id).toBe(DECLARED_SKILL_ID);
+    // email-channel registry default is false, so it is filtered out
+    expect(resolved.length).toBe(0);
   });
 
   test("skill without featureFlag is never flag-gated", () => {
@@ -259,12 +258,16 @@ describe("resolveSkillStates with feature flags", () => {
   test("multiple skills with mixed flags — persisted overrides respected", () => {
     _setOverridesForTesting({
       [DECLARED_FLAG_KEY]: false,
-      browser: true,
+      [ENABLED_UNDECLARED_FLAG_KEY]: true,
       deploy: false,
     });
     const catalog = [
       makeSkill(DECLARED_SKILL_ID, "bundled", DECLARED_FLAG_ID),
-      makeSkill("browser", "bundled", "browser"),
+      makeSkill(
+        ENABLED_UNDECLARED_SKILL_ID,
+        "bundled",
+        ENABLED_UNDECLARED_FLAG_KEY,
+      ),
       makeSkill("deploy", "bundled", "deploy"),
     ];
     const config = makeConfig();
@@ -272,8 +275,8 @@ describe("resolveSkillStates with feature flags", () => {
     const resolved = resolveSkillStates(catalog, config);
     const ids = resolved.map((r) => r.summary.id);
 
-    // sounds and deploy explicitly false; browser explicitly true
-    expect(ids).toEqual(["browser"]);
+    // email-channel and deploy explicitly false; one unrelated skill explicitly true
+    expect(ids).toEqual([ENABLED_UNDECLARED_SKILL_ID]);
   });
 });
 
@@ -282,15 +285,14 @@ describe("resolveSkillStates with feature flags", () => {
 // ---------------------------------------------------------------------------
 
 describe("resolveSkillStates with frontmatter featureFlag", () => {
-  test("skill with featureFlag (defaultEnabled: true) is included when no config override", () => {
-    // sounds has defaultEnabled: true in the registry
+  test("skill with featureFlag (defaultEnabled: false) is excluded when no config override", () => {
+    // email-channel has defaultEnabled: false in the registry
     const catalog = [makeSkill(DECLARED_SKILL_ID, "bundled", DECLARED_FLAG_ID)];
     const config = makeConfig();
 
     const resolved = resolveSkillStates(catalog, config);
-    // No override, registry default is true → passes through
-    expect(resolved.length).toBe(1);
-    expect(resolved[0].summary.id).toBe(DECLARED_SKILL_ID);
+    // No override, registry default is false → filtered out
+    expect(resolved.length).toBe(0);
   });
 
   test("skill with featureFlag is included when override enables it", () => {

package/src/__tests__/skill-load-feature-flag.test.ts

@@ -12,8 +12,8 @@ const TEST_DIR = process.env.VELLUM_WORKSPACE_DIR!;
 
 let currentConfig: Record<string, unknown> = {};
 
-const DECLARED_SKILL_ID = "sounds";
-const DECLARED_FLAG_KEY = "sounds";
+const DECLARED_SKILL_ID = "email-channel";
+const DECLARED_FLAG_KEY = "email-channel";
 
 const noopLogger = new Proxy({} as Record<string, unknown>, {
   get: (_target, prop) => (prop === "child" ? () => noopLogger : () => {}),
@@ -35,7 +35,6 @@ mock.module("../config/loader.js", () => ({
   getConfigReadOnly: () => currentConfig,
   loadConfig: () => currentConfig,
   loadRawConfig: () => ({}),
-  saveConfig: () => {},
   saveRawConfig: () => {},
   invalidateConfigCache: () => {},
   getNestedValue: () => undefined,
@@ -99,8 +98,8 @@ describe("skill_load feature flag enforcement", () => {
   test("returns deterministic error for flag OFF skill", async () => {
     writeSkill(
       DECLARED_SKILL_ID,
-      "Sounds",
-      "Toggle sounds behavior",
+      "Email Channel",
+      "Toggle email channel behavior",
       "Use the feature.",
     );
     writeFileSync(
@@ -120,8 +119,8 @@ describe("skill_load feature flag enforcement", () => {
   test("loads skill normally when flag is ON", async () => {
     writeSkill(
       DECLARED_SKILL_ID,
-      "Sounds",
-      "Toggle sounds behavior",
+      "Email Channel",
+      "Toggle email channel behavior",
       "Use the feature.",
     );
     writeFileSync(
@@ -134,14 +133,14 @@ describe("skill_load feature flag enforcement", () => {
     const result = await executeSkillLoad({ skill: DECLARED_SKILL_ID });
 
     expect(result.isError).toBe(false);
-    expect(result.content).toContain("Skill: Sounds");
+    expect(result.content).toContain("Skill: Email Channel");
   });
 
-  test("loads skill when flag key is absent (registry defaults to enabled)", async () => {
+  test("returns error when flag key is absent (registry defaults to disabled)", async () => {
     writeSkill(
       DECLARED_SKILL_ID,
-      "Sounds",
-      "Toggle sounds behavior",
+      "Email Channel",
+      "Toggle email channel behavior",
       "Use the feature.",
     );
     writeFileSync(
@@ -153,8 +152,8 @@ describe("skill_load feature flag enforcement", () => {
 
     const result = await executeSkillLoad({ skill: DECLARED_SKILL_ID });
 
-    // sounds is declared in the registry with defaultEnabled: true
-    expect(result.isError).toBe(false);
-    expect(result.content).toContain("Skill: Sounds");
+    // email-channel is declared in the registry with defaultEnabled: false
+    expect(result.isError).toBe(true);
+    expect(result.content).toContain("disabled by feature flag");
   });
 });

package/src/__tests__/skill-load-inline-command.test.ts

@@ -4,8 +4,6 @@
  * Validates that:
  * - Root skills with `!\`command\`` tokens get those tokens expanded exactly
  *   once at skill_load time, wrapped in <inline_skill_command> XML tags.
- * - When the feature flag is off, skill_load returns an error instead of
- *   leaving unresolved live tokens in the prompt.
  * - When the skill source is "extra", skill_load rejects with a specific error.
  * - Render failures produce stable inline stubs rather than raw stderr.
  */
@@ -14,8 +12,6 @@ import { mkdirSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
 import { beforeEach, describe, expect, mock, test } from "bun:test";
 
-import { _setOverridesForTesting } from "../config/assistant-feature-flags.js";
-
 // ── Test directory ────────────────────────────────────────────────────────────
 
 const TEST_DIR = process.env.VELLUM_WORKSPACE_DIR!;
@@ -93,7 +89,6 @@ mock.module("../config/loader.js", () => ({
   getConfig: () => testConfig,
   loadConfig: () => testConfig,
   invalidateConfigCache: () => {},
-  saveConfig: () => {},
   loadRawConfig: () => ({}),
   saveRawConfig: () => {},
   getNestedValue: () => undefined,
@@ -163,10 +158,6 @@ describe("skill_load inline command expansion", () => {
       ) => mockRunInlineCommand(command, workingDir),
     }));
 
-    // Enable the feature flag
-    _setOverridesForTesting({
-      "inline-skill-commands": true,
-    });
     testConfig.skills = { load: { extraDirs: [] } };
   });
 
@@ -255,48 +246,6 @@ describe("skill_load inline command expansion", () => {
     });
   });
 
-  // ── Feature flag off ─────────────────────────────────────────────────
-
-  describe("feature flag disabled", () => {
-    test("returns error when flag is off and skill has inline commands", async () => {
-      _setOverridesForTesting({
-        "inline-skill-commands": false,
-      });
-
-      writeSkill(
-        "flagged-off-skill",
-        "Flagged Off Skill",
-        "Has inline commands",
-        "Data: !`echo hello`",
-      );
-
-      const result = await executeSkillLoad({ skill: "flagged-off-skill" });
-      expect(result.isError).toBe(true);
-      expect(result.content).toContain(
-        "inline-skill-commands feature flag is disabled",
-      );
-      // Runner should not be called when flag is off
-      expect(runInlineCommandCalls).toHaveLength(0);
-    });
-
-    test("plain skill still loads when flag is off", async () => {
-      _setOverridesForTesting({
-        "inline-skill-commands": false,
-      });
-
-      writeSkill(
-        "plain-flag-off",
-        "Plain Flag Off",
-        "No inline commands",
-        "Regular content.",
-      );
-
-      const result = await executeSkillLoad({ skill: "plain-flag-off" });
-      expect(result.isError).toBe(false);
-      expect(result.content).toContain("Regular content.");
-    });
-  });
-
   // ── Extra source rejection ───────────────────────────────────────────
   //
   // The SkillLoadTool checks `skill.source === "extra"` and rejects inline

package/src/__tests__/skill-load-inline-includes.test.ts

@@ -16,8 +16,6 @@ import { mkdirSync, writeFileSync } from "node:fs";
 import { join } from "node:path";
 import { beforeEach, describe, expect, mock, test } from "bun:test";
 
-import { _setOverridesForTesting } from "../config/assistant-feature-flags.js";
-
 // ── Test directory ────────────────────────────────────────────────────────────
 
 const TEST_DIR = process.env.VELLUM_WORKSPACE_DIR!;
@@ -95,7 +93,6 @@ mock.module("../config/loader.js", () => ({
   getConfig: () => testConfig,
   loadConfig: () => testConfig,
   invalidateConfigCache: () => {},
-  saveConfig: () => {},
   loadRawConfig: () => ({}),
   saveRawConfig: () => {},
   getNestedValue: () => undefined,
@@ -173,10 +170,6 @@ describe("skill_load inline command expansion for included skills", () => {
       ) => mockRunInlineCommand(command, workingDir),
     }));
 
-    // Enable the feature flag
-    _setOverridesForTesting({
-      "inline-skill-commands": true,
-    });
     testConfig.skills = { load: { extraDirs: [] } };
   });
 
@@ -514,42 +507,6 @@ describe("skill_load inline command expansion for included skills", () => {
     });
   });
 
-  // ── Feature flag off for child inline commands ────────────────────────
-
-  describe("feature flag disabled for included skills", () => {
-    test("skill_load returns error when child has inline commands and flag is off", async () => {
-      _setOverridesForTesting({
-        "inline-skill-commands": false,
-      });
-
-      writeSkill(
-        "child-flag-off",
-        "Flag Off Child",
-        "Child with inline cmds",
-        "Data: !`echo hello`",
-      );
-      writeSkill(
-        "parent-flag-off",
-        "Parent Flag Off",
-        "Parent for flag-off test",
-        "Root content.",
-        { includes: ["child-flag-off"] },
-      );
-
-      const result = await executeSkillLoad({ skill: "parent-flag-off" });
-      // Fail closed: the entire skill_load must error when any included child
-      // has inline commands and the feature flag is off, matching the root
-      // skill behavior and the documented fail-closed contract.
-      expect(result.isError).toBe(true);
-      expect(result.content).toContain("child-flag-off");
-      expect(result.content).toContain(
-        "inline-skill-commands feature flag is disabled",
-      );
-      // Runner should not be called
-      expect(runInlineCommandCalls).toHaveLength(0);
-    });
-  });
-
   // ── Root with inline + child with inline ──────────────────────────────
 
   describe("root and child both have inline commands", () => {

package/src/__tests__/skill-projection.benchmark.test.ts

@@ -28,7 +28,6 @@ mock.module("../config/loader.js", () => ({
   getConfig: () => ({}),
   loadConfig: () => ({}),
   applyNestedDefaults: (c: unknown) => c,
-  saveConfig: () => {},
   invalidateConfigCache: () => {},
   loadRawConfig: () => ({}),
   saveRawConfig: () => {},