@vellumai/assistant 0.7.0 → 0.7.2

package/src/runtime/__tests__/client-registry.test.ts

@@ -1,271 +0,0 @@
-import { beforeEach, describe, expect, test } from "bun:test";
-
-import {
-  __resetClientRegistryForTests,
-  ClientRegistry,
-  getClientRegistry,
-} from "../client-registry.js";
-
-describe("ClientRegistry", () => {
-  beforeEach(() => {
-    __resetClientRegistryForTests();
-  });
-
-  // ── register ──────────────────────────────────────────────────────────────
-
-  test("register creates a new entry with derived capabilities", () => {
-    const registry = new ClientRegistry();
-    const entry = registry.register({
-      clientId: "mac-1",
-      interfaceId: "macos",
-    });
-
-    expect(entry.clientId).toBe("mac-1");
-    expect(entry.interfaceId).toBe("macos");
-    expect(entry.capabilities).toContain("host_bash");
-    expect(entry.capabilities).toContain("host_file");
-    expect(entry.capabilities).toContain("host_cu");
-    expect(entry.capabilities).toContain("host_browser");
-    expect(entry.connectedAt).toBeGreaterThan(0);
-    expect(entry.lastActiveAt).toBeGreaterThanOrEqual(entry.connectedAt);
-  });
-
-  test("register derives empty capabilities for cli interface", () => {
-    const registry = new ClientRegistry();
-    const entry = registry.register({
-      clientId: "cli-1",
-      interfaceId: "cli",
-    });
-
-    expect(entry.capabilities).toEqual([]);
-  });
-
-  test("register derives host_browser capability for chrome-extension", () => {
-    const registry = new ClientRegistry();
-    const entry = registry.register({
-      clientId: "ext-1",
-      interfaceId: "chrome-extension",
-    });
-
-    expect(entry.capabilities).toEqual(["host_browser"]);
-  });
-
-  test("register refreshes lastActiveAt on re-register with same clientId", () => {
-    const registry = new ClientRegistry();
-    const first = registry.register({
-      clientId: "mac-1",
-      interfaceId: "macos",
-    });
-    const firstActive = first.lastActiveAt;
-
-    // Advance time slightly
-    const second = registry.register({
-      clientId: "mac-1",
-      interfaceId: "macos",
-    });
-
-    // Same object reference — refreshed in place
-    expect(second).toBe(first);
-    expect(second.lastActiveAt).toBeGreaterThanOrEqual(firstActive);
-    // connectedAt should NOT change on refresh
-    expect(second.connectedAt).toBe(first.connectedAt);
-  });
-
-  test("register does not increase size on re-register", () => {
-    const registry = new ClientRegistry();
-    registry.register({ clientId: "mac-1", interfaceId: "macos" });
-    registry.register({ clientId: "mac-1", interfaceId: "macos" });
-    expect(registry.size).toBe(1);
-  });
-
-  // ── unregister ────────────────────────────────────────────────────────────
-
-  test("unregister removes the entry", () => {
-    const registry = new ClientRegistry();
-    registry.register({ clientId: "mac-1", interfaceId: "macos" });
-    expect(registry.size).toBe(1);
-
-    registry.unregister("mac-1");
-    expect(registry.size).toBe(0);
-    expect(registry.get("mac-1")).toBeUndefined();
-  });
-
-  test("unregister is a no-op for unknown clientId", () => {
-    const registry = new ClientRegistry();
-    registry.register({ clientId: "mac-1", interfaceId: "macos" });
-    registry.unregister("unknown");
-    expect(registry.size).toBe(1);
-  });
-
-  // ── touch ─────────────────────────────────────────────────────────────────
-
-  test("touch updates lastActiveAt", () => {
-    const registry = new ClientRegistry();
-    const entry = registry.register({
-      clientId: "mac-1",
-      interfaceId: "macos",
-    });
-    const before = entry.lastActiveAt;
-    registry.touch("mac-1");
-    expect(entry.lastActiveAt).toBeGreaterThanOrEqual(before);
-  });
-
-  test("touch is a no-op for unknown clientId", () => {
-    const registry = new ClientRegistry();
-    // Should not throw
-    registry.touch("unknown");
-  });
-
-  // ── get ───────────────────────────────────────────────────────────────────
-
-  test("get returns the entry for a registered clientId", () => {
-    const registry = new ClientRegistry();
-    const entry = registry.register({
-      clientId: "mac-1",
-      interfaceId: "macos",
-    });
-    expect(registry.get("mac-1")).toBe(entry);
-  });
-
-  test("get returns undefined for unknown clientId", () => {
-    const registry = new ClientRegistry();
-    expect(registry.get("unknown")).toBeUndefined();
-  });
-
-  // ── listAll ───────────────────────────────────────────────────────────────
-
-  test("listAll returns entries sorted by lastActiveAt descending", () => {
-    const registry = new ClientRegistry();
-    registry.register({ clientId: "old", interfaceId: "cli" });
-    // Touch the second one to make it most recent
-    registry.register({ clientId: "new", interfaceId: "macos" });
-
-    const all = registry.listAll();
-    expect(all.length).toBe(2);
-    expect(all[0].lastActiveAt).toBeGreaterThanOrEqual(all[1].lastActiveAt);
-  });
-
-  test("listAll returns empty array when no clients registered", () => {
-    const registry = new ClientRegistry();
-    expect(registry.listAll()).toEqual([]);
-  });
-
-  // ── listByCapability ──────────────────────────────────────────────────────
-
-  test("listByCapability filters to clients with matching capability", () => {
-    const registry = new ClientRegistry();
-    registry.register({ clientId: "mac-1", interfaceId: "macos" });
-    registry.register({ clientId: "cli-1", interfaceId: "cli" });
-    registry.register({ clientId: "ext-1", interfaceId: "chrome-extension" });
-
-    const bashCapable = registry.listByCapability("host_bash");
-    expect(bashCapable.length).toBe(1);
-    expect(bashCapable[0].clientId).toBe("mac-1");
-
-    const browserCapable = registry.listByCapability("host_browser");
-    expect(browserCapable.length).toBe(2);
-    // macOS now supports host_browser too
-    const ids = browserCapable.map((e) => e.clientId).sort();
-    expect(ids).toEqual(["ext-1", "mac-1"]);
-  });
-
-  test("listByCapability returns empty when no clients match", () => {
-    const registry = new ClientRegistry();
-    registry.register({ clientId: "cli-1", interfaceId: "cli" });
-    expect(registry.listByCapability("host_bash")).toEqual([]);
-  });
-
-  // ── getMostRecentByCapability ─────────────────────────────────────────────
-
-  test("getMostRecentByCapability returns the most recently active client", () => {
-    const registry = new ClientRegistry();
-    const mac1 = registry.register({ clientId: "mac-1", interfaceId: "macos" });
-    const mac2 = registry.register({ clientId: "mac-2", interfaceId: "macos" });
-
-    // Ensure deterministic ordering — both may register within the same ms
-    mac1.lastActiveAt = Date.now() - 5000;
-    mac2.lastActiveAt = Date.now();
-
-    const best = registry.getMostRecentByCapability("host_bash");
-    expect(best).toBeDefined();
-    expect(best!.clientId).toBe("mac-2");
-  });
-
-  test("getMostRecentByCapability returns undefined when no clients match", () => {
-    const registry = new ClientRegistry();
-    registry.register({ clientId: "cli-1", interfaceId: "cli" });
-    expect(registry.getMostRecentByCapability("host_bash")).toBeUndefined();
-  });
-
-  // ── toJSON ────────────────────────────────────────────────────────────────
-
-  test("toJSON serializes with ISO timestamps", () => {
-    const registry = new ClientRegistry();
-    const entry = registry.register({
-      clientId: "mac-1",
-      interfaceId: "macos",
-    });
-
-    const json = ClientRegistry.toJSON(entry);
-    expect(json.clientId).toBe("mac-1");
-    expect(json.interfaceId).toBe("macos");
-    expect(json.capabilities).toContain("host_bash");
-    expect(json.connectedAt).toMatch(/^\d{4}-\d{2}-\d{2}T/);
-    expect(json.lastActiveAt).toMatch(/^\d{4}-\d{2}-\d{2}T/);
-  });
-
-  // ── evictStale ─────────────────────────────────────────────────────────────
-
-  test("evictStale removes entries older than maxAgeMs", () => {
-    const registry = new ClientRegistry();
-    const entry = registry.register({
-      clientId: "old-mac",
-      interfaceId: "macos",
-    });
-    // Backdate lastActiveAt by 1 hour
-    entry.lastActiveAt = Date.now() - 60 * 60 * 1000;
-
-    const evicted = registry.evictStale(30 * 60 * 1000); // 30 min threshold
-    expect(evicted).toBe(1);
-    expect(registry.size).toBe(0);
-  });
-
-  test("evictStale keeps fresh entries", () => {
-    const registry = new ClientRegistry();
-    registry.register({ clientId: "fresh", interfaceId: "macos" });
-
-    const evicted = registry.evictStale(30 * 60 * 1000);
-    expect(evicted).toBe(0);
-    expect(registry.size).toBe(1);
-  });
-
-  test("listAll triggers lazy eviction", () => {
-    const registry = new ClientRegistry();
-    const entry = registry.register({
-      clientId: "stale-cli",
-      interfaceId: "cli",
-    });
-    entry.lastActiveAt = Date.now() - 60 * 60 * 1000;
-
-    registry.register({ clientId: "fresh-mac", interfaceId: "macos" });
-
-    const all = registry.listAll();
-    expect(all.length).toBe(1);
-    expect(all[0].clientId).toBe("fresh-mac");
-  });
-
-  // ── singleton ─────────────────────────────────────────────────────────────
-
-  test("getClientRegistry returns a singleton", () => {
-    const a = getClientRegistry();
-    const b = getClientRegistry();
-    expect(a).toBe(b);
-  });
-
-  test("__resetClientRegistryForTests clears the singleton", () => {
-    const a = getClientRegistry();
-    __resetClientRegistryForTests();
-    const b = getClientRegistry();
-    expect(a).not.toBe(b);
-  });
-});

package/src/runtime/capability-tokens.ts

@@ -1,190 +0,0 @@
-/**
- * Capability token verification for scoped, short-lived tokens issued to the
- * chrome extension (and other thin clients).
- *
- * Both minting and verification are owned by the gateway
- * (`gateway/src/auth/capability-tokens.ts`). The daemon delegates
- * verification to the gateway via IPC so it never needs to read the
- * HMAC secret from the filesystem.
- *
- * Test-only helpers (`mintHostBrowserCapability`,
- * `setCapabilityTokenSecretForTests`, `resetCapabilityTokenSecretForTests`)
- * implement the same HMAC logic in-process so assistant tests can create
- * and verify tokens without a live gateway.
- */
-
-import { createHmac, randomBytes, timingSafeEqual } from "node:crypto";
-
-import { ipcCall } from "../ipc/gateway-client.js";
-import { getLogger } from "../util/logger.js";
-
-const log = getLogger("capability-tokens");
-
-// ---------------------------------------------------------------------------
-// Types (mirror the gateway's types for consumer convenience)
-// ---------------------------------------------------------------------------
-
-/** Capability identifiers that can be bound to a capability token. */
-export type Capability = "host_browser_command";
-
-/** Claims encoded in the signed payload. */
-export interface CapabilityClaims {
-  capability: Capability;
-  guardianId: string;
-  /** 16-byte random nonce, hex-encoded. Prevents replay across fresh mints. */
-  nonce: string;
-  /** ms-since-epoch expiry. */
-  expiresAt: number;
-}
-
-/** A freshly-minted capability token and its absolute expiry. */
-export interface CapabilityToken {
-  token: string;
-  expiresAt: number;
-}
-
-// ---------------------------------------------------------------------------
-// In-process HMAC helpers (shared between test mint/verify and IPC verify)
-// ---------------------------------------------------------------------------
-
-let _testSecret: Buffer | undefined;
-
-function base64urlEncode(buf: Buffer): string {
-  return buf
-    .toString("base64")
-    .replace(/\+/g, "-")
-    .replace(/\//g, "_")
-    .replace(/=+$/, "");
-}
-
-function base64urlDecode(s: string): Buffer {
-  const pad = s.length % 4 === 0 ? 0 : 4 - (s.length % 4);
-  const b64 = s.replace(/-/g, "+").replace(/_/g, "/") + "=".repeat(pad);
-  return Buffer.from(b64, "base64");
-}
-
-function sign(payload: string, secret: Buffer): string {
-  return base64urlEncode(createHmac("sha256", secret).update(payload).digest());
-}
-
-// ---------------------------------------------------------------------------
-// Verify (production: gateway IPC, test: in-process)
-// ---------------------------------------------------------------------------
-
-/**
- * Verify a capability token.
- *
- * In production, delegates to the gateway via IPC. In tests (when a
- * secret has been injected via `setCapabilityTokenSecretForTests`),
- * verifies in-process so tests don't need a live gateway.
- *
- * Returns the decoded claims on success or null on any failure.
- */
-export async function verifyHostBrowserCapability(
-  token: string,
-): Promise<CapabilityClaims | null> {
-  if (typeof token !== "string" || token.length === 0) return null;
-
-  // Test path: in-process verification with the injected secret.
-  if (_testSecret) {
-    return verifyInProcess(token, _testSecret);
-  }
-
-  // Production path: delegate to the gateway.
-  try {
-    const result = await ipcCall("verify_capability_token", { token });
-    if (!result || typeof result !== "object") return null;
-
-    const claims = result as Record<string, unknown>;
-    if (claims.valid === false) return null;
-    if (claims.capability !== "host_browser_command") return null;
-    if (
-      typeof claims.guardianId !== "string" ||
-      claims.guardianId.length === 0
-    ) {
-      return null;
-    }
-
-    return claims as unknown as CapabilityClaims;
-  } catch (err) {
-    log.warn({ err }, "Failed to verify capability token via gateway IPC");
-    return null;
-  }
-}
-
-function verifyInProcess(
-  token: string,
-  secret: Buffer,
-): CapabilityClaims | null {
-  const dot = token.indexOf(".");
-  if (dot < 0) return null;
-  const payload = token.slice(0, dot);
-  const sig = token.slice(dot + 1);
-  if (!payload || !sig) return null;
-
-  const expected = sign(payload, secret);
-  const a = Buffer.from(sig, "utf8");
-  const b = Buffer.from(expected, "utf8");
-  if (a.length !== b.length) return null;
-  if (!timingSafeEqual(a, b)) return null;
-
-  let claims: CapabilityClaims;
-  try {
-    claims = JSON.parse(
-      base64urlDecode(payload).toString("utf8"),
-    ) as CapabilityClaims;
-  } catch {
-    return null;
-  }
-
-  if (!claims || typeof claims !== "object") return null;
-  if (claims.capability !== "host_browser_command") return null;
-  if (typeof claims.guardianId !== "string" || claims.guardianId.length === 0) {
-    return null;
-  }
-  if (typeof claims.expiresAt !== "number" || claims.expiresAt <= Date.now()) {
-    return null;
-  }
-  return claims;
-}
-
-// ---------------------------------------------------------------------------
-// Test-only helpers
-// ---------------------------------------------------------------------------
-
-/**
- * Mint a capability token in-process. Test-only — production minting is
- * done by the gateway.
- */
-export function mintHostBrowserCapability(
-  guardianId: string,
-  ttlMs: number = 30 * 60 * 1000,
-): CapabilityToken {
-  const secret = _testSecret;
-  if (!secret) {
-    throw new Error(
-      "capability token secret not set — call setCapabilityTokenSecretForTests() first",
-    );
-  }
-  const expiresAt = Date.now() + ttlMs;
-  const nonce = randomBytes(16).toString("hex");
-  const claims: CapabilityClaims = {
-    capability: "host_browser_command",
-    guardianId,
-    nonce,
-    expiresAt,
-  };
-  const payload = base64urlEncode(Buffer.from(JSON.stringify(claims), "utf8"));
-  const sig = sign(payload, secret);
-  return { token: `${payload}.${sig}`, expiresAt };
-}
-
-/** Inject a deterministic secret for tests. */
-export function setCapabilityTokenSecretForTests(secret: Buffer): void {
-  _testSecret = secret;
-}
-
-/** Reset the test secret. */
-export function resetCapabilityTokenSecretForTests(): void {
-  _testSecret = undefined;
-}