@torrent-tv/proxy 2.89.6 → 2.89.8

This diff represents the content of publicly available package versions that have been released to one of the supported registries. The information contained in this diff is provided for informational purposes only and reflects changes between package versions as they appear in their respective public registries.
Files changed (92) hide show
  1. package/AGENTS.md +32 -12
  2. package/CHANGELOG.md +2340 -2330
  3. package/assets/calibration/audio/NOTICE.md +19 -19
  4. package/assets/calibration/audio/manifest.json +98 -98
  5. package/biome.json +412 -412
  6. package/docs/browser-proxy-contract.md +155 -155
  7. package/docs/container-architecture.md +273 -273
  8. package/docs/encode-run-state.md +1 -1
  9. package/docs/playback-start-forecast.md +113 -98
  10. package/package.json +51 -50
  11. package/routes/api/sources/files/get.js +106 -106
  12. package/scripts/build-audio-samples.mjs +31 -31
  13. package/services/encode/EncodeRun.js +67 -15
  14. package/services/encode/EncodeRuns.js +19 -7
  15. package/services/encode/OutputOpening.js +784 -784
  16. package/services/encode/audio-calibration.js +67 -67
  17. package/services/encode/audio-work-rate.js +15 -15
  18. package/services/encode/encode-exit.js +2 -0
  19. package/services/encode/hwaccel.js +1894 -1894
  20. package/services/encode/output/index.js +24 -24
  21. package/services/encode/piece-completeness.js +60 -2
  22. package/services/encode/run-command.js +757 -755
  23. package/services/encode/segment-formats/index.js +1 -0
  24. package/services/encode/segment-formats/mp4-boxes.js +8 -1
  25. package/services/media/ContainerOrchestrator.js +202 -202
  26. package/services/media/KeyframeTables.js +356 -356
  27. package/services/media/SubtitleCues.js +592 -592
  28. package/services/media/audio-inventory.js +299 -299
  29. package/services/media/container/AviContainer.js +268 -268
  30. package/services/media/container/Container.js +632 -632
  31. package/services/media/container/ContainerFactory.js +38 -38
  32. package/services/media/container/MatroskaContainer.js +1031 -1031
  33. package/services/media/container/Mp4Container.js +1354 -1354
  34. package/services/media/container/SubtitleFileContainer.js +339 -339
  35. package/services/media/container/ebml-stream.js +174 -174
  36. package/services/media/container/matroska-clusters.js +1165 -1165
  37. package/services/media/container/unavailable.js +77 -77
  38. package/services/media/tracks/ContainerTrack.js +84 -84
  39. package/services/media/tracks/TextSubtitleTrack.js +295 -295
  40. package/services/storage/piece-store/shared-piece-store.js +1937 -1937
  41. package/services/storage/segment-store/SegmentStore.js +1294 -1294
  42. package/services/torrent/Contents.js +382 -382
  43. package/services/torrent/episode-naming.js +182 -182
  44. package/services/torrent/torrent-pool.js +2688 -2688
  45. package/services/torrent/worker/client.js +836 -836
  46. package/services/torrent/worker/held-bytes.js +231 -231
  47. package/services/torrent/worker/worker.js +1137 -1137
  48. package/services/transport/data-channel-handler.js +1373 -1373
  49. package/services/viewer/PriorityMap.js +421 -421
  50. package/test/audio-calibration.test.js +23 -23
  51. package/test/auto-quality-step.test.js +762 -762
  52. package/test/coalesce.test.js +39 -39
  53. package/test/coverage-follows-the-disk.test.js +5 -0
  54. package/test/decode-cost.test.js +475 -475
  55. package/test/encode-run.test.js +58 -0
  56. package/test/episode-naming.test.js +131 -131
  57. package/test/failed-encoder-still-serves-what-exists.test.js +1 -1
  58. package/test/fixtures/audio-frame-boundary.json +1 -1
  59. package/test/fixtures/refused-audio-20261002.json +10 -0
  60. package/test/fmp4-presentation-clock.test.js +4 -2
  61. package/test/format-keyed-outputs.test.js +78 -78
  62. package/test/health-metrics.test.js +11 -13
  63. package/test/held-read-ownership.test.js +77 -77
  64. package/test/helpers/encode-run.js +14 -6
  65. package/test/helpers/held-file.js +77 -77
  66. package/test/helpers/manager.js +62 -62
  67. package/test/helpers/matroska-file.js +296 -296
  68. package/test/keyframe-table-budget.test.js +123 -123
  69. package/test/matroska-cluster-discovery.test.js +323 -323
  70. package/test/one-output-one-session.test.js +273 -273
  71. package/test/output-speed.test.js +6 -1
  72. package/test/piece-completeness.test.js +37 -1
  73. package/test/quality-variants.test.js +1274 -1270
  74. package/test/rate-control-in-the-output.test.js +4 -3
  75. package/test/reads-not-yet-arrived.test.js +218 -218
  76. package/test/seek-frees-the-viewers-requests.test.js +1 -1
  77. package/test/segment-closed-on-both-branches.test.js +114 -114
  78. package/test/segment-judged-by-its-own-header.test.js +222 -222
  79. package/test/segment-serve-wiring.test.js +481 -481
  80. package/test/serving-existing-output.test.js +111 -111
  81. package/test/source-files-route.test.js +113 -113
  82. package/test/subtitle-cue-walk.test.js +385 -385
  83. package/test/subtitle-metadata.test.js +15 -15
  84. package/test/subtitle-plan-waits.test.js +125 -125
  85. package/test/subtitle-track-numbering.test.js +391 -391
  86. package/test/two-viewers-one-picture.test.js +508 -508
  87. package/test/viewer-requests-admission.test.js +92 -92
  88. package/test/viewer-starts-on-map.test.js +27 -27
  89. package/test/viewer-states.test.js +5 -2
  90. package/test/viewing-generations.test.js +390 -390
  91. package/test/whole-file-held-read.test.js +30 -30
  92. package/utils/coalesce.js +41 -41
@@ -1,391 +1,391 @@
1
- /**
2
- * @file The number a subtitle track is asked for by, and one walk per file.
3
- *
4
- * Two rules, both found by reading on 2026-08-26 after the report that embedded
5
- * subtitles appear late (`research/subtitle-delay-2026-08-26.md`):
6
- *
7
- * 1. The browser names a track by ffmpeg's `0:s:N`, which counts EVERY subtitle
8
- * stream. The container plan drops the picture-based ones — PGS, VobSub —
9
- * because they cannot become WebVTT, so counting the kept ones is a
10
- * different numbering as soon as a file carries one of each. What that cost:
11
- * the push landed on a track the browser does not know, and the browser's
12
- * own request found no track at all and fell through to the ffmpeg
13
- * extraction, which reads the whole film (752 s measured, 2026-08-19).
14
- * 2. A file is walked once at a time. The walk marks a cluster as read only
15
- * after two suspension points, and it is started both on every verified
16
- * piece and on a 3 s timer, so two passes could read and parse the same
17
- * cluster and push the same line twice.
18
- */
19
-
20
- import test from "node:test";
21
- import assert from "node:assert/strict";
22
- import { Readable } from "node:stream";
23
- import { MatroskaContainer } from "../services/media/container/MatroskaContainer.js";
24
- import { cuesHeldFor, forgetSubtitles } from "../services/media/SubtitleCues.js";
25
- import { heldFileOver } from "./helpers/held-file.js";
26
-
27
- const ID_EBML = 0x1a45dfa3;
28
- const ID_SEGMENT = 0x18538067;
29
- const ID_SEEK_HEAD = 0x114d9b74;
30
- const ID_SEEK = 0x4dbb;
31
- const ID_SEEK_ID = 0x53ab;
32
- const ID_SEEK_POSITION = 0x53ac;
33
- const ID_INFO = 0x1549a966;
34
- const ID_TIMESTAMP_SCALE = 0x2ad7b1;
35
- const ID_TRACKS = 0x1654ae6b;
36
- const ID_TRACK_ENTRY = 0xae;
37
- const ID_TRACK_NUMBER = 0xd7;
38
- const ID_TRACK_TYPE = 0x83;
39
- const ID_CODEC_ID = 0x86;
40
- const ID_LANGUAGE = 0x22b59c;
41
- const ID_LANGUAGE_BCP47 = 0x22b59d;
42
- const ID_FLAG_ENABLED = 0xb9;
43
- const ID_FLAG_FORCED = 0x55aa;
44
- const ID_FLAG_HEARING_IMPAIRED = 0x55ab;
45
- const ID_CUES = 0x1c53bb6b;
46
- const ID_CUE_POINT = 0xbb;
47
- const ID_CUE_TIME = 0xb3;
48
- const ID_CUE_TRACK_POSITIONS = 0xb7;
49
- const ID_CUE_TRACK = 0xf7;
50
- const ID_CUE_CLUSTER_POSITION = 0xf1;
51
- const ID_CLUSTER = 0x1f43b675;
52
- const ID_TIMESTAMP = 0xe7;
53
-
54
- /** An element id, as the bytes the specification gives it. */
55
- function idBytes(id) {
56
- const bytes = [];
57
- let rest = id;
58
- while (rest > 0) {
59
- bytes.unshift(rest & 0xff);
60
- rest = Math.floor(rest / 256);
61
- }
62
- return Buffer.from(bytes);
63
- }
64
-
65
- /** A size, as a four-byte EBML variable-length integer. */
66
- function sizeBytes(size) {
67
- const buffer = Buffer.alloc(4);
68
- buffer.writeUInt32BE(size, 0);
69
- buffer[0] |= 0x10;
70
- return buffer;
71
- }
72
-
73
- function element(id, payload) {
74
- return Buffer.concat([idBytes(id), sizeBytes(payload.length), payload]);
75
- }
76
-
77
- function uintElement(id, value) {
78
- const bytes = [];
79
- let rest = value;
80
- do {
81
- bytes.unshift(rest & 0xff);
82
- rest = Math.floor(rest / 256);
83
- } while (rest > 0);
84
- return element(id, Buffer.from(bytes));
85
- }
86
-
87
- function stringElement(id, value) {
88
- return element(id, Buffer.from(value, "utf8"));
89
- }
90
-
91
- /**
92
- * An unsigned value at a FIXED four bytes. A cue's cluster position has to be
93
- * written twice — once to measure the table, once with the position that
94
- * measurement produced — and a value-sized element would make the second table
95
- * a different length from the first, moving the very cluster it names.
96
- */
97
- function uint32Element(id, value) {
98
- const payload = Buffer.alloc(4);
99
- payload.writeUInt32BE(value, 0);
100
- return element(id, payload);
101
- }
102
-
103
- function trackEntry({ number, type, codecId, language, flags = {}, languageBcp47 = null }) {
104
- const parts = [
105
- uintElement(ID_TRACK_NUMBER, number),
106
- uintElement(ID_TRACK_TYPE, type),
107
- stringElement(ID_CODEC_ID, codecId)
108
- ];
109
- if (language !== undefined && language !== null) {
110
- parts.push(stringElement(ID_LANGUAGE, language));
111
- }
112
- if (languageBcp47 !== null) {
113
- parts.push(stringElement(ID_LANGUAGE_BCP47, languageBcp47));
114
- }
115
- for (const [id, value] of [
116
- [ID_FLAG_ENABLED, flags.enabled],
117
- [ID_FLAG_FORCED, flags.forced],
118
- [ID_FLAG_HEARING_IMPAIRED, flags.hearingImpaired]
119
- ]) {
120
- if (value !== undefined) {
121
- parts.push(uintElement(id, value ? 1 : 0));
122
- }
123
- }
124
- return element(ID_TRACK_ENTRY, Buffer.concat(parts));
125
- }
126
-
127
- /**
128
- * A file whose subtitle tracks are, in the container's own order: a picture
129
- * one, then two text ones. ffmpeg numbers those `0:s:0`, `0:s:1`, `0:s:2`;
130
- * the plan can only read the last two.
131
- *
132
- * The Cues table points both text tracks at one cluster, which is written after
133
- * the table so its position can be stated.
134
- *
135
- * @returns {{ file: Buffer, clusterAt: number }}
136
- */
137
- function buildFile() {
138
- const info = element(ID_INFO, uintElement(ID_TIMESTAMP_SCALE, 1_000_000));
139
- const tracks = element(ID_TRACKS, Buffer.concat([
140
- trackEntry({ number: 1, type: 1, codecId: "V_MPEG4/ISO/AVC", language: "und" }),
141
- trackEntry({ number: 2, type: 17, codecId: "S_HDMV/PGS", language: "eng" }),
142
- trackEntry({ number: 3, type: 17, codecId: "S_TEXT/UTF8", language: "rus" }),
143
- trackEntry({ number: 4, type: 17, codecId: "S_TEXT/ASS", language: "eng" })
144
- ]));
145
-
146
- // Built twice: the cue points state where the cluster is, and that position
147
- // is only known once everything before it has its final length. Every size
148
- // and position here is written at a fixed width, so the draft and the final
149
- // table are the same length.
150
- const cuesWith = (clusterAt) => element(ID_CUES, Buffer.concat([
151
- element(ID_CUE_POINT, Buffer.concat([
152
- uintElement(ID_CUE_TIME, 1000),
153
- element(ID_CUE_TRACK_POSITIONS, Buffer.concat([
154
- uintElement(ID_CUE_TRACK, 3),
155
- uint32Element(ID_CUE_CLUSTER_POSITION, clusterAt)
156
- ])),
157
- element(ID_CUE_TRACK_POSITIONS, Buffer.concat([
158
- uintElement(ID_CUE_TRACK, 4),
159
- uint32Element(ID_CUE_CLUSTER_POSITION, clusterAt)
160
- ]))
161
- ]))
162
- ]));
163
-
164
- const seekEntry = (targetId, position) => element(ID_SEEK, Buffer.concat([
165
- element(ID_SEEK_ID, idBytes(targetId)),
166
- element(ID_SEEK_POSITION, (() => {
167
- const buffer = Buffer.alloc(4);
168
- buffer.writeUInt32BE(position, 0);
169
- return buffer;
170
- })())
171
- ]));
172
- const seekHeadWith = (infoAt, tracksAt, cuesAt) => element(ID_SEEK_HEAD, Buffer.concat([
173
- seekEntry(ID_INFO, infoAt),
174
- seekEntry(ID_TRACKS, tracksAt),
175
- seekEntry(ID_CUES, cuesAt)
176
- ]));
177
-
178
- const headLength = seekHeadWith(0, 0, 0).length;
179
- const infoAt = headLength;
180
- const tracksAt = infoAt + info.length;
181
- const cuesAt = tracksAt + tracks.length;
182
- // A position in the Cues table is measured from the Segment's payload, and so
183
- // is the one the reader turns it into.
184
- const clusterRelative = cuesAt + cuesWith(0).length;
185
-
186
- // Enough of a cluster to be read and recognised: its own header and a
187
- // timestamp. No blocks, so it yields no cues — what the walk test counts is
188
- // that its bytes are fetched once, and that does not depend on their content.
189
- const cluster = element(ID_CLUSTER, uintElement(ID_TIMESTAMP, 1000));
190
-
191
- const segmentPayload = Buffer.concat([
192
- seekHeadWith(infoAt, tracksAt, cuesAt),
193
- info,
194
- tracks,
195
- cuesWith(clusterRelative),
196
- cluster
197
- ]);
198
- const ebml = element(ID_EBML, Buffer.from([0x42, 0x86, 0x81, 0x01]));
199
- const segment = element(ID_SEGMENT, segmentPayload);
200
- const segmentDataOffset = ebml.length + segment.length - segmentPayload.length;
201
- return {
202
- file: Buffer.concat([ebml, segment]),
203
- clusterAt: segmentDataOffset + clusterRelative
204
- };
205
- }
206
-
207
- function readerOver(file) {
208
- return async (start, end) => {
209
- const last = Math.min(end, file.length - 1);
210
- return start > last ? null : file.subarray(start, last + 1);
211
- };
212
- }
213
-
214
- test("a text track is numbered as ffmpeg numbers it, past the picture ones", async () => {
215
- const { file } = buildFile();
216
-
217
- const plan = await MatroskaContainer.readSubtitlePlan(readerOver(file), file.length);
218
-
219
- assert.equal(plan.declared.length, 3, "all three subtitle tracks are declared");
220
- assert.deepEqual(plan.tracks.map((track) => track.trackNumber), [3, 4], "only the text ones are readable");
221
- assert.deepEqual(
222
- plan.tracks.map((track) => track.declaredIndex),
223
- [1, 2],
224
- "the PGS track is 0:s:0, so the text tracks are 0:s:1 and 0:s:2 — not 0 and 1"
225
- );
226
- });
227
-
228
- /**
229
- * A torrent holding one file entirely, counting the byte ranges read from it.
230
- *
231
- * @param {Buffer} bytes
232
- * @returns {{ torrent: object, reads: Array<{ start: number, end: number }> }}
233
- */
234
- function torrentOver(bytes) {
235
- const reads = [];
236
- const file = {
237
- name: "film.mkv",
238
- length: bytes.length,
239
- offset: 0,
240
- createReadStream({ start = 0, end = bytes.length - 1 } = {}) {
241
- reads.push({ start, end });
242
- // Asynchronous on purpose: a read that resolves in the same tick would
243
- // hide exactly the interleaving this test is about.
244
- return Readable.from((async function* chunks() {
245
- await new Promise((resolve) => setImmediate(resolve));
246
- yield bytes.subarray(start, end + 1);
247
- })());
248
- }
249
- };
250
- return {
251
- reads,
252
- torrent: {
253
- pieceLength: 1024,
254
- bitfield: { get: () => true },
255
- files: [file]
256
- }
257
- };
258
- }
259
-
260
- test("two walks of one file at the same time read each cluster once", async () => {
261
- const { file, clusterAt } = buildFile();
262
- const { torrent, reads } = torrentOver(file);
263
- const sourceKey = "torrent:numbering-test";
264
- forgetSubtitles(sourceKey);
265
-
266
- // Both text tracks at once, which is what the warmup does on every verified
267
- // piece and every three seconds.
268
- const [first, second] = await Promise.all([
269
- cuesHeldFor(heldFileOver(torrent, 0, sourceKey), 3),
270
- cuesHeldFor(heldFileOver(torrent, 0, sourceKey), 4)
271
- ]);
272
-
273
- assert.equal(first.coveredClusters, 1, "the cluster the table names was walked");
274
- assert.equal(second.coveredClusters, 1, "and the second track sees the same walk, not its own");
275
- const clusterReads = reads.filter((range) => range.start === clusterAt);
276
- assert.equal(
277
- clusterReads.length,
278
- 2,
279
- "one probe of the cluster's header and one read of its body — not two of each"
280
- );
281
- forgetSubtitles(sourceKey);
282
- });
283
-
284
- /**
285
- * A file whose subtitle tracks carry the flags RFC 9559 defines for them: one
286
- * forced, one for viewers who cannot hear, one the file marks unusable, one
287
- * writing its language as RFC 5646 alongside the three-letter code, and one
288
- * relying on Matroska's default language.
289
- *
290
- * @returns {Buffer}
291
- */
292
- function fileWithFlags() {
293
- const info = element(ID_INFO, uintElement(ID_TIMESTAMP_SCALE, 1_000_000));
294
- const tracks = element(ID_TRACKS, Buffer.concat([
295
- trackEntry({ number: 1, type: 1, codecId: "V_MPEG4/ISO/AVC", language: "und" }),
296
- trackEntry({ number: 2, type: 17, codecId: "S_TEXT/UTF8", language: "rus", flags: { forced: true } }),
297
- trackEntry({ number: 3, type: 17, codecId: "S_TEXT/UTF8", language: "eng", flags: { hearingImpaired: true } }),
298
- trackEntry({ number: 4, type: 17, codecId: "S_TEXT/UTF8", language: "fre", flags: { enabled: false } }),
299
- trackEntry({ number: 5, type: 17, codecId: "S_TEXT/ASS", language: "por", languageBcp47: "pt-BR" }),
300
- trackEntry({ number: 6, type: 17, codecId: "S_TEXT/UTF8", language: null })
301
- ]));
302
- const seekEntry = (targetId, position) => element(ID_SEEK, Buffer.concat([
303
- element(ID_SEEK_ID, idBytes(targetId)),
304
- uint32Element(ID_SEEK_POSITION, position)
305
- ]));
306
- const seekHeadWith = (infoAt, tracksAt) => element(ID_SEEK_HEAD, Buffer.concat([
307
- seekEntry(ID_INFO, infoAt),
308
- seekEntry(ID_TRACKS, tracksAt)
309
- ]));
310
- const headLength = seekHeadWith(0, 0).length;
311
- const segmentPayload = Buffer.concat([
312
- seekHeadWith(headLength, headLength + info.length),
313
- info,
314
- tracks
315
- ]);
316
- const ebml = element(ID_EBML, Buffer.from([0x42, 0x86, 0x81, 0x01]));
317
- return Buffer.concat([ebml, element(ID_SEGMENT, segmentPayload)]);
318
- }
319
-
320
- test("the flags the file states about a track are read, not guessed from its name", async () => {
321
- const plan = await MatroskaContainer.readSubtitlePlan(readerOver(fileWithFlags()), fileWithFlags().length);
322
-
323
- const forced = plan.tracks.find((track) => track.trackNumber === 2);
324
- assert.equal(forced.isForced, true, "FlagForced 0x55AA");
325
- assert.equal(forced.isHearingImpaired, false);
326
-
327
- const sdh = plan.tracks.find((track) => track.trackNumber === 3);
328
- assert.equal(sdh.isHearingImpaired, true, "FlagHearingImpaired 0x55AB");
329
- assert.equal(sdh.isForced, false);
330
- });
331
-
332
- test("a track the file marks unusable is not offered, but is still counted", async () => {
333
- // FlagEnabled (0xB9): "Set to 1 if the track is usable." Track 4 says 0, so
334
- // it is not offered — but it KEEPS its place in the numbering, because ffmpeg
335
- // keeps it: `matroskadec.c` parses MATROSKA_ID_TRACKFLAGENABLED as EBML_NONE,
336
- // reading the element and storing nothing, so the stream is created and gets
337
- // its own `0:s:N`. Dropping it here would shift every track after it.
338
- const plan = await MatroskaContainer.readSubtitlePlan(readerOver(fileWithFlags()), fileWithFlags().length);
339
-
340
- assert.equal(plan.tracks.some((track) => track.trackNumber === 4), false, "not offered for extraction");
341
- const counted = plan.declared.find((track) => track.trackNumber === 4);
342
- assert.ok(counted, "still declared, so the numbering does not move");
343
- assert.equal(counted.isEnabled, false);
344
- });
345
-
346
- test("an unusable track keeps its place, so the tracks after it keep theirs", async () => {
347
- const plan = await MatroskaContainer.readSubtitlePlan(readerOver(fileWithFlags()), fileWithFlags().length);
348
-
349
- // s:0 forced, s:1 SDH, s:2 the unusable one, s:3 the Brazilian track.
350
- assert.deepEqual(
351
- plan.tracks.map((track) => [track.trackNumber, track.declaredIndex]),
352
- [[2, 0], [3, 1], [5, 3], [6, 4]]
353
- );
354
- });
355
-
356
- test("the list ffmpeg is lined up against still speaks ffmpeg's language codes", async () => {
357
- // `declared` exists to be paired with the `-i` banner, which prints the
358
- // three-letter code; reporting "pt-BR" there would break the pairing and cost
359
- // the FlagDefault reading with it.
360
- const plan = await MatroskaContainer.readSubtitlePlan(readerOver(fileWithFlags()), fileWithFlags().length);
361
-
362
- const declared = plan.declared.find((track) => track.trackNumber === 5);
363
- assert.equal(declared.language, "por");
364
- assert.equal(declared.languageBcp47, "pt-BR");
365
- });
366
-
367
- test("where the file writes RFC 5646, that is the language", async () => {
368
- // "If this element is used, then any Language elements used in the same
369
- // TrackEntry MUST be ignored."
370
- const plan = await MatroskaContainer.readSubtitlePlan(readerOver(fileWithFlags()), fileWithFlags().length);
371
-
372
- const track = plan.tracks.find((entry) => entry.trackNumber === 5);
373
- assert.equal(track.language, "pt-BR", "not the three-letter por");
374
- assert.equal(track.languageBcp47, "pt-BR");
375
- });
376
-
377
- test("an omitted Matroska Language element is the format's default, `eng`, and says it was not written", async () => {
378
- // RFC 9559 §5.1.4.1.19 gives Language the default `eng`; RFC 8794 §11.1.19
379
- // says an element equal to its default need not be written, and a reader MUST
380
- // read the default. Until 2026-10-01 such a track was offered as Unknown.
381
- const file = fileWithFlags();
382
- const plan = await MatroskaContainer.readSubtitlePlan(readerOver(file), file.length);
383
-
384
- const track = plan.tracks.find((entry) => entry.trackNumber === 6);
385
- const declared = plan.declared.find((entry) => entry.trackNumber === 6);
386
- assert.equal(track.language, "eng");
387
- assert.equal(track.languageSource, "default");
388
- assert.equal(track.declaresLanguage, false, "the element itself was not written");
389
- assert.equal(declared.language, "eng");
390
- assert.equal(declared.declaresLanguage, false);
391
- });
1
+ /**
2
+ * @file The number a subtitle track is asked for by, and one walk per file.
3
+ *
4
+ * Two rules, both found by reading on 2026-08-26 after the report that embedded
5
+ * subtitles appear late (`research/subtitle-delay-2026-08-26.md`):
6
+ *
7
+ * 1. The browser names a track by ffmpeg's `0:s:N`, which counts EVERY subtitle
8
+ * stream. The container plan drops the picture-based ones — PGS, VobSub —
9
+ * because they cannot become WebVTT, so counting the kept ones is a
10
+ * different numbering as soon as a file carries one of each. What that cost:
11
+ * the push landed on a track the browser does not know, and the browser's
12
+ * own request found no track at all and fell through to the ffmpeg
13
+ * extraction, which reads the whole film (752 s measured, 2026-08-19).
14
+ * 2. A file is walked once at a time. The walk marks a cluster as read only
15
+ * after two suspension points, and it is started both on every verified
16
+ * piece and on a 3 s timer, so two passes could read and parse the same
17
+ * cluster and push the same line twice.
18
+ */
19
+
20
+ import test from "node:test";
21
+ import assert from "node:assert/strict";
22
+ import { Readable } from "node:stream";
23
+ import { MatroskaContainer } from "../services/media/container/MatroskaContainer.js";
24
+ import { cuesHeldFor, forgetSubtitles } from "../services/media/SubtitleCues.js";
25
+ import { heldFileOver } from "./helpers/held-file.js";
26
+
27
+ const ID_EBML = 0x1a45dfa3;
28
+ const ID_SEGMENT = 0x18538067;
29
+ const ID_SEEK_HEAD = 0x114d9b74;
30
+ const ID_SEEK = 0x4dbb;
31
+ const ID_SEEK_ID = 0x53ab;
32
+ const ID_SEEK_POSITION = 0x53ac;
33
+ const ID_INFO = 0x1549a966;
34
+ const ID_TIMESTAMP_SCALE = 0x2ad7b1;
35
+ const ID_TRACKS = 0x1654ae6b;
36
+ const ID_TRACK_ENTRY = 0xae;
37
+ const ID_TRACK_NUMBER = 0xd7;
38
+ const ID_TRACK_TYPE = 0x83;
39
+ const ID_CODEC_ID = 0x86;
40
+ const ID_LANGUAGE = 0x22b59c;
41
+ const ID_LANGUAGE_BCP47 = 0x22b59d;
42
+ const ID_FLAG_ENABLED = 0xb9;
43
+ const ID_FLAG_FORCED = 0x55aa;
44
+ const ID_FLAG_HEARING_IMPAIRED = 0x55ab;
45
+ const ID_CUES = 0x1c53bb6b;
46
+ const ID_CUE_POINT = 0xbb;
47
+ const ID_CUE_TIME = 0xb3;
48
+ const ID_CUE_TRACK_POSITIONS = 0xb7;
49
+ const ID_CUE_TRACK = 0xf7;
50
+ const ID_CUE_CLUSTER_POSITION = 0xf1;
51
+ const ID_CLUSTER = 0x1f43b675;
52
+ const ID_TIMESTAMP = 0xe7;
53
+
54
+ /** An element id, as the bytes the specification gives it. */
55
+ function idBytes(id) {
56
+ const bytes = [];
57
+ let rest = id;
58
+ while (rest > 0) {
59
+ bytes.unshift(rest & 0xff);
60
+ rest = Math.floor(rest / 256);
61
+ }
62
+ return Buffer.from(bytes);
63
+ }
64
+
65
+ /** A size, as a four-byte EBML variable-length integer. */
66
+ function sizeBytes(size) {
67
+ const buffer = Buffer.alloc(4);
68
+ buffer.writeUInt32BE(size, 0);
69
+ buffer[0] |= 0x10;
70
+ return buffer;
71
+ }
72
+
73
+ function element(id, payload) {
74
+ return Buffer.concat([idBytes(id), sizeBytes(payload.length), payload]);
75
+ }
76
+
77
+ function uintElement(id, value) {
78
+ const bytes = [];
79
+ let rest = value;
80
+ do {
81
+ bytes.unshift(rest & 0xff);
82
+ rest = Math.floor(rest / 256);
83
+ } while (rest > 0);
84
+ return element(id, Buffer.from(bytes));
85
+ }
86
+
87
+ function stringElement(id, value) {
88
+ return element(id, Buffer.from(value, "utf8"));
89
+ }
90
+
91
+ /**
92
+ * An unsigned value at a FIXED four bytes. A cue's cluster position has to be
93
+ * written twice — once to measure the table, once with the position that
94
+ * measurement produced — and a value-sized element would make the second table
95
+ * a different length from the first, moving the very cluster it names.
96
+ */
97
+ function uint32Element(id, value) {
98
+ const payload = Buffer.alloc(4);
99
+ payload.writeUInt32BE(value, 0);
100
+ return element(id, payload);
101
+ }
102
+
103
+ function trackEntry({ number, type, codecId, language, flags = {}, languageBcp47 = null }) {
104
+ const parts = [
105
+ uintElement(ID_TRACK_NUMBER, number),
106
+ uintElement(ID_TRACK_TYPE, type),
107
+ stringElement(ID_CODEC_ID, codecId)
108
+ ];
109
+ if (language !== undefined && language !== null) {
110
+ parts.push(stringElement(ID_LANGUAGE, language));
111
+ }
112
+ if (languageBcp47 !== null) {
113
+ parts.push(stringElement(ID_LANGUAGE_BCP47, languageBcp47));
114
+ }
115
+ for (const [id, value] of [
116
+ [ID_FLAG_ENABLED, flags.enabled],
117
+ [ID_FLAG_FORCED, flags.forced],
118
+ [ID_FLAG_HEARING_IMPAIRED, flags.hearingImpaired]
119
+ ]) {
120
+ if (value !== undefined) {
121
+ parts.push(uintElement(id, value ? 1 : 0));
122
+ }
123
+ }
124
+ return element(ID_TRACK_ENTRY, Buffer.concat(parts));
125
+ }
126
+
127
+ /**
128
+ * A file whose subtitle tracks are, in the container's own order: a picture
129
+ * one, then two text ones. ffmpeg numbers those `0:s:0`, `0:s:1`, `0:s:2`;
130
+ * the plan can only read the last two.
131
+ *
132
+ * The Cues table points both text tracks at one cluster, which is written after
133
+ * the table so its position can be stated.
134
+ *
135
+ * @returns {{ file: Buffer, clusterAt: number }}
136
+ */
137
+ function buildFile() {
138
+ const info = element(ID_INFO, uintElement(ID_TIMESTAMP_SCALE, 1_000_000));
139
+ const tracks = element(ID_TRACKS, Buffer.concat([
140
+ trackEntry({ number: 1, type: 1, codecId: "V_MPEG4/ISO/AVC", language: "und" }),
141
+ trackEntry({ number: 2, type: 17, codecId: "S_HDMV/PGS", language: "eng" }),
142
+ trackEntry({ number: 3, type: 17, codecId: "S_TEXT/UTF8", language: "rus" }),
143
+ trackEntry({ number: 4, type: 17, codecId: "S_TEXT/ASS", language: "eng" })
144
+ ]));
145
+
146
+ // Built twice: the cue points state where the cluster is, and that position
147
+ // is only known once everything before it has its final length. Every size
148
+ // and position here is written at a fixed width, so the draft and the final
149
+ // table are the same length.
150
+ const cuesWith = (clusterAt) => element(ID_CUES, Buffer.concat([
151
+ element(ID_CUE_POINT, Buffer.concat([
152
+ uintElement(ID_CUE_TIME, 1000),
153
+ element(ID_CUE_TRACK_POSITIONS, Buffer.concat([
154
+ uintElement(ID_CUE_TRACK, 3),
155
+ uint32Element(ID_CUE_CLUSTER_POSITION, clusterAt)
156
+ ])),
157
+ element(ID_CUE_TRACK_POSITIONS, Buffer.concat([
158
+ uintElement(ID_CUE_TRACK, 4),
159
+ uint32Element(ID_CUE_CLUSTER_POSITION, clusterAt)
160
+ ]))
161
+ ]))
162
+ ]));
163
+
164
+ const seekEntry = (targetId, position) => element(ID_SEEK, Buffer.concat([
165
+ element(ID_SEEK_ID, idBytes(targetId)),
166
+ element(ID_SEEK_POSITION, (() => {
167
+ const buffer = Buffer.alloc(4);
168
+ buffer.writeUInt32BE(position, 0);
169
+ return buffer;
170
+ })())
171
+ ]));
172
+ const seekHeadWith = (infoAt, tracksAt, cuesAt) => element(ID_SEEK_HEAD, Buffer.concat([
173
+ seekEntry(ID_INFO, infoAt),
174
+ seekEntry(ID_TRACKS, tracksAt),
175
+ seekEntry(ID_CUES, cuesAt)
176
+ ]));
177
+
178
+ const headLength = seekHeadWith(0, 0, 0).length;
179
+ const infoAt = headLength;
180
+ const tracksAt = infoAt + info.length;
181
+ const cuesAt = tracksAt + tracks.length;
182
+ // A position in the Cues table is measured from the Segment's payload, and so
183
+ // is the one the reader turns it into.
184
+ const clusterRelative = cuesAt + cuesWith(0).length;
185
+
186
+ // Enough of a cluster to be read and recognised: its own header and a
187
+ // timestamp. No blocks, so it yields no cues — what the walk test counts is
188
+ // that its bytes are fetched once, and that does not depend on their content.
189
+ const cluster = element(ID_CLUSTER, uintElement(ID_TIMESTAMP, 1000));
190
+
191
+ const segmentPayload = Buffer.concat([
192
+ seekHeadWith(infoAt, tracksAt, cuesAt),
193
+ info,
194
+ tracks,
195
+ cuesWith(clusterRelative),
196
+ cluster
197
+ ]);
198
+ const ebml = element(ID_EBML, Buffer.from([0x42, 0x86, 0x81, 0x01]));
199
+ const segment = element(ID_SEGMENT, segmentPayload);
200
+ const segmentDataOffset = ebml.length + segment.length - segmentPayload.length;
201
+ return {
202
+ file: Buffer.concat([ebml, segment]),
203
+ clusterAt: segmentDataOffset + clusterRelative
204
+ };
205
+ }
206
+
207
+ function readerOver(file) {
208
+ return async (start, end) => {
209
+ const last = Math.min(end, file.length - 1);
210
+ return start > last ? null : file.subarray(start, last + 1);
211
+ };
212
+ }
213
+
214
+ test("a text track is numbered as ffmpeg numbers it, past the picture ones", async () => {
215
+ const { file } = buildFile();
216
+
217
+ const plan = await MatroskaContainer.readSubtitlePlan(readerOver(file), file.length);
218
+
219
+ assert.equal(plan.declared.length, 3, "all three subtitle tracks are declared");
220
+ assert.deepEqual(plan.tracks.map((track) => track.trackNumber), [3, 4], "only the text ones are readable");
221
+ assert.deepEqual(
222
+ plan.tracks.map((track) => track.declaredIndex),
223
+ [1, 2],
224
+ "the PGS track is 0:s:0, so the text tracks are 0:s:1 and 0:s:2 — not 0 and 1"
225
+ );
226
+ });
227
+
228
+ /**
229
+ * A torrent holding one file entirely, counting the byte ranges read from it.
230
+ *
231
+ * @param {Buffer} bytes
232
+ * @returns {{ torrent: object, reads: Array<{ start: number, end: number }> }}
233
+ */
234
+ function torrentOver(bytes) {
235
+ const reads = [];
236
+ const file = {
237
+ name: "film.mkv",
238
+ length: bytes.length,
239
+ offset: 0,
240
+ createReadStream({ start = 0, end = bytes.length - 1 } = {}) {
241
+ reads.push({ start, end });
242
+ // Asynchronous on purpose: a read that resolves in the same tick would
243
+ // hide exactly the interleaving this test is about.
244
+ return Readable.from((async function* chunks() {
245
+ await new Promise((resolve) => setImmediate(resolve));
246
+ yield bytes.subarray(start, end + 1);
247
+ })());
248
+ }
249
+ };
250
+ return {
251
+ reads,
252
+ torrent: {
253
+ pieceLength: 1024,
254
+ bitfield: { get: () => true },
255
+ files: [file]
256
+ }
257
+ };
258
+ }
259
+
260
+ test("two walks of one file at the same time read each cluster once", async () => {
261
+ const { file, clusterAt } = buildFile();
262
+ const { torrent, reads } = torrentOver(file);
263
+ const sourceKey = "torrent:numbering-test";
264
+ forgetSubtitles(sourceKey);
265
+
266
+ // Both text tracks at once, which is what the warmup does on every verified
267
+ // piece and every three seconds.
268
+ const [first, second] = await Promise.all([
269
+ cuesHeldFor(heldFileOver(torrent, 0, sourceKey), 3),
270
+ cuesHeldFor(heldFileOver(torrent, 0, sourceKey), 4)
271
+ ]);
272
+
273
+ assert.equal(first.coveredClusters, 1, "the cluster the table names was walked");
274
+ assert.equal(second.coveredClusters, 1, "and the second track sees the same walk, not its own");
275
+ const clusterReads = reads.filter((range) => range.start === clusterAt);
276
+ assert.equal(
277
+ clusterReads.length,
278
+ 2,
279
+ "one probe of the cluster's header and one read of its body — not two of each"
280
+ );
281
+ forgetSubtitles(sourceKey);
282
+ });
283
+
284
+ /**
285
+ * A file whose subtitle tracks carry the flags RFC 9559 defines for them: one
286
+ * forced, one for viewers who cannot hear, one the file marks unusable, one
287
+ * writing its language as RFC 5646 alongside the three-letter code, and one
288
+ * relying on Matroska's default language.
289
+ *
290
+ * @returns {Buffer}
291
+ */
292
+ function fileWithFlags() {
293
+ const info = element(ID_INFO, uintElement(ID_TIMESTAMP_SCALE, 1_000_000));
294
+ const tracks = element(ID_TRACKS, Buffer.concat([
295
+ trackEntry({ number: 1, type: 1, codecId: "V_MPEG4/ISO/AVC", language: "und" }),
296
+ trackEntry({ number: 2, type: 17, codecId: "S_TEXT/UTF8", language: "rus", flags: { forced: true } }),
297
+ trackEntry({ number: 3, type: 17, codecId: "S_TEXT/UTF8", language: "eng", flags: { hearingImpaired: true } }),
298
+ trackEntry({ number: 4, type: 17, codecId: "S_TEXT/UTF8", language: "fre", flags: { enabled: false } }),
299
+ trackEntry({ number: 5, type: 17, codecId: "S_TEXT/ASS", language: "por", languageBcp47: "pt-BR" }),
300
+ trackEntry({ number: 6, type: 17, codecId: "S_TEXT/UTF8", language: null })
301
+ ]));
302
+ const seekEntry = (targetId, position) => element(ID_SEEK, Buffer.concat([
303
+ element(ID_SEEK_ID, idBytes(targetId)),
304
+ uint32Element(ID_SEEK_POSITION, position)
305
+ ]));
306
+ const seekHeadWith = (infoAt, tracksAt) => element(ID_SEEK_HEAD, Buffer.concat([
307
+ seekEntry(ID_INFO, infoAt),
308
+ seekEntry(ID_TRACKS, tracksAt)
309
+ ]));
310
+ const headLength = seekHeadWith(0, 0).length;
311
+ const segmentPayload = Buffer.concat([
312
+ seekHeadWith(headLength, headLength + info.length),
313
+ info,
314
+ tracks
315
+ ]);
316
+ const ebml = element(ID_EBML, Buffer.from([0x42, 0x86, 0x81, 0x01]));
317
+ return Buffer.concat([ebml, element(ID_SEGMENT, segmentPayload)]);
318
+ }
319
+
320
+ test("the flags the file states about a track are read, not guessed from its name", async () => {
321
+ const plan = await MatroskaContainer.readSubtitlePlan(readerOver(fileWithFlags()), fileWithFlags().length);
322
+
323
+ const forced = plan.tracks.find((track) => track.trackNumber === 2);
324
+ assert.equal(forced.isForced, true, "FlagForced 0x55AA");
325
+ assert.equal(forced.isHearingImpaired, false);
326
+
327
+ const sdh = plan.tracks.find((track) => track.trackNumber === 3);
328
+ assert.equal(sdh.isHearingImpaired, true, "FlagHearingImpaired 0x55AB");
329
+ assert.equal(sdh.isForced, false);
330
+ });
331
+
332
+ test("a track the file marks unusable is not offered, but is still counted", async () => {
333
+ // FlagEnabled (0xB9): "Set to 1 if the track is usable." Track 4 says 0, so
334
+ // it is not offered — but it KEEPS its place in the numbering, because ffmpeg
335
+ // keeps it: `matroskadec.c` parses MATROSKA_ID_TRACKFLAGENABLED as EBML_NONE,
336
+ // reading the element and storing nothing, so the stream is created and gets
337
+ // its own `0:s:N`. Dropping it here would shift every track after it.
338
+ const plan = await MatroskaContainer.readSubtitlePlan(readerOver(fileWithFlags()), fileWithFlags().length);
339
+
340
+ assert.equal(plan.tracks.some((track) => track.trackNumber === 4), false, "not offered for extraction");
341
+ const counted = plan.declared.find((track) => track.trackNumber === 4);
342
+ assert.ok(counted, "still declared, so the numbering does not move");
343
+ assert.equal(counted.isEnabled, false);
344
+ });
345
+
346
+ test("an unusable track keeps its place, so the tracks after it keep theirs", async () => {
347
+ const plan = await MatroskaContainer.readSubtitlePlan(readerOver(fileWithFlags()), fileWithFlags().length);
348
+
349
+ // s:0 forced, s:1 SDH, s:2 the unusable one, s:3 the Brazilian track.
350
+ assert.deepEqual(
351
+ plan.tracks.map((track) => [track.trackNumber, track.declaredIndex]),
352
+ [[2, 0], [3, 1], [5, 3], [6, 4]]
353
+ );
354
+ });
355
+
356
+ test("the list ffmpeg is lined up against still speaks ffmpeg's language codes", async () => {
357
+ // `declared` exists to be paired with the `-i` banner, which prints the
358
+ // three-letter code; reporting "pt-BR" there would break the pairing and cost
359
+ // the FlagDefault reading with it.
360
+ const plan = await MatroskaContainer.readSubtitlePlan(readerOver(fileWithFlags()), fileWithFlags().length);
361
+
362
+ const declared = plan.declared.find((track) => track.trackNumber === 5);
363
+ assert.equal(declared.language, "por");
364
+ assert.equal(declared.languageBcp47, "pt-BR");
365
+ });
366
+
367
+ test("where the file writes RFC 5646, that is the language", async () => {
368
+ // "If this element is used, then any Language elements used in the same
369
+ // TrackEntry MUST be ignored."
370
+ const plan = await MatroskaContainer.readSubtitlePlan(readerOver(fileWithFlags()), fileWithFlags().length);
371
+
372
+ const track = plan.tracks.find((entry) => entry.trackNumber === 5);
373
+ assert.equal(track.language, "pt-BR", "not the three-letter por");
374
+ assert.equal(track.languageBcp47, "pt-BR");
375
+ });
376
+
377
+ test("an omitted Matroska Language element is the format's default, `eng`, and says it was not written", async () => {
378
+ // RFC 9559 §5.1.4.1.19 gives Language the default `eng`; RFC 8794 §11.1.19
379
+ // says an element equal to its default need not be written, and a reader MUST
380
+ // read the default. Until 2026-10-01 such a track was offered as Unknown.
381
+ const file = fileWithFlags();
382
+ const plan = await MatroskaContainer.readSubtitlePlan(readerOver(file), file.length);
383
+
384
+ const track = plan.tracks.find((entry) => entry.trackNumber === 6);
385
+ const declared = plan.declared.find((entry) => entry.trackNumber === 6);
386
+ assert.equal(track.language, "eng");
387
+ assert.equal(track.languageSource, "default");
388
+ assert.equal(track.declaresLanguage, false, "the element itself was not written");
389
+ assert.equal(declared.language, "eng");
390
+ assert.equal(declared.declaresLanguage, false);
391
+ });