@theia/core 1.67.0-next.59 → 1.67.0

package/src/common/preferences/preference-provider.ts

@@ -27,6 +27,10 @@ export interface PreferenceProviderDataChange {
     readonly preferenceName: string;
     /**
      * The new value of the changed preference.
+     * Can be `undefined` for multiple reasons:
+     * - The preference has been reset to its default value.
+     * - The preference has been reset and has no value explicitly stored.
+     * If `undefined`, use the preference service to determine the effective new value if needed.
      */
     readonly newValue?: JSONValue;
     /**

package/src/common/preferences/preference-service.ts

@@ -16,7 +16,7 @@
 
 /* eslint-disable @typescript-eslint/no-explicit-any */
 
-import { JSONExt, JSONValue } from '@lumino/coreutils';
+import { JSONValue } from '@lumino/coreutils';
 import { inject, injectable, postConstruct } from 'inversify';
 import { Disposable, DisposableCollection, Emitter, Event, deepFreeze, unreachable } from '../../common';
 import { Deferred } from '../../common/promise-util';
@@ -538,14 +538,18 @@ export class PreferenceServiceImpl implements PreferenceService {
         if (inspection) {
             const scopesToChange = this.getScopesToChange(inspection, value);
             const isDeletion = value === undefined
-                || (scopesToChange.length === 1 && scopesToChange[0] === PreferenceScope.User && JSONExt.deepEqual(value, inspection.defaultValue));
+                || (
+                    scopesToChange.length === 1
+                    && scopesToChange[0] === PreferenceScope.User
+                    && PreferenceUtils.deepEqual(value, inspection.defaultValue)
+                );
             const effectiveValue = isDeletion ? undefined : value;
             await Promise.all(scopesToChange.map(scope => this.set(preferenceName, effectiveValue, scope, resourceUri)));
         }
     }
 
     protected getScopesToChange(inspection: PreferenceInspection<any>, intendedValue: any): PreferenceScope[] {
-        if (JSONExt.deepEqual(inspection.value, intendedValue)) {
+        if (PreferenceUtils.deepEqual(inspection.value, intendedValue)) {
             return [];
         }
 

package/src/common/severity.ts

@@ -93,9 +93,9 @@ export namespace Severity {
 
     export function toLocaleString(severity: string | Severity): string {
         if (severity === Severity.Error || severity === error) {
-            return nls.localize('theia/core/severity/errors', 'Errors');
+            return nls.localizeByDefault('Errors');
         } else if (severity === Severity.Warning || severity === warning) {
-            return nls.localize('theia/core/severity/warnings', 'Warnings');
+            return nls.localizeByDefault('Warnings');
         } else if (severity === Severity.Info || severity === info) {
             return nls.localizeByDefault('Info');
         } else if (severity === Severity.Log || severity === log) {

package/src/common/types.ts

@@ -30,6 +30,12 @@ export type RecursivePartial<T> = {
     ? RecursivePartial<I>[]
     : RecursivePartial<T[P]>;
 };
+export type RecursiveReadonly<T> = {
+    readonly [P in keyof T]: T[P] extends Array<infer I>
+    ? RecursiveReadonly<I>[]
+    : T[P] extends object ? RecursiveReadonly<T[P]>
+    : T[P];
+};
 
 export function isBoolean(value: unknown): value is boolean {
     return value === true || value === false;

package/src/electron-common/electron-window-preferences.ts

@@ -45,8 +45,7 @@ export const electronWindowPreferencesSchema: PreferenceSchema = {
             enum: ['native', 'custom'],
             default: isWindows ? 'custom' : 'native',
             scope: PreferenceScope.User,
-            // eslint-disable-next-line max-len
-            description: nls.localizeByDefault('Adjust the appearance of the window title bar to be native by the OS or custom. On Linux and Windows, this setting also affects the application and context menu appearances. Changes require a full restart to apply.'),
+            description: nls.localizeByDefault('Adjust the appearance of the window title bar to be native by the OS or custom. Changes require a full restart to apply.'),
             included: !isOSX
         },
     }

package/src/electron-main/electron-main-application.ts

@@ -43,6 +43,7 @@ import { TheiaRendererAPI } from './electron-api-main';
 import { StopReason } from '../common/frontend-application-state';
 import { dynamicRequire } from '../node/dynamic-require';
 import { ThemeMode } from '../common/theme';
+import { backendGlobal } from '../node/backend-global';
 
 export { ElectronMainApplicationGlobals };
 
@@ -590,11 +591,9 @@ export class ElectronMainApplication {
     }
 
     protected getDefaultTheiaWindowBounds(): TheiaBrowserWindowOptions {
-        // The `screen` API must be required when the application is ready.
-        // See: https://electronjs.org/docs/api/screen#screen
+        const { bounds } = this.getDisplayForNewWindow();
         // We must center by hand because `browserWindow.center()` fails on multi-screen setups
         // See: https://github.com/electron/electron/issues/3490
-        const { bounds } = screen.getDisplayNearestPoint(screen.getCursorScreenPoint());
         const height = Math.round(bounds.height * (2 / 3));
         const width = Math.round(bounds.width * (2 / 3));
         const y = Math.round(bounds.y + (bounds.height - height) / 2);
@@ -607,6 +606,52 @@ export class ElectronMainApplication {
         };
     }
 
+    /**
+     * Returns the display where a new window should be opened.
+     * Attempts to use the display nearest to the cursor position for multi-monitor setups.
+     * Falls back to the primary display if cursor position cannot be determined
+     * (e.g., on Wayland before any window is opened).
+     * See: https://github.com/eclipse-theia/theia/issues/16582
+     */
+    protected getDisplayForNewWindow(): Electron.Display {
+        // On Wayland, screen.getCursorScreenPoint() causes a native crash (SIGSEGV)
+        // before any window is opened. Detect Wayland and use primary display instead.
+        if (this.isWaylandSession()) {
+            console.debug('Running under Wayland, using primary display for new window.');
+            return screen.getPrimaryDisplay();
+        }
+        try {
+            return screen.getDisplayNearestPoint(screen.getCursorScreenPoint());
+        } catch (error) {
+            console.warn('Failed to get cursor screen point, falling back to primary display.', error);
+            return screen.getPrimaryDisplay();
+        }
+    }
+
+    /**
+     * Detects if the current session is running natively under Wayland
+     * (i.e., not using X11 fallback/XWayland).
+     */
+    protected isWaylandSession(): boolean {
+        if (process.platform !== 'linux') {
+            return false;
+        }
+
+        // Primary check: WAYLAND_DISPLAY is set when a Wayland compositor is running
+        const hasWaylandDisplay = !!process.env.WAYLAND_DISPLAY;
+
+        // Secondary check: XDG_SESSION_TYPE explicitly set to 'wayland'
+        const isWaylandSession = process.env.XDG_SESSION_TYPE === 'wayland';
+
+        // Check whether X11 fallback is in use
+        const usingX11Fallback =
+            process.env.GDK_BACKEND?.includes('x11') ||
+            process.env.ELECTRON_OZONE_PLATFORM_HINT === 'x11' ||
+            process.argv.includes('--ozone-platform=x11');
+
+        return (hasWaylandDisplay || isWaylandSession) && !usingX11Fallback;
+    }
+
     /**
      * Save the window geometry state on every change.
      */
@@ -675,10 +720,12 @@ export class ElectronMainApplication {
         process.env.THEIA_ELECTRON_VERSION = process.versions.electron;
         if (noBackendFork) {
             process.env[ElectronSecurityToken] = JSON.stringify(this.electronSecurityToken);
-            // The backend server main file is supposed to export a promise resolving with the port used by the http(s) server.
+            // The backend server main file is supposed put a promise resolving with the port used by the http(s) server into the global object.
             dynamicRequire(this.globals.THEIA_BACKEND_MAIN_PATH);
-            // @ts-expect-error
-            const address: AddressInfo = await globalThis.serverAddress;
+            const address = await backendGlobal.serverAddress;
+            if (!address) {
+                throw new Error('The backend server did not start correctly.');
+            }
             return address.port;
         } else {
             const backendProcess = fork(

package/src/node/application-server.ts

@@ -18,6 +18,7 @@ import { injectable, inject } from 'inversify';
 import { ApplicationServer, ExtensionInfo, ApplicationInfo } from '../common/application-protocol';
 import { ApplicationPackage } from '@theia/application-package';
 import { OS } from '../common/os';
+import { backendGlobal } from './backend-global';
 
 @injectable()
 export class ApplicationServerImpl implements ApplicationServer {
@@ -26,9 +27,7 @@ export class ApplicationServerImpl implements ApplicationServer {
     protected readonly applicationPackage: ApplicationPackage;
 
     getExtensionsInfos(): Promise<ExtensionInfo[]> {
-        // @ts-expect-error
-        const appInfo: ExtensionInfo[] = globalThis.extensionInfo;
-        return Promise.resolve(appInfo);
+        return Promise.resolve(backendGlobal.extensionInfo);
     }
 
     getApplicationInfo(): Promise<ApplicationInfo | undefined> {

package/src/node/backend-global.ts

@@ -0,0 +1,41 @@
+// *****************************************************************************
+// Copyright (C) 2025 TypeFox and others.
+//
+// This program and the accompanying materials are made available under the
+// terms of the Eclipse Public License v. 2.0 which is available at
+// http://www.eclipse.org/legal/epl-2.0.
+//
+// This Source Code may also be made available under the following Secondary
+// Licenses when the conditions for such availability set forth in the Eclipse
+// Public License v. 2.0 are satisfied: GNU General Public License, version 2
+// with the GNU Classpath Exception which is available at
+// https://www.gnu.org/software/classpath/license.html.
+//
+// SPDX-License-Identifier: EPL-2.0 OR GPL-2.0-only WITH Classpath-exception-2.0
+// *****************************************************************************
+
+import type { AddressInfo } from 'net';
+import type { ExtensionInfo } from '../common/application-protocol';
+import { isPromise } from 'util/types';
+
+export interface BackendGlobal {
+    serverAddress?: Promise<AddressInfo>;
+    extensionInfo: ExtensionInfo[];
+}
+
+/**
+ * The global object for the backend application.
+ * Used to store application-wide information.
+ *
+ * See {@link BackendGlobal} for more details.
+ */
+export const backendGlobal: BackendGlobal = globalThis as unknown as BackendGlobal;
+
+if (backendGlobal.serverAddress !== undefined && !isPromise(backendGlobal.serverAddress)) {
+    console.error('globalThis.serverAddress should be a `Promise<AddressInfo>` if defined.');
+}
+
+if (!Array.isArray(backendGlobal.extensionInfo)) {
+    // Initialize to an empty array if not already set
+    backendGlobal.extensionInfo = [];
+}

package/src/node/index.ts

@@ -15,6 +15,7 @@
 // *****************************************************************************
 
 export * from './backend-application';
+export * from './backend-global';
 export * from './debug';
 export * from '../common/file-uri';
 export * from './messaging';