@tailor-platform/erp-kit 0.7.0 → 0.9.0

package/src/modules/finance-ledger/command/updateJournalEntry.ts

@@ -4,18 +4,15 @@ import {
   JournalEntryNotFoundError,
   InvalidStatusForUpdateError,
   DuplicateReferenceNumberError,
-  JournalTypeImmutableError,
 } from "../lib/errors.generated";
 
-export interface UpdateJournalEntryInput {
+export type UpdateJournalEntryInput = {
   journalEntryId: string;
-  journalType?: string;
   description?: string;
   sourceDocumentReference?: string;
   entryDate?: Date;
   referenceNumber?: string;
-}
-
+};
 /**
  * Function: updateJournalEntry
  *
@@ -43,11 +40,6 @@ export async function run(db: Transaction, input: UpdateJournalEntryInput, _ctx:
     return err(new InvalidStatusForUpdateError(journalEntryId));
   }
 
-  // 2b. Journal type cannot be changed after creation
-  if (input.journalType !== undefined && input.journalType !== existing.journalType) {
-    return err(new JournalTypeImmutableError(journalEntryId));
-  }
-
   // 3. If referenceNumber is being updated, check uniqueness within company
   if (referenceNumber !== undefined) {
     const duplicate = await db

package/src/modules/finance-ledger/command/updateJournalLine.ts

@@ -9,7 +9,7 @@ import {
   CurrencyNotFoundError,
 } from "../lib/errors.generated";
 
-export interface UpdateJournalLineInput {
+export type UpdateJournalLineInput = {
   id: string;
   accountId?: string;
   debitAmount?: number | null;
@@ -17,8 +17,7 @@ export interface UpdateJournalLineInput {
   description?: string;
   currencyCode?: string | null;
   exchangeRate?: number | null;
-}
-
+};
 export async function run(db: Transaction, input: UpdateJournalLineInput, ctx: CommandContext) {
   // 1. Fetch journal line
   const existing = await db

package/src/modules/finance-ledger/docs/commands/UpdateJournalEntry.md

@@ -2,13 +2,12 @@
 
 ## Overview
 
-updateJournalEntry modifies the header fields of an existing journal entry that is in DRAFT status. Updatable fields include description, source document reference, and other header-level attributes. Posted and reversed entries are immutable and cannot be updated. This command does not affect journal lines, which are managed via addJournalLine, updateJournalLine, and removeJournalLine.
+updateJournalEntry modifies the header fields of an existing journal entry that is in DRAFT status. Updatable fields include description, source document reference, entry date, and reference number. Posted and reversed entries are immutable and cannot be updated. This command does not affect journal lines, which are managed via addJournalLine, updateJournalLine, and removeJournalLine.
 
 ## Business Rules
 
 - Journal entry must exist and be in DRAFT status
 - Only DRAFT entries can be updated; POSTED and REVERSED entries are immutable
-- Journal type cannot be changed after the entry is created
 - Entry date can be updated while in DRAFT status
 - Description and source document reference can be updated while in DRAFT status
 - Emits an audit event recording previous and new field values, acting user, and timestamp
@@ -34,7 +33,6 @@ flowchart TD
 
 - **JOURNAL_ENTRY_NOT_FOUND**: Referenced journal entry does not exist
 - **INVALID_STATUS_FOR_UPDATE**: Journal entry is not in DRAFT status; POSTED and REVERSED entries cannot be modified
-- **JOURNAL_TYPE_IMMUTABLE**: Attempted to change the journal type after creation; journal type is immutable once created
 
 ## Test Cases
 
@@ -46,5 +44,4 @@ flowchart TD
 - updates entry date on a DRAFT journal entry
 - updates reference number on a DRAFT journal entry with uniqueness check
 - returns error when updated reference number already exists
-- returns error when attempting to change journal type
 - emits audit event recording previous and new field values and acting user

package/src/modules/finance-ledger/module.ts

@@ -129,6 +129,7 @@ export interface DefineModuleParams<
   };
 }
 
+/* @__NO_SIDE_EFFECTS__ */
 export const defineModule = <
   const FyF extends Record<string, TailorAnyDBField> = EmptyFields,
   const ApF extends Record<string, TailorAnyDBField> = EmptyFields,

package/src/modules/inventory/command/approveInventoryAdjustment.test.ts

@@ -49,7 +49,7 @@ describe("approveInventoryAdjustment", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.adjustment.status).toBe("APPROVED");
+      expect(result.value.inventoryAdjustment.status).toBe("APPROVED");
     }
     expect(spies.update).toHaveBeenCalled();
   });

package/src/modules/inventory/command/approveInventoryAdjustment.ts

@@ -46,5 +46,5 @@ export async function run(
     .returningAll()
     .executeTakeFirst();
 
-  return ok({ adjustment: updated! });
+  return ok({ inventoryAdjustment: updated! });
 }

package/src/modules/inventory/command/cancelStockMovement.test.ts

@@ -67,7 +67,7 @@ describe("cancelStockMovement", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.movement.status).toBe("CANCELLED");
+      expect(result.value.stockMovement.status).toBe("CANCELLED");
     }
     expect(spies.update).toHaveBeenCalled();
   });
@@ -82,7 +82,7 @@ describe("cancelStockMovement", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.movement.status).toBe("CANCELLED");
+      expect(result.value.stockMovement.status).toBe("CANCELLED");
     }
   });
 

package/src/modules/inventory/command/cancelStockMovement.ts

@@ -52,5 +52,5 @@ export async function run(db: Transaction, input: CancelStockMovementInput, _ctx
     .returningAll()
     .executeTakeFirst();
 
-  return ok({ movement: cancelled! });
+  return ok({ stockMovement: cancelled! });
 }

package/src/modules/inventory/command/confirmInventoryAdjustment.test.ts

@@ -81,7 +81,7 @@ describe("confirmInventoryAdjustment", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.adjustment.status).toBe("CONFIRMED");
+      expect(result.value.inventoryAdjustment.status).toBe("CONFIRMED");
     }
   });
 
@@ -104,7 +104,7 @@ describe("confirmInventoryAdjustment", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.adjustment.status).toBe("CONFIRMED");
+      expect(result.value.inventoryAdjustment.status).toBe("CONFIRMED");
     }
   });
 
@@ -133,7 +133,7 @@ describe("confirmInventoryAdjustment", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.adjustment.status).toBe("CONFIRMED");
+      expect(result.value.inventoryAdjustment.status).toBe("CONFIRMED");
     }
   });
 
@@ -163,7 +163,7 @@ describe("confirmInventoryAdjustment", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.adjustment.status).toBe("CONFIRMED");
+      expect(result.value.inventoryAdjustment.status).toBe("CONFIRMED");
     }
   });
 

package/src/modules/inventory/command/confirmInventoryAdjustment.ts

@@ -190,5 +190,5 @@ export async function run(
     .returningAll()
     .executeTakeFirst();
 
-  return ok({ adjustment: confirmed! });
+  return ok({ inventoryAdjustment: confirmed! });
 }

package/src/modules/inventory/command/confirmStockMovement.test.ts

@@ -119,7 +119,7 @@ describe("confirmStockMovement", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.movement.status).toBe("CONFIRMED");
+      expect(result.value.stockMovement.status).toBe("CONFIRMED");
     }
     expect(spies.update).toHaveBeenCalled();
   });

package/src/modules/inventory/command/confirmStockMovement.ts

@@ -127,5 +127,5 @@ export async function run(
     .returningAll()
     .executeTakeFirst();
 
-  return ok({ movement: confirmed! });
+  return ok({ stockMovement: confirmed! });
 }

package/src/modules/inventory/command/createInventoryAdjustment.test.ts

@@ -135,8 +135,8 @@ describe("createInventoryAdjustment", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.adjustment.adjustmentType).toBe("CORRECTION");
-      expect(result.value.adjustment.quantityDelta).toBe(10);
+      expect(result.value.inventoryAdjustment.adjustmentType).toBe("CORRECTION");
+      expect(result.value.inventoryAdjustment.quantityDelta).toBe(10);
     }
     expect(spies.insert).toHaveBeenCalled();
   });
@@ -162,7 +162,7 @@ describe("createInventoryAdjustment", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.adjustment.quantityDelta).toBe(-5);
+      expect(result.value.inventoryAdjustment.quantityDelta).toBe(-5);
     }
     expect(spies.insert).toHaveBeenCalled();
   });
@@ -188,8 +188,8 @@ describe("createInventoryAdjustment", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.adjustment.adjustmentType).toBe("SCRAP");
-      expect(result.value.adjustment.quantityDelta).toBe(-3);
+      expect(result.value.inventoryAdjustment.adjustmentType).toBe("SCRAP");
+      expect(result.value.inventoryAdjustment.quantityDelta).toBe(-3);
     }
     expect(spies.insert).toHaveBeenCalled();
   });
@@ -216,7 +216,7 @@ describe("createInventoryAdjustment", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.adjustment.inventoryCountId).toBe("count-1");
+      expect(result.value.inventoryAdjustment.inventoryCountId).toBe("count-1");
     }
     expect(spies.insert).toHaveBeenCalled();
   });

package/src/modules/inventory/command/createInventoryAdjustment.ts

@@ -120,5 +120,5 @@ export async function run(
     .returningAll()
     .executeTakeFirst();
 
-  return ok({ adjustment: adjustment! });
+  return ok({ inventoryAdjustment: adjustment! });
 }

package/src/modules/inventory/command/createStockMovement.test.ts

@@ -249,8 +249,8 @@ describe("createStockMovement", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.movement.status).toBe("DRAFT");
-      expect(result.value.moveLines).toHaveLength(1);
+      expect(result.value.stockMovement.status).toBe("DRAFT");
+      expect(result.value.stockMoveLines).toHaveLength(1);
     }
   });
 
@@ -335,7 +335,7 @@ describe("createStockMovement", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.moveLines).toHaveLength(2);
+      expect(result.value.stockMoveLines).toHaveLength(2);
     }
     expect(spies.insert).toHaveBeenCalledTimes(3); // 1 movement + 2 lines
   });

package/src/modules/inventory/command/createStockMovement.ts

@@ -168,5 +168,5 @@ export async function run(
     moveLines.push(moveLine!);
   }
 
-  return ok({ movement: movement!, moveLines });
+  return ok({ stockMovement: movement!, stockMoveLines: moveLines });
 }

package/src/modules/inventory/command/executeStockMovement.test.ts

@@ -186,7 +186,7 @@ describe("executeStockMovement", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.movement.status).toBe("DONE");
+      expect(result.value.stockMovement.status).toBe("DONE");
     }
     expect(spies.update).toHaveBeenCalled();
   });
@@ -217,7 +217,7 @@ describe("executeStockMovement", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.movement.status).toBe("DONE");
+      expect(result.value.stockMovement.status).toBe("DONE");
     }
   });
 
@@ -256,7 +256,7 @@ describe("executeStockMovement", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.movement.status).toBe("DONE");
+      expect(result.value.stockMovement.status).toBe("DONE");
     }
   });
 
@@ -290,7 +290,7 @@ describe("executeStockMovement", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.movement.status).toBe("DONE");
+      expect(result.value.stockMovement.status).toBe("DONE");
     }
   });
 
@@ -324,7 +324,7 @@ describe("executeStockMovement", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.movement.status).toBe("DONE");
+      expect(result.value.stockMovement.status).toBe("DONE");
     }
   });
 

package/src/modules/inventory/command/executeStockMovement.ts

@@ -207,7 +207,7 @@ export async function run(db: Transaction, input: ExecuteStockMovementInput, _ct
     .returningAll()
     .executeTakeFirst();
 
-  return ok({ movement: executed! });
+  return ok({ stockMovement: executed! });
 }
 
 // Helper: get stock level for item at location

package/src/modules/inventory/command/rejectInventoryAdjustment.test.ts

@@ -49,7 +49,7 @@ describe("rejectInventoryAdjustment", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.adjustment.status).toBe("REJECTED");
+      expect(result.value.inventoryAdjustment.status).toBe("REJECTED");
     }
     expect(spies.update).toHaveBeenCalled();
   });

package/src/modules/inventory/command/rejectInventoryAdjustment.ts

@@ -46,5 +46,5 @@ export async function run(
     .returningAll()
     .executeTakeFirst();
 
-  return ok({ adjustment: updated! });
+  return ok({ inventoryAdjustment: updated! });
 }

package/src/modules/inventory/command/reviseInventoryAdjustment.test.ts

@@ -46,7 +46,7 @@ describe("reviseInventoryAdjustment", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.adjustment.status).toBe("DRAFT");
+      expect(result.value.inventoryAdjustment.status).toBe("DRAFT");
     }
     expect(spies.update).toHaveBeenCalled();
   });
@@ -62,7 +62,7 @@ describe("reviseInventoryAdjustment", () => {
     expect(result.ok).toBe(true);
     if (result.ok) {
       // After revise, adjustment is back in DRAFT and can be modified/resubmitted
-      expect(result.value.adjustment.status).toBe("DRAFT");
+      expect(result.value.inventoryAdjustment.status).toBe("DRAFT");
     }
   });
 });

package/src/modules/inventory/command/reviseInventoryAdjustment.ts

@@ -44,5 +44,5 @@ export async function run(
     .returningAll()
     .executeTakeFirst();
 
-  return ok({ adjustment: updated! });
+  return ok({ inventoryAdjustment: updated! });
 }

package/src/modules/inventory/command/submitInventoryAdjustment.test.ts

@@ -46,7 +46,7 @@ describe("submitInventoryAdjustment", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.adjustment.status).toBe("PENDING_APPROVAL");
+      expect(result.value.inventoryAdjustment.status).toBe("PENDING_APPROVAL");
     }
     expect(spies.update).toHaveBeenCalled();
   });

package/src/modules/inventory/command/submitInventoryAdjustment.ts

@@ -43,5 +43,5 @@ export async function run(
     .returningAll()
     .executeTakeFirst();
 
-  return ok({ adjustment: updated! });
+  return ok({ inventoryAdjustment: updated! });
 }

package/src/modules/inventory/command/updateLot.test.ts

@@ -61,7 +61,7 @@ describe("updateLot", () => {
     }
   });
 
-  it("lot number cannot be changed", async () => {
+  it("lot number is not part of the update input", async () => {
     const { db, spies } = createMockDb<Transaction>();
     const updatedLot = { ...baseActiveLot }; // lotNumber remains the same
     spies.select.mockReturnValueOnce(baseActiveLot); // existing lot

package/src/modules/inventory/command/updateLot.ts

@@ -2,13 +2,12 @@ import type { Transaction } from "../generated/kysely-tailordb";
 import { LotNotFoundError, LotFullyConsumedError } from "../lib/errors.generated";
 import { ok, err, type CommandContext } from "@tailor-platform/erp-kit/module";
 
-export interface UpdateLotInput {
+export type UpdateLotInput = {
   id: string;
   manufactureDate?: Date | null;
   expirationDate?: Date | null;
   supplierLotReference?: string | null;
-}
-
+};
 /**
  * Function: updateLot
  *

package/src/modules/inventory/command/updateStockMovement.test.ts

@@ -71,7 +71,7 @@ describe("updateStockMovement", () => {
 
     expect(result.ok).toBe(true);
     if (result.ok) {
-      expect(result.value.movement.reasonCode).toBe("new-reason");
+      expect(result.value.stockMovement.reasonCode).toBe("new-reason");
     }
     expect(spies.update).toHaveBeenCalled();
   });
@@ -215,9 +215,9 @@ describe("updateStockMovement", () => {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any
       const value = result.value as any;
       // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-      expect(value.moveLines).toHaveLength(1);
+      expect(value.stockMoveLines).toHaveLength(1);
       // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-      expect(value.moveLines![0].quantity).toBe(30);
+      expect(value.stockMoveLines![0].quantity).toBe(30);
     }
   });
 
@@ -244,7 +244,7 @@ describe("updateStockMovement", () => {
       // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment, @typescript-eslint/no-explicit-any
       const value = result.value as any;
       // eslint-disable-next-line @typescript-eslint/no-unsafe-member-access
-      expect(value.moveLines).toHaveLength(0);
+      expect(value.stockMoveLines).toHaveLength(0);
     }
   });
 });

package/src/modules/inventory/command/updateStockMovement.ts

@@ -20,11 +20,11 @@ export interface UpdateMoveLineInput {
   serialNumberId?: string | null;
 }
 
-export interface UpdateStockMovementInput {
+export type UpdateStockMovementInput = {
   id: string;
   reasonCode?: string | null;
   lines?: UpdateMoveLineInput[];
-}
+};
 
 export interface ItemManagementQueries {
   getItem: (
@@ -36,7 +36,6 @@ export interface ItemManagementQueries {
     value: { item: { id: string; status: string; isLotTracked?: boolean } | null };
   }>;
 }
-
 /**
  * Function: updateStockMovement
  *
@@ -157,8 +156,8 @@ export async function run(
       newLines.push(moveLine!);
     }
 
-    return ok({ movement: updatedMovement!, moveLines: newLines });
+    return ok({ stockMovement: updatedMovement!, stockMoveLines: newLines });
   }
 
-  return ok({ movement: updatedMovement! });
+  return ok({ stockMovement: updatedMovement! });
 }

package/src/modules/inventory/command/updateStorageLocation.ts

@@ -2,19 +2,17 @@ import type { Transaction } from "../generated/kysely-tailordb";
 import { StorageLocationNotFoundError, DuplicateLocationNameError } from "../lib/errors.generated";
 import { ok, err, type CommandContext } from "@tailor-platform/erp-kit/module";
 
-export interface UpdateStorageLocationInput {
+export type UpdateStorageLocationInput = {
   id: string;
   name?: string;
-  code?: string;
   storageCondition?: string | null;
   capacity?: number | null;
-}
-
+};
 /**
  * Function: updateStorageLocation
  *
- * Modifies the mutable fields of a storage location, including name, code,
- * storageCondition, and capacity. warehouseId, parentId, and locationType
+ * Modifies the mutable fields of a storage location, including name,
+ * storageCondition, and capacity. warehouseId, parentId, locationType, and code
  * are immutable after creation.
  */
 export async function run(
@@ -22,34 +20,32 @@ export async function run(
   input: UpdateStorageLocationInput,
   _ctx: CommandContext,
 ) {
-  const { id, name, code, storageCondition, capacity } = input;
+  const { name, storageCondition, capacity } = input;
 
   // 1. Check storage location exists
   const location = await db
     .selectFrom("StorageLocation")
     .selectAll()
-    .where("id", "=", id)
+    .where("id", "=", input.id)
     .forUpdate()
     .executeTakeFirst();
 
   if (!location) {
-    return err(new StorageLocationNotFoundError(id));
+    return err(new StorageLocationNotFoundError(input.id));
   }
 
-  // 2. If name or code changed, check uniqueness within warehouse
+  // 2. If name changed, check uniqueness within warehouse
   const nameChanged = name !== undefined && name !== location.name;
-  const codeChanged = code !== undefined && code !== location.code;
 
-  if (nameChanged || codeChanged) {
+  if (nameChanged) {
     const checkName = name ?? location.name;
-    const checkCode = code ?? location.code;
 
     const duplicate = await db
       .selectFrom("StorageLocation")
       .selectAll()
       .where("warehouseId", "=", location.warehouseId)
-      .where("id", "!=", id)
-      .where((eb) => eb.or([eb("name", "=", checkName), eb("code", "=", checkCode)]))
+      .where("id", "!=", location.id)
+      .where("name", "=", checkName)
       .forUpdate()
       .executeTakeFirst();
 
@@ -61,7 +57,6 @@ export async function run(
   // 3. Build update set
   const updates: Record<string, unknown> = { updatedAt: new Date() };
   if (name !== undefined) updates.name = name;
-  if (code !== undefined) updates.code = code;
   if (storageCondition !== undefined) updates.storageCondition = storageCondition;
   if (capacity !== undefined) updates.capacity = capacity;
 
@@ -69,7 +64,7 @@ export async function run(
   const updatedLocation = await db
     .updateTable("StorageLocation")
     .set(updates)
-    .where("id", "=", id)
+    .where("id", "=", location.id)
     .returningAll()
     .executeTakeFirstOrThrow();
 

package/src/modules/inventory/command/updateValuationPolicy.ts

@@ -5,13 +5,12 @@ import {
 } from "../lib/errors.generated";
 import { ok, err, type CommandContext } from "@tailor-platform/erp-kit/module";
 
-export interface UpdateValuationPolicyInput {
+export type UpdateValuationPolicyInput = {
   id: string;
   name?: string;
   costingMethod?: string;
   standardCostRate?: number | null;
-}
-
+};
 /**
  * Function: updateValuationPolicy
  *

package/src/modules/inventory/command/updateWarehouse.ts

@@ -2,13 +2,12 @@ import type { Transaction } from "../generated/kysely-tailordb";
 import { WarehouseNotFoundError, DuplicateWarehouseNameError } from "../lib/errors.generated";
 import { ok, err, type CommandContext } from "@tailor-platform/erp-kit/module";
 
-export interface UpdateWarehouseInput {
+export type UpdateWarehouseInput = {
   id: string;
   name?: string;
   storageCondition?: string | null;
   capacity?: number | null;
-}
-
+};
 /**
  * Function: updateWarehouse
  *

package/src/modules/inventory/docs/commands/UpdateLot.md

@@ -2,13 +2,13 @@
 
 ## Overview
 
-updateLot modifies the mutable fields of a lot record, including manufactureDate, expirationDate, and supplierLotReference. The lotNumber is immutable after creation and cannot be changed.
+updateLot modifies the mutable fields of a lot record, including manufactureDate, expirationDate, and supplierLotReference. `lotNumber` is fixed by the existing record and is not part of the update input.
 
 ## Business Rules
 
 - Lot must exist
 - Lot must not be in FULLY_CONSUMED status
-- lotNumber is immutable after creation
+- lotNumber is not part of the update input
 - Can update manufactureDate, expirationDate, and supplierLotReference
 
 ## Process Flow
@@ -38,4 +38,4 @@ flowchart TD
 - returns error when lot is FULLY_CONSUMED
 - updates expiration date
 - updates supplier lot reference
-- lot number cannot be changed
+- lot number is not part of the update input