@tailor-platform/erp-kit 0.7.0 → 0.9.0

package/src/modules/business-partner/command/updateContactPerson.ts

@@ -8,7 +8,7 @@ import {
 } from "../lib/errors.generated";
 import { ok, err } from "@tailor-platform/erp-kit/module";
 
-export interface UpdateContactPersonInput {
+export type UpdateContactPersonInput = {
   id: string;
   firstName?: string;
   lastName?: string;
@@ -16,8 +16,7 @@ export interface UpdateContactPersonInput {
   phone?: string | null;
   jobTitle?: string | null;
   department?: string | null;
-}
-
+};
 /**
  * Function: updateContactPerson
  *
@@ -27,7 +26,7 @@ export interface UpdateContactPersonInput {
  */
 export async function run<CF extends Record<string, unknown>>(
   db: Transaction,
-  input: UpdateContactPersonInput & CF,
+  input: UpdateContactPersonInput & Omit<Partial<CF>, "status">,
 ) {
   const { id, firstName, lastName, email, phone, jobTitle, department, ...customFields } = input;
 

package/src/modules/business-partner/command/updatePartner.ts

@@ -10,12 +10,11 @@ import { ok, err, type CommandContext } from "@tailor-platform/erp-kit/module";
 type PrimitivesModule = ReturnType<typeof definePrimitivesModule>;
 type PrimitivesQueries = PrimitivesModule["queries"];
 
-export interface UpdatePartnerInput {
+export type UpdatePartnerInput = {
   id: string;
   name?: string;
   preferredCurrencyId?: string;
-}
-
+};
 /**
  * Function: updatePartner
  *
@@ -24,11 +23,19 @@ export interface UpdatePartnerInput {
  */
 export async function run<CF extends Record<string, unknown>>(
   db: Transaction,
-  input: UpdatePartnerInput & Partial<CF>,
+  input: UpdatePartnerInput & Omit<Partial<CF>, "status">,
   ctx: CommandContext,
   primitivesQueries?: Pick<PrimitivesQueries, "getCurrency">,
 ) {
-  const { id, name, preferredCurrencyId, ...customFields } = input;
+  const { id, name, preferredCurrencyId } = input;
+
+  const KNOWN_KEYS = new Set(["id", "name", "preferredCurrencyId"]);
+  const customFields: Record<string, unknown> = {};
+  for (const [key, value] of Object.entries(input as Record<string, unknown>)) {
+    if (!KNOWN_KEYS.has(key)) {
+      customFields[key] = value;
+    }
+  }
 
   // 1. Check partner exists
   const partner = await db
@@ -59,7 +66,7 @@ export async function run<CF extends Record<string, unknown>>(
 
   // 4. Apply updates
   const updates: Record<string, unknown> = {
-    ...(customFields as Record<string, unknown>),
+    ...customFields,
     updatedAt: new Date(),
   };
   if (name !== undefined) updates.name = name;

package/src/modules/business-partner/command/updatePartnerAddress.ts

@@ -2,7 +2,7 @@ import type { Transaction } from "../generated/kysely-tailordb";
 import { AddressNotFoundError, InvalidCountryCodeError } from "../lib/errors.generated";
 import { ok, err } from "@tailor-platform/erp-kit/module";
 
-export interface UpdatePartnerAddressInput {
+export type UpdatePartnerAddressInput = {
   id: string;
   line1?: string;
   line2?: string | null;
@@ -10,8 +10,7 @@ export interface UpdatePartnerAddressInput {
   state?: string | null;
   postalCode?: string;
   country?: string;
-}
-
+};
 /**
  * Function: updatePartnerAddress
  *
@@ -20,9 +19,17 @@ export interface UpdatePartnerAddressInput {
  */
 export async function run<CF extends Record<string, unknown>>(
   db: Transaction,
-  input: UpdatePartnerAddressInput & Partial<CF>,
+  input: UpdatePartnerAddressInput & Omit<Partial<CF>, "status">,
 ) {
-  const { id, line1, line2, city, state, postalCode, country, ...customFields } = input;
+  const { id, line1, line2, city, state, postalCode, country } = input;
+
+  const KNOWN_KEYS = new Set(["id", "line1", "line2", "city", "state", "postalCode", "country"]);
+  const customFields: Record<string, unknown> = {};
+  for (const [key, value] of Object.entries(input as Record<string, unknown>)) {
+    if (!KNOWN_KEYS.has(key)) {
+      customFields[key] = value;
+    }
+  }
 
   // 1. Check address exists
   const address = await db
@@ -43,7 +50,7 @@ export async function run<CF extends Record<string, unknown>>(
 
   // 3. Apply updates
   const updates: Record<string, unknown> = {
-    ...(customFields as Record<string, unknown>),
+    ...customFields,
     updatedAt: new Date(),
   };
   if (line1 !== undefined) updates.line1 = line1;

package/src/modules/business-partner/command/updatePartnerBankAccount.ts

@@ -12,7 +12,7 @@ import { ok, err, type CommandContext } from "@tailor-platform/erp-kit/module";
 type PrimitivesModule = ReturnType<typeof definePrimitivesModule>;
 type PrimitivesQueries = PrimitivesModule["queries"];
 
-export interface UpdatePartnerBankAccountInput {
+export type UpdatePartnerBankAccountInput = {
   id: string;
   bankName?: string;
   accountHolderName?: string;
@@ -21,8 +21,7 @@ export interface UpdatePartnerBankAccountInput {
   iban?: string;
   swiftBic?: string | null;
   currencyId?: string;
-}
-
+};
 /**
  * Function: updatePartnerBankAccount
  *
@@ -31,7 +30,7 @@ export interface UpdatePartnerBankAccountInput {
  */
 export async function run<CF extends Record<string, unknown>>(
   db: Transaction,
-  input: UpdatePartnerBankAccountInput & CF,
+  input: UpdatePartnerBankAccountInput & Omit<Partial<CF>, "status">,
   ctx: CommandContext,
   primitivesQueries?: Pick<PrimitivesQueries, "getCurrency">,
 ) {

package/src/modules/business-partner/command/updatePartnerIdentification.ts

@@ -7,14 +7,13 @@ import {
 } from "../lib/errors.generated";
 import { ok, err, type CommandContext } from "@tailor-platform/erp-kit/module";
 
-export interface UpdatePartnerIdentificationInput {
+export type UpdatePartnerIdentificationInput = {
   id: string;
   value?: string;
   issuingCountry?: string;
   validFrom?: Date;
   validTo?: Date;
-}
-
+};
 /**
  * Function: updatePartnerIdentification
  *
@@ -24,7 +23,7 @@ export interface UpdatePartnerIdentificationInput {
  */
 export async function run<CF extends Record<string, unknown>>(
   db: Transaction,
-  input: UpdatePartnerIdentificationInput & CF,
+  input: UpdatePartnerIdentificationInput & Omit<Partial<CF>, "status">,
   _ctx: CommandContext,
 ) {
   const { id, value, issuingCountry, validFrom, validTo, ...customFields } = input;

package/src/modules/business-partner/docs/commands/UpdateContactPerson.md

@@ -2,7 +2,7 @@
 
 ## Overview
 
-updateContactPerson modifies the details of an existing contact person. All fields are optional, but validation rules are enforced for any provided values. The contact person's association with its organization partner cannot be changed. After the update, at least one communication channel (email or phone) must remain present.
+updateContactPerson modifies the details of an existing contact person. All fields are optional, but validation rules are enforced for any provided values. The contact person's organization association is fixed by the existing record and is not part of the update input. After the update, at least one communication channel (email or phone) must remain present.
 
 ## Business Rules
 
@@ -11,8 +11,8 @@ updateContactPerson modifies the details of an existing contact person. All fiel
 - Last name, if provided, must be non-empty and not whitespace-only
 - Email, if provided, must be in a valid format
 - After update, at least one of email or phone must still be present (whitespace-only values do not count)
-- The organization association is immutable and cannot be changed
-- The primary contact designation (isPrimary) is not modifiable through this command; it is preserved as-is
+- The organization association is not part of the update input
+- The primary contact designation (`isPrimary`) is not part of the update input; the existing value is preserved as-is
 - Only provided fields are updated; omitted fields retain their current values
 
 ## Process Flow

package/src/modules/business-partner/docs/commands/UpdatePartner.md

@@ -2,14 +2,14 @@
 
 ## Overview
 
-updatePartner modifies the mutable fields of an existing business partner. Only name and preferred currency can be updated. The partner type remains immutable after creation. This command supports incremental enrichment of partner data throughout the partner lifecycle.
+updatePartner modifies the mutable fields of an existing business partner. Only name and preferred currency can be updated. Partner type is fixed by the existing record and is not part of the update input. This command supports incremental enrichment of partner data throughout the partner lifecycle.
 
 ## Business Rules
 
 - Partner must exist in the system
 - Name, if provided, must be non-empty
 - Preferred currency, if provided, must reference an existing Currency in the primitives module
-- Partner type cannot be changed via this command
+- Partner type is not part of the update input
 
 ## Process Flow
 

package/src/modules/business-partner/docs/commands/UpdatePartnerAddress.md

@@ -2,13 +2,13 @@
 
 ## Overview
 
-updatePartnerAddress modifies the fields of an existing partner address. The address type is immutable and cannot be changed after creation. All other address fields (line1, line2, city, state, postalCode, country) can be updated individually. Country validation is enforced when a new country value is provided. Updates are permitted regardless of the parent partner's lifecycle status (DRAFT, ACTIVE, or INACTIVE) — existing addresses always remain updatable.
+updatePartnerAddress modifies the fields of an existing partner address. Address type is fixed by the existing record and is not part of the update input. All other address fields (line1, line2, city, state, postalCode, country) can be updated individually. Country validation is enforced when a new country value is provided. Updates are permitted regardless of the parent partner's lifecycle status (DRAFT, ACTIVE, or INACTIVE) — existing addresses always remain updatable.
 
 ## Business Rules
 
 - Address must exist in the system
 - Parent partner's lifecycle status is not checked — updates are permitted in any state (DRAFT, ACTIVE, or INACTIVE)
-- Address type is immutable — it cannot be changed after creation
+- Address type is not part of the update input
 - Country, if provided, must be a valid ISO 3166-1 alpha-2 code
 - Only provided fields are updated; omitted fields retain their current values
 

package/src/modules/business-partner/docs/commands/UpdatePartnerIdentification.md

@@ -2,12 +2,12 @@
 
 ## Overview
 
-updatePartnerIdentification modifies the fields of an existing partner identification. The identification type is immutable and cannot be changed after creation. When the value is updated, uniqueness is re-validated against the company scope to prevent duplicate registrations.
+updatePartnerIdentification modifies the fields of an existing partner identification. Identification type is fixed by the existing record and is not part of the update input. When the value is updated, uniqueness is re-validated against the company scope to prevent duplicate registrations.
 
 ## Business Rules
 
 - Identification must exist in the system
-- Type is immutable — it cannot be changed after creation
+- Type is not part of the update input
 - If value is provided, it must be non-empty and not whitespace-only
 - If value is changed, the new (type, value) combination must be unique within the company scope
 - When both validFrom and validTo are set, validTo must be greater than or equal to validFrom

package/src/modules/business-partner/module.ts

@@ -92,6 +92,7 @@ export interface DefineModuleParams<
   };
 }
 
+/* @__NO_SIDE_EFFECTS__ */
 export const defineModule = <
   const BPF extends Record<string, TailorAnyDBField> = EmptyFields,
   const PRF extends Record<string, TailorAnyDBField> = EmptyFields,

package/src/modules/coa-management/command/activateAccount.test.ts

@@ -107,19 +107,4 @@ describe("activateAccount", () => {
       expect(result.value.account.status).toBe("ACTIVE");
     }
   });
-
-  it("emits audit event recording status transition from DRAFT to ACTIVE", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    const activated = { ...baseDraftAccount, status: "ACTIVE" };
-    spies.select.mockReturnValueOnce(baseDraftAccount).mockReturnValueOnce(baseActiveCoa);
-    spies.update.mockReturnValue(activated);
-
-    const result = await run(db, { id: baseDraftAccount.id }, ctx);
-
-    // Audit event is emitted as part of successful activation
-    expect(result.ok).toBe(true);
-    if (result.ok) {
-      expect(result.value.account.status).toBe("ACTIVE");
-    }
-  });
 });

package/src/modules/coa-management/command/activateAccount.ts

@@ -1,4 +1,3 @@
-import { randomUUID } from "node:crypto";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
   AccountNotFoundError,
@@ -12,35 +11,13 @@ export interface ActivateAccountInput {
   from?: string[];
 }
 
-export interface AuditCommands {
-  logAuditEvent: (
-    db: Transaction,
-    input: {
-      eventId: string;
-      actorType: string;
-      actorId: string;
-      entityType: string;
-      entityId: string;
-      operationType: string;
-      companyId?: string;
-      changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[];
-    },
-    ctx: CommandContext,
-  ) => Promise<{ ok: true; value: unknown }>;
-}
-
 /**
  * Function: activateAccount
  *
  * Transitions a GL account from DRAFT to ACTIVE status, making it eligible
  * to receive journal postings from downstream modules.
  */
-export async function run(
-  db: Transaction,
-  input: ActivateAccountInput,
-  ctx: CommandContext,
-  auditCommands?: AuditCommands,
-) {
+export async function run(db: Transaction, input: ActivateAccountInput, _ctx: CommandContext) {
   const { id, from = ["DRAFT"] } = input;
 
   // 1. Find account with forUpdate
@@ -83,23 +60,5 @@ export async function run(
     .returningAll()
     .executeTakeFirst();
 
-  // 6. Emit audit event
-  if (auditCommands) {
-    await auditCommands.logAuditEvent(
-      db,
-      {
-        eventId: randomUUID(),
-        actorType: "USER",
-        actorId: ctx.actorId,
-        entityType: "Account",
-        entityId: id,
-        operationType: "UPDATE",
-        companyId: coa.companyId,
-        changes: [{ fieldName: "status", oldValue: account.status, newValue: "ACTIVE" }],
-      },
-      ctx,
-    );
-  }
-
   return ok({ account: updated! });
 }

package/src/modules/coa-management/command/activateChartOfAccounts.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it, vi } from "vitest";
+import { describe, expect, it } from "vitest";
 import { createMockDb } from "../../../testing/index";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
@@ -7,7 +7,7 @@ import {
   DuplicateActiveChartOfAccountsError,
 } from "../lib/errors.generated";
 import { baseDraftCoa, baseActiveCoa, baseArchivedCoa } from "../testing/fixtures";
-import { run, type AuditCommands } from "./activateChartOfAccounts";
+import { run } from "./activateChartOfAccounts";
 import type { CommandContext } from "@tailor-platform/erp-kit/module";
 
 const ctx: CommandContext = {
@@ -81,33 +81,4 @@ describe("activateChartOfAccounts", () => {
       expect(result.value.chartOfAccounts.status).toBe("ACTIVE");
     }
   });
-
-  it("emits audit event recording status transition from DRAFT to ACTIVE", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    const activatedCoa = { ...baseDraftCoa, status: "ACTIVE" };
-    spies.select
-      .mockReturnValueOnce(baseDraftCoa) // CoA lookup
-      .mockReturnValueOnce(undefined); // no existing ACTIVE CoA
-    spies.update.mockReturnValue(activatedCoa);
-
-    const mockLogAuditEvent = vi.fn().mockResolvedValue({ ok: true, value: {} });
-    const auditCommands: AuditCommands = { logAuditEvent: mockLogAuditEvent };
-
-    const result = await run(db, { id: baseDraftCoa.id }, ctx, auditCommands);
-
-    expect(result.ok).toBe(true);
-    expect(mockLogAuditEvent).toHaveBeenCalledWith(
-      db,
-      expect.objectContaining({
-        entityType: "ChartOfAccounts",
-        entityId: baseDraftCoa.id,
-        operationType: "UPDATE",
-        companyId: baseDraftCoa.companyId,
-        actorType: "USER",
-        actorId: ctx.actorId,
-        changes: [{ fieldName: "status", oldValue: "DRAFT", newValue: "ACTIVE" }],
-      }),
-      ctx,
-    );
-  });
 });

package/src/modules/coa-management/command/activateChartOfAccounts.ts

@@ -1,4 +1,3 @@
-import { randomUUID } from "node:crypto";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
   ChartOfAccountsNotFoundError,
@@ -12,23 +11,6 @@ export interface ActivateChartOfAccountsInput {
   from?: string[];
 }
 
-export interface AuditCommands {
-  logAuditEvent: (
-    db: Transaction,
-    input: {
-      eventId: string;
-      actorType: string;
-      actorId: string;
-      entityType: string;
-      entityId: string;
-      operationType: string;
-      companyId?: string;
-      changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[];
-    },
-    ctx: CommandContext,
-  ) => Promise<{ ok: true; value: unknown }>;
-}
-
 /**
  * Function: activateChartOfAccounts
  *
@@ -38,8 +20,7 @@ export interface AuditCommands {
 export async function run(
   db: Transaction,
   input: ActivateChartOfAccountsInput,
-  ctx: CommandContext,
-  auditCommands?: AuditCommands,
+  _ctx: CommandContext,
 ) {
   const { id, from = ["DRAFT"] } = input;
 
@@ -83,22 +64,5 @@ export async function run(
     .returningAll()
     .executeTakeFirst();
 
-  if (auditCommands) {
-    await auditCommands.logAuditEvent(
-      db,
-      {
-        eventId: randomUUID(),
-        actorType: "USER",
-        actorId: ctx.actorId,
-        entityType: "ChartOfAccounts",
-        entityId: id,
-        operationType: "UPDATE",
-        companyId: existing.companyId,
-        changes: [{ fieldName: "status", oldValue: existing.status, newValue: "ACTIVE" }],
-      },
-      ctx,
-    );
-  }
-
   return ok({ chartOfAccounts: chartOfAccounts! });
 }

package/src/modules/coa-management/command/createAccount.test.ts

@@ -710,34 +710,6 @@ describe("createAccount", () => {
     }
   });
 
-  it("emits audit event recording acting user, timestamp, CoA reference, account code, and classification", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    const created = {
-      ...baseDraftAccount,
-      code: "1500",
-      name: "Audit Account",
-    };
-    spies.select.mockReturnValueOnce(baseActiveCoa).mockReturnValueOnce(undefined);
-    spies.insert.mockReturnValue(created);
-
-    const result = await run(
-      db,
-      {
-        chartOfAccountsId: baseActiveCoa.id,
-        code: "1500",
-        name: "Audit Account",
-        accountType: "ASSET",
-      },
-      ctx,
-    );
-
-    // Audit event is emitted as part of successful creation
-    expect(result.ok).toBe(true);
-    if (result.ok) {
-      expect(result.value.account).toBeDefined();
-    }
-  });
-
   it("passes custom fields through to insert", async () => {
     const { db, spies } = createMockDb<Transaction>();
     const created = {

package/src/modules/coa-management/command/createAccount.ts

@@ -1,4 +1,3 @@
-import { randomUUID } from "node:crypto";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
   ChartOfAccountsNotFoundError,
@@ -34,23 +33,6 @@ export interface CreateAccountInput {
   accountGroupId?: string;
 }
 
-export interface AuditCommands {
-  logAuditEvent: (
-    db: Transaction,
-    input: {
-      eventId: string;
-      actorType: string;
-      actorId: string;
-      entityType: string;
-      entityId: string;
-      operationType: string;
-      companyId?: string;
-      changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[];
-    },
-    ctx: CommandContext,
-  ) => Promise<{ ok: true; value: unknown }>;
-}
-
 interface GetCurrencyDep {
   getCurrency: (
     db: Transaction,
@@ -81,7 +63,6 @@ export async function run<CF extends Record<string, unknown>>(
   input: CreateAccountInput & CF,
   ctx: CommandContext,
   deps?: GetCurrencyDep,
-  auditCommands?: AuditCommands,
 ) {
   const {
     chartOfAccountsId,
@@ -219,29 +200,5 @@ export async function run<CF extends Record<string, unknown>>(
     .returningAll()
     .executeTakeFirst();
 
-  // 11. Emit audit event
-  if (auditCommands) {
-    await auditCommands.logAuditEvent(
-      db,
-      {
-        eventId: randomUUID(),
-        actorType: "USER",
-        actorId: ctx.actorId,
-        entityType: "Account",
-        entityId: account!.id,
-        operationType: "CREATE",
-        companyId: coa.companyId,
-        changes: [
-          { fieldName: "code", newValue: code },
-          { fieldName: "name", newValue: name },
-          { fieldName: "accountType", newValue: accountType },
-          { fieldName: "classification", newValue: classification },
-          { fieldName: "reconciliation", newValue: reconciliation },
-        ],
-      },
-      ctx,
-    );
-  }
-
   return ok({ account: account! });
 }

package/src/modules/coa-management/command/createAccountGroup.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it, vi } from "vitest";
+import { describe, expect, it } from "vitest";
 import { createMockDb } from "../../../testing/index";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
@@ -11,7 +11,7 @@ import {
   InvalidNumberRangeError,
 } from "../lib/errors.generated";
 import { baseActiveCoa, baseArchivedCoa, baseRootGroup, baseChildGroup } from "../testing/fixtures";
-import { run, type AuditCommands } from "./createAccountGroup";
+import { run } from "./createAccountGroup";
 import type { CommandContext } from "@tailor-platform/erp-kit/module";
 
 const ctx: CommandContext = {
@@ -414,55 +414,6 @@ describe("createAccountGroup", () => {
     }
   });
 
-  it("emits audit event recording acting user, timestamp, CoA reference, group code, and initial field values", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    const createdGroup = {
-      ...baseRootGroup,
-      id: "new-group-id",
-      code: "4000",
-      name: "Expenses",
-      createdAt: new Date(),
-    };
-    spies.select
-      .mockReturnValueOnce(baseActiveCoa) // CoA lookup
-      .mockReturnValueOnce(undefined); // No duplicate code
-    spies.insert.mockReturnValue(createdGroup);
-
-    const mockLogAuditEvent = vi.fn().mockResolvedValue({ ok: true, value: {} });
-    const auditCommands: AuditCommands = { logAuditEvent: mockLogAuditEvent };
-
-    const result = await run(
-      db,
-      {
-        chartOfAccountsId: baseActiveCoa.id,
-        code: "4000",
-        name: "Expenses",
-      },
-      ctx,
-      auditCommands,
-    );
-
-    expect(result.ok).toBe(true);
-    expect(mockLogAuditEvent).toHaveBeenCalledWith(
-      db,
-      expect.objectContaining({
-        entityType: "AccountGroup",
-        entityId: "new-group-id",
-        operationType: "CREATE",
-        companyId: baseActiveCoa.companyId,
-        actorType: "USER",
-        actorId: ctx.actorId,
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-        changes: expect.arrayContaining([
-          { fieldName: "chartOfAccountsId", newValue: baseActiveCoa.id },
-          { fieldName: "code", newValue: "4000" },
-          { fieldName: "name", newValue: "Expenses" },
-        ]),
-      }),
-      ctx,
-    );
-  });
-
   it("passes custom fields through to insert", async () => {
     const { db, spies } = createMockDb<Transaction>();
     const createdGroup = {