@tailor-platform/erp-kit 0.7.0 → 0.9.0

package/src/modules/coa-management/command/updateChartOfAccounts.test.ts

@@ -1,4 +1,4 @@
-import { describe, expect, it, vi } from "vitest";
+import { describe, expect, it } from "vitest";
 import { createMockDb } from "../../../testing/index";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
@@ -7,7 +7,7 @@ import {
   NameRequiredError,
 } from "../lib/errors.generated";
 import { baseDraftCoa, baseActiveCoa, baseArchivedCoa } from "../testing/fixtures";
-import { run, type AuditCommands } from "./updateChartOfAccounts";
+import { run } from "./updateChartOfAccounts";
 import type { CommandContext } from "@tailor-platform/erp-kit/module";
 
 const ctx: CommandContext = {
@@ -112,35 +112,6 @@ describe("updateChartOfAccounts", () => {
     const setData = spies.set.mock.calls[0][0] as Record<string, unknown>;
     expect(setData.customField).toBe("custom-value");
   });
-  it("emits audit event recording previous and new field values", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    const updatedCoa = { ...baseDraftCoa, name: "Updated Name" };
-    spies.select.mockReturnValueOnce(baseDraftCoa);
-    spies.update.mockReturnValue(updatedCoa);
-
-    const mockLogAuditEvent = vi.fn().mockResolvedValue({ ok: true, value: {} });
-    const auditCommands: AuditCommands = { logAuditEvent: mockLogAuditEvent };
-
-    const result = await run(db, { id: baseDraftCoa.id, name: "Updated Name" }, ctx, auditCommands);
-
-    expect(result.ok).toBe(true);
-    expect(mockLogAuditEvent).toHaveBeenCalledWith(
-      db,
-      expect.objectContaining({
-        entityType: "ChartOfAccounts",
-        entityId: baseDraftCoa.id,
-        operationType: "UPDATE",
-        companyId: baseDraftCoa.companyId,
-        actorType: "USER",
-        actorId: ctx.actorId,
-        // eslint-disable-next-line @typescript-eslint/no-unsafe-assignment
-        changes: expect.arrayContaining([
-          { fieldName: "name", oldValue: baseDraftCoa.name, newValue: "Updated Name" },
-        ]),
-      }),
-      ctx,
-    );
-  });
 });
 
 // Helper type for custom fields test

package/src/modules/coa-management/command/updateChartOfAccounts.ts

@@ -1,4 +1,3 @@
-import { randomUUID } from "node:crypto";
 import type { Transaction } from "../generated/kysely-tailordb";
 import {
   ChartOfAccountsNotFoundError,
@@ -7,28 +6,11 @@ import {
 } from "../lib/errors.generated";
 import { ok, err, type CommandContext } from "@tailor-platform/erp-kit/module";
 
-export interface UpdateChartOfAccountsInput {
+export type UpdateChartOfAccountsInput = {
   id: string;
   name?: string;
   description?: string | null;
-}
-
-export interface AuditCommands {
-  logAuditEvent: (
-    db: Transaction,
-    input: {
-      eventId: string;
-      actorType: string;
-      actorId: string;
-      entityType: string;
-      entityId: string;
-      operationType: string;
-      companyId?: string;
-      changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[];
-    },
-    ctx: CommandContext,
-  ) => Promise<{ ok: true; value: unknown }>;
-}
+};
 
 /**
  * Function: updateChartOfAccounts
@@ -38,9 +20,8 @@ export interface AuditCommands {
  */
 export async function run<CF extends Record<string, unknown>>(
   db: Transaction,
-  input: UpdateChartOfAccountsInput & CF,
-  ctx: CommandContext,
-  auditCommands?: AuditCommands,
+  input: UpdateChartOfAccountsInput & Omit<Partial<CF>, "status">,
+  _ctx: CommandContext,
 ) {
   const { id, name, description, ...customFields } = input;
 
@@ -98,36 +79,5 @@ export async function run<CF extends Record<string, unknown>>(
     .returningAll()
     .executeTakeFirst();
 
-  if (auditCommands) {
-    const changes: { fieldName: string; oldValue?: unknown; newValue?: unknown }[] = [];
-    if (name !== undefined && name !== existing.name) {
-      changes.push({ fieldName: "name", oldValue: existing.name, newValue: name });
-    }
-    if (description !== undefined && description !== existing.description) {
-      changes.push({
-        fieldName: "description",
-        oldValue: existing.description,
-        newValue: description,
-      });
-    }
-
-    if (changes.length > 0) {
-      await auditCommands.logAuditEvent(
-        db,
-        {
-          eventId: randomUUID(),
-          actorType: "USER",
-          actorId: ctx.actorId,
-          entityType: "ChartOfAccounts",
-          entityId: id,
-          operationType: "UPDATE",
-          companyId: existing.companyId,
-          changes,
-        },
-        ctx,
-      );
-    }
-  }
-
   return ok({ chartOfAccounts: chartOfAccounts! });
 }

package/src/modules/coa-management/docs/commands/ActivateAccount.md

@@ -11,7 +11,6 @@ activateAccount transitions a GL account from DRAFT to ACTIVE status, making it
 - Target account must be in DRAFT status
 - Activating an already ACTIVE account fails with an invalid state transition error
 - Activating an INACTIVE account fails (use reactivateAccount instead)
-- Emits an audit event via the audit module recording the acting user, timestamp, CoA reference, account code, and status transition from DRAFT to ACTIVE
 
 ## Process Flow
 
@@ -24,8 +23,7 @@ flowchart TD
     B2 -->|Yes| D{Status is DRAFT?}
     D -->|No| E[Return error: invalid state transition]
     D -->|Yes| F[Update status to ACTIVE]
-    F --> G[Emit audit event]
-    G --> H[Return activated account]
+    F --> G[Return activated account]
 ```
 
 ## External Dependencies
@@ -46,4 +44,3 @@ flowchart TD
 - returns error when account is already ACTIVE
 - returns error when account is INACTIVE
 - activates a DRAFT account
-- emits audit event recording status transition from DRAFT to ACTIVE

package/src/modules/coa-management/docs/commands/ActivateChartOfAccounts.md

@@ -10,7 +10,6 @@ activateChartOfAccounts transitions a Chart of Accounts from DRAFT to ACTIVE sta
 - Target CoA must be in DRAFT status
 - Activating an already ACTIVE or ARCHIVED CoA fails with an invalid state transition error
 - Only one CoA per company can be in ACTIVE status; activating a second CoA for the same company fails with a uniqueness constraint error
-- Emits an audit event via the audit module recording the acting user, timestamp, and status transition from DRAFT to ACTIVE
 
 ## Process Flow
 
@@ -23,8 +22,7 @@ flowchart TD
     D -->|Yes| F{Another ACTIVE CoA for same company?}
     F -->|Yes| G[Return error: duplicate active CoA]
     F -->|No| H[Update status to ACTIVE]
-    H --> I[Emit audit event]
-    I --> J[Return activated CoA]
+    H --> I[Return activated CoA]
 ```
 
 ## External Dependencies
@@ -44,4 +42,3 @@ flowchart TD
 - returns error when CoA is ARCHIVED
 - returns error when another ACTIVE CoA exists for the same company
 - activates a DRAFT CoA
-- emits audit event recording status transition from DRAFT to ACTIVE

package/src/modules/coa-management/docs/commands/CreateAccount.md

@@ -20,7 +20,6 @@ createAccount establishes a new GL account in DRAFT status within a Chart of Acc
 - Account group, when provided, must belong to the same CoA and account code must fall within the group's number range (if defined)
 - Parent CoA must exist and be in DRAFT or ACTIVE status
 - Account is always created in DRAFT status
-- Emits an audit event via the audit module recording the acting user, timestamp, CoA reference, account code, classification, and initial field values
 
 ## Process Flow
 
@@ -41,8 +40,7 @@ flowchart TD
     L -->|Yes| N{Reconciliation valid for classification?}
     N -->|No| Q[Return error: reconciliation required]
     N -->|Yes| O[Create account in DRAFT]
-    O --> P[Emit audit event]
-    P --> Q[Return created account]
+    O --> P[Return created account]
 ```
 
 ## External Dependencies
@@ -90,5 +88,4 @@ flowchart TD
 - returns error when reconciliation explicitly set to false for RECEIVABLE classification
 - returns error when reconciliation explicitly set to false for PAYABLE classification
 - returns error when reconciliation explicitly set to false for BANK_CASH classification
-- emits audit event recording acting user, timestamp, CoA reference, account code, and classification
 - passes custom fields through to insert

package/src/modules/coa-management/docs/commands/CreateAccountGroup.md

@@ -12,7 +12,6 @@ createAccountGroup establishes a new account group within a Chart of Accounts. G
 - Parent group, when provided, must exist within the same CoA
 - Account number range, when defined, requires both start and end to be provided together, must be a valid interval (start < end), and must not overlap with other groups' ranges within the CoA
 - Sort order controls display sequence among sibling groups
-- Emits an audit event via the audit module recording the acting user, timestamp, CoA reference, group code, and initial field values
 
 ## Process Flow
 
@@ -31,13 +30,12 @@ flowchart TD
     F -->|Yes| H{Number range valid and non-overlapping?}
     H -->|No| I[Return error: invalid or overlapping range]
     H -->|Yes| J[Create account group]
-    J --> K[Emit audit event]
-    K --> L[Return created group]
+    J --> K[Return created group]
 ```
 
 ## External Dependencies
 
-- [audit](../../../audit/README.md) — Receives audit events emitted by this command
+- None
 
 ## Error Scenarios
 
@@ -66,5 +64,4 @@ flowchart TD
 - creates a child group with valid parent
 - creates a group with account number range
 - creates a group with sort order
-- emits audit event recording acting user, timestamp, CoA reference, group code, and initial field values
 - passes custom fields through to insert

package/src/modules/coa-management/docs/commands/CreateChartOfAccounts.md

@@ -17,7 +17,6 @@ createChartOfAccounts establishes a new Chart of Accounts container in DRAFT sta
 - When `templateId` is provided, the command delegates template resolution to the template provider (external dependency). The provider must return the template's account groups and accounts. If no template provider is configured, templateId is rejected with TEMPLATE_PROVIDER_NOT_CONFIGURED
 - When a valid template is resolved, the command copies the template's account groups (with numbering ranges) and GL accounts into the new CoA in DRAFT status
 - Template-based creation is a convenience shortcut — all copied entities are fully mutable in DRAFT and can be modified before activation
-- Emits an audit event via the audit module recording the acting user, timestamp, initial field values, and whether the CoA was created from a template or blank
 
 ## Process Flow
 
@@ -35,9 +34,8 @@ flowchart TD
     H -->|No| I[Return error: template not found]
     H -->|Yes| J[Create CoA in DRAFT with template contents]
     G -->|No| K[Create blank CoA in DRAFT]
-    J --> L[Emit audit event]
-    K --> L
-    L --> M[Return created CoA]
+    J --> K2[Return created CoA]
+    K --> K2
 ```
 
 ## External Dependencies
@@ -68,5 +66,3 @@ flowchart TD
 - returns error when organizationQueries reports company not found
 - creates blank CoA in DRAFT status with inherited base currency when no templateId is provided
 - template-copied entities are mutable and can be modified before activation
-- emits audit event recording acting user, timestamp, and initial field values
-- audit event includes whether CoA was created from template or blank

package/src/modules/coa-management/docs/commands/DeactivateAccount.md

@@ -14,7 +14,6 @@ deactivateAccount transitions a GL account from ACTIVE to INACTIVE status, preve
 - Deactivation exposes a pre-deactivation hook for the GL module to block the transition when open balances exist
 - Without a GL module integrated, deactivation proceeds without balance checks
 - Successor account mapping is optional
-- Emits an audit event via the audit module recording the acting user, timestamp, CoA reference, account code, status transition from ACTIVE to INACTIVE, and successor mapping if provided
 
 ## Process Flow
 
@@ -35,8 +34,7 @@ flowchart TD
     J -->|No| K[Return error: successor not active]
     J -->|Yes| L[Map successor and set INACTIVE]
     I -->|No| L[Set status to INACTIVE]
-    L --> M[Emit audit event]
-    M --> N[Return deactivated account]
+    L --> M[Return deactivated account]
 ```
 
 ## External Dependencies
@@ -62,4 +60,3 @@ flowchart TD
 - deactivates an ACTIVE account with successor mapping
 - deactivates without balance check when GL hook is not registered
 - returns error when GL hook reports open balances
-- emits audit event recording status transition from ACTIVE to INACTIVE and successor mapping

package/src/modules/coa-management/docs/commands/DeactivateChartOfAccounts.md

@@ -11,7 +11,6 @@ deactivateChartOfAccounts transitions a Chart of Accounts from ACTIVE to ARCHIVE
 - Deactivating a DRAFT or already ARCHIVED CoA fails with an invalid state transition error
 - Archived CoA records and their accounts remain queryable for reporting and audit
 - This is a one-way transition; reactivation from ARCHIVED is not permitted
-- Emits an audit event via the audit module recording the acting user, timestamp, and status transition from ACTIVE to ARCHIVED
 
 ## Process Flow
 
@@ -22,8 +21,7 @@ flowchart TD
     B -->|Yes| D{Status is ACTIVE?}
     D -->|No| E[Return error: invalid state transition]
     D -->|Yes| F[Update status to ARCHIVED]
-    F --> G[Emit audit event]
-    G --> H[Return archived CoA]
+    F --> G[Return archived CoA]
 ```
 
 ## External Dependencies
@@ -41,4 +39,3 @@ flowchart TD
 - returns error when CoA is DRAFT
 - returns error when CoA is already ARCHIVED
 - archives an ACTIVE CoA
-- emits audit event recording status transition from ACTIVE to ARCHIVED

package/src/modules/coa-management/docs/commands/DeleteAccount.md

@@ -11,7 +11,6 @@ deleteAccount permanently removes a GL account that is in DRAFT status and has n
 - Target account must be in DRAFT status
 - Target account must have no posted transactions
 - Deleting ACTIVE or INACTIVE accounts is rejected
-- Emits an audit event via the audit module recording the acting user, timestamp, CoA reference, account code, and deletion
 
 ## Process Flow
 
@@ -26,8 +25,7 @@ flowchart TD
     D -->|Yes| F{Has posted transactions?}
     F -->|Yes| G[Return error: has posted transactions]
     F -->|No| H[Delete account record]
-    H --> I[Emit audit event]
-    I --> J[Return success]
+    H --> I[Return success]
 ```
 
 ## External Dependencies
@@ -49,4 +47,3 @@ flowchart TD
 - returns error when account is INACTIVE
 - returns error when DRAFT account has posted transactions
 - deletes a DRAFT account with no posted transactions
-- emits audit event recording deletion, acting user, and account code

package/src/modules/coa-management/docs/commands/DeleteAccountGroup.md

@@ -10,7 +10,6 @@ deleteAccountGroup permanently removes an account group that has no child groups
 - Parent CoA must be in DRAFT or ACTIVE status; deleting a group under an ARCHIVED CoA is rejected
 - Group must have no child groups
 - Group must have no accounts assigned to it
-- Emits an audit event via the audit module recording the acting user, timestamp, and deletion of the group
 
 ## Process Flow
 
@@ -25,8 +24,7 @@ flowchart TD
     D -->|No| F{Has assigned accounts?}
     F -->|Yes| G[Return error: has assigned accounts]
     F -->|No| H[Delete group]
-    H --> I[Emit audit event]
-    I --> J[Return success]
+    H --> I[Return success]
 ```
 
 ## External Dependencies
@@ -47,4 +45,3 @@ flowchart TD
 - returns error when group has child groups
 - returns error when group has assigned accounts
 - deletes a leaf group with no assigned accounts
-- emits audit event recording deletion and acting user

package/src/modules/coa-management/docs/commands/DeleteChartOfAccounts.md

@@ -9,8 +9,6 @@ deleteChartOfAccounts permanently removes a Chart of Accounts that is still in D
 - Target CoA must exist
 - Target CoA must be in DRAFT status; deleting ACTIVE or ARCHIVED CoA is rejected
 - Deletion cascade-deletes all child Account and AccountGroup records belonging to the CoA. Because only DRAFT CoA records can be deleted, and accounts can only be created under a DRAFT or ACTIVE CoA, all child accounts are guaranteed to be in DRAFT status with no posted transactions at this point — making cascade deletion safe and consistent with the account deletion invariant
-- Each cascade-deleted child record (Account and AccountGroup) emits its own audit event, followed by the CoA deletion audit event
-- Emits an audit event via the audit module recording the acting user, timestamp, and deletion of the CoA
 
 ## Process Flow
 
@@ -23,8 +21,7 @@ flowchart TD
     D -->|Yes| F[Cascade-delete all child Accounts]
     F --> G[Cascade-delete all child AccountGroups]
     G --> H[Delete CoA record]
-    H --> I[Emit audit events for each deleted child and the CoA]
-    I --> J[Return success]
+    H --> I[Return success]
 ```
 
 ## External Dependencies
@@ -44,5 +41,3 @@ flowchart TD
 - deletes a DRAFT CoA with no child records
 - deletes a DRAFT CoA and cascade-deletes all child Accounts
 - deletes a DRAFT CoA and cascade-deletes all child AccountGroups
-- emits audit events for each cascade-deleted Account and AccountGroup
-- emits audit event recording CoA deletion and acting user

package/src/modules/coa-management/docs/commands/MoveAccountGroup.md

@@ -12,7 +12,6 @@ moveAccountGroup reparents an account group by changing its parent reference wit
 - A group cannot be moved under itself or any of its descendants (circular reference prevention)
 - All child groups and their account assignments are preserved during the move
 - Group code and account assignments are unchanged by the move
-- Emits an audit event via the audit module recording the acting user, timestamp, previous parent reference, and new parent reference
 
 ## Process Flow
 
@@ -29,8 +28,7 @@ flowchart TD
     G -->|Yes| H[Return error: circular reference]
     G -->|No| I[Update parent reference]
     D -->|No/null| I[Promote to root]
-    I --> J[Emit audit event]
-    J --> K[Return moved group]
+    I --> J[Return moved group]
 ```
 
 ## External Dependencies
@@ -54,4 +52,3 @@ flowchart TD
 - returns error when moving group under its descendant
 - moves group to different parent
 - promotes group to root by setting parent to null
-- emits audit event recording previous and new parent references

package/src/modules/coa-management/docs/commands/ReactivateAccount.md

@@ -11,7 +11,6 @@ reactivateAccount transitions a GL account from INACTIVE back to ACTIVE status,
 - Target account must be in INACTIVE status
 - Reactivating a DRAFT or ACTIVE account fails with an invalid state transition error
 - Reactivation clears any previously mapped successor account
-- Emits an audit event via the audit module recording the acting user, timestamp, CoA reference, account code, and status transition from INACTIVE to ACTIVE
 
 ## Process Flow
 
@@ -25,8 +24,7 @@ flowchart TD
     D -->|No| E[Return error: invalid state transition]
     D -->|Yes| F[Clear successor mapping]
     F --> G[Update status to ACTIVE]
-    G --> H[Emit audit event]
-    H --> I[Return reactivated account]
+    G --> H[Return reactivated account]
 ```
 
 ## External Dependencies
@@ -47,4 +45,3 @@ flowchart TD
 - returns error when account is already ACTIVE
 - reactivates an INACTIVE account
 - clears successor mapping on reactivation
-- emits audit event recording status transition from INACTIVE to ACTIVE

package/src/modules/coa-management/docs/commands/UpdateAccount.md

@@ -19,7 +19,6 @@ updateAccount modifies attributes of an existing GL account. Structural fields (
 - Currency restriction changes must reference a valid currency from the primitives module. An account with currency restriction only accepts postings in that currency (enforced by downstream posting modules)
 - Account group changes must reference a group in the same CoA, and the account code must fall within the group's number range (if defined)
 - When the account code is changed and the account belongs to an account group (whether the group assignment is also changing or staying the same), the new code must fall within the target group's number range (if defined). This applies to both cases: changing only the code while keeping the current group, and changing both the code and the group simultaneously
-- Emits an audit event via the audit module recording the acting user, timestamp, CoA reference, account code, and previous and new field values for all changed attributes
 
 ## Process Flow
 
@@ -44,8 +43,7 @@ flowchart TD
     H --> H2{Reconciliation invariant violated?}
     H2 -->|Yes| H3[Return error: reconciliation required]
     H2 -->|No| I[Update account fields]
-    I --> J[Emit audit event]
-    J --> K[Return updated account]
+    I --> J[Return updated account]
 ```
 
 ## External Dependencies
@@ -98,5 +96,4 @@ flowchart TD
 - returns error when changing code to a value outside the current group's number range
 - returns error when changing classification from RECEIVABLE after posted transactions
 - returns error when changing classification from PAYABLE after posted transactions
-- emits audit event recording previous and new field values for all changed attributes
 - passes custom fields through to update

package/src/modules/coa-management/docs/commands/UpdateAccountGroup.md

@@ -2,17 +2,16 @@
 
 ## Overview
 
-updateAccountGroup modifies the mutable fields (name, sort order, number range) of an existing account group. Code is immutable after creation. Number range changes must not conflict with existing account assignments or overlap with other groups' ranges.
+updateAccountGroup modifies the mutable fields (name, sort order, number range) of an existing account group. The target group can be looked up by `id` or by `chartOfAccountsId` + `code`. Group code is fixed by the existing record and is used only as a lookup key when paired with `chartOfAccountsId`. Number range changes must not conflict with existing account assignments or overlap with other groups' ranges.
 
 ## Business Rules
 
-- Target group must exist
+- Target group must exist (looked up by `id` or `chartOfAccountsId` + `code`)
 - Parent CoA must be in DRAFT or ACTIVE status; updating a group under an ARCHIVED CoA is rejected
 - Name, when provided, must be non-empty
-- Group code is immutable
+- Group code is not part of the update input
 - Number range changes, when provided, require both start and end to be provided together, must remain a valid non-overlapping interval within the CoA
 - Changing a number range must not invalidate existing accounts already assigned to the group (their codes must still fall within the new range)
-- Emits an audit event via the audit module recording the acting user, timestamp, and previous and new field values for all changed attributes
 
 ## Process Flow
 
@@ -29,13 +28,12 @@ flowchart TD
     F -->|Yes| H{Existing accounts within new range?}
     H -->|No| I[Return error: accounts out of range]
     H -->|Yes| J[Update group fields]
-    J --> K[Emit audit event]
-    K --> L[Return updated group]
+    J --> K[Return updated group]
 ```
 
 ## External Dependencies
 
-- [audit](../../../audit/README.md) — Receives audit events emitted by this command
+- None
 
 ## Error Scenarios
 
@@ -48,6 +46,7 @@ flowchart TD
 ## Test Cases
 
 - returns error when group does not exist
+- looks up group by chartOfAccountsId and code and updates name
 - returns error when parent CoA is ARCHIVED
 - returns error when name is empty
 - returns error when new number range is invalid
@@ -58,5 +57,4 @@ flowchart TD
 - updates group name
 - updates sort order
 - updates number range
-- emits audit event recording previous and new field values
 - passes custom fields through to update

package/src/modules/coa-management/docs/commands/UpdateChartOfAccounts.md

@@ -10,7 +10,6 @@ updateChartOfAccounts modifies the mutable fields (name, description) of an exis
 - Target CoA must be in DRAFT or ACTIVE status; updating an ARCHIVED CoA is rejected
 - Name, when provided, must be non-empty
 - Description is optional and can be cleared
-- Emits an audit event via the audit module recording the acting user, timestamp, and previous and new field values for all changed attributes
 
 ## Process Flow
 
@@ -23,8 +22,7 @@ flowchart TD
     D -->|Yes| F{Name valid if provided?}
     F -->|No| G[Return error: name required]
     F -->|Yes| H[Update CoA fields]
-    H --> I[Emit audit event]
-    I --> J[Return updated CoA]
+    H --> I[Return updated CoA]
 ```
 
 ## External Dependencies
@@ -45,5 +43,4 @@ flowchart TD
 - updates name of a DRAFT CoA
 - updates description of an ACTIVE CoA
 - clears description by setting to null
-- emits audit event recording previous and new field values
 - passes custom fields through to update

package/src/modules/coa-management/module.ts

@@ -1,7 +1,7 @@
 import { type TailorAnyDBField } from "@tailor-platform/sdk";
 import type { defineModule as defineOrganizationModule } from "../organization";
 import type { defineModule as definePrimitivesModule } from "../primitives";
-import type { TemplateProvider, AuditCommands } from "./command/createChartOfAccounts";
+import type { TemplateProvider } from "./command/createChartOfAccounts";
 // Commands
 import { createChartOfAccounts } from "./command/createChartOfAccounts.generated";
 import { updateChartOfAccounts } from "./command/updateChartOfAccounts.generated";
@@ -60,11 +60,9 @@ export interface DefineModuleParams<
     queries: Pick<PrimitivesQueries, "getCurrency">;
   };
   templateProvider?: TemplateProvider;
-  audit?: {
-    commands: AuditCommands;
-  };
 }
 
+/* @__NO_SIDE_EFFECTS__ */
 export const defineModule = <
   const COAF extends Record<string, TailorAnyDBField> = EmptyFields,
   const AGF extends Record<string, TailorAnyDBField> = EmptyFields,
@@ -88,8 +86,6 @@ export const defineModule = <
     currencyType: params.primitives.db.currency,
   });
 
-  const auditCommands = params.audit?.commands;
-
   return {
     db: {
       chartOfAccounts: chartOfAccountsDb,
@@ -100,28 +96,21 @@ export const defineModule = <
       createChartOfAccounts: createChartOfAccounts<FieldsToInsertable<COAF>>(
         params.organization.queries,
         params.templateProvider,
-        auditCommands,
-      ),
-      updateChartOfAccounts: updateChartOfAccounts<FieldsToInsertable<COAF>>(auditCommands),
-      activateChartOfAccounts: activateChartOfAccounts(auditCommands),
-      deactivateChartOfAccounts: deactivateChartOfAccounts(auditCommands),
-      deleteChartOfAccounts: deleteChartOfAccounts(auditCommands),
-      createAccountGroup: createAccountGroup<FieldsToInsertable<AGF>>(auditCommands),
-      updateAccountGroup: updateAccountGroup<FieldsToInsertable<AGF>>(auditCommands),
-      moveAccountGroup: moveAccountGroup(auditCommands),
-      deleteAccountGroup: deleteAccountGroup(auditCommands),
-      createAccount: createAccount<FieldsToInsertable<AF>>(
-        params.primitives.queries,
-        auditCommands,
-      ),
-      updateAccount: updateAccount<FieldsToInsertable<AF>>(
-        params.primitives.queries,
-        auditCommands,
       ),
-      activateAccount: activateAccount(auditCommands),
-      deactivateAccount: deactivateAccount(auditCommands),
-      reactivateAccount: reactivateAccount(auditCommands),
-      deleteAccount: deleteAccount(auditCommands),
+      updateChartOfAccounts: updateChartOfAccounts<FieldsToInsertable<COAF>>(),
+      activateChartOfAccounts: activateChartOfAccounts(),
+      deactivateChartOfAccounts: deactivateChartOfAccounts(),
+      deleteChartOfAccounts: deleteChartOfAccounts(),
+      createAccountGroup: createAccountGroup<FieldsToInsertable<AGF>>(),
+      updateAccountGroup: updateAccountGroup<FieldsToInsertable<AGF>>(),
+      moveAccountGroup: moveAccountGroup(),
+      deleteAccountGroup: deleteAccountGroup(),
+      createAccount: createAccount<FieldsToInsertable<AF>>(params.primitives.queries),
+      updateAccount: updateAccount<FieldsToInsertable<AF>>(params.primitives.queries),
+      activateAccount: activateAccount(),
+      deactivateAccount: deactivateAccount(),
+      reactivateAccount: reactivateAccount(),
+      deleteAccount: deleteAccount(),
     },
     queries: {
       getChartOfAccounts,

package/src/modules/finance-ledger/command/updateFiscalYear.ts

@@ -8,13 +8,12 @@ import {
   OverlappingFiscalYearError,
 } from "../lib/errors.generated";
 
-export interface UpdateFiscalYearInput {
+export type UpdateFiscalYearInput = {
   id: string;
   yearName?: string;
   startDate?: Date;
   endDate?: Date;
-}
-
+};
 export async function run(db: Transaction, input: UpdateFiscalYearInput, ctx: CommandContext) {
   const existing = await db
     .selectFrom("FiscalYear")

package/src/modules/finance-ledger/command/updateJournalEntry.test.ts

@@ -5,7 +5,6 @@ import {
   JournalEntryNotFoundError,
   InvalidStatusForUpdateError,
   DuplicateReferenceNumberError,
-  JournalTypeImmutableError,
 } from "../lib/errors.generated";
 import { baseJournalEntry, postedJournalEntry, reversedJournalEntry } from "../testing/fixtures";
 import { commandCtx, expectErr, expectOk } from "../testing/commandTestUtils";
@@ -60,22 +59,6 @@ describe("updateJournalEntry", () => {
     expectErr(result, InvalidStatusForUpdateError);
   });
 
-  it("returns error when attempting to change journal type", async () => {
-    const { db, spies } = createMockDb<Transaction>();
-    spies.select.mockReturnValueOnce(baseJournalEntry);
-
-    const result = await run(
-      db,
-      {
-        journalEntryId: baseJournalEntry.id,
-        journalType: "SALES",
-      },
-      commandCtx,
-    );
-
-    expectErr(result, JournalTypeImmutableError);
-  });
-
   it("updates description on a DRAFT journal entry", async () => {
     const updatedEntry = { ...baseJournalEntry, description: "New description" };
     const { db, spies } = createMockDb<Transaction>();