@surea11y/core 1.4.0 → 1.5.0

package/src/checks/automatic/aria-prohibited-children.js

@@ -256,10 +256,6 @@ function runInPage(ctx) {
     for (const entry of owned) {
       if (entry.role && requiredSet.has(entry.role)) continue;
 
-      const stableSelector = helpers.buildSelector ? helpers.buildSelector(entry.el) : 'html';
-      const html = helpers.getOuterHtmlSnippet
-        ? helpers.getOuterHtmlSnippet(entry.el)
-        : entry.el.outerHTML || '';
       const containerSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
 
       const isRoleless = !entry.role;
@@ -286,29 +282,33 @@ function runInPage(ctx) {
         hintKey = 'ariaProhibitedChildren_hint_fail';
       }
 
-      occurrences.push({
-        selector: stableSelector,
-        html,
-        summary,
-        hint,
-        i18n: {
-          summaryKey,
-          hintKey,
-          params: isRoleless
-            ? { attr: entry.attr, containerRole: role }
-            : { childRole: entry.role, containerRole: role, allowedRoles: requiredOwned.join(', ') }
-        },
-        data: {
-          details: {
-            reasonCode: isRoleless ? 'ARIA_PROHIBITED_CHILD_ROLELESS' : 'ARIA_PROHIBITED_CHILD',
-            childRole: entry.role,
-            attr: entry.attr,
-            containerRole: role,
-            containerSelector,
-            allowedOwnedRoles: requiredOwned
+      occurrences.push(
+        helpers.reportOccurrence(entry.el, {
+          summary,
+          hint,
+          i18n: {
+            summaryKey,
+            hintKey,
+            params: isRoleless
+              ? { attr: entry.attr, containerRole: role }
+              : {
+                  childRole: entry.role,
+                  containerRole: role,
+                  allowedRoles: requiredOwned.join(', ')
+                }
+          },
+          data: {
+            details: {
+              reasonCode: isRoleless ? 'ARIA_PROHIBITED_CHILD_ROLELESS' : 'ARIA_PROHIBITED_CHILD',
+              childRole: entry.role,
+              attr: entry.attr,
+              containerRole: role,
+              containerSelector,
+              allowedOwnedRoles: requiredOwned
+            }
           }
-        }
-      });
+        })
+      );
     }
   }
 

package/src/checks/automatic/aria-required-attr.js

@@ -129,24 +129,21 @@ function runInPage(ctx) {
 
     if (!missing.length) continue;
 
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
     for (const attr of missing) {
-      occurrences.push({
-        selector: stableSelector,
-        html,
-        summary: 'This attribute is required for this element’s role, but is missing.',
-        hint: 'Add this attribute with a valid value for this role.',
-        i18n: {
-          summaryKey: 'ariaRequiredAttr_summary_fail',
-          hintKey: 'ariaRequiredAttr_hint_fail',
-          params: { attr, role }
-        },
-        data: {
-          details: { reasonCode: 'ARIA_ATTR_REQUIRED_MISSING', attr, role }
-        }
-      });
+      occurrences.push(
+        helpers.reportOccurrence(el, {
+          summary: 'This attribute is required for this element’s role, but is missing.',
+          hint: 'Add this attribute with a valid value for this role.',
+          i18n: {
+            summaryKey: 'ariaRequiredAttr_summary_fail',
+            hintKey: 'ariaRequiredAttr_hint_fail',
+            params: { attr, role }
+          },
+          data: {
+            details: { reasonCode: 'ARIA_ATTR_REQUIRED_MISSING', attr, role }
+          }
+        })
+      );
     }
   }
 

package/src/checks/automatic/aria-required-children.js

@@ -253,27 +253,24 @@ function runInPage(ctx) {
 
     if (found) continue;
 
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: 'This container role has no owned child with a required role.',
-      hint: 'Add a descendant (or aria-owns-referenced element) with one of the required owned roles.',
-      i18n: {
-        summaryKey: 'ariaRequiredChildren_summary_fail',
-        hintKey: 'ariaRequiredChildren_hint_fail',
-        params: { role, requiredRoles: requiredOwned.join(', ') }
-      },
-      data: {
-        details: {
-          reasonCode: 'ARIA_REQUIRED_CHILD_MISSING',
-          role,
-          requiredOwnedRoles: requiredOwned
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: 'This container role has no owned child with a required role.',
+        hint: 'Add a descendant (or aria-owns-referenced element) with one of the required owned roles.',
+        i18n: {
+          summaryKey: 'ariaRequiredChildren_summary_fail',
+          hintKey: 'ariaRequiredChildren_hint_fail',
+          params: { role, requiredRoles: requiredOwned.join(', ') }
+        },
+        data: {
+          details: {
+            reasonCode: 'ARIA_REQUIRED_CHILD_MISSING',
+            role,
+            requiredOwnedRoles: requiredOwned
+          }
         }
-      }
-    });
+      })
+    );
   }
 
   if (applicableCount === 0) {

package/src/checks/automatic/aria-required-parent.js

@@ -210,27 +210,24 @@ function runInPage(ctx) {
 
     if (hasContext) continue;
 
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: 'This role requires a specific ancestor/owner context role, which was not found.',
-      hint: 'Place this element inside (or aria-owns-reference it from) an element with an acceptable context role.',
-      i18n: {
-        summaryKey: 'ariaRequiredParent_summary_fail',
-        hintKey: 'ariaRequiredParent_hint_fail',
-        params: { role, requiredRoles: requiredContext.join(', ') }
-      },
-      data: {
-        details: {
-          reasonCode: 'ARIA_REQUIRED_PARENT_MISSING',
-          role,
-          requiredContextRoles: requiredContext
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: 'This role requires a specific ancestor/owner context role, which was not found.',
+        hint: 'Place this element inside (or aria-owns-reference it from) an element with an acceptable context role.',
+        i18n: {
+          summaryKey: 'ariaRequiredParent_summary_fail',
+          hintKey: 'ariaRequiredParent_hint_fail',
+          params: { role, requiredRoles: requiredContext.join(', ') }
+        },
+        data: {
+          details: {
+            reasonCode: 'ARIA_REQUIRED_PARENT_MISSING',
+            role,
+            requiredContextRoles: requiredContext
+          }
         }
-      }
-    });
+      })
+    );
   }
 
   if (applicableCount === 0) {

package/src/checks/automatic/aria-roles-valid.js

@@ -67,41 +67,80 @@ function runInPage(ctx) {
   const occurrences = [];
   let applicableCount = 0;
 
+  // Programmatically hidden per the ACT glossary: display:none, visibility not
+  // visible, or aria-hidden on the element or an ancestor. inert is treated
+  // the same although the glossary predates it -- an inert subtree is out of
+  // the accessibility tree entirely, so a role on it reaches no one.
+  function isHidden(el) {
+    try {
+      if (typeof helpers.isDomVisibleEligible === 'function') {
+        if (!helpers.isDomVisibleEligible(el, ctx)) return true;
+      }
+      // Walk the composed tree, not parentElement: that stops at a shadow
+      // root, so a host carrying aria-hidden or inert would never be seen
+      // from inside its own shadow content.
+      const up =
+        typeof helpers.composedParent === 'function'
+          ? helpers.composedParent
+          : (n) => n.parentElement;
+
+      // A shadow root has no getAttribute, so skip past it rather than
+      // stopping: the host one step further up is the node that matters.
+      for (let n = el; n; n = up(n)) {
+        if (!n.getAttribute) continue;
+        if (String(n.getAttribute('aria-hidden') || '').toLowerCase() === 'true') return true;
+        if (n.hasAttribute && n.hasAttribute('inert')) return true;
+      }
+    } catch {
+      return false;
+    }
+    return false;
+  }
+
   for (const el of nodes) {
     if (!el || !el.getAttribute) continue;
 
-    const role = ariaHelpers.getExplicitRole(el);
-    if (!role) continue; // role="" or whitespace-only: not this rule's concern
+    // ACT 674b10 is not applicable to a programmatically hidden element.
+    if (isHidden(el)) continue;
 
-    applicableCount += 1;
+    // role takes a fallback list and the first token the browser recognises
+    // wins, so role="searchfield searchbox" resolves to searchbox. The rule
+    // fails only when no token names a concrete role.
+    const tokens =
+      typeof ariaHelpers.getAllRoleTokens === 'function'
+        ? ariaHelpers.getAllRoleTokens(el)
+        : [ariaHelpers.getExplicitRole(el)].filter(Boolean);
+    if (!tokens.length) continue; // role="" or whitespace-only: not this rule's concern
 
-    const isAbstract = ariaHelpers.isAbstractRole(role);
-    const isKnown = ariaHelpers.isKnownRole(role);
+    applicableCount += 1;
 
-    if (isKnown && !isAbstract) continue;
+    const usable = tokens.find((t) => ariaHelpers.isKnownRole(t) && !ariaHelpers.isAbstractRole(t));
+    if (usable) continue;
 
+    const role = tokens[0];
+    const isKnown = tokens.some((t) => ariaHelpers.isKnownRole(t));
     const reasonCode = !isKnown ? 'ARIA_ROLE_INVALID' : 'ARIA_ROLE_ABSTRACT';
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: !isKnown
-        ? 'The role attribute value is not a recognized ARIA role.'
-        : 'The role attribute value is an abstract ARIA role, which must not be used directly.',
-      hint: !isKnown
-        ? 'Use a valid ARIA role token, or remove the role attribute if none applies.'
-        : 'Replace this abstract role with a concrete role appropriate for the widget/structure.',
-      i18n: {
-        summaryKey: !isKnown ? 'ariaRolesValid_summary_invalid' : 'ariaRolesValid_summary_abstract',
-        hintKey: !isKnown ? 'ariaRolesValid_hint_invalid' : 'ariaRolesValid_hint_abstract',
-        params: { role }
-      },
-      data: {
-        details: { reasonCode, role }
-      }
-    });
+
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: !isKnown
+          ? 'The role attribute value is not a recognized ARIA role.'
+          : 'The role attribute value is an abstract ARIA role, which must not be used directly.',
+        hint: !isKnown
+          ? 'Use a valid ARIA role token, or remove the role attribute if none applies.'
+          : 'Replace this abstract role with a concrete role appropriate for the widget/structure.',
+        i18n: {
+          summaryKey: !isKnown
+            ? 'ariaRolesValid_summary_invalid'
+            : 'ariaRolesValid_summary_abstract',
+          hintKey: !isKnown ? 'ariaRolesValid_hint_invalid' : 'ariaRolesValid_hint_abstract',
+          params: { role }
+        },
+        data: {
+          details: { reasonCode, role }
+        }
+      })
+    );
   }
 
   if (applicableCount === 0) {

package/src/checks/automatic/aria-valid-attr-value.js

@@ -105,29 +105,26 @@ function runInPage(ctx) {
 
     if (!invalid || !invalid.length) continue;
 
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
     for (const item of invalid) {
-      occurrences.push({
-        selector: stableSelector,
-        html,
-        summary: 'This element has an ARIA attribute with an invalid value.',
-        hint: 'Use a value that matches the attribute’s expected type (see the WAI-ARIA specification for this attribute).',
-        i18n: {
-          summaryKey: 'ariaValidAttrValue_summary_fail',
-          hintKey: 'ariaValidAttrValue_hint_fail',
-          params: { attr: item.name, value: item.value }
-        },
-        data: {
-          details: {
-            reasonCode: 'ARIA_ATTR_VALUE_INVALID',
-            attr: item.name,
-            value: item.value,
-            valueReason: item.reason
+      occurrences.push(
+        helpers.reportOccurrence(el, {
+          summary: 'This element has an ARIA attribute with an invalid value.',
+          hint: 'Use a value that matches the attribute’s expected type (see the WAI-ARIA specification for this attribute).',
+          i18n: {
+            summaryKey: 'ariaValidAttrValue_summary_fail',
+            hintKey: 'ariaValidAttrValue_hint_fail',
+            params: { attr: item.name, value: item.value }
+          },
+          data: {
+            details: {
+              reasonCode: 'ARIA_ATTR_VALUE_INVALID',
+              attr: item.name,
+              value: item.value,
+              valueReason: item.reason
+            }
           }
-        }
-      });
+        })
+      );
     }
   }
 

package/src/checks/automatic/aria-valid-attr.js

@@ -86,24 +86,21 @@ function runInPage(ctx) {
 
     if (!invalidNames || !invalidNames.length) continue;
 
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
     for (const name of invalidNames) {
-      occurrences.push({
-        selector: stableSelector,
-        html,
-        summary: 'This element has an attribute that is not a recognized ARIA attribute.',
-        hint: 'Correct the attribute name (check for typos), or remove it if not needed.',
-        i18n: {
-          summaryKey: 'ariaValidAttr_summary_fail',
-          hintKey: 'ariaValidAttr_hint_fail',
-          params: { attr: name }
-        },
-        data: {
-          details: { reasonCode: 'ARIA_ATTR_INVALID', attr: name }
-        }
-      });
+      occurrences.push(
+        helpers.reportOccurrence(el, {
+          summary: 'This element has an attribute that is not a recognized ARIA attribute.',
+          hint: 'Correct the attribute name (check for typos), or remove it if not needed.',
+          i18n: {
+            summaryKey: 'ariaValidAttr_summary_fail',
+            hintKey: 'ariaValidAttr_hint_fail',
+            params: { attr: name }
+          },
+          data: {
+            details: { reasonCode: 'ARIA_ATTR_INVALID', attr: name }
+          }
+        })
+      );
     }
   }
 

package/src/checks/automatic/autocomplete-valid.js

@@ -130,7 +130,15 @@ function runInPage(ctx) {
     if (tokens[i] && tokens[i].startsWith('section-') && tokens[i].length > 'section-'.length)
       i += 1;
     if (tokens[i] === 'shipping' || tokens[i] === 'billing') i += 1;
-    if (CONTACT_MODALITY.has(tokens[i])) i += 1;
+    // A contact modality token is only allowed when the field that follows is
+    // a contact field, so "work photo" is invalid while "work email" is not.
+    if (CONTACT_MODALITY.has(tokens[i])) {
+      const next = tokens[i + 1];
+      const isContactField =
+        next === 'email' || next === 'impp' || next === 'tel' || (next || '').startsWith('tel-');
+      if (!isContactField) return false;
+      i += 1;
+    }
 
     let end = tokens.length;
     if (tokens[end - 1] === 'webauthn') end -= 1;
@@ -147,33 +155,59 @@ function runInPage(ctx) {
   const occurrences = [];
   let applicableCount = 0;
 
+  // ACT 73f2c2 exempts controls where the attribute cannot describe an input
+  // purpose: the on/off toggle, disabled controls, input types with a fixed
+  // value, and controls that take no input.
+  const FIXED_VALUE_TYPES = new Set([
+    'button',
+    'checkbox',
+    'file',
+    'image',
+    'radio',
+    'reset',
+    'submit'
+  ]);
+
+  function isExempt(el) {
+    const tag = String(el.tagName || '').toLowerCase();
+    if (tag === 'input') {
+      const type = String(el.getAttribute('type') || 'text').toLowerCase();
+      if (FIXED_VALUE_TYPES.has(type)) return true;
+    }
+    if (el.hasAttribute && el.hasAttribute('disabled')) return true;
+    if (String(el.getAttribute('aria-disabled') || '').toLowerCase() === 'true') return true;
+    return false;
+  }
+
   for (const el of nodes) {
     if (!el || !el.getAttribute) continue;
     const raw = String(el.getAttribute('autocomplete') || '').trim();
     if (!raw) continue;
 
+    const tokens = raw.toLowerCase().split(/\s+/).filter(Boolean);
+    if (tokens.length === 1 && (tokens[0] === 'on' || tokens[0] === 'off')) continue;
+    if (isExempt(el)) continue;
+
     applicableCount += 1;
 
     if (isValidAutocomplete(raw)) continue;
 
     const tag = el.tagName.toLowerCase();
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: 'This autocomplete attribute value is not a valid autofill value.',
-      hint: 'Use "on"/"off", or a valid autofill token list (e.g. "shipping street-address", "cc-number").',
-      i18n: {
-        summaryKey: 'autocompleteValid_summary_fail',
-        hintKey: 'autocompleteValid_hint_fail',
-        params: { element: tag, value: raw }
-      },
-      data: {
-        details: { reasonCode: 'AUTOCOMPLETE_VALUE_INVALID', element: tag, value: raw }
-      }
-    });
+
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: 'This autocomplete attribute value is not a valid autofill value.',
+        hint: 'Use "on"/"off", or a valid autofill token list (e.g. "shipping street-address", "cc-number").',
+        i18n: {
+          summaryKey: 'autocompleteValid_summary_fail',
+          hintKey: 'autocompleteValid_hint_fail',
+          params: { element: tag, value: raw }
+        },
+        data: {
+          details: { reasonCode: 'AUTOCOMPLETE_VALUE_INVALID', element: tag, value: raw }
+        }
+      })
+    );
   }
 
   if (applicableCount === 0) {