@surea11y/core 1.4.0 → 1.5.0

package/src/checks/manual/skip-link-manual.js

@@ -184,59 +184,51 @@ function runInPage(ctx) {
       const unusableByGeometry = !!geometryReasonCode;
       if (!unusableByAcc && !unusableByGeometry) continue;
 
-      const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-      const html = helpers.getOuterHtmlSnippet
-        ? helpers.getOuterHtmlSnippet(el)
-        : el.outerHTML || '';
+      occurrences.push(
+        helpers.reportOccurrence(el, {
+          summary: 'This skip link points to a target that exists but is not currently usable.',
+          hint: 'Point this skip link to a target that is exposed and usable as a navigation destination.',
+          i18n: {
+            summaryKey: 'skipLink_summary_unusableTarget_cantTell',
+            hintKey: 'skipLink_hint_unusableTarget_cantTell',
+            params: { href }
+          },
+          data: {
+            details: {
+              reasonCode: 'SKIP_LINK_TARGET_UNUSABLE',
+              href,
+              unusableReasonCode: unusableByAcc ? 'ACC_TREE_INELIGIBLE' : geometryReasonCode,
+              targetSelector: helpers.buildSelector ? helpers.buildSelector(target) : null,
+              geometryCheckEnabled: geometrySupported
+            },
+            visibilityFilter: {
+              targetSet: 'acc',
+              accEligible: accEligibility.eligible,
+              reasons: accEligibility.reasons
+            },
+            targetGeometry: geometryEligibility
+              ? { eligible: geometryEligibility.eligible, reasons: geometryEligibility.reasons }
+              : { eligible: null, reasons: [] }
+          }
+        })
+      );
+      continue;
+    }
 
-      occurrences.push({
-        selector: stableSelector,
-        html,
-        summary: 'This skip link points to a target that exists but is not currently usable.',
-        hint: 'Point this skip link to a target that is exposed and usable as a navigation destination.',
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: "This skip link's target does not exist.",
+        hint: "Point the skip link's href at an id that exists in the document, or add the missing target element.",
         i18n: {
-          summaryKey: 'skipLink_summary_unusableTarget_cantTell',
-          hintKey: 'skipLink_hint_unusableTarget_cantTell',
+          summaryKey: 'skipLink_summary_cantTell',
+          hintKey: 'skipLink_hint_cantTell',
           params: { href }
         },
         data: {
-          details: {
-            reasonCode: 'SKIP_LINK_TARGET_UNUSABLE',
-            href,
-            unusableReasonCode: unusableByAcc ? 'ACC_TREE_INELIGIBLE' : geometryReasonCode,
-            targetSelector: helpers.buildSelector ? helpers.buildSelector(target) : null,
-            geometryCheckEnabled: geometrySupported
-          },
-          visibilityFilter: {
-            targetSet: 'acc',
-            accEligible: accEligibility.eligible,
-            reasons: accEligibility.reasons
-          },
-          targetGeometry: geometryEligibility
-            ? { eligible: geometryEligibility.eligible, reasons: geometryEligibility.reasons }
-            : { eligible: null, reasons: [] }
+          details: { reasonCode: 'SKIP_LINK_TARGET_MISSING', href }
         }
-      });
-      continue;
-    }
-
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: "This skip link's target does not exist.",
-      hint: "Point the skip link's href at an id that exists in the document, or add the missing target element.",
-      i18n: {
-        summaryKey: 'skipLink_summary_cantTell',
-        hintKey: 'skipLink_hint_cantTell',
-        params: { href }
-      },
-      data: {
-        details: { reasonCode: 'SKIP_LINK_TARGET_MISSING', href }
-      }
-    });
+      })
+    );
   }
 
   if (applicableCount === 0) {

package/src/checks/manual/tabindex-manual.js

@@ -62,23 +62,20 @@ function runInPage(ctx) {
 
     if (n <= 0) continue;
 
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: 'This element has a positive tabindex, overriding the natural tab order.',
-      hint: 'Use tabindex="0" (or a negative value to remove from tab order) instead of a positive number; fix the DOM order if a different tab order is needed.',
-      i18n: {
-        summaryKey: 'tabindex_summary_cantTell',
-        hintKey: 'tabindex_hint_cantTell',
-        params: { value: String(n) }
-      },
-      data: {
-        details: { reasonCode: 'TABINDEX_POSITIVE', value: n }
-      }
-    });
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: 'This element has a positive tabindex, overriding the natural tab order.',
+        hint: 'Use tabindex="0" (or a negative value to remove from tab order) instead of a positive number; fix the DOM order if a different tab order is needed.',
+        i18n: {
+          summaryKey: 'tabindex_summary_cantTell',
+          hintKey: 'tabindex_hint_cantTell',
+          params: { value: String(n) }
+        },
+        data: {
+          details: { reasonCode: 'TABINDEX_POSITIVE', value: n }
+        }
+      })
+    );
   }
 
   if (applicableCount === 0) {

package/src/checks/manual/table-duplicate-name-manual.js

@@ -73,23 +73,20 @@ function runInPage(ctx) {
 
     if (captionText.toLowerCase() !== summary.toLowerCase()) continue;
 
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: "This table's caption duplicates its summary attribute.",
-      hint: 'Remove the redundant summary attribute, or make it provide different information than the caption.',
-      i18n: {
-        summaryKey: 'tableDuplicateName_summary_cantTell',
-        hintKey: 'tableDuplicateName_hint_cantTell',
-        params: {}
-      },
-      data: {
-        details: { reasonCode: 'TABLE_CAPTION_SUMMARY_DUPLICATE' }
-      }
-    });
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: "This table's caption duplicates its summary attribute.",
+        hint: 'Remove the redundant summary attribute, or make it provide different information than the caption.',
+        i18n: {
+          summaryKey: 'tableDuplicateName_summary_cantTell',
+          hintKey: 'tableDuplicateName_hint_cantTell',
+          params: {}
+        },
+        data: {
+          details: { reasonCode: 'TABLE_CAPTION_SUMMARY_DUPLICATE' }
+        }
+      })
+    );
   }
 
   if (applicableCount === 0) {