@surea11y/core 1.4.0 → 1.5.0

package/src/checks/automatic/searchbox-name-present.js

@@ -109,9 +109,16 @@ function runInPage(ctx) {
     return '';
   }
 
+  // Naming rules apply only to elements included in the accessibility tree
+  // (ACT c487ae and siblings), which excludes focusable aria-hidden content.
+  // aria-hidden-focus (ACT 6cfa84) covers that markup instead.
   function isEligibleAcc(helpers, el, ctx) {
     const fn =
-      helpers && typeof helpers.isAccTreeEligible === 'function' ? helpers.isAccTreeEligible : null;
+      helpers && typeof helpers.isIncludedInAccessibilityTree === 'function'
+        ? helpers.isIncludedInAccessibilityTree
+        : helpers && typeof helpers.isAccTreeEligible === 'function'
+          ? helpers.isAccTreeEligible
+          : null;
     if (!fn) return true;
     try {
       const r = fn(el, ctx);
@@ -220,24 +227,26 @@ function runInPage(ctx) {
           }
         })()
       : null;
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
 
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: 'This element has no accessible name.',
-      hint: "Provide aria-label, aria-labelledby, or a title attribute — visible text content is not exposed as this searchbox's accessible name.",
-      i18n: {
-        summaryKey: 'searchboxNamePresent_summary_fail',
-        hintKey: 'searchboxNamePresent_hint_fail',
-        params: { controlType: 'searchbox' }
-      },
-      data: {
-        details: { reasonCode: 'name_missing', controlType: 'searchbox', methodTried: res.method },
-        visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] }
-      }
-    });
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: 'This element has no accessible name.',
+        hint: "Provide aria-label, aria-labelledby, or a title attribute — visible text content is not exposed as this searchbox's accessible name.",
+        i18n: {
+          summaryKey: 'searchboxNamePresent_summary_fail',
+          hintKey: 'searchboxNamePresent_hint_fail',
+          params: { controlType: 'searchbox' }
+        },
+        data: {
+          details: {
+            reasonCode: 'name_missing',
+            controlType: 'searchbox',
+            methodTried: res.method
+          },
+          visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] }
+        }
+      })
+    );
   }
 
   if (applicableCount === 0) {

package/src/checks/automatic/server-side-image-map-absent.js

@@ -66,24 +66,21 @@ function runInPage(ctx) {
 
     applicableCount += 1;
 
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary:
-        'This image uses a server-side image map, which has no keyboard-operable equivalent.',
-      hint: 'Replace the server-side image map (ismap) with a client-side image map (<map>/<area>) or separate accessible links/buttons.',
-      i18n: {
-        summaryKey: 'serverSideImageMapAbsent_summary_fail',
-        hintKey: 'serverSideImageMapAbsent_hint_fail',
-        params: {}
-      },
-      data: {
-        details: { reasonCode: 'SERVER_SIDE_IMAGE_MAP' }
-      }
-    });
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary:
+          'This image uses a server-side image map, which has no keyboard-operable equivalent.',
+        hint: 'Replace the server-side image map (ismap) with a client-side image map (<map>/<area>) or separate accessible links/buttons.',
+        i18n: {
+          summaryKey: 'serverSideImageMapAbsent_summary_fail',
+          hintKey: 'serverSideImageMapAbsent_hint_fail',
+          params: {}
+        },
+        data: {
+          details: { reasonCode: 'SERVER_SIDE_IMAGE_MAP' }
+        }
+      })
+    );
   }
 
   if (applicableCount === 0) {

package/src/checks/automatic/slider-name-present.js

@@ -125,9 +125,16 @@ function runInPage(ctx) {
     return '';
   }
 
+  // Naming rules apply only to elements included in the accessibility tree
+  // (ACT c487ae and siblings), which excludes focusable aria-hidden content.
+  // aria-hidden-focus (ACT 6cfa84) covers that markup instead.
   function isEligibleAcc(helpers, el, ctx) {
     const fn =
-      helpers && typeof helpers.isAccTreeEligible === 'function' ? helpers.isAccTreeEligible : null;
+      helpers && typeof helpers.isIncludedInAccessibilityTree === 'function'
+        ? helpers.isIncludedInAccessibilityTree
+        : helpers && typeof helpers.isAccTreeEligible === 'function'
+          ? helpers.isAccTreeEligible
+          : null;
     if (!fn) return true;
     try {
       const r = fn(el, ctx);
@@ -141,7 +148,9 @@ function runInPage(ctx) {
   const occurrences = [];
   let applicableCount = 0;
 
-  const selector = 'input[type="range"], [role="slider"]';
+  // Native input[type=range] belongs to
+  // form-control-programmatic-label-present.
+  const selector = '[role="slider"]';
   const nodes = helpers.queryAllSmart
     ? helpers.queryAllSmart(selector)
     : helpers.queryAll(selector);
@@ -233,24 +242,22 @@ function runInPage(ctx) {
           }
         })()
       : null;
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
 
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: 'This slider has no accessible name.',
-      hint: 'Provide a label, aria-label, or aria-labelledby so assistive technologies can identify the slider.',
-      i18n: {
-        summaryKey: 'sliderNamePresent_summary_fail',
-        hintKey: 'sliderNamePresent_hint_fail',
-        params: { kind }
-      },
-      data: {
-        details: { reasonCode: 'name_missing', controlType: kind, methodTried: res.method },
-        visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] }
-      }
-    });
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: 'This slider has no accessible name.',
+        hint: 'Provide a label, aria-label, or aria-labelledby so assistive technologies can identify the slider.',
+        i18n: {
+          summaryKey: 'sliderNamePresent_summary_fail',
+          hintKey: 'sliderNamePresent_hint_fail',
+          params: { kind }
+        },
+        data: {
+          details: { reasonCode: 'name_missing', controlType: kind, methodTried: res.method },
+          visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] }
+        }
+      })
+    );
   }
 
   if (applicableCount === 0) {

package/src/checks/automatic/spinbutton-name-present.js

@@ -109,9 +109,16 @@ function runInPage(ctx) {
     return '';
   }
 
+  // Naming rules apply only to elements included in the accessibility tree
+  // (ACT c487ae and siblings), which excludes focusable aria-hidden content.
+  // aria-hidden-focus (ACT 6cfa84) covers that markup instead.
   function isEligibleAcc(helpers, el, ctx) {
     const fn =
-      helpers && typeof helpers.isAccTreeEligible === 'function' ? helpers.isAccTreeEligible : null;
+      helpers && typeof helpers.isIncludedInAccessibilityTree === 'function'
+        ? helpers.isIncludedInAccessibilityTree
+        : helpers && typeof helpers.isAccTreeEligible === 'function'
+          ? helpers.isAccTreeEligible
+          : null;
     if (!fn) return true;
     try {
       const r = fn(el, ctx);
@@ -220,24 +227,26 @@ function runInPage(ctx) {
           }
         })()
       : null;
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
 
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: 'This element has no accessible name.',
-      hint: "Provide aria-label, aria-labelledby, or a title attribute — visible text content is not exposed as this spinbutton's accessible name.",
-      i18n: {
-        summaryKey: 'spinbuttonNamePresent_summary_fail',
-        hintKey: 'spinbuttonNamePresent_hint_fail',
-        params: { controlType: 'spinbutton' }
-      },
-      data: {
-        details: { reasonCode: 'name_missing', controlType: 'spinbutton', methodTried: res.method },
-        visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] }
-      }
-    });
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: 'This element has no accessible name.',
+        hint: "Provide aria-label, aria-labelledby, or a title attribute — visible text content is not exposed as this spinbutton's accessible name.",
+        i18n: {
+          summaryKey: 'spinbuttonNamePresent_summary_fail',
+          hintKey: 'spinbuttonNamePresent_hint_fail',
+          params: { controlType: 'spinbutton' }
+        },
+        data: {
+          details: {
+            reasonCode: 'name_missing',
+            controlType: 'spinbutton',
+            methodTried: res.method
+          },
+          visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] }
+        }
+      })
+    );
   }
 
   if (applicableCount === 0) {

package/src/checks/automatic/summary-name-present.js

@@ -83,9 +83,16 @@ function runInPage(ctx) {
     return '';
   }
 
+  // Naming rules apply only to elements included in the accessibility tree
+  // (ACT c487ae and siblings), which excludes focusable aria-hidden content.
+  // aria-hidden-focus (ACT 6cfa84) covers that markup instead.
   function isEligibleAcc(helpers, el, ctx) {
     const fn =
-      helpers && typeof helpers.isAccTreeEligible === 'function' ? helpers.isAccTreeEligible : null;
+      helpers && typeof helpers.isIncludedInAccessibilityTree === 'function'
+        ? helpers.isIncludedInAccessibilityTree
+        : helpers && typeof helpers.isAccTreeEligible === 'function'
+          ? helpers.isAccTreeEligible
+          : null;
     if (!fn) return true;
     try {
       const r = fn(el, ctx);
@@ -137,24 +144,22 @@ function runInPage(ctx) {
           }
         })()
       : null;
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: 'This summary has no accessible name.',
-      hint: 'Provide summary text that is not hidden from assistive technologies, or provide aria-label or aria-labelledby.',
-      i18n: {
-        summaryKey: 'summaryNamePresent_summary_fail',
-        hintKey: 'summaryNamePresent_hint_fail',
-        params: {}
-      },
-      data: {
-        details: { reasonCode: 'name_missing', controlType: 'summary', methodTried: res.method },
-        visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] }
-      }
-    });
+
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: 'This summary has no accessible name.',
+        hint: 'Provide summary text that is not hidden from assistive technologies, or provide aria-label or aria-labelledby.',
+        i18n: {
+          summaryKey: 'summaryNamePresent_summary_fail',
+          hintKey: 'summaryNamePresent_hint_fail',
+          params: {}
+        },
+        data: {
+          details: { reasonCode: 'name_missing', controlType: 'summary', methodTried: res.method },
+          visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] }
+        }
+      })
+    );
   }
 
   if (applicableCount === 0) {

package/src/checks/automatic/tab-name-present.js

@@ -83,9 +83,16 @@ function runInPage(ctx) {
     return '';
   }
 
+  // Naming rules apply only to elements included in the accessibility tree
+  // (ACT c487ae and siblings), which excludes focusable aria-hidden content.
+  // aria-hidden-focus (ACT 6cfa84) covers that markup instead.
   function isEligibleAcc(helpers, el, ctx) {
     const fn =
-      helpers && typeof helpers.isAccTreeEligible === 'function' ? helpers.isAccTreeEligible : null;
+      helpers && typeof helpers.isIncludedInAccessibilityTree === 'function'
+        ? helpers.isIncludedInAccessibilityTree
+        : helpers && typeof helpers.isAccTreeEligible === 'function'
+          ? helpers.isAccTreeEligible
+          : null;
     if (!fn) return true;
     try {
       const r = fn(el, ctx);
@@ -141,24 +148,22 @@ function runInPage(ctx) {
           }
         })()
       : null;
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: 'This tab has no accessible name.',
-      hint: 'Provide tab text that is not hidden from assistive technologies, or provide aria-label or aria-labelledby.',
-      i18n: {
-        summaryKey: 'tabNamePresent_summary_fail',
-        hintKey: 'tabNamePresent_hint_fail',
-        params: {}
-      },
-      data: {
-        details: { reasonCode: 'name_missing', controlType: 'tab', methodTried: res.method },
-        visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] }
-      }
-    });
+
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: 'This tab has no accessible name.',
+        hint: 'Provide tab text that is not hidden from assistive technologies, or provide aria-label or aria-labelledby.',
+        i18n: {
+          summaryKey: 'tabNamePresent_summary_fail',
+          hintKey: 'tabNamePresent_hint_fail',
+          params: {}
+        },
+        data: {
+          details: { reasonCode: 'name_missing', controlType: 'tab', methodTried: res.method },
+          visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] }
+        }
+      })
+    );
   }
 
   if (applicableCount === 0) {

package/src/checks/automatic/table-headers-attr-valid.js

@@ -104,23 +104,21 @@ function runInPage(ctx) {
     const dedupedInvalidIds = [...new Set(invalid.map((i) => i.id))];
 
     const tag = el.tagName.toLowerCase();
-    const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
-
-    occurrences.push({
-      selector: stableSelector,
-      html,
-      summary: 'This cell’s headers attribute references one or more invalid header cells.',
-      hint: 'Update the headers attribute so every id refers to a <th> element within the same table.',
-      i18n: {
-        summaryKey: 'tableHeadersAttrValid_summary_fail',
-        hintKey: 'tableHeadersAttrValid_hint_fail',
-        params: { element: tag, invalidIds: dedupedInvalidIds.join(', ') }
-      },
-      data: {
-        details: { reasonCode: 'TABLE_HEADERS_ATTR_INVALID', element: tag, invalid }
-      }
-    });
+
+    occurrences.push(
+      helpers.reportOccurrence(el, {
+        summary: 'This cell’s headers attribute references one or more invalid header cells.',
+        hint: 'Update the headers attribute so every id refers to a <th> element within the same table.',
+        i18n: {
+          summaryKey: 'tableHeadersAttrValid_summary_fail',
+          hintKey: 'tableHeadersAttrValid_hint_fail',
+          params: { element: tag, invalidIds: dedupedInvalidIds.join(', ') }
+        },
+        data: {
+          details: { reasonCode: 'TABLE_HEADERS_ATTR_INVALID', element: tag, invalid }
+        }
+      })
+    );
   }
 
   if (applicableCount === 0) {

package/src/checks/automatic/table-th-has-data-cells.js

@@ -9,7 +9,10 @@
  * @standard WCAG 2.2
  * @sc 1.3.1
  * @applicability
- *   Applies to <table> elements that contain at least one <th>.
+ *   Applies to <table> elements that keep their table semantics and are included
+ *   in the accessibility tree, and that contain at least one <th> which is
+ *   visible, included in the accessibility tree, and not overridden by an
+ *   explicit role other than rowheader/columnheader.
  * @expectation
  *   The table also contains at least one <td> somewhere in it.
  * @implementation-notes
@@ -30,9 +33,10 @@
  *   if some particular <th> in it doesn't actually describe any cell
  *   (false negative, not a false positive — acceptable under this
  *   engine's philosophy).
- * - Not rule-gated on isAccTreeEligible: this remains a static-markup
- *   property, while engine-level hidden-subtree filtering still applies
- *   unless engineOptions.includeHiddenElements is true.
+ * - Applicability IS gated, because the zero-<td> case above turns any
+ *   over-broad scope straight into a false fail: a layout table marked
+ *   role="presentation" with a stray <th> and no <td> was being failed,
+ *   as were tables whose only header was hidden or carried role="cell".
  */
 
 const id = 'table-th-has-data-cells';
@@ -72,16 +76,73 @@ function runInPage(ctx) {
   const occurrences = [];
   let applicableCount = 0;
 
+  function explicitRole(el) {
+    try {
+      return String((el && el.getAttribute && el.getAttribute('role')) || '')
+        .trim()
+        .toLowerCase()
+        .split(/\s+/)[0];
+    } catch {
+      return '';
+    }
+  }
+
+  function isIncludedInTree(el) {
+    const fn =
+      helpers && typeof helpers.isIncludedInAccessibilityTree === 'function'
+        ? helpers.isIncludedInAccessibilityTree
+        : null;
+    if (!fn) return true;
+    try {
+      const r = fn(el, ctx);
+      return typeof r === 'boolean' ? r : !!(r && r.eligible);
+    } catch {
+      return true;
+    }
+  }
+
+  // role="presentation"/"none" removes the table role, and with it every
+  // header cell the role would have implied. A table is not focusable, so
+  // presentational role conflict resolution does not restore it.
+  function hasTableSemantics(table) {
+    const role = explicitRole(table);
+    if (role === 'presentation' || role === 'none') return false;
+    if (role && role !== 'table' && role !== 'grid' && role !== 'treegrid') return false;
+    return isIncludedInTree(table);
+  }
+
+  // A <th> only carries a rowheader/columnheader role while nothing overrides
+  // it, and a hidden header describes nothing to a screen reader either way.
+  function isHeaderCellInScope(th) {
+    if (!th) return false;
+    const role = explicitRole(th);
+    if (role && role !== 'rowheader' && role !== 'columnheader') return false;
+    if (helpers.isDomVisibleEligible) {
+      try {
+        if (!helpers.isDomVisibleEligible(th, ctx, { targetSet: 'dom' }).eligible) return false;
+      } catch {
+        // fall through to the tree check
+      }
+    }
+    return isIncludedInTree(th);
+  }
+
   for (const table of tables) {
     if (!table || !table.querySelectorAll) continue;
 
+    // A table stripped of its semantics has no header cells to describe
+    // anything, so nothing in it is in scope.
+    if (!hasTableSemantics(table)) continue;
+
     let ths;
     try {
       ths = table.querySelectorAll('th');
     } catch {
       ths = [];
     }
-    if (!ths.length) continue;
+
+    const headers = Array.from(ths).filter(isHeaderCellInScope);
+    if (!headers.length) continue;
 
     applicableCount += 1;
 
@@ -93,27 +154,23 @@ function runInPage(ctx) {
     }
     if (hasDataCell) continue;
 
-    for (const th of ths) {
+    for (const th of headers) {
       if (!th) continue;
-      const stableSelector = helpers.buildSelector ? helpers.buildSelector(th) : 'html';
-      const html = helpers.getOuterHtmlSnippet
-        ? helpers.getOuterHtmlSnippet(th)
-        : th.outerHTML || '';
-
-      occurrences.push({
-        selector: stableSelector,
-        html,
-        summary: 'This table has header cells but no data cells for them to describe.',
-        hint: 'Add data cells (<td>) to the table, or remove the header cells if the table has no data.',
-        i18n: {
-          summaryKey: 'tableThHasDataCells_summary_fail',
-          hintKey: 'tableThHasDataCells_hint_fail',
-          params: {}
-        },
-        data: {
-          details: { reasonCode: 'TABLE_TH_NO_DATA_CELLS' }
-        }
-      });
+
+      occurrences.push(
+        helpers.reportOccurrence(th, {
+          summary: 'This table has header cells but no data cells for them to describe.',
+          hint: 'Add data cells (<td>) to the table, or remove the header cells if the table has no data.',
+          i18n: {
+            summaryKey: 'tableThHasDataCells_summary_fail',
+            hintKey: 'tableThHasDataCells_hint_fail',
+            params: {}
+          },
+          data: {
+            details: { reasonCode: 'TABLE_TH_NO_DATA_CELLS' }
+          }
+        })
+      );
     }
   }