@surea11y/core 1.2.0 → 1.4.0

package/src/checks/manual/table-duplicate-name-manual.js

@@ -1,10 +1,12 @@
+/* SPDX-License-Identifier: MPL-2.0 */
+
 'use strict';
 
 /**
  * @check table-duplicate-name
  * @atomic true
  * @summary A table's caption must not duplicate its summary attribute
- * @standard Best Practices (a widely-used reference engine's classification; no formal WCAG Success Criterion — see ROADMAP.md Tier 1b)
+ * @standard Best Practices (no formal WCAG Success Criterion — see ROADMAP.md Tier 1b)
  * @applicability
  *   Applies to <table> elements that have both a <caption> with text
  *   content and a (deprecated but still encountered) summary attribute.
@@ -17,16 +19,16 @@
  * - Not WCAG-normative — authored as an advisory, cantTell-capped
  *   `type: 'manual'` rule; see landmark-banner-is-top-level's
  *   header comment for the shared rationale/precedent.
- * - Narrowly scoped to caption-vs-summary duplication specifically
- *   (matching a reference engine's table-duplicate-name check), not a general "table
- *   name quality" check.
+ * - Narrowly scoped to caption-vs-summary duplication specifically, not a
+ *   general "table name quality" check.
  */
 
 const id = 'table-duplicate-name';
 
 const meta = {
   title: 'Table caption must not duplicate its summary attribute',
-  description: 'Checks that a <table>\'s <caption> text is not identical to its (deprecated) summary attribute.',
+  description:
+    "Checks that a <table>'s <caption> text is not identical to its (deprecated) summary attribute.",
   i18n: {
     titleKey: 'tableDuplicateName_title',
     descriptionKey: 'tableDuplicateName_description'
@@ -43,13 +45,17 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, helpers, rule } = ctx;
+  const { helpers, rule } = ctx;
 
   function normalizeWs(s) {
-    return String(s || '').replace(/\s+/g, ' ').trim();
+    return String(s || '')
+      .replace(/\s+/g, ' ')
+      .trim();
   }
 
-  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('table[summary]') : helpers.queryAll('table[summary]');
+  const nodes = helpers.queryAllSmart
+    ? helpers.queryAllSmart('table[summary]')
+    : helpers.queryAll('table[summary]');
 
   const occurrences = [];
   let applicableCount = 0;
@@ -68,12 +74,12 @@ function runInPage(ctx) {
     if (captionText.toLowerCase() !== summary.toLowerCase()) continue;
 
     const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : (el.outerHTML || '');
+    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
 
     occurrences.push({
       selector: stableSelector,
       html,
-      summary: 'This table\'s caption duplicates its summary attribute.',
+      summary: "This table's caption duplicates its summary attribute.",
       hint: 'Remove the redundant summary attribute, or make it provide different information than the caption.',
       i18n: {
         summaryKey: 'tableDuplicateName_summary_cantTell',
@@ -90,7 +96,12 @@ function runInPage(ctx) {
     return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };
   }
   if (occurrences.length) {
-    return { ruleId: rule.ruleId, outcome: 'cantTell', severity: rule.defaultSeverity || 'minor', occurrences };
+    return {
+      ruleId: rule.ruleId,
+      outcome: 'cantTell',
+      severity: rule.defaultSeverity || 'minor',
+      occurrences
+    };
   }
   return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };
 }

package/src/checks/manual/table-fake-caption-manual.js

@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: MPL-2.0 */
+
 'use strict';
 
 /**
@@ -32,7 +34,8 @@ const id = 'table-fake-caption';
 
 const meta = {
   title: "A table's first row should not stand in for a real <caption>",
-  description: 'Flags tables with no <caption> whose first row has a single non-empty cell while other rows have multiple cells, for manual review of whether that cell is acting as a fake caption.',
+  description:
+    'Flags tables with no <caption> whose first row has a single non-empty cell while other rows have multiple cells, for manual review of whether that cell is acting as a fake caption.',
   i18n: {
     titleKey: 'tableFakeCaption_title',
     descriptionKey: 'tableFakeCaption_description'
@@ -41,7 +44,13 @@ const meta = {
   tags: ['wcag2a', 'wcag131', 'structure', 'atomic', 'manual'],
   wcagSc: ['1.3.1'],
   normativeMappings: [
-    { standard: 'WCAG', version: '2.2', requirement: '1.3.1', title: 'Info and Relationships', conformanceLevel: 'A' }
+    {
+      standard: 'WCAG',
+      version: '2.2',
+      requirement: '1.3.1',
+      title: 'Info and Relationships',
+      conformanceLevel: 'A'
+    }
   ],
   defaultSeverity: 'minor',
   category: 'perceivable',
@@ -51,9 +60,24 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, helpers, rule } = ctx;
+  const { helpers, rule } = ctx;
+
+  function trim(v) {
+    return (v == null ? '' : String(v)).trim();
+  }
 
-  function trim(v) { return (v == null ? '' : String(v)).trim(); }
+  const isAccTreeEligible =
+    helpers && typeof helpers.isAccTreeEligible === 'function' ? helpers.isAccTreeEligible : null;
+
+  function isEligible(node) {
+    if (!isAccTreeEligible) return true;
+    try {
+      const r = isAccTreeEligible(node, ctx);
+      return !!(r && r.eligible);
+    } catch {
+      return true;
+    }
+  }
 
   const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('table') : helpers.queryAll('table');
 
@@ -66,29 +90,38 @@ function runInPage(ctx) {
     const hasCaption = !!(table.querySelector && table.querySelector('caption'));
     if (hasCaption) continue;
 
-    const rows = Array.from(table.rows);
+    // An aria-hidden row (or cell) isn't part of the AT-perceived table
+    // structure at all -- it must not be treated as the table's "first
+    // row" (or counted toward a row's cell count) for this positional
+    // heuristic.
+    const rows = Array.from(table.rows).filter(isEligible);
     if (rows.length < 2) continue;
 
     applicableCount += 1;
 
     const firstRow = rows[0];
-    const firstRowCells = Array.from(firstRow.cells || []);
+    const firstRowCells = Array.from(firstRow.cells || []).filter(isEligible);
     if (firstRowCells.length !== 1) continue;
 
     const candidateCell = firstRowCells[0];
     const candidateText = trim(candidateCell.textContent || '');
     if (!candidateText) continue;
 
-    const hasMultiCellRow = rows.slice(1).some((r) => Array.from(r.cells || []).length > 1);
+    const hasMultiCellRow = rows
+      .slice(1)
+      .some((r) => Array.from(r.cells || []).filter(isEligible).length > 1);
     if (!hasMultiCellRow) continue;
 
     const stableSelector = helpers.buildSelector ? helpers.buildSelector(table) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(table) : (table.outerHTML || '');
+    const html = helpers.getOuterHtmlSnippet
+      ? helpers.getOuterHtmlSnippet(table)
+      : table.outerHTML || '';
 
     const baseOccurrence = {
       selector: stableSelector,
       html,
-      summary: 'This table has no <caption>, but its first row is a single cell sitting above multi-cell rows — it may be acting as a fake caption.',
+      summary:
+        'This table has no <caption>, but its first row is a single cell sitting above multi-cell rows — it may be acting as a fake caption.',
       hint: 'If this cell is meant to describe the table, use a real <caption> element instead of a lone first-row cell.',
       i18n: {
         summaryKey: 'tableFakeCaption_summary_cantTell',
@@ -112,7 +145,12 @@ function runInPage(ctx) {
   }
 
   if (occurrences.length) {
-    return { ruleId: rule.ruleId, outcome: 'cantTell', severity: rule.defaultSeverity || 'minor', occurrences };
+    return {
+      ruleId: rule.ruleId,
+      outcome: 'cantTell',
+      severity: rule.defaultSeverity || 'minor',
+      occurrences
+    };
   }
 
   return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };

package/src/checks/manual/video-caption-manual.js

@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: MPL-2.0 */
+
 'use strict';
 
 /**
@@ -41,7 +43,13 @@ const meta = {
   tags: ['wcag2a', 'wcag122', 'media', 'timebasedmedia', 'atomic', 'manual'],
   wcagSc: ['1.2.2'],
   normativeMappings: [
-    { standard: 'WCAG', version: '2.2', requirement: '1.2.2', title: 'Captions (Prerecorded)', conformanceLevel: 'A' }
+    {
+      standard: 'WCAG',
+      version: '2.2',
+      requirement: '1.2.2',
+      title: 'Captions (Prerecorded)',
+      conformanceLevel: 'A'
+    }
   ],
   defaultSeverity: 'moderate',
   category: 'perceivable',
@@ -51,7 +59,7 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, helpers, rule } = ctx;
+  const { helpers, rule } = ctx;
 
   const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('video') : helpers.queryAll('video');
 
@@ -77,7 +85,7 @@ function runInPage(ctx) {
     if (hasCaptionsTrack) continue;
 
     const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : (el.outerHTML || '');
+    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
 
     const baseOccurrence = {
       selector: stableSelector,
@@ -106,7 +114,12 @@ function runInPage(ctx) {
   }
 
   if (occurrences.length) {
-    return { ruleId: rule.ruleId, outcome: 'cantTell', severity: rule.defaultSeverity || 'moderate', occurrences };
+    return {
+      ruleId: rule.ruleId,
+      outcome: 'cantTell',
+      severity: rule.defaultSeverity || 'moderate',
+      occurrences
+    };
   }
 
   // Manual rules may only emit cantTell/notApplicable (never pass/fail):

package/src/checks/manual-review.js

@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: MPL-2.0 */
+
 'use strict';
 
 /**
@@ -20,17 +22,59 @@ const meta = {
   type: 'manual',
   defaultConfidence: 'medium',
   normativeMappings: [
-    { standard: 'WCAG', version: '2.2', requirement: '2.1.1', title: 'Keyboard', conformanceLevel: 'A', url: 'https://www.w3.org/TR/WCAG22/#keyboard' },
-    { standard: 'WCAG', version: '2.2', requirement: '2.4.3', title: 'Focus Order', conformanceLevel: 'A', url: 'https://www.w3.org/TR/WCAG22/#focus-order' },
-    { standard: 'WCAG', version: '2.2', requirement: '2.4.7', title: 'Focus Visible', conformanceLevel: 'AA', url: 'https://www.w3.org/TR/WCAG22/#focus-visible' },
+    {
+      standard: 'WCAG',
+      version: '2.2',
+      requirement: '2.1.1',
+      title: 'Keyboard',
+      conformanceLevel: 'A',
+      url: 'https://www.w3.org/TR/WCAG22/#keyboard'
+    },
+    {
+      standard: 'WCAG',
+      version: '2.2',
+      requirement: '2.4.3',
+      title: 'Focus Order',
+      conformanceLevel: 'A',
+      url: 'https://www.w3.org/TR/WCAG22/#focus-order'
+    },
+    {
+      standard: 'WCAG',
+      version: '2.2',
+      requirement: '2.4.7',
+      title: 'Focus Visible',
+      conformanceLevel: 'AA',
+      url: 'https://www.w3.org/TR/WCAG22/#focus-visible'
+    },
 
     { standard: 'EN 301 549', version: 'V3.2.1', requirement: '9.2.1.1', title: 'Keyboard' },
     { standard: 'EN 301 549', version: 'V3.2.1', requirement: '9.2.4.3', title: 'Focus Order' },
     { standard: 'EN 301 549', version: 'V3.2.1', requirement: '9.2.4.7', title: 'Focus Visible' },
 
-    { standard: 'WCAG', version: '2.2', type: 'Understanding', requirement: '2.1.1', title: 'Understanding Keyboard', url: 'https://www.w3.org/WAI/WCAG22/Understanding/keyboard.html' },
-    { standard: 'WCAG', version: '2.2', type: 'Understanding', requirement: '2.4.3', title: 'Understanding Focus Order', url: 'https://www.w3.org/WAI/WCAG22/Understanding/focus-order.html' },
-    { standard: 'WCAG', version: '2.2', type: 'Understanding', requirement: '2.4.7', title: 'Understanding Focus Visible', url: 'https://www.w3.org/WAI/WCAG22/Understanding/focus-visible.html' }
+    {
+      standard: 'WCAG',
+      version: '2.2',
+      type: 'Understanding',
+      requirement: '2.1.1',
+      title: 'Understanding Keyboard',
+      url: 'https://www.w3.org/WAI/WCAG22/Understanding/keyboard.html'
+    },
+    {
+      standard: 'WCAG',
+      version: '2.2',
+      type: 'Understanding',
+      requirement: '2.4.3',
+      title: 'Understanding Focus Order',
+      url: 'https://www.w3.org/WAI/WCAG22/Understanding/focus-order.html'
+    },
+    {
+      standard: 'WCAG',
+      version: '2.2',
+      type: 'Understanding',
+      requirement: '2.4.7',
+      title: 'Understanding Focus Visible',
+      url: 'https://www.w3.org/WAI/WCAG22/Understanding/focus-visible.html'
+    }
   ]
 };
 
@@ -43,7 +87,8 @@ const meta = {
 function runInPage(ctx) {
   const { document, root, helpers, rule } = ctx;
 
-  const getOuterHtmlSnippet = helpers && helpers.getOuterHtmlSnippet
+  const getOuterHtmlSnippet =
+    helpers && helpers.getOuterHtmlSnippet
       ? helpers.getOuterHtmlSnippet
       : (el) => (el && el.outerHTML) || '';
 
@@ -66,10 +111,7 @@ function runInPage(ctx) {
   }
 
   const fallbackRoot =
-      rootEl ||
-      document.documentElement ||
-      document.body ||
-      document.querySelector('html');
+    rootEl || document.documentElement || document.body || document.querySelector('html');
 
   const html = getOuterHtmlSnippet(fallbackRoot);
 
@@ -82,7 +124,11 @@ function runInPage(ctx) {
         selector: contextSelector || 'html',
         html,
         summary: 'Manual review required for keyboard navigation and focus order.',
-        i18n: { summaryKey: 'manualReview_summary_cantTell', hintKey: 'manualReview_hint_cantTell', params: {} },
+        i18n: {
+          summaryKey: 'manualReview_summary_cantTell',
+          hintKey: 'manualReview_hint_cantTell',
+          params: {}
+        }
       }
     ]
   };