@surea11y/core 1.2.0 → 1.4.0

package/src/checks/manual/area-alt-quality-manual.js

@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: MPL-2.0 */
+
 'use strict';
 
 /**
@@ -11,20 +13,26 @@
  *   Human review is required to confirm that the provided text alternative is accurate and appropriate.
  */
 
-const id = "area-alt-quality";
+const id = 'area-alt-quality';
 
 const meta = {
-  title: "<area> alt text must be appropriate (manual review)",
-  description: "Flags <area> elements with non-empty alt text for human review of appropriateness.",
+  title: '<area> alt text must be appropriate (manual review)',
+  description: 'Flags <area> elements with non-empty alt text for human review of appropriateness.',
   i18n: {
-    titleKey: "area_altQuality_title",
-    descriptionKey: "area_altQuality_description"
+    titleKey: 'area_altQuality_title',
+    descriptionKey: 'area_altQuality_description'
   },
   helpUrl: null,
-  tags: ["wcag2a", "wcag111", "nontext", "images", "imagemap", "manual", "atomic"],
+  tags: ['wcag2a', 'wcag111', 'nontext', 'images', 'imagemap', 'manual', 'atomic'],
   wcagSc: ['1.1.1'],
   normativeMappings: [
-    { standard: 'WCAG', version: '2.2', requirement: '1.1.1', title: 'Non-text Content', conformanceLevel: 'A' }
+    {
+      standard: 'WCAG',
+      version: '2.2',
+      requirement: '1.1.1',
+      title: 'Non-text Content',
+      conformanceLevel: 'A'
+    }
   ],
   defaultSeverity: 'minor',
   category: 'perceivable',
@@ -38,167 +46,202 @@ const meta = {
 };
 
 function runInPage(ctx) {
+  const { document, root, helpers, rule } = ctx;
+  const safeRoot = root || document;
+
+  const queryAllSmart =
+    helpers && typeof helpers.queryAllSmart === 'function' ? helpers.queryAllSmart : null;
+  const queryAll =
+    helpers && typeof helpers.queryAll === 'function'
+      ? helpers.queryAll
+      : (sel) => {
+          try {
+            return safeRoot && safeRoot.querySelectorAll
+              ? Array.from(safeRoot.querySelectorAll(sel))
+              : [];
+          } catch {
+            return [];
+          }
+        };
 
-    const { document, root, helpers, rule } = ctx;
-    const safeRoot = root || document;
+  const getEligibilityInfo =
+    helpers && typeof helpers.getEligibilityInfo === 'function' ? helpers.getEligibilityInfo : null;
 
-    const queryAllSmart = helpers && typeof helpers.queryAllSmart === 'function' ? helpers.queryAllSmart : null;
-    const queryAll = helpers && typeof helpers.queryAll === 'function'
-        ? helpers.queryAll
-        : (sel) => {
-            try { return safeRoot && safeRoot.querySelectorAll ? Array.from(safeRoot.querySelectorAll(sel)) : []; }
-            catch { return []; }
-        };
+  const isAccTreeEligible =
+    helpers && typeof helpers.isAccTreeEligible === 'function' ? helpers.isAccTreeEligible : null;
 
-    const getEligibilityInfo = helpers && typeof helpers.getEligibilityInfo === 'function'
-        ? helpers.getEligibilityInfo
-        : null;
-
-    const isAccTreeEligible = helpers && typeof helpers.isAccTreeEligible === 'function'
-        ? helpers.isAccTreeEligible
-        : null;
-
-    const __accEligCache = new WeakMap();
-    function accEligibleCached(node) {
-        if (!isAccTreeEligible) return { eligible: true, reasons: [] };
-        if (!node || typeof node !== 'object') return { eligible: true, reasons: [] };
-        const c = __accEligCache.get(node);
-        if (c) return c;
-        let r;
-        try { r = isAccTreeEligible(node, ctx); } catch { r = { eligible: true, reasons: [] }; }
-        r = r && typeof r === 'object' ? r : { eligible: !!r, reasons: [] };
-        __accEligCache.set(node, r);
-        return r;
+  const __accEligCache = new WeakMap();
+  function accEligibleCached(node) {
+    if (!isAccTreeEligible) return { eligible: true, reasons: [] };
+    if (!node || typeof node !== 'object') return { eligible: true, reasons: [] };
+    const c = __accEligCache.get(node);
+    if (c) return c;
+    let r;
+    try {
+      r = isAccTreeEligible(node, ctx);
+    } catch {
+      r = { eligible: true, reasons: [] };
     }
+    r = r && typeof r === 'object' ? r : { eligible: !!r, reasons: [] };
+    __accEligCache.set(node, r);
+    return r;
+  }
 
-// --- image-map semantics (rule-local; match automatic <area> applicability) ---
-function normUsemap(val) {
+  // --- image-map semantics (rule-local; match automatic <area> applicability) ---
+  function normUsemap(val) {
     try {
-        const t = String(val || '').trim();
-        if (!t) return '';
-        return (t[0] === '#') ? t.slice(1).trim().toLowerCase() : t.toLowerCase();
-    } catch { return ''; }
-}
-function getMapName(mapEl) {
+      const t = String(val || '').trim();
+      if (!t) return '';
+      return t[0] === '#' ? t.slice(1).trim().toLowerCase() : t.toLowerCase();
+    } catch {
+      return '';
+    }
+  }
+  function getMapName(mapEl) {
     try {
-        if (!mapEl || !mapEl.getAttribute) return '';
-        const n = String(mapEl.getAttribute('name') || mapEl.getAttribute('id') || '').trim();
-        return n ? n.toLowerCase() : '';
-    } catch { return ''; }
-}
+      if (!mapEl || !mapEl.getAttribute) return '';
+      const n = String(mapEl.getAttribute('name') || mapEl.getAttribute('id') || '').trim();
+      return n ? n.toLowerCase() : '';
+    } catch {
+      return '';
+    }
+  }
 
-    const getFocusableInfo = helpers && typeof helpers.getFocusableInfo === 'function'
-        ? helpers.getFocusableInfo
-        : null;
-
-    function isRolePresentationExcluded(el) {
-        const role = (() => {
-            try { return String(el.getAttribute('role') || '').trim().toLowerCase(); }
-            catch { return ''; }
-        })();
-        if (role !== 'presentation' && role !== 'none') return false;
-
-        // Exclude only when NOT focusable (mirrors img-alt-present policy)
-        let focusable = false;
-        if (getFocusableInfo) {
-            const fi = (() => { try { return getFocusableInfo(el, ctx); } catch { return null; } })();
-            focusable = !!(fi && fi.focusable);
-        } else {
-            const tabindex = el.getAttribute('tabindex');
-            focusable = tabindex != null && String(tabindex).trim() !== '' && !Number.isNaN(Number(String(tabindex).trim()));
+  const getFocusableInfo =
+    helpers && typeof helpers.getFocusableInfo === 'function' ? helpers.getFocusableInfo : null;
+
+  function isRolePresentationExcluded(el) {
+    const role = (() => {
+      try {
+        return String(el.getAttribute('role') || '')
+          .trim()
+          .toLowerCase();
+      } catch {
+        return '';
+      }
+    })();
+    if (role !== 'presentation' && role !== 'none') return false;
+
+    // Exclude only when NOT focusable (mirrors img-alt-present policy)
+    let focusable;
+    if (getFocusableInfo) {
+      const fi = (() => {
+        try {
+          return getFocusableInfo(el, ctx);
+        } catch {
+          return null;
         }
-        return !focusable;
+      })();
+      focusable = !!(fi && fi.focusable);
+    } else {
+      const tabindex = el.getAttribute('tabindex');
+      focusable =
+        tabindex != null &&
+        String(tabindex).trim() !== '' &&
+        !Number.isNaN(Number(String(tabindex).trim()));
     }
+    return !focusable;
+  }
 
+  const els = (() => {
+    try {
+      return Array.from((queryAllSmart ? queryAllSmart('area') : queryAll('area')) || []);
+    } catch {
+      return queryAll('area');
+    }
+  })();
 
-    const els = (() => {
-        try { return Array.from((queryAllSmart ? queryAllSmart('area') : queryAll('area')) || []); }
-        catch { return queryAll('area'); }
-    })();
+  if (!els.length) {
+    return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };
+  }
+
+  const occurrences = [];
+  let applicableCount = 0;
 
-    if (!els.length) {
-        return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };
+  const __usemapIndex = new Map(); // mapName -> img (first in document order)
+  try {
+    const imgs = Array.from(document.querySelectorAll('img[usemap]'));
+    for (const img of imgs) {
+      const u = normUsemap(img.getAttribute('usemap'));
+      if (!u) continue;
+      if (!__usemapIndex.has(u)) __usemapIndex.set(u, img);
     }
+  } catch {}
 
-    const occurrences = [];
-    let applicableCount = 0;
+  for (const el of els) {
+    if (!el || !el.getAttribute) continue;
 
-    const __usemapIndex = new Map(); // mapName -> img (first in document order)
+    // Must belong to a *used* image map (referenced by an <img usemap>). If unused, not applicable.
+    let img;
     try {
-        const imgs = Array.from(document.querySelectorAll('img[usemap]'));
-        for (const img of imgs) {
-            const u = normUsemap(img.getAttribute('usemap'));
-            if (!u) continue;
-            if (!__usemapIndex.has(u)) __usemapIndex.set(u, img);
-        }
-    } catch {}
+      const map = el.closest && el.closest('map');
+      const mapName = map ? getMapName(map) : '';
+      img = mapName ? __usemapIndex.get(mapName) || null : null;
+    } catch {
+      img = null;
+    }
+    if (!img) continue;
 
-    for (const el of els) {
-        if (!el || !el.getAttribute) continue;
+    // The referencing <img> must be eligible in the accessibility tree.
+    if (isAccTreeEligible) {
+      const imgElig = accEligibleCached(img);
+      if (imgElig && imgElig.eligible === false) continue;
+    }
 
-// Must belong to a *used* image map (referenced by an <img usemap>). If unused, not applicable.
-        let img = null;
-        try {
-            const map = el.closest && el.closest('map');
-            const mapName = map ? getMapName(map) : '';
-            img = mapName ? (__usemapIndex.get(mapName) || null) : null;
-        } catch {
-            img = null;
-        }
-        if (!img) continue;
+    if (isAccTreeEligible) {
+      const elig = accEligibleCached(el);
+      if (elig && elig.eligible === false) continue;
+    }
 
-// The referencing <img> must be eligible in the accessibility tree.
-if (isAccTreeEligible) {
-    const imgElig = accEligibleCached(img);
-    if (imgElig && imgElig.eligible === false) continue;
-}
+    if (isRolePresentationExcluded(el)) continue;
 
-        if (isAccTreeEligible) {
-            const elig = accEligibleCached(el);
-            if (elig && elig.eligible === false) continue;
-        }
+    // Rule-specific applicability (only elements that already have a text alternative mechanism)
+    let alt;
+    try {
+      alt = el.getAttribute('alt');
+    } catch {
+      alt = null;
+    }
+    if (alt === null) continue;
+    if (String(alt).trim() === '') continue; // only non-empty alt is applicable here
 
-        if (isRolePresentationExcluded(el)) continue;
-
-        // Rule-specific applicability (only elements that already have a text alternative mechanism)
-        let alt = null;
-        try { alt = el.getAttribute('alt'); } catch { alt = null; }
-        if (alt === null) continue;
-        if (String(alt).trim() === '') continue; // only non-empty alt is applicable here
-
-        applicableCount += 1;
-
-        const eligInfo = getEligibilityInfo ? getEligibilityInfo(el, ctx, { targetSet: 'acc' }) : null;
-
-        let altVal = '';
-        try { altVal = String(el.getAttribute('alt') || ''); } catch { altVal = ''; }
-
-        const baseOccurrence = {
-            summary: 'Review alt text on <area> for accuracy and appropriateness.',
-            hint: 'Ensure the alt text identifies the destination/action of the image map area in context.',
-            i18n: {
-                summaryKey: 'area_altQuality_summary_cantTell',
-                hintKey: 'area_altQuality_hint_cantTell',
-                params: { element: (el.tagName || '').toLowerCase() }
-            },
-            data: {
-                visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] },
-                details: { alt: altVal.trim() } // optional but useful for manual review
-            }
-        };
+    applicableCount += 1;
 
-        if (helpers && typeof helpers.reportOccurrence === 'function') {
-            occurrences.push(helpers.reportOccurrence(el, baseOccurrence));
-        } else {
-            occurrences.push({ selector: '', html: '', ...baseOccurrence });
-        }
+    const eligInfo = getEligibilityInfo ? getEligibilityInfo(el, ctx, { targetSet: 'acc' }) : null;
+
+    let altVal;
+    try {
+      altVal = String(el.getAttribute('alt') || '');
+    } catch {
+      altVal = '';
     }
 
-    if (applicableCount === 0) {
-        return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };
+    const baseOccurrence = {
+      summary: 'Review alt text on <area> for accuracy and appropriateness.',
+      hint: 'Ensure the alt text identifies the destination/action of the image map area in context.',
+      i18n: {
+        summaryKey: 'area_altQuality_summary_cantTell',
+        hintKey: 'area_altQuality_hint_cantTell',
+        params: { element: (el.tagName || '').toLowerCase() }
+      },
+      data: {
+        visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] },
+        details: { alt: altVal.trim() } // optional but useful for manual review
+      }
+    };
+
+    if (helpers && typeof helpers.reportOccurrence === 'function') {
+      occurrences.push(helpers.reportOccurrence(el, baseOccurrence));
+    } else {
+      occurrences.push({ selector: '', html: '', ...baseOccurrence });
     }
+  }
+
+  if (applicableCount === 0) {
+    return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };
+  }
 
-    return { ruleId: rule.ruleId, outcome: 'cantTell', severity: 'minor', occurrences };
+  return { ruleId: rule.ruleId, outcome: 'cantTell', severity: 'minor', occurrences };
 }
 
 module.exports = { id, meta, runInPage };

package/src/checks/manual/aria-checked-state-mismatch-manual.js

@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: MPL-2.0 */
+
 'use strict';
 
 /**
@@ -14,34 +16,23 @@
  *   checked state is already exposed natively), but when an author sets
  *   it explicitly it should agree with the element's actual state —
  *   otherwise assistive technology is told something different from what
- *   a sighted user perceives. This is the same static/live-DOM check
- *   a widely-used reference engine's own `aria-conditional-attr` rule
- *   performs (verified directly against its `ariaConditionalCheckboxAttr`/
- *   `ariaConditionalRadioAttr` source).
+ *   a sighted user perceives.
  * @implementation-notes
  * - Deliberately authored as `type: 'manual'` (cantTell-capped, never
- *   fail), unlike most ARIA-validity rules in this file family. That
- *   reference engine runs as a script injected into the LIVE, already-hydrated DOM, so a
- *   mismatch it reports is a genuine, current-state fact. This engine
- *   analyzes STATIC markup only (no script execution) — `.checked`
+ *   fail), unlike most ARIA-validity rules in this file family. This
+ *   engine analyzes STATIC markup only (no script execution) — `.checked`
  *   reliably reflects the static `checked` attribute for freshly-parsed
- *   markup (verified directly against jsdom), but a very common, entirely
- *   legitimate real-world pattern is a JS-hydrated widget whose
- *   server-rendered HTML intentionally ships `aria-checked="true"` (or
- *   `"mixed"`) BEFORE client JS sets the native `checked`/`indeterminate`
- *   property to match on hydration. A hard `fail` here would misfire on
- *   that pattern constantly — real risk given how common it is in exactly
- *   the kind of JS-framework-heavy pages this engine's own real-world
- *   corpus is full of. Flagging for human review (cantTell) captures the
- *   same signal without the false-positive risk of asserting it as a
- *   confirmed violation.
+ *   markup, but a very common, entirely legitimate real-world pattern is a
+ *   JS-hydrated widget whose server-rendered HTML intentionally ships
+ *   `aria-checked="true"` (or `"mixed"`) BEFORE client JS sets the native
+ *   `checked`/`indeterminate` property to match on hydration. A hard
+ *   `fail` here would misfire on that pattern constantly. Flagging for
+ *   human review (cantTell) captures the same signal without the
+ *   false-positive risk of asserting it as a confirmed violation.
  * - `aria-checked="mixed"` is only meaningful for checkboxes (radio
- *   buttons have no indeterminate state) — matches that reference engine's
- *   own `normalizeAriaChecked` (radio) vs `normalizeAriaChecked2` (checkbox)
- *   split, verified directly against its source.
+ *   buttons have no indeterminate state).
  * - Any `aria-checked` value other than "true"/"false"/"mixed" (checkbox)
- *   or "true"/"false" (radio) is treated as equivalent to "false" — also
- *   matches that reference engine's own normalization exactly.
+ *   or "true"/"false" (radio) is treated as equivalent to "false".
  * - Not rule-gated on isAccTreeEligible: whether the accessible state
  *   matches is still a markup-correctness property, while engine-level
  *   hidden-subtree filtering applies unless engineOptions.includeHiddenElements
@@ -52,7 +43,8 @@ const id = 'aria-checked-state-mismatch';
 
 const meta = {
   title: 'Native checkbox/radio aria-checked should match its actual state',
-  description: 'Flags a native <input type="checkbox">/<input type="radio"> whose explicit aria-checked value disagrees with its actual checked/indeterminate state, for manual review.',
+  description:
+    'Flags a native <input type="checkbox">/<input type="radio"> whose explicit aria-checked value disagrees with its actual checked/indeterminate state, for manual review.',
   i18n: {
     titleKey: 'ariaCheckedStateMismatch_title',
     descriptionKey: 'ariaCheckedStateMismatch_description'
@@ -61,7 +53,13 @@ const meta = {
   tags: ['wcag2a', 'wcag412', 'aria', 'forms', 'atomic', 'manual'],
   wcagSc: ['4.1.2'],
   normativeMappings: [
-    { standard: 'WCAG', version: '2.2', requirement: '4.1.2', title: 'Name, Role, Value', conformanceLevel: 'A' }
+    {
+      standard: 'WCAG',
+      version: '2.2',
+      requirement: '4.1.2',
+      title: 'Name, Role, Value',
+      conformanceLevel: 'A'
+    }
   ],
   defaultSeverity: 'moderate',
   category: 'robust',
@@ -71,12 +69,16 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, helpers, rule } = ctx;
+  const { helpers, rule } = ctx;
 
-  function trim(v) { return (v == null ? '' : String(v)).trim(); }
+  function trim(v) {
+    return (v == null ? '' : String(v)).trim();
+  }
 
   const nodes = helpers.queryAllSmart
-    ? helpers.queryAllSmart('input[type="checkbox"][aria-checked], input[type="radio"][aria-checked]')
+    ? helpers.queryAllSmart(
+        'input[type="checkbox"][aria-checked], input[type="radio"][aria-checked]'
+      )
     : helpers.queryAll('input[type="checkbox"][aria-checked], input[type="radio"][aria-checked]');
 
   const occurrences = [];
@@ -97,9 +99,10 @@ function runInPage(ctx) {
 
     let normalizedAriaChecked;
     if (isCheckbox) {
-      normalizedAriaChecked = (rawAriaChecked === 'mixed' || rawAriaChecked === 'true') ? rawAriaChecked : 'false';
+      normalizedAriaChecked =
+        rawAriaChecked === 'mixed' || rawAriaChecked === 'true' ? rawAriaChecked : 'false';
     } else {
-      normalizedAriaChecked = (rawAriaChecked === 'true') ? 'true' : 'false';
+      normalizedAriaChecked = rawAriaChecked === 'true' ? 'true' : 'false';
     }
 
     let actualState;
@@ -112,12 +115,13 @@ function runInPage(ctx) {
     if (normalizedAriaChecked === actualState) continue;
 
     const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : (el.outerHTML || '');
+    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
 
     occurrences.push({
       selector: stableSelector,
       html,
-      summary: 'This element’s aria-checked value does not match its actual checked/indeterminate state.',
+      summary:
+        'This element’s aria-checked value does not match its actual checked/indeterminate state.',
       hint: 'Set aria-checked to match the element’s real state, or remove it — a native checkbox/radio already exposes this state without it.',
       i18n: {
         summaryKey: 'ariaCheckedStateMismatch_summary_cantTell',
@@ -125,7 +129,12 @@ function runInPage(ctx) {
         params: { ariaChecked: normalizedAriaChecked, actualState, type }
       },
       data: {
-        details: { reasonCode: 'ARIA_CHECKED_STATE_MISMATCH', ariaChecked: normalizedAriaChecked, actualState, type }
+        details: {
+          reasonCode: 'ARIA_CHECKED_STATE_MISMATCH',
+          ariaChecked: normalizedAriaChecked,
+          actualState,
+          type
+        }
       }
     });
   }
@@ -134,7 +143,12 @@ function runInPage(ctx) {
     return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };
   }
   if (occurrences.length) {
-    return { ruleId: rule.ruleId, outcome: 'cantTell', severity: rule.defaultSeverity || 'moderate', occurrences };
+    return {
+      ruleId: rule.ruleId,
+      outcome: 'cantTell',
+      severity: rule.defaultSeverity || 'moderate',
+      occurrences
+    };
   }
   return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };
 }

package/src/checks/manual/aria-text-manual.js

@@ -1,10 +1,12 @@
+/* SPDX-License-Identifier: MPL-2.0 */
+
 'use strict';
 
 /**
  * @check aria-text
  * @atomic true
  * @summary role="text" elements should have no focusable descendants
- * @standard Best Practices (a widely-used reference engine's classification; no formal WCAG Success Criterion — see ROADMAP.md Tier 1b)
+ * @standard Best Practices (no formal WCAG Success Criterion — see ROADMAP.md Tier 1b)
  * @applicability
  *   Elements with an explicit `role="text"`.
  * @expectation
@@ -15,10 +17,9 @@
  *   focusable content — a focusable descendant inside a "this is just
  *   text" region is unreachable or confusing for keyboard/AT users.
  * @implementation-notes
- * - Not WCAG-normative by a widely-used reference engine's own classification — authored as an
- *   advisory, cantTell-capped `type: 'manual'` rule, matching the Tier 1b
- *   precedent (see `landmark-unique`'s header comment for the shared
- *   rationale).
+ * - Not WCAG-normative — authored as an advisory, cantTell-capped
+ *   `type: 'manual'` rule, matching the Tier 1b precedent (see
+ *   `landmark-unique`'s header comment for the shared rationale).
  * - "Focusable descendant" is a presence check (link/button/form
  *   control/`[tabindex]`/`iframe`/`[contenteditable]`), the same
  *   conservative selector `scrollable-region-focusable` uses, not a full
@@ -29,7 +30,8 @@ const id = 'aria-text';
 
 const meta = {
   title: 'role="text" elements should have no focusable descendants',
-  description: 'Checks that elements with role="text" contain no focusable descendant (link, button, form control, tabindex, iframe, or contenteditable).',
+  description:
+    'Checks that elements with role="text" contain no focusable descendant (link, button, form control, tabindex, iframe, or contenteditable).',
   i18n: {
     titleKey: 'ariaText_title',
     descriptionKey: 'ariaText_description'
@@ -46,12 +48,14 @@ const meta = {
 };
 
 function runInPage(ctx) {
-  const { document, helpers, rule } = ctx;
+  const { helpers, rule } = ctx;
 
   const FOCUSABLE_DESCENDANT_SELECTOR =
     'a[href], button, input, select, textarea, [tabindex], iframe, [contenteditable]:not([contenteditable="false"])';
 
-  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('[role="text"]') : helpers.queryAll('[role="text"]');
+  const nodes = helpers.queryAllSmart
+    ? helpers.queryAllSmart('[role="text"]')
+    : helpers.queryAll('[role="text"]');
 
   const occurrences = [];
   let applicableCount = 0;
@@ -61,7 +65,7 @@ function runInPage(ctx) {
 
     applicableCount += 1;
 
-    let focusableDescendant = null;
+    let focusableDescendant;
     try {
       focusableDescendant = el.querySelector(FOCUSABLE_DESCENDANT_SELECTOR);
     } catch {
@@ -70,7 +74,7 @@ function runInPage(ctx) {
     if (!focusableDescendant) continue;
 
     const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : (el.outerHTML || '');
+    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
 
     const baseOccurrence = {
       selector: stableSelector,
@@ -99,7 +103,12 @@ function runInPage(ctx) {
   }
 
   if (occurrences.length) {
-    return { ruleId: rule.ruleId, outcome: 'cantTell', severity: rule.defaultSeverity || 'minor', occurrences };
+    return {
+      ruleId: rule.ruleId,
+      outcome: 'cantTell',
+      severity: rule.defaultSeverity || 'minor',
+      occurrences
+    };
   }
 
   return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };