@surea11y/core 1.2.0 → 1.4.0

package/src/checks/manual/embed-text-alternative-quality-manual.js

@@ -1,3 +1,5 @@
+/* SPDX-License-Identifier: MPL-2.0 */
+
 'use strict';
 
 /**
@@ -11,194 +13,208 @@
  *   Human review is required to confirm that the provided text alternative is accurate and appropriate.
  */
 
-const id = "embed-text-alternative-quality";
+const id = 'embed-text-alternative-quality';
 
 const meta = {
-    title: "<embed> text alternative must be appropriate (manual review)",
-    description: "Flags <embed> elements with a detected name for human review of appropriateness.",
-    i18n: {
-        titleKey: "embed_textAltQuality_title",
-        descriptionKey: "embed_textAltQuality_description"
-    },
-    helpUrl: null,
-    tags: ["wcag2a", "wcag111", "nontext", "embed", "manual", "atomic"],
-    wcagSc: ['1.1.1'],
-    normativeMappings: [
-        {standard: 'WCAG', version: '2.2', requirement: '1.1.1', title: 'Non-text Content', conformanceLevel: 'A'}
-    ],
-    defaultSeverity: 'minor',
-    category: 'perceivable',
-    type: 'manual',
-    defaultConfidence: 'medium',
-    coverage: {
-        facetsBySc: {
-            '1.1.1': ['text-alternative-quality']
-        }
+  title: '<embed> text alternative must be appropriate (manual review)',
+  description: 'Flags <embed> elements with a detected name for human review of appropriateness.',
+  i18n: {
+    titleKey: 'embed_textAltQuality_title',
+    descriptionKey: 'embed_textAltQuality_description'
+  },
+  helpUrl: null,
+  tags: ['wcag2a', 'wcag111', 'nontext', 'embed', 'manual', 'atomic'],
+  wcagSc: ['1.1.1'],
+  normativeMappings: [
+    {
+      standard: 'WCAG',
+      version: '2.2',
+      requirement: '1.1.1',
+      title: 'Non-text Content',
+      conformanceLevel: 'A'
+    }
+  ],
+  defaultSeverity: 'minor',
+  category: 'perceivable',
+  type: 'manual',
+  defaultConfidence: 'medium',
+  coverage: {
+    facetsBySc: {
+      '1.1.1': ['text-alternative-quality']
     }
+  }
 };
 
 function runInPage(ctx) {
-    const {document, root, helpers, rule} = ctx;
-    const safeRoot = root || document;
-
-    const trim = (v) => (v == null ? '' : String(v)).trim();
-    const getTextFromIdRefs =
-        helpers && typeof helpers.getTextFromIdRefs === 'function' ? helpers.getTextFromIdRefs : null;
-
-    const queryAllSmart = helpers && typeof helpers.queryAllSmart === 'function' ? helpers.queryAllSmart : null;
-    const queryAll = helpers && typeof helpers.queryAll === 'function'
-        ? helpers.queryAll
-        : (sel) => {
-            try {
-                return safeRoot && safeRoot.querySelectorAll ? Array.from(safeRoot.querySelectorAll(sel)) : [];
-            } catch {
-                return [];
-            }
+  const { document, root, helpers, rule } = ctx;
+  const safeRoot = root || document;
+
+  const trim = (v) => (v == null ? '' : String(v)).trim();
+  const getTextFromIdRefs =
+    helpers && typeof helpers.getTextFromIdRefs === 'function' ? helpers.getTextFromIdRefs : null;
+
+  const queryAllSmart =
+    helpers && typeof helpers.queryAllSmart === 'function' ? helpers.queryAllSmart : null;
+  const queryAll =
+    helpers && typeof helpers.queryAll === 'function'
+      ? helpers.queryAll
+      : (sel) => {
+          try {
+            return safeRoot && safeRoot.querySelectorAll
+              ? Array.from(safeRoot.querySelectorAll(sel))
+              : [];
+          } catch {
+            return [];
+          }
         };
 
-    const getEligibilityInfo = helpers && typeof helpers.getEligibilityInfo === 'function'
-        ? helpers.getEligibilityInfo
-        : null;
-
-    const isAccTreeEligible = helpers && typeof helpers.isAccTreeEligible === 'function'
-        ? helpers.isAccTreeEligible
-        : null;
-
-    const getFocusableInfo = helpers && typeof helpers.getFocusableInfo === 'function'
-        ? helpers.getFocusableInfo
-        : null;
-
-    function isRolePresentationExcluded(el) {
-        const role = (() => {
-            try {
-                return String(el.getAttribute('role') || '').trim().toLowerCase();
-            } catch {
-                return '';
-            }
-        })();
-        if (role !== 'presentation' && role !== 'none') return false;
-
-        // Exclude only when NOT focusable (mirrors img-alt-present policy)
-        let focusable = false;
-        if (getFocusableInfo) {
-            const fi = (() => {
-                try {
-                    return getFocusableInfo(el, ctx);
-                } catch {
-                    return null;
-                }
-            })();
-            focusable = !!(fi && fi.focusable);
-        } else {
-            const tabindex = el.getAttribute('tabindex');
-            focusable = tabindex != null && String(tabindex).trim() !== '' && !Number.isNaN(Number(String(tabindex).trim()));
-        }
-        return !focusable;
-    }
+  const getEligibilityInfo =
+    helpers && typeof helpers.getEligibilityInfo === 'function' ? helpers.getEligibilityInfo : null;
+
+  const isAccTreeEligible =
+    helpers && typeof helpers.isAccTreeEligible === 'function' ? helpers.isAccTreeEligible : null;
 
+  const getFocusableInfo =
+    helpers && typeof helpers.getFocusableInfo === 'function' ? helpers.getFocusableInfo : null;
 
-    const els = (() => {
+  function isRolePresentationExcluded(el) {
+    const role = (() => {
+      try {
+        return String(el.getAttribute('role') || '')
+          .trim()
+          .toLowerCase();
+      } catch {
+        return '';
+      }
+    })();
+    if (role !== 'presentation' && role !== 'none') return false;
+
+    // Exclude only when NOT focusable (mirrors img-alt-present policy)
+    let focusable;
+    if (getFocusableInfo) {
+      const fi = (() => {
         try {
-            return Array.from((queryAllSmart ? queryAllSmart('embed') : queryAll('embed')) || []);
+          return getFocusableInfo(el, ctx);
         } catch {
-            return queryAll('embed');
+          return null;
         }
-    })();
-
-    if (!els.length) {
-        return {ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: []};
+      })();
+      focusable = !!(fi && fi.focusable);
+    } else {
+      const tabindex = el.getAttribute('tabindex');
+      focusable =
+        tabindex != null &&
+        String(tabindex).trim() !== '' &&
+        !Number.isNaN(Number(String(tabindex).trim()));
+    }
+    return !focusable;
+  }
+
+  const els = (() => {
+    try {
+      return Array.from((queryAllSmart ? queryAllSmart('embed') : queryAll('embed')) || []);
+    } catch {
+      return queryAll('embed');
     }
+  })();
 
-    const occurrences = [];
-    let applicableCount = 0;
-
-    for (const el of els) {
-        if (!el || !el.getAttribute) continue;
-
-        if (isAccTreeEligible) {
-            const elig = (() => {
-                try {
-                    return isAccTreeEligible(el, ctx);
-                } catch {
-                    return {eligible: true, reasons: []};
-                }
-            })();
-            if (elig && elig.eligible === false) continue;
-        }
+  if (!els.length) {
+    return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };
+  }
+
+  const occurrences = [];
+  let applicableCount = 0;
 
-        if (isRolePresentationExcluded(el)) continue;
+  for (const el of els) {
+    if (!el || !el.getAttribute) continue;
 
-        let ariaLabel = '';
-        let ariaLabelledBy = '';
-        let title = '';
+    if (isAccTreeEligible) {
+      const elig = (() => {
         try {
-            ariaLabel = trim(el.getAttribute('aria-label'));
-            ariaLabelledBy = trim(el.getAttribute('aria-labelledby'));
-            title = trim(el.getAttribute('title'));
+          return isAccTreeEligible(el, ctx);
         } catch {
-            ariaLabel = '';
-            ariaLabelledBy = '';
-            title = '';
-        }
-
-        // Only resolve IDREF text if aria-labelledby is present and aria-label is not already sufficient
-        let labelledByText = '';
-        let hasLabelledByMechanism = false;
-
-        if (!ariaLabel && ariaLabelledBy) {
-            hasLabelledByMechanism = true;
-
-            if (getTextFromIdRefs) {
-                try {
-                    const t = getTextFromIdRefs(ariaLabelledBy, ctx);
-                    labelledByText = trim(t && t.text);
-                    // If it resolves to empty, still treat as a mechanism present for manual review.
-                } catch {
-                    labelledByText = '';
-                }
-            }
+          return { eligible: true, reasons: [] };
         }
+      })();
+      if (elig && elig.eligible === false) continue;
+    }
 
-        const hasNameMechanism = !!(ariaLabel || title || hasLabelledByMechanism);
-        if (!hasNameMechanism) continue;
-
-        const details = {
-            ariaLabel: ariaLabel || null,
-            ariaLabelledBy: ariaLabelledBy || null,
-            ariaLabelledByText: labelledByText || null,
-            title: title || null
-        };
+    if (isRolePresentationExcluded(el)) continue;
+
+    let ariaLabel;
+    let ariaLabelledBy;
+    let title;
+    try {
+      ariaLabel = trim(el.getAttribute('aria-label'));
+      ariaLabelledBy = trim(el.getAttribute('aria-labelledby'));
+      title = trim(el.getAttribute('title'));
+    } catch {
+      ariaLabel = '';
+      ariaLabelledBy = '';
+      title = '';
+    }
 
-        applicableCount += 1;
-
-        const eligInfo = getEligibilityInfo ? getEligibilityInfo(el, ctx, {targetSet: 'acc'}) : null;
-
-        const baseOccurrence = {
-            summary: 'Review text alternative for <embed> for accuracy and appropriateness.',
-            hint: 'Confirm the ARIA name or title accurately identifies the embedded content in context.',
-            i18n: {
-                summaryKey: 'embed_textAltQuality_summary_cantTell',
-                hintKey: 'embed_textAltQuality_hint_cantTell',
-                params: {element: (el.tagName || '').toLowerCase()}
-            },
-            data: {
-                visibilityFilter: eligInfo || {targetSet: 'acc', accEligible: null, reasons: []},
-                details
-            }
-        };
+    // Only resolve IDREF text if aria-labelledby is present and aria-label is not already sufficient
+    let labelledByText = '';
 
-        if (helpers && typeof helpers.reportOccurrence === 'function') {
-            occurrences.push(helpers.reportOccurrence(el, baseOccurrence));
-        } else {
-            occurrences.push({selector: '', html: '', ...baseOccurrence});
-        }
+    if (!ariaLabel && ariaLabelledBy && getTextFromIdRefs) {
+      try {
+        const t = getTextFromIdRefs(ariaLabelledBy, ctx);
+        labelledByText = trim(t && t.text);
+      } catch {
+        labelledByText = '';
+      }
     }
 
-    if (applicableCount === 0) {
-        return {ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: []};
+    // A broken/empty-resolving aria-labelledby (e.g. pointing at a
+    // nonexistent id) is not a "detected" text alternative to review the
+    // QUALITY of -- there's no text here at all, and this element's
+    // sibling automatic rule (embed-text-alternative-present) already
+    // reports it as a fail (no accessible name). Like object-/svg-/
+    // canvas-text-alternative-quality-manual, require aria-labelledby to
+    // actually resolve to non-empty text rather than merely being present
+    // as an attribute; a present-but-broken aria-labelledby has no text
+    // alternative to review.
+    const hasNameMechanism = !!(ariaLabel || title || labelledByText);
+    if (!hasNameMechanism) continue;
+
+    const details = {
+      ariaLabel: ariaLabel || null,
+      ariaLabelledBy: ariaLabelledBy || null,
+      ariaLabelledByText: labelledByText || null,
+      title: title || null
+    };
+
+    applicableCount += 1;
+
+    const eligInfo = getEligibilityInfo ? getEligibilityInfo(el, ctx, { targetSet: 'acc' }) : null;
+
+    const baseOccurrence = {
+      summary: 'Review text alternative for <embed> for accuracy and appropriateness.',
+      hint: 'Confirm the ARIA name or title accurately identifies the embedded content in context.',
+      i18n: {
+        summaryKey: 'embed_textAltQuality_summary_cantTell',
+        hintKey: 'embed_textAltQuality_hint_cantTell',
+        params: { element: (el.tagName || '').toLowerCase() }
+      },
+      data: {
+        visibilityFilter: eligInfo || { targetSet: 'acc', accEligible: null, reasons: [] },
+        details
+      }
+    };
+
+    if (helpers && typeof helpers.reportOccurrence === 'function') {
+      occurrences.push(helpers.reportOccurrence(el, baseOccurrence));
+    } else {
+      occurrences.push({ selector: '', html: '', ...baseOccurrence });
     }
+  }
+
+  if (applicableCount === 0) {
+    return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };
+  }
 
-    return {ruleId: rule.ruleId, outcome: 'cantTell', severity: 'minor', occurrences};
+  return { ruleId: rule.ruleId, outcome: 'cantTell', severity: 'minor', occurrences };
 }
 
-module.exports = {id, meta, runInPage};
+module.exports = { id, meta, runInPage };

package/src/checks/manual/empty-heading-manual.js

@@ -1,10 +1,12 @@
+/* SPDX-License-Identifier: MPL-2.0 */
+
 'use strict';
 
 /**
  * @check empty-heading
  * @atomic true
  * @summary Heading elements must not be empty
- * @standard Best Practices (a widely-used reference engine's classification; no formal WCAG Success Criterion — see ROADMAP.md Tier 1b)
+ * @standard Best Practices (no formal WCAG Success Criterion — see ROADMAP.md Tier 1b)
  * @applicability
  *   Applies to elements with a heading role: native <h1>-<h6>, or any
  *   element with explicit role="heading" (unless overridden by another
@@ -19,30 +21,29 @@
  * - Not WCAG-normative — authored as an advisory, cantTell-capped
  *   `type: 'manual'` rule; see landmark-banner-is-top-level's
  *   header comment for the shared rationale/precedent.
- * - This is also the reconciliation point for the "heading-name-present"
- *   gap surfaced by the 2026-07-19 ACT-rules research pass (see
- *   ROADMAP.md "Tier 5 candidates"): that gap was already closed by this
- *   pre-existing rule under a different name, not a real gap. Fixed two
- *   real false-positive bugs found while confirming that (2026-07-19):
- *   `title` wasn't accepted as a naming fallback, and hidden/aria-hidden/
- *   display:none headings weren't excluded (not gated on
- *   `isAccTreeEligible`), so an empty heading no AT user could ever
- *   reach was still flagged.
- * - 2026-07-21: the subtree-text walker's own hand-rolled descendant
- *   handling (aria-label/aria-labelledby only) never checked an `<img>`
- *   descendant's `alt` text — found via Party City's
- *   `<h1><a><div><img alt="..."></div></a></h1>` logo header, a false
- *   "empty heading" cantTell. Replaced with the shared, accname-aligned
+ * - This is also the reconciliation point for the ACT-rules
+ *   "heading-name-present" requirement (see ROADMAP.md "Tier 5
+ *   candidates"): already covered by this pre-existing rule under a
+ *   different name, not a separate gap. `title` is accepted as a naming
+ *   fallback, and hidden/aria-hidden/display:none headings are excluded
+ *   (gated on `isAccTreeEligible`), so an empty heading no AT user could
+ *   ever reach is not flagged.
+ * - Descendant name resolution uses the shared, accname-aligned
  *   `helpers.getContentNameInfo` (see dom-helpers.js) — the same "name
- *   from content" implementation the 19 `-name-present` rules already use
- *   — instead of maintaining a third, narrower copy of this logic here.
+ *   from content" implementation the 19 `-name-present` rules already
+ *   use — rather than a narrower hand-rolled walker, so an `<img alt="...">`
+ *   descendant's alt text (e.g. a
+ *   `<h1><a><div><img alt="..."></div></a></h1>` logo header) is correctly
+ *   picked up as the heading's name instead of producing a false "empty
+ *   heading" cantTell.
  */
 
 const id = 'empty-heading';
 
 const meta = {
   title: 'Headings must not be empty',
-  description: 'Checks that heading elements (<h1>-<h6> or role="heading") have a non-empty accessible name.',
+  description:
+    'Checks that heading elements (<h1>-<h6> or role="heading") have a non-empty accessible name.',
   i18n: {
     titleKey: 'emptyHeading_title',
     descriptionKey: 'emptyHeading_description'
@@ -62,7 +63,9 @@ function runInPage(ctx) {
   const { document, helpers, rule } = ctx;
 
   function normalizeWs(s) {
-    return String(s || '').replace(/\s+/g, ' ').trim();
+    return String(s || '')
+      .replace(/\s+/g, ' ')
+      .trim();
   }
 
   function getExplicitRoleToken(el) {
@@ -112,13 +115,16 @@ function runInPage(ctx) {
     return normalizeWs(el.getAttribute && el.getAttribute('title'));
   }
 
-  const nodes = helpers.queryAllSmart ? helpers.queryAllSmart('h1, h2, h3, h4, h5, h6, [role]') : helpers.queryAll('h1, h2, h3, h4, h5, h6, [role]');
+  const nodes = helpers.queryAllSmart
+    ? helpers.queryAllSmart('h1, h2, h3, h4, h5, h6, [role]')
+    : helpers.queryAll('h1, h2, h3, h4, h5, h6, [role]');
 
   const occurrences = [];
   let applicableCount = 0;
   const seen = new Set();
 
-  const isAccTreeEligible = helpers && typeof helpers.isAccTreeEligible === 'function' ? helpers.isAccTreeEligible : null;
+  const isAccTreeEligible =
+    helpers && typeof helpers.isAccTreeEligible === 'function' ? helpers.isAccTreeEligible : null;
 
   function isEligible(el) {
     if (!isAccTreeEligible) return true;
@@ -143,9 +149,15 @@ function runInPage(ctx) {
     if (name) continue;
 
     const stableSelector = helpers.buildSelector ? helpers.buildSelector(el) : 'html';
-    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : (el.outerHTML || '');
+    const html = helpers.getOuterHtmlSnippet ? helpers.getOuterHtmlSnippet(el) : el.outerHTML || '';
     const eligInfo = helpers.getEligibilityInfo
-      ? (() => { try { return helpers.getEligibilityInfo(el, ctx, { targetSet: 'acc' }); } catch { return null; } })()
+      ? (() => {
+          try {
+            return helpers.getEligibilityInfo(el, ctx, { targetSet: 'acc' });
+          } catch {
+            return null;
+          }
+        })()
       : null;
 
     occurrences.push({
@@ -169,7 +181,12 @@ function runInPage(ctx) {
     return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };
   }
   if (occurrences.length) {
-    return { ruleId: rule.ruleId, outcome: 'cantTell', severity: rule.defaultSeverity || 'minor', occurrences };
+    return {
+      ruleId: rule.ruleId,
+      outcome: 'cantTell',
+      severity: rule.defaultSeverity || 'minor',
+      occurrences
+    };
   }
   return { ruleId: rule.ruleId, outcome: 'notApplicable', severity: 'minor', occurrences: [] };
 }