@sovovs/bycli 1.8.0 → 2.1.0

package/clis/twitter/likes.test.js

@@ -1,220 +0,0 @@
-import { describe, expect, it, vi } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import { ArgumentError, AuthRequiredError, EmptyResultError } from '@sovovs/bycli/errors';
-import { __test__ } from './likes.js';
-
-function likesPayload() {
-    return {
-        data: {
-            user: {
-                result: {
-                    timeline_v2: {
-                        timeline: {
-                            instructions: [{
-                                entries: [{
-                                    entryId: 'tweet-1',
-                                    content: {
-                                        itemContent: {
-                                            tweet_results: {
-                                                result: {
-                                                    rest_id: '1',
-                                                    legacy: {
-                                                        full_text: 'liked post',
-                                                        favorite_count: 7,
-                                                        retweet_count: 2,
-                                                        created_at: 'now',
-                                                    },
-                                                    core: {
-                                                        user_results: {
-                                                            result: {
-                                                                legacy: { screen_name: 'alice', name: 'Alice' },
-                                                            },
-                                                        },
-                                                    },
-                                                },
-                                            },
-                                        },
-                                    },
-                                }],
-                            }],
-                        },
-                    },
-                },
-            },
-        },
-    };
-}
-
-describe('twitter likes helpers', () => {
-    it('falls back when queryId contains unsafe characters', () => {
-        expect(__test__.sanitizeQueryId('safe_Query-123', 'fallback')).toBe('safe_Query-123');
-        expect(__test__.sanitizeQueryId('bad"id', 'fallback')).toBe('fallback');
-        expect(__test__.sanitizeQueryId('bad/id', 'fallback')).toBe('fallback');
-        expect(__test__.sanitizeQueryId(null, 'fallback')).toBe('fallback');
-    });
-    it('builds likes url with the provided queryId', () => {
-        const url = __test__.buildLikesUrl('query123', '42', 20, 'cursor-1');
-        expect(url).toContain('/i/api/graphql/query123/Likes');
-        expect(decodeURIComponent(url)).toContain('"userId":"42"');
-        expect(decodeURIComponent(url)).toContain('"cursor":"cursor-1"');
-    });
-    it('parses likes timeline entries and bottom cursor', () => {
-        const payload = {
-            data: {
-                user: {
-                    result: {
-                        timeline_v2: {
-                            timeline: {
-                                instructions: [
-                                    {
-                                        entries: [
-                                            {
-                                                entryId: 'tweet-1',
-                                                content: {
-                                                    itemContent: {
-                                                        tweet_results: {
-                                                            result: {
-                                                                rest_id: '1',
-                                                                legacy: {
-                                                                    full_text: 'liked post',
-                                                                    favorite_count: 7,
-                                                                    retweet_count: 2,
-                                                                    created_at: 'now',
-                                                                },
-                                                                core: {
-                                                                    user_results: {
-                                                                        result: {
-                                                                            legacy: {
-                                                                                screen_name: 'alice',
-                                                                                name: 'Alice',
-                                                                            },
-                                                                        },
-                                                                    },
-                                                                },
-                                                            },
-                                                        },
-                                                    },
-                                                },
-                                            },
-                                            {
-                                                entryId: 'cursor-bottom-1',
-                                                content: {
-                                                    entryType: 'TimelineTimelineCursor',
-                                                    cursorType: 'Bottom',
-                                                    value: 'cursor-next',
-                                                },
-                                            },
-                                        ],
-                                    },
-                                ],
-                            },
-                        },
-                    },
-                },
-            },
-        };
-        const result = __test__.parseLikes(payload, new Set());
-        expect(result.nextCursor).toBe('cursor-next');
-        expect(result.tweets).toHaveLength(1);
-        expect(result.tweets[0]).toMatchObject({
-            id: '1',
-            author: 'alice',
-            name: 'Alice',
-            text: 'liked post',
-            likes: 7,
-            retweets: 2,
-            created_at: 'now',
-            url: 'https://x.com/alice/status/1',
-        });
-    });
-});
-
-describe('twitter likes command', () => {
-    it('throws EmptyResultError with privacy message when API returns empty-timeline shape', async () => {
-        const command = getRegistry().get('twitter/likes');
-        const page = {
-            goto: vi.fn().mockResolvedValue(undefined),
-            wait: vi.fn().mockResolvedValue(undefined),
-            getCookies: vi.fn(async () => [{ name: 'ct0', value: 'token' }]),
-            evaluate: vi.fn(async (script) => {
-                const text = String(script);
-                if (text.includes('AppTabBar_Profile_Link')) return { session: 'site:twitter', data: '/viewer' };
-                if (text.includes('operationName')) return null;
-                if (text.includes('/UserByScreenName')) return { session: 'site:twitter', data: '42' };
-                if (text.includes('/Likes')) {
-                    return { session: 'site:twitter', data: { data: { user: { result: { __typename: 'User', timeline: {} } } } } };
-                }
-                throw new Error(`Unexpected evaluate: ${text.slice(0, 80)}`);
-            }),
-        };
-        await expect(command.func(page, { username: 'simonw', limit: 5 }))
-            .rejects.toMatchObject({ hint: expect.stringContaining('Likes are private by default on X') });
-        await expect(command.func(page, { username: 'simonw', limit: 5 }))
-            .rejects.toBeInstanceOf(EmptyResultError);
-    });
-});
-
-describe('twitter likes command', () => {
-    it('rejects invalid explicit username before cookies or navigation', async () => {
-        const command = getRegistry().get('twitter/likes');
-        const page = {
-            goto: vi.fn(),
-            wait: vi.fn(),
-            getCookies: vi.fn(),
-            evaluate: vi.fn(),
-        };
-
-        await expect(command.func(page, { username: 'viewer/extra', limit: 10 })).rejects.toBeInstanceOf(ArgumentError);
-        expect(page.getCookies).not.toHaveBeenCalled();
-        expect(page.goto).not.toHaveBeenCalled();
-        expect(page.evaluate).not.toHaveBeenCalled();
-    });
-
-    it('rejects route-like AppTabBar hrefs as AuthRequiredError', async () => {
-        const command = getRegistry().get('twitter/likes');
-        const page = {
-            goto: vi.fn().mockResolvedValue(undefined),
-            wait: vi.fn().mockResolvedValue(undefined),
-            getCookies: vi.fn(async () => [{ name: 'ct0', value: 'token' }]),
-            evaluate: vi.fn(async (script) => {
-                if (String(script).includes('AppTabBar_Profile_Link')) return '/home';
-                throw new Error(`Unexpected evaluate: ${String(script).slice(0, 80)}`);
-            }),
-        };
-
-        await expect(command.func(page, { limit: 10 })).rejects.toBeInstanceOf(AuthRequiredError);
-        expect(page.goto).toHaveBeenCalledWith('https://x.com/home');
-        expect(page.evaluate).toHaveBeenCalledTimes(1);
-    });
-
-    it('unwraps Browser Bridge envelopes for default-self user lookup and likes payload', async () => {
-        const command = getRegistry().get('twitter/likes');
-        const page = {
-            goto: vi.fn().mockResolvedValue(undefined),
-            wait: vi.fn().mockResolvedValue(undefined),
-            getCookies: vi.fn(async () => [{ name: 'ct0', value: 'token' }]),
-            evaluate: vi.fn(async (script) => {
-                const text = String(script);
-                if (text.includes('AppTabBar_Profile_Link')) {
-                    return { session: 'site:twitter', data: '/viewer' };
-                }
-                if (text.includes('operationName')) return null;
-                if (text.includes('/UserByScreenName')) {
-                    return { session: 'site:twitter', data: '42' };
-                }
-                if (text.includes('/Likes')) {
-                    return { session: 'site:twitter', data: likesPayload() };
-                }
-                throw new Error(`Unexpected evaluate: ${text.slice(0, 80)}`);
-            }),
-        };
-
-        const rows = await command.func(page, { limit: 1 });
-
-        expect(rows).toHaveLength(1);
-        expect(rows[0]).toMatchObject({ id: '1', author: 'alice', text: 'liked post' });
-        const likesCall = page.evaluate.mock.calls.find(([script]) => String(script).includes('/Likes')) || [];
-        expect(decodeURIComponent(String(likesCall[0]))).toContain('"userId":"42"');
-        expect(decodeURIComponent(String(likesCall[0]))).not.toContain('[object Object]');
-    });
-});

package/clis/twitter/list-add.test.js

@@ -1,133 +0,0 @@
-import { describe, expect, it, vi } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import { ArgumentError, CommandExecutionError } from '@sovovs/bycli/errors';
-import { buildListAddMemberRow } from './list-add.js';
-
-describe('twitter list-add registration', () => {
-    it('registers the list-add command with the expected shape', () => {
-        const cmd = getRegistry().get('twitter/list-add');
-        expect(cmd?.func).toBeTypeOf('function');
-        expect(cmd?.columns).toEqual(['listId', 'username', 'userId', 'status', 'message']);
-        const listIdArg = cmd?.args?.find((a) => a.name === 'listId');
-        expect(listIdArg).toBeTruthy();
-        expect(listIdArg?.required).toBe(true);
-        expect(listIdArg?.positional).toBe(true);
-    });
-
-    it('keeps the x.com root navigation before pre-target GraphQL calls', async () => {
-        const cmd = getRegistry().get('twitter/list-add');
-        const page = {
-            goto: vi.fn().mockResolvedValue(undefined),
-            wait: vi.fn().mockResolvedValue(undefined),
-            getCookies: vi.fn().mockResolvedValue([{ name: 'ct0', value: 'token' }]),
-            evaluate: vi.fn()
-                .mockResolvedValueOnce(null) // UserByScreenName queryId fallback
-                .mockResolvedValueOnce('user-1')
-                .mockResolvedValueOnce(null) // ListsManagement queryId fallback
-                .mockResolvedValueOnce({}),
-        };
-
-        await expect(cmd.func(page, { listId: '123', username: 'alice' }))
-            .rejects
-            .toThrow(/List 123 not found/);
-        expect(page.goto).toHaveBeenCalledWith('https://x.com');
-        expect(page.goto).toHaveBeenCalledTimes(1);
-        expect(page.wait).toHaveBeenCalledWith(3);
-        expect(page.getCookies).toHaveBeenCalledWith({ url: 'https://x.com' });
-    });
-
-    it('rejects invalid user input before navigation', async () => {
-        const cmd = getRegistry().get('twitter/list-add');
-        const page = {
-            goto: vi.fn(),
-            wait: vi.fn(),
-            getCookies: vi.fn(),
-            evaluate: vi.fn(),
-        };
-
-        await expect(cmd.func(page, { listId: 'abc', username: 'alice' })).rejects.toBeInstanceOf(ArgumentError);
-        await expect(cmd.func(page, { listId: '123', username: '' })).rejects.toBeInstanceOf(ArgumentError);
-        expect(page.goto).not.toHaveBeenCalled();
-    });
-
-    it('builds success rows when member_count increases despite non-fatal decode errors', () => {
-        const row = buildListAddMemberRow({
-            addResult: {
-                httpOk: true,
-                status: 200,
-                mc: 11,
-                isMember: true,
-                errors: [{ path: ['data', 'list', 'default_banner_media_results'], message: 'decode failed' }],
-            },
-            memberCountBefore: 10,
-            listId: '123',
-            username: 'alice',
-            userId: '42',
-        });
-
-        expect(row).toMatchObject({
-            listId: '123',
-            username: 'alice',
-            userId: '42',
-            status: 'success',
-        });
-        expect(row.message).toContain('member_count 10 → 11');
-    });
-
-    it('treats unchanged member_count as noop only when membership is confirmed', () => {
-        const row = buildListAddMemberRow({
-            addResult: { httpOk: true, status: 200, mc: 10, isMember: true, errors: null },
-            memberCountBefore: 10,
-            listId: '123',
-            username: 'alice',
-            userId: '42',
-        });
-
-        expect(row.status).toBe('noop');
-        expect(row.message).toBe('@alice is already a member of list 123');
-    });
-
-    it('fails typed when unchanged member_count does not confirm membership', () => {
-        expect(() => buildListAddMemberRow({
-            addResult: { httpOk: true, status: 200, mc: 10, isMember: false, errors: null },
-            memberCountBefore: 10,
-            listId: '123',
-            username: 'alice',
-            userId: '42',
-        })).toThrow(CommandExecutionError);
-    });
-
-    it('fails typed when member_count decreases unexpectedly', () => {
-        expect(() => buildListAddMemberRow({
-            addResult: { httpOk: true, status: 200, mc: 9, isMember: true, errors: null },
-            memberCountBefore: 10,
-            listId: '123',
-            username: 'alice',
-            userId: '42',
-        })).toThrow(/decreased unexpectedly/);
-    });
-
-    it('fails typed when GraphQL response has no usable member_count', () => {
-        expect(() => buildListAddMemberRow({
-            addResult: {
-                httpOk: true,
-                status: 200,
-                mc: undefined,
-                isMember: null,
-                errors: [{ message: 'List is unavailable', path: ['data', 'list'] }],
-            },
-            memberCountBefore: 10,
-            listId: '123',
-            username: 'alice',
-            userId: '42',
-        })).toThrow(/List is unavailable/);
-
-        expect(() => buildListAddMemberRow({
-            addResult: { httpOk: true, status: 200, mc: null, isMember: null, errors: { message: 'not an array' } },
-            memberCountBefore: 10,
-            listId: '123',
-            username: 'alice',
-            userId: '42',
-        })).toThrow(/no member_count/);
-    });
-});

package/clis/twitter/list-create.test.js

@@ -1,169 +0,0 @@
-import { describe, expect, it, vi } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import { ArgumentError, AuthRequiredError, CommandExecutionError } from '@sovovs/bycli/errors';
-import { buildListCreateRow, parseListCreateArgs } from './list-create.js';
-import './list-create.js';
-
-function createPayload(overrides = {}) {
-    return {
-        ok: true,
-        httpStatus: 200,
-        bodyText: '{}',
-        bodyJson: {
-            data: {
-                list: {
-                    id_str: '123456789',
-                    name: 'My List',
-                    description: 'A list',
-                    mode: 'Private',
-                    ...overrides,
-                },
-            },
-        },
-    };
-}
-
-describe('twitter list-create registration', () => {
-    it('registers the list-create command with the expected shape', () => {
-        const cmd = getRegistry().get('twitter/list-create');
-        expect(cmd?.func).toBeTypeOf('function');
-        expect(cmd?.columns).toEqual(['id', 'name', 'description', 'mode', 'status']);
-        const nameArg = cmd?.args?.find((a) => a.name === 'name');
-        expect(nameArg).toBeTruthy();
-        expect(nameArg?.required).toBe(true);
-        expect(nameArg?.positional).toBe(true);
-        const modeArg = cmd?.args?.find((a) => a.name === 'mode');
-        expect(modeArg?.default).toBe('public');
-        const descArg = cmd?.args?.find((a) => a.name === 'description');
-        expect(descArg?.default).toBe('');
-    });
-
-    it('rejects empty name', async () => {
-        const cmd = getRegistry().get('twitter/list-create');
-        await expect(cmd.func({}, { name: '   ' })).rejects.toBeInstanceOf(ArgumentError);
-    });
-
-    it('rejects names over 25 chars', async () => {
-        const cmd = getRegistry().get('twitter/list-create');
-        await expect(cmd.func({}, { name: 'x'.repeat(26) })).rejects.toBeInstanceOf(ArgumentError);
-    });
-
-    it('rejects descriptions over 100 chars', () => {
-        expect(() => parseListCreateArgs({ name: 'ok', description: 'x'.repeat(101) })).toThrow(ArgumentError);
-    });
-
-    it('rejects invalid mode', async () => {
-        const cmd = getRegistry().get('twitter/list-create');
-        await expect(cmd.func({}, { name: 'ok', mode: 'secret' })).rejects.toBeInstanceOf(ArgumentError);
-    });
-
-    it('reads ct0 from cookies and unwraps Browser Bridge mutation envelopes', async () => {
-        const cmd = getRegistry().get('twitter/list-create');
-        const page = {
-            goto: vi.fn().mockResolvedValue(undefined),
-            wait: vi.fn().mockResolvedValue(undefined),
-            getCookies: vi.fn().mockResolvedValue([{ name: 'ct0', value: 'csrf-token' }]),
-            evaluate: vi.fn().mockResolvedValue({ session: 'browser:default', data: createPayload() }),
-        };
-
-        const rows = await cmd.func(page, { name: 'My List', description: 'A list', mode: 'private' });
-
-        expect(page.goto).toHaveBeenCalledWith('https://x.com');
-        expect(page.wait).toHaveBeenCalledWith(3);
-        expect(page.getCookies).toHaveBeenCalledWith({ url: 'https://x.com' });
-        expect(rows).toEqual([{ id: '123456789', name: 'My List', description: 'A list', mode: 'private', status: 'success' }]);
-    });
-
-    it('rejects missing ct0 before mutation', async () => {
-        const cmd = getRegistry().get('twitter/list-create');
-        const page = {
-            goto: vi.fn().mockResolvedValue(undefined),
-            wait: vi.fn().mockResolvedValue(undefined),
-            getCookies: vi.fn().mockResolvedValue([]),
-            evaluate: vi.fn(),
-        };
-
-        await expect(cmd.func(page, { name: 'My List' })).rejects.toBeInstanceOf(AuthRequiredError);
-        expect(page.evaluate).not.toHaveBeenCalled();
-    });
-
-    it('keeps non-fatal GraphQL errors when a valid created list payload exists', () => {
-        const row = buildListCreateRow({
-            result: {
-                ...createPayload(),
-                bodyJson: {
-                    ...createPayload().bodyJson,
-                    errors: [{ message: 'DecodeException' }],
-                },
-            },
-            name: 'My List',
-            description: 'A list',
-            mode: 'private',
-        });
-
-        expect(row).toEqual({ id: '123456789', name: 'My List', description: 'A list', mode: 'private', status: 'success' });
-    });
-
-    it('maps mutation auth and HTTP failures to typed errors', () => {
-        expect(() => buildListCreateRow({
-            result: { ok: false, httpStatus: 401, bodyText: 'login' },
-            name: 'My List',
-            description: '',
-            mode: 'public',
-        })).toThrow(AuthRequiredError);
-
-        expect(() => buildListCreateRow({
-            result: { ok: false, httpStatus: 500, bodyText: 'server' },
-            name: 'My List',
-            description: '',
-            mode: 'public',
-        })).toThrow(CommandExecutionError);
-    });
-
-    it('fails typed when the mutation response lacks post-condition evidence', () => {
-        for (const result of [
-            createPayload({ id_str: '', id: '' }),
-            createPayload({ name: '' }),
-            createPayload({ mode: '' }),
-        ]) {
-            expect(() => buildListCreateRow({
-                result,
-                name: 'My List',
-                description: '',
-                mode: 'public',
-            })).toThrow(CommandExecutionError);
-        }
-    });
-
-    it('fails typed when returned list name does not match the requested name', () => {
-        expect(() => buildListCreateRow({
-            result: createPayload({ name: 'Other List' }),
-            name: 'My List',
-            description: '',
-            mode: 'private',
-        })).toThrow(/expected "My List"/);
-    });
-
-    it('fails typed when returned list mode does not match requested mode', () => {
-        expect(() => buildListCreateRow({
-            result: createPayload({ mode: 'Public' }),
-            name: 'My List',
-            description: '',
-            mode: 'private',
-        })).toThrow(/expected private/);
-    });
-
-    it('fails typed when errors appear without a list payload', () => {
-        expect(() => buildListCreateRow({
-            result: {
-                ok: true,
-                httpStatus: 200,
-                bodyText: '{}',
-                bodyJson: { errors: [{ message: 'duplicate name' }] },
-            },
-            name: 'My List',
-            description: '',
-            mode: 'public',
-        })).toThrow(/duplicate name/);
-    });
-});

package/clis/twitter/list-remove.test.js

@@ -1,110 +0,0 @@
-import { describe, expect, it, vi } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import { CommandExecutionError } from '@sovovs/bycli/errors';
-import './list-remove.js';
-
-function buildListsPayload(listId = '123', memberCount = 10) {
-    return {
-        data: {
-            viewer: {
-                list_management_timeline: {
-                    timeline: {
-                        instructions: [{
-                            entries: [{
-                                entryId: 'owned-subscribed-list-module-0',
-                                content: {
-                                    items: [{
-                                        item: {
-                                            itemContent: {
-                                                list: {
-                                                    id_str: listId,
-                                                    name: 'My List',
-                                                    member_count: memberCount,
-                                                    subscriber_count: 0,
-                                                    mode: 'Public',
-                                                },
-                                            },
-                                        },
-                                    }],
-                                },
-                            }],
-                        }],
-                    },
-                },
-            },
-        },
-    };
-}
-
-function buildRemovePage(afterPayload) {
-    return {
-        goto: vi.fn().mockResolvedValue(undefined),
-        wait: vi.fn().mockResolvedValue(undefined),
-        getCookies: vi.fn().mockResolvedValue([{ name: 'ct0', value: 'token' }]),
-        nativeClick: vi.fn().mockResolvedValue(undefined),
-        evaluate: vi.fn()
-            .mockResolvedValueOnce(null) // UserByScreenName queryId fallback
-            .mockResolvedValueOnce('user-1')
-            .mockResolvedValueOnce(null) // ListsManagement queryId fallback
-            .mockResolvedValueOnce(buildListsPayload('123', 10))
-            .mockResolvedValueOnce({ ok: true, needsNativeInteraction: true, rowClickX: 1, rowClickY: 2, saveClickX: 3, saveClickY: 4 })
-            .mockResolvedValueOnce(afterPayload),
-    };
-}
-
-describe('twitter list-remove registration', () => {
-    it('registers the list-remove command with the expected shape', () => {
-        const cmd = getRegistry().get('twitter/list-remove');
-        expect(cmd?.func).toBeTypeOf('function');
-        expect(cmd?.columns).toEqual(['listId', 'username', 'userId', 'status', 'message']);
-        const listIdArg = cmd?.args?.find((a) => a.name === 'listId');
-        expect(listIdArg).toBeTruthy();
-        expect(listIdArg?.required).toBe(true);
-    });
-
-    it('keeps the x.com root navigation before pre-target GraphQL calls', async () => {
-        const cmd = getRegistry().get('twitter/list-remove');
-        const page = {
-            goto: vi.fn().mockResolvedValue(undefined),
-            wait: vi.fn().mockResolvedValue(undefined),
-            getCookies: vi.fn().mockResolvedValue([{ name: 'ct0', value: 'token' }]),
-            evaluate: vi.fn()
-                .mockResolvedValueOnce(null) // UserByScreenName queryId fallback
-                .mockResolvedValueOnce('user-1')
-                .mockResolvedValueOnce(null) // ListsManagement queryId fallback
-                .mockResolvedValueOnce({}),
-        };
-
-        await expect(cmd.func(page, { listId: '123', username: 'alice' }))
-            .rejects
-            .toThrow(/List 123 not found/);
-        expect(page.goto).toHaveBeenCalledWith('https://x.com');
-        expect(page.goto).toHaveBeenCalledTimes(1);
-        expect(page.wait).toHaveBeenCalledWith(3);
-        expect(page.getCookies).toHaveBeenCalledWith({ url: 'https://x.com' });
-    });
-
-    it('does not treat post-delete fetch failure as successful member_count decrease', async () => {
-        const cmd = getRegistry().get('twitter/list-remove');
-        const page = buildRemovePage({ __error: 'HTTP 500' });
-
-        await expect(cmd.func(page, { listId: '123', username: 'alice' }))
-            .rejects.toBeInstanceOf(CommandExecutionError);
-    });
-
-    it('does not treat malformed post-delete payload as successful member_count decrease', async () => {
-        const cmd = getRegistry().get('twitter/list-remove');
-        const page = buildRemovePage({ data: {} });
-
-        await expect(cmd.func(page, { listId: '123', username: 'alice' }))
-            .rejects.toBeInstanceOf(CommandExecutionError);
-    });
-
-    it('does not treat a missing target list in post-delete payload as success', async () => {
-        const cmd = getRegistry().get('twitter/list-remove');
-        const page = buildRemovePage(buildListsPayload('456', 1));
-
-        await expect(cmd.func(page, { listId: '123', username: 'alice' }))
-            .rejects.toBeInstanceOf(CommandExecutionError);
-    });
-});