@sovovs/bycli 1.8.0 → 2.1.0

package/clis/reddit/extract-media.test.js

@@ -1,149 +0,0 @@
-/**
- * Behavioral tests for the extractRedditMedia helper.
- *
- * The helper is duplicated inline inside each adapter's browser-side evaluate()
- * source (see popular.js / hot.js / search.js / frontpage.js / subreddit.js).
- * Per-adapter tests grep that the same function-name + spread call is present.
- * This file pins the helper's behavior against representative Reddit-JSON
- * fixtures.
- */
-import { describe, expect, it } from 'vitest';
-
-function decodeHtml(s) {
-  if (typeof s !== 'string' || !s) return '';
-  return s
-    .replace(/&/g, '&')
-    .replace(/&lt;/g, '<')
-    .replace(/&gt;/g, '>')
-    .replace(/&quot;/g, '"')
-    .replace(/&#x27;/gi, "'")
-    .replace(/&#39;/g, "'");
-}
-function extractRedditMedia(d) {
-  const post_hint = d?.post_hint || '';
-  const url_overridden_by_dest = d?.url_overridden_by_dest || '';
-  const preview_image_url = decodeHtml(d?.preview?.images?.[0]?.source?.url || '');
-  const gallery_urls = [];
-  const items = d?.gallery_data?.items;
-  const meta = d?.media_metadata;
-  if (Array.isArray(items) && meta) {
-    for (const it of items) {
-      const m = it && meta[it.media_id];
-      const u = m?.s?.u;
-      if (u) gallery_urls.push(decodeHtml(u));
-    }
-  }
-  return { post_hint, url_overridden_by_dest, preview_image_url, gallery_urls };
-}
-
-describe('extractRedditMedia', () => {
-  it('returns empty fields for a plain text/self post', () => {
-    expect(extractRedditMedia({ is_self: true, selftext: 'hi' })).toEqual({
-      post_hint: '',
-      url_overridden_by_dest: '',
-      preview_image_url: '',
-      gallery_urls: [],
-    });
-  });
-
-  it('extracts post_hint, url_overridden_by_dest, preview_image_url for a single-image post', () => {
-    const post = {
-      post_hint: 'image',
-      url_overridden_by_dest: 'https://i.redd.it/abc.jpg',
-      preview: {
-        images: [{ source: { url: 'https://preview.redd.it/abc.jpg?width=640&amp;s=xyz' } }],
-      },
-    };
-    expect(extractRedditMedia(post)).toEqual({
-      post_hint: 'image',
-      url_overridden_by_dest: 'https://i.redd.it/abc.jpg',
-      preview_image_url: 'https://preview.redd.it/abc.jpg?width=640&s=xyz',
-      gallery_urls: [],
-    });
-  });
-
-  it('extracts gallery_urls in gallery_data.items order, HTML-decoded', () => {
-    const post = {
-      post_hint: '',
-      url_overridden_by_dest: 'https://www.reddit.com/gallery/xyz',
-      gallery_data: {
-        items: [{ media_id: 'idB' }, { media_id: 'idA' }, { media_id: 'idC' }],
-      },
-      media_metadata: {
-        idA: { s: { u: 'https://preview.redd.it/idA.jpg?width=1&amp;a=1' } },
-        idB: { s: { u: 'https://preview.redd.it/idB.jpg?width=1&amp;a=2' } },
-        idC: { s: { u: 'https://preview.redd.it/idC.jpg?width=1&amp;a=3' } },
-      },
-    };
-    const out = extractRedditMedia(post);
-    expect(out.gallery_urls).toEqual([
-      'https://preview.redd.it/idB.jpg?width=1&a=2',
-      'https://preview.redd.it/idA.jpg?width=1&a=1',
-      'https://preview.redd.it/idC.jpg?width=1&a=3',
-    ]);
-    expect(out.url_overridden_by_dest).toBe('https://www.reddit.com/gallery/xyz');
-  });
-
-  it('extracts post_hint for a hosted:video post', () => {
-    const post = {
-      post_hint: 'hosted:video',
-      url_overridden_by_dest: 'https://v.redd.it/xyz',
-      preview: { images: [{ source: { url: 'https://preview.redd.it/thumb.jpg' } }] },
-    };
-    const out = extractRedditMedia(post);
-    expect(out.post_hint).toBe('hosted:video');
-    expect(out.url_overridden_by_dest).toBe('https://v.redd.it/xyz');
-    expect(out.preview_image_url).toBe('https://preview.redd.it/thumb.jpg');
-    expect(out.gallery_urls).toEqual([]);
-  });
-
-  it('extracts post_hint for an external link post', () => {
-    const post = {
-      post_hint: 'link',
-      url_overridden_by_dest: 'https://example.com/article',
-    };
-    expect(extractRedditMedia(post)).toEqual({
-      post_hint: 'link',
-      url_overridden_by_dest: 'https://example.com/article',
-      preview_image_url: '',
-      gallery_urls: [],
-    });
-  });
-
-  it('HTML-decodes preview URLs that arrive with &amp; separators', () => {
-    const post = {
-      preview: {
-        images: [{ source: { url: 'https://x/?a=1&amp;b=2&amp;c=3' } }],
-      },
-    };
-    expect(extractRedditMedia(post).preview_image_url).toBe('https://x/?a=1&b=2&c=3');
-  });
-
-  it('skips gallery entries whose media_metadata is missing', () => {
-    const post = {
-      gallery_data: { items: [{ media_id: 'present' }, { media_id: 'orphan' }] },
-      media_metadata: {
-        present: { s: { u: 'https://preview.redd.it/present.jpg' } },
-        // 'orphan' intentionally absent
-      },
-    };
-    expect(extractRedditMedia(post).gallery_urls).toEqual([
-      'https://preview.redd.it/present.jpg',
-    ]);
-  });
-
-  it('tolerates null/undefined input without throwing', () => {
-    expect(extractRedditMedia(null)).toEqual({
-      post_hint: '',
-      url_overridden_by_dest: '',
-      preview_image_url: '',
-      gallery_urls: [],
-    });
-    expect(extractRedditMedia(undefined)).toEqual({
-      post_hint: '',
-      url_overridden_by_dest: '',
-      preview_image_url: '',
-      gallery_urls: [],
-    });
-  });
-});

package/clis/reddit/frontpage.test.js

@@ -1,34 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import './frontpage.js';
-
-describe('reddit frontpage adapter', () => {
-  const command = getRegistry().get('reddit/frontpage');
-
-  it('exposes the full frontpage shape including the 4 media columns', () => {
-    expect(command?.columns).toEqual([
-      'title', 'subreddit', 'author', 'upvotes', 'comments', 'url',
-      'post_hint', 'url_overridden_by_dest', 'preview_image_url', 'gallery_urls',
-    ]);
-  });
-
-  it('shapes children into the intermediate-object pattern with media spread in', () => {
-    // Refactored from item.data.* templating to a uniform pre-shaped object
-    // so gallery_urls (array-valued) can be set directly in evaluate.
-    expect(command?.pipeline?.[1]?.evaluate).toContain('function extractRedditMedia');
-    expect(command?.pipeline?.[1]?.evaluate).toContain('...extractRedditMedia(c.data)');
-    expect(command?.pipeline?.[1]?.evaluate).toContain('/r/all.json?limit=${{ args.limit }}&raw_json=1');
-    expect(command?.pipeline?.[2]?.map).toMatchObject({
-      title: '${{ item.title }}',
-      subreddit: '${{ item.subreddit }}',
-      author: '${{ item.author }}',
-      upvotes: '${{ item.upvotes }}',
-      comments: '${{ item.comments }}',
-      url: '${{ item.url }}',
-      post_hint: '${{ item.post_hint }}',
-      url_overridden_by_dest: '${{ item.url_overridden_by_dest }}',
-      preview_image_url: '${{ item.preview_image_url }}',
-      gallery_urls: '${{ item.gallery_urls }}',
-    });
-  });
-});

package/clis/reddit/home.test.js

@@ -1,170 +0,0 @@
-import { describe, expect, it, vi } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import { ArgumentError, AuthRequiredError, CommandExecutionError, EmptyResultError } from '@sovovs/bycli/errors';
-import { extractRedditMedia, parseRedditHomeLimit } from './home.js';
-import './home.js';
-
-function makePage(result) {
-    return {
-        goto: vi.fn().mockResolvedValue(undefined),
-        evaluate: vi.fn().mockResolvedValue(result),
-    };
-}
-
-function makeEntry(id, overrides = {}) {
-    return {
-        data: {
-            id,
-            title: `Title for ${id}`,
-            subreddit_name_prefixed: 'r/dummy',
-            score: 100,
-            num_comments: 10,
-            author: 'someone',
-            permalink: `/r/dummy/comments/${id}/title/`,
-            ...overrides,
-        },
-    };
-}
-
-describe('reddit home command', () => {
-    const command = getRegistry().get('reddit/home');
-
-    it('registers with the expected shape', () => {
-        expect(command).toBeDefined();
-        expect(command.access).toBe('read');
-        expect(command.browser).toBe(true);
-        expect(command.columns).toEqual([
-            'rank', 'title', 'subreddit', 'score', 'comments', 'postId', 'author', 'url',
-            'post_hint', 'url_overridden_by_dest', 'preview_image_url', 'gallery_urls',
-        ]);
-    });
-
-    it('parseRedditHomeLimit accepts [1,100] and rejects out-of-range / non-integer without silent clamp', () => {
-        expect(parseRedditHomeLimit(undefined)).toBe(25);
-        expect(parseRedditHomeLimit(null)).toBe(25);
-        expect(parseRedditHomeLimit('')).toBe(25);
-        expect(parseRedditHomeLimit(1)).toBe(1);
-        expect(parseRedditHomeLimit(25)).toBe(25);
-        expect(parseRedditHomeLimit(100)).toBe(100);
-
-        for (const bad of [0, -1, 101, 1.5, NaN, 'abc']) {
-            expect(() => parseRedditHomeLimit(bad)).toThrow(ArgumentError);
-        }
-    });
-
-    it('rejects a bad limit BEFORE navigating', async () => {
-        const page = makePage({ kind: 'ok', entries: [] });
-        await expect(command.func(page, { limit: 101 })).rejects.toBeInstanceOf(ArgumentError);
-        expect(page.goto).not.toHaveBeenCalled();
-        expect(page.evaluate).not.toHaveBeenCalled();
-    });
-
-    it('throws AuthRequiredError when logged out (401/403 or missing identity)', async () => {
-        await expect(command.func(makePage({ kind: 'auth', detail: 'login required' }), { limit: 25 }))
-            .rejects.toBeInstanceOf(AuthRequiredError);
-    });
-
-    it('throws CommandExecutionError on HTTP / exception failure modes', async () => {
-        await expect(command.func(makePage({ kind: 'http', httpStatus: 503, where: '/best.json' }), { limit: 25 }))
-            .rejects.toBeInstanceOf(CommandExecutionError);
-        await expect(command.func(makePage({ kind: 'exception', detail: 'network' }), { limit: 25 }))
-            .rejects.toBeInstanceOf(CommandExecutionError);
-    });
-
-    it('throws EmptyResultError when Reddit returns no posts', async () => {
-        await expect(command.func(makePage({ kind: 'ok', entries: [] }), { limit: 25 }))
-            .rejects.toBeInstanceOf(EmptyResultError);
-    });
-
-    it('maps entries to row shape with 1-based rank, full URLs, and typed numbers', async () => {
-        const entries = [makeEntry('a1'), makeEntry('b2', { score: 250, num_comments: 42 })];
-        const rows = await command.func(makePage({ kind: 'ok', entries }), { limit: 25 });
-
-        expect(rows).toEqual([
-            {
-                rank: 1, title: 'Title for a1', subreddit: 'r/dummy', score: 100, comments: 10,
-                postId: 'a1', author: 'someone', url: 'https://www.reddit.com/r/dummy/comments/a1/title/',
-                post_hint: '', url_overridden_by_dest: '', preview_image_url: '', gallery_urls: [],
-            },
-            {
-                rank: 2, title: 'Title for b2', subreddit: 'r/dummy', score: 250, comments: 42,
-                postId: 'b2', author: 'someone', url: 'https://www.reddit.com/r/dummy/comments/b2/title/',
-                post_hint: '', url_overridden_by_dest: '', preview_image_url: '', gallery_urls: [],
-            },
-        ]);
-        // Row shape must match declared columns exactly.
-        for (const row of rows) {
-            expect(Object.keys(row).sort()).toEqual(
-                [
-                    'author', 'comments', 'gallery_urls', 'postId', 'post_hint', 'preview_image_url',
-                    'rank', 'score', 'subreddit', 'title', 'url', 'url_overridden_by_dest',
-                ],
-            );
-        }
-    });
-
-    it('surfaces media route fields from the personalized home feed', async () => {
-        const entries = [makeEntry('a1', {
-            post_hint: 'image',
-            url_overridden_by_dest: 'https://i.redd.it/a.jpg',
-            preview: {
-                images: [{ source: { url: 'https://preview.redd.it/a.jpg?x=1&y=2' } }],
-            },
-            gallery_data: { items: [{ media_id: 'm2' }, { media_id: 'm1' }] },
-            media_metadata: {
-                m1: { s: { u: 'https://preview.redd.it/m1.jpg?x=1&y=1' } },
-                m2: { s: { u: 'https://preview.redd.it/m2.jpg?x=1&y=2' } },
-            },
-        })];
-        const rows = await command.func(makePage({ kind: 'ok', entries }), { limit: 25 });
-
-        expect(rows[0]).toMatchObject({
-            post_hint: 'image',
-            url_overridden_by_dest: 'https://i.redd.it/a.jpg',
-            preview_image_url: 'https://preview.redd.it/a.jpg?x=1&y=2',
-            gallery_urls: [
-                'https://preview.redd.it/m2.jpg?x=1&y=2',
-                'https://preview.redd.it/m1.jpg?x=1&y=1',
-            ],
-        });
-    });
-
-    it('extractRedditMedia tolerates missing media without throwing', () => {
-        expect(extractRedditMedia({ is_self: true })).toEqual({
-            post_hint: '',
-            url_overridden_by_dest: '',
-            preview_image_url: '',
-            gallery_urls: [],
-        });
-    });
-
-    it('applies the post-fetch limit slice (defence in depth vs Reddit overshoot)', async () => {
-        const entries = Array.from({ length: 30 }, (_, i) => makeEntry(`p${i}`));
-        const rows = await command.func(makePage({ kind: 'ok', entries }), { limit: 5 });
-        expect(rows).toHaveLength(5);
-        expect(rows[0].postId).toBe('p0');
-        expect(rows[4].postId).toBe('p4');
-    });
-
-    it('drops entries with no data.id rather than silently emitting sentinels', async () => {
-        const entries = [makeEntry('keep1'), { data: { title: 'no id' } }, makeEntry('keep2')];
-        const rows = await command.func(makePage({ kind: 'ok', entries }), { limit: 25 });
-        expect(rows.map((r) => r.postId)).toEqual(['keep1', 'keep2']);
-    });
-
-    it('throws CommandExecutionError when all home entries are missing post ids', async () => {
-        const entries = [{ data: { title: 'no id' } }, { data: { title: 'also no id' } }];
-        await expect(command.func(makePage({ kind: 'ok', entries }), { limit: 25 }))
-            .rejects.toMatchObject({
-                code: 'COMMAND_EXEC',
-                message: expect.stringContaining('required post id anchors'),
-            });
-    });
-
-    it('embeds the requested limit literally inside the evaluate script', async () => {
-        const page = makePage({ kind: 'ok', entries: [makeEntry('x')] });
-        await command.func(page, { limit: 7 });
-        const script = page.evaluate.mock.calls[0][0];
-        expect(script).toContain('const limit = 7');
-    });
-});

package/clis/reddit/hot.test.js

@@ -1,32 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import './hot.js';
-
-describe('reddit hot adapter', () => {
-  const command = getRegistry().get('reddit/hot');
-
-  it('registers postId, author, and url columns in the hot-list shape', () => {
-    expect(command?.columns).toEqual([
-      'rank', 'title', 'subreddit', 'score', 'comments', 'postId', 'author', 'url',
-      'post_hint', 'url_overridden_by_dest', 'preview_image_url', 'gallery_urls',
-    ]);
-    expect(command?.pipeline?.[1]?.evaluate).toContain('postId: c.data.id');
-    expect(command?.pipeline?.[1]?.evaluate).toContain("'https://www.reddit.com' + c.data.permalink");
-    expect(command?.pipeline?.[2]?.map).toMatchObject({
-      postId: '${{ item.postId }}',
-      author: '${{ item.author }}',
-      url: '${{ item.url }}',
-    });
-  });
-
-  it('surfaces post_hint, url_overridden_by_dest, preview_image_url, gallery_urls via extractRedditMedia', () => {
-    expect(command?.pipeline?.[1]?.evaluate).toContain('function extractRedditMedia');
-    expect(command?.pipeline?.[1]?.evaluate).toContain('...extractRedditMedia(c.data)');
-    expect(command?.pipeline?.[2]?.map).toMatchObject({
-      post_hint: '${{ item.post_hint }}',
-      url_overridden_by_dest: '${{ item.url_overridden_by_dest }}',
-      preview_image_url: '${{ item.preview_image_url }}',
-      gallery_urls: '${{ item.gallery_urls }}',
-    });
-  });
-});

package/clis/reddit/popular.test.js

@@ -1,26 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import './popular.js';
-
-describe('reddit popular adapter', () => {
-  const command = getRegistry().get('reddit/popular');
-
-  it('exposes the full post-list shape including the 4 media columns', () => {
-    expect(command?.columns).toEqual([
-      'rank', 'id', 'title', 'subreddit', 'score', 'comments', 'author', 'url',
-      'created_utc', 'selftext',
-      'post_hint', 'url_overridden_by_dest', 'preview_image_url', 'gallery_urls',
-    ]);
-  });
-
-  it('surfaces media via extractRedditMedia in evaluate + map', () => {
-    expect(command?.pipeline?.[1]?.evaluate).toContain('function extractRedditMedia');
-    expect(command?.pipeline?.[1]?.evaluate).toContain('...extractRedditMedia(c.data)');
-    expect(command?.pipeline?.[2]?.map).toMatchObject({
-      post_hint: '${{ item.post_hint }}',
-      url_overridden_by_dest: '${{ item.url_overridden_by_dest }}',
-      preview_image_url: '${{ item.preview_image_url }}',
-      gallery_urls: '${{ item.gallery_urls }}',
-    });
-  });
-});