@sovovs/bycli 1.8.0 → 2.1.0

package/clis/hackernews/hackernews.test.js

@@ -1,132 +0,0 @@
-import { afterEach, describe, expect, it, vi } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import { ArgumentError, EmptyResultError } from '@sovovs/bycli/errors';
-import './top.js';
-import './best.js';
-import './ask.js';
-import './new.js';
-import './show.js';
-import './jobs.js';
-import './search.js';
-import './read.js';
-
-afterEach(() => {
-  vi.unstubAllGlobals();
-  vi.restoreAllMocks();
-});
-
-describe('hackernews listing adapters expose item id', () => {
-  const storyCommands = ['hackernews/top', 'hackernews/best', 'hackernews/ask', 'hackernews/new', 'hackernews/show'];
-
-  storyCommands.forEach((key) => {
-    it(`${key} surfaces id alongside title/score/author/comments/url`, () => {
-      const cmd = getRegistry().get(key);
-      expect(cmd?.columns).toEqual(['rank', 'id', 'title', 'score', 'author', 'comments', 'url']);
-      expect(cmd?.pipeline?.[5]?.map).toMatchObject({
-        id: '${{ item.id }}',
-        url: '${{ item.url }}',
-      });
-    });
-  });
-
-  it('hackernews/jobs surfaces id alongside title/author/url', () => {
-    const cmd = getRegistry().get('hackernews/jobs');
-    expect(cmd?.columns).toEqual(['rank', 'id', 'title', 'author', 'url']);
-    expect(cmd?.pipeline?.[5]?.map).toMatchObject({
-      id: '${{ item.id }}',
-      url: '${{ item.url }}',
-    });
-  });
-
-  it('hackernews/search surfaces id (algolia objectID) alongside the existing columns', () => {
-    const cmd = getRegistry().get('hackernews/search');
-    expect(cmd?.columns).toEqual(['rank', 'id', 'title', 'score', 'author', 'comments', 'url']);
-    expect(cmd?.pipeline?.[2]?.map).toMatchObject({
-      id: '${{ item.objectID }}',
-    });
-  });
-});
-
-describe('hackernews/read adapter', () => {
-  const cmd = getRegistry().get('hackernews/read');
-
-  it('registers the comment-thread shape (type/author/score/text)', () => {
-    expect(cmd?.columns).toEqual(['type', 'author', 'score', 'text']);
-  });
-
-  it('takes a positional id plus tunable depth/limit/replies/max-length args', () => {
-    const argNames = (cmd?.args || []).map((a) => a.name);
-    expect(argNames).toEqual(['id', 'limit', 'depth', 'replies', 'max-length']);
-    const idArg = cmd?.args?.find((a) => a.name === 'id');
-    expect(idArg?.required).toBe(true);
-    expect(idArg?.positional).toBe(true);
-  });
-
-  it('uses the public Firebase API (no browser, public strategy)', () => {
-    expect(cmd?.browser).toBe(false);
-    expect(cmd?.strategy).toBe('public');
-  });
-
-  it('fails fast with ArgumentError for non-numeric ids before hitting fetch', async () => {
-    const fetchMock = vi.fn();
-    vi.stubGlobal('fetch', fetchMock);
-
-    await expect(cmd.func({ id: 'abc', limit: 5, depth: 2, replies: 5, 'max-length': 2000 })).rejects.toThrow(ArgumentError);
-    expect(fetchMock).not.toHaveBeenCalled();
-  });
-
-  it('fails fast with EmptyResultError when the story is missing', async () => {
-    vi.stubGlobal('fetch', vi.fn().mockResolvedValue(new Response(JSON.stringify(null), { status: 200 })));
-
-    await expect(cmd.func({ id: '99999999', limit: 5, depth: 2, replies: 5, 'max-length': 2000 })).rejects.toThrow(EmptyResultError);
-  });
-
-  it('renders story body, anchor text, and hidden-replies stubs from the public API tree', async () => {
-    const items = new Map([
-      ['123', {
-        id: 123,
-        type: 'story',
-        by: 'pg',
-        score: 42,
-        title: 'Ask HN: Example',
-        text: '<p>Hello <a href=\"https://example.com\">world</a></p>',
-        url: 'https://news.ycombinator.com/item?id=123',
-        kids: [456],
-      }],
-      ['456', {
-        id: 456,
-        type: 'comment',
-        by: 'sama',
-        text: '<p>Top level</p>',
-        kids: [789],
-      }],
-    ]);
-    vi.stubGlobal('fetch', vi.fn(async (url) => {
-      const id = String(url).match(/item\/(\d+)\.json$/)?.[1];
-      return new Response(JSON.stringify(items.get(id) ?? null), { status: 200 });
-    }));
-
-    const rows = await cmd.func({ id: '123', limit: 5, depth: 1, replies: 5, 'max-length': 2000 });
-
-    expect(rows).toEqual([
-      {
-        type: 'POST',
-        author: 'pg',
-        score: 42,
-        text: 'Ask HN: Example\nHello world (https://example.com)\nhttps://news.ycombinator.com/item?id=123',
-      },
-      {
-        type: 'L0',
-        author: 'sama',
-        score: '',
-        text: 'Top level',
-      },
-      {
-        type: 'L1',
-        author: '',
-        score: '',
-        text: '  [+1 more replies]',
-      },
-    ]);
-  });
-});

package/clis/hf/hf.test.js

@@ -1,16 +0,0 @@
-import { describe, expect, it } from 'vitest';
-import { getRegistry } from '@sovovs/bycli/registry';
-import './top.js';
-import './paper.js';
-
-describe('hf adapter registry contracts', () => {
-    it('declares hf top columns so paper ids round-trip into hf paper', () => {
-        const top = getRegistry().get('hf/top');
-        const paper = getRegistry().get('hf/paper');
-
-        expect(top).toBeDefined();
-        expect(paper).toBeDefined();
-        expect(top.columns).toEqual(['rank', 'id', 'title', 'upvotes', 'authors']);
-        expect(paper.columns).toContain('id');
-    });
-});

package/clis/hupu/hot.test.js

@@ -1,224 +0,0 @@
-// Hupu hot adapter — contract + JSDOM-against-frozen-fixture tests.
-//
-// Why a frozen-HTML fixture: the legacy adapter used a
-// `documentElement.outerHTML` regex that would silently miss rows when
-// hupu nudged whitespace or attribute order. Testing against a slim
-// captured fixture in JSDOM proves the new querySelectorAll-based
-// extractor handles the real markup shape — a mocked `page.evaluate()`
-// alone cannot catch in-browser DOM bugs (lesson from dianping #1312
-// → #1313).
-
-import { readFileSync } from 'node:fs';
-import { dirname, join } from 'node:path';
-import { fileURLToPath } from 'node:url';
-import { JSDOM } from 'jsdom';
-import { describe, expect, it, vi } from 'vitest';
-import { ArgumentError, CommandExecutionError, EmptyResultError } from '@sovovs/bycli/errors';
-import { getRegistry } from '@sovovs/bycli/registry';
-import {
-    HOT_LIMIT_DEFAULT,
-    HOT_LIMIT_MAX,
-    extractHupuHotRowsFromDoc,
-    hotCommand,
-    normalizeHotLimit,
-    parseHupuCount,
-    __test__,
-} from './hot.js';
-
-const __dirname = dirname(fileURLToPath(import.meta.url));
-const HOT_FIXTURE = readFileSync(join(__dirname, '__fixtures__/hot-home.html'), 'utf8');
-
-describe('hupu/hot — registration', () => {
-    it('registers as PUBLIC + browser:true with the new column shape', () => {
-        const cmd = getRegistry().get('hupu/hot');
-        expect(cmd).toBe(hotCommand);
-        expect(cmd.browser).toBe(true);
-        expect(cmd.strategy).toBe('public');
-        expect(cmd.access).toBe('read');
-        expect(cmd.domain).toBe('bbs.hupu.com');
-        expect(cmd.columns).toEqual(['rank', 'tid', 'title', 'lights', 'replies', 'forum', 'is_hot', 'url']);
-    });
-});
-
-describe('hupu/hot — normalizeHotLimit', () => {
-    it('returns default when raw is missing / empty', () => {
-        expect(normalizeHotLimit(undefined)).toBe(HOT_LIMIT_DEFAULT);
-        expect(normalizeHotLimit(null)).toBe(HOT_LIMIT_DEFAULT);
-        expect(normalizeHotLimit('')).toBe(HOT_LIMIT_DEFAULT);
-    });
-
-    it('accepts integer-coerceable values inside the cap', () => {
-        expect(normalizeHotLimit(1)).toBe(1);
-        expect(normalizeHotLimit('20')).toBe(20);
-        expect(normalizeHotLimit(HOT_LIMIT_MAX)).toBe(HOT_LIMIT_MAX);
-    });
-
-    it('throws ArgumentError on out-of-range / non-integer / non-numeric — no silent clamp', () => {
-        expect(() => normalizeHotLimit(0)).toThrow(ArgumentError);
-        expect(() => normalizeHotLimit(-1)).toThrow(ArgumentError);
-        expect(() => normalizeHotLimit(HOT_LIMIT_MAX + 1)).toThrow(ArgumentError);
-        expect(() => normalizeHotLimit(1.5)).toThrow(ArgumentError);
-        expect(() => normalizeHotLimit('not-a-number')).toThrow(ArgumentError);
-    });
-});
-
-describe('hupu/hot — parseHupuCount', () => {
-    it('parses base counts', () => {
-        expect(parseHupuCount('50亮')).toBe(50);
-        expect(parseHupuCount('359回复')).toBe(359);
-        expect(parseHupuCount('0亮')).toBe(0);
-    });
-
-    it('expands 万 multiplier', () => {
-        expect(parseHupuCount('1.2万亮')).toBe(12000);
-        expect(parseHupuCount('5.8万回复')).toBe(58000);
-        expect(parseHupuCount('1万')).toBe(10000);
-    });
-
-    it('returns null for missing / unparseable input — never 0 as unknown sentinel', () => {
-        expect(parseHupuCount(null)).toBeNull();
-        expect(parseHupuCount(undefined)).toBeNull();
-        expect(parseHupuCount('')).toBeNull();
-        expect(parseHupuCount('   ')).toBeNull();
-        expect(parseHupuCount('abc')).toBeNull();
-    });
-});
-
-describe('hupu/hot — extractHupuHotRowsFromDoc against frozen fixture', () => {
-    function loadDocument() {
-        const dom = new JSDOM(HOT_FIXTURE, { url: 'https://bbs.hupu.com/' });
-        return dom.window.document;
-    }
-
-    it('extracts all 6 fixture rows with full column shape (lights/replies/forum/is_hot)', () => {
-        const doc = loadDocument();
-        const rows = extractHupuHotRowsFromDoc(doc, 50, parseHupuCount);
-
-        expect(rows).toHaveLength(6);
-        expect(rows.some((row) => row.tid === '639999999')).toBe(false);
-        // Row 0: hot row, ASCII counts
-        expect(rows[0]).toEqual({
-            rank: 1,
-            tid: '639088523',
-            title: '网友曝三亚4只皮皮虾收费1035，官方凌晨通报',
-            lights: 50,
-            replies: 359,
-            forum: '步行街主干道',
-            is_hot: true,
-            url: 'https://bbs.hupu.com/639088523.html',
-        });
-        // Row 1: non-hot row — same forum, different is_hot
-        expect(rows[1]).toMatchObject({ rank: 2, tid: '639095236', is_hot: false });
-        // Row 2: 万 multiplier — covers 1.2万 → 12000, 5.8万 → 58000
-        expect(rows[2]).toMatchObject({ rank: 3, tid: '639094866', lights: 12000, replies: 58000, is_hot: false });
-        // Row 3: 0 is preserved as real 0, not coerced to null
-        expect(rows[3]).toMatchObject({ rank: 4, tid: '639100001', lights: 0, replies: 0, is_hot: true });
-        // Row 4: missing .t-lights span — null sentinel, never silent 0
-        expect(rows[4]).toMatchObject({ rank: 5, tid: '639100002', lights: null, replies: 20, is_hot: false });
-        // Row 5: forum varies — proves t-label resolution is per-row
-        expect(rows[5]).toMatchObject({ rank: 6, tid: '639100003', forum: '国际足球', is_hot: true });
-    });
-
-    it('respects the limit cap (returns ≤ limit rows)', () => {
-        const doc = loadDocument();
-        expect(extractHupuHotRowsFromDoc(doc, 3, parseHupuCount)).toHaveLength(3);
-        expect(extractHupuHotRowsFromDoc(doc, 1, parseHupuCount)).toHaveLength(1);
-    });
-
-    it('returns [] when the document has no .t-info containers (page wobble guard)', () => {
-        const dom = new JSDOM('<html><body><div class="bbs-index-web"></div></body></html>', {
-            url: 'https://bbs.hupu.com/',
-        });
-        const rows = extractHupuHotRowsFromDoc(dom.window.document, 20, parseHupuCount);
-        expect(rows).toEqual([]);
-    });
-
-    it('skips rows whose href does not match /<9-digit>.html (silent partial guard)', () => {
-        const dom = new JSDOM(`
-<html><body><div class="bbs-index-web">
-  <div class="list-item-wrap"><div class="list-wrap"><div class="list-item">
-    <div class="t-info">
-      <a href="/forum/announcement"><span class="t-title">公告</span></a>
-      <span class="t-lights">99亮</span><span class="t-replies">99回复</span>
-    </div>
-    <div class="t-label"><a>导航</a></div>
-  </div></div></div>
-  <div class="list-item-wrap"><div class="list-wrap"><div class="list-item">
-    <div class="t-info">
-      <a href="/639200001.html" class=" hot"><span class="t-title">真帖子</span></a>
-      <span class="t-lights">5亮</span><span class="t-replies">3回复</span>
-    </div>
-    <div class="t-label"><a>板块</a></div>
-  </div></div></div>
-</div></body></html>`, { url: 'https://bbs.hupu.com/' });
-        const rows = extractHupuHotRowsFromDoc(dom.window.document, 20, parseHupuCount);
-        expect(rows).toHaveLength(1);
-        expect(rows[0]).toMatchObject({ tid: '639200001', is_hot: true });
-    });
-});
-
-describe('hupu/hot — buildHotScript invariants', () => {
-    it('embeds extractHupuHotRowsFromDoc + parseHupuCount via toString() and JSON.stringifies the limit', () => {
-        const script = __test__.buildHotScript(7);
-        expect(script).toContain('extractHupuHotRowsFromDoc');
-        expect(script).toContain('parseHupuCount');
-        expect(script).toContain('querySelectorAll');
-        // Limit must be embedded literally (JSON.stringified) so the IIFE
-        // can never be tricked into reading a parameter from the host page.
-        expect(script).toContain(', 7, parseHupuCount');
-    });
-
-    it('does NOT use document.documentElement.outerHTML regex (anti-pattern guard)', () => {
-        const script = __test__.buildHotScript(20);
-        expect(script).not.toContain('documentElement.outerHTML');
-        expect(script).not.toMatch(/regex\.exec/);
-    });
-});
-
-describe('hupu/hot — getHupuHot func wiring', () => {
-    function createPageMock(rows) {
-        return {
-            goto: vi.fn().mockResolvedValue(undefined),
-            evaluate: vi.fn().mockResolvedValue(rows),
-        };
-    }
-
-    function createFailingPageMock(error) {
-        return {
-            goto: vi.fn().mockResolvedValue(undefined),
-            evaluate: vi.fn().mockRejectedValue(error),
-        };
-    }
-
-    it('validates --limit upfront BEFORE calling page.goto (no wasted navigation)', async () => {
-        const page = createPageMock([]);
-        await expect(hotCommand.func(page, { limit: 0 })).rejects.toThrow(ArgumentError);
-        expect(page.goto).not.toHaveBeenCalled();
-        expect(page.evaluate).not.toHaveBeenCalled();
-    });
-
-    it('throws EmptyResultError when the page returns an empty row list', async () => {
-        const page = createPageMock([]);
-        await expect(hotCommand.func(page, { limit: 20 })).rejects.toThrow(EmptyResultError);
-        expect(page.goto).toHaveBeenCalledTimes(1);
-    });
-
-    it('wraps page.evaluate failures as CommandExecutionError', async () => {
-        const page = createFailingPageMock(new Error('selector crashed'));
-        await expect(hotCommand.func(page, { limit: 20 })).rejects.toThrow(CommandExecutionError);
-        expect(page.goto).toHaveBeenCalledTimes(1);
-    });
-
-    it('returns the rows verbatim when the in-page extractor yields data', async () => {
-        const fakeRow = {
-            rank: 1, tid: '639000001', title: 'demo', lights: 1, replies: 2,
-            forum: '测试', is_hot: true, url: 'https://bbs.hupu.com/639000001.html',
-        };
-        const page = createPageMock([fakeRow]);
-        const result = await hotCommand.func(page, { limit: 20 });
-        expect(result).toEqual([fakeRow]);
-        expect(page.goto).toHaveBeenCalledWith('https://bbs.hupu.com/', expect.objectContaining({
-            waitUntil: 'load',
-        }));
-    });
-});

package/clis/imdb/utils.test.js

@@ -1,88 +0,0 @@
-import { describe, expect, it, vi } from 'vitest';
-import { extractJsonLd, forceEnglishUrl, formatDuration, getCurrentImdbId, isChallengePage, normalizeImdbTitleType, normalizeImdbId, waitForImdbPath, waitForImdbReviewsReady, waitForImdbSearchReady, } from './utils.js';
-describe('normalizeImdbId', () => {
-    it('passes through bare ids', () => {
-        expect(normalizeImdbId('tt1375666', 'tt')).toBe('tt1375666');
-        expect(normalizeImdbId('nm0634240', 'nm')).toBe('nm0634240');
-    });
-    it('extracts ids from supported urls', () => {
-        expect(normalizeImdbId('https://www.imdb.com/title/tt1375666/', 'tt')).toBe('tt1375666');
-        expect(normalizeImdbId('https://m.imdb.com/title/tt1375666/', 'tt')).toBe('tt1375666');
-        expect(normalizeImdbId('https://www.imdb.com/de/title/tt1375666/?ref_=nv_sr_srsg_0', 'tt')).toBe('tt1375666');
-        expect(normalizeImdbId('https://www.imdb.com/name/nm0634240/', 'nm')).toBe('nm0634240');
-    });
-    it('throws on invalid or mismatched ids', () => {
-        expect(() => normalizeImdbId('invalid', 'tt')).toThrow('Invalid IMDb ID');
-        expect(() => normalizeImdbId('tt1', 'tt')).toThrow('Invalid IMDb ID');
-        expect(() => normalizeImdbId('nm0634240', 'tt')).toThrow('Invalid IMDb ID');
-    });
-});
-describe('formatDuration', () => {
-    it('converts ISO-8601 durations to a short human format', () => {
-        expect(formatDuration('PT2H28M')).toBe('2h 28m');
-        expect(formatDuration('PT1H')).toBe('1h');
-        expect(formatDuration('PT45M')).toBe('45m');
-        expect(formatDuration('PT2H')).toBe('2h');
-    });
-    it('returns an empty string for invalid input', () => {
-        expect(formatDuration('')).toBe('');
-        expect(formatDuration('invalid')).toBe('');
-    });
-});
-describe('forceEnglishUrl', () => {
-    it('adds the English language parameter', () => {
-        expect(forceEnglishUrl('https://www.imdb.com/title/tt1375666/')).toContain('language=en-US');
-    });
-    it('preserves existing query parameters', () => {
-        const result = forceEnglishUrl('https://www.imdb.com/title/tt1375666/?ref_=nv');
-        expect(result).toContain('language=en-US');
-        expect(result).toContain('ref_=nv');
-    });
-});
-describe('normalizeImdbTitleType', () => {
-    it('maps internal imdb ids to readable labels', () => {
-        expect(normalizeImdbTitleType({ id: 'movie', text: '' })).toBe('Movie');
-        expect(normalizeImdbTitleType({ id: 'tvSeries', text: '' })).toBe('TV Series');
-        expect(normalizeImdbTitleType('short')).toBe('Short');
-    });
-    it('preserves explicit text labels', () => {
-        expect(normalizeImdbTitleType({ id: 'movie', text: 'Feature Film' })).toBe('Feature Film');
-    });
-});
-describe('extractJsonLd', () => {
-    it('returns the evaluated JSON-LD payload', async () => {
-        const page = {
-            evaluate: vi.fn().mockResolvedValue({ '@type': 'Movie', name: 'Inception' }),
-        };
-        await expect(extractJsonLd(page, 'Movie')).resolves.toEqual({ '@type': 'Movie', name: 'Inception' });
-        expect(page.evaluate).toHaveBeenCalledTimes(1);
-        expect(page.evaluate).toHaveBeenCalledWith(expect.stringContaining('"Movie"'));
-    });
-});
-describe('isChallengePage', () => {
-    it('returns true when the page evaluation matches a challenge', async () => {
-        const page = {
-            evaluate: vi.fn().mockResolvedValue(true),
-        };
-        await expect(isChallengePage(page)).resolves.toBe(true);
-        expect(page.evaluate).toHaveBeenCalledTimes(1);
-    });
-});
-describe('imdb browser helpers', () => {
-    it('reads the current imdb id from page metadata', async () => {
-        const page = {
-            evaluate: vi.fn().mockResolvedValue('nm0634240'),
-        };
-        await expect(getCurrentImdbId(page, 'nm')).resolves.toBe('nm0634240');
-        expect(page.evaluate).toHaveBeenCalledTimes(1);
-    });
-    it('wait helpers resolve mocked readiness booleans', async () => {
-        const page = {
-            evaluate: vi.fn().mockResolvedValue(true),
-        };
-        await expect(waitForImdbPath(page, '^/find/?$')).resolves.toBe(true);
-        await expect(waitForImdbSearchReady(page)).resolves.toBe(true);
-        await expect(waitForImdbReviewsReady(page)).resolves.toBe(true);
-        expect(page.evaluate).toHaveBeenCalledTimes(3);
-    });
-});