@skillsmith/core 0.11.5 → 0.11.6

package/dist/tests/unit/services/skill-installation.service.companion-basedir.test.js

@@ -0,0 +1,112 @@
+/**
+ * SMI-5982 code-review fix #1 (BLOCKING, cwd-dependent resolution):
+ * `SkillInstallationService`'s `companionBaseDir` constructor param must
+ * thread all the way through `install()` -> `writeInstallFiles()` ->
+ * `resolveCompanionAgentPath()` so the Antigravity companion-agent file
+ * lands under an explicitly-passed root, not whatever `process.cwd()`
+ * happens to be at the moment the write actually runs — the exact hazard
+ * for a long-running MCP server whose cwd is fixed at launch and does not
+ * track the calling editor/agent's real project.
+ *
+ * `applyOptimization` (skill-installation.helpers.ts) is mocked to force a
+ * deterministic `subagentContent` without depending on the real
+ * TransformationService's content-shape heuristics — this test is about
+ * PATH WIRING, not optimization behavior, which is covered elsewhere.
+ */
+import { afterEach, beforeEach, describe, expect, it, vi } from 'vitest';
+import * as fs from 'fs/promises';
+import * as path from 'path';
+import * as os from 'node:os';
+vi.mock('../../../src/services/skill-installation.helpers.js', async (importOriginal) => {
+    const actual = await importOriginal();
+    return {
+        ...actual,
+        applyOptimization: vi.fn(async (_db, _skillId, skillName, skillMdContent) => ({
+            finalSkillContent: skillMdContent,
+            subSkillFiles: [],
+            subagentContent: `---\nname: ${skillName}-specialist\n---\nCompanion subagent body`,
+            claudeMdSnippet: undefined,
+            optimizationInfo: {
+                optimized: true,
+                subSkills: [],
+                subagentGenerated: true,
+            },
+        })),
+    };
+});
+import { SkillInstallationService } from '../../../src/services/skill-installation.service.js';
+import { SkillRepository } from '../../../src/repositories/SkillRepository.js';
+import { SkillDependencyRepository } from '../../../src/repositories/SkillDependencyRepository.js';
+import { createTestDatabase } from '../../helpers/database.js';
+const VALID_SKILL_MD = '---\nname: my-skill\ndescription: test skill for SMI-5982 companionBaseDir wiring\n---\n\n' +
+    '# My Skill\n\nEnough content here to clear the 100-character minimum validation threshold ' +
+    'the installer enforces before proceeding with the rest of the install pipeline.';
+describe('SkillInstallationService companionBaseDir wiring (SMI-5982 code-review fix #1)', () => {
+    let db;
+    let originalCwd;
+    let projectDir;
+    let skillsDir;
+    let manifestPath;
+    beforeEach(async () => {
+        db = await createTestDatabase();
+        originalCwd = process.cwd();
+        projectDir = await fs.mkdtemp(path.join(os.tmpdir(), 'skillsmith-service-companion-basedir-'));
+        process.chdir(projectDir);
+        skillsDir = path.join(projectDir, 'skills');
+        manifestPath = path.join(projectDir, 'manifest.json');
+        await fs.mkdir(skillsDir, { recursive: true });
+        vi.stubGlobal('fetch', vi.fn());
+        vi.mocked(fetch).mockImplementation(async (url) => {
+            const urlStr = typeof url === 'string' ? url : url.toString();
+            if (urlStr.includes('SKILL.md')) {
+                return new Response(VALID_SKILL_MD, { status: 200 });
+            }
+            return new Response('Not found', { status: 404 });
+        });
+    });
+    afterEach(async () => {
+        process.chdir(originalCwd);
+        db.close();
+        vi.restoreAllMocks();
+        await fs.rm(projectDir, { recursive: true, force: true }).catch(() => { });
+    });
+    function buildService(overrides = {}) {
+        return new SkillInstallationService({
+            db,
+            skillRepo: new SkillRepository(db),
+            skillDependencyRepo: new SkillDependencyRepository(db),
+            skillsDir,
+            manifestPath,
+            client: 'antigravity',
+            ...overrides,
+        });
+    }
+    it('lands the antigravity companion file under an explicit companionBaseDir, not process.cwd()', async () => {
+        const explicitBaseDir = await fs.mkdtemp(path.join(os.tmpdir(), 'skillsmith-service-explicit-basedir-'));
+        try {
+            const service = buildService({ companionBaseDir: explicitBaseDir });
+            const result = await service.install('https://github.com/owner/my-skill');
+            expect(result.success).toBe(true);
+            const expectedPath = path.join(explicitBaseDir, '.agents', 'agents', 'my-skill', 'agent.md');
+            expect(result.optimization?.subagentPath).toBe(expectedPath);
+            await expect(fs.access(expectedPath)).resolves.toBeUndefined();
+            // Must NOT have landed under process.cwd() (this describe block's projectDir) —
+            // the whole point of the fix.
+            expect(result.optimization?.subagentPath?.startsWith(projectDir)).toBe(false);
+        }
+        finally {
+            await fs.rm(explicitBaseDir, { recursive: true, force: true }).catch(() => { });
+        }
+    });
+    it('PR-review follow-up: omitting companionBaseDir now fails the install closed instead of silently defaulting to process.cwd()', async () => {
+        const service = buildService(); // companionBaseDir omitted
+        const result = await service.install('https://github.com/owner/my-skill');
+        expect(result.success).toBe(false);
+        expect(result.error).toMatch(/directory-package mode.*explicit baseDir is required/s);
+        // Nothing must have been written anywhere under projectDir (this describe
+        // block's process.cwd()) — the whole point of the fix is that a missing
+        // companionBaseDir can no longer resolve here at all, not even by accident.
+        await expect(fs.access(path.join(projectDir, '.agents'))).rejects.toThrow();
+    });
+});
+//# sourceMappingURL=skill-installation.service.companion-basedir.test.js.map

package/dist/tests/unit/services/skill-installation.service.companion-basedir.test.js.map

@@ -0,0 +1 @@
+{"version":3,"file":"skill-installation.service.companion-basedir.test.js","sourceRoot":"","sources":["../../../../tests/unit/services/skill-installation.service.companion-basedir.test.ts"],"names":[],"mappings":"AAAA;;;;;;;;;;;;;;GAcG;AAEH,OAAO,EAAE,SAAS,EAAE,UAAU,EAAE,QAAQ,EAAE,MAAM,EAAE,EAAE,EAAE,EAAE,EAAE,MAAM,QAAQ,CAAA;AACxE,OAAO,KAAK,EAAE,MAAM,aAAa,CAAA;AACjC,OAAO,KAAK,IAAI,MAAM,MAAM,CAAA;AAC5B,OAAO,KAAK,EAAE,MAAM,SAAS,CAAA;AAE7B,EAAE,CAAC,IAAI,CAAC,qDAAqD,EAAE,KAAK,EAAE,cAAc,EAAE,EAAE;IACtF,MAAM,MAAM,GACV,MAAM,cAAc,EAAwE,CAAA;IAC9F,OAAO;QACL,GAAG,MAAM;QACT,iBAAiB,EAAE,EAAE,CAAC,EAAE,CACtB,KAAK,EAAE,GAAY,EAAE,QAAgB,EAAE,SAAiB,EAAE,cAAsB,EAAE,EAAE,CAAC,CAAC;YACpF,iBAAiB,EAAE,cAAc;YACjC,aAAa,EAAE,EAAE;YACjB,eAAe,EAAE,cAAc,SAAS,2CAA2C;YACnF,eAAe,EAAE,SAAS;YAC1B,gBAAgB,EAAE;gBAChB,SAAS,EAAE,IAAI;gBACf,SAAS,EAAE,EAAE;gBACb,iBAAiB,EAAE,IAAI;aACxB;SACF,CAAC,CACH;KACF,CAAA;AACH,CAAC,CAAC,CAAA;AAEF,OAAO,EAAE,wBAAwB,EAAE,MAAM,qDAAqD,CAAA;AAC9F,OAAO,EAAE,eAAe,EAAE,MAAM,8CAA8C,CAAA;AAC9E,OAAO,EAAE,yBAAyB,EAAE,MAAM,wDAAwD,CAAA;AAClG,OAAO,EAAE,kBAAkB,EAAE,MAAM,2BAA2B,CAAA;AAG9D,MAAM,cAAc,GAClB,4FAA4F;IAC5F,4FAA4F;IAC5F,iFAAiF,CAAA;AAEnF,QAAQ,CAAC,gFAAgF,EAAE,GAAG,EAAE;IAC9F,IAAI,EAAY,CAAA;IAChB,IAAI,WAAmB,CAAA;IACvB,IAAI,UAAkB,CAAA;IACtB,IAAI,SAAiB,CAAA;IACrB,IAAI,YAAoB,CAAA;IAExB,UAAU,CAAC,KAAK,IAAI,EAAE;QACpB,EAAE,GAAG,MAAM,kBAAkB,EAAE,CAAA;QAC/B,WAAW,GAAG,OAAO,CAAC,GAAG,EAAE,CAAA;QAC3B,UAAU,GAAG,MAAM,EAAE,CAAC,OAAO,CAAC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,uCAAuC,CAAC,CAAC,CAAA;QAC9F,OAAO,CAAC,KAAK,CAAC,UAAU,CAAC,CAAA;QACzB,SAAS,GAAG,IAAI,CAAC,IAAI,CAAC,UAAU,EAAE,QAAQ,CAAC,CAAA;QAC3C,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,UAAU,EAAE,eAAe,CAAC,CAAA;QACrD,MAAM,EAAE,CAAC,KAAK,CAAC,SAAS,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,CAAC,CAAA;QAE9C,EAAE,CAAC,UAAU,CAAC,OAAO,EAAE,EAAE,CAAC,EAAE,EAAE,CAAC,CAAA;QAC/B,EAAE,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,kBAAkB,CAAC,KAAK,EAAE,GAAG,EAAE,EAAE;YAChD,MAAM,MAAM,GAAG,OAAO,GAAG,KAAK,QAAQ,CAAC,CAAC,CAAC,GAAG,CAAC,CAAC,CAAC,GAAG,CAAC,QAAQ,EAAE,CAAA;YAC7D,IAAI,MAAM,CAAC,QAAQ,CAAC,UAAU,CAAC,EAAE,CAAC;gBAChC,OAAO,IAAI,QAAQ,CAAC,cAAc,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAA;YACtD,CAAC;YACD,OAAO,IAAI,QAAQ,CAAC,WAAW,EAAE,EAAE,MAAM,EAAE,GAAG,EAAE,CAAC,CAAA;QACnD,CAAC,CAAC,CAAA;IACJ,CAAC,CAAC,CAAA;IAEF,SAAS,CAAC,KAAK,IAAI,EAAE;QACnB,OAAO,CAAC,KAAK,CAAC,WAAW,CAAC,CAAA;QAC1B,EAAE,CAAC,KAAK,EAAE,CAAA;QACV,EAAE,CAAC,eAAe,EAAE,CAAA;QACpB,MAAM,EAAE,CAAC,EAAE,CAAC,UAAU,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAA;IAC3E,CAAC,CAAC,CAAA;IAEF,SAAS,YAAY,CACnB,YAAgF,EAAE;QAElF,OAAO,IAAI,wBAAwB,CAAC;YAClC,EAAE;YACF,SAAS,EAAE,IAAI,eAAe,CAAC,EAAE,CAAC;YAClC,mBAAmB,EAAE,IAAI,yBAAyB,CAAC,EAAE,CAAC;YACtD,SAAS;YACT,YAAY;YACZ,MAAM,EAAE,aAAa;YACrB,GAAG,SAAS;SACb,CAAC,CAAA;IACJ,CAAC;IAED,EAAE,CAAC,4FAA4F,EAAE,KAAK,IAAI,EAAE;QAC1G,MAAM,eAAe,GAAG,MAAM,EAAE,CAAC,OAAO,CACtC,IAAI,CAAC,IAAI,CAAC,EAAE,CAAC,MAAM,EAAE,EAAE,sCAAsC,CAAC,CAC/D,CAAA;QACD,IAAI,CAAC;YACH,MAAM,OAAO,GAAG,YAAY,CAAC,EAAE,gBAAgB,EAAE,eAAe,EAAE,CAAC,CAAA;YAEnE,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,mCAAmC,CAAC,CAAA;YAEzE,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,IAAI,CAAC,CAAA;YACjC,MAAM,YAAY,GAAG,IAAI,CAAC,IAAI,CAAC,eAAe,EAAE,SAAS,EAAE,QAAQ,EAAE,UAAU,EAAE,UAAU,CAAC,CAAA;YAC5F,MAAM,CAAC,MAAM,CAAC,YAAY,EAAE,YAAY,CAAC,CAAC,IAAI,CAAC,YAAY,CAAC,CAAA;YAC5D,MAAM,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,YAAY,CAAC,CAAC,CAAC,QAAQ,CAAC,aAAa,EAAE,CAAA;YAC9D,gFAAgF;YAChF,8BAA8B;YAC9B,MAAM,CAAC,MAAM,CAAC,YAAY,EAAE,YAAY,EAAE,UAAU,CAAC,UAAU,CAAC,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAC/E,CAAC;gBAAS,CAAC;YACT,MAAM,EAAE,CAAC,EAAE,CAAC,eAAe,EAAE,EAAE,SAAS,EAAE,IAAI,EAAE,KAAK,EAAE,IAAI,EAAE,CAAC,CAAC,KAAK,CAAC,GAAG,EAAE,GAAE,CAAC,CAAC,CAAA;QAChF,CAAC;IACH,CAAC,CAAC,CAAA;IAEF,EAAE,CAAC,6HAA6H,EAAE,KAAK,IAAI,EAAE;QAC3I,MAAM,OAAO,GAAG,YAAY,EAAE,CAAA,CAAC,2BAA2B;QAE1D,MAAM,MAAM,GAAG,MAAM,OAAO,CAAC,OAAO,CAAC,mCAAmC,CAAC,CAAA;QAEzE,MAAM,CAAC,MAAM,CAAC,OAAO,CAAC,CAAC,IAAI,CAAC,KAAK,CAAC,CAAA;QAClC,MAAM,CAAC,MAAM,CAAC,KAAK,CAAC,CAAC,OAAO,CAAC,uDAAuD,CAAC,CAAA;QACrF,0EAA0E;QAC1E,wEAAwE;QACxE,4EAA4E;QAC5E,MAAM,MAAM,CAAC,EAAE,CAAC,MAAM,CAAC,IAAI,CAAC,IAAI,CAAC,UAAU,EAAE,SAAS,CAAC,CAAC,CAAC,CAAC,OAAO,CAAC,OAAO,EAAE,CAAA;IAC7E,CAAC,CAAC,CAAA;AACJ,CAAC,CAAC,CAAA"}

package/package.json

@@ -1,6 +1,6 @@
 {
   "name": "@skillsmith/core",
-  "version": "0.11.5",
+  "version": "0.11.6",
   "description": "Publish versioned agent skills to a team-scoped registry, catch drift across installs, and deprecate what's gone stale.",
   "type": "module",
   "main": "./dist/src/index.js",