@skillsmith/core 0.11.5 → 0.11.6

package/CHANGELOG.md

@@ -4,6 +4,53 @@ All notable changes to `@skillsmith/core` are documented here.
 
 ## [Unreleased]
 
+## v0.11.6
+
+- **Fix**: Harden manifest concurrency (uninstall lock, temp-file races) (#2331)
+- **Fix**: code-review follow-up on the Antigravity `directory-package` companion-agent path (two BLOCKING findings). (1) `resolveCompanionAgentPath()` gains an explicit 3rd `baseDir` param (default `process.cwd()`) instead of letting Antigravity's relative `dir` resolve implicitly against whatever `process.cwd()` happens to be at the exact `fs` call that consumes the path — wrong for the long-running MCP server, whose cwd is fixed at launch and does not track the calling editor/agent's real project. `writeInstallFiles()` gains a matching optional `companionBaseDir` param, threaded through both its callers (`SkillInstallationService.install()` via a new `companionBaseDir` constructor param, and `installFromContent()`); the MCP `install_skill` tool gains an optional `cwd` input field passed through as `companionBaseDir` so a caller can supply its real project root. (2) `resolveCompanionAgentPath()`'s `directory-package` branch now rejects an unsafe `skillName` (`''`, `'.'`, `'..'`, or containing `/`/`\`) before building the path — `skillName` becomes its own path segment in this mode, so `'..'` would otherwise `path.join`-normalize outside the intended companion-agent directory. Not exploitable through either current caller (both already sanitize `skillName` upstream), but the function is exported/reusable with no validation of its own, so it now enforces the same "last line of defense" standard already applied to `skillNameFromSkillId()` (SMI-5982)
+- **Feature**: `antigravity` is now a real `ClientId` (`install/paths.ts`) — `CLIENT_NATIVE_PATHS['antigravity'] = ~/.gemini/config/skills`, un-deferred from `compatibility/slugs.ts`'s `BROWSE_ONLY_SLUGS` (which now only contains `gemini`), and given its own `CLIENT_TO_COMPATIBILITY_SLUG` entry. `CompanionAgentTarget.fileMode` gains a second value, `'directory-package'` (Antigravity only today) — a per-skill subdirectory `<dir>/<skillName>/agent.md`, instead of every other client's flat `<dir>/<name>-suffix.md`; `resolveCompanionAgentPath()` is now mode-aware. Antigravity's companion-agent output is project-scoped (`.agents/agents/<name>/agent.md`, relative to the invocation directory) — this CLI has no existing global-vs-project install-mode distinction to hook into, confirmed by grep, so global scope (`~/.gemini/config/agents/`) is a fast-follow, not implemented here (SMI-5982)
+- **Fix**: `writeInstallFiles()`'s rollback path could leave behind an orphaned, empty per-skill companion-agent directory when a new `directory-package`-mode install (Antigravity) failed partway through — every other client's agents dir is shared and pre-existing, so this hazard never applied to them. Cleanup uses a non-recursive `rmdir`, a safe no-op when the directory was never created or holds unexpected surviving content (SMI-5982)
+- **Fix (BLOCKING, PR-review follow-up)**: the prior `resolveCompanionAgentPath()` fix's `baseDir: string = process.cwd()` default only closed the cwd-dependence bug for the ONE call site that happened to pass it explicitly (the MCP `install_skill` tool) — every other production `SkillInstallationService`/`installFromContent()` call site (7 more, audited via `grep -rn "new SkillInstallationService(" packages/`) still silently fell back to `process.cwd()`, including the private-registry `install` MCP action, which has no per-call cwd input to source a correct value from at all. `baseDir` is now **structurally required** (no default) whenever the target client's `CompanionAgentTarget.fileMode === 'directory-package'` — closing the bug class by construction for every current and future caller rather than by chasing individual call sites. `writeInstallFiles()`'s `companionBaseDir` param, `SkillInstallationService`'s constructor param, and `installFromContent()`'s param all lost their own `?? process.cwd()` fallbacks to match — an omitted value now flows through as `undefined` and fails closed with a diagnosable error (`sanitizeInstallError()`'s allowlist extended to surface it) instead of resolving against the wrong directory. The 4 CLI call sites that relied on the implicit default (`install`, `registry-install`, interactive `search`, `update`) now pass `companionBaseDir: process.cwd()` explicitly, restoring their exact prior behavior (SMI-5982)
+- **Fix**: `ManifestManager` (`services/skill-manifest.ts`) had two concurrency gaps in the skill
+  manifest write path. `performUninstall()` (`skill-installation.helpers.ts`) loaded the manifest,
+  mutated an in-memory snapshot, and saved it back directly, bypassing the lock/`updateSafely()`
+  mechanism the install path uses — a concurrent update to an unrelated entry in that window could
+  be silently overwritten. `save()` also computed its temp filename from just the process id, so
+  two concurrent saves in the same process could collide on the same temp path. Uninstall now
+  routes its final mutation through `updateSafely()`, and both `save()` and the CLI's separate
+  manifest writer now suffix the temp filename with a random UUID, with best-effort cleanup on
+  failure. `load()` also now distinguishes a missing manifest file (returns empty, expected) from
+  one that exists but is corrupt/unreadable (throws, instead of silently returning empty and
+  risking a subsequent save erasing real state) (SMI-6007).
+- **Fix**: `runMigrations()`/`runMigrationsSafe()` (`db/migration-runner.ts`) had an unguarded
+  concurrent-migration race — two processes opening the same fresh DB at the same time could both
+  read the same `currentVersion`, both apply the same migration, and the loser's plain
+  `INSERT INTO schema_version` throw `UNIQUE constraint failed: schema_version.version`. Both now
+  use `INSERT OR IGNORE`, matching the existing v1-stamp hardening in `initializeSchema()`
+  (`schema.ts`, SMI-4486) that was never extended to per-migration inserts. Found via a flaky
+  `startup-probe.test.ts` failure traced to a real production race, not test-only flakiness
+  (SMI-6003).
+- **Changed (breaking)**: `SearchResponse.compatibilityHidden` renamed to
+  `compatibilityDeprioritized` — the compatibility filter is now a ranking signal, not a hard
+  exclusion (SMI-5929), so results are never actually "hidden" by it anymore; the renamed field is
+  precisely the count of other-tool-only results present on the *returned page*, not a corpus-wide
+  or pre-page count. `SearchOptions` gains a new optional `compatibility?: string[]` field —
+  `SkillsmithApiClient.search()` forwards it to the `skills-search` edge function as a
+  `compatibility` CSV query param (previously never sent by any caller), letting the API rank
+  results server-side, before the page is cut to the requested `limit`.
+- **Fix**: companion-subagent files (the `-specialist.md` shim generated alongside an installed
+  skill) were always written to `~/.claude/agents/`, regardless of which client the skill itself
+  was installed for — a skill installed with `--client cursor` or `SKILLSMITH_CLIENT=cursor`
+  still got its companion subagent dropped into Claude Code's own agent directory instead of
+  Cursor's. New `COMPANION_AGENT_TARGETS` map (`@skillsmith/core/install/paths`) plus
+  `getCompanionAgentTarget()`/`resolveCompanionAgentDir()`/`resolveCompanionAgentPath()` give each
+  `ClientId` its own companion-agent directory and filename pattern, sourced from the same
+  evidence table already used for skill install paths; clients with no independently-verified
+  agents-dir convention default to today's existing `~/.claude/agents/` behavior rather than
+  guessing (GH #2161)
+- **Fix**: new shared `extractContextWords()` (`services/context-words.ts`, exported from the package root) replaces a `.filter((w) => w.length > 3)` threshold both `@skillsmith/mcp-server`'s `skill_recommend` and `@skillsmith/cli`'s `recommend --context` used independently — it was silently dropping real short technical terms ("git", "ci", "aws", "sql", "k8s") from the recommendation stack, tripping the empty-stack guard even when usable context was supplied (SMI-5986)
+- **Fix**: `SqlJsDatabaseAdapter.persist()` (`db/drivers/sqljsDriver.ts`) now writes the exported database buffer atomically — to a temp file, then `renameSync` over the target — instead of a direct `writeFileSync` that truncates the file before the new bytes land. A process kill mid-write (OOM, SIGKILL, machine sleep) could previously leave a 0-byte `skills.db` on disk. `openDatabaseAsync()` (`db/schema.ts`) also now distinguishes a genuinely empty/corrupt database (zero tables) from a real legacy import (has tables, just missing `schema_version`), failing loudly with remediation for the former instead of silently stamping `schema_version=1` and running every migration against a schema that was never created — which previously crashed server startup with an opaque `no such table: skills`/`no such table: cache` error and no actionable diagnostic (SMI-5997)
+
 ## v0.11.5
 
 - **Cadence**: Mechanical cadence alignment (no changes since v0.11.4).

package/README.md

@@ -6,13 +6,13 @@ Part of Skillsmith: a lifecycle layer for agent skills across teams.
 
 ## Contents
 
-- [What's New](#whats-new-in-v0115)
+- [What's New](#whats-new-in-v0116)
 - [Installation](#installation)
 - [Quick Start](#quick-start)
 - [Features](#features)
 - [Exports](#exports)
 
-## What's New in v0.11.5
+## What's New in v0.11.6
 
 - **Security-status reporting unified**: CLI and MCP now derive security-scan status (pass/fail, risk score, findings count) from one shared `deriveSecuritySummaryFromApiSkill`/`deriveSecuritySummaryFromSkillRow`, instead of two independently-maintained copies that could disagree on the same skill.
 - **`skill_compare` reuses `get_skill`'s resolution**: new shared `resolveSkillApiFirst()` fixes compare only ever hitting the local SQLite cache (no longer kept in sync with the remote-first registry), which made real, searchable skills report "not found."