@semiont/react-ui 0.2.35-build.98 → 0.2.35

package/src/features/resource-viewer/__tests__/AnnotationCreationPending.test.tsx

@@ -1,13 +1,13 @@
 /**
- * Regression test: pendingAnnotation cleared after annotate:createsucceeds
+ * Regression test: pendingAnnotation cleared after mark:createsucceeds
  *
- * Bug: handleAnnotationCreate in useAnnotationFlow called the API and emitted
- * annotate:created, but never called setPendingAnnotation(null). The pending
+ * Bug: handleAnnotationCreate in useMarkFlow called the API and emitted
+ * mark:created, but never called setPendingAnnotation(null). The pending
  * creation form (e.g. "Create Reference", "Save" assessment) remained visible
  * after the user clicked the confirm button.
  *
  * Fix: setPendingAnnotation(null) added in handleAnnotationCreate on success,
- * before emitting annotate:created.
+ * before emitting mark:created.
  *
  * This test covers all four motivations that have a pending form:
  * - linking  (ReferencesPanel: "Create Reference" button)
@@ -20,7 +20,7 @@ import React from 'react';
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
 import { render, screen, waitFor } from '@testing-library/react';
 import { act } from 'react';
-import { useAnnotationFlow } from '../../../hooks/useAnnotationFlow';
+import { useMarkFlow } from '../../../hooks/useMarkFlow';
 import { EventBusProvider, useEventBus, resetEventBusForTesting } from '../../../contexts/EventBusContext';
 import { ApiClientProvider } from '../../../contexts/ApiClientContext';
 import { AuthTokenProvider } from '../../../contexts/AuthTokenContext';
@@ -71,7 +71,7 @@ function renderDetectionFlow(testUri: string) {
   }
 
   function DetectionFlowHarness() {
-    const { pendingAnnotation } = useAnnotationFlow(testUri as any);
+    const { pendingAnnotation } = useMarkFlow(testUri as any);
     return (
       <div>
         <div data-testid="pending-motivation">
@@ -122,16 +122,16 @@ describe('Annotation creation clears pendingAnnotation', () => {
 
     // Set a pending annotation
     act(() => {
-      emit('annotate:requested', { selector: TEXT_SELECTOR, motivation: 'linking' });
+      emit('mark:requested', { selector: TEXT_SELECTOR, motivation: 'linking' });
     });
 
     await waitFor(() => {
       expect(screen.getByTestId('pending-motivation')).toHaveTextContent('linking');
     });
 
-    // Emit annotate:create(what ReferencesPanel does when user clicks "Create Reference")
+    // Emit mark:create(what ReferencesPanel does when user clicks "Create Reference")
     await act(async () => {
-      emit('annotate:create', {
+      emit('mark:create', {
         motivation: 'linking',
         selector: TEXT_SELECTOR,
         body: [{ type: 'TextualBody', value: 'Person', purpose: 'tagging' }],
@@ -150,7 +150,7 @@ describe('Annotation creation clears pendingAnnotation', () => {
     const { emit } = renderDetectionFlow(TEST_URI);
 
     act(() => {
-      emit('annotate:requested', { selector: SVG_SELECTOR, motivation: 'assessing' });
+      emit('mark:requested', { selector: SVG_SELECTOR, motivation: 'assessing' });
     });
 
     await waitFor(() => {
@@ -158,7 +158,7 @@ describe('Annotation creation clears pendingAnnotation', () => {
     });
 
     await act(async () => {
-      emit('annotate:create', {
+      emit('mark:create', {
         motivation: 'assessing',
         selector: SVG_SELECTOR,
         body: [{ type: 'TextualBody', value: 'Looks good', purpose: 'assessing' }],
@@ -174,7 +174,7 @@ describe('Annotation creation clears pendingAnnotation', () => {
     const { emit } = renderDetectionFlow(TEST_URI);
 
     act(() => {
-      emit('annotate:requested', { selector: SVG_SELECTOR, motivation: 'assessing' });
+      emit('mark:requested', { selector: SVG_SELECTOR, motivation: 'assessing' });
     });
 
     await waitFor(() => {
@@ -183,7 +183,7 @@ describe('Annotation creation clears pendingAnnotation', () => {
 
     // Empty body is valid for assessments
     await act(async () => {
-      emit('annotate:create', {
+      emit('mark:create', {
         motivation: 'assessing',
         selector: SVG_SELECTOR,
         body: [],
@@ -199,7 +199,7 @@ describe('Annotation creation clears pendingAnnotation', () => {
     const { emit } = renderDetectionFlow(TEST_URI);
 
     act(() => {
-      emit('annotate:requested', { selector: TEXT_SELECTOR, motivation: 'commenting' });
+      emit('mark:requested', { selector: TEXT_SELECTOR, motivation: 'commenting' });
     });
 
     await waitFor(() => {
@@ -207,7 +207,7 @@ describe('Annotation creation clears pendingAnnotation', () => {
     });
 
     await act(async () => {
-      emit('annotate:create', {
+      emit('mark:create', {
         motivation: 'commenting',
         selector: TEXT_SELECTOR,
         body: [{ type: 'TextualBody', value: 'Great point', purpose: 'commenting' }],
@@ -223,7 +223,7 @@ describe('Annotation creation clears pendingAnnotation', () => {
     const { emit } = renderDetectionFlow(TEST_URI);
 
     act(() => {
-      emit('annotate:requested', { selector: SVG_SELECTOR, motivation: 'tagging' });
+      emit('mark:requested', { selector: SVG_SELECTOR, motivation: 'tagging' });
     });
 
     await waitFor(() => {
@@ -231,7 +231,7 @@ describe('Annotation creation clears pendingAnnotation', () => {
     });
 
     await act(async () => {
-      emit('annotate:create', {
+      emit('mark:create', {
         motivation: 'tagging',
         selector: SVG_SELECTOR,
         body: [{ type: 'TextualBody', value: 'concept:trust', purpose: 'tagging' }],
@@ -243,20 +243,20 @@ describe('Annotation creation clears pendingAnnotation', () => {
     });
   });
 
-  it('emits annotate:created after successful creation', async () => {
+  it('emits mark:created after successful creation', async () => {
     const { emit, getEventBus } = renderDetectionFlow(TEST_URI);
 
     const createdListener = vi.fn();
     // Set listener after first render so eventBus is captured
     await waitFor(() => expect(getEventBus()).toBeDefined());
-    const subscription = getEventBus().get('annotate:created').subscribe(createdListener);
+    const subscription = getEventBus().get('mark:created').subscribe(createdListener);
 
     act(() => {
-      emit('annotate:requested', { selector: TEXT_SELECTOR, motivation: 'linking' });
+      emit('mark:requested', { selector: TEXT_SELECTOR, motivation: 'linking' });
     });
 
     await act(async () => {
-      emit('annotate:create', {
+      emit('mark:create', {
         motivation: 'linking',
         selector: TEXT_SELECTOR,
         body: [],
@@ -277,7 +277,7 @@ describe('Annotation creation clears pendingAnnotation', () => {
     const { emit } = renderDetectionFlow(TEST_URI);
 
     act(() => {
-      emit('annotate:requested', { selector: TEXT_SELECTOR, motivation: 'linking' });
+      emit('mark:requested', { selector: TEXT_SELECTOR, motivation: 'linking' });
     });
 
     await waitFor(() => {
@@ -285,7 +285,7 @@ describe('Annotation creation clears pendingAnnotation', () => {
     });
 
     await act(async () => {
-      emit('annotate:create', {
+      emit('mark:create', {
         motivation: 'linking',
         selector: TEXT_SELECTOR,
         body: [],
@@ -299,11 +299,11 @@ describe('Annotation creation clears pendingAnnotation', () => {
     });
   });
 
-  it('clears pendingAnnotation on cancel (annotate:cancel-pending)', async () => {
+  it('clears pendingAnnotation on cancel (mark:cancel-pending)', async () => {
     const { emit } = renderDetectionFlow(TEST_URI);
 
     act(() => {
-      emit('annotate:requested', { selector: TEXT_SELECTOR, motivation: 'assessing' });
+      emit('mark:requested', { selector: TEXT_SELECTOR, motivation: 'assessing' });
     });
 
     await waitFor(() => {
@@ -311,7 +311,7 @@ describe('Annotation creation clears pendingAnnotation', () => {
     });
 
     act(() => {
-      emit('annotate:cancel-pending', undefined);
+      emit('mark:cancel-pending', undefined);
     });
 
     await waitFor(() => {

package/src/features/resource-viewer/__tests__/AnnotationDeletionIntegration.test.tsx

@@ -4,7 +4,7 @@
  * Tests the COMPLETE annotation deletion flow with real component composition:
  * - EventBusProvider (REAL)
  * - ApiClientProvider (REAL, with MOCKED client)
- * - useAnnotationFlow (REAL) — single registration point for useResolutionFlow
+ * - useMarkFlow (REAL) — single registration point for useBindFlow
  * - useEventSubscriptions (REAL)
  *
  * This test focuses on ARCHITECTURE and EVENT WIRING:
@@ -15,18 +15,18 @@
  *
  * CRITICAL: This test prevents regressions where:
  * - Multiple deletion paths exist (event-driven vs direct)
- * - useResolutionFlow called in more than one hook (causes duplicate subscriptions)
+ * - useBindFlow called in more than one hook (causes duplicate subscriptions)
  * - Auth token missing from API calls (401 errors)
  *
- * ARCHITECTURE: useResolutionFlow is called ONLY in useAnnotationFlow.
- * useAnnotationFlow handles all detection state (manual annotation selection
- * and AI-driven SSE detection) plus all API operations via useResolutionFlow.
+ * ARCHITECTURE: useBindFlow is called ONLY in useMarkFlow.
+ * useMarkFlow handles all detection state (manual annotation selection
+ * and AI-driven SSE detection) plus all API operations via useBindFlow.
  */
 
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
 import { render, waitFor } from '@testing-library/react';
 import { act } from 'react';
-import { useAnnotationFlow } from '../../../hooks/useAnnotationFlow';
+import { useMarkFlow } from '../../../hooks/useMarkFlow';
 import { EventBusProvider, useEventBus, resetEventBusForTesting } from '../../../contexts/EventBusContext';
 
 // Mock Toast module to prevent "useToast must be used within a ToastProvider" errors
@@ -70,9 +70,9 @@ describe('Annotation Deletion - Feature Integration', () => {
 
     function TestComponent() {
       eventBusInstance = useEventBus();
-      // useAnnotationFlow is the single registration point for useResolutionFlow
-      // (handles annotate:delete annotate:create annotate:detect-request, etc.)
-      useAnnotationFlow(testUri);
+      // useMarkFlow is the single registration point for useBindFlow
+      // (handles mark:delete mark:create annotate:detect-request, etc.)
+      useMarkFlow(testUri);
       return null;
     }
 
@@ -89,14 +89,14 @@ describe('Annotation Deletion - Feature Integration', () => {
     return {
       emitDelete: (annotationId: string) => {
         act(() => {
-          eventBusInstance!.get('annotate:delete').next({ annotationId });
+          eventBusInstance!.get('mark:delete').next({ annotationId });
         });
       },
       eventBus: eventBusInstance!,
     };
   }
 
-  it('should call deleteAnnotation API exactly ONCE when annotate:deleteevent is emitted', async () => {
+  it('should call deleteAnnotation API exactly ONCE when mark:deleteevent is emitted', async () => {
     const { emitDelete } = renderAnnotationFlow();
     const annotationId = 'annotation-123';
 
@@ -133,12 +133,12 @@ describe('Annotation Deletion - Feature Integration', () => {
     expect(callArgs[1].auth).toBe(accessToken(testToken));
   });
 
-  it('should emit annotate:deleted event on successful deletion', async () => {
+  it('should emit mark:deleted event on successful deletion', async () => {
     const { emitDelete, eventBus } = renderAnnotationFlow();
     const deletedListener = vi.fn();
 
     // Subscribe to success event
-    eventBus.get('annotate:deleted').subscribe(deletedListener);
+    eventBus.get('mark:deleted').subscribe(deletedListener);
 
     emitDelete('annotation-789');
 
@@ -155,7 +155,7 @@ describe('Annotation Deletion - Feature Integration', () => {
     });
   });
 
-  it('should emit annotate:delete-failed event on API error', async () => {
+  it('should emit mark:delete-failed event on API error', async () => {
     // Make API call fail
     deleteAnnotationSpy.mockRejectedValue(new Error('Network error'));
 
@@ -163,7 +163,7 @@ describe('Annotation Deletion - Feature Integration', () => {
     const failedListener = vi.fn();
 
     // Subscribe to failure event
-    eventBus.get('annotate:delete-failed').subscribe(failedListener);
+    eventBus.get('mark:delete-failed').subscribe(failedListener);
 
     emitDelete('annotation-error');
 
@@ -202,13 +202,13 @@ describe('Annotation Deletion - Feature Integration', () => {
     expect(deleteAnnotationSpy.mock.calls[1][0]).toContain('annotation-2');
   });
 
-  it('ARCHITECTURE: useResolutionFlow is called in useAnnotationFlow (single registration point)', async () => {
+  it('ARCHITECTURE: useBindFlow is called in useMarkFlow (single registration point)', async () => {
     /**
      * This test validates that there's only ONE event-driven deletion path:
-     * - useAnnotationFlow calls useResolutionFlow (the single registration point)
-     * - useResolutionFlow subscribes to annotation:delete
+     * - useMarkFlow calls useBindFlow (the single registration point)
+     * - useBindFlow subscribes to annotation:delete
      *
-     * If this test fails with 2 API calls, it means useResolutionFlow was added
+     * If this test fails with 2 API calls, it means useBindFlow was added
      * to a second hook, causing duplicate subscriptions (ARCHITECTURE VIOLATION).
      */
 
@@ -229,8 +229,8 @@ describe('Annotation Deletion - Feature Integration', () => {
      * that bypassed the event bus.
      *
      * The correct pattern is event-driven only:
-     * - UI emits annotate:deleteevent
-     * - useResolutionFlow handles it
+     * - UI emits mark:deleteevent
+     * - useBindFlow handles it
      * - No direct function calls
      */
 

package/src/features/resource-viewer/__tests__/AnnotationProgressDismissal.test.tsx

@@ -8,20 +8,20 @@
  * 4. BUG: Progress modal stays visible showing "Processing: Location" indefinitely
  *
  * ROOT CAUSE:
- * - useAnnotationFlow.ts (line 54-62): annotate:assist-finished clears `assistingMotivation` but keeps `progress`
+ * - useMarkFlow.ts (line 54-62): mark:assist-finished clears `assistingMotivation` but keeps `progress`
  * - AssistSection.tsx (line 214): Shows progress UI whenever `progress` is not null
  * - No mechanism to auto-dismiss or manually close the progress display
  *
  * FIX OPTIONS:
  * A) Auto-dismiss after timeout (3s after completion)
  * B) Add "Close" button to progress display
- * C) Clear progress on next annotate:assist-request (already works but not ideal UX)
+ * C) Clear progress on next mark:assist-request (already works but not ideal UX)
  */
 
 import { describe, it, expect, vi, beforeEach, afterEach } from 'vitest';
 import { render, screen, waitFor } from '@testing-library/react';
 import { act } from 'react';
-import { useAnnotationFlow } from '../../../hooks/useAnnotationFlow';
+import { useMarkFlow } from '../../../hooks/useMarkFlow';
 import { EventBusProvider, resetEventBusForTesting, useEventBus } from '../../../contexts/EventBusContext';
 import { ApiClientProvider } from '../../../contexts/ApiClientContext';
 import { AuthTokenProvider } from '../../../contexts/AuthTokenContext';
@@ -65,7 +65,7 @@ describe('Detection Progress Dismissal Bug', () => {
 
     function TestHarness() {
       eventBusInstance = useEventBus();
-      const { assistingMotivation, progress } = useAnnotationFlow(rUri);
+      const { assistingMotivation, progress } = useMarkFlow(rUri);
 
       return (
         <div>
@@ -91,9 +91,9 @@ describe('Detection Progress Dismissal Bug', () => {
     expect(screen.getByTestId('detecting')).toHaveTextContent('none');
     expect(screen.getByTestId('progress')).toHaveTextContent('no progress');
 
-    // User clicks detect button (emits annotate:assist-request)
+    // User clicks detect button (emits mark:assist-request)
     act(() => {
-      eventBusInstance.get('annotate:assist-request').next({
+      eventBusInstance.get('mark:assist-request').next({
         motivation: 'linking',
         options: { entityTypes: ['Location'] }
       });
@@ -106,7 +106,7 @@ describe('Detection Progress Dismissal Bug', () => {
 
     // SSE sends progress update
     act(() => {
-      eventBusInstance.get('annotate:progress').next({
+      eventBusInstance.get('mark:progress').next({
         status: 'scanning',
         message: 'Processing: Location',
         currentEntityType: 'Location',
@@ -118,9 +118,9 @@ describe('Detection Progress Dismissal Bug', () => {
       expect(screen.getByTestId('progress')).toHaveTextContent('Processing: Location');
     });
 
-    // Detection completes (SSE finishes, backend emits annotate:assist-finished)
+    // Detection completes (SSE finishes, backend emits mark:assist-finished)
     act(() => {
-      eventBusInstance.get('annotate:assist-finished').next({ motivation: 'linking' });
+      eventBusInstance.get('mark:assist-finished').next({ motivation: 'linking' });
     });
 
     // assistingMotivation cleared immediately
@@ -138,7 +138,7 @@ describe('Detection Progress Dismissal Bug', () => {
 
     function TestHarness() {
       eventBusInstance = useEventBus();
-      const { progress } = useAnnotationFlow(rUri);
+      const { progress } = useMarkFlow(rUri);
 
       return (
         <div data-testid="progress">
@@ -159,15 +159,15 @@ describe('Detection Progress Dismissal Bug', () => {
 
     // First detection with stuck progress
     act(() => {
-      eventBusInstance.get('annotate:assist-request').next({ motivation: 'linking', options: {} });
+      eventBusInstance.get('mark:assist-request').next({ motivation: 'linking', options: {} });
     });
 
     act(() => {
-      eventBusInstance.get('annotate:progress').next({ message: 'Old progress stuck here' });
+      eventBusInstance.get('mark:progress').next({ message: 'Old progress stuck here' });
     });
 
     act(() => {
-      eventBusInstance.get('annotate:assist-finished').next({ motivation: 'linking' });
+      eventBusInstance.get('mark:assist-finished').next({ motivation: 'linking' });
     });
 
     await waitFor(() => {
@@ -176,7 +176,7 @@ describe('Detection Progress Dismissal Bug', () => {
 
     // WORKAROUND: Start new detection clears old progress
     act(() => {
-      eventBusInstance.get('annotate:assist-request').next({ motivation: 'highlighting', options: {} });
+      eventBusInstance.get('mark:assist-request').next({ motivation: 'highlighting', options: {} });
     });
 
     await waitFor(() => {
@@ -191,7 +191,7 @@ describe('Detection Progress Dismissal Bug', () => {
 
     function TestHarness() {
       eventBusInstance = useEventBus();
-      const { progress } = useAnnotationFlow(rUri);
+      const { progress } = useMarkFlow(rUri);
 
       return (
         <div data-testid="progress">
@@ -212,18 +212,18 @@ describe('Detection Progress Dismissal Bug', () => {
 
     // Show progress
     act(() => {
-      eventBusInstance.get('annotate:assist-request').next({ motivation: 'linking', options: {} });
+      eventBusInstance.get('mark:assist-request').next({ motivation: 'linking', options: {} });
     });
 
     act(() => {
-      eventBusInstance.get('annotate:progress').next({
+      eventBusInstance.get('mark:progress').next({
         status: 'complete',
         message: 'Complete! Created 5 annotations'
       });
     });
 
     act(() => {
-      eventBusInstance.get('annotate:assist-finished').next({ motivation: 'linking' });
+      eventBusInstance.get('mark:assist-finished').next({ motivation: 'linking' });
     });
 
     // Progress visible initially
@@ -242,7 +242,7 @@ describe('Detection Progress Dismissal Bug', () => {
   it('FIXED: SSE emits final completion chunk data as annotate:assist-progress', async () => {
     /**
      * This test verifies that SSE emits the final chunk as annotate:assist-progress
-     * BEFORE emitting annotate:assist-finished.
+     * BEFORE emitting mark:assist-finished.
      *
      * This ensures the UI can display the final completion message with status:'complete'.
      */
@@ -251,7 +251,7 @@ describe('Detection Progress Dismissal Bug', () => {
 
     function TestHarness() {
       eventBusInstance = useEventBus();
-      const { progress } = useAnnotationFlow(rUri);
+      const { progress } = useMarkFlow(rUri);
 
       return (
         <div>
@@ -273,7 +273,7 @@ describe('Detection Progress Dismissal Bug', () => {
 
     // Start detection (triggers SSE stream creation)
     act(() => {
-      eventBusInstance.get('annotate:assist-request').next({
+      eventBusInstance.get('mark:assist-request').next({
         motivation: 'linking',
         options: { entityTypes: ['Location'] }
       });
@@ -281,7 +281,7 @@ describe('Detection Progress Dismissal Bug', () => {
 
     // Simulate SSE scanning chunk
     act(() => {
-      eventBusInstance.get('annotate:progress').next({
+      eventBusInstance.get('mark:progress').next({
         status: 'scanning',
         message: 'Processing: Location',
       });
@@ -293,7 +293,7 @@ describe('Detection Progress Dismissal Bug', () => {
 
     // Simulate SSE emitting final chunk as annotate:assist-progress
     act(() => {
-      eventBusInstance.get('annotate:progress').next({
+      eventBusInstance.get('mark:progress').next({
         status: 'complete',
         message: 'Complete! Found 5 entities',
         foundCount: 5,