@selesai/code 0.8.3 → 0.8.5

package/dist/extensions/pi-subagents/test/unit/chain-append.test.ts

@@ -12,6 +12,8 @@ import {
 } from "../../src/runs/background/chain-append.ts";
 import type { AsyncStatus } from "../../src/shared/types.ts";
 import type { RunnerStep } from "../../src/runs/shared/parallel-utils.ts";
+import { claimRunFanoutBatchWithCommit, createRunFanoutBudget, getRunFanoutBudgetSnapshot } from "../../src/runs/shared/run-fanout-budget.ts";
+import { PROMPT_REDACTED } from "../../src/shared/utils.ts";
 import { createTempDir, removeTempDir } from "../support/helpers.ts";
 
 function writeStatus(asyncDir: string, status: Partial<AsyncStatus> & Pick<AsyncStatus, "runId" | "mode" | "state" | "startedAt">): void {
@@ -44,13 +46,13 @@ describe("chain append requests", () => {
 				startedAt: 100,
 				lastUpdate: 100,
 				chainStepCount: 1,
-				steps: [{ agent: "explorer", status: "running" }],
+				steps: [{ agent: "scout", status: "running" }],
 			});
 
 			const result = enqueueChainAppendRequest({
 				asyncDir,
 				runId: "run-a",
-				steps: [runnerStep("builder")],
+				steps: [runnerStep("worker")],
 				now: 200,
 			});
 
@@ -71,6 +73,75 @@ describe("chain append requests", () => {
 		}
 	});
 
+	it("persists the request inside the admission callback", () => {
+		const root = createTempDir("pi-chain-append-admission-");
+		try {
+			const asyncDir = path.join(root, "run-admission");
+			writeStatus(asyncDir, {
+				runId: "run-admission",
+				mode: "chain",
+				state: "running",
+				startedAt: 100,
+				steps: [{ agent: "scout", status: "running" }],
+			});
+			let admitted = false;
+			const result = enqueueChainAppendRequest({
+				asyncDir,
+				runId: "run-admission",
+				steps: [runnerStep("worker")],
+				now: 200,
+				admit: (persist) => {
+					assert.equal(countPendingChainAppendRequests(asyncDir), 0);
+					persist();
+					admitted = true;
+				},
+			});
+
+			assert.equal(admitted, true);
+			assert.equal(result.pendingCount, 1);
+		} finally {
+			removeTempDir(root);
+		}
+	});
+
+	it("reports accepted appends and keeps admission claims when bookkeeping fails after persistence", () => {
+		const root = createTempDir("pi-chain-append-bookkeeping-");
+		const budget = createRunFanoutBudget("append-bookkeeping", 1);
+		try {
+			const asyncDir = path.join(root, "run-bookkeeping");
+			writeStatus(asyncDir, {
+				runId: "run-bookkeeping",
+				mode: "chain",
+				state: "running",
+				startedAt: 100,
+				steps: [{ agent: "scout", status: "running" }],
+			});
+			const statusPath = path.join(asyncDir, "status.json");
+			fs.mkdirSync(path.join(asyncDir, "events.jsonl"));
+
+			const result = enqueueChainAppendRequest({
+				asyncDir,
+				runId: "run-bookkeeping",
+				steps: [runnerStep("worker")],
+				now: 200,
+				admit: (persist) => claimRunFanoutBatchWithCommit(budget, ["chain[1]"], () => {
+					persist();
+					fs.rmSync(statusPath, { force: true });
+					fs.mkdirSync(statusPath);
+				}),
+			});
+
+			assert.equal(result.pendingCount, 1);
+			assert.match(result.bookkeepingError ?? "", /status update failed/);
+			assert.match(result.bookkeepingError ?? "", /event append failed/);
+			assert.equal(readPendingChainAppendRequests(asyncDir).length, 1);
+			assert.deepEqual(getRunFanoutBudgetSnapshot(budget), { used: 1, limit: 1, remaining: 0 });
+		} finally {
+			fs.rmSync(budget.directory, { recursive: true, force: true });
+			removeTempDir(root);
+		}
+	});
+
 	it("reads pending append requests without consuming them and reports reserved output names", () => {
 		const root = createTempDir("pi-chain-append-pending-");
 		try {
@@ -80,15 +151,15 @@ describe("chain append requests", () => {
 				mode: "chain",
 				state: "running",
 				startedAt: 100,
-				steps: [{ agent: "explorer", status: "running" }],
+				steps: [{ agent: "scout", status: "running" }],
 			});
 			enqueueChainAppendRequest({
 				asyncDir,
 				runId: "run-pending",
 				steps: [{
 					parallel: [
-						{ ...runnerStep("builder"), outputName: "draft" },
-						{ ...runnerStep("commentator"), outputName: "review" },
+						{ ...runnerStep("worker"), outputName: "draft" },
+						{ ...runnerStep("reviewer"), outputName: "review" },
 					],
 				}],
 				now: 200,
@@ -113,10 +184,10 @@ describe("chain append requests", () => {
 				mode: "chain",
 				state: "complete",
 				startedAt: 100,
-				steps: [{ agent: "explorer", status: "complete" }],
+				steps: [{ agent: "scout", status: "complete" }],
 			});
 			assert.throws(
-				() => enqueueChainAppendRequest({ asyncDir: completeDir, runId: "complete", steps: [runnerStep("builder")] }),
+				() => enqueueChainAppendRequest({ asyncDir: completeDir, runId: "complete", steps: [runnerStep("worker")] }),
 				/only running chain runs/,
 			);
 
@@ -126,10 +197,10 @@ describe("chain append requests", () => {
 				mode: "parallel",
 				state: "running",
 				startedAt: 100,
-				steps: [{ agent: "explorer", status: "running" }],
+				steps: [{ agent: "scout", status: "running" }],
 			});
 			assert.throws(
-				() => enqueueChainAppendRequest({ asyncDir: parallelDir, runId: "parallel", steps: [runnerStep("builder")] }),
+				() => enqueueChainAppendRequest({ asyncDir: parallelDir, runId: "parallel", steps: [runnerStep("worker")] }),
 				/only active chain runs/,
 			);
 
@@ -139,10 +210,10 @@ describe("chain append requests", () => {
 				mode: "chain",
 				state: "running",
 				startedAt: 100,
-				steps: [{ agent: "explorer", status: "complete" }],
+				steps: [{ agent: "scout", status: "complete" }],
 			});
 			assert.throws(
-				() => enqueueChainAppendRequest({ asyncDir: drainedDir, runId: "drained", steps: [runnerStep("builder")] }),
+				() => enqueueChainAppendRequest({ asyncDir: drainedDir, runId: "drained", steps: [runnerStep("worker")] }),
 				/no running or pending chain steps left/,
 			);
 		} finally {
@@ -158,7 +229,7 @@ describe("chain append requests", () => {
 			startedAt: 100,
 			currentStep: 0,
 			chainStepCount: 1,
-			steps: [{ agent: "explorer", status: "complete" }],
+			steps: [{ agent: "scout", status: "complete" }],
 			parallelGroups: [],
 			workflowGraph: {
 				runId: "run-graph",
@@ -167,8 +238,8 @@ describe("chain append requests", () => {
 				nodes: [{
 					id: "step-0",
 					kind: "step",
-					agent: "explorer",
-					label: "explorer",
+					agent: "scout",
+					label: "scout",
 					status: "completed",
 					flatIndex: 0,
 					stepIndex: 0,
@@ -176,10 +247,10 @@ describe("chain append requests", () => {
 			},
 		};
 		const appended: RunnerStep[] = [
-			runnerStep("builder"),
+			runnerStep("worker"),
 			{
 				parallel: [
-					runnerStep("commentator"),
+					runnerStep("reviewer"),
 					runnerStep("auditor"),
 				],
 				concurrency: 2,
@@ -193,16 +264,16 @@ describe("chain append requests", () => {
 		assert.equal(status.pendingAppends, 0);
 		assert.equal(status.lastUpdate, 300);
 		assert.deepEqual(status.steps?.map((step) => `${step.agent}:${step.status}`), [
-			"explorer:complete",
-			"builder:pending",
-			"commentator:pending",
+			"scout:complete",
+			"worker:pending",
+			"reviewer:pending",
 			"auditor:pending",
 		]);
-		// Appended steps must carry their own bounded task description for fleet display.
+		// Appended steps must not carry raw task text into durable status.
 		assert.deepEqual(status.steps?.slice(1).map((step) => step.description), [
-			"Use {previous}",
-			"Use {previous}",
-			"Use {previous}",
+			PROMPT_REDACTED,
+			PROMPT_REDACTED,
+			PROMPT_REDACTED,
 		]);
 		assert.deepEqual(status.parallelGroups, [{ start: 2, count: 2, stepIndex: 2 }]);
 		assert.equal(status.workflowGraph?.nodes[1]?.id, "step-1");

package/dist/extensions/pi-subagents/test/unit/chain-root-attachment.test.ts

@@ -39,12 +39,12 @@ describe("async chain root attachment", () => {
 			mode: "single",
 			state: "complete",
 			startedAt: 1,
-			steps: [{ agent: "builder", status: "complete", sessionFile }],
+			steps: [{ agent: "worker", status: "complete", sessionFile }],
 		});
 		writeJson(importedRoot.resultPath, {
 			state: "complete",
 			success: true,
-			results: [{ agent: "builder", output: "root output", success: true, sessionFile }],
+			results: [{ agent: "worker", output: "root output", success: true, sessionFile }],
 		});
 
 		const result = await waitForImportedAsyncRoot(importedRoot, { pollIntervalMs: 1 });
@@ -55,7 +55,7 @@ describe("async chain root attachment", () => {
 			exitCode: result.exitCode,
 			sessionFile: result.sessionFile,
 		}, {
-			agent: "builder",
+			agent: "worker",
 			output: "root output",
 			exitCode: 0,
 			sessionFile,
@@ -69,7 +69,7 @@ describe("async chain root attachment", () => {
 			mode: "single",
 			state: "running",
 			startedAt: 1,
-			steps: [{ agent: "builder", status: "running" }],
+			steps: [{ agent: "worker", status: "running" }],
 		});
 
 		const waiting = waitForImportedAsyncRoot(importedRoot, { pollIntervalMs: 5 });
@@ -77,7 +77,7 @@ describe("async chain root attachment", () => {
 			writeJson(importedRoot.resultPath, {
 				state: "complete",
 				success: true,
-				results: [{ agent: "builder", output: "late root output", success: true }],
+				results: [{ agent: "worker", output: "late root output", success: true }],
 			});
 		}, 20);
 
@@ -95,13 +95,13 @@ describe("async chain root attachment", () => {
 			state: "failed",
 			startedAt: 1,
 			error: "root failed",
-			steps: [{ agent: "builder", status: "failed", error: "root failed" }],
+			steps: [{ agent: "worker", status: "failed", error: "root failed" }],
 		});
 		writeJson(importedRoot.resultPath, {
 			state: "failed",
 			success: false,
 			summary: "root failed",
-			results: [{ agent: "builder", output: "root failed", error: "root failed", success: false }],
+			results: [{ agent: "worker", output: "root failed", error: "root failed", success: false }],
 		});
 
 		const result = await waitForImportedAsyncRoot(importedRoot, { pollIntervalMs: 1 });
@@ -118,7 +118,7 @@ describe("async chain root attachment", () => {
 			mode: "single",
 			state: "complete",
 			startedAt: 1,
-			steps: [{ agent: "builder", status: "complete" }],
+			steps: [{ agent: "worker", status: "complete" }],
 		});
 
 		const result = await waitForImportedAsyncRoot(importedRoot, {
@@ -137,7 +137,7 @@ describe("async chain root attachment", () => {
 			mode: "single",
 			state: "running",
 			startedAt: 1,
-			steps: [{ agent: "builder", status: "running" }],
+			steps: [{ agent: "worker", status: "running" }],
 		});
 		let timedOut = false;
 		const waiting = waitForImportedAsyncRoot(importedRoot, {

package/dist/extensions/pi-subagents/test/unit/chain-serializer.test.ts

@@ -7,7 +7,7 @@ name: review-chain
 description: Review chain
 ---
 
-## commentator
+## reviewer
 output: report.md
 outputMode: file-only
 
@@ -28,7 +28,7 @@ name: review-chain
 description: Review chain
 ---
 
-## commentator
+## reviewer
 phase: Review
 label: correctness pass
 as: correctnessFindings
@@ -54,7 +54,7 @@ name: review-chain
 description: Review chain
 ---
 
-## commentator
+## reviewer
 toolBudget: {"soft":3,"hard":5,"block":["read","grep"]}
 
 Review the diff
@@ -71,12 +71,12 @@ name: review-chain
 description: Review chain
 ---
 
-## commentator
+## reviewer
 toolBudget: {"soft":6,"hard":5}
 
 Review the diff
 `, "project", "/tmp/review-chain.md"),
-			/toolBudget for step 'commentator'\.soft must be <= toolBudget for step 'commentator'\.hard/,
+			/toolBudget for step 'reviewer'\.soft must be <= toolBudget for step 'reviewer'\.hard/,
 		);
 	});
 
@@ -87,7 +87,7 @@ name: review-chain
 description: Review chain
 ---
 
-## commentator
+## reviewer
 outputSchema: {"type":"object"}
 
 Review the diff
@@ -102,10 +102,10 @@ Review the diff
 				name: "bad-dynamic-review",
 				description: "Bad dynamic targets",
 				chain: [
-					{ agent: "explorer", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
+					{ agent: "scout", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
 					{
 						expand: { from: { output: "targets", path: "/items" }, maxItems: 4 },
-						parallel: [{ agent: "commentator", task: "Review" }],
+						parallel: [{ agent: "reviewer", task: "Review" }],
 						collect: { as: "reviews" },
 					},
 				],
@@ -124,10 +124,10 @@ Review the diff
 			package: "code-analysis",
 			description: "Review dynamic targets",
 			chain: [
-				{ agent: "explorer", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
+				{ agent: "scout", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
 				{
 					expand: { from: { output: "targets", path: "/items" }, item: "target", key: "/path", maxItems: 4 },
-					parallel: { agent: "commentator", task: "Review {target.path}", outputSchema: { type: "object" } },
+					parallel: { agent: "reviewer", task: "Review {target.path}", outputSchema: { type: "object" } },
 					collect: { as: "reviews" },
 				},
 			],
@@ -146,10 +146,10 @@ Review the diff
 			name: "dynamic-review",
 			description: "Review dynamic targets",
 			chain: [
-				{ agent: "explorer", task: "Return targets", as: "targets", outputSchema: { type: "object" }, toolBudget: { hard: 4 } },
+				{ agent: "scout", task: "Return targets", as: "targets", outputSchema: { type: "object" }, toolBudget: { hard: 4 } },
 				{
 					expand: { from: { output: "targets", path: "/items" }, item: "target", key: "/path", maxItems: 4 },
-					parallel: { agent: "commentator", task: "Review {target.path}", outputSchema: { type: "object" }, toolBudget: { soft: 3, hard: 5 } },
+					parallel: { agent: "reviewer", task: "Review {target.path}", outputSchema: { type: "object" }, toolBudget: { soft: 3, hard: 5 } },
 					collect: { as: "reviews" },
 				},
 			],
@@ -164,7 +164,7 @@ Review the diff
 			() => parseJsonChain(JSON.stringify({
 				name: "bad-tool-budget",
 				description: "Bad tool budget",
-				chain: [{ agent: "builder", toolBudget: { hard: 0 } }],
+				chain: [{ agent: "worker", toolBudget: { hard: 0 } }],
 			}), "project", "/tmp/bad-tool-budget.chain.json"),
 			/step 1 toolBudget\.hard must be an integer >= 1/,
 		);
@@ -173,8 +173,8 @@ Review the diff
 				name: "bad-dynamic-tool-budget",
 				description: "Bad dynamic tool budget",
 				chain: [
-					{ agent: "explorer", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
-					{ expand: { from: { output: "targets", path: "/items" }, maxItems: 4 }, parallel: { agent: "builder", toolBudget: { hard: 3, block: [] } }, collect: { as: "reviews" } },
+					{ agent: "scout", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
+					{ expand: { from: { output: "targets", path: "/items" }, maxItems: 4 }, parallel: { agent: "worker", toolBudget: { hard: 3, block: [] } }, collect: { as: "reviews" } },
 				],
 			}), "project", "/tmp/bad-dynamic-tool-budget.chain.json"),
 			/step 2 dynamic template toolBudget\.block must contain at least one tool name/,
@@ -186,10 +186,10 @@ Review the diff
 			name: "dynamic-review",
 			description: "Review dynamic targets",
 			chain: [
-				{ agent: "explorer", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
+				{ agent: "scout", task: "Return targets", as: "targets", outputSchema: { type: "object" } },
 				{
 					expand: { from: { output: "targets", path: "/items" }, item: "target", key: "/path", maxItems: 4 },
-					parallel: { agent: "commentator", task: "Review {target.path}", outputSchema: { type: "object" } },
+					parallel: { agent: "reviewer", task: "Review {target.path}", outputSchema: { type: "object" } },
 					collect: { as: "reviews" },
 				},
 			],
@@ -206,10 +206,10 @@ Review the diff
 			name: "accepted-chain",
 			description: "Chain with acceptance gates",
 			chain: [
-				{ agent: "builder", task: "Fix bug", acceptance: { level: "checked", evidence: ["changed-files", "commands-run"] } },
+				{ agent: "worker", task: "Fix bug", acceptance: { level: "checked", evidence: ["changed-files", "commands-run"] } },
 				{
 					parallel: [
-						{ agent: "commentator", task: "Review", acceptance: "attested" },
+						{ agent: "reviewer", task: "Review", acceptance: "attested" },
 					],
 				},
 			],
@@ -221,7 +221,7 @@ Review the diff
 			() => parseJsonChain(JSON.stringify({
 				name: "bad-acceptance",
 				description: "Bad acceptance",
-				chain: [{ agent: "builder", acceptance: { level: "none" } }],
+				chain: [{ agent: "worker", acceptance: { level: "none" } }],
 			}), "project", "/tmp/bad-acceptance.chain.json"),
 			/step 1 acceptance\.reason is required/,
 		);

package/dist/extensions/pi-subagents/test/unit/child-transcript.test.ts

@@ -21,7 +21,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "foreground",
 			runId: "run-1",
-			agent: "builder",
+			agent: "worker",
 			childIndex: 0,
 			cwd: "/repo",
 		});
@@ -35,7 +35,7 @@ describe("createChildTranscriptWriter", () => {
 		assert.equal(record.recordType, "message");
 		assert.equal(record.source, "foreground");
 		assert.equal(record.runId, "run-1");
-		assert.equal(record.agent, "builder");
+		assert.equal(record.agent, "worker");
 		assert.equal(record.childIndex, 0);
 		assert.equal(record.cwd, "/repo");
 		assert.equal(record.sourceEventType, "initial_prompt");
@@ -52,7 +52,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "async",
 			runId: "run-2",
-			agent: "commentator",
+			agent: "reviewer",
 			cwd: "/repo",
 		});
 		writer.writeInitialUserMessage("review it");
@@ -68,7 +68,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "async",
 			runId: "run-3",
-			agent: "builder",
+			agent: "worker",
 			childIndex: 1,
 			cwd: "/repo",
 		});
@@ -119,7 +119,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "foreground",
 			runId: "run-4",
-			agent: "builder",
+			agent: "worker",
 			cwd: "/repo",
 		});
 		writer.writeChildEvent({ type: "tool_execution_start", toolCallId: "call-1", toolName: "bash", args: { command: "ls" } });
@@ -152,7 +152,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "foreground",
 			runId: "run-bounded",
-			agent: "builder",
+			agent: "worker",
 			cwd: "/repo",
 		});
 		writer.writeChildEvent({ type: "tool_execution_start", toolCallId: "large", toolName: "bash", args: { command: "🧪".repeat(10_000) } });
@@ -178,7 +178,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "async",
 			runId: "run-5",
-			agent: "builder",
+			agent: "worker",
 			cwd: "/repo",
 		});
 		writer.writeStdoutLine("first line");
@@ -202,7 +202,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "foreground",
 			runId: "run-6",
-			agent: "builder",
+			agent: "worker",
 			cwd: "/repo",
 			maxBytes: 900,
 		});
@@ -254,7 +254,7 @@ describe("createChildTranscriptWriter", () => {
 			transcriptPath,
 			source: "foreground",
 			runId: "run-7",
-			agent: "builder",
+			agent: "worker",
 			cwd: "/repo",
 		});
 		writer.writeInitialUserMessage("should not be written");

package/dist/extensions/pi-subagents/test/unit/compaction-resume.test.ts

@@ -15,23 +15,53 @@ describe("async compaction resume", () => {
 			const handlers = new Map();
 			const events = { listeners: new Map(), on(name, handler) { this.listeners.set(name, handler); return () => this.listeners.delete(name); }, emit(name, payload) { this.listeners.get(name)?.(payload); } };
 			const sent = [];
+			const widgets = [];
+			let renders = 0;
 			const pi = new Proxy({
 				events,
 				on(name, handler) { handlers.set(name, handler); },
 				registerTool() {}, registerCommand() {}, registerShortcut() {}, registerMessageRenderer() {},
 				sendMessage(message, options) { sent.push({ message, options }); }, getSessionName() { return undefined; },
 			}, { get(target, prop) { return prop in target ? target[prop] : () => undefined; } });
-			const ctx = { cwd: process.cwd(), hasUI: true, ui: { setWidget() {}, requestRender() {}, theme: { fg(_name, text) { return text; }, bg(_name, text) { return text; }, bold(text) { return text; } } }, sessionManager: { getSessionId() { return "compact-session"; }, getSessionFile() { return null; }, getEntries() { return []; } }, modelRegistry: { getAvailable() { return []; } } };
+			const ctx = { cwd: process.cwd(), hasUI: true, ui: { setWidget(key, value) { widgets.push([key, value]); }, requestRender() { renders++; }, onTerminalInput() { return () => {}; }, getEditorText() { return ""; }, notify() {}, theme: { fg(_name, text) { return text; }, bg(_name, text) { return text; }, bold(text) { return text; } } }, sessionManager: { getSessionId() { return "compact-session"; }, getSessionFile() { return null; }, getEntries() { return []; } }, modelRegistry: { getAvailable() { return []; } } };
 			registerSubagentExtension(pi);
 			handlers.get("session_start")({}, ctx);
 			sent.length = 0;
-			events.emit("subagent:async-started", { id: "running", pid: 1, sessionId: "compact-session", mode: "single", agent: "builder", asyncDir: path.join(os.tmpdir(), "pi-compaction-test-running") });
-			handlers.get("session_compact")();
+			events.emit("subagent:async-started", { id: "running", pid: 1, sessionId: "compact-session", mode: "single", agent: "worker", asyncDir: path.join(os.tmpdir(), "pi-compaction-test-running") });
+			widgets.length = 0;
+			renders = 0;
+			handlers.get("session_before_compact")({ reason: "threshold", signal: new AbortController().signal });
+			const cleared = widgets.filter(([key, value]) => value === undefined).map(([key]) => key).sort();
+			if (JSON.stringify(cleared) !== JSON.stringify(["subagent-async", "subagent-fleet-status"])) throw new Error(JSON.stringify(widgets));
+			widgets.length = 0;
+			events.emit("subagent:async-complete", { id: "running", sessionId: "compact-session", agent: "worker", success: true, summary: "done" });
+			events.emit("subagent:async-started", { id: "running-2", pid: 2, sessionId: "compact-session", mode: "single", agent: "worker", asyncDir: path.join(os.tmpdir(), "pi-compaction-test-running-2") });
+			if (widgets.length !== 0 || renders !== 0) throw new Error("widgets repainted during compaction");
+			handlers.get("session_compact")({ reason: "threshold" });
+			if (widgets.length !== 0) throw new Error("widgets restored inside compaction hook");
+			handlers.get("agent_start")();
+			const restored = widgets.filter(([_, value]) => value !== undefined).map(([key]) => key).sort();
+			if (JSON.stringify(restored) !== JSON.stringify(["subagent-async", "subagent-fleet-status"])) throw new Error(JSON.stringify(widgets));
 			if (sent.length !== 1 || sent[0].options?.triggerTurn !== true || sent[0].message?.customType !== "subagent-compaction-resume") throw new Error(JSON.stringify(sent));
+
 			sent.length = 0;
-			events.emit("subagent:async-complete", { id: "running", sessionId: "compact-session", agent: "builder", success: true, summary: "done" });
-			handlers.get("session_compact")();
+			events.emit("subagent:async-complete", { id: "running-2", sessionId: "compact-session", agent: "worker", success: true, summary: "done" });
+			handlers.get("session_before_compact")({ reason: "threshold", signal: new AbortController().signal });
+			handlers.get("session_compact")({ reason: "threshold" });
+			handlers.get("agent_settled")();
 			if (sent.some((entry) => entry.message?.customType === "subagent-compaction-resume")) throw new Error("resumed without active work");
+
+			events.emit("subagent:async-started", { id: "running-3", pid: 3, sessionId: "compact-session", mode: "single", agent: "worker", asyncDir: path.join(os.tmpdir(), "pi-compaction-test-running-3") });
+			widgets.length = 0;
+			handlers.get("session_before_compact")({ reason: "overflow", signal: new AbortController().signal });
+			widgets.length = 0;
+			handlers.get("agent_settled")();
+			if (!widgets.some(([_, value]) => value !== undefined)) throw new Error("widgets did not recover after compaction failure");
+
+			widgets.length = 0;
+			handlers.get("session_before_compact")({ reason: "manual", signal: new AbortController().signal });
+			if (widgets.length !== 0) throw new Error("manual compaction changed widget state");
+			await handlers.get("session_shutdown")();
 		`;
 		const env = { ...process.env };
 		delete env.SELESAI_SUBAGENT_CHILD;

package/dist/extensions/pi-subagents/test/unit/completion-dedupe.test.ts

@@ -11,8 +11,8 @@ describe("buildCompletionKey", () => {
 	});
 
 	it("builds deterministic fallback key when id is missing", () => {
-		const first = buildCompletionKey({ agent: "commentator", timestamp: 123, taskIndex: 1, totalTasks: 2, success: true }, "x");
-		const second = buildCompletionKey({ agent: "commentator", timestamp: 123, taskIndex: 1, totalTasks: 2, success: true }, "x");
+		const first = buildCompletionKey({ agent: "reviewer", timestamp: 123, taskIndex: 1, totalTasks: 2, success: true }, "x");
+		const second = buildCompletionKey({ agent: "reviewer", timestamp: 123, taskIndex: 1, totalTasks: 2, success: true }, "x");
 		assert.equal(first, second);
 	});
 });