@selesai/code 0.8.3 → 0.8.5

package/dist/extensions/pi-subagents/test/integration/slash-commands.test.ts

@@ -3,6 +3,7 @@ import * as fs from "node:fs";
 import * as os from "node:os";
 import * as path from "node:path";
 import { beforeEach, describe, it } from "node:test";
+import { visibleWidth } from "@earendil-works/pi-tui";
 
 import { scheduledRunStorePath } from "../../src/runs/background/scheduled-runs.ts";
 import { SUBAGENT_FANOUT_CHILD_ENV } from "../../src/runs/shared/pi-args.ts";
@@ -115,17 +116,17 @@ function createState(cwd: string) {
 
 async function withIsolatedHome<T>(fn: () => Promise<T>): Promise<T> {
 	const home = fs.mkdtempSync(path.join(os.tmpdir(), "pi-slash-home-"));
-	const previousAgentDir = process.env.SELESAI_CODING_AGENT_DIR;
+	const previousAgentDir = process.env.PI_CODING_AGENT_DIR;
 	const previousHome = process.env.HOME;
 	const previousUserProfile = process.env.USERPROFILE;
-	process.env.SELESAI_CODING_AGENT_DIR = path.join(home, ".selesai", "agent");
+	process.env.PI_CODING_AGENT_DIR = path.join(home, ".selesai", "agent");
 	process.env.HOME = home;
 	process.env.USERPROFILE = home;
 	try {
 		return await fn();
 	} finally {
-		if (previousAgentDir === undefined) delete process.env.SELESAI_CODING_AGENT_DIR;
-		else process.env.SELESAI_CODING_AGENT_DIR = previousAgentDir;
+		if (previousAgentDir === undefined) delete process.env.PI_CODING_AGENT_DIR;
+		else process.env.PI_CODING_AGENT_DIR = previousAgentDir;
 		if (previousHome === undefined) delete process.env.HOME;
 		else process.env.HOME = previousHome;
 		if (previousUserProfile === undefined) delete process.env.USERPROFILE;
@@ -242,6 +243,7 @@ async function captureSlashCommandParams(
 
 		const pi = {
 			events,
+			on() {},
 			registerCommand(name: string, spec: RegisteredSlashCommand) {
 				commands.set(name, spec);
 			},
@@ -364,7 +366,7 @@ describe("subagents watchdog slash command", { skip: !available ? "watchdog comm
 				fs.writeFileSync(settingsPath, JSON.stringify({
 					other: true,
 					subagents: {
-						agentOverrides: { explorer: { model: "openai/test" } },
+						agentOverrides: { scout: { model: "openai/test" } },
 						watchdog: { agentEndTimeoutMs: 1234, main: { enabled: false, model: "openai/watchdog" } },
 					},
 				}, null, 2), "utf-8");
@@ -375,7 +377,7 @@ describe("subagents watchdog slash command", { skip: !available ? "watchdog comm
 				await commands.get("subagents-watchdog")!.handler("on", createCommandContext({ cwd: root }));
 				let settings = JSON.parse(fs.readFileSync(settingsPath, "utf-8"));
 				assert.equal(settings.other, true);
-				assert.equal(settings.subagents.agentOverrides.explorer.model, "openai/test");
+				assert.equal(settings.subagents.agentOverrides.scout.model, "openai/test");
 				assert.equal(settings.subagents.watchdog.agentEndTimeoutMs, 1234);
 				assert.equal(settings.subagents.watchdog.enabled, true);
 				assert.equal(settings.subagents.watchdog.main.enabled, true);
@@ -478,6 +480,65 @@ describe("slash command custom message delivery", { skip: !available ? "slash-co
 		clearSlashSnapshots?.();
 	});
 
+	it("/subagents-stop keeps the selector within its allocated width", async () => {
+		await withTempProject("pi-stop-selector-width-", async (root) => {
+			const id = "scheduled-width-check";
+			const nextRunAt = "2099-01-01T00:00:00.000Z";
+			const scheduleDir = path.join(scheduledRunStorePath(root), id);
+			fs.mkdirSync(scheduleDir, { recursive: true });
+			fs.writeFileSync(path.join(scheduleDir, "schedule.json"), JSON.stringify({
+				schemaVersion: 1,
+				id,
+				name: "A very long scheduled run name with wide characters 中文🙂",
+				cwd: root,
+				trigger: { kind: "once", at: nextRunAt, nextRunAt },
+				target: { agent: "scout", task: "Inspect" },
+				overlap: "skip",
+				catchUp: "latest",
+				paused: false,
+				createdAt: "2026-08-06T00:00:00.000Z",
+				updatedAt: "2026-08-06T00:00:00.000Z",
+			}), "utf-8");
+
+			const commands = new Map<string, RegisteredSlashCommand>();
+			const pi = {
+				events: createEventBus(),
+				on() {},
+				registerCommand(name: string, spec: RegisteredSlashCommand) { commands.set(name, spec); },
+				registerShortcut() {},
+				sendMessage() {},
+			};
+			const rendered = new Map<number, string[]>();
+			registerSlashCommands!(pi as never, createState(root));
+			await commands.get("subagents-stop")!.handler("", createCommandContext({
+				cwd: root,
+				hasUI: true,
+				custom: async (factory) => {
+					const component = (factory as (
+						tui: { requestRender(): void },
+						theme: { fg(name: string, text: string): string; bold(text: string): string },
+						keybindings: unknown,
+						done: (result: unknown) => void,
+					) => { render(width: number): string[] })(
+						{ requestRender() {} },
+						{ fg: (_name, text) => text, bold: (text) => text },
+						{},
+						() => {},
+					);
+					for (const width of [0, 1, 2, 3, 32]) rendered.set(width, component.render(width));
+					return undefined;
+				},
+			}));
+
+			for (const [width, lines] of rendered) {
+				assert.ok(lines.length > 0);
+				for (const line of lines) {
+					assert.ok(visibleWidth(line) <= width, `stop selector line exceeds render width: ${visibleWidth(line)} > ${width}`);
+				}
+			}
+		});
+	});
+
 	it("/run accepts an agent without a task", async () => {
 		const sent: unknown[] = [];
 		const commands = new Map<string, { handler(args: string, ctx: unknown): Promise<void> }>();
@@ -509,6 +570,7 @@ describe("slash command custom message delivery", { skip: !available ? "slash-co
 
 		const pi = {
 			events,
+			on() {},
 			registerCommand(name: string, spec: { handler(args: string, ctx: unknown): Promise<void> }) {
 				commands.set(name, spec);
 			},
@@ -520,10 +582,10 @@ describe("slash command custom message delivery", { skip: !available ? "slash-co
 
 		const ctx = createCommandContext({ sessionManager });
 		registerSlashCommands!(pi, createState(process.cwd()));
-		await commands.get("run")!.handler("explorer", ctx);
+		await commands.get("run")!.handler("scout", ctx);
 		await new Promise<void>((resolve) => setImmediate(resolve));
 
-		assert.deepEqual(requestedParams, { agent: "explorer", task: "", clarify: false, agentScope: "both" });
+		assert.deepEqual(requestedParams, { workflowScript: "return runs.run(\"run\", {\"agent\":\"scout\",\"task\":\"\",\"agentScope\":\"both\"})", async: false });
 		assert.equal(requestedCtx, ctx);
 		assert.equal(sent.length, 2);
 		assert.equal((sent[0] as { display?: boolean }).display, true);
@@ -534,6 +596,25 @@ describe("slash command custom message delivery", { skip: !available ? "slash-co
 		assert.equal(sessionManager.flushed, true);
 	});
 
+	it("/run preserves existing relative reads and omits missing reads", async () => {
+		await withTempProject("pi-slash-reads-", async (root) => {
+			fs.writeFileSync(path.join(root, ".selesai", "agents", "scout.md"), `---
+name: scout
+description: Scout
+---
+
+Inspect
+`, "utf-8");
+			fs.writeFileSync(path.join(root, "context.md"), "context");
+
+			const run = await captureSlashCommandParams("run", "scout[reads=context.md+missing.md] Inspect", root);
+			assert.deepEqual(run.params, {
+				workflowScript: "return runs.run(\"run\", {\"agent\":\"scout\",\"task\":\"[Read from: context.md]\\n\\nInspect\",\"agentScope\":\"both\"})",
+				async: false,
+			});
+		});
+	});
+
 	it("/run finalizes the slash snapshot before the last UI redraw on success", async () => {
 		const sent: unknown[] = [];
 		const log: string[] = [];
@@ -554,6 +635,7 @@ describe("slash command custom message delivery", { skip: !available ? "slash-co
 
 		const pi = {
 			events,
+			on() {},
 			registerCommand(name: string, spec: { handler(args: string, ctx: unknown): Promise<void> }) {
 				commands.set(name, spec);
 			},
@@ -565,7 +647,7 @@ describe("slash command custom message delivery", { skip: !available ? "slash-co
 		};
 
 		registerSlashCommands!(pi, createState(process.cwd()));
-		await commands.get("run")!.handler("explorer inspect this", createCommandContext({
+		await commands.get("run")!.handler("scout inspect this", createCommandContext({
 			hasUI: true,
 			setStatus: (_key, text) => {
 				log.push(`status:${text ?? "clear"}`);
@@ -605,6 +687,7 @@ describe("slash command custom message delivery", { skip: !available ? "slash-co
 
 		const pi = {
 			events,
+			on() {},
 			registerCommand(name: string, spec: { handler(args: string, ctx: unknown): Promise<void> }) {
 				commands.set(name, spec);
 			},
@@ -615,7 +698,7 @@ describe("slash command custom message delivery", { skip: !available ? "slash-co
 		};
 
 		registerSlashCommands!(pi, createState(process.cwd()));
-		await commands.get("run")!.handler("explorer inspect this", createCommandContext({
+		await commands.get("run")!.handler("scout inspect this", createCommandContext({
 			hasUI: true,
 			setToolsExpanded: (expanded) => log.push(`expanded:${String(expanded)}`),
 		}));
@@ -644,6 +727,7 @@ describe("slash command custom message delivery", { skip: !available ? "slash-co
 
 		const pi = {
 			events,
+			on() {},
 			registerCommand(name: string, spec: { handler(args: string, ctx: unknown): Promise<void> }) {
 				commands.set(name, spec);
 			},
@@ -655,7 +739,7 @@ describe("slash command custom message delivery", { skip: !available ? "slash-co
 		};
 
 		registerSlashCommands!(pi, createState(process.cwd()));
-		await commands.get("run")!.handler("explorer inspect this", createCommandContext({
+		await commands.get("run")!.handler("scout inspect this", createCommandContext({
 			hasUI: true,
 			setStatus: (_key, text) => {
 				log.push(`status:${text ?? "clear"}`);
@@ -680,8 +764,8 @@ describe("slash command custom message delivery", { skip: !available ? "slash-co
 
 	it("/run accepts dotted packaged runtime agent names", async () => {
 		await withTempProject("pi-packaged-agent-slash-", async (root) => {
-			fs.writeFileSync(path.join(root, ".selesai", "agents", "code-analysis.explorer.md"), `---
-name: explorer
+			fs.writeFileSync(path.join(root, ".selesai", "agents", "code-analysis.scout.md"), `---
+name: scout
 package: code-analysis
 description: Fast recon
 ---
@@ -689,33 +773,36 @@ description: Fast recon
 Inspect
 `, "utf-8");
 
-			const run = await captureSlashCommandParams("run", "code-analysis.explorer Investigate", root);
-			assert.deepEqual(run.params, { agent: "code-analysis.explorer", task: "Investigate", clarify: false, agentScope: "both" });
+			const run = await captureSlashCommandParams("run", "code-analysis.scout Investigate", root);
+			assert.deepEqual(run.params, { workflowScript: "return runs.run(\"run\", {\"agent\":\"code-analysis.scout\",\"task\":\"Investigate\",\"agentScope\":\"both\"})", async: false });
 
 			await withIsolatedHome(async () => {
 				const commands = new Map<string, RegisteredSlashCommand>();
 				registerSlashCommands!({
 					events: createEventBus(),
+					on() {},
 					registerCommand(name: string, spec: RegisteredSlashCommand) { commands.set(name, spec); },
 					registerShortcut() {},
 					sendMessage() {},
 				} as never, createState(root));
 				const completions = commands.get("run")!.getArgumentCompletions!("code-") as Array<{ value: string }>;
-				assert.deepEqual(completions.map(({ value }) => value), ["code-analysis.explorer"]);
+				assert.deepEqual(completions.map(({ value }) => value), ["code-analysis.scout"]);
 			});
 		});
 	});
 
-	it("does not register legacy orchestration commands", async () => {
+	it("registers the Selesai-native chain/parallel orchestration commands", async () => {
 		const commands = new Map<string, unknown>();
 		registerSlashCommands!({
+			on() {},
 			registerCommand(name: string, command: unknown) { commands.set(name, command); },
 			registerShortcut() {},
 			events: createEventBus(),
 		} as never, { baseCwd: process.cwd() } as never);
 		assert.equal(commands.has("run"), true);
-		assert.equal(commands.has("chain"), false);
-		assert.equal(commands.has("parallel"), false);
-		assert.equal(commands.has("run-chain"), false);
+		assert.equal(commands.has("chain"), true);
+		assert.equal(commands.has("parallel"), true);
+		assert.equal(commands.has("run-chain"), true);
+		assert.equal(commands.has("chain-prompts"), true);
 	});
 });

package/dist/extensions/pi-subagents/test/integration/slash-live-state.test.ts

@@ -34,7 +34,7 @@ describe("slash live state", { skip: !available ? "slash-live-state.ts not impor
 	it("streams progress updates into the visible slash snapshot", () => {
 		clearSlashSnapshots!();
 		const details = buildSlashInitialResult!("req-1", {
-			agent: "explorer",
+			agent: "scout",
 			task: "scan codebase",
 		});
 
@@ -43,7 +43,7 @@ describe("slash live state", { skip: !available ? "slash-live-state.ts not impor
 			currentTool: "find",
 			toolCount: 2,
 			progress: [{
-				agent: "explorer",
+				agent: "scout",
 				status: "running",
 				task: "scan codebase",
 				currentTool: "find",
@@ -66,14 +66,14 @@ describe("slash live state", { skip: !available ? "slash-live-state.ts not impor
 	it("does not assign a parallel child update to another chain placeholder", () => {
 		clearSlashSnapshots!();
 		const details = buildSlashInitialResult!("req-parallel", {
-			chain: [{ parallel: [{ agent: "explorer", task: "map" }, { agent: "explorer", task: "analyze" }] }],
+			chain: [{ parallel: [{ agent: "scout", task: "map" }, { agent: "context-builder", task: "analyze" }] }],
 		});
 
 		applySlashUpdate!("req-parallel", {
 			requestId: "req-parallel",
 			progress: [{
 				index: 1,
-				agent: "explorer",
+				agent: "context-builder",
 				status: "running",
 				task: "analyze",
 				currentTool: "find",
@@ -90,10 +90,10 @@ describe("slash live state", { skip: !available ? "slash-live-state.ts not impor
 		assert.equal(results[1]?.progress?.currentTool, "find");
 	});
 
-	it("creates stable placeholders for a 40-step builder/commentator chain", () => {
+	it("creates stable placeholders for a 40-step worker/reviewer chain", () => {
 		clearSlashSnapshots!();
 		const chain = Array.from({ length: 40 }, (_, index) => ({
-			agent: index % 2 === 0 ? "builder" : "commentator",
+			agent: index % 2 === 0 ? "worker" : "reviewer",
 			...(index === 0 ? { task: "Start long chain" } : {}),
 		}));
 
@@ -106,14 +106,14 @@ describe("slash live state", { skip: !available ? "slash-live-state.ts not impor
 		assert.equal(details.result.details.totalSteps, 40);
 		assert.equal(details.result.details.currentStepIndex, 0);
 		assert.equal(details.result.details.results[0]?.progress?.status, "running");
-		assert.equal(details.result.details.results[39]?.agent, "commentator");
+		assert.equal(details.result.details.results[39]?.agent, "reviewer");
 		assert.equal(details.result.details.results[39]?.progress?.index, 39);
 	});
 
 	it("prefers finalized snapshots and restores them from persisted custom messages", () => {
 		clearSlashSnapshots!();
 		const details = buildSlashInitialResult!("req-2", {
-			agent: "explorer",
+			agent: "scout",
 			task: "scan codebase",
 		});
 
@@ -124,7 +124,7 @@ describe("slash live state", { skip: !available ? "slash-live-state.ts not impor
 				details: {
 					mode: "single",
 					results: [{
-						agent: "explorer",
+						agent: "scout",
 						task: "scan codebase",
 						exitCode: 0,
 						messages: [],

package/dist/extensions/pi-subagents/test/integration/template-resolution.test.ts

@@ -75,7 +75,7 @@ describe("resolveChainTemplates", { skip: !available ? "pi packages not availabl
 
 	it("mixed sequential + parallel", () => {
 		const chain = [
-			{ agent: "explorer", task: "Scan" },
+			{ agent: "scout", task: "Scan" },
 			{
 				parallel: [
 					{ agent: "rev-a", task: "Deep review A" },
@@ -171,6 +171,14 @@ describe("resolveStepBehavior", { skip: !available ? "pi packages not available"
 		assert.equal(behavior.output, false);
 	});
 
+	it("ignores boolean and string true output overrides", () => {
+		const config = { name: "test", output: "report.md" };
+		assert.equal(resolveStepBehavior(config, { output: true }).output, "report.md");
+		assert.equal(resolveStepBehavior(config, { output: "true" }).output, "report.md");
+		assert.equal(resolveStepBehavior({ name: "test" }, { output: true }).output, false);
+		assert.equal(resolveStepBehavior({ name: "test" }, { output: "true" }).output, false);
+	});
+
 	it("defaults to false when agent has no config", () => {
 		const config = { name: "test" };
 		const behavior = resolveStepBehavior(config, {});
@@ -183,8 +191,8 @@ describe("resolveStepBehavior", { skip: !available ? "pi packages not available"
 describe("resolveParallelBehaviors", { skip: !available ? "pi packages not available" : undefined }, () => {
 	it("string false agent default disables output in chain parallel tasks", () => {
 		const behaviors = resolveParallelBehaviors(
-			[{ agent: "commentator", task: "Review" }],
-			[{ name: "commentator", output: "false" }],
+			[{ agent: "reviewer", task: "Review" }],
+			[{ name: "reviewer", output: "false" }],
 			0,
 		);
 
@@ -206,13 +214,25 @@ describe("read-only progress suppression", { skip: !available ? "pi packages not
 });
 
 describe("buildChainInstructions", { skip: !available ? "pi packages not available" : undefined }, () => {
-	it("adds [Read from:] prefix for reads", () => {
-		const behavior = { reads: ["context.md"], output: false, outputMode: "inline", progress: false, skills: undefined };
+	it("includes existing reads and omits missing reads", () => {
+		const behavior = { reads: ["context.md", "missing.md"], output: false, outputMode: "inline", progress: false, skills: undefined };
 		const dir = createTempDir("chain-test-");
 		try {
+			fs.writeFileSync(path.join(dir, "context.md"), "context");
 			const { prefix } = buildChainInstructions(behavior, dir, false);
 			assert.ok(prefix.includes("[Read from:"), `should have Read instruction: ${prefix}`);
-			assert.ok(prefix.includes("context.md"), "should reference the file");
+			assert.ok(prefix.includes("context.md"), "should reference the existing file");
+			assert.doesNotMatch(prefix, /missing\.md/);
+		} finally {
+			removeTempDir(dir);
+		}
+	});
+
+	it("omits the read prefix when all configured reads are missing", () => {
+		const behavior = { reads: ["missing.md"], output: false, outputMode: "inline", progress: false, skills: undefined };
+		const dir = createTempDir("chain-test-");
+		try {
+			assert.doesNotMatch(buildChainInstructions(behavior, dir, false).prefix, /\[Read from:/);
 		} finally {
 			removeTempDir(dir);
 		}

package/dist/extensions/pi-subagents/test/integration/top-level-async.test.ts

@@ -15,12 +15,12 @@ const available = !!mod;
 
 describe("force top-level async helper", { skip: !available ? "pi packages not available" : undefined }, () => {
 	it("forces top-level calls async and disables clarify", () => {
-		const params = { async: false, clarify: true, agent: "builder" };
+		const params = { async: false, clarify: true, agent: "worker" };
 		const next = mod!.applyForceTopLevelAsyncOverride(params, 0, true);
 		assert.notEqual(next, params);
 		assert.equal(next.async, true);
 		assert.equal(next.clarify, false);
-		assert.equal(next.agent, "builder");
+		assert.equal(next.agent, "worker");
 	});
 
 	it("keeps bridge-owned foreground calls attached", () => {

package/dist/extensions/pi-subagents/test/support/helpers.ts

@@ -43,7 +43,9 @@ export function createEventBus() {
 
 interface AgentConfig {
 	name: string;
+	aliases?: string[];
 	description?: string;
+	defaultContext?: "fresh" | "fork";
 	systemPrompt?: string;
 	model?: string;
 	fallbackModels?: string[];

package/dist/extensions/pi-subagents/test/support/mock-pi-script.mjs

@@ -337,7 +337,7 @@ async function main() {
 	writeToolDiagnostic(response);
 	const callPath = path.join(queueDir, `call-${Date.now()}-${process.pid}-${Math.random().toString(16).slice(2)}.json`);
 	const callTempPath = `${callPath}.tmp-${process.pid}-${Date.now()}`;
-	fs.writeFileSync(callTempPath, JSON.stringify({ args, systemPrompts: readSystemPromptRecords(args) }), "utf-8");
+	fs.writeFileSync(callTempPath, JSON.stringify({ args, cwd: process.cwd(), systemPrompts: readSystemPromptRecords(args) }), "utf-8");
 	fs.renameSync(callTempPath, callPath);
 
 	if (typeof response.delay === "number" && response.delay > 0) {

package/dist/extensions/pi-subagents/test/support/ts-loader.mjs

@@ -6,11 +6,6 @@ import * as fs from "node:fs";
 import * as path from "node:path";
 import { fileURLToPath } from "node:url";
 
-const renderPiCodingAgentShim = `
-export function getMarkdownTheme() { return {}; }
-export function keyText(keybinding) { return keybinding === "app.tools.expand" ? "configured-expand-key" : ""; }
-`;
-
 const renderPiTuiShim = `
 function wrapText(text, width) {
   if (!width || width <= 0) return [text];
@@ -82,9 +77,6 @@ function asDataModule(source) {
 
 export function resolve(specifier, context, nextResolve) {
   if (context.parentURL?.endsWith("/render.ts")) {
-    if (specifier === "@selesai/code") {
-      return { url: asDataModule(renderPiCodingAgentShim), shortCircuit: true };
-    }
     if (specifier === "@earendil-works/pi-tui") {
       return { url: asDataModule(renderPiTuiShim), shortCircuit: true };
     }